[Bug 1387131] Review Request: golang-github-pkg-sftp - SFTP support for the go.crypto/ssh package

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1387131



--- Comment #10 from Fedora Update System  ---
golang-github-pkg-sftp-0-0.1.git8197a2e.fc25 has been pushed to the Fedora 25
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-9f43b78a5c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1387178] Review Request: golang-github-pelletier-go-buffruneio - Wrapper around bufio to provide buffered runes access with unlimited unreads

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1387178



--- Comment #9 from Fedora Update System  ---
golang-github-pelletier-go-buffruneio-0-0.1.gitdf1e16f.fc25 has been pushed to
the Fedora 25 testing repository. If problems still persist, please make note
of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-4820a57257

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1409929] Review Request: python-sqlalchemy_schemadisplay - Turn SQLAlchemy DB Model into a graph

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1409929



--- Comment #7 from Fedora Update System  ---
python-sqlalchemy_schemadisplay-1.3-1.fc25 has been pushed to the Fedora 25
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-5c5965a67c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1387115] Review Request: golang-github-pkg-errors - Simple error handling primitives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1387115



--- Comment #13 from Fedora Update System  ---
golang-github-pkg-errors-0.7.1-0.2.gita887431.fc25 has been pushed to the
Fedora 25 testing repository. If problems still persist, please make note of it
in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-56a23c5467

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1411954] Review Request: pandora-wallpapers - Wallpapers for elementary's Pantheon desktop

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1411954

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #4 from Fedora Update System  ---
pandora-wallpapers-0.1.4-1.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-a1ead18e49

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1411957] Review Request: pantheon-files - Pantheon file manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1411957

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #6 from Fedora Update System  ---
pantheon-files-0.3.0.5-3.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-e0bb3a9d92

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1411066] Review Request: python-shortuuid - A generator library for concise, unambiguous and URL-safe UUIDs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1411066



--- Comment #2 from Peter Robinson  ---
Thanks!

> It would be nice to be more verbose on python3 packages %files section to

I'll tighten that up before initial commit.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1387131] Review Request: golang-github-pkg-sftp - SFTP support for the go.crypto/ssh package

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1387131



--- Comment #9 from Fedora Update System  ---
golang-github-pkg-sftp-0-0.1.git8197a2e.fc24 has been pushed to the Fedora 24
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-e9e4ea4d45

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1409929] Review Request: python-sqlalchemy_schemadisplay - Turn SQLAlchemy DB Model into a graph

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1409929

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #6 from Fedora Update System  ---
python-sqlalchemy_schemadisplay-1.3-1.fc24 has been pushed to the Fedora 24
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-e54acedb77

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1387115] Review Request: golang-github-pkg-errors - Simple error handling primitives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1387115



--- Comment #12 from Fedora Update System  ---
golang-github-pkg-errors-0.7.1-0.2.gita887431.fc24 has been pushed to the
Fedora 24 testing repository. If problems still persist, please make note of it
in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-861a82f5f1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1387178] Review Request: golang-github-pelletier-go-buffruneio - Wrapper around bufio to provide buffered runes access with unlimited unreads

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1387178



--- Comment #8 from Fedora Update System  ---
golang-github-pelletier-go-buffruneio-0-0.1.gitdf1e16f.fc24 has been pushed to
the Fedora 24 testing repository. If problems still persist, please make note
of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-6936f7819d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1219662] Review Request: python-terminado - Terminals served to term.js using Tornado websockets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219662



--- Comment #15 from Tim Orling  ---
Confirmed that William is busy, so I will continue with the review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1219662] Review Request: python-terminado - Terminals served to term.js using Tornado websockets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219662

Tim Orling  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1148447] Review Request: golang-github-kr-fs - Provides Go filesystem-related functions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1148447

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|ERRATA  |---
   Keywords||Reopened



--- Comment #20 from Fedora Update System  ---
golang-github-kr-fs-0-0.8.git2788f0d.el6 has been pushed to the Fedora EPEL 6
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-319487df96

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1387115] Review Request: golang-github-pkg-errors - Simple error handling primitives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1387115

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #11 from Fedora Update System  ---
golang-github-pkg-errors-0.7.1-0.2.gita887431.el6 has been pushed to the Fedora
EPEL 6 testing repository. If problems still persist, please make note of it in
this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-b881eef27b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1387131] Review Request: golang-github-pkg-sftp - SFTP support for the go.crypto/ssh package

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1387131

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #8 from Fedora Update System  ---
golang-github-pkg-sftp-0-0.1.git8197a2e.el6 has been pushed to the Fedora EPEL
6 testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-0a52c655ae

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1387178] Review Request: golang-github-pelletier-go-buffruneio - Wrapper around bufio to provide buffered runes access with unlimited unreads

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1387178

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #7 from Fedora Update System  ---
golang-github-pelletier-go-buffruneio-0-0.1.gitdf1e16f.el6 has been pushed to
the Fedora EPEL 6 testing repository. If problems still persist, please make
note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-a7eba3c01a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1409241] Review Request: ufw - Uncomplicated Firewall

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1409241



--- Comment #17 from Fedora Update System  ---
ufw-0.35-7.fc24 has been pushed to the Fedora 24 stable repository. If problems
still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1409314] Review Request: python-pytaglib - Python audio metadata (" tagging") library based on TagLib

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1409314



--- Comment #11 from Fedora Update System  ---
python-pytaglib-1.4.0-1.fc24 has been pushed to the Fedora 24 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1409451] Review Request: python-daemonize - Library for writing system daemons in Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1409451



--- Comment #9 from Fedora Update System  ---
python-daemonize-2.4.7-1.fc24 has been pushed to the Fedora 24 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1398965] Review Request: python-aioodbc - Library for accessing a ODBC databases from the asyncio

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1398965



--- Comment #11 from Fedora Update System  ---
python-aioodbc-0.0.3-1.fc24 has been pushed to the Fedora 24 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1411438] Review Request: arc-theme - Flat theme with transparent elements

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1411438

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-01-12 00:24:45



--- Comment #12 from Fedora Update System  ---
arc-theme-20161119-1.fc25 has been pushed to the Fedora 25 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1409387] Review Request: python-sanic - Microframework based on uvloop, httptools, and learnings of flask

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1409387
Bug 1409387 depends on bug 1409386, which changed state.

Bug 1409386 Summary: Review Request: python-uvloop - Ultra fast implementation 
of asyncio event loop on top of libuv
https://bugzilla.redhat.com/show_bug.cgi?id=1409386

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1409387] Review Request: python-sanic - Microframework based on uvloop, httptools, and learnings of flask

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1409387

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-01-12 00:23:52



--- Comment #8 from Fedora Update System  ---
python-sanic-0.1.9-1.fc25 has been pushed to the Fedora 25 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1409314] Review Request: python-pytaglib - Python audio metadata (" tagging") library based on TagLib

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1409314

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-01-12 00:23:55



--- Comment #10 from Fedora Update System  ---
python-pytaglib-1.4.0-1.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1409387] Review Request: python-sanic - Microframework based on uvloop, httptools, and learnings of flask

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1409387
Bug 1409387 depends on bug 1409384, which changed state.

Bug 1409384 Summary: Review Request: python-httptools - Fast HTTP parser
https://bugzilla.redhat.com/show_bug.cgi?id=1409384

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1398965] Review Request: python-aioodbc - Library for accessing a ODBC databases from the asyncio

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1398965

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-01-12 00:23:20



--- Comment #10 from Fedora Update System  ---
python-aioodbc-0.0.3-1.fc25 has been pushed to the Fedora 25 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1408869] Review Request: python-vine - Promises, promises, promises

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1408869
Bug 1408869 depends on bug 1408868, which changed state.

Bug 1408868 Summary: Review Request: python-case - Python unittest Utilities
https://bugzilla.redhat.com/show_bug.cgi?id=1408868

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1408868] Review Request: python-case - Python unittest Utilities

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1408868

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-01-12 00:23:34



--- Comment #11 from Fedora Update System  ---
python-case-1.5.2-2.fc25 has been pushed to the Fedora 25 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1409386] Review Request: python-uvloop - Ultra fast implementation of asyncio event loop on top of libuv

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1409386

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-01-12 00:23:48



--- Comment #6 from Fedora Update System  ---
python-uvloop-0.7.1-1.fc25 has been pushed to the Fedora 25 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1409241] Review Request: ufw - Uncomplicated Firewall

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1409241

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-01-12 00:23:26



--- Comment #16 from Fedora Update System  ---
ufw-0.35-7.fc25 has been pushed to the Fedora 25 stable repository. If problems
still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1409384] Review Request: python-httptools - Fast HTTP parser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1409384

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-01-12 00:23:15



--- Comment #6 from Fedora Update System  ---
python-httptools-0.0.9-2.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1409451] Review Request: python-daemonize - Library for writing system daemons in Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1409451

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-01-12 00:23:23



--- Comment #8 from Fedora Update System  ---
python-daemonize-2.4.7-1.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1409378] Review Request: python-aiofiles - File support for asyncio

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1409378

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-01-12 00:23:10



--- Comment #6 from Fedora Update System  ---
python-aiofiles-0.3.0-1.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1409387] Review Request: python-sanic - Microframework based on uvloop, httptools, and learnings of flask

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1409387
Bug 1409387 depends on bug 1409378, which changed state.

Bug 1409378 Summary: Review Request: python-aiofiles - File support for asyncio
https://bugzilla.redhat.com/show_bug.cgi?id=1409378

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1391334] Review Request: freeorion - Turn-based space empire and galactic conquest (4X) computer game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391334

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-01-12 00:22:36



--- Comment #20 from Fedora Update System  ---
freeorion-0.4.6-5.fc25 has been pushed to the Fedora 25 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1403600] Review Request: YafaRay - A free open-source raytracing render engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1403600



--- Comment #2 from Michael Schwendt  ---
> Source0:
> Source1:

404 not found


> %package blender
> Summary: Blender integration scripts
> Requires: %{name} = %{version}-%{release}

Since there are arch-specific builds in these packages:
https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package


> The build will not work but I think this is a place to provide
> guidance and suggestion.

Uhm, the build will not work? Why submit a package for review that doesn't even
try to build, because the top sourcedir isn't found?

  RPM build errors:
  + cd YafaRay-3.1.1
  /var/tmp/rpm-tmp.p0hraO: line 37: cd: YafaRay-3.1.1: No such file or
directory

Obviously, you need to adjust the name of the top sourcedir, which is
Core-3.1.1-beta and not the default %{name}-%{version}.

You haven't even mentioned anything in the %changelog about the upgrade from
0.0.1 to 3.1.1 Beta.


> %{_libdir}/%{yname}/*.so
> %{_libdir}/libyafaraycore.so

https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership
https://fedoraproject.org/wiki/Packaging:UnownedDirectories

Also for both [sub]packages and the libs installed into global %{_libdir}:
https://fedoraproject.org/wiki/Packaging:Guidelines#Shared_Libraries

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1409780] Review Request: golang-github-hanwen-go-fuse - FUSE bindings for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1409780



--- Comment #7 from Michael Schwendt  ---
> Version:0
> Release:1.git%{shortcommit}%{?dist}

Now that you've changed "Version" to something more sane and have added a
different git snapshot, you really want to skim over the snapshot versioning
guidelines as mentioned before:

  https://fedoraproject.org/wiki/Packaging:Versioning


> Group:  Development/Libraries

https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections


> %description
> %{summary}

> %package devel
> Summary:   %{summary}

> %description devel
> %{summary}

Hmmm? Same %summary in all these places? That's odd, isn't it?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1411066] Review Request: python-shortuuid - A generator library for concise, unambiguous and URL-safe UUIDs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1411066

Athos Ribeiro  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Athos Ribeiro  ---
Hi Peter,

Your package looks good: approved.

When installing the python2-* subpackage I realized that /usr/bin/python2.7 was
not installed. At first I thought there was a problem with the package, but it
does require python(abi) = 2.7.

There is a new python2 package in rawhide and its python2-libs subpackage is
providing python(abi) for some reason, which makes mock happy enough not
installing /usr/bin/python2.7

It would be nice to be more verbose on python3 packages %files section to avoid
owning unwanted files. Some people forget about that and end up owning
'/usr/lib/python3.MINOR/site-packages/__pycache__'
which right now is the case of 42 packages for python3.6.
According to the guidelines, this directory should belong to
system-python-libs.

Finally, rpmlint complains about python3.6 magic numbers. This is a known boug
reported here: https://bugzilla.redhat.com/show_bug.cgi?id=1409376

Here is fedora-review output:

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the 

[Bug 1407000] Review Request: python-pulp - LP modeler written in python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1407000



--- Comment #10 from Alan Pevec  ---
ok, fedora-review is not that smart "MIT/X11 (BSD like)" is not listed at
https://fedoraproject.org/wiki/Licensing:Main#Software_License_List
It should be simply License: MIT
LICENSE text matches
https://fedoraproject.org/wiki/Licensing:MIT?rd=Licensing/MIT#Modern_Style_with_sublicense

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1411066] Review Request: python-shortuuid - A generator library for concise, unambiguous and URL-safe UUIDs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1411066

Athos Ribeiro  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||athoscribe...@gmail.com
   Assignee|nob...@fedoraproject.org|athoscribe...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1412252] Review Request: compat-readline6 - Compatibility package for Readline 6

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1412252

Igor Gnatenko  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags||fedora-review+



--- Comment #1 from Igor Gnatenko  ---
By the guidelines: The package is being created so that multiple versions of
the same package can coexist in the distribution. The package MUST be properly
named according to the naming guidelines and MUST NOT conflict with all other
versions of the same package. If these requirements are not met, an exemption
is required as above.

it can co-exist if the readline will change SONAME which will, since it's going
to be upgraded to 7.x.

Siteshwar, feel free to request new package in PkgDB.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1412128] Review Request: libpreludedb - Prelude DB Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1412128



--- Comment #3 from Thomas Andrejak  ---
SPEC : https://fedorapeople.org/~totol/libpreludedb.spec
SRPM : https://fedorapeople.org/~totol/libpreludedb-3.1.0-26.fc26.src.rpm

(In reply to Zbigniew Jędrzejewski-Szmek from comment #1)
> It'd be nice to rewrap the %description's. They are very unevenly indented.
> 

Done

> > Provides:   %{name}%{?_isa}-devel = %{version}-%{release}
> > Provides:   prelude-devel = %{version}-%{release}
> That's a bit unusual. Automatically generated provides are usually enough.
> Why is this needed?

There is a mistake, it should be preludedb-devel. This was an habit, as I do in
libprelude. But this is just for the lib. Do I have to remove it ?

> 
> make distcheck → %make_build distcheck. This will add -j..., which should
> make the whole thing faster. Also, I'm not sure if running "distcheck" is
> appropriate. "check" should be enough. "distcheck" is for tarball creators
> to make sure that all the necessary files are included in the distribution,
> and takes much more time because of the additional rebuild.

Done

> 
> There seems to be some codepage corruption in changelog: Caolán McNamara →
> Caolán McNamara, Marcela MaÅ¡láňová → Marcela Mašláňová.
> 

Done

> Looks great though.

(In reply to Zbigniew Jędrzejewski-Szmek from comment #2)
> fedora-review says:
> 
> - Package does not contain duplicates in %files.
>   Note: warning: File listed twice:
>   /usr/share/libpreludedb/classic/mysql2pgsql.sh
>   See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles
> 

I do not have this on my side, can you help me on this ?

> [ ]: Spec use %global instead of %define unless justified.
>  Note: %define requiring justification: %define major 7, %define
>  cppmajor 2

Done

> 
> libpreludedb.i686: W: shared-lib-calls-exit /usr/lib/libpreludedb.so.7.1.1
> exit@GLIBC_2.0
> Might be worth checking, although usually this is a false positive.

As for libprelude, this is a false positive

> 
> python3-preludedb.i686: E: python-bytecode-wrong-magic-value
> /usr/lib/python3.6/site-packages/__pycache__/preludedb.cpython-36.pyc
> expected 3361 (3.6), found 3379 (unknown)
> python3-preludedb.i686: E: python-bytecode-wrong-magic-value
> /usr/lib/python3.6/site-packages/__pycache__/preludedb.cpython-36.opt-1.pyc
> expected 3361 (3.6), found 3379 (unknown)
> 
> I think this is a false positive in rpmlint... python3 seems to import those
> files just fine.

Yes : https://bugzilla.redhat.com/show_bug.cgi?id=1409376

> 
> 
> python2-preludedb needs Requires: python2-prelude,
> python3-preludedb needs Requires: python3-prelude.

Done

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1412252] Review Request: compat-readline6 - Compatibility package for Readline 6

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1412252

Igor Gnatenko  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|ignate...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1412264] Re-Review request: python2-docs - Documentation for the Python programming language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1412264



--- Comment #3 from Charalampos Stratakis  ---
(In reply to Charalampos Stratakis from comment #2)
> Already tested on a rawhide box and a dnf update with the copr repo enabled,
> properly removes python-docs and installs python2-box

and install python2-docs*

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1412344] Review Request: golang-github-mattn-go-isatty - an implememtation of isatty in golang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1412344



--- Comment #1 from josef radinger  ---
spec-file was created with gofed, which creates quite long specs with lots of
%if and %globals,...

i think the spec-file could be smaller, but if i compare with other
golang*-specs it seems to be in line.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1412344] New: Review Request: golang-github-mattn-go-isatty - an implememtation of isatty in golang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1412344

Bug ID: 1412344
   Summary: Review Request: golang-github-mattn-go-isatty - an
implememtation of isatty in golang
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: che...@nosuchhost.net
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
http://www.nosuchhost.net/~cheese/fedora/temp/golang-github-mattn-go-isatty.spec
SRPM URL:
http://www.nosuchhost.net/~cheese/fedora/temp/golang-github-mattn-go-isatty-0.0.1-1.git30a891c.fc25.src.rpm
Description: an implememtation of isatty in golang
Fedora Account System Username: cheese

as this is my first golang-package and those packages have (for me) a weird
setup (repository/username in package name,...) i would need a reviewer with
knowledge in golang-packages.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1219662] Review Request: python-terminado - Terminals served to term.js using Tornado websockets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219662



--- Comment #14 from Tim Orling  ---
Just FYI
mock build on CentOS7 fails:
DEBUG util.py:435:  Error: No Package found for python2-nose
DEBUG util.py:435:  Error: No Package found for python2-ptyprocess
DEBUG util.py:435:  Error: No Package found for python2-tornado >= 4.0.0
DEBUG util.py:435:  Error: No Package found for python34-ptyprocess

Koji EPEL7 build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=17248219
same result, of course :)

Koji builds for F24, F25, rawhide all ok.
  F24: https://koji.fedoraproject.org/koji/taskinfo?taskID=17248224
  F25: https://koji.fedoraproject.org/koji/taskinfo?taskID=17248221
  rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=17248273

Had an issue with fedora-review on F24:
error: line 29: Package does not exist: %description -n python2-terminado

having proxy issues on my F25 box, so more later.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1409929] Review Request: python-sqlalchemy_schemadisplay - Turn SQLAlchemy DB Model into a graph

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1409929



--- Comment #5 from Fedora Update System  ---
python-sqlalchemy_schemadisplay-1.3-1.el7 has been submitted as an update to
Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-d4be5728a4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1387131] Review Request: golang-github-pkg-sftp - SFTP support for the go.crypto/ssh package

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1387131



--- Comment #6 from Fedora Update System  ---
golang-github-pkg-sftp-0-0.1.git8197a2e.fc25 has been submitted as an update to
Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-9f43b78a5c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1387131] Review Request: golang-github-pkg-sftp - SFTP support for the go.crypto/ssh package

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1387131



--- Comment #7 from Fedora Update System  ---
golang-github-pkg-sftp-0-0.1.git8197a2e.fc24 has been submitted as an update to
Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-e9e4ea4d45

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1387131] Review Request: golang-github-pkg-sftp - SFTP support for the go.crypto/ssh package

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1387131



--- Comment #4 from Fedora Update System  ---
golang-github-pkg-sftp-0-0.1.git8197a2e.el6 has been submitted as an update to
Fedora EPEL 6.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-0a52c655ae

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1387131] Review Request: golang-github-pkg-sftp - SFTP support for the go.crypto/ssh package

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1387131



--- Comment #5 from Fedora Update System  ---
golang-github-pkg-sftp-0-0.1.git8197a2e.el7 has been submitted as an update to
Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-4f280740f3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1387131] Review Request: golang-github-pkg-sftp - SFTP support for the go.crypto/ssh package

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1387131

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1409929] Review Request: python-sqlalchemy_schemadisplay - Turn SQLAlchemy DB Model into a graph

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1409929



--- Comment #4 from Fedora Update System  ---
python-sqlalchemy_schemadisplay-1.3-1.fc24 has been submitted as an update to
Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-e54acedb77

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1409929] Review Request: python-sqlalchemy_schemadisplay - Turn SQLAlchemy DB Model into a graph

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1409929

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1409929] Review Request: python-sqlalchemy_schemadisplay - Turn SQLAlchemy DB Model into a graph

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1409929



--- Comment #3 from Fedora Update System  ---
python-sqlalchemy_schemadisplay-1.3-1.fc25 has been submitted as an update to
Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-5c5965a67c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1412068] Review Request: ufw-kde - UFW control module for KDE

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1412068

Neal Gompa  changed:

   What|Removed |Added

 CC||ngomp...@gmail.com
   Assignee|nob...@fedoraproject.org|ngomp...@gmail.com
  Flags||fedora-review?



--- Comment #1 from Neal Gompa  ---
Taking this review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1342688] Review Request: python-livereload - Command line utility for starting a server in a directory

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1342688



--- Comment #8 from William Moreno  ---
Thanks a lot for the review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1219662] Review Request: python-terminado - Terminals served to term.js using Tornado websockets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219662

Tim Orling  changed:

   What|Removed |Added

 CC||ticot...@gmail.com
   Assignee|nob...@fedoraproject.org|ticot...@gmail.com



--- Comment #13 from Tim Orling  ---
Given that William Moreno changed the assignee to nobody, I will take this
review. I sent him email and am happy to give it back to him if desired.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1392457] Review request: python2 - An interpreted, interactive, object-oriented programming language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392457

Charalampos Stratakis  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED
   Fixed In Version||python2-2.7.12-9.fc26



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1412008] Review Request: docker-client-java - docker client library for java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1412008

Roland Grunberg  changed:

   What|Removed |Added

  Flags|fedora-review-  |fedora-review+



--- Comment #5 from Roland Grunberg  ---
[x]: Package complies to the Packaging Guidelines
[x]: Rpmlint is run on all rpms the build produces.
2 packages and 0 specfiles checked; 0 errors, 0 warnings.


*** APPROVED ***


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1404012] Review Request: module-build-service - The Module Build Service for Modularity

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1404012

Ralph Bean  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2017-01-11 13:22:52



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1387115] Review Request: golang-github-pkg-errors - Simple error handling primitives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1387115



--- Comment #10 from Fedora Update System  ---
golang-github-pkg-errors-0.7.1-0.2.gita887431.fc24 has been submitted as an
update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-861a82f5f1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1387115] Review Request: golang-github-pkg-errors - Simple error handling primitives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1387115



--- Comment #9 from Fedora Update System  ---
golang-github-pkg-errors-0.7.1-0.2.gita887431.fc25 has been submitted as an
update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-56a23c5467

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1387115] Review Request: golang-github-pkg-errors - Simple error handling primitives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1387115



--- Comment #8 from Fedora Update System  ---
golang-github-pkg-errors-0.7.1-0.2.gita887431.el7 has been submitted as an
update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-52a4f293c5

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1148447] Review Request: golang-github-kr-fs - Provides Go filesystem-related functions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1148447



--- Comment #19 from Fedora Update System  ---
golang-github-kr-fs-0-0.8.git2788f0d.el6 has been submitted as an update to
Fedora EPEL 6.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-319487df96

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1387115] Review Request: golang-github-pkg-errors - Simple error handling primitives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1387115



--- Comment #7 from Fedora Update System  ---
golang-github-pkg-errors-0.7.1-0.2.gita887431.el6 has been submitted as an
update to Fedora EPEL 6.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-b881eef27b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406786] Review Request: configsnap - Record and compare system state

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406786

Ricardo Cordeiro  changed:

   What|Removed |Added

 CC||christos.triantafyllidis@gm
   ||ail.com
 Whiteboard||AwaitingSubmitter
  Flags||needinfo?(christos.triantaf
   ||ylli...@gmail.com)



--- Comment #3 from Ricardo Cordeiro  ---
Hi Christos,

Please review the following official review results. Once you're ready for a
2nd pass, please drop "AwaitingSubmitter" from the Whiteboard. Thanks.




Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

[x]: Each %files section contains %defattr if rpm < 4.4
 Note: %defattr present but not needed

 "The %defattr directive in the %files list SHOULD ONLY be used when
setting a
  non-default value, or to reset to the default value after having set a
  non-default value."
  Reference:
https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions

  I would recommend removing it per guidelines but I will not fail this
review if
  it remains unchanged.

[!]: Package obeys FHS, except libexecdir and /usr/target.

 /usr/bin/configsnap fails to run if not done as root. This being the case,
it
 should be placed under /usr/sbin instead
 Ref.: http://refspecs.linuxfoundation.org/FHS_3.0/fhs/ch04s10.html

[!]: Package meets the Packaging Guidelines::Python

 "Packages in Fedora should not depend on where /usr/bin/python happens to
point
 but instead should call the proper executable for the needed python major
version
 directly, either /usr/bin/python2 or /usr/bin/python3 as appropriate."
 Ref.:
https://fedoraproject.org/wiki/Packaging:Python#Multiple_Python_Runtimes

 /usr/bin/configsnap's shebang is set to /usr/bin/python, I would suggest
upstream
 to change this or alternatively patch the source when packaging the for
Fedora
 and EPEL as it has been done for unoconv 
 http://pkgs.fedoraproject.org/cgit/rpms/unoconv.git/tree/

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Apache (v2.0)", "Unknown or generated". 5 files have unknown
 license. Detailed output of licensecheck in
 /home/makerpm/reviews/configsnap/1406786-configsnap/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does 

[Bug 1344261] Review Request: warsow - Fast paced 3D first person shooter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1344261

Raphael Groner  changed:

   What|Removed |Added

  Alias||warsow



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1344294] Review Request: warsow-data - Game data for Warsow

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1344294

Raphael Groner  changed:

   What|Removed |Added

  Alias||warsow-data



--- Comment #17 from Raphael Groner  ---
As said in comment #14, fedora-review needs to validate all package
dependencies, incl. runtime. It tries to install inside a mock environment. You
should build warsow-data and provide it at least as a buildroot override for
the review of warsow (rhbz#1344261), no bodhi needed yet. Later, you can push
both warsow and warsow-data in one multi-packages update to bodhi.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1344261] Review Request: warsow - Fast paced 3D first person shooter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1344261



--- Comment #11 from Raphael Groner  ---
Yes, some new SPEC and SRPM files are needed to do another run of
fedora-review. f-r tries to install the package in a mock environment, please
provide warsow-data (rhbz#1344294) for completeness of runtime dependencies.

FYI I'm currently moving and stuck with a limited internet connection, so the
next run may not be expected in the next couple of weeks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1412264] Re-Review request: python2-docs - Documentation for the Python programming language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1412264



--- Comment #2 from Charalampos Stratakis  ---
Already tested on a rawhide box and a dnf update with the copr repo enabled,
properly removes python-docs and installs python2-box

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1342688] Review Request: python-livereload - Command line utility for starting a server in a directory

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1342688

Julien Enselme  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #7 from Julien Enselme  ---
(In reply to William Moreno from comment #6)
> The rawhide build run fine, I will check this issue in f25.
> 
> https://copr.fedorainfracloud.org/coprs/williamjmorenor/fedora-review-test/
> build/498547/
> 
> Any way I think I can go with this package for rawhide only, and later send
> a patch upstream, looks like a missing setting in the test configuration.

Package approved then.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1412008] Review Request: docker-client-java - docker client library for java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1412008



--- Comment #4 from Jeff Johnston  ---
(In reply to Roland Grunberg from comment #2)

Spec URL: http://www.vermillionskye.com/docker-client-java.spec
SRPM URL: http://www.vermillionskye.com/docker-client-java-4.0.6-4.fc26.src.rpm

Description: This is a package containing the com.spotify docker-client library
used by java code to access the docker daemon.  This was previously packaged
as docker-client and is being renamed to allow the docker server to use the old
package name.
Fedora Account System Username: jjohnstn

[jjohnstn@localhost docker-client]$ rpmlint
docker-client-java-4.0.6-4.fc26.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

[jjohnstn@localhost docker-client]$ rpmlint docker-client-java.spec
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1387178] Review Request: golang-github-pelletier-go-buffruneio - Wrapper around bufio to provide buffered runes access with unlimited unreads

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1387178



--- Comment #5 from Fedora Update System  ---
golang-github-pelletier-go-buffruneio-0-0.1.gitdf1e16f.fc25 has been submitted
as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-4820a57257

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1387178] Review Request: golang-github-pelletier-go-buffruneio - Wrapper around bufio to provide buffered runes access with unlimited unreads

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1387178



--- Comment #6 from Fedora Update System  ---
golang-github-pelletier-go-buffruneio-0-0.1.gitdf1e16f.fc24 has been submitted
as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-6936f7819d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1387178] Review Request: golang-github-pelletier-go-buffruneio - Wrapper around bufio to provide buffered runes access with unlimited unreads

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1387178

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1387178] Review Request: golang-github-pelletier-go-buffruneio - Wrapper around bufio to provide buffered runes access with unlimited unreads

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1387178



--- Comment #4 from Fedora Update System  ---
golang-github-pelletier-go-buffruneio-0-0.1.gitdf1e16f.el7 has been submitted
as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-dbdfd16238

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1387178] Review Request: golang-github-pelletier-go-buffruneio - Wrapper around bufio to provide buffered runes access with unlimited unreads

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1387178



--- Comment #3 from Fedora Update System  ---
golang-github-pelletier-go-buffruneio-0-0.1.gitdf1e16f.el6 has been submitted
as an update to Fedora EPEL 6.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-a7eba3c01a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1412008] Review Request: docker-client-java - docker client library for java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1412008



--- Comment #3 from Roland Grunberg  ---
One additional thing worth correcting :

The specfile uses '0%{fedora}' . If %{fedora} is not defined, then this
evaluates to 0%{fedora} . To allow the %if to evaluate correctly, the
expression should be 0%{?fedora} .

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1412008] Review Request: docker-client-java - docker client library for java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1412008

Roland Grunberg  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review-



--- Comment #2 from Roland Grunberg  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

Issues:
===
[!]: Package complies to the Packaging Guidelines
I Don't think we can use SCL macros within the spec file. This is something
that was done a while ago to ease packaging but it's actually against the
guidelines. See :

https://fedoraproject.org/wiki/Packaging:Guidelines#Software_Collection_Macros

For software collections, there should be scripts in place that automatically
insert the macros where needed, for the most part.

[!]: Rpmlint is run on all rpms the build produces.
docker-client-java.src:9: W: mixed-use-of-spaces-and-tabs (spaces: line 4, tab:
line 9)


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[-]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
[!]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[!]: Rpmlint is run on all rpms the build produces.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Java:
[x]: Bundled jar/class files should be removed before build
[x]: Packages have proper BuildRequires/Requires on jpackage-utils

Maven:
[x]: If package contains pom.xml files install it (including metadata) even
 when building with ant
[x]: POM files have correct Maven mapping
[x]: Maven packages should use new style packaging
[x]: Old add_to_maven_depmap macro is not being used
[x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage-
 utils for %update_maven_depmap macro
[x]: Package DOES NOT use %update_maven_depmap in %post/%postun
[x]: Packages use .mfiles file list instead of %{_datadir}/maven2/poms

= SHOULD items =

Generic:
[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[-]: Latest version is packaged.
Since this is a package rename request, it should be ok to simply 

[Bug 1387115] Review Request: golang-github-pkg-errors - Simple error handling primitives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1387115



--- Comment #6 from Fedora Update System  ---
golang-github-pkg-errors-0.7.1-0.1.gita887431.fc24 has been submitted as an
update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-c0a66e24f3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1387115] Review Request: golang-github-pkg-errors - Simple error handling primitives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1387115

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1387115] Review Request: golang-github-pkg-errors - Simple error handling primitives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1387115



--- Comment #5 from Fedora Update System  ---
golang-github-pkg-errors-0.7.1-0.1.gita887431.fc25 has been submitted as an
update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-319f19068c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1387115] Review Request: golang-github-pkg-errors - Simple error handling primitives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1387115



--- Comment #4 from Fedora Update System  ---
golang-github-pkg-errors-0.7.1-0.1.gita887431.el7 has been submitted as an
update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-4915d9bf70

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1387115] Review Request: golang-github-pkg-errors - Simple error handling primitives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1387115



--- Comment #3 from Fedora Update System  ---
golang-github-pkg-errors-0.7.1-0.1.gita887431.el6 has been submitted as an
update to Fedora EPEL 6.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-875bbe1fae

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1412128] Review Request: libpreludedb - Prelude DB Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1412128

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl
  Flags||fedora-review?



--- Comment #2 from Zbigniew Jędrzejewski-Szmek  ---
fedora-review says:

- Package does not contain duplicates in %files.
  Note: warning: File listed twice:
  /usr/share/libpreludedb/classic/mysql2pgsql.sh
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles

[ ]: Spec use %global instead of %define unless justified.
 Note: %define requiring justification: %define major 7, %define
 cppmajor 2

libpreludedb.i686: W: shared-lib-calls-exit /usr/lib/libpreludedb.so.7.1.1
exit@GLIBC_2.0
Might be worth checking, although usually this is a false positive.

python3-preludedb.i686: E: python-bytecode-wrong-magic-value
/usr/lib/python3.6/site-packages/__pycache__/preludedb.cpython-36.pyc expected
3361 (3.6), found 3379 (unknown)
python3-preludedb.i686: E: python-bytecode-wrong-magic-value
/usr/lib/python3.6/site-packages/__pycache__/preludedb.cpython-36.opt-1.pyc
expected 3361 (3.6), found 3379 (unknown)

I think this is a false positive in rpmlint... python3 seems to import those
files just fine.


python2-preludedb needs Requires: python2-prelude,
python3-preludedb needs Requires: python3-prelude.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1412264] Re-Review request: python2-docs - Documentation for the Python programming language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1412264

Miro Hrončok  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||mhron...@redhat.com
   Assignee|nob...@fedoraproject.org|mhron...@redhat.com
  Flags||fedora-review?



--- Comment #1 from Miro Hrončok  ---
The obsoletes/provides looks good to me. Other changes as well.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1342688] Review Request: python-livereload - Command line utility for starting a server in a directory

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1342688



--- Comment #6 from William Moreno  ---
The rawhide build run fine, I will check this issue in f25.

https://copr.fedorainfracloud.org/coprs/williamjmorenor/fedora-review-test/build/498547/

Any way I think I can go with this package for rawhide only, and later send a
patch upstream, looks like a missing setting in the test configuration.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1412128] Review Request: libpreludedb - Prelude DB Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1412128



--- Comment #1 from Zbigniew Jędrzejewski-Szmek  ---
It'd be nice to rewrap the %description's. They are very unevenly indented.

> Provides:   %{name}%{?_isa}-devel = %{version}-%{release}
> Provides:   prelude-devel = %{version}-%{release}
That's a bit unusual. Automatically generated provides are usually enough. Why
is this needed?

make distcheck → %make_build distcheck. This will add -j..., which should make
the whole thing faster. Also, I'm not sure if running "distcheck" is
appropriate. "check" should be enough. "distcheck" is for tarball creators to
make sure that all the necessary files are included in the distribution, and
takes much more time because of the additional rebuild.

There seems to be some codepage corruption in changelog: Caolán McNamara →
Caolán McNamara, Marcela MaÅ¡láňová → Marcela Mašláňová.

Looks great though.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1409654] Review Request: python-pydocstyle - Python docstring style checker

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1409654

Filip Szymański  changed:

   What|Removed |Added

 CC||fszyman...@onet.pl



--- Comment #5 from Filip Szymański  ---
Hi,

In this case I have to agree with Igor, it would be better to use the GitHub
source. It contains tests and all files have Unix line endings (conversion
unnecessary). Use the tarball and not the zip archive.
Correct source URL:
Source0: 
https://github.com/PyCQA/%{srcname}/archive/%{version}/%{srcname}-%{version}.tar.gz

Things like removing shebang from a file or dos2unix should be done in the
%prep section.

What's up with the Release tag (0%{?dist}.1)?
Should be:
Release:  1%{?dist}

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1386938] Review Request: libprelude - Prelude Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1386938

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Blocks||1412128




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1412128
[Bug 1412128] Review Request: libpreludedb - Prelude DB Library
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1412128] Review Request: libpreludedb - Prelude DB Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1412128

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 CC||zbys...@in.waw.pl
 Depends On||1386938




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1386938
[Bug 1386938] Review Request: libprelude - Prelude Library
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1398949] Review Request: bear - Game engine and editors dedicated to creating great 2D games

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1398949

Michael Schwendt  changed:

   What|Removed |Added

 CC||bugs.mich...@gmx.net



--- Comment #34 from Michael Schwendt  ---
There are two things that seem to have slipped through during package review.
At least they have not been commented on:

> %build
> %cmake -DBEAR_ENGINE_INSTALL_LIBRARY_DIR=%{_lib}/%{name} \
>-DBEAR_FACTORY_INSTALL_LIBRARY_DIR=%{_lib}/%{name}  \

What's the goal of relocating the libs into that directory?
Where would they be installed by default?
Where do dependencies search for the bear libs by default?
Do they CMake files as included within the Fedora bear packages find the libs
by default?

> %config(noreplace) %{_sysconfdir}/ld.so.conf.d/%{name}-engine-%{_arch}.conf   
>   

This ld.so config file adds the same directory to runtime linker's search path.
Of course! Else they wouldn't be found in that path. But that makes them
available globally again, just as if they were put into %_libdir directly. And
the ld.so cache contents even are searched before the system's libdirs.

So, there is no gain from relocating them.

Not running "ldconfig" in the scriptlets of the -engine and -factory
subpackages is a related mistake, because of the added ld.so config files that
extend the search path. Anything else (a package or the admin) that runs
ldconfig, would also find the bear libs and add them to the cache. And then
uninstalling the package, the cache ought to be updated again to remove the lib
entries again.

$ ldconfig -p|grep bear
libbear_visual.so (libc6,x86-64) => /usr/lib64/bear/libbear_visual.so
libbear_universe.so (libc6,x86-64) => /usr/lib64/bear/libbear_universe.so
libbear_time.so (libc6,x86-64) => /usr/lib64/bear/libbear_time.so
libbear_text_interface.so (libc6,x86-64) =>
/usr/lib64/bear/libbear_text_interface.so
libbear_net.so (libc6,x86-64) => /usr/lib64/bear/libbear_net.so
libbear_input.so (libc6,x86-64) => /usr/lib64/bear/libbear_input.so
libbear_gui.so (libc6,x86-64) => /usr/lib64/bear/libbear_gui.so
libbear_generic_items.so (libc6,x86-64) =>
/usr/lib64/bear/libbear_generic_items.so
libbear_expr.so (libc6,x86-64) => /usr/lib64/bear/libbear_expr.so
libbear_engine.so (libc6,x86-64) => /usr/lib64/bear/libbear_engine.so
libbear_debug.so (libc6,x86-64) => /usr/lib64/bear/libbear_debug.so
libbear_communication.so (libc6,x86-64) =>
/usr/lib64/bear/libbear_communication.so
libbear_audio.so (libc6,x86-64) => /usr/lib64/bear/libbear_audio.so


> %{_mandir}/man6/running-%n{ame}.6*

This refers to a missing executable.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1412264] New: Re-Review request: python2-docs - Documentation for the Python programming language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1412264

Bug ID: 1412264
   Summary: Re-Review request: python2-docs - Documentation for
the Python programming language
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: cstra...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



SPEC:
https://raw.githubusercontent.com/fedora-python/python-docs/master/python2-docs.spec

SRPM: https://cstratak.fedorapeople.org/python2-docs-2.7.12-3.fc26.src.rpm


Diff:
https://github.com/fedora-python/python-docs/compare/9bd9de270a5bc5bcd8c1afae682e13436b5c19ba...master


Fedora Account System Username: cstratak

As python got renamed to python2 (#1392457), the respective documentation
package should be renamed as well from python-docs to python2-docs.

The change is intended only for rawhide.

With the provides and obsoletes added the upgrade path should remain clean.

Copr repo for testing:
https://copr.fedorainfracloud.org/coprs/cstratak/python-docs

koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=17245653

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1302744] Review Request: python-resumable-urlretrieve - Small library to fetch files over HTTP and resuming their download

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302744

Haïkel Guémar  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #7 from Haïkel Guémar  ---
Please request upstream to add license file in tarball for next releases.
Package approved.



Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated". 15 files have unknown license. Detailed
 output of licensecheck in /home/hguemar/1302744-python-resumable-
 urlretrieve/licensecheck.txt
[x]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/lib/python3.6/site-packages,
 /usr/lib/python3.6
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/lib/python3.6/site-
 packages, /usr/lib/python3.6
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Macros in Summary, %description expandable at SRPM build time.
 Note: Macros in: python3-resumable-urlretrieve (description)
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 

[Bug 1412252] Review Request: compat-readline6 - Compatibility package for Readline 6

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1412252

Siteshwar Vashisht  changed:

   What|Removed |Added

Summary|Review Request: |Review Request:
   |compat-readline6 -  |compat-readline6 -
   |compatibility package for   |Compatibility package for
   |Readline 6  |Readline 6



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1412252] Review Request: compat-readline6 - compatibility package for Readline 6

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1412252

Siteshwar Vashisht  changed:

   What|Removed |Added

Summary|Review Request: |Review Request:
   |compat-readline6 -  |compat-readline6 -
   |Compatiblity package for|compatibility package for
   |Readline 6  |Readline 6



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1412252] New: Review Request: compat-readline6 - Compatiblity package for Readline 6

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1412252

Bug ID: 1412252
   Summary: Review Request: compat-readline6 - Compatiblity
package for Readline 6
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: svashi...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://people.redhat.com/svashish/compat-readline6/compat-readline6.spec
SRPM URL:
https://people.redhat.com/svashish/compat-readline6/compat-readline6-6.3-9.fc26.src.rpm
Description: 

The Readline library provides a set of functions that allow users to
edit command lines. Both Emacs and vi editing modes are available. The
Readline library includes additional functions for maintaining a list
of previously-entered command lines for recalling or editing those
lines, and for performing csh-like history expansion on previous
commands.

Fedora Account System Username: svashi...@redhat.com

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org