https://bugzilla.redhat.com/show_bug.cgi?id=1412128
--- Comment #3 from Thomas Andrejak <thomas.andre...@gmail.com> --- SPEC : https://fedorapeople.org/~totol/libpreludedb.spec SRPM : https://fedorapeople.org/~totol/libpreludedb-3.1.0-26.fc26.src.rpm (In reply to Zbigniew Jędrzejewski-Szmek from comment #1) > It'd be nice to rewrap the %description's. They are very unevenly indented. > Done > > Provides: %{name}%{?_isa}-devel = %{version}-%{release} > > Provides: prelude-devel = %{version}-%{release} > That's a bit unusual. Automatically generated provides are usually enough. > Why is this needed? There is a mistake, it should be preludedb-devel. This was an habit, as I do in libprelude. But this is just for the lib. Do I have to remove it ? > > make distcheck → %make_build distcheck. This will add -j..., which should > make the whole thing faster. Also, I'm not sure if running "distcheck" is > appropriate. "check" should be enough. "distcheck" is for tarball creators > to make sure that all the necessary files are included in the distribution, > and takes much more time because of the additional rebuild. Done > > There seems to be some codepage corruption in changelog: Caolán McNamara → > Caolán McNamara, Marcela MaÅ¡láňová → Marcela Mašláňová. > Done > Looks great though. (In reply to Zbigniew Jędrzejewski-Szmek from comment #2) > fedora-review says: > > - Package does not contain duplicates in %files. > Note: warning: File listed twice: > /usr/share/libpreludedb/classic/mysql2pgsql.sh > See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles > I do not have this on my side, can you help me on this ? > [ ]: Spec use %global instead of %define unless justified. > Note: %define requiring justification: %define major 7, %define > cppmajor 2 Done > > libpreludedb.i686: W: shared-lib-calls-exit /usr/lib/libpreludedb.so.7.1.1 > exit@GLIBC_2.0 > Might be worth checking, although usually this is a false positive. As for libprelude, this is a false positive > > python3-preludedb.i686: E: python-bytecode-wrong-magic-value > /usr/lib/python3.6/site-packages/__pycache__/preludedb.cpython-36.pyc > expected 3361 (3.6), found 3379 (unknown) > python3-preludedb.i686: E: python-bytecode-wrong-magic-value > /usr/lib/python3.6/site-packages/__pycache__/preludedb.cpython-36.opt-1.pyc > expected 3361 (3.6), found 3379 (unknown) > > I think this is a false positive in rpmlint... python3 seems to import those > files just fine. Yes : https://bugzilla.redhat.com/show_bug.cgi?id=1409376 > > > python2-preludedb needs Requires: python2-prelude, > python3-preludedb needs Requires: python3-prelude. Done -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
