[Bug 1409866] Review Request: perl-Astro-SunTime - Calculates sun rise/ set times

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1409866



--- Comment #18 from Fedora Update System  ---
perl-Astro-SunTime-0.05-2.el6 has been pushed to the Fedora EPEL 6 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-39d372dc15

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1409866] Review Request: perl-Astro-SunTime - Calculates sun rise/ set times

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1409866



--- Comment #19 from Fedora Update System  ---
perl-Astro-SunTime-0.05-2.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-820c75f0c5

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1403314] Review Request: python-publicsuffix - Get a public suffix for a domain name using the Public Suffix List.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1403314



--- Comment #21 from Fedora Update System  ---
python-publicsuffix-1.1.0-1.el7 has been pushed to the Fedora EPEL 7 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1403314] Review Request: python-publicsuffix - Get a public suffix for a domain name using the Public Suffix List.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1403314



--- Comment #20 from Fedora Update System  ---
python-publicsuffix-1.1.0-1.el6 has been pushed to the Fedora EPEL 6 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1416059] Review Request: perl-Git-Wrapper - Wrap git command-line interface for Perl

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1416059

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #6 from Fedora Update System  ---
perl-Git-Wrapper-0.047-1.fc24 has been pushed to the Fedora 24 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-dc00f9f341

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1409866] Review Request: perl-Astro-SunTime - Calculates sun rise/ set times

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1409866

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #17 from Fedora Update System  ---
perl-Astro-SunTime-0.05-2.fc24 has been pushed to the Fedora 24 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-5bfcccedd5

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394193] Review Request: arduino-builder - A command line tool for compiling Arduino sketches

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394193

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #6 from Fedora Update System  ---
arduino-builder-1.0.5-2.fc24 has been pushed to the Fedora 24 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-9e3f59cacf

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1412801] Review Request: python-networkmanager - Easy communication with NetworkManager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1412801



--- Comment #6 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-networkmanager

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1411028] Review Request: python-backports-shutil_which - Backport of shutil.which from Python 3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1411028



--- Comment #5 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-backports-shutil_which

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1416523] Review Request: pantheon-photos - Pantheon photo manager and viewer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1416523



--- Comment #5 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/pantheon-photos

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1411028] Review Request: python-backports-shutil_which - Backport of shutil.which from Python 3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1411028

Lameire Alexis  changed:

   What|Removed |Added

  Flags|fedora-review? needinfo+|fedora-review+



--- Comment #4 from Lameire Alexis  ---
If no ambiguity I validate it

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1411028] Review Request: python-backports-shutil_which - Backport of shutil.which from Python 3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1411028



--- Comment #3 from Mohamed El Morabity  ---
License fixed:

Spec URL:
https://melmorabity.fedorapeople.org/packages/python-backports-shutil_which/python-backports-shutil_which.spec
SRPM URL:
https://melmorabity.fedorapeople.org/packages/python-backports-shutil_which/python-backports-shutil_which-3.5.1-2.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1411028] Review Request: python-backports-shutil_which - Backport of shutil.which from Python 3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1411028



--- Comment #2 from Mohamed El Morabity  ---
Thanks for your review Alexis.

(In reply to Lameire Alexis from comment #1)
> Hello,
> Please submit a PR to the origiual project for adding the licence header
> inside the source and add the request url as comment inside your spec and I
> will validate the review.

I was wrong about the project license. Since it's a backport of Python 3
(without modification), the code in shutil_which.py is covered by the Python
license (as already specified in its header comment... and the LICENSE file).
Extra bits (__init__.py, deployment script) are covered by the MIT license, as
specified also in the LICENSE file. For these last files, which are trivial, is
it really worth adding a license header? Nothing in the MIT license prescribes
it.

Anyway I will upload a new version of the package with license fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406786] Review Request: configsnap - Record and compare system state

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406786

Ricardo Cordeiro  changed:

   What|Removed |Added

   Assignee|ricardo.corde...@tux.com.pt |christos.triantafyllidis@gm
   ||ail.com
  Flags|fedora-review?  |fedora-review+



--- Comment #5 from Ricardo Cordeiro  ---
Hi Christos,

Thanks for your update, modified specfile and patch. The package is ready to be
included in the package DB.

Please find below my last review.

Kind Regards,
Ricardo Cordeiro


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Apache (v2.0)", "Unknown or generated". 5 files have unknown
 license. Detailed output of licensecheck in
 /home/makerpm/reviews/configsnap/1406786-configsnap/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Each %files section contains %defattr if rpm < 4.4
 Note: %defattr present but not needed
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[-]: Python eggs must not download any dependencies during the build
 process.
[-]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[-]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or 

[Bug 1411028] Review Request: python-backports-shutil_which - Backport of shutil.which from Python 3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1411028

Lameire Alexis  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||alexis.lame...@gmail.com
  Flags||fedora-review? needinfo+



--- Comment #1 from Lameire Alexis  ---
Hello,
Please submit a PR to the origiual project for adding the licence header inside
the source and add the request url as comment inside your spec and I will
validate the review.

Here the compleate list :
= MUST items =

Generic:
[!]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
source files are not licenced, 
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated", "*No copyright*
 PSF". 5 files have unknown license. Detailed output of licensecheck in
 /home/alexises/projet_new/rpm/review-python-backports-
 shutil_which/licensecheck.txt
[x]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by: /usr/lib/python2.7/site-
 packages/backports(python2-backports-functools_lru_cache,
 python2-configparser, python-backports)
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from 

[Bug 1412801] Review Request: python-networkmanager - Easy communication with NetworkManager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1412801



--- Comment #5 from Igor Gnatenko  ---
(In reply to John Dulaney from comment #4)
> Spec URL: https://jdulaney.fedorapeople.org/python-networkmanager.spec
> SRPM URL:
> https://jdulaney.fedorapeople.org/python-networkmanager-1.2.1-3.fc25.src.rpm
> 
> I put the manpage into the docs subpackage.  I figured having the examples
> in a subpackage would be better for security, the whole "don't install
> things that are not necessary" thing.
There's nothing secure (I mean non-secure) in having examples in main
subpackages. You want to split docs only if they are big (>10M)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1412801] Review Request: python-networkmanager - Easy communication with NetworkManager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1412801



--- Comment #4 from John Dulaney  ---
Spec URL: https://jdulaney.fedorapeople.org/python-networkmanager.spec
SRPM URL:
https://jdulaney.fedorapeople.org/python-networkmanager-1.2.1-3.fc25.src.rpm

I put the manpage into the docs subpackage.  I figured having the examples in a
subpackage would be better for security, the whole "don't install things that
are not necessary" thing.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1391334] Review Request: freeorion - Turn-based space empire and galactic conquest (4X) computer game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391334



--- Comment #21 from Fedora Update System  ---
freeorion-0.4.6-5.fc24 has been pushed to the Fedora 24 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1416523] Review Request: pantheon-photos - Pantheon photo manager and viewer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1416523

Neal Gompa  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #4 from Neal Gompa  ---
APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1416523] Review Request: pantheon-photos - Pantheon photo manager and viewer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1416523



--- Comment #3 from Neal Gompa  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[-]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD (2 clause)", "LGPL (v2.1 or later)", "GPL (v3 or later)",
 "Unknown or generated". 335 files have unknown license. Detailed
 output of licensecheck in /home/makerpm/1416523-pantheon-
 photos/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/share/locale/szl/LC_MESSAGES,
 /usr/share/locale/ckb, /usr/share/locale/rue/LC_MESSAGES,
 /usr/share/locale/ckb/LC_MESSAGES, /usr/share/locale/rue,
 /usr/share/locale/szl
[x]: Package must own all directories that it creates.
 Note: Directories without known owners:
 /usr/share/locale/rue/LC_MESSAGES, /usr/share/locale/szl/LC_MESSAGES,
 /usr/share/locale/ckb/LC_MESSAGES, /usr/share/locale/ckb,
 /usr/share/locale/rue, /usr/share/locale/szl
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
 contains icons.
 Note: icons in pantheon-photos
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 40960 bytes in 5 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
 desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:

[Bug 1412128] Review Request: libpreludedb - Prelude DB Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1412128



--- Comment #16 from Fedora Update System  ---
libpreludedb-3.1.0-1.fc25 has been pushed to the Fedora 25 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1414844] Review Request: php-react - Event-driven, non-blocking I/ O with PHP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1414844



--- Comment #2 from Shawn Iwinski  ---
(In reply to Remi Collet from comment #1)
> Build fails
> 
> + : Minimal autoloader test
> + php -r 'require
> "/builddir/build/BUILDROOT/php-react-0.4.2-1.fc26.x86_64/usr/share/php/React/
> autoload.php";'
> /var/tmp/rpm-tmp.YfSHQ4: line 32: php: command not found
> 
> 
> Probably you forget to require php-cli ;)

Yep :/

Diff:
https://github.com/siwinski/rpms/commit/6761f4175985f4c5cd6574c84b46ff9b9a1e3d1f



Spec URL:
https://raw.githubusercontent.com/siwinski/rpms/6761f4175985f4c5cd6574c84b46ff9b9a1e3d1f/php-react/php-react.spec

SRPM URL:
https://siwinski.fedorapeople.org/SRPMS/php-react-0.4.2-2.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1362487] Review Request: arcanist - A command line interface to Phabricator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1362487



--- Comment #22 from Ling Li  ---
When using the libphutil package (from
https://kanarip.fedorapeople.org/phabricator/), arc complains about 

Exception
[cURL/77] (https://company.com/api/user.whoami) The SSL CA Bundles that we
tried to use could not be read or are not formatted correctly.
(Run with `--trace` for a full exception trace.)

If I added resources/ into /usr/share/libphutil, then everything works fine.

I don't know PHP/libphutil enough and couldn't tell if it's something wrong in
my system or in the RPM.  So, just for your information.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1416523] Review Request: pantheon-photos - Pantheon photo manager and viewer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1416523



--- Comment #2 from Fabio Valentini  ---
Sorry about the noise, I forgot to add a fallback icon to this package. It's
fixed in this version:

Spec URL:
https://raw.githubusercontent.com/decathorpe/fedora-packaging/2674dce5ad917fd23d0c07ef6eda89f3ef8055c7/specs/pantheon-photos/pantheon-photos.spec

SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/decathorpe/staging/fedora-25-x86_64/00503758-pantheon-photos/pantheon-photos-0.2.1.1-2.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406786] Review Request: configsnap - Record and compare system state

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406786

Christos Triantafyllidis  changed:

   What|Removed |Added

  Flags|needinfo?(christos.triantaf |
   |ylli...@gmail.com)  |



--- Comment #4 from Christos Triantafyllidis 
 ---
Thank you Ricardo,

Updated SRPM:
https://ctria.fedorapeople.org/packaging/configsnap/configsnap-0.11-2.fc25.src.rpm

Updated SPEC:
https://ctria.fedorapeople.org/packaging/configsnap/configsnap.spec

Included patch (as I don't think that needs to go to upstream, that is a Fedora
implementation issue):
https://ctria.fedorapeople.org/packaging/configsnap/python_executable.patch

On your comments:
[!]: Package obeys FHS, except libexecdir and /usr/target.
Correct, changed!

[!]: Package meets the Packaging Guidelines::Python
Correct, changed!

[?] - getData script provided by upstream is not included. I understand that
  its purpose is limited as it only serves to warn the user that the script
  has been renamed to configsnap. I guess you've not included it by design,
  although, if included, /usr/bin/getdata would not collide with any
current
  packages on Fedora, RHEL and EPEL repositories. Please confirm that this
was
  done by design.
That is done by design that was added as part of the deprecation of the old
project name. There is no need to introduce this in Fedora/EPEL.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406786] Review Request: configsnap - Record and compare system state

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406786

Christos Triantafyllidis  changed:

   What|Removed |Added

 Whiteboard|AwaitingSubmitter   |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1416523] Review Request: pantheon-photos - Pantheon photo manager and viewer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1416523

Neal Gompa  changed:

   What|Removed |Added

 CC||ngomp...@gmail.com
   Assignee|nob...@fedoraproject.org|ngomp...@gmail.com
  Flags||fedora-review?



--- Comment #1 from Neal Gompa  ---
Taking this review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1416523] New: Review Request: pantheon-photos - Pantheon photo manager and viewer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1416523

Bug ID: 1416523
   Summary: Review Request: pantheon-photos - Pantheon photo
manager and viewer
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: decatho...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://raw.githubusercontent.com/decathorpe/fedora-packaging/f4f48bfc3e65bff7820737527d3f6d9bd507ceaf/specs/pantheon-photos/pantheon-photos.spec

SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/decathorpe/staging/fedora-25-x86_64/00503749-pantheon-photos/pantheon-photos-0.2.1.1-1.fc25.src.rpm

Description: The elementary continuation of Shotwell, originally written by
Yorba Foundation.

Fedora Account System Username: decathorpe


koji scratch build for rawhide:
https://koji.fedoraproject.org/koji/taskinfo?taskID=17411734

COPR build for f25 and rawhide:
https://copr.fedorainfracloud.org/coprs/decathorpe/staging/build/503749/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1416492] New: Review Request: perl-Task-Kensho-XML - Glimpse at an Enlightened Perl (XML Development)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1416492

Bug ID: 1416492
   Summary: Review Request: perl-Task-Kensho-XML - Glimpse at an
Enlightened Perl (XML Development)
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: jples...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://jplesnik.fedorapeople.org/perl-Task-Kensho-XML/perl-Task-Kensho-XML.spec
SRPM URL:
https://jplesnik.fedorapeople.org/perl-Task-Kensho-XML/perl-Task-Kensho-XML-0.39-1.fc26.src.rpm

Description:
Task::Kensho is a list of recommended modules for Enlightened Perl
development. CPAN is wonderful, but there are too many wheels and you have
to pick and choose amongst the various competing technologies.

Fedora Account System Username: jples...@redhat.com

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1410901] Review Request: python-fmn - A system for generic fedmsg-driven notifications for end users

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1410901

Jeremy Cline  changed:

   What|Removed |Added

  Flags|needinfo?(jer...@jcline.org |
   |)   |



--- Comment #4 from Jeremy Cline  ---
Spec URL: https://jcline.fedorapeople.org/python-fmn.spec
SRPM URL: https://jcline.fedorapeople.org/python-fmn-1.1.0-1.fc25.src.rpm

I updated the Provides. I don't know why I forgot about the release, but
originally I couldn't use the version macro because I (somewhat arbitrarily)
versioned the combined package at 1.0.0 since some of the old packages were
0.x.z and one was at 1.0.3. In hindsight this was bad, since the library
suddenly dropped in version (and this is what made me hesitant to claim to
provide it), but I've since bumped (somewhat arbitrarily) the version to 1.1.0
so everything is okay.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1416059] Review Request: perl-Git-Wrapper - Wrap git command-line interface for Perl

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1416059



--- Comment #4 from Fedora Update System  ---
perl-Git-Wrapper-0.047-1.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-c3fe9e7108

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1416059] Review Request: perl-Git-Wrapper - Wrap git command-line interface for Perl

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1416059

Petr Pisar  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED
   Fixed In Version||perl-Git-Wrapper-0.047-1.fc
   ||26



--- Comment #3 from Petr Pisar  ---
Thank you for the review and the repository. I added the the dependencies.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1416059] Review Request: perl-Git-Wrapper - Wrap git command-line interface for Perl

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1416059



--- Comment #5 from Fedora Update System  ---
perl-Git-Wrapper-0.047-1.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-dc00f9f341

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020

Tomas Repik  changed:

   What|Removed |Added

 Depends On|1183877 |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1183877
[Bug 1183877] thrift-0.9.3 is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1416477] New: Review Request: python-openstack-doc-tools - Tools for OpenStack Documentation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1416477

Bug ID: 1416477
   Summary: Review Request: python-openstack-doc-tools  - Tools
for OpenStack Documentation
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: jp...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://jpena.fedorapeople.org/openstack-doc-tools/python-openstack-doc-tools.spec
SRPM URL:
https://jpena.fedorapeople.org/openstack-doc-tools/python-openstack-doc-tools-1.3.0-1.src.rpm
Description: Tools used by the OpenStack Documentation Project.
Fedora Account System Username: jpena

Koji scratch build available at
https://koji.fedoraproject.org/koji/taskinfo?taskID=17411247

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1416477] Review Request: python-openstack-doc-tools - Tools for OpenStack Documentation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1416477

Javier Peña  changed:

   What|Removed |Added

 Blocks||1373513 (RDO-OCATA)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1373513
[Bug 1373513] Tracker: Blockers and Review requests for new RDO Ocata
packages
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1412264] Re-Review request: python2-docs - Documentation for the Python programming language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1412264



--- Comment #5 from Charalampos Stratakis  ---
Addressed all your notes (I think).

SPEC:
https://raw.githubusercontent.com/fedora-python/python-docs/master/python2-docs.spec

SRPM: https://cstratak.fedorapeople.org/python2-docs-2.7.13-1.fc26.src.rpm


Diff:
https://github.com/fedora-python/python-docs/compare/9bd9de270a5bc5bcd8c1afae682e13436b5c19ba...master


Fedora Account System Username: cstratak


Copr repo: https://copr.fedorainfracloud.org/coprs/cstratak/python-docs

scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=17411166

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1416455] Review Request: python-easywatch - super simple directory monitoring

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1416455

Fabio Alessandro Locati  changed:

   What|Removed |Added

 Blocks||1416458




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1416458
[Bug 1416458] Review Request: python-staticjinja - jinja based static site
generator
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1416458] New: Review Request: python-staticjinja - jinja based static site generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1416458

Bug ID: 1416458
   Summary: Review Request: python-staticjinja - jinja based
static site generator
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: f...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://fale.fedorapeople.org/rpms/python-staticjinja.spec
SRPM URL:
https://fale.fedorapeople.org/rpms/python-staticjinja-0.3.3-1.fc25.src.rpm
Description: jinja based static site generator
Fedora Account System Username: fale

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1416458] Review Request: python-staticjinja - jinja based static site generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1416458

Fabio Alessandro Locati  changed:

   What|Removed |Added

 Depends On||1416455




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1416455
[Bug 1416455] Review Request: python-easywatch - super simple directory
monitoring
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1416455] New: Review Request: python-easywatch - super simple directory monitoring

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1416455

Bug ID: 1416455
   Summary: Review Request: python-easywatch - super simple
directory monitoring
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: f...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://fale.fedorapeople.org/rpms/python-easywatch.spec
SRPM URL:
https://fale.fedorapeople.org/rpms/python-easywatch-0.0.3-1.fc25.src.rpm
Description: super simple directory monitoring
Fedora Account System Username: fale

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1414004] Review Request: rubygem-rspec-pending_for - Mark specs pending or skipped for specific Ruby engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1414004
Bug 1414004 depends on bug 1414002, which changed state.

Bug 1414002 Summary: Review Request: rubygem-ruby_version - Adds the 
RubyVersion pseudo-constant
https://bugzilla.redhat.com/show_bug.cgi?id=1414002

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1414002] Review Request: rubygem-ruby_version - Adds the RubyVersion pseudo-constant

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1414002

František Dvořák  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2017-01-25 08:52:37



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1414004] Review Request: rubygem-rspec-pending_for - Mark specs pending or skipped for specific Ruby engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1414004
Bug 1414004 depends on bug 1414001, which changed state.

Bug 1414001 Summary: Review Request: rubygem-ruby_engine - Adds the RubyEngine 
pseudo-constant
https://bugzilla.redhat.com/show_bug.cgi?id=1414001

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1414001] Review Request: rubygem-ruby_engine - Adds the RubyEngine pseudo-constant

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1414001

František Dvořák  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2017-01-25 08:52:25



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1410901] Review Request: python-fmn - A system for generic fedmsg-driven notifications for end users

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1410901

Randy Barlow  changed:

   What|Removed |Added

  Flags||needinfo?(jer...@jcline.org
   ||)



--- Comment #3 from Randy Barlow  ---
I believe the Provides statements should be using the release, but even more
importantly should be using the version macro. Otherwise, this package will
always claim to provide the other packages at the versions they were retired
at, which won't be true since it will be changing over time.

For example, instead of:

Provides: python-fmn-rules = 0.9.1

I think you need:

Provides: python-fmn-rules = %{version}-%{release}

You can read a bit about that here:

https://fedoraproject.org/wiki/Packaging:Guidelines#Renaming.2FReplacing_Existing_Packages

Here's an example spec file that uses a global for the description:

http://pkgs.fedoraproject.org/cgit/rpms/python-nose.git/tree/python-nose.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1415993] Review Request: perl-Time-Tiny - Time object, with as little code as possible

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1415993

Jitka Plesnikova  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
   Fixed In Version||perl-Time-Tiny-1.07-1.fc26
 Resolution|--- |RAWHIDE
Last Closed||2017-01-25 08:37:27



--- Comment #3 from Jitka Plesnikova  ---
Thank you for the review and the repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1414087] Review Request: Gearboy - Game Boy and Game Boy Color emulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1414087



--- Comment #8 from Daniel Moerner  ---
Thank you for the suggestion, Itamar and Andrea; I will submit it to rpmfusion.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1414087] Review Request: Gearboy - Game Boy and Game Boy Color emulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1414087

Itamar Reis Peixoto  changed:

   What|Removed |Added

 CC||ita...@ispbrasil.com.br



--- Comment #7 from Itamar Reis Peixoto  ---
please submit it to rpmfusion, thank you.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1404043] Review Request: rdma-core - RDMA core userspace libraries and daemons

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1404043



--- Comment #24 from Jarod Wilson  ---
(In reply to Jon Ciesla from comment #23)
> Package request has been approved:
> https://admin.fedoraproject.org/pkgdb/package/rpms/rdma-core

Whoops, I just filed a new package request to get it into pkgdb moments before
noticing it had already been done.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1404043] Review Request: rdma-core - RDMA core userspace libraries and daemons

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1404043



--- Comment #23 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/rdma-core

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1416059] Review Request: perl-Git-Wrapper - Wrap git command-line interface for Perl

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1416059



--- Comment #2 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Git-Wrapper

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1414002] Review Request: rubygem-ruby_version - Adds the RubyVersion pseudo-constant

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1414002



--- Comment #7 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/rubygem-ruby_version

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1415993] Review Request: perl-Time-Tiny - Time object, with as little code as possible

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1415993



--- Comment #2 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Time-Tiny

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1414001] Review Request: rubygem-ruby_engine - Adds the RubyEngine pseudo-constant

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1414001



--- Comment #7 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/rubygem-ruby_engine

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1414087] Review Request: Gearboy - Game Boy and Game Boy Color emulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1414087

Daniel Moerner  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |WONTFIX
Last Closed||2017-01-25 08:04:53



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1414087] Review Request: Gearboy - Game Boy and Game Boy Color emulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1414087



--- Comment #6 from Daniel Moerner  ---
Thank you for sharing, I was not aware of that history. This does look like a
clear legal blocker.

Thanks all for your help; my apologies for any time you spent on this. I will
be much more careful next time.

I believe the correct thing to do this is to close this bug "WONTFIX".

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1416059] Review Request: perl-Git-Wrapper - Wrap git command-line interface for Perl

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1416059

Jitka Plesnikova  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Jitka Plesnikova  ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Git-Wrapper-0.047-1.fc26.noarch.rpm | sort | uniq -c
  1 git-core
  1 perl(:MODULE_COMPAT_5.24.1)
  1 perl(:VERSION) >= 5.6.0
  1 perl(File::Temp)
  1 perl(File::chdir)
  1 perl(Git::Wrapper::Exception)
  1 perl(Git::Wrapper::File::RawModification)
  1 perl(Git::Wrapper::Log)
  1 perl(Git::Wrapper::Status)
  1 perl(Git::Wrapper::Statuses)
  1 perl(IPC::Cmd)
  1 perl(IPC::Open3)
  1 perl(Scalar::Util)
  1 perl(Sort::Versions)
  1 perl(Symbol)
  1 perl(overload)
  1 perl(strict)
  1 perl(warnings)
  1 rpmlib(CompressedFileNames) <= 3.0.4-1
  1 rpmlib(FileDigests) <= 4.6.0-1
  1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
  1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Git-Wrapper-0.047-1.fc26.noarch.rpm | sort | uniq -c
  1 perl(Git::Wrapper) = 0.047
  1 perl(Git::Wrapper::Exception) = 0.047
  1 perl(Git::Wrapper::File::RawModification) = 0.047
  1 perl(Git::Wrapper::Log) = 0.047
  1 perl(Git::Wrapper::Status) = 0.047
  1 perl(Git::Wrapper::Statuses) = 0.047
  1 perl-Git-Wrapper = 0.047-1.fc26
Binary provides are Ok.

$ rpmlint ./perl-Git-Wrapper*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

Rpmlint is ok

FIX: Please add build-requires 'make' and 'findutils'. They are used in
 spec file.

Please correct 'FIX' issue.

Otherwise the package looks good.
Approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394193] Review Request: arduino-builder - A command line tool for compiling Arduino sketches

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394193



--- Comment #5 from Fedora Update System  ---
arduino-builder-1.0.5-2.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-9e3f59cacf

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394193] Review Request: arduino-builder - A command line tool for compiling Arduino sketches

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394193

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394193] Review Request: arduino-builder - A command line tool for compiling Arduino sketches

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394193



--- Comment #4 from Fedora Update System  ---
arduino-builder-1.0.5-2.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-e26cf562b7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1416059] Review Request: perl-Git-Wrapper - Wrap git command-line interface for Perl

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1416059

Jitka Plesnikova  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jples...@redhat.com
   Assignee|nob...@fedoraproject.org|jples...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1415731] Review Request: perl-XML-Generator-PerlData - Perl extension for generating SAX2 events from nested Perl data structures

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1415731

Jitka Plesnikova  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
   Fixed In Version||perl-XML-Generator-PerlData
   ||-0.95-1.fc26
 Resolution|--- |RAWHIDE
Last Closed||2017-01-25 03:46:34



--- Comment #3 from Jitka Plesnikova  ---
Thank you for the review and the repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1414087] Review Request: Gearboy - Game Boy and Game Boy Color emulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1414087



--- Comment #5 from Andrea Musuruane  ---
Please read:
http://gbdev.gg8.se/wiki/articles/Gameboy_Bootstrap_ROM

I guess this is a blocker to have Gearboy in Fedora proper.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org