[Bug 1445130] New: Review Request: nodejs-union - A hybrid streaming middleware kernel backwards compatible with connect

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445130

Bug ID: 1445130
   Summary: Review Request: nodejs-union - A hybrid streaming
middleware kernel backwards compatible with connect
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: pnem...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org




Spec URL: http://pnemade.fedorapeople.org/fedora-work/nodejs-union.spec
SRPM URL:
http://pnemade.fedorapeople.org/fedora-work/nodejs-union-0.4.6-1.fc26.src.rpm

Description:
A hybrid streaming middleware kernel backwards compatible with connect.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445130] Review Request: nodejs-union - A hybrid streaming middleware kernel backwards compatible with connect

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445130



--- Comment #1 from Parag Nemade  ---
This package built on koji: 
https://koji.fedoraproject.org/koji/taskinfo?taskID=19193010

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431763] Review Request: golang-github-oschwald-geoip2-golang - GeoIP2 lookup library for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431763

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #15 from Fedora Update System  ---
golang-github-oschwald-geoip2-golang-1.1.0-1.fc25 has been pushed to the Fedora
25 testing repository. If problems still persist, please make note of it in
this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-dd3997794d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431445] Review Request: avogadro2-libs - Avogadro2 libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431445



--- Comment #12 from Fedora Update System  ---
avogadro2-libs-1.90.0-5.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1430132] Review Request: golang-github-google-go-github - Go library for accessing the GitHub API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1430132

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-04-24 22:22:24



--- Comment #17 from Fedora Update System  ---
golang-github-google-go-github-0-0.1.git553fda4.fc25 has been pushed to the
Fedora 25 stable repository. If problems still persist, please make note of it
in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1267468] Review Request: rubygem-codeclimate-test-reporter - Uploads Ruby test coverage data to Code Climate

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1267468

Ilya Gradina  changed:

   What|Removed |Added

  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268360] Review Request: rubygem-simple_oauth - Simply builds and verifies OAuth headers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268360

Ilya Gradina  changed:

   What|Removed |Added

  Flags||needinfo?(pval...@redhat.co
   ||m)



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444518] Review Request: libcoap - C library implementation of CoAP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444518

Iwicki Artur  changed:

   What|Removed |Added

 CC||iwicki.ar...@svgames.pl



--- Comment #1 from Iwicki Artur  ---
I am not a packager, so this is not an official review.

I noticed the %files section uses
> %{_datadir}/man/man5/coap*.gz
The wiki page says you should not assume that gzip is used, and use a pattern
which reflects that. Also, you may use %{_mandir} instead of %{_datadir}/man.
https://fedoraproject.org/wiki/Packaging:Guidelines#Manpages

As a minor note, the %descriptions for -devel and -docs use the %{name} macro,
whereas the -utils subpackage uses a bare string.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1440704] Review Request: cpprest - C++ REST SDK

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1440704



--- Comment #3 from Michael Schwendt  ---
The Fedora Project does a couple of packaging related things differently than
whatever distribution you've used before. Here's the result of a brief look at
the spec file.

Consider pointing the fedora-review tool at this ticket:

  fedora-review -b 1440704

It will evaluate the latest "Spec URL:" and "SRPM URL:" lines, download the
files and packages, perform local test-builds in Mock and run many checks on
the packages. The tool is relevant to package submitters, too.


> Patch0: cpprest-pthread.patch

https://fedoraproject.org/wiki/Packaging:Guidelines#Patch_Guidelines


> %package devel
> Summary:Development files for %{name}
> Requires:   libcpprest%{major}_%{minor} = %{version}

https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package


> %files -n libcpprest%{major}_%{minor}
> %defattr(-,root,root)
> %doc CONTRIBUTORS.txt license.txt ThirdPartyNotices.txt
> %{_libdir}/libcpprest.so.%{major}.%{minor}
> %{_libdir}/libcpprest.so

https://fedoraproject.org/wiki/Packaging:Guidelines#Devel_Packages


> %defattr(-,root,root)

https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions


> %package -n libcpprest%{major}_%{minor}

The naming of this subpackage is odd. What have you planned for updates that
touch %major or %minor or both?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1350884] Review Request: mspgcc - Rebase of GCC for the MSP430 to TI / Red Hat upstream

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1350884



--- Comment #9 from Brandon Nielsen  ---
(In reply to Elliott Sales de Andrade from comment #8)
> Since the old packages still exist, would it be helpful to mark these as
> Obsolete-ing the others?

That's definitely a good idea.

Upstream changed how the project is distributed and built back in January and
I'm only just getting around to changing my specfile to work with the new
versions.

I'll hopefully have an updated specfile and SRPM ready to go soon.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444954] Review Request: arm-trusted-firmware - ARM Trusted Firmware

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444954

Peter Robinson  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2017-04-24 16:35:16



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444618] Review Request: buildah - A command line tool to facilitate working with containers and using them to build images.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444618



--- Comment #1 from Lokesh Mandvekar  ---
mock build failed on my rawhide machine coz btrfs/ioctl.h not found.

Could you please add BuildRequires: btfs-progs-devel to the spec and post it
here?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1441828] Review Request: nuvolaplayer- Cloud Music Integration for your Linux Desktop

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1441828



--- Comment #10 from mgans...@alice.de  ---
nuvolaplayer compiles fine on F25 without this part in your patch:

@@ -546,16 +550,6 @@ def dist(ctx):
 ctx.archive = archive

 from waflib.TaskGen import extension
-@extension('.vapi')
-def vapi_file(self, node):
-try:
-valatask = self.valatask
-except AttributeError:
-valatask = self.valatask = self.create_task('valac')
-self.init_vala_task()
-
-valatask.inputs.append(node)
-
 from waflib import TaskGen, Utils, Errors, Node, Task
 from nuvolamergejs import mergejs as merge_js

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444954] Review Request: arm-trusted-firmware - ARM Trusted Firmware

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444954



--- Comment #2 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/arm-trusted-firmware

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1441828] Review Request: nuvolaplayer- Cloud Music Integration for your Linux Desktop

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1441828



--- Comment #9 from mgans...@alice.de  ---
(In reply to Vít Ondruch from comment #8)
> (In reply to mgans...@alice.de from comment #6)
> > 
> > 
> > 
> > [23/27] Compiling build/Transport.c
> > [24/27] Compiling build/jsapi.c
> > [25/27] Compiling build/jsexecutor.c
> > [26/27] Linking build/libengineio.so
> > [27/27] Linking build/libnuvolaplayer3-base.so
> > Waf: Leaving directory 
> > `/home/martin/rpmbuild/BUILD/nuvolaplayer-3.1.2/build'
> > File
> > /home/martin/rpmbuild/BUILD/nuvolaplayer-3.1.2/src/nuvolakit-runner/secret.
> > vapi has no mapping in ['.c', '.gs', '.vala', '.obj', '.o', '.pc.in'] (load
> > a waf tool?)
> > error: Bad exit status from /var/tmp/rpm-tmp.iXKaFq (%build)
> 
> Is this "waf build" again? Is this Rawhide?

yes it's "waf build" on F25 not Rawhide.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444954] Review Request: arm-trusted-firmware - ARM Trusted Firmware

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444954

Dennis Gilmore  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Dennis Gilmore  ---
Approved 

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
[ ]: %build honors applicable compiler flags or justifies otherwise.
[ ]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[ ]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[ ]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[!]: Uses parallel make %{?_smp_mflags} macro.
[ ]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[ ]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[ ]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed
 files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[x]: Spec use %global 

[Bug 1444954] Review Request: arm-trusted-firmware - ARM Trusted Firmware

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444954

Dennis Gilmore  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|den...@ausil.us



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444954] Review Request: arm-trusted-firmware - ARM Trusted Firmware

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444954

Dennis Gilmore  changed:

   What|Removed |Added

  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1220451] Review Request: zuul - Trunk gating system developed for the OpenStack Project

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1220451



--- Comment #18 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/zuul

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444954] New: Review Request: arm-trusted-firmware - ARM Trusted Firmware

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444954

Bug ID: 1444954
   Summary: Review Request: arm-trusted-firmware - ARM Trusted
Firmware
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: pbrobin...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
Blocks: 245418 (ARMTracker)



SPEC: https://pbrobinson.fedorapeople.org/arm-trusted-firmware.spec
SRPM:
https://pbrobinson.fedorapeople.org/arm-trusted-firmware-1.3-0.1.fc26.src.rpm

Description:
ARM Trusted firmware is a reference implementation of secure world software for
ARMv8-A including Exception Level 3 (EL3) software. I provides a number of 
standard ARM interfaces like Power State Coordination (PSCI), Trusted Board 
Boot Requirements (TBBR) and Secure Monitor.

Note: the contents of this package are generally just consumed by bootloaders
such as u-boot. As such the binaries aren't of general interest to users.

koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=19180481


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=245418
[Bug 245418] Tracker for ARM support
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444925] Review Request: python-rpm-generators - The RPM python dependency generators

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444925

Michal Cyprian  changed:

   What|Removed |Added

Summary|Review Request: |Review Request:
   | -   |python-rpm-generators - The
   | |generators



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1441828] Review Request: nuvolaplayer- Cloud Music Integration for your Linux Desktop

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1441828



--- Comment #8 from Vít Ondruch  ---
(In reply to mgans...@alice.de from comment #6)
> 
> 
> 
> [23/27] Compiling build/Transport.c
> [24/27] Compiling build/jsapi.c
> [25/27] Compiling build/jsexecutor.c
> [26/27] Linking build/libengineio.so
> [27/27] Linking build/libnuvolaplayer3-base.so
> Waf: Leaving directory `/home/martin/rpmbuild/BUILD/nuvolaplayer-3.1.2/build'
> File
> /home/martin/rpmbuild/BUILD/nuvolaplayer-3.1.2/src/nuvolakit-runner/secret.
> vapi has no mapping in ['.c', '.gs', '.vala', '.obj', '.o', '.pc.in'] (load
> a waf tool?)
> error: Bad exit status from /var/tmp/rpm-tmp.iXKaFq (%build)

Is this "waf build" again? Is this Rawhide?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444897] Review Request: python3-zope-component - Zope Component Architecture

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444897

Aurelien Bompard  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |NOTABUG
Last Closed||2017-04-24 11:11:33



--- Comment #1 from Aurelien Bompard  ---
Ah, my bad, python-zope-component is provided by EPEL, not RHEL/CentOS.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444464] Review Request: perl-Test-WriteVariants - Dynamic generation of tests in nested combinations of contexts

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=164

Jitka Plesnikova  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Jitka Plesnikova  ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Test-WriteVariants-0.012-1.fc27.noarch.rpm | sort |
uniq -c
i  1 perl(:MODULE_COMPAT_5.24.1)
  1 perl(Carp)
  1 perl(Data::Dumper)
  1 perl(Data::Tumbler) >= 0.002
  1 perl(File::Basename)
  1 perl(File::Path)
  1 perl(Module::Pluggable::Object) >= 4.9
  1 perl(Test::WriteVariants::Context)
  1 perl(Test::WriteVariants::Context::BaseItem)
  1 perl(base)
  1 perl(strict)
  1 perl(warnings)
  1 rpmlib(CompressedFileNames) <= 3.0.4-1
  1 rpmlib(FileDigests) <= 4.6.0-1
  1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
  1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Test-WriteVariants-0.012-1.fc27.noarch.rpm | sort |
uniq -c
  1 perl(Test::WriteVariants) = 0.012
  1 perl(Test::WriteVariants::Context)
  1 perl(Test::WriteVariants::Context::BaseItem)
  1 perl(Test::WriteVariants::Context::EnvVar)
  1 perl(Test::WriteVariants::Context::MetaInfo)
  1 perl(Test::WriteVariants::Context::ModuleUse)
  1 perl(Test::WriteVariants::Context::OurVar)
  1 perl-Test-WriteVariants = 0.012-1.fc27
Binary provides are Ok.

$ rpmlint ./perl-Test-WriteVariants*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

The package looks good.
Approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444925] Review Request: - < The RPM python dependency generators>

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444925

Igor Gnatenko  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|ignate...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444618] Review Request: buildah - A command line tool to facilitate working with containers and using them to build images.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444618

Lokesh Mandvekar  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||l...@redhat.com
   Assignee|nob...@fedoraproject.org|l...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444925] New: Review Request: - < The RPM python dependency generators>

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444925

Bug ID: 1444925
   Summary: Review Request:  - 
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: mcypr...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://mcyprian.fedorapeople.org/python-rpm-generators.spec
SRPM URL:
https://mcyprian.fedorapeople.org/python-rpm-generators-1-1.fc25.src.rpm
Description: This package contains RPM python dependency generators, which were
part of the rpm package before. Package rpm_build won't depend on Python 3
after python scripts are moved to separate package. This will also make minimal
build root smaller.
Fedora Account System Username: mcyprian

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1426785] Review Request: pyjoke - One line jokes for programmers ( jokes as a service)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1426785



--- Comment #7 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/pyjoke

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1441828] Review Request: nuvolaplayer- Cloud Music Integration for your Linux Desktop

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1441828



--- Comment #7 from mgans...@alice.de  ---
(In reply to Vít Ondruch from comment #5)
> Created attachment 1273606 [details]
> wscript patch
> 
> After some fighting, I was able to come up with the attached patch which
> enables build of nuvolaplayer. But I am afraid this should be discussed with
> upstream ...

upstream ticket: https://github.com/tiliado/nuvolaplayer/issues/327

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1441828] Review Request: nuvolaplayer- Cloud Music Integration for your Linux Desktop

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1441828



--- Comment #6 from mgans...@alice.de  ---
(In reply to Vít Ondruch from comment #5)
> Created attachment 1273606 [details]
> wscript patch
> 
> After some fighting, I was able to come up with the attached patch which
> enables build of nuvolaplayer. But I am afraid this should be discussed with
> upstream ...

I added the your patch to the spec file:
https://martinkg.fedorapeople.org/Packages/nuvolaplayer/nuvolaplayer.spec
now i get this message:



[23/27] Compiling build/Transport.c
[24/27] Compiling build/jsapi.c
[25/27] Compiling build/jsexecutor.c
[26/27] Linking build/libengineio.so
[27/27] Linking build/libnuvolaplayer3-base.so
Waf: Leaving directory `/home/martin/rpmbuild/BUILD/nuvolaplayer-3.1.2/build'
File
/home/martin/rpmbuild/BUILD/nuvolaplayer-3.1.2/src/nuvolakit-runner/secret.vapi
has no mapping in ['.c', '.gs', '.vala', '.obj', '.o', '.pc.in'] (load a waf
tool?)
error: Bad exit status from /var/tmp/rpm-tmp.iXKaFq (%build)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444897] New: Review Request: python3-zope-component - Zope Component Architecture

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444897

Bug ID: 1444897
   Summary: Review Request: python3-zope-component - Zope
Component Architecture
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: aurel...@bompard.org
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://abompard.fedorapeople.org/reviews/python3-zope-component/python3-zope-component.spec
SRPM URL:
https://abompard.fedorapeople.org/reviews/python3-zope-component/python3-zope-component-4.3.0-1.el7.centos.src.rpm
Description:
This module is already provided by RHEL/CentOS, but only in the Python2
version. I am submitting this package, based on the main one, which only builds
the Python3 version, and I'll only request the EPEL7 branch (and later EPEL
versions).

Fedora Account System Username: abompard

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444464] Review Request: perl-Test-WriteVariants - Dynamic generation of tests in nested combinations of contexts

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=164

Jitka Plesnikova  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jples...@redhat.com
   Assignee|nob...@fedoraproject.org|jples...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444464] Review Request: perl-Test-WriteVariants - Dynamic generation of tests in nested combinations of contexts

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=164
Bug 164 depends on bug 163, which changed state.

Bug 163 Summary: Review Request: perl-Test-Directory - Perl extension for 
maintaining test directories
https://bugzilla.redhat.com/show_bug.cgi?id=163

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444463] Review Request: perl-Test-Directory - Perl extension for maintaining test directories

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=163

Petr Pisar  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
   Fixed In Version||perl-Test-Directory-0.041-1
   ||.fc27
 Resolution|--- |RAWHIDE
Last Closed||2017-04-24 09:00:27



--- Comment #3 from Petr Pisar  ---
Thank you for the review and the repository. I added the dependency on make.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444736] Review Request: perl-re-engine-PCRE2 - PCRE2 regular expression engine for Perl

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444736



--- Comment #2 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/perl-re-engine-PCRE2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444463] Review Request: perl-Test-Directory - Perl extension for maintaining test directories

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=163



--- Comment #2 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Test-Directory

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1441828] Review Request: nuvolaplayer- Cloud Music Integration for your Linux Desktop

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1441828



--- Comment #5 from Vít Ondruch  ---
Created attachment 1273606
  --> https://bugzilla.redhat.com/attachment.cgi?id=1273606=edit
wscript patch

After some fighting, I was able to come up with the attached patch which
enables build of nuvolaplayer. But I am afraid this should be discussed with
upstream ...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444819] Review Request: golang-gopkg-tylerb-graceful-v1 - Graceful is a Go 1.3+ package enabling graceful shutdown of http.Handler servers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444819



--- Comment #3 from Simon Fels  ---
@Neil: Fixed those.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444819] Review Request: golang-gopkg-tylerb-graceful-v1 - Graceful is a Go 1.3+ package enabling graceful shutdown of http.Handler servers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444819



--- Comment #2 from Neal Gompa  ---
This package looks like it has remnants of gopkg.in/retry.v1 in it, please
clean up and make sure that everything is sane.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444819] Review Request: golang-gopkg-tylerb-graceful-v1 - Graceful is a Go 1.3+ package enabling graceful shutdown of http.Handler servers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444819

Neal Gompa  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|ngomp...@gmail.com
  Flags||fedora-review?



--- Comment #1 from Neal Gompa  ---
Taking this review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444822] Review Request: nodejs-portfinder - A simple tool to find an open port or domain socket on the current machine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444822



--- Comment #1 from Parag Nemade  ---
This package built on koji: 
https://koji.fedoraproject.org/koji/taskinfo?taskID=19176572

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444822] New: Review Request: nodejs-portfinder - A simple tool to find an open port or domain socket on the current machine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444822

Bug ID: 1444822
   Summary: Review Request: nodejs-portfinder - A simple tool to
find an open port or domain socket on the current
machine
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: pnem...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org




Spec URL: http://pnemade.fedorapeople.org/fedora-work/nodejs-portfinder.spec
SRPM URL:
http://pnemade.fedorapeople.org/fedora-work/nodejs-portfinder-1.0.13-1.fc26.src.rpm

Description:
A simple tool to find an open port or domain socket on the current machine.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444819] New: Review Request: golang-gopkg-tylerb-graceful-v1 - Graceful is a Go 1.3+ package enabling graceful shutdown of http.Handler servers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444819

Bug ID: 1444819
   Summary: Review Request: golang-gopkg-tylerb-graceful-v1 -
Graceful is a Go 1.3+ package enabling graceful
shutdown of http.Handler servers
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: morp...@gravedo.de
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://mm.gravedo.de/files/golang-gopkg-tylerb-graceful-v1.spec
SRPM URL:
https://mm.gravedo.de/files/golang-gopkg-tylerb-graceful-v1-1-1.2.15.git4654dfb.fc25.src.rpm

Description: 

This packages the golang package gopkg.in/retry.v1 which enables graceful
shutdown of http.Handler servers.

Fedora Account System Username: mrmorph

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444736] Review Request: perl-re-engine-PCRE2 - PCRE2 regular expression engine for Perl

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444736

Jitka Plesnikova  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Jitka Plesnikova  ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-re-engine-PCRE2-0.11-1.fc27.x86_64.rpm | sort | uniq
-c
  1 libc.so.6()(64bit)
  1 libc.so.6(GLIBC_2.2.5)(64bit)
  1 libc.so.6(GLIBC_2.4)(64bit)
  1 libpcre2-8.so.0()(64bit)
  1 libperl.so.5.24()(64bit)
  1 perl(:MODULE_COMPAT_5.24.1)
  1 perl(:VERSION) >= 5.10.0
  1 perl(XSLoader)
  1 perl(strict)
  1 rpmlib(CompressedFileNames) <= 3.0.4-1
  1 rpmlib(FileDigests) <= 4.6.0-1
  1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
  1 rpmlib(PayloadIsXz) <= 5.2-1
  1 rtld(GNU_HASH)
Binary requires are Ok.

$ rpm -qp --provides perl-re-engine-PCRE2-0.11-1.fc27.x86_64.rpm | sort | uniq
-c
  1 perl(re::engine::PCRE2) = 0.11
  1 perl-re-engine-PCRE2 = 0.11-1.fc27
  1 perl-re-engine-PCRE2(x86-64) = 0.11-1.fc27
Binary provides are Ok.

$ rpmlint ./perl-re-engine-PCRE2*
perl-re-engine-PCRE2.x86_64: W: hidden-file-or-dir /usr/lib/.build-id
perl-re-engine-PCRE2.x86_64: W: hidden-file-or-dir /usr/lib/.build-id
perl-re-engine-PCRE2.x86_64: E: incorrect-fsf-address
/usr/share/licenses/perl-re-engine-PCRE2/LICENSE
2 packages and 1 specfiles checked; 1 errors, 2 warnings.
NOTE: incorrect-fsf-address was reported to upstream

Rpmlint is ok

The package looks good.
Approved

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444736] Review Request: perl-re-engine-PCRE2 - PCRE2 regular expression engine for Perl

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444736

Jitka Plesnikova  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jples...@redhat.com
   Assignee|nob...@fedoraproject.org|jples...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431763] Review Request: golang-github-oschwald-geoip2-golang - GeoIP2 lookup library for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431763



--- Comment #14 from Fedora Update System  ---
golang-github-oschwald-geoip2-golang-1.1.0-1.fc24 has been submitted as an
update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-c4a6754314

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431763] Review Request: golang-github-oschwald-geoip2-golang - GeoIP2 lookup library for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431763

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431763] Review Request: golang-github-oschwald-geoip2-golang - GeoIP2 lookup library for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431763



--- Comment #13 from Fedora Update System  ---
golang-github-oschwald-geoip2-golang-1.1.0-1.fc25 has been submitted as an
update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-dd3997794d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444766] Review Request: nodejs-eventemitter3 - EventEmitter3 is a high performance EventEmmitter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444766



--- Comment #1 from Parag Nemade  ---
This package built on koji: 
https://koji.fedoraproject.org/koji/taskinfo?taskID=19174213

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444766] New: Review Request: nodejs-eventemitter3 - EventEmitter3 is a high performance EventEmmitter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444766

Bug ID: 1444766
   Summary: Review Request: nodejs-eventemitter3 - EventEmitter3
is a high performance EventEmmitter
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: pnem...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org




Spec URL: http://pnemade.fedorapeople.org/fedora-work/nodejs-eventemitter3.spec
SRPM URL:
http://pnemade.fedorapeople.org/fedora-work/nodejs-eventemitter3-2.0.3-1.fc26.src.rpm

Description:
EventEmitter3 is a high performance EventEmitter. It has been micro-optimized
for various of code paths making this, one of, if not the fastest EventEmitter
available for Node.js and browsers. The module is API compatible with the
EventEmitter that ships by default with Node.js.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444765] Review Request: nodejs-requires-port - Check if a protocol requires a certain port number

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444765



--- Comment #1 from Parag Nemade  ---
This package built on koji: 
https://koji.fedoraproject.org/koji/taskinfo?taskID=19174257

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444765] New: Review Request: nodejs-requires-port - Check if a protocol requires a certain port number

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444765

Bug ID: 1444765
   Summary: Review Request: nodejs-requires-port - Check if a
protocol requires a certain port number
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: pnem...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org




Spec URL: http://pnemade.fedorapeople.org/fedora-work/nodejs-requires-port.spec
SRPM URL:
http://pnemade.fedorapeople.org/fedora-work/nodejs-requires-port-1.0.0-1.fc26.src.rpm

Description:
This module is intended to be used with browserify or Node.js
and is distributed in the public npm registry.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1410009] Review Request: mimic - Mycroft's TTS engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1410009

Peter Robinson  changed:

   What|Removed |Added

  Flags||needinfo?(pwha...@redhat.co
   ||m)



--- Comment #3 from Peter Robinson  ---
I believe 1.2.0.2 resolved the license issues between the actual copying file
and associated source file updates:

https://github.com/MycroftAI/mimic/blob/master/COPYING

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444634] Review Request: openvdb - C++ library for sparse volumetric data discretized on three-dimensional grids

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444634

Sascha Spreitzer  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||sspre...@redhat.com
   Assignee|nob...@fedoraproject.org|sspre...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444463] Review Request: perl-Test-Directory - Perl extension for maintaining test directories

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=163

Jitka Plesnikova  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Jitka Plesnikova  ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

$ rpm -qp --requires perl-Test-Directory-0.041-1.fc27.noarch.rpm | sort | uniq
-c
  1 perl(:MODULE_COMPAT_5.24.1)
  1 perl(Carp)
  1 perl(Fcntl)
  1 perl(File::Spec)
  1 perl(File::Temp)
  1 perl(Test::Builder::Module)
  1 perl(strict)
  1 perl(warnings)
  1 rpmlib(CompressedFileNames) <= 3.0.4-1
  1 rpmlib(FileDigests) <= 4.6.0-1
  1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
  1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Test-Directory-0.041-1.fc27.noarch.rpm | sort | uniq
-c
  1 perl(Test::Directory) = 0.041
  1 perl-Test-Directory = 0.041-1.fc27
Binary provides are Ok.

$ rpmlint ./perl-Test-Directory*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

BuildRequires are almost ok
FIX: Please add build-require 'make'

Please correct 'FIX' issue.

The package looks good.
Approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444736] New: Review Request: perl-re-engine-PCRE2 - PCRE2 regular expression engine for Perl

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444736

Bug ID: 1444736
   Summary: Review Request: perl-re-engine-PCRE2 - PCRE2 regular
expression engine for Perl
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: ppi...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://ppisar.fedorapeople.org/perl-re-engine-PCRE2/perl-re-engine-PCRE2.spec
SRPM URL:
https://ppisar.fedorapeople.org/perl-re-engine-PCRE2/perl-re-engine-PCRE2-0.11-1.fc27.src.rpm
Description:
This Perl module replaces perl's regex engine in a given lexical scope with
PCRE2 regular expressions provided by libpcre2-8.

Fedora Account System Username: ppisar

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1420384] Review Request: phpcov - CLI frontend for PHP_CodeCoverage

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1420384



--- Comment #6 from Remi Collet  ---
Thanks for the review.

Cleanup done in
http://pkgs.fedoraproject.org/cgit/rpms/phpcov.git/commit/?id=998fecd80c08571ce002a363f9bb9049581a8cad

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1420384] Review Request: phpcov - CLI frontend for PHP_CodeCoverage

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1420384

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1420384] Review Request: phpcov - CLI frontend for PHP_CodeCoverage

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1420384



--- Comment #5 from Fedora Update System  ---
phpcov-4.0.0-2.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-15266e9f04

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444615] Review Request: python2-ipython - An enhanced interactive Python shell (Python 2 version)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444615



--- Comment #2 from Lumír Balhar  ---
Fixed in original files.

New Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=19171637

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org