[Bug 1457949] Review Request: libdxflib - A C++ library for reading and writing DXF files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1457949



--- Comment #20 from Fedora Update System  ---
libdxflib-3.17.0-2.fc24 has been pushed to the Fedora 24 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1350884] Review Request: mspgcc - Rebase of GCC for the MSP430 to TI / Red Hat upstream

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1350884



--- Comment #13 from Elliott Sales de Andrade  ---
For g++ subpackage, I'd check original gcc, maybe.  Same for gnulib, assuming
it has also been bundling it. The illegal package name has to do with including
static files in a package name without -static suffix, which is likely not
relevant here.

I'd say pinging someone from the Embedded SIG might be useful:
https://fedoraproject.org/wiki/Embedded

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1469396] Review Request: hotspot - The Linux perf GUI for performance analysis

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1469396



--- Comment #7 from Fedora Update System  ---
hotspot-1.0.0-1.fc26 has been pushed to the Fedora 26 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-ef275a5084

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470580] Review Request: rubygem-factory_girl - Framework and DSL for defining and using model instance factories

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470580

Pavel Valena  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Pavel Valena  ---
Package Review
==
 - Will you be unretiring the package in two commits? The first one being spec
file checkout to 533041868174e19827d4a7374333f20e4b0f377d.
 - Is there any reason for inclusion of `cucumber.yml`?
 - I'd recommend you to use %{gem_name} in `%exclude
%{gem_instdir}/factory_girl.gemspec`

Apart from my questions/recommendations above the package is fine, therefore


I APPROVE this package.


Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

= MUST items =
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[x]: Avoid bundling fonts in non-fonts packages.
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
 files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: 

[Bug 1433757] Review Request: python-glyphsLib - A bridge from Glyphs source files to UFOs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1433757



--- Comment #6 from Elliott Sales de Andrade  ---
A non-random URL can be done like:
https://files.pythonhosted.org/packages/source/g/%{srcname}/%{srcname}-%{version}.tar.gz

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1469396] Review Request: hotspot - The Linux perf GUI for performance analysis

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1469396

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #6 from Fedora Update System  ---
hotspot-1.0.0-1.fc25 has been pushed to the Fedora 25 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-6588dc96d6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1465881] Review Request: golang-github-cznic-lexer - Run time generator of action less scanners written in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1465881



--- Comment #3 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/golang-github-cznic-lexer

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1465881] Review Request: golang-github-cznic-lexer - Run time generator of action less scanners written in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1465881



--- Comment #2 from Fabio Valentini  ---
Thanks for the review! I'll look at (re)moving the test_deps.go file before
building the package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1457949] Review Request: libdxflib - A C++ library for reading and writing DXF files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1457949



--- Comment #19 from Fedora Update System  ---
libdxflib-3.17.0-2.fc25 has been pushed to the Fedora 25 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470842] New: Review Request: bazel - A fast, scalable, multi-language and extensible build system

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470842

Bug ID: 1470842
   Summary: Review Request: bazel - A fast, scalable,
multi-language and extensible build system
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: sjenn...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://www.variantweb.net/pub/bazel.spec
SRPM URL: https://www.variantweb.net/pub/bazel-0.5.2-1.fc26.src.rpm

Description:
Bazel is a build tool which coordinates builds and runs tests. The extension
language allows it to work with source files written in any language, with
native support for Java, C, C++ and Python. Bazel produces builds and runs
tests for multiple platforms.

Fedora Account System Username: sjenning

Notably, this is the build tool for Kubernetes and will soon be required for
developers on that project.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1467322] Review Request: manifest-tool - A command line tool used for creating manifest list objects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1467322



--- Comment #15 from Fedora Update System  ---
manifest-tool-0.6.0-4.gita28af2b.el7 has been submitted as an update to Fedora
EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-bef4cbcf4b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1467322] Review Request: manifest-tool - A command line tool used for creating manifest list objects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1467322

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1467322] Review Request: manifest-tool - A command line tool used for creating manifest list objects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1467322



--- Comment #14 from Fedora Update System  ---
manifest-tool-0.6.0-3.gita28af2b.fc25 has been submitted as an update to Fedora
25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-b093304055

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1293694] Review Request: byte-buddy - Runtime code generation for the Java virtual machine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1293694

Raphael Groner  changed:

   What|Removed |Added

 CC||punto...@libero.it
  Flags||needinfo?(puntogil@libero.i
   ||t)



--- Comment #8 from Raphael Groner  ---
awaitility (and so byte-buddy as dependency) is needed for some tests of
rabbitmq-java-client version 4.1.1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1419317] Review Request: deepin-terminal - terminal emulation application

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1419317

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zbys...@in.waw.pl
   Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl



--- Comment #1 from Zbigniew Jędrzejewski-Szmek  ---
The usual:
- please link to the raw spec file for fedora-review's sake
- underscores on macros are not necessary

It would be great to add an appdata file
[https://fedoraproject.org/wiki/Packaging:AppData]. This will make it easier to
discover and install deepin-terminal for users of other desktop environments.
I'm assuming it's independently usable.

It doesn't build in rawhide and F26 currently:
/builddir/build/BUILD/deepin-terminal-4f7069e064ae4e5437013295fd5bdbfd8867086c/./lib/animation.vala:33.9-33.43:
 
warning: the modifier `static' is not applicable to constants
public static const int FAST = 250; /* Good for animations that convey
duplicated information */
^^^
/builddir/build/BUILD/deepin-terminal-4f7069e064ae4e5437013295fd5bdbfd8867086c/./lib/animation.vala:34.9-34.46:
 
warning: the modifier `static' is not applicable to constants
public static const int INSTANT = 150; /* Good for animations that
don't convey any information */
^^
/builddir/build/BUILD/deepin-terminal-4f7069e064ae4e5437013295fd5bdbfd8867086c/./lib/animation.vala:35.9-35.45:
 
warning: the modifier `static' is not applicable to constants
public static const int NORMAL = 500;
^
/builddir/build/BUILD/deepin-terminal-4f7069e064ae4e5437013295fd5bdbfd8867086c/./lib/animation.vala:36.9-36.44:
warning: the modifier `static' is not applicable to constants
public static const int SLOW = 1000; /* Good for animations that convey
information that is only presented in the animation */

gee-0.8.vapi:278.3-278.31: error: overriding method `Gee.HashSet.foreach' is
incompatible with base method `Gee.AbstractCollection.foreach': incompatible
type of parameter 1.
public override bool @foreach (Gee.ForallFunc f);
^
gee-0.8.vapi:278.3-278.31: error: Gee.HashSet.foreach: no suitable method found
to override
public override bool @foreach (Gee.ForallFunc f);
^
gee-0.8.vapi:368.3-368.31: error: overriding method `Gee.PriorityQueue.foreach'
is incompatible with base method `Gee.AbstractCollection.foreach': incompatible
type of parameter 1.
public override bool @foreach (Gee.ForallFunc f);
^
gee-0.8.vapi:368.3-368.31: error: Gee.PriorityQueue.foreach: no suitable method
found to override
public override bool @foreach (Gee.ForallFunc f);
   
/builddir/build/BUILD/deepin-terminal-4f7069e064ae4e5437013295fd5bdbfd8867086c/./widget/quake_window.vala:43.27-43.54:
warning: Gdk.Screen.get_monitor_at_window has been deprecated since 3.22
/builddir/build/BUILD/deepin-terminal-4f7069e064ae4e5437013295fd5bdbfd8867086c/./widget/quake_window.vala:43.56-43.79:
warning: Gdk.Screen.get_active_window has been deprecated since 3.22
/builddir/build/BUILD/deepin-terminal-4f7069e064ae4e5437013295fd5bdbfd8867086c/./widget/quake_window.vala:45.13-45.39:
warning: Gdk.Screen.get_monitor_geometry has been deprecated since 3.22
/builddir/build/BUILD/deepin-terminal-4f7069e064ae4e5437013295fd5bdbfd8867086c/./widget/quake_window.vala:293.27-293.54:
warning: Gdk.Screen.get_monitor_at_window has been deprecated since 3.22
/builddir/build/BUILD/deepin-terminal-4f7069e064ae4e5437013295fd5bdbfd8867086c/./widget/quake_window.vala:293.56-293.79:
warning: Gdk.Screen.get_active_window has been deprecated since 3.22
/builddir/build/BUILD/deepin-terminal-4f7069e064ae4e5437013295fd5bdbfd8867086c/./widget/quake_window.vala:295.13-295.39:
warning: Gdk.Screen.get_monitor_geometry has been deprecated since 3.22
/builddir/build/BUILD/deepin-terminal-4f7069e064ae4e5437013295fd5bdbfd8867086c/./widget/quake_window.vala:177.34-177.61:
warning: Gdk.Screen.get_monitor_at_window has been deprecated since 3.22
/builddir/build/BUILD/deepin-terminal-4f7069e064ae4e5437013295fd5bdbfd8867086c/./widget/quake_window.vala:177.63-177.86:
warning: Gdk.Screen.get_active_window has been deprecated since 3.22
/builddir/build/BUILD/deepin-terminal-4f7069e064ae4e5437013295fd5bdbfd8867086c/./widget/quake_window.vala:178.34-178.61:
warning: Gdk.Screen.get_monitor_at_window has been deprecated since 3.22
/builddir/build/BUILD/deepin-terminal-4f7069e064ae4e5437013295fd5bdbfd8867086c/./widget/quake_window.vala:181.13-181.39:
warning: 

[Bug 1470702] Review Request: rubygem-jekyll-sitemap

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470702

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Depends On||1470699




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1470699
[Bug 1470699] New version of rubygem-jekyll is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1341662] Review Request: fedora-developer-portal - Offline Fedora Developer Portal

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1341662

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Depends On|1470699 |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1470699
[Bug 1470699] New version of rubygem-jekyll is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470702] Review Request: rubygem-jekyll-sitemap

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470702

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 CC||zbys...@in.waw.pl



--- Comment #1 from Zbigniew Jędrzejewski-Szmek  ---
Looks reasonable. Everything in https://fedoraproject.org/wiki/Packaging:Ruby
seems to be followed, but I know zilch about ruby, so it'd be better if
somebody else reviewed this package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1468830] Review Request: abbayedesmorts-gpl - Platform game set in 13th century

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1468830



--- Comment #6 from Andrea Musuruane  ---
Spec URL: https://musuruan.fedorapeople.org/abbayedesmorts-gpl.spec
SRPM URL:
https://musuruan.fedorapeople.org/abbayedesmorts-gpl-2.0.1-2.20170709git.fc25.src.rpm

Changelog:
- Updated to new upstream post-release
- Added missing BR

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1468861] Review Request: dtksettings - DtkSettings is a powerful tool to generate config from json

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1468861



--- Comment #12 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/dtksettings

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1341662] Review Request: fedora-developer-portal - Offline Fedora Developer Portal

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1341662

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl
  Flags||fedora-review?



--- Comment #12 from Zbigniew Jędrzejewski-Szmek  ---
URL: should give the full URL to the upstream tarball, so it's possible to
build the whole file from the spec file, and to verify that the tarball you
have matches the upstream tarball.

The build part (everything starting from "jekyll build") should be in the
%build section.

The kill part is indeed tough. My idea of putting 'jekyll serve' in the
background does not work because it takes a while for jekyll to open the
listening port, and we have to wait for that, but there's not synchronization
mechanism. So using '--detach' seems like the only option.

I'd do this:

diff --git fedora-developer-portal.spec fedora-developer-portal.spec
index a711e0b05b..6ea026e24b 100644
--- fedora-developer-portal.spec
+++ fedora-developer-portal.spec
@@ -49,6 +49,8 @@ touch _includes/announcement.html
 gem install jekyll-lunr-js-search
 gem install jekyll-sitemap

+%build
+
 # Build the site and start server
 jekyll build
 jekyll serve --detach
@@ -60,9 +62,7 @@ wget --convert-links -r http://127.0.0.1:4000/ || :
 mv 127.0.0.1\:4000/ fedora-developer-portal-content-%{shortcommit}

 # Kill server in the background
-kill -9 `ps aux | grep jekyll | awk '{print $2}'` || :
-
-%build
+pgrep -f 'jekyll serve --detach' | xargs kill

 %install
 mkdir -p %buildroot%{_bindir}
-

OK, let's concentrate on the deps. This package looks good. I'll add
fedora-review+ when the deps are ready.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1468861] Review Request: dtksettings - DtkSettings is a powerful tool to generate config from json

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1468861



--- Comment #11 from Felix Yan  ---
Requested, status is now "Awaiting Review".

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1468861] Review Request: dtksettings - DtkSettings is a powerful tool to generate config from json

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1468861



--- Comment #10 from Zbigniew Jędrzejewski-Szmek  ---
Now you need to request a new package in the pkgdb:
https://admin.fedoraproject.org/pkgdb/request/package/.
https://fedoraproject.org/wiki/PackageDB_admin_requests has some additional
docs.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1468861] Review Request: dtksettings - DtkSettings is a powerful tool to generate config from json

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1468861



--- Comment #9 from Felix Yan  ---
Sorry I overlooked the description-line-too-long error. Updated again:

Spec URL:
https://raw.githubusercontent.com/felixonmars/fedora-staging/37efb2c44daec4badb0442422c184a2eec9c46e1/dtksettings/dtksettings.spec
SRPM URL:
https://raw.githubusercontent.com/felixonmars/fedora-staging/37efb2c44daec4badb0442422c184a2eec9c46e1/dtksettings/dtksettings-0.1.7-1.git34d321e.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1468861] Review Request: dtksettings - DtkSettings is a powerful tool to generate config from json

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1468861



--- Comment #8 from Felix Yan  ---
Thank you. I have also adjusted the Summary field a bit.

Spec URL:
https://raw.githubusercontent.com/felixonmars/fedora-staging/0231c295d5cea631a304f6e3c3ca356a6bb9282b/dtksettings/dtksettings.spec
SRPM URL:
https://raw.githubusercontent.com/felixonmars/fedora-staging/0231c295d5cea631a304f6e3c3ca356a6bb9282b/dtksettings/dtksettings-0.1.7-1.git34d321e.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268360] Review Request: rubygem-simple_oauth - Simply builds and verifies OAuth headers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268360



--- Comment #17 from Pavel Valena  ---
These following issues are still valid.

>  Issues 
>  - README.md and CONTRIBUTING.md should be in `doc` subpackage.
>  - Release should be 1 (also remove changelog entries)
>  - Move all `%exclude` macros to main package
>  - Include Gemfile and Rakefile in `doc` subpackage
>  - Add `ruby` BuildRequire to ensure MRI is used for tests.
>  - Use Fedora 27 dist tag to create srpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268360] Review Request: rubygem-simple_oauth - Simply builds and verifies OAuth headers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268360



--- Comment #16 from Pavel Valena  ---
(In reply to Ilya Gradina from comment #14)
> Thx, for review.
> 
> I have a few questions.
> 
> 1. "Use Fedora 27 dist tag to create srpm"
>   - Why can not I use 26?

Fedora 27 is current rawhide version. Previously 26 was correct, but now it's
currently release so it's eligible for updates only AFAIK.

> 
> 2. "Add `ruby` BuildRequire to ensure MRI is used for tests."
>   - What did you mean? "BuildRequires: ruby(release)" - already available.

This could in some case pull 'jruby' instead of 'ruby' dependency, as both
satisfy this require.

```
$ dnf repoquery -q --disablerepo='*' --qf "%{name}" --enablerepo='rawhide'
--whatprovides 'ruby(release)'
jruby
ruby-libs
```

> 
> 3. "Move all `%exclude` macros to main package"
>   - you meant all `%exclude` macros move to section %files

Yes, that's correct. %files section without arg creates main package and
'%files doc' creates the doc subpackage for this package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421041] Review Request: deepin-gettext-tools - Deepin Gettext Tools

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421041

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1189171] Review Request: antlr-python - Python runtime support for ANTLR-generated parsers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1189171

Germano Massullo  changed:

   What|Removed |Added

  Flags||needinfo?(germano.massullo@
   ||gmail.com)



--- Comment #15 from Germano Massullo  ---
(In reply to Dominik 'Rathann' Mierzejewski from comment #14)
> Thanks for the comments, Miro. I'll address them soon.
> 
> (In reply to Miro Hrončok from comment #13)
> > (In reply to Germano Massullo from comment #11)
> > > And another thing. Please remove the big comment block at the beginning of
> > > spec file, because LICENSE file is the proper place to insert licensing 
> > > stuff
> > 
> > I would think of that comment block as a license for the specfile itself,
> > not the package content. This is not forbidden in Fedora.
> 
> That's correct. Also, I wanted to minimize divergence from RHEL spec.

Okay

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1468861] Review Request: dtksettings - DtkSettings is a powerful tool to generate config from json

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1468861

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|NEW |POST



--- Comment #7 from Zbigniew Jędrzejewski-Szmek  ---
%description
This package provides a Dtk module which can generate user configuration and UI
dialog from json.

("generate config" is unclear)


%description devel
→ add "." at the end. All %description:s should have a dot (but Summary:ies
not).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1441023] Review Request: python-fontmake - Compile fonts from sources to binary

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1441023



--- Comment #1 from Athos Ribeiro  ---
New sources

Spec URL: https://athoscr.fedorapeople.org/packaging/python-fontmake.spec
SRPM URL:
https://athoscr.fedorapeople.org/packaging/python-fontmake-1.2.6-1.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1433757] Review Request: python-glyphsLib - A bridge from Glyphs source files to UFOs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1433757



--- Comment #5 from Athos Ribeiro  ---
Thank you Elliot and Fabio :)

- I believe that when pypi started providing random URLs only, python packagers
started preferring to fetch sources from github. Since this new pypi.org seems
to be a 'pre-production' instance, I would rather fetch sources from github,
since there are tags in upstream repositories. I will switch to pypi if needed,
though :)

- Project name changed. I do prefer to use them just like upstream, but some
reviewers do complain about cammelcases :(

- Package updated! 

Spec URL: https://athoscr.fedorapeople.org/packaging/python-glyphsLib.spec
SRPM URL:
https://athoscr.fedorapeople.org/packaging/python-glyphsLib-1.7.5-1.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1432983] Review Request: camotics - Open-Source Simulation & Computer Aided Machining - A 3-axis CNC GCode simulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1432983
Bug 1432983 depends on bug 1457949, which changed state.

Bug 1457949 Summary: Review Request: libdxflib - A C++ library for reading and 
writing DXF files
https://bugzilla.redhat.com/show_bug.cgi?id=1457949

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1457949] Review Request: libdxflib - A C++ library for reading and writing DXF files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1457949

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-07-13 10:50:59



--- Comment #18 from Fedora Update System  ---
libdxflib-3.17.0-2.fc26 has been pushed to the Fedora 26 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1463092] Review Request: python-vulture - Find Dead Code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1463092

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-07-13 10:50:56



--- Comment #15 from Fedora Update System  ---
python-vulture-0.14-3.fc26 has been pushed to the Fedora 26 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1433757] Review Request: python-glyphsLib - A bridge from Glyphs source files to UFOs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1433757

Athos Ribeiro  changed:

   What|Removed |Added

Summary|Review Request: |Review Request:
   |python-glyphslib - A bridge |python-glyphsLib - A bridge
   |from Glyphs source files to |from Glyphs source files to
   |UFOs|UFOs



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1458840] Review Request: urw-base35-fonts - Level 2 Core Font Set for Ghostscript

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1458840

David Kaspar [Dee'Kej]  changed:

   What|Removed |Added

 Blocks||1470700




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1470700
[Bug 1470700] ps2pdf crashes on s309x only: Error: /invalidfont in
/findfont
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470580] Review Request: rubygem-factory_girl - Framework and DSL for defining and using model instance factories

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470580

Pavel Valena  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||pval...@redhat.com
   Assignee|nob...@fedoraproject.org|pval...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1465881] Review Request: golang-github-cznic-lexer - Run time generator of action less scanners written in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1465881

Athos Ribeiro  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Athos Ribeiro  ---
Hi Fabio, I am taking this one.

- It seems that the file test_deps.go should not be in the -devel package. It
probably should not be shipped at all, but if it is to be shipped, I believe it
should go in the unit tests sub-package.

Other than that, the package looks great. I will not block this review, since
that is basically a blank file anyway.

Approved.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
 files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags 

[Bug 1465881] Review Request: golang-github-cznic-lexer - Run time generator of action less scanners written in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1465881

Athos Ribeiro  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||athoscribe...@gmail.com
   Assignee|nob...@fedoraproject.org|athoscribe...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470678] Review Request: perl-Data-Dmp - Dump Perl data structures as Perl code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470678

Jitka Plesnikova  changed:

   What|Removed |Added

 Blocks||1470705




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1470705
[Bug 1470705] Review Request: perl-Log-ger - Lightweight, flexible logging
framework
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470705] Review Request: perl-Log-ger - Lightweight, flexible logging framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470705

Jitka Plesnikova  changed:

   What|Removed |Added

 Blocks||1469515
 Depends On||1470678




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1469515
[Bug 1469515] perl-Perl-Stripper-0.10 is available
https://bugzilla.redhat.com/show_bug.cgi?id=1470678
[Bug 1470678] Review Request: perl-Data-Dmp - Dump Perl data structures as
Perl code
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470705] New: Review Request: perl-Log-ger - Lightweight, flexible logging framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470705

Bug ID: 1470705
   Summary: Review Request: perl-Log-ger - Lightweight, flexible
logging framework
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: jples...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://jplesnik.fedorapeople.org/perl-Log-ger/perl-Log-ger.spec
SRPM URL:
https://jplesnik.fedorapeople.org/perl-Log-ger/perl-Log-ger-0.015-1.fc27.src.rpm

Description:
This module provides another lightweight, flexible logging framework.

Fedora Account System Username: jples...@redhat.com

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470702] Review Request: rubygem-jekyll-sitemap

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470702

František Zatloukal  changed:

   What|Removed |Added

 Blocks||1341662




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1341662
[Bug 1341662] Review Request: fedora-developer-portal - Offline Fedora
Developer Portal
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470702] New: Review Request: rubygem-jekyll-sitemap

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470702

Bug ID: 1470702
   Summary: Review Request: rubygem-jekyll-sitemap
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: fzatl...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



SPEC:
https://copr-be.cloud.fedoraproject.org/results/frantisekz/fedora-developer-portal/fedora-26-x86_64/00578946-rubygem-jekyll-sitemap/rubygem-jekyll-sitemap.spec

SRPM:
https://copr-be.cloud.fedoraproject.org/results/frantisekz/fedora-developer-portal/fedora-26-x86_64/00578946-rubygem-jekyll-sitemap/rubygem-jekyll-sitemap-1.1.1-1.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1341662] Review Request: fedora-developer-portal - Offline Fedora Developer Portal

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1341662

František Zatloukal  changed:

   What|Removed |Added

 Depends On||1470699, 1470702




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1470699
[Bug 1470699] New version of rubygem-jekyll is available
https://bugzilla.redhat.com/show_bug.cgi?id=1470702
[Bug 1470702] Review Request: rubygem-jekyll-sitemap
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1465889] Tracking: Deepin Desktop related package review tracker

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1465889
Bug 1465889 depends on bug 1469951, which changed state.

Bug 1469951 Summary: Review Request: perl-XML-LibXML-PrettyPrint - Add pleasant 
white space to an XML tree
https://bugzilla.redhat.com/show_bug.cgi?id=1469951

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1469951] Review Request: perl-XML-LibXML-PrettyPrint - Add pleasant white space to an XML tree

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1469951

Petr Pisar  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
   Fixed In Version||perl-XML-LibXML-PrettyPrint
   ||-0.006-1.fc27
 Resolution|--- |RAWHIDE
Last Closed||2017-07-13 09:02:20



--- Comment #5 from Petr Pisar  ---
Thank you for the review and the repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470656] Review Request: perl-Regexp-Stringify - Stringify a Regexp object

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470656

Jitka Plesnikova  changed:

   What|Removed |Added

 Blocks||1470678




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1470678
[Bug 1470678] Review Request: perl-Data-Dmp - Dump Perl data structures as
Perl code
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470678] Review Request: perl-Data-Dmp - Dump Perl data structures as Perl code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470678

Jitka Plesnikova  changed:

   What|Removed |Added

 Depends On||1470656




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1470656
[Bug 1470656] Review Request: perl-Regexp-Stringify - Stringify a Regexp
object
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470678] New: Review Request: perl-Data-Dmp - Dump Perl data structures as Perl code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470678

Bug ID: 1470678
   Summary: Review Request: perl-Data-Dmp - Dump Perl data
structures as Perl code
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: jples...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://jplesnik.fedorapeople.org/perl-Data-Dmp/perl-Data-Dmp.spec
SRPM URL:
https://jplesnik.fedorapeople.org/perl-Data-Dmp/perl-Data-Dmp-0.23-1.fc27.src.rpm

Description:
This module is a Perl dumper like Data::Dumper. It's compact , starts fast
and does not use any non-core modules except Regexp::Stringify when dumping
regexes. It produces compact single-line output (similar to
Data::Dumper::Concise). It supports dumping objects, regexes, circular
structures, coderefs.

Fedora Account System Username: jples...@redhat.com

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421413] Review Request: sysusage - System monitoring based on perl, rrdtool, and sysstat

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421413



--- Comment #9 from Frank Crawford  ---
(In reply to Jaroslav Škarvada from comment #8)
> (In reply to Frank Crawford from comment #6)
> > Will review and fix up.
> > 
> Great, please also address comment 3 and comment 5.

Thanks Jaroslav, I'll also pick up those comments while I'm at it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421413] Review Request: sysusage - System monitoring based on perl, rrdtool, and sysstat

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421413



--- Comment #8 from Jaroslav Škarvada  ---
(In reply to Frank Crawford from comment #6)
> Will review and fix up.
> 
Great, please also address comment 3 and comment 5.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421413] Review Request: sysusage - System monitoring based on perl, rrdtool, and sysstat

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421413



--- Comment #7 from Jaroslav Škarvada  ---
(In reply to Marek Cermak from comment #1)
> [!]: Fully versioned dependency in subpackages if applicable.
>  Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
>  sysusage-common , sysusage-httpd , sysusage-rsysusage

False positive, noarch packages, no %{?_isa} is needed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421413] Review Request: sysusage - System monitoring based on perl, rrdtool, and sysstat

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421413



--- Comment #6 from Frank Crawford  ---
(In reply to Marek Cermak from comment #1)

Marek, thanks for that.  I've made a couple of comments below.

> Package Review
> ==
...
> 
> NOTES
> -
>   - Orphaned package - name conflict permitted

Obviously not an issue, it is the same package, so should be the same.

>   - For package ownership information, see :
>
> https://fedoraproject.org/wiki/Packaging:
> Guidelines#The_directory_is_owned_by_a_package_which_is_not_required_for_your
> _package_to_function or
> https://fedoraproject.org/wiki/Packaging:WeakDependencies

Mostly covered above, the only outstanding seems to be for /etc/cron.d, which I
thought would be covered by crontabs, but seems to be owned by cronie.

Any suggestions on what to do about that one, if anything?

>   - Correction of the spelling in specfile

Yeah, will fix real errors here.  (rsysusage -> sausage! :-))

>   - Consider using %{?_isa} to fully define Requires

Will review and probably fix it up.

>   - Consider putting content of Web App into /usr/share/%{name} instead of
> /var/www/

See Comment 2 above.

>   - Change %doc LICENSE -> %license LICENSE

Yep, will fix.

>   - Not necessary anymore to compare %if 0%{?fedora} > 17

Yep, will look at and probably remove.

>   - Rpmlint is complaining about the #%global comment - note that to 
> escape
> the whole macro, #%% is needed, also, it could actually be deleted
> completely. 

Will review and fix up.

As I said, thanks, I'll review and submit a new spec file.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421413] Review Request: sysusage - System monitoring based on perl, rrdtool, and sysstat

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421413



--- Comment #5 from Jaroslav Škarvada  ---
Also please remove trailing whitespaces in %description.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421413] Review Request: sysusage - System monitoring based on perl, rrdtool, and sysstat

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421413



--- Comment #4 from Jaroslav Škarvada  ---
(In reply to Marek Cermak from comment #1)
>   file /etc/cron.d is not owned by any package

False positive, the package requires crontabs which requires /etc/cron.d, which
is provided by cronie, i.e. the dependency is fulfilled.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421413] Review Request: sysusage - System monitoring based on perl, rrdtool, and sysstat

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421413



--- Comment #3 from Jaroslav Škarvada  ---
Also I think the license tag should be GPLv3+, not GPLv3.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1467322] Review Request: manifest-tool - A command line tool used for creating manifest list objects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1467322



--- Comment #13 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/manifest-tool

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1469951] Review Request: perl-XML-LibXML-PrettyPrint - Add pleasant white space to an XML tree

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1469951



--- Comment #4 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/perl-XML-LibXML-PrettyPrint

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470656] New: Review Request: perl-Regexp-Stringify - Stringify a Regexp object

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470656

Bug ID: 1470656
   Summary: Review Request: perl-Regexp-Stringify - Stringify a
Regexp object
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: jples...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://jplesnik.fedorapeople.org/perl-Regexp-Stringify/perl-Regexp-Stringify.spec
SRPM URL:
https://jplesnik.fedorapeople.org/perl-Regexp-Stringify/perl-Regexp-Stringify-0.06-1.fc27.src.rpm

Description:
This module is an alternative to Perl's default stringification of Regexp
object and has some features/options, e.g. producing regexp string that is
compatible with certain perl versions.

Fedora Account System Username: jples...@redhat.com

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421413] Review Request: sysusage - System monitoring based on perl, rrdtool, and sysstat

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421413

Jaroslav Škarvada  changed:

   What|Removed |Added

 CC||jskar...@redhat.com



--- Comment #2 from Jaroslav Škarvada  ---
(In reply to Marek Cermak from comment #1)
>   - Consider putting content of Web App into /usr/share/%{name} instead of
> /var/www/
>
Probably OK, bug 1028722.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470644] Review Request: rubygem-addressable

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470644
Bug 1470644 depends on bug 1470641, which changed state.

Bug 1470641 Summary: rubygem-public_suffix is built only in Rawhide
https://bugzilla.redhat.com/show_bug.cgi?id=1470641

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |NOTABUG



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470448] Review Request: php-simplesamlphp-saml2_3 - SAML2 PHP library from SimpleSAMLphp ( version 3)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470448

Remi Collet  changed:

   What|Removed |Added

 CC||fed...@famillecollet.com



--- Comment #1 from Remi Collet  ---
fedora-review detects a corrupted archive.

You need to pull a git snapshot to workaround the .gitattributes

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421413] Review Request: sysusage - System monitoring based on perl, rrdtool, and sysstat

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421413

Marek Cermak  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



--- Comment #1 from Marek Cermak  ---

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file LICENSE is not marked as %license
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text
- Package does not use a name that already exists.
  Note: A package with this name already exists. Please check
  https://admin.fedoraproject.org/pkgdb/package/sysusage
  See:
 
https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Conflicting_Package_Names
- Package must own all directories that it creates.
  Note: Directories without known owners: /usr/share/perl5/vendor_perl,
   /usr/share/perl5, /etc/cron.d, /var/www

  /usr/share/perl5 is owned by perl-libs-5.26.0-394.fc27.x86_64
  /usr/share/perl5/vendor_perl/ is owned by perl-libs-5.26.0-394.fc27.x86_64
  /var/www is owned by httpd-filesystem-2.4.27-1.fc27.noarch
  file /etc/cron.d is not owned by any package

- %build : Remove the DESTDIR=%{buildroot} from the build section, if not
possible, check that nothing is being built into the directory during build
section.

- See "NOTES" at the end of this document for more info and todos.


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "GPL (v3 or later)", "Unknown or generated". 28 files have
 unknown license. 
[x]: License file installed when any subpackage combination is installed.
[!]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/perl5/vendor_perl,
 /usr/share/perl5, /etc/cron.d, /var/www
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 153600 bytes in 5 files.
[!]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Perl:
[x]: 

[Bug 1470644] Review Request: rubygem-addressable

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470644

František Zatloukal  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |NOTABUG
Last Closed||2017-07-13 07:35:56



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470644] Review Request: rubygem-addressable

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470644

František Zatloukal  changed:

   What|Removed |Added

 Depends On||1470641




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1470641
[Bug 1470641] rubygem-public_suffix is built only in Rawhide
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470644] New: Review Request: rubygem-addressable

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470644

Bug ID: 1470644
   Summary: Review Request: rubygem-addressable
   Product: Fedora
   Version: 26
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: fzatl...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



SPEC URL:
https://copr-be.cloud.fedoraproject.org/results/frantisekz/fedora-developer-portal/fedora-26-x86_64/00578912-rubygem-addressable/rubygem-addressable.spec

SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/frantisekz/fedora-developer-portal/fedora-26-x86_64/00578912-rubygem-addressable/rubygem-addressable-2.5.1-1.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1341662] Review Request: fedora-developer-portal - Offline Fedora Developer Portal

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1341662



--- Comment #11 from František Zatloukal  ---
So, I've looked at packaging jekyll-sitemap with gem2rpm. It looks like there
is some automatic requires detection because it's depending on rubygem-jekyll
>= 3.3 (newer than packaged in Fedora). I was able to solve dependency chain on
my system and it's pretty complicated:

fedora-developer-portal depends on rubygem-jekyll-sitemap
rubygem-jekyll-sitemap depends on rubygem-jekyll >= 3.3
rubygem-jekyll >= 3.3 depends on rubygem-addressable
rubygem-addressable depends on rubygem-public_suffix (built in rawhide only,
but installable in f26)

I will create review request for rubygem-addressable soon, rubygem-jekyll bug
regarding new version availability and rubygem-public_suffix bug report to
package it even for F26 at least.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470635] New: Review Request: glslang - OpenGL and OpenGL ES shader front end and validator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470635

Bug ID: 1470635
   Summary: Review Request: glslang - OpenGL and OpenGL ES shader
front end and validator
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: leigh123li...@googlemail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://leigh123linux.fedorapeople.org/pub/review/glslang/1/glslang.spec

SRPM URL:
https://leigh123linux.fedorapeople.org/pub/review/glslang/1/glslang-3.1-0.1.20170612.git91c46c6.fc26.src.rpm

Description:
glslang is the official reference compiler front end for the OpenGL
ES and OpenGL shading languages. It implements a strict
interpretation of the specifications for these languages.


Fedora Account System Username: leigh123linux

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470447] Review Request: php-robrichards-xmlseclibs3 - A PHP library for XML Security (version 3)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470447

Remi Collet  changed:

   What|Removed |Added

  Flags||fedora-review+



--- Comment #5 from Remi Collet  ---
[x]: Package complies to the Packaging Guidelines


=== APPROVED ===

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470447] Review Request: php-robrichards-xmlseclibs3 - A PHP library for XML Security (version 3)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470447



--- Comment #4 from Remi Collet  ---
Created attachment 1297505
  --> https://bugzilla.redhat.com/attachment.cgi?id=1297505=edit
review.txt

Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -b 1470447
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, PHP, Shell-api

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470447] Review Request: php-robrichards-xmlseclibs3 - A PHP library for XML Security (version 3)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470447

Remi Collet  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|fed...@famillecollet.com



--- Comment #3 from Remi Collet  ---
Created attachment 1297504
  --> https://bugzilla.redhat.com/attachment.cgi?id=1297504=edit
review.txt

phpCompatInfo version 5.0.7 DB version 1.22.0 built Jun 10 2017
 10:52:56 CEST static analyze results

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470447] Review Request: php-robrichards-xmlseclibs3 - A PHP library for XML Security (version 3)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470447



--- Comment #2 from Remi Collet  ---
Forget previous stupid comment... badly read the diff with v2 spec file... I
need Holidays ;)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470447] Review Request: php-robrichards-xmlseclibs3 - A PHP library for XML Security (version 3)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470447

Remi Collet  changed:

   What|Removed |Added

 CC||fed...@famillecollet.com



--- Comment #1 from Remi Collet  ---
From CHANGELOG:

   25, May 2017, 3.0.0
   Improvements:
   - Remove use of mcrypt

So, please cleanup weak dep + comments about mcrypt

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470580] Review Request: rubygem-factory_girl - Framework and DSL for defining and using model instance factories

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470580

Vít Ondruch  changed:

   What|Removed |Added

 Blocks||1380037




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1380037
[Bug 1380037] rubygem-cucumber-rails-1.5.0 is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470580] New: Review Request: rubygem-factory_girl - Framework and DSL for defining and using model instance factories

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470580

Bug ID: 1470580
   Summary: Review Request: rubygem-factory_girl - Framework and
DSL for defining and using model instance factories
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: vondr...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



This is re-review request to unretire rubygem-factory_girl. I need it to
execute test suite of rubygem-cucumber-rails.

Spec URL:
https://fedorapeople.org/cgit/vondruch/public_git/rubygem-factory_girl.git/plain/rubygem-factory_girl.spec?id=039fe34538785102ea0ca5a87bfe5bb30e051844
SRPM URL:
http://people.redhat.com/vondruch/rubygem-factory_girl-4.8.0-1.fc27.src.rpm
Description: Framework and DSL for defining and using factories - less
error-prone, more explicit, and all-around easier to work with than fixtures.

Fedora Account System Username: vondruch

Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=20491971

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1469396] Review Request: hotspot - The Linux perf GUI for performance analysis

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1469396



--- Comment #4 from Fedora Update System  ---
hotspot-1.0.0-1.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-6588dc96d6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1469396] Review Request: hotspot - The Linux perf GUI for performance analysis

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1469396

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1469396] Review Request: hotspot - The Linux perf GUI for performance analysis

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1469396



--- Comment #5 from Fedora Update System  ---
hotspot-1.0.0-1.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-ef275a5084

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org