[Bug 1535292] Review Request: vagrant-openstack-provider - Vagrant plugin for OpenStack provider

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1535292



--- Comment #2 from greg.helli...@gmail.com ---
I have addressed all of your comments in the code save one. I'll address it
here:

I do not believe that stackrc is supposed to be executable. It's designed to be
sourced into the current environment, not to be executed as a standalone
script. I believe the shebang line at the top is intended to give syntax
highlighting in vim and similar situations. It's presented as a doc file, so I
don't believe it will be important either way. I'll be happy to make it
executable if that's preferred or edit out the shebang line if you agree it
should be left with 0644 permissions. Either one should resolve the lint error.

Once we have an agreement I'll post the updated SRPM file.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1535291] Review Request: rubygem-terminal-table - Simple, feature rich ascii table generation library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1535291



--- Comment #3 from greg.helli...@gmail.com ---
I've addressed the improper executables and the capitalization/spelling error
for ASCII.

You also have flagged not using %gem_install macro, but that is used on line 46
of the spec file (it's in the %build section, with an appropriate note as to
why). Spec updated in the same URL as before. New SRPM:

https://fedorapeople.org/~greghellings/rubygem-terminal-table/rubygem-terminal-table-1.8.0-1.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1535291] Review Request: rubygem-terminal-table - Simple, feature rich ascii table generation library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1535291



--- Comment #2 from greg.helli...@gmail.com ---
File permissions reported upstream:
https://github.com/tj/terminal-table/pull/96

Working on the other issues.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1495293] Review Request: python-Naked - A command line application framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1495293

greg.helli...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 854729] Review Request: bat-extratools-java - A collection of extra java tools for the BAT

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=854729

Wei-Lun Chao  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |NOTABUG
Last Closed||2018-01-18 22:24:36



--- Comment #11 from Wei-Lun Chao  ---
https://github.com/armijnhemel/bat-extratools-java
Upstream no longer maintained.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 854723] Review Request: bat - Binary Analysis Tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=854723
Bug 854723 depends on bug 854729, which changed state.

Bug 854729 Summary: Review Request: bat-extratools-java - A collection of extra 
java tools for the BAT
https://bugzilla.redhat.com/show_bug.cgi?id=854729

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |NOTABUG



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 854723] Review Request: bat - Binary Analysis Tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=854723
Bug 854723 depends on bug 854728, which changed state.

Bug 854728 Summary: Review Request: bat-extratools - A collection of extra 
tools for the BAT
https://bugzilla.redhat.com/show_bug.cgi?id=854728

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |NOTABUG



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 854728] Review Request: bat-extratools - A collection of extra tools for the BAT

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=854728

Wei-Lun Chao  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |NOTABUG
Last Closed||2018-01-18 22:23:19



--- Comment #11 from Wei-Lun Chao  ---
https://github.com/armijnhemel/bat-extratools
Upstream no longer maintained.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 854723] Review Request: bat - Binary Analysis Tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=854723

Wei-Lun Chao  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |NOTABUG
Last Closed||2018-01-18 22:21:49



--- Comment #24 from Wei-Lun Chao  ---
https://github.com/armijnhemel/binaryanalysis
Upstream no longer maintained.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519081] Review Request: scribus-generator - Open source high-quality PDF template and mail-merge alternative

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519081



--- Comment #15 from Fedora Update System  ---
scribus-generator-2.5-4.fc27 has been pushed to the Fedora 27 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-9fb18427a3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532837] Review Request: python-uranium-lulzbot - A Python framework for building desktop applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532837



--- Comment #17 from Fedora Update System  ---
CuraEngine-lulzbot-2.6.66-1.fc27, cura-lulzbot-2.6.66-2.fc27,
lulzbot-marlin-firmware-1.1.5.70-1.fc27, python-uranium-lulzbot-2.6.66-1.fc27
has been pushed to the Fedora 27 testing repository. If problems still persist,
please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-c36a0c632f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1495293] Review Request: python-Naked - A command line application framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1495293



--- Comment #4 from Clint Savage  ---
I think all of my concerns from above were met. I noted a few nits in the
attached review.txt, but nothing preventing approval.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1495293] Review Request: python-Naked - A command line application framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1495293

Clint Savage <csav...@redhat.com> changed:

   What|Removed |Added

 CC||csav...@redhat.com
 Attachment||review+
 #1383081 Flags||



--- Comment #3 from Clint Savage <csav...@redhat.com> ---
Created attachment 1383081
  --> https://bugzilla.redhat.com/attachment.cgi?id=1383081=edit
fedora-review results (review.txt) 20180118

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532837] Review Request: python-uranium-lulzbot - A Python framework for building desktop applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532837

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #16 from Fedora Update System  ---
CuraEngine-lulzbot-2.6.66-1.fc26, cura-lulzbot-2.6.66-2.fc26,
lulzbot-marlin-firmware-1.1.5.70-1.fc26, python-uranium-lulzbot-2.6.66-1.fc26
has been pushed to the Fedora 26 testing repository. If problems still persist,
please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-0d31ff4112

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519081] Review Request: scribus-generator - Open source high-quality PDF template and mail-merge alternative

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519081

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #14 from Fedora Update System  ---
scribus-generator-2.5-4.fc26 has been pushed to the Fedora 26 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-7e9b8f10b9

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1535549] Review Request: mupen64plus - Nintendo 64 Emulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1535549



--- Comment #4 from Robert-André Mauchin  ---
As you wish Antonio.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536159] Review Request: openvswitch-ovn-kubernetes - Wedge between kubernetes and OVN

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536159

Phil Cameron  changed:

   What|Removed |Added

Summary|Review Request: |Review Request:
   |opwnvswitch-ovn-kubernetes  |openvswitch-ovn-kubernetes
   |- Wedge between kubernetes  |- Wedge between kubernetes
   |and OVN |and OVN



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1535549] Review Request: mupen64plus - Nintendo 64 Emulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1535549

Antonio Trande  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|anto.tra...@gmail.com
  Flags||fedora-review?



--- Comment #3 from Antonio Trande  ---
@Robert-André

Please, let me care this package; i have followed it from rpmfusion.

@Wade

Fix all issues pointed by Robert-André, then we can go on with the review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536159] New: Review Request: opwnvswitch-ovn-kubernetes - Wedge between kubernetes and OVN

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536159

Bug ID: 1536159
   Summary: Review Request: opwnvswitch-ovn-kubernetes - Wedge
between kubernetes and OVN
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: pcame...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://pecameron.fedorapeople.org/ovn-kubernetes/openvswitch-ovn-kubernetes.spec
SRPM URL:
https://pecameron.fedorapeople.org/ovn-kubernetes/openvswitch-ovn-kubernetes-0.1.0-1.fc27.src.rpm
Description: This allows kubernetes (and Openshift) to use Open Virtual
Networking (OVN)
Fedora Account System Username: pecameron

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1491281] Review Request: python-libsass - python bindings for libsass

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1491281



--- Comment #18 from Miro Hrončok  ---
Please fix the following rpmlint issues:

python2-libsass.x86_64: E: wrong-script-interpreter
/usr/lib64/python2.7/site-packages/sassc.py /usr/bin/env python
python2-libsass.x86_64: E: non-executable-script
/usr/lib64/python2.7/site-packages/sassc.py 644 /usr/bin/env python
python3-libsass.x86_64: E: wrong-script-interpreter
/usr/lib64/python3.6/site-packages/sassc.py /usr/bin/env python
python3-libsass.x86_64: E: non-executable-script
/usr/lib64/python3.6/site-packages/sassc.py 644 /usr/bin/env python
python3-libsass.x86_64: W: spurious-executable-perm
/usr/share/man/man1/pysassc.1.gz

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1451138] Review Request: libomp - default OpenMP runtime used by clang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1451138

Tom Stellard  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-01-18 11:13:42



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532541] Review Request: python2-django1.11 - Version 1.11 LTS of Django, a high-level Python Web framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532541



--- Comment #6 from Miro Hrončok  ---
The python provide macro should be used, so the main package provides
python-django1.11.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536077] New: Review Request: jackson-bom - Bill of materials POM for Jackson projects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536077

Bug ID: 1536077
   Summary: Review Request: jackson-bom - Bill of materials POM
for Jackson projects
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: mat.bo...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://fedorapeople.org/~mbooth/reviews/jackson-bom.spec
SRPM URL:
https://fedorapeople.org/~mbooth/reviews/jackson-bom-2.9.3-1.fc28.src.rpm

Description:
A "bill of materials" POM for Jackson dependencies.


Fedora Account System Username: mbooth


Other Notes:
This package also contains a new "base" parent pom for internal jackson
components -- since jackson 2.9.2, upstream are gradually moving from the old
parent pom to this base pom so this review blocks the update of the Jackson
stack to modern versions. There's a chance that the old parent pom might go
away in the future.

Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=24269380

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532837] Review Request: python-uranium-lulzbot - A Python framework for building desktop applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532837



--- Comment #15 from Fedora Update System  ---
python-uranium-lulzbot-2.6.66-1.fc26 lulzbot-marlin-firmware-1.1.5.70-1.fc26
CuraEngine-lulzbot-2.6.66-1.fc26 cura-lulzbot-2.6.66-1.fc26 has been submitted
as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-0d31ff4112

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532837] Review Request: python-uranium-lulzbot - A Python framework for building desktop applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532837

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532837] Review Request: python-uranium-lulzbot - A Python framework for building desktop applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532837



--- Comment #14 from Fedora Update System  ---
python-uranium-lulzbot-2.6.66-1.fc27 lulzbot-marlin-firmware-1.1.5.70-1.fc27
CuraEngine-lulzbot-2.6.66-1.fc27 cura-lulzbot-2.6.66-1.fc27 has been submitted
as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-c36a0c632f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532541] Review Request: python2-django1.11 - Version 1.11 LTS of Django, a high-level Python Web framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532541



--- Comment #5 from Petr Viktorin  ---
Spec URL:
https://raw.githubusercontent.com/encukou/distgit-python2-django1.11/master/python2-django1.11.spec
SRPM URL:
https://kojipkgs.fedoraproject.org//work/tasks/7064/24267064/python2-django1.11-1.11.9-1.fc28.src.rpm
Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=24267064


Thanks for the review. I did the changes.

Remaining rpmlint complaints I get:

python2-django1.11-doc.noarch: W: invalid-url URL:
http://www.djangoproject.com/ 

-- local connection issue

python2-django1.11.noarch: W: spelling-error %description -l en_US Django ->
Fandango

-- bogus

python2-django1.11.noarch: W: obsolete-not-provided python-django
python2-django1.11.noarch: W: obsolete-not-provided python2-django

-- intentional; see the Change and its contingency plan

python2-django1.11.noarch: E: zero-length
/usr/lib/python2.7/site-packages/django/conf/app_template/__init__.py-tpl
python2-django1.11.noarch: E: zero-length
/usr/lib/python2.7/site-packages/django/conf/app_template/migrations/__init__.py-tpl
python2-django1.11.noarch: E: wrong-script-interpreter
/usr/lib/python2.7/site-packages/django/conf/project_template/manage.py-tpl
/usr/bin/env python
python2-django1.11.noarch: E: zero-length
/usr/lib/python2.7/site-packages/django/conf/project_template/project_name/__init__.py-tpl

-- intentional; note that these are template files

python2-django1.11.noarch: W: no-manual-page-for-binary django-admin-1.11
2 packages and 0 specfiles checked; 4 errors, 6 warnings.

-- see comment in specfile


Also, the automatic dependency on /usr/bin/env is not needed, but it doesn't
really do any harm.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1525570] Review Request: pew - Tool to manage multiple virtualenvs written in pure python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1525570

Miro Hrončok  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #13 from Miro Hrončok  ---
> Tool to manage multiple virtualenvs written in pure python

Please use uppercase P for Python.


> # Add pytest marker to test requiring connection
> Patch0: 0001-tests-connection-marker-fix.patch

Is this posted upstream?



Package is APPROVED.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated



= MUST items =

Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
 https://koji.fedoraproject.org/koji/taskinfo?taskID=24266546
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 30720 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[x]: Reviewer should test that the package builds in mock. (I've checked Koji,
had some local troubles)
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[?]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[ ]: Patches link to upstream bugs/comments/lists or are otherwise
 justified. Unsure here.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[?]: Package should compile and build into binary rpms on all supported
 architectures.
[x]: %check is present and all tests pass.
[?]: Packages should try to preserve timestamps of original installed
 files.
[x]: Buildroot is not present

[Bug 1526717] Review Request: python-giacpy - Python binding for Giac

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1526717



--- Comment #8 from Antonio Trande  ---
(In reply to Robert-André Mauchin from comment #7)
> Well the install script includes it for a reason I suppose.

Not always.
http://xcas.e.ujf-grenoble.fr/XCAS/viewtopic.php?f=24=1987#p9784

> 
> Package approved anyway.

Thank you.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1525570] Review Request: pew - Tool to manage multiple virtualenvs written in pure python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1525570

Miro Hrončok  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|mhron...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1482524] ansible-kubespray - Ansible library for kubernetes installer needed to install tripleo openstack on top

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1482524



--- Comment #13 from Bogdan Dobrelya  ---
I've updated and tested the pull request for kubespray, works for me, hopefully
should be fine to consume after its merged!

for details see
https://github.com/kubernetes-incubator/kubespray/pull/2170#issuecomment-358617691

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1432997] Review Request: multimc - Minecraft launcher with ability to manage multiple instances

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1432997



--- Comment #5 from srakitnican  ---
To elaborate further, some of the core icons would need to be replaced unless
you want the end result to look crimpled. This I feel is best done upstream and
not at packaging.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519081] Review Request: scribus-generator - Open source high-quality PDF template and mail-merge alternative

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519081

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519081] Review Request: scribus-generator - Open source high-quality PDF template and mail-merge alternative

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519081



--- Comment #12 from Fedora Update System  ---
scribus-generator-2.5-4.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-9fb18427a3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519081] Review Request: scribus-generator - Open source high-quality PDF template and mail-merge alternative

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519081



--- Comment #13 from Fedora Update System  ---
scribus-generator-2.5-4.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-7e9b8f10b9

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1432997] Review Request: multimc - Minecraft launcher with ability to manage multiple instances

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1432997

srakitnican  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |WONTFIX
Last Closed||2018-01-18 03:16:32



--- Comment #4 from srakitnican  ---
At least "Batch" icon set contains a non-free license not acceptable by Fedora
[1]. There are also other icons that are mix and matched from which some of
them with an unknown license that would need to be reviewed and possibly pruned
as well.


Thank you for your review but I am sorry to say this seems too much work for me
with not much benefit, thus I am closing this with a WONTFIX.

[1]
https://lists.fedoraproject.org/archives/list/le...@lists.fedoraproject.org/message/KCKV7HWFWAY7UJH7UUQ4D2UP7AHPXE52/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org