[Bug 1520375] Review Request: php-kdyby-strict-objects - Simple trait to make your class strict

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520375

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1520375] Review Request: php-kdyby-strict-objects - Simple trait to make your class strict

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520375



--- Comment #4 from Fedora Update System  ---
php-kdyby-strict-objects-1.0.0-1.fc27 has been submitted as an update to Fedora
27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-869bae8561

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1541346] Review Request: phpunit7 - The PHP Unit Testing framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1541346



--- Comment #5 from Remi Collet  ---
Thanks for the review

SCM request
https://pagure.io/releng/fedora-scm-requests/issue/4441

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1541346] Review Request: phpunit7 - The PHP Unit Testing framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1541346
Bug 1541346 depends on bug 1541340, which changed state.

Bug 1541340 Summary: Review Request: php-phpunit-mock-objects6 - Mock Object 
library for PHPUnit
https://bugzilla.redhat.com/show_bug.cgi?id=1541340

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1541340] Review Request: php-phpunit-mock-objects6 - Mock Object library for PHPUnit

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1541340

Remi Collet  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-02-07 02:19:00



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1541343] Review Request: php-phpunit-php-code-coverage6 - PHP code coverage information

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1541343
Bug 1541343 depends on bug 1541342, which changed state.

Bug 1541342 Summary: Review Request: php-phpunit-php-token-stream3 - Wrapper 
around PHP tokenizer extension
https://bugzilla.redhat.com/show_bug.cgi?id=1541342

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1541342] Review Request: php-phpunit-php-token-stream3 - Wrapper around PHP tokenizer extension

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1541342

Remi Collet  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-02-07 02:15:46



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1541343] Review Request: php-phpunit-php-code-coverage6 - PHP code coverage information

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1541343

Remi Collet  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-02-07 02:13:03



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1541346] Review Request: phpunit7 - The PHP Unit Testing framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1541346
Bug 1541346 depends on bug 1541343, which changed state.

Bug 1541343 Summary: Review Request: php-phpunit-php-code-coverage6 - PHP code 
coverage information
https://bugzilla.redhat.com/show_bug.cgi?id=1541343

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1541334] Review Request: php-phpunit-php-timer2 - PHP Utility class for timing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1541334

Remi Collet  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-02-07 02:09:49



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1541346] Review Request: phpunit7 - The PHP Unit Testing framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1541346
Bug 1541346 depends on bug 1541334, which changed state.

Bug 1541334 Summary: Review Request: php-phpunit-php-timer2 - PHP Utility class 
for timing
https://bugzilla.redhat.com/show_bug.cgi?id=1541334

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1541337] Review Request: php-sebastian-diff3 - Diff implementation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1541337

Remi Collet  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-02-07 02:01:55



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1541346] Review Request: phpunit7 - The PHP Unit Testing framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1541346
Bug 1541346 depends on bug 1541337, which changed state.

Bug 1541337 Summary: Review Request: php-sebastian-diff3 - Diff implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1541337

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1541346] Review Request: phpunit7 - The PHP Unit Testing framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1541346
Bug 1541346 depends on bug 1539554, which changed state.

Bug 1539554 Summary: Review Request: php-phpunit-php-invoker2 - Invoke 
callables with a timeout
https://bugzilla.redhat.com/show_bug.cgi?id=1539554

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539554] Review Request: php-phpunit-php-invoker2 - Invoke callables with a timeout

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539554

Remi Collet  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-02-07 01:55:37



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519719] Review Request: php-phpunit-mock-objects5 - Mock Object library for PHPUnit

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519719



--- Comment #10 from Fedora Update System  ---
php-phpunit-mock-objects5-5.0.6-3.fc27 has been submitted as an update to
Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-5bba96e2fb

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519719] Review Request: php-phpunit-mock-objects5 - Mock Object library for PHPUnit

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519719

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538658] Review Request: python-anyconfig - common API to load and dump configuration files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538658



--- Comment #8 from Troy Curtis  ---
The source url, which expands to
https://github.com/ssato/python-anyconfig/archive/0.9.3/anyconfig-0.9.3.tar.gz
gives a "File not Found" error.

BuildRequires actually belong to the source rpm, not individual subpackages, so
I'd suggest moving them up a level.  This will also make clear the 'make' is a
duplicate dependency.

For some reason my `fedora-review` invocation is having some trouble, so these
two items will have to suffice for the moment.  I didn't notice other issues
though, and as I'm not (yet) a packager, I can't take it all the way to
approved anyhow.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539189] Review Request: golang-github-zyedidia-pty - PTY interface for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539189

Elliott Sales de Andrade  changed:

   What|Removed |Added

 CC||quantum.anal...@gmail.com



--- Comment #1 from Elliott Sales de Andrade  ---
So how is this different from the existing golang-github-kr-pty, which appears
to  still be under development and not dead?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1542807] New: Review Request: gap-pkg-toric - Computations with toric varieties in GAP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1542807

Bug ID: 1542807
   Summary: Review Request: gap-pkg-toric - Computations with
toric varieties in GAP
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: loganje...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://jjames.fedorapeople.org/gap-pkg-toric/gap-pkg-toric.spec
SRPM URL:
https://jjames.fedorapeople.org/gap-pkg-toric/gap-pkg-toric-1.9.4-1.fc28.src.rpm
Description: Toric implements some computations related to toric varieties and
combinatorial geometry in GAP.  Affine toric varieties can be created
and related information about them can be calculated.
Fedora Account System Username: jjames

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1542663] Review Request: bitlbee-discord - Bitlbee plugin for Discord

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1542663



--- Comment #2 from Ben Rosser  ---
> %dir %{_libdir}/bitlbee
> %dir %{_datadir}/bitlbee

Ah, my bad. This is because I forgot to require bitlbee (which owns these
directories), and RPM doesn't detect it automatically.

Thanks for the LT_INIT patch. I've added it and a Requires: bitlbee.

Spec URL: https://tc01.fedorapeople.org/chat/bitlbee-discord.spec
SRPM URL:
https://tc01.fedorapeople.org/chat/bitlbee-discord-0.4.1-2.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539209] Review Request: ddgr - DuckDuckGo from the terminal

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539209



--- Comment #1 from Ben Rosser  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===

- The license header in "ddgr" (the Python script) says:

> # This program is free software: you can redistribute it and/or modify
> # it under the terms of the GNU General Public License as published by
> # the Free Software Foundation, either version 3 of the License, or
> # (at your option) any later version.

So I think the license tag should actually be GPLv3+, not GPLv3.

- The fish and zsh directories under /usr/share are unowned, since those
  shells aren't dependencies. Therefore I believe this package needs
  to own them too.

 Note: Directories without known owners:
 /usr/share/fish/vendor_functions.d, /usr/share/zsh/site-functions,
 /usr/share/fish, /usr/share/zsh

Everything else looks good.

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "GPL (v3 or later)", "Unknown or generated". 11 files have
 unknown license. Detailed output of licensecheck in
 /home/bjr/Programming/fedora/reviews/1539209-ddgr/licensecheck.txt
[!]: Package must own all directories that it creates.
 Note: Directories without known owners:
 /usr/share/fish/vendor_functions.d, /usr/share/zsh/site-functions,
 /usr/share/fish, /usr/share/zsh
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to 

[Bug 1539209] Review Request: ddgr - DuckDuckGo from the terminal

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539209

Ben Rosser  changed:

   What|Removed |Added

  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1542598] Review Request: compat-xerces-c31 - Compat package with xerces-c libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1542598

Pete Walter  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
   Fixed In Version||compat-xerces-c31-3.1.4-1.f
   ||c28
 Resolution|--- |RAWHIDE
Last Closed||2018-02-06 21:17:07



--- Comment #3 from Pete Walter  ---
Thanks. Built as compat-xerces-c31-3.1.4-1.fc28.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1541587] Review Request: python-kiwisolver - A fast implementation of the Cassowary constraint solver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1541587



--- Comment #9 from Fedora Update System  ---
python-kiwisolver-1.0.1-1.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-92155e9316

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1541587] Review Request: python-kiwisolver - A fast implementation of the Cassowary constraint solver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1541587



--- Comment #8 from Fedora Update System  ---
python-kiwisolver-1.0.1-1.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-f21bbd868d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1541587] Review Request: python-kiwisolver - A fast implementation of the Cassowary constraint solver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1541587

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1535207] Review Request: ravada - Remote Virtual Desktops Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1535207

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1535207] Review Request: ravada - Remote Virtual Desktops Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1535207



--- Comment #11 from Fedora Update System  ---
ravada-0.2.13-0.1.20180117gitf70dfbf.fc26 has been submitted as an update to
Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2018-4ff2ff1802

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1542646] Review Request: patool - Portable command line archive file manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1542646



--- Comment #2 from Robert-André Mauchin  ---
> %{python2_sitelib}/_patool_configdata.*
This is really an upstream issue, but a package should never ever install
private modules into the top-level namespace. Maybe you can talk with upstream
to move it underneath patoollib/ ?

Wouldn't work currently:

File "/usr/lib/python3.6/site-packages/patoolib/configuration.py", line 5, in

import _patool_configdata as configdata

I doubt I'll manage to get upstream to change this as the GIT repo and issue
tracker haven't bulge for 2 years now.

There's also a handful of top-level packages that already exist:

$ ll /usr/lib/python3.6/site-packages/*.py
-rw-r--r--. 1 root root  24K août  31  2014
/usr/lib/python3.6/site-packages/augeas.py
-rw-r--r--. 1 root root  16K févr. 16  2016
/usr/lib/python3.6/site-packages/cycler.py
-rw-r--r--. 1 root root  16K janv. 15  2017
/usr/lib/python3.6/site-packages/decorator.py
-rw-r--r--. 1 root root  39K déc.  24 17:29
/usr/lib/python3.6/site-packages/distro.py
-rw-r--r--. 1 root root  126 nov.  28 16:47
/usr/lib/python3.6/site-packages/easy_install.py
-rw-r--r--. 1 root root  19K juil. 26  2017
/usr/lib/python3.6/site-packages/git_archive_all.py
-rw-r--r--. 1 root root  59K avril  1  2013
/usr/lib/python3.6/site-packages/IPy.py
-rw-r--r--. 1 root root  75K nov.   9 10:24
/usr/lib/python3.6/site-packages/langtable.py
-rw-r--r--. 1 root root 8,2K avril  4  2017
/usr/lib/python3.6/site-packages/magic.py
-rw-r--r--. 1 root root  14K juil. 27  2015
/usr/lib/python3.6/site-packages/ntplib.py
-rw-r--r--. 1 root root 1,1K janv.  6  2017
/usr/lib/python3.6/site-packages/OleFileIO_PL.py
-rw-r--r--. 1 root root 6,2K déc.  15  2015
/usr/lib/python3.6/site-packages/ordered_set.py
-rw-r--r--. 1 root root  87K juin   4  2015
/usr/lib/python3.6/site-packages/pyinotify.py
-rw-r--r--. 1 root root 225K juil. 28  2017
/usr/lib/python3.6/site-packages/pyparsing.py
-rw-r--r--. 1 root root 4,4K août  24  2015
/usr/lib/python3.6/site-packages/requests_file.py
-rw-r--r--. 1 root root 118K juil. 28  2017
/usr/lib/python3.6/site-packages/sh.py
-rw-r--r--. 1 root root  31K sept. 19 15:47
/usr/lib/python3.6/site-packages/six.py
-rw-r--r--. 1 root root 2,9K mars  28  2015
/usr/lib/python3.6/site-packages/sockshandler.py
-rw-r--r--. 1 root root  32K mars  23  2017
/usr/lib/python3.6/site-packages/socks.py
-rw-r--r--. 1 root root 5,0K janv. 13  2011
/usr/lib/python3.6/site-packages/termcolor.py
-rw-r--r--. 1 root root 9,7K déc.   8 16:02
/usr/lib/python3.6/site-packages/tldr.py


I could patch it I guess.


>> %{_datadir}/bash-completion/completions/patool.bash-completion
>This should be called just 'patool', without the extension.

Done.

> Shouldn't this package have Recommends on various tools for all the 
> non-natively-supported formats?

Yes I forgot about this.


Spec URL:
https://raw.githubusercontent.com/eclipseo/packaging/7bf94ea/patool.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/eclipseo/patool/fedora-rawhide-x86_64/00711233-patool/patool-1.12-1.fc28.src.rpm

SPEC diff:
https://github.com/eclipseo/packaging/commit/7bf94eab8915ea4021e01df12059e4aa4e1da804#diff-978fea9b8642e77c470ed419b5f34bfd

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539920] Review Request: rocm-runtime - ROCm runtime driver for AMD compute

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539920



--- Comment #10 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rocm-runtime

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1541554] Review Request: podman - Manage Pods, Containers and Container Images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1541554



--- Comment #6 from Fedora Update System  ---
podman-0-0.3.git367213a.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-665045691d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1541554] Review Request: podman - Manage Pods, Containers and Container Images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1541554

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1535207] Review Request: ravada - Remote Virtual Desktops Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1535207



--- Comment #10 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/ravada. You may commit to the branch "f27"
in about 10 minutes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1542646] Review Request: patool - Portable command line archive file manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1542646

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zbys...@in.waw.pl
   Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl



--- Comment #1 from Zbigniew Jędrzejewski-Szmek  ---
> %{_datadir}/bash-completion/completions/patool.bash-completion
This should be called just 'patool', without the extension.

> %{python2_sitelib}/_patool_configdata.*
This is really an upstream issue, but a package should never ever install
private modules into the top-level namespace. Maybe you can talk with upstream
to move it underneath patoollib/ ?

Shouldn't this package have Recommends on various tools for all the
non-natively-supported formats?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539920] Review Request: rocm-runtime - ROCm runtime driver for AMD compute

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539920



--- Comment #9 from Tom Stellard  ---
Spec URL:
http://copr-dist-git.fedorainfracloud.org/cgit/tstellar/rocm-1.6-userspace/rocm-runtime.git/plain/rocm-runtime.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/tstellar/rocm-1.6-userspace/fedora-rawhide-x86_64/00711188-rocm-runtime/rocm-runtime-1.6.1-5.fc28.src.rpm

Updated to fix ownership of /usr/include/hsa.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538259] Review Request: ocaml-lambda-term - Terminal manipulation library for OCaml

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538259



--- Comment #2 from Ben Rosser  ---
Great, thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1541587] Review Request: python-kiwisolver - A fast implementation of the Cassowary constraint solver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1541587



--- Comment #7 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-kiwisolver

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1540335] Review Request: primesieve - Fast C/ C++ prime number generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540335



--- Comment #5 from Kim Walisch  ---
Hi Micheal,

Thanks for your feedback. I have fixed the issues you pointed out and pushed a
new version of the spec and SRPM to GitHub:

Spec URL:
https://raw.githubusercontent.com/kimwalisch/primesieve-rpm/master/primesieve.spec
SRPM URL:
https://raw.githubusercontent.com/kimwalisch/primesieve-rpm/master/primesieve-6.4-3.fc27.src.rpm

Note that I have also fixed the following issues pointed out by Jerry James:

> %post -p /sbin/ldconfig
> %postun -p /sbin/ldconfig

> should be replaced with this:
> %ldconfig_scriptlets

1) Done, use ldconfig_scriptlets.

> Also, the spec file at the URL given in the review bug has release
> number 2, but the one inside the SRPM has release number 1. 
> Make sure those match.

2) Done, spec release number now matches SRPM release number.

> ...it is a good idea for the binary and the library to
be in separate packages.

3) I have now put the binary in the primesieve package, the shared
libprimesieve and the header files are in the libprimesieve-devel package and
the static libprimesieve is in the libprimesieve-static package. The naming of
the packages is similar to Debian/Ubuntu where the binary is in primesieve and
the libraries and header in libprimesieve-dev.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1535207] Review Request: ravada - Remote Virtual Desktops Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1535207

Raphael Groner  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags||fedora-review+



--- Comment #9 from Raphael Groner  ---
APPROVED

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "AGPL (v3)", "Unknown or generated", "*No copyright* Apache
 (v2.0)". 280 files have unknown license. Detailed output of
 licensecheck in /home/builder/fedora-
 review/1535207-ravada/licensecheck.txt
=> License breakdown available.

[x]: If the package is under multiple licenses, the licensing breakdown
 must be documented in the spec.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 81920 bytes in 50 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Perl:
[x]: Package contains the mandatory BuildRequires and Requires:.

= SHOULD items =

Generic:
[?]: Avoid bundling fonts in non-fonts packages.
 Note: Package contains font files
=> No idea what this means. Maybe due to bundled templates.

[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[?]: %check is present 

[Bug 1538658] Review Request: python-anyconfig - common API to load and dump configuration files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538658



--- Comment #7 from Brett Lentz  ---
Updated spec:
https://wakko666.fedorapeople.org/python-anyconfig/python-anyconfig.spec

Updated srpm:
https://wakko666.fedorapeople.org/python-anyconfig/python-anyconfig-0.9.3-1.fc28.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1542663] Review Request: bitlbee-discord - Bitlbee plugin for Discord

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1542663

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review?



--- Comment #1 from Robert-André Mauchin  ---
[!]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/lib64/bitlbee,
 /usr/share/bitlbee

You should own thses dirs:

%dir %{_libdir}/bitlbee
%dir %{_datadir}/bitlbee


[!]: Package should not use obsolete m4 macros
 Note: Some obsoleted macros found, see the attachment.

AutoTools: Obsoleted m4s found
--
  AC_PROG_LIBTOOL found in: bitlbee-discord-0.4.1/configure.ac:32

Replace it with LT_INIT.
See for details
https://www.gnu.org/software/libtool/manual/html_node/LT_005fINIT.html

Actually I've sent a patch for this upstream. Add it to your SPEC:

Patch0:
https://github.com/sm00th/bitlbee-discord/pull/135.patch#/%{name}-%{version}-remove_obsolete_m4s_macro.patch

   And add -p1 to autosetup:

%autosetup -p1



Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "*No copyright* GPL (v2 or later)", "GPL (v2 or later)",
 "Unknown or generated". 2 files have unknown license. Detailed output
 of licensecheck in /home/bob/packaging/review/bitlbee-discord/review-
 bitlbee-discord/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[!]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/lib64/bitlbee,
 /usr/share/bitlbee
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make 

[Bug 1540347] Review Request: hashcat - password recovery utility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540347



--- Comment #10 from Jaroslav Škarvada  ---
(In reply to Igor Gnatenko from comment #9)
> you should depend only on ocl-icd... And DNF should really implement pulling
> in appropriate implementations automatically. But until it's there, users
> will have to manually install appropriate driver.
> 
> you can use POCL which is CPU-based implementation... Last time I tried
> hashcat, it worked on with POCL and proprietary driver (so no mesa, beignet).

Thanks for info, I will try.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1535207] Review Request: ravada - Remote Virtual Desktops Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1535207



--- Comment #8 from Robert-André Mauchin  ---
Spec URL:
https://raw.githubusercontent.com/eclipseo/packaging/cea62fb/ravada.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/eclipseo/ravada/fedora-rawhide-x86_64/00711120-ravada/ravada-0.2.13-0.1.20180117gitf70dfbf.fc28.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539209] Review Request: ddgr - DuckDuckGo from the terminal

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539209

Ben Rosser  changed:

   What|Removed |Added

 CC||rosser@gmail.com
   Assignee|nob...@fedoraproject.org|rosser@gmail.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1542650] Review Request: QEverCloud - Unofficial Evernote Cloud API for Qt5

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1542650

Ben Rosser  changed:

   What|Removed |Added

 CC||rosser@gmail.com
   Assignee|nob...@fedoraproject.org|rosser@gmail.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1535207] Review Request: ravada - Remote Virtual Desktops Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1535207



--- Comment #7 from Raphael Groner  ---
(In reply to Robert-André Mauchin from comment #6)
> I fixed the buildroot/RPM_BUILD_ROOT issue mentionned py fedora-review after
> this, I don't want to rebuild it for such a minor change.

Not fixed. Can you upload and show fixed SPEC and SRPM files?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1542200] Review Request: 4diac-forte - IEC 61499 runtime environment

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1542200

Jens Reimann  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-02-06 14:18:41



--- Comment #7 from Jens Reimann  ---
Build was successful:
https://koji.fedoraproject.org/koji/taskinfo?taskID=24757437

Thanks

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538259] Review Request: ocaml-lambda-term - Terminal manipulation library for OCaml

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538259

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #1 from Robert-André Mauchin  ---
 - Should be %{name}%{?_isa}:

%packagedevel
Summary:Development files for %{name}
Requires:   %{name}%{?_isa} = %{version}-%{release}

The binary calls chroot two times but without chdir beforehand:

  5ae168:e8 03 c3 ed ff   callq  48a470 

  5b1233:e8 38 92 ed ff   callq  48a470 

I have no idea how to fix this though. I actually had this issue with another
ocaml package, but in both case the source code doesn't seem to call chroot, it
seems to be functions from ocaml added at compilation time.

Anyhow just fix the %{?_isa} part before import. Package approved.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD (2 clause)", "Unknown or generated". 92 files have unknown
 license. Detailed output of licensecheck in /home/bob/packaging/review
 /ocaml-lambda-term/review-ocaml-lambda-term/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 

[Bug 1540335] Review Request: primesieve - Fast C/ C++ prime number generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540335



--- Comment #4 from Michael Schwendt  ---
> %check
> make test
> 
> %install

During rpmbuild, %check gets executed _after_ %install, so putting %check below
%install in the spec file is common practice. Sometimes tests are run on
buildroot contents, btw, which explains the order of those sections.


> %package static
> Requires: %{name}-devel = %{version}-%{release}

Make it arch-specific as explained in the base package guidelines:
https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package


> %{_includedir}/primesieve/PrimeSieve.hpp

If you list individual files like that (which may be beneficial because the
build would abort for added/removed files), you need to specify also
directories:

  %dir %{_includedir}/primesieve

https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership
https://fedoraproject.org/wiki/Packaging:UnownedDirectories

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1542671] Review Request: emojitwo-fonts - Color emoji font with a flat style

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1542671

Peter Oliver  changed:

   What|Removed |Added

 CC||bnoc...@redhat.com



--- Comment #1 from Peter Oliver  ---
I think this should probably obsolete package eosrei-emojione-fonts. 
Maintainer of that package, Bastien Nocera, do you have an opinion on that?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1542671] New: Review Request: emojitwo-fonts - Color emoji font with a flat style

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1542671

Bug ID: 1542671
   Summary: Review Request: emojitwo-fonts - Color emoji font with
a flat style
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: ma...@mavit.org.uk
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://pagure.io/emojitwo-fonts/raw/master/f/emojitwo-fonts.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/mavit/emojitwo-fonts/fedora-rawhide-x86_64/00710896-emojitwo-fonts/emojitwo-fonts-20171213gitb851e20-1.fc28.src.rpm
Description: Maintained fork of the last fully free version of Ranks.com's
Emoji One font.
Fedora Account System Username: mavit

Note that Emoji Two currently lacks a build system, so this package borrows the
build system of Google Noto Emoji to turn PNGs into a TTF.  This is the same
approach as used for the twitter-twemoji-fonts package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1542663] New: Review Request: bitlbee-discord - Bitlbee plugin for Discord

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1542663

Bug ID: 1542663
   Summary: Review Request: bitlbee-discord - Bitlbee plugin for
Discord
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: rosser@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://tc01.fedorapeople.org/chat/bitlbee-discord.spec
SRPM URL:
https://tc01.fedorapeople.org/chat/bitlbee-discord-0.4.1-1.fc27.src.rpm
Description: Discord protocol plugin for bitlbee.

Fedora Account System Username: tc01

Should hopefully be a really simple review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1540833] Review Request: racket - programming language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540833

David Benoit  changed:

   What|Removed |Added

 Whiteboard||NotReady



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1514274] Review Request: twitter-twemoji-fonts - Twitter Emoji for everyone

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1514274



--- Comment #33 from Peter Oliver  ---
Thanks for your help, everyone.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1514274] Review Request: twitter-twemoji-fonts - Twitter Emoji for everyone

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1514274



--- Comment #32 from Fedora Update System  ---
twitter-twemoji-fonts-2.4.0-1.fc27 has been submitted as an update to Fedora
27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-86ff582bf9

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1514274] Review Request: twitter-twemoji-fonts - Twitter Emoji for everyone

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1514274

Fedora Update System  changed:

   What|Removed |Added

 Status|NEW |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1542650] Review Request: QEverCloud - Unofficial Evernote Cloud API for Qt5

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1542650

Robert-André Mauchin  changed:

   What|Removed |Added

 Blocks||1542654




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1542654
[Bug 1542654] Review Request: quentier - Cross-platform desktop Evernote
client
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1542654] Review Request: quentier - Cross-platform desktop Evernote client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1542654

Robert-André Mauchin  changed:

   What|Removed |Added

 Depends On||1542650, 1542651




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1542650
[Bug 1542650] Review Request: QEverCloud - Unofficial Evernote Cloud API
for Qt5
https://bugzilla.redhat.com/show_bug.cgi?id=1542651
[Bug 1542651] Review Request: libquentier - Set of Qt/C++ APIs for feature
rich desktop clients for Evernote service
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1542651] Review Request: libquentier - Set of Qt/ C++ APIs for feature rich desktop clients for Evernote service

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1542651

Robert-André Mauchin  changed:

   What|Removed |Added

 Blocks||1542654




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1542654
[Bug 1542654] Review Request: quentier - Cross-platform desktop Evernote
client
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1542654] New: Review Request: quentier - Cross-platform desktop Evernote client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1542654

Bug ID: 1542654
   Summary: Review Request: quentier - Cross-platform desktop
Evernote client
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: zebo...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://raw.githubusercontent.com/eclipseo/packaging/22aeec2/quentier.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/eclipseo/quentier/fedora-rawhide-x86_64/00708612-quentier/quentier-0-1.20180128.git442947d.fc28.src.rpm

Description:
Quentier is a cross-platform desktop note taking app capable of working as 
Evernote client. You can also use Quentier for local notes without any 
connection to Evernote and synchronization.

Fedora Account System Username: eclipseo

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1542650] Review Request: QEverCloud - Unofficial Evernote Cloud API for Qt5

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1542650

Robert-André Mauchin  changed:

   What|Removed |Added

 Blocks||1542651




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1542651
[Bug 1542651] Review Request: libquentier - Set of Qt/C++ APIs for feature
rich desktop clients for Evernote service
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1542651] Review Request: libquentier - Set of Qt/ C++ APIs for feature rich desktop clients for Evernote service

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1542651

Robert-André Mauchin  changed:

   What|Removed |Added

 Depends On||1542650




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1542650
[Bug 1542650] Review Request: QEverCloud - Unofficial Evernote Cloud API
for Qt5
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1542651] New: Review Request: libquentier - Set of Qt/ C++ APIs for feature rich desktop clients for Evernote service

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1542651

Bug ID: 1542651
   Summary: Review Request: libquentier - Set of Qt/C++ APIs for
feature rich desktop clients for Evernote service
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: zebo...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://raw.githubusercontent.com/eclipseo/packaging/22aeec2/libquentier.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/eclipseo/quentier/fedora-rawhide-x86_64/00708601-libquentier/libquentier-0-1.20180130.git45bb65b.fc28.src.rpm

Description:
This library presents a set of Qt/C++ APIs useful for applications working as 
feature rich desktop clients for Evernote service. The most important and 
useful components of the library are the following:

 - Local storage - persistence of data downloaded from Evernote service in 
   a local SQLite database
 - Synchronization - the logics of exchanging new and/or modified data 
   with Evernote service
 - Note editor - the UI component capable for notes displaying and editing

The library is based on the lower level functionality provided by QEverCloud 
library. It also serves as the functional core of Quentier application.

Fedora Account System Username: eclipseo

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1542650] New: Review Request: QEverCloud - Unofficial Evernote Cloud API for Qt5

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1542650

Bug ID: 1542650
   Summary: Review Request: QEverCloud - Unofficial Evernote Cloud
API for Qt5
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: zebo...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://raw.githubusercontent.com/eclipseo/packaging/22aeec2/qevercloud.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/eclipseo/quentier/fedora-rawhide-x86_64/00708588-qevercloud/qevercloud-4.0.0-1.fc28.src.rpm

Description:
This library presents the complete Evernote SDK for Qt. All the functionality 
that is described on Evernote site is implemented and ready to use. 
In particular OAuth authentication is implemented.

Fedora Account System Username: eclipseo

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1542646] New: Review Request: patool - Portable command line archive file manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1542646

Bug ID: 1542646
   Summary: Review Request: patool - Portable command line archive
file manager
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: zebo...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://raw.githubusercontent.com/eclipseo/packaging/e632a7b/patool.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/eclipseo/patool/fedora-rawhide-x86_64/00708379-patool/patool-1.12-1.fc28.src.rpm

Description:
Patool is an archive file manager.

Various archive formats can be created, extracted, tested, listed, searched, 
repacked and compared with patool. The advantage of patool is its simplicity 
in handling archive files without having to remember a myriad of programs 
and options. 

The archive format is determined by the file(1) program and as a fallback 
by the archive file extension. 

patool supports 7z (.7z, .cb7), ACE (.ace, .cba), ADF (.adf), ALZIP (.alz), 
APE (.ape), AR (.a), ARC (.arc), ARJ (.arj), BZIP2 (.bz2), CAB (.cab), 
COMPRESS (.Z), CPIO (.cpio), DEB (.deb), DMS (.dms), FLAC (.flac), GZIP (.gz), 
ISO (.iso), LRZIP (.lrz), LZH (.lha, .lzh), LZIP (.lz), LZMA (.lzma), 
LZOP (.lzo), RPM (.rpm), RAR (.rar, .cbr), RZIP (.rz), SHN (.shn), 
TAR (.tar, .cbt), XZ (.xz), ZIP (.zip, .jar, .cbz) and ZOO (.zoo) 
archive formats. It relies on helper applications to handle those archive 
formats (for example bzip2 for BZIP2 archives).

The archive formats TAR, ZIP, BZIP2 and GZIP are supported natively and do 
not require helper applications to be installed.

Fedora Account System Username: eclipseo

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1535207] Review Request: ravada - Remote Virtual Desktops Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1535207



--- Comment #6 from Robert-André Mauchin  ---
I fixed the buildroot/RPM_BUILD_ROOT issue mentionned py fedora-review after
this, I don't want to rebuild it for such a minor change.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1542561] Review Request: conu - library which makes it easy to write tests for your containers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1542561



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/conu. You may commit to the branch "f27" in
about 10 minutes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1535207] Review Request: ravada - Remote Virtual Desktops Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1535207



--- Comment #5 from Robert-André Mauchin  ---
Updated with your recommendations:

Spec URL:
https://raw.githubusercontent.com/eclipseo/packaging/25245d1/ravada.spec
SRPM url:
https://copr-be.cloud.fedoraproject.org/results/eclipseo/ravada/fedora-rawhide-x86_64/00710890-ravada/ravada-0.2.13-0.1.20180117gitf70dfbf.fc28.src.rpm

SPEC diff:
https://github.com/eclipseo/packaging/commit/25245d1b5ba77fe0a7ce6a3cc71d2885e36cb648#diff-17e2f419b7ab9101f056c0f5d38fe283

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1540347] Review Request: hashcat - password recovery utility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540347



--- Comment #9 from Igor Gnatenko  ---
you should depend only on ocl-icd... And DNF should really implement pulling in
appropriate implementations automatically. But until it's there, users will
have to manually install appropriate driver.

you can use POCL which is CPU-based implementation... Last time I tried
hashcat, it worked on with POCL and proprietary driver (so no mesa, beignet).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1542583] Review Request: rubygem-em-websocket - EventMachine based WebSocket server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1542583

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #1 from Robert-André Mauchin  ---
Package approved.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated". 52 files have unknown license. Detailed
 output of licensecheck in /home/bob/packaging/review/rubygem-em-
 websocket/review-rubygem-em-websocket/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/gems,
 /usr/share/gems/doc
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Ruby:
[x]: Platform dependent files must all go under %{gem_extdir_mri}, platform
 independent under %{gem_dir}.
[x]: Gem package must not define a non-gem subpackage
[x]: Macro %{gem_extdir} is deprecated.
[x]: Gem package is named rubygem-%{gem_name}
[x]: Package contains BuildRequires: rubygems-devel.
[x]: Gem package must define %{gem_name} macro.
[x]: Pure Ruby package must be built as noarch
[x]: Package does not contain Requires: ruby(abi).

= SHOULD items =

Generic:
[-]: Avoid bundling fonts in non-fonts packages.
 Note: Package contains font files
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary 

[Bug 1540347] Review Request: hashcat - password recovery utility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540347



--- Comment #8 from Jaroslav Škarvada  ---
I used mesa-libOpenCL in the above mentioned test.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1540347] Review Request: hashcat - password recovery utility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540347



--- Comment #7 from Jaroslav Škarvada  ---
It seems there are more problems:

$ hashcat -b
hashcat (v4.0.1) starting in benchmark mode...

Benchmarking uses hand-optimized kernel code by default.
You can use it in your cracking session by setting the -O option.
Note: Using optimized kernel code limits the maximum supported password length.
To disable the optimized kernel code in benchmark mode, use the -w option.

/usr/bin/OpenCL/: No such file or directory

Started: Tue Feb  6 08:06:34 2018
Stopped: Tue Feb  6 08:06:34 2018

The OpenCL directory holds the so called OpenCL "kernels" so it has to be
packed in the base package (and the devel subpackage should be dropped until
upstream will come with the public headers for their API). Also the
/usr/bin/OpenCL/ directory is not good for the OpenCL kernels. You should add
the PREFIX to the build phase, i.e.:

%make_build SHARED=1 DEBUG=1 PREFIX="%{_usr}" ...

Then the hashcat will start looking for the kernels under:
/usr/share/hashcat/OpenCL/ which is not the best, but much better than the 
/usr/bin


Another problem is that hashcat then also needs:
/usr/share/hashcat/hashcat.hctune
/usr/share/hashcat/hashcat.hcstat2

BTW it seems hashcat.hcstat2 is LZMA packed data file,so that's why it bundles
the LZMA_SDK.


On my intel machine I had to force the OpenCL devices and then it started to do
"something":
$ hashcat -b --force
hashcat (v4.0.1) starting in benchmark mode...

Benchmarking uses hand-optimized kernel code by default.
You can use it in your cracking session by setting the -O option.
Note: Using optimized kernel code limits the maximum supported password length.
To disable the optimized kernel code in benchmark mode, use the -w option.

install_dir: /usr/bin, resolved_install_folder: /usr/bin
/usr/share/hashcat
clGetDeviceIDs(): CL_DEVICE_NOT_FOUND

clGetDeviceIDs(): CL_DEVICE_NOT_FOUND

OpenCL Platform #1: Intel
=
* Device #1: Intel(R) HD Graphics Haswell Ultrabook GT2 Mobile, 1536/2048 MB
allocatable, 20MCU

OpenCL Platform #2: The pocl project

* Device #2: pthread-Intel(R) Core(TM) i7-4600U CPU @ 2.10GHz, skipped.

OpenCL Platform #3: Mesa, skipped or no OpenCL compatible devices found.

Benchmark relevant options:
===
* --force
* --optimized-kernel-enable

Hashmode: 900 - MD4

Speed.Dev.#1.:   314.4 MH/s (66.18ms)

Hashmode: 0 - MD5

Speed.Dev.#1.:   201.4 MH/s (51.60ms)

Hashmode: 5100 - Half MD5

Speed.Dev.#1.:   126.3 MH/s (82.44ms)

Hashmode: 100 - SHA1

Speed.Dev.#1.: 35272.3 kH/s (73.79ms)

Hashmode: 1400 - SHA-256

Speed.Dev.#1.: 11895.5 kH/s (54.77ms)

Hashmode: 10800 - SHA-384

ASSERTION FAILED: !(ctx->getErrCode() == OUT_OF_RANGE_IF_ENDIF &&
ctx->getIFENDIFFix())
  at file
/builddir/build/BUILD/Beignet-1.3.2-Source/backend/src/backend/gen_program.cpp,
function virtual gbe::Kernel* gbe::GenProgram::compileKernel(const
gbe::ir::Unit&, const string&, bool, int), line 248
Trasovací/ladící past (SIGTRAP) (core dumped [obraz paměti uložen])


Well, it's bad that it hung - we need to find out why from the coredump and
probably address the problem upstream, but it's not blocker for the packaging.


Also we should probably use:
ExclusiveArch: %{ix86} x86_64 %{arm}

in the spec file to limit the arches to x86 and arm only - I don't know much
about OpenCL, but it still seems to be x86/arm specific (I haven't tried it on
ARM, so I don't know whether it's usable there). But on ppc64:
$ hashcat -b
hashcat (v4.0.1) starting in benchmark mode...

Benchmarking uses hand-optimized kernel code by default.
You can use it in your cracking session by setting the -O option.
Note: Using optimized kernel code limits the maximum supported password length.
To disable the optimized kernel code in benchmark mode, use the -w option.

Cannot find an OpenCL ICD loader library.

You are probably missing the native OpenCL runtime or driver for your platform.

* AMD GPUs on Linux require this runtime and/or driver:
  "RadeonOpenCompute (ROCm)" Software Platform (1.6.180 or later)
* Intel CPUs require this runtime and/or driver:
  "OpenCL Runtime for Intel Core and Intel Xeon Processors" (16.1.1 or later)
* Intel GPUs on Linux require this runtime and/or driver:
  "OpenCL 2.0 GPU Driver Package for Linux" (2.0 or later)
* NVIDIA GPUs require this runtime and/or driver:
  "NVIDIA Driver" (367.x or later)

So contrary to the hashcat-legacy which worked with the CPU, the new hashcat
seems not to work without OpenCL, so it's probably useless to build it for
architectures where OpenCL is not supported.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to 

[Bug 1542598] Review Request: compat-xerces-c31 - Compat package with xerces-c libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1542598



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/compat-xerces-c31

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1509856] Review Request: php-phpunit-php-token-stream2 - Wrapper around PHP tokenizer extension

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1509856



--- Comment #7 from Fedora Update System  ---
php-phpunit-PHP-TokenStream-1.4.12-1.fc27
php-phpunit-php-token-stream2-2.0.2-1.fc27 has been submitted as an update to
Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-96c0ff19a5

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1509856] Review Request: php-phpunit-php-token-stream2 - Wrapper around PHP tokenizer extension

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1509856

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1542598] Review Request: compat-xerces-c31 - Compat package with xerces-c libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1542598

Chris Sandler  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||ch...@protonmail.com
   Assignee|nob...@fedoraproject.org|ch...@protonmail.com
  Flags||fedora-review+



--- Comment #1 from Chris Sandler  ---
Approving as per the blanket exception.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1542598] Review Request: compat-xerces-c31 - Compat package with xerces-c libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1542598

Pete Walter  changed:

   What|Removed |Added

   Assignee|walter.p...@yandex.com  |nob...@fedoraproject.org
  Flags|fedora-review+  |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1542561] Review Request: conu - library which makes it easy to write tests for your containers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1542561

Tomas Tomecek  changed:

   What|Removed |Added

 Status|NEW |POST
  Flags||fedora-review+



--- Comment #1 from Tomas Tomecek  ---
Two notes inline. These don't block the review.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.

 Note: sources don't contain short license in their header, this will
 be fixed in next upstream release:
 https://github.com/fedora-modularity/conu/issues/137

[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by: /usr/lib/python2.7/site-
 packages/conu/backend/docker(python2-conu, conu), /usr/lib/python2.7
 /site-packages/conu(python2-conu, conu), /usr/lib/python2.7/site-
 packages/conu/backend(python2-conu, conu), /usr/lib/python2.7/site-
 packages/conu/utils(python2-conu, conu), /usr/lib/python2.7/site-
 packages/conu/apidefs(python2-conu, conu)
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[x]: Avoid bundling fonts in non-fonts packages.
 Note: Package contains font files
[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in 

[Bug 1542598] Review Request: compat-xerces-c31 - Compat package with xerces-c libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1542598

Pete Walter  changed:

   What|Removed |Added

Summary|Review Request: |Review Request:
   |compat-xerces-c31   |compat-xerces-c31 - Compat
   ||package with xerces-c
   ||libraries



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1542598] Review Request: compat-xerces-c31

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1542598

Pete Walter  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|walter.p...@yandex.com
  Flags||fedora-review+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376885] Dummy package review ticket for multiply-versioned packages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376885



--- Comment #19 from Pete Walter  ---
Filed https://bugzilla.redhat.com/show_bug.cgi?id=1542598 for compat-xerces-c31

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1513669] Review Request: php-phpmailer6 - Full-featured email creation and transfer class for PHP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1513669



--- Comment #8 from Fedora Update System  ---
php-phpmailer6-6.0.3-1.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-225a8b6ce9

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1526056] Review Request: rubygem-ascii_binder - An AsciiDoc-based system for authoring and publishing documentation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1526056



--- Comment #10 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rubygem-ascii_binder

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1514274] Review Request: twitter-twemoji-fonts - Twitter Emoji for everyone

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1514274



--- Comment #31 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/twitter-twemoji-fonts. You may commit to the
branch "f27" in about 10 minutes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1542598] New: Review Request: compat-xerces-c31

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1542598

Bug ID: 1542598
   Summary: Review Request: compat-xerces-c31
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: walter.p...@yandex.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



The process for requesting a new package repository currently requires a
package review ticket even in those cases where the package has been granted an
exception (either an existing blanket exception or a specific exception granted
by the packaging committee).

As the designated ticket for the exception process
(https://bugzilla.redhat.com/show_bug.cgi?id=1376885) can no longer be used due
to new scm processing requirements that the ticket reporter match with scm repo
requester, I'm filing a new ticket for this package.

compat-xerces-c31 is being requested without review under the blanket exception
for multi-versioned packages.

Existing package: xerces-c
New package: compat-xerces-c31

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539323] Review Request: ghc-unliftio-core - The MonadUnliftIO typeclass for unlifting monads to IO

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539323



--- Comment #3 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/ghc-unliftio-core. You may commit to the
branch "f27" in about 10 minutes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1513669] Review Request: php-phpmailer6 - Full-featured email creation and transfer class for PHP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1513669



--- Comment #9 from Fedora Update System  ---
php-phpmailer6-6.0.3-1.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-723d9c742c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376885] Dummy package review ticket for multiply-versioned packages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376885

Pete Walter  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |NOTABUG
   Assignee|walter.p...@yandex.com  |nob...@fedoraproject.org
Summary|Review Request: |Dummy package review ticket
   |compat-xerces-c31 - Compat  |for multiply-versioned
   |package with xerces-c   |packages
   |libraries   |
  Flags|fedora-review+  |
Last Closed|2017-11-28 07:43:12 |2018-02-06 10:57:40



--- Comment #18 from Pete Walter  ---
Grr. Apparently we can't use this ticket any more as the scm request ticket was
closed as invalid, "The Bugzilla review bug creator didn't match the requester
in Pagure." 

https://pagure.io/releng/fedora-scm-requests/issue/4404

I'll file a new ticket with intent to skip package review for the parallel
installable package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1542485] Review Request: phpcpd - Copy/Paste Detector (CPD) for PHP code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1542485



--- Comment #3 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/phpcpd

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1513669] Review Request: php-phpmailer6 - Full-featured email creation and transfer class for PHP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1513669

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1540422] Review Request: ghc-typed-process - Run external processes, with strong typing of streams

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540422



--- Comment #4 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/ghc-typed-process. You may commit to the
branch "f27" in about 10 minutes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539920] Review Request: rocm-runtime - ROCm runtime driver for AMD compute

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539920

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #8 from Robert-André Mauchin  ---

[!]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/include/hsa

 Remove the * to own the directory:

%{_includedir}/hsa/*


Package otherwise approved. Just fix the above error before import.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "*No copyright* BSD (3 clause)", "Unknown or generated". 112
 files have unknown license. Detailed output of licensecheck in
 /home/bob/packaging/review/rocm-runtime/review-rocm-
 runtime/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/include/hsa
[!]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/include/hsa
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see 

[Bug 1539314] Review Request: ghc-basement - Foundation scrap box of array & string

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539314



--- Comment #4 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/ghc-basement. You may commit to the branch
"f27" in about 10 minutes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1542583] New: Review Request: rubygem-em-websocket - EventMachine based WebSocket server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1542583

Bug ID: 1542583
   Summary: Review Request: rubygem-em-websocket - EventMachine
based WebSocket server
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: jar.pro...@volny.cz
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://gitlab.com/jackorp/rubygem-em-websocket/raw/163856ec63e493e114ba2b3c48b5ef774578fb46/rubygem-em-websocket.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/vondruch/ascii_binder/fedora-rawhide-x86_64/00710653-rubygem-em-websocket/rubygem-em-websocket-0.5.1-1.fc28.src.rpm
Description: EventMachine based WebSocket server.
Fedora Account System Username: jackorp
Koji:https://koji.fedoraproject.org/koji/taskinfo?taskID=24753821

Some tests were disabled due to absense of some packages needed for these tests
in fedora.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1537805] Review Request: python-josepy - JOSE protocol implementation in Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1537805

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2018-02-06 10:34:46



--- Comment #12 from Fedora Update System  ---
certbot-0.21.1-1.fc27, python-acme-0.21.1-1.fc27,
python-certbot-apache-0.21.1-1.fc27, python-certbot-dns-rfc2136-0.21.1-1.fc27,
python-certbot-nginx-0.21.1-1.fc27, python-josepy-1.0.1-1.fc27 has been pushed
to the Fedora 27 stable repository. If problems still persist, please make note
of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1527289] Review Request: nototools - Noto fonts support tools and scripts plus web site generation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1527289

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2018-02-06 10:35:08



--- Comment #20 from Fedora Update System  ---
google-noto-emoji-fonts-20170928-3.fc27, nototools-0-0.20170926.git0c99dff.fc27
has been pushed to the Fedora 27 stable repository. If problems still persist,
please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1514274] Review Request: twitter-twemoji-fonts - Twitter Emoji for everyone

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1514274
Bug 1514274 depends on bug 1527289, which changed state.

Bug 1527289 Summary: Review Request: nototools - Noto fonts support tools and 
scripts plus web site generation
https://bugzilla.redhat.com/show_bug.cgi?id=1527289

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1542485] Review Request: phpcpd - Copy/Paste Detector (CPD) for PHP code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1542485



--- Comment #2 from Remi Collet  ---
Thanks for the review!

SCM request
https://pagure.io/releng/fedora-scm-requests/issue/4407

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539291] Review Request: ghc-echo - Cross-platform, cross-console echoing of terminal input

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539291



--- Comment #4 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/ghc-echo. You may commit to the branch "f27"
in about 10 minutes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org