[Bug 1507103] Review Request: kronosnet - Multipoint-to-Multipoint network abstraction layer for High Availability applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1507103



--- Comment #38 from digimer  ---
> - Please remove %defattr(-,root,root,-) everywhere

Done.

> - For kronosnetd:
>  * Requires(preun): shadow-utils <-- not needed

What about the (postrun) entry? I've left that for now.

>   * groupadd --force kronosnetadm <-- kronosnetadm should be system account 
> (and force is not needed), so result should be "groupadd -r kronosnetadm"

OK, but I used the more verbose '--system' just to be a little more
self-documenting.

> So the question is, if you want to keep compatibility with non-systemd systems

No, I see no reason for this. Knet will never run on EL6. I do test against
EPEL7 and modern Fedoras, which are all systemd now. I'd actually prefer to
remove all sysvinit stuff down the road. I'm only not doing it now because I
still have too much to learn and I didn't want to slow down the initial
release.

Now that it is an issue though (if minor), I will try to remove it in this
release. I apologize if this introduces new issues at this stage.

> - Missing "BuildRequires: systemd" (probably conditional) so something like

Given the above comment, I added it without conditional. 

> Forgot one more thing. We need more %{_isa}. Just add them basically for 
> every...

Done.

New .spec and srpm:
https://www.alteeve.com/an-repo/files/packages/kronosnet.spec.1.0-6
https://www.alteeve.com/an-repo/files/packages/kronosnet-1.0-6.fc27.src.rpm

f26:
https://koji.fedoraproject.org/koji/taskinfo?taskID=25061282

f27:
https://koji.fedoraproject.org/koji/taskinfo?taskID=25061295

rawhide:
https://koji.fedoraproject.org/koji/taskinfo?taskID=25061303

epel7:
https://koji.fedoraproject.org/koji/taskinfo?taskID=25061269


Here is the diff in .spec from 1.0-5;


--- kronosnet.spec.1.0-52018-02-12 14:20:52.122179273 -0500
+++ kronosnet.spec.1.0-62018-02-15 00:25:25.797016016 -0500
@@ -70,7 +70,7 @@
 Name: kronosnet
 Summary: Multipoint-to-Multipoint VPN daemon
 Version: 1.0
-Release: 5%{?dist}
+Release: 6%{?dist}
 License: GPLv2+ and LGPLv2+
 URL: http://www.kronosnet.org
 Source0: http://www.kronosnet.org/releases/kronosnet-%{version}.tar.gz
@@ -78,6 +78,7 @@

 # Build dependencies
 BuildRequires: gcc
+BuildRequires: systemd
 # required to build man pages
 BuildRequires: libqb-devel libxml2-devel doxygen
 %if %{defined buildsctp}
@@ -170,11 +171,7 @@
 --enable-libtap \
 %endif
 --with-initdefaultdir=%{_sysconfdir}/sysconfig/ \
-%if %{defined _unitdir}
 --with-systemddir=%{_unitdir}
-%else
---with-initddir=%{_sysconfdir}/rc.d/init.d/
-%endif

 make %{_smp_mflags}

@@ -188,13 +185,8 @@
 find %{buildroot} -name "*.la" -exec rm {} \;

 # handle systemd vs init script
-%if %{defined _unitdir}
 # remove init scripts
 rm -rf %{buildroot}/etc/init.d
-%else
-# remove systemd specific bits
-find %{buildroot} -name "*.service" -exec rm {} \;
-%endif

 # remove docs
 rm -rf %{buildroot}/usr/share/doc/kronosnet
@@ -209,7 +201,6 @@
 Summary: Multipoint-to-Multipoint VPN daemon
 License: GPLv2+ and LGPLv2+
 Requires(post): shadow-utils
-Requires(preun): shadow-utils
 Requires: pam, /etc/pam.d/passwd

 %description -n kronosnetd
@@ -228,21 +219,14 @@
 getent group kronosnetadm >/dev/null || groupadd --force kronosnetadm

 %preun -n kronosnetd
-%if %{defined _unitdir}
- %if 0%{?systemd_preun:1}
+%if 0%{?systemd_preun:1}
   %systemd_preun kronosnetd.service
- %else
+%else
 if [ "$1" -eq 0 ]; then
 /bin/systemctl --no-reload disable kronosnetd.service
 /bin/systemctl stop kronosnetd.service >/dev/null 2>&1
 fi
 %endif
-%else
-if [ "$1" = 0 ]; then
-/sbin/service kronosnetd stop >/dev/null 2>&1
-/sbin/chkconfig --del kronosnetd
-fi
-%endif

 %files -n kronosnetd
 %license COPYING.* COPYRIGHT 
@@ -251,11 +235,7 @@
 %config(noreplace) %{_sysconfdir}/sysconfig/kronosnetd
 %config(noreplace) %{_sysconfdir}/pam.d/kronosnetd
 %config(noreplace) %{_sysconfdir}/logrotate.d/kronosnetd
-%if %{defined _unitdir}
 %{_unitdir}/kronosnetd.service
-%else
-%config(noreplace) %{_sysconfdir}/rc.d/init.d/kronosnetd
-%endif
 %{_sbindir}/*
 %{_mandir}/man8/*
 %endif
@@ -271,7 +251,6 @@
  pre-up.d/up.d/down.d/post-down.d infrastructure.

 %files -n libtap1
-%defattr(-,root,root,-)
 %license COPYING.* COPYRIGHT
 %{_libdir}/libtap.so.*

@@ -282,7 +261,7 @@
 %package -n libtap1-devel
 Summary: Simple userland wrapper around kernel tap devices (developer files)
 License: GPLv2+ and LGPLv2+
-Requires: libtap1 = %{version}-%{release}
+Requires: libtap1%{_isa} = %{version}-%{release}
 Requires: pkgconfig

 %description -n libtap1-devel
@@ -291,7 +270,6 @@
  pre-up.d/up.d/down.d/post-down.d infrastructure.

 %files -n libtap1-devel
-%defattr(-,root,root,-)
 %license COPYING.* COPYRIGHT
 %{_libdir}/libtap.so
 %{_includedir}/libtap.h
@@ -312,7 +290,6 @@
  Please refer to https://kronosnet.org/ for further  information.

 %files -n libknet1
-%defattr(-,root,root,-)
 %license COPYING.* COPYRIGHT
 %{_libdir}/libknet.so.*

[Bug 1536780] Review Request: swift-lang - Apple' s Swift Programming Language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536780



--- Comment #14 from Ron Olson  ---
I've updated the spec file and generated two new rpm files to take into account
a bug fix that I submitted to Apple and they merged:
https://github.com/apple/swift/pull/14589. This allows Swift to be built
successfully using Clang 6 on Rawhide. I tested it against 5.0.1 on F27 and it
builds successfully there as well.


https://tachoknight.fedorapeople.org/swift-lang/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1346249] Review Request: resultsdb - Results store for automated tasks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1346249

Bugzilla account termination  changed:

   What|Removed |Added

   Assignee|jku...@redhat.com   |nob...@fedoraproject.org



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1249211] Review Request: cndoom - Conservative Doom engine for speedrunning competition

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1249211



--- Comment #7 from Adam Williamson  ---
Quick update - the github repo disappeared. The author is still active on
Doomworld forums, I've sent him a message asking what's going on.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1545479] New: Review Request: hcc- Heterogeneous C++ Compiler

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1545479

Bug ID: 1545479
   Summary: Review Request: hcc- Heterogeneous C++ Compiler
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: tstel...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
http://copr-dist-git.fedorainfracloud.org/cgit/tstellar/rocm-1.6-userspace/hcc.git/plain/hcc.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/tstellar/rocm-1.6-userspace/fedora-rawhide-x86_64/00715528-hcc/hcc-1.0-15.rocm1.6.0.fc28.src.rpm
Description: Heterogeneous C++ Compiler
Fedora Account System Username: tstellar

hcc is a GPU compiler for single source C++ like languages.  It supports AMD
GPUs using the ROCm driver stack.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1545347] Review Request: microdns - Minimal mDNS resolver and announcer library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1545347



--- Comment #5 from Fedora Update System  ---
microdns-0.0.8-1.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-90b401026b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1545347] Review Request: microdns - Minimal mDNS resolver and announcer library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1545347



--- Comment #4 from Fedora Update System  ---
microdns-0.0.8-1.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-0b2cfbc4a9

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1545347] Review Request: microdns - Minimal mDNS resolver and announcer library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1545347

Fedora Update System  changed:

   What|Removed |Added

 Status|NEW |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1545347] Review Request: microdns - Minimal mDNS resolver and announcer library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1545347



--- Comment #3 from Fedora Update System  ---
microdns-0.0.8-1.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-1a15d7bad0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1545347] Review Request: microdns - Minimal mDNS resolver and announcer library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1545347



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/microdns

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1544605] Review Request: python-digitalocean - Easy access to Digital Ocean APIs to deploy droplets , images and more

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1544605



--- Comment #7 from Fedora Update System  ---
python-digitalocean-1.13.2-1.el7 has been submitted as an update to Fedora EPEL
7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-3e30720bac

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1544605] Review Request: python-digitalocean - Easy access to Digital Ocean APIs to deploy droplets , images and more

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1544605



--- Comment #6 from Fedora Update System  ---
python-digitalocean-1.13.2-1.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-35a463bf31

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1544605] Review Request: python-digitalocean - Easy access to Digital Ocean APIs to deploy droplets , images and more

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1544605

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1544605] Review Request: python-digitalocean - Easy access to Digital Ocean APIs to deploy droplets , images and more

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1544605



--- Comment #5 from Fedora Update System  ---
python-digitalocean-1.13.2-1.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-78a6ca0968

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1544555] Review Request: python-certbot-dns-google - Google Cloud DNS Authenticator plugin for Certbot

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1544555



--- Comment #7 from Fedora Update System  ---
python-certbot-dns-google-0.21.1-1.el7 has been submitted as an update to
Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-bc20e94f8f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1544555] Review Request: python-certbot-dns-google - Google Cloud DNS Authenticator plugin for Certbot

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1544555



--- Comment #6 from Fedora Update System  ---
python-certbot-dns-google-0.21.1-1.fc26 has been submitted as an update to
Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2018-3ed7ad5399

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1544555] Review Request: python-certbot-dns-google - Google Cloud DNS Authenticator plugin for Certbot

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1544555



--- Comment #5 from Fedora Update System  ---
python-certbot-dns-google-0.21.1-1.fc27 has been submitted as an update to
Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-e19835bffa

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1544555] Review Request: python-certbot-dns-google - Google Cloud DNS Authenticator plugin for Certbot

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1544555

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1544562] Review Request: python-certbot-dns-route53 - Route53 DNS Authenticator plugin for Certbot

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1544562



--- Comment #7 from Fedora Update System  ---
python-certbot-dns-route53-0.21.1-1.el7 has been submitted as an update to
Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-fe7cb9101a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1544562] Review Request: python-certbot-dns-route53 - Route53 DNS Authenticator plugin for Certbot

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1544562



--- Comment #6 from Fedora Update System  ---
python-certbot-dns-route53-0.21.1-1.fc26 has been submitted as an update to
Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2018-8f9cc4c12e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1544562] Review Request: python-certbot-dns-route53 - Route53 DNS Authenticator plugin for Certbot

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1544562

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1544562] Review Request: python-certbot-dns-route53 - Route53 DNS Authenticator plugin for Certbot

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1544562



--- Comment #5 from Fedora Update System  ---
python-certbot-dns-route53-0.21.1-1.fc27 has been submitted as an update to
Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-8e32abe174

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1492475] Review Request: aftertheflood-sparks-fonts - a font to display charts within text

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1492475



--- Comment #14 from Elliott Sales de Andrade  ---
Please fill out the font description template [1] in the wiki for these new
fonts as well.

[1] https://fedoraproject.org/wiki/Font_description_template

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1428202] Review Request: sirikali - GUI front end to encfs,cryfs, gocryptfs and securefs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1428202



--- Comment #30 from Fedora Update System  ---
sirikali-1.3.3-1.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-4e325158b8

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1428202] Review Request: sirikali - GUI front end to encfs,cryfs, gocryptfs and securefs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1428202

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538658] Review Request: python-anyconfig - common API to load and dump configuration files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538658

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags||fedora-review+



--- Comment #18 from Zbigniew Jędrzejewski-Szmek  ---
Note: I bumped the version to 0.9.4 manually, the spec file still says 0.9.3.

The %changelog in the rpm package is _not_ supposed to be a reflection of the
vcs logs of upstream. It should be a short overview of high-level changes
relevant to the user of the package. Hence, it'd even be better to say "0.9.4
Update to latest upstream version, minor cleanups", i.e. give no details,
rather than overwhelm the users with details they don't care about. E.g. there
is no python3.3 in any supported Fedora, and some deprecated or replaced
methods are not important for the user. See
https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs. This is a minor
thing, also a bit of personal preference, and I'm not saying you have to change
the style, and especially not for past entries, but please consider it for the
future.

+ package name is OK
+ license is acceptable for Fedora (MIT)
+ license is specified correctly
+ builds and install OK
+ Provides/Requires/BR look correct
+ new python packaging macros are used
+ %python_provide macros is used

Package is APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1545347] Review Request: microdns - Minimal mDNS resolver and announcer library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1545347

Wolfgang Ulbrich  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1545347] Review Request: microdns - Minimal mDNS resolver and announcer library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1545347



--- Comment #1 from Wolfgang Ulbrich  ---
APPROVED!

Please fix  %{buildroot}/$RPM_BUILD_ROOT issue before uploading




Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Package uses either %{buildroot} or $RPM_BUILD_ROOT
  Note: Using both %{buildroot} and $RPM_BUILD_ROOT
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#macros
- ldconfig called in %post and %postun if required.
  Note: /sbin/ldconfig not called in libmicrodns
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#Shared_Libraries

Fales positive. Rpmlint needs updating to newest scriptlets.
see
https://fedoraproject.org/wiki/Packaging:Scriptlets?rd=Packaging:ScriptletSnippets#Shared_Libraries


= MUST items =

C/C++:
[x]: Provides: bundled(gnulib) in place as required.
 Note: Sources not installed
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: There is no build directory. Running licensecheck on vanilla
 upstream sources. No licenses found. Please check the source files for
 licenses manually.
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} 

[Bug 1538658] Review Request: python-anyconfig - common API to load and dump configuration files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538658



--- Comment #17 from Brett Lentz  ---
New spec and srpm are now up at the location in comment #7.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1545378] Review Request: libmicrodns - Minimal mDNS resolver library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1545378



--- Comment #1 from Nicolas Chauvet (kwizart)  ---
koji scratch build
https://koji.fedoraproject.org/koji/taskinfo?taskID=25049910

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1545378] New: Review Request: libmicrodns - Minimal mDNS resolver library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1545378

Bug ID: 1545378
   Summary: Review Request: libmicrodns - Minimal mDNS resolver
library
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: kwiz...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: http://dl.kwizart.net/review/libmicrodns.spec
SRPM URL: http://dl.kwizart.net/review/libmicrodns-0.0.8-1.fc26.src.rpm
Description: Minimal mDNS resolver library
Fedora Account System Username: kwizart

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1396847] Review Request: screencloud - Easy to use screenshot sharing application

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396847



--- Comment #7 from Igor Gnatenko  ---
(In reply to Tomáš Korbař from comment #5)
> Hello,
> According to the fedora-review you dont have to list "gcc" and "make" in
> BuildRequires, i compiled the code after removal and it works so i think you
> can remove it.
> Upstream already accepted change of desktop file and removed execution
> permission from LICENSE and README.md so you can remove that parts too.

Bad luck, fedora-review. Guidelines say to explicitly mention everything.

(In reply to Tomáš Korbař from comment #6)
> And if you would have some time you could also look at the unbundling.

I tried to, but I failed (at least on libxqt), and qtsingleapplication failed
too because they patch code.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1541554] Review Request: podman - Manage Pods, Containers and Container Images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1541554

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #11 from Fedora Update System  ---
podman-0.2-2.git3d0100b.fc27 has been pushed to the Fedora 27 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-23fa359f4c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1543813] Review Request: pwkickstart - generate kickstart passwords

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1543813



--- Comment #9 from Fedora Update System  ---
pwkickstart-1.0.2-1.fc27 has been pushed to the Fedora 27 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-fcd5fb27e1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1492475] Review Request: aftertheflood-sparks-fonts - a font to display charts within text

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1492475

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #13 from Fedora Update System  ---
aftertheflood-sparks-fonts-2.0-1.fc27 has been pushed to the Fedora 27 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-bd6471dbac

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1537727] Review Request: python-cattrs - Python library for structuring and unstructuring data

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1537727

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #4 from Fedora Update System  ---
python-cattrs-0.6.0-3.fc27 has been pushed to the Fedora 27 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-bb6df012c9

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519323] Review request: qesteidutil - Estonian ID card utility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519323

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #14 from Fedora Update System  ---
qesteidutil-3.12.10-1.fc27 has been pushed to the Fedora 27 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-54c7a5b01b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1495293] Review Request: python-Naked - A command line application framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1495293

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #10 from Fedora Update System  ---
python-Naked-0.1.31-3.fc27 has been pushed to the Fedora 27 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-91d06f2add

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1545347] Review Request: microdns - Minimal mDNS resolver and announcer library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1545347

Wolfgang Ulbrich  changed:

   What|Removed |Added

  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1545347] Review Request: microdns - Minimal mDNS resolver and announcer library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1545347

Wolfgang Ulbrich  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|fed...@raveit.de



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1396847] Review Request: screencloud - Easy to use screenshot sharing application

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396847



--- Comment #6 from Tomáš Korbař  ---
And if you would have some time you could also look at the unbundling.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1543813] Review Request: pwkickstart - generate kickstart passwords

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1543813

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #8 from Fedora Update System  ---
pwkickstart-1.0.2-1.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-0b09e66084

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539276] Review Request: rust-threadpool - Thread pool for running a number of jobs on a fixed set of worker threads

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539276

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2018-02-14 12:29:19



--- Comment #7 from Fedora Update System  ---
rust-threadpool-1.7.1-2.fc27 has been pushed to the Fedora 27 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519081] Review Request: scribus-generator - Open source high-quality PDF template and mail-merge alternative

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519081



--- Comment #21 from Fedora Update System  ---
scribus-generator-2.5-5.fc27 has been pushed to the Fedora 27 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1541441] Review Request: python-txredisapi - Non-blocking Redis client for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1541441

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2018-02-14 12:29:09



--- Comment #5 from Fedora Update System  ---
python-txredisapi-1.4.4-1.fc27 has been pushed to the Fedora 27 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1535292] Review Request: vagrant-openstack-provider - Vagrant plugin for OpenStack provider

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1535292

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2018-02-14 12:28:47



--- Comment #10 from Fedora Update System  ---
vagrant-openstack-provider-0.11.0-2.fc27 has been pushed to the Fedora 27
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1535292] Review Request: vagrant-openstack-provider - Vagrant plugin for OpenStack provider

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1535292
Bug 1535292 depends on bug 1535291, which changed state.

Bug 1535291 Summary: Review Request: rubygem-terminal-table - Simple, feature 
rich ascii table generation library
https://bugzilla.redhat.com/show_bug.cgi?id=1535291

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1535291] Review Request: rubygem-terminal-table - Simple, feature rich ascii table generation library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1535291

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2018-02-14 12:28:43



--- Comment #8 from Fedora Update System  ---
rubygem-terminal-table-1.8.0-2.fc27 has been pushed to the Fedora 27 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1529202] Review Request: ocaml-migrate-parsetree - Convert OCaml parsetrees between different major versions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1529202

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2018-02-14 12:27:37



--- Comment #7 from Fedora Update System  ---
ocaml-migrate-parsetree-1.0.7-1.fc27 has been pushed to the Fedora 27 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1528530] Review Request: ocaml-rope - Ropes ("heavyweight strings") for OCaml

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1528530

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2018-02-14 12:27:34



--- Comment #5 from Fedora Update System  ---
ocaml-rope-0.6.1-1.fc27 has been pushed to the Fedora 27 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539281] Review Request: rust-chan - Multi-producer, multi-consumer channels with select

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539281

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed|2018-01-28 02:02:09 |2018-02-14 12:27:25



--- Comment #8 from Fedora Update System  ---
rust-chan-0.1.20-1.fc27 has been pushed to the Fedora 27 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1545349] Review Request: libplacebo - Reusable library for GPU-accelerated video/ image rendering primitives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1545349



--- Comment #1 from Nicolas Chauvet (kwizart)  ---
koji scratch build on f28:
https://koji.fedoraproject.org/koji/taskinfo?taskID=25048142

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1545349] New: Review Request: libplacebo - Reusable library for GPU-accelerated video/ image rendering primitives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1545349

Bug ID: 1545349
   Summary: Review Request: libplacebo - Reusable library for
GPU-accelerated video/image rendering primitives
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: kwiz...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: http://dl.kwizart.net/review/libplacebo.spec
SRPM URL: http://dl.kwizart.net/review/libplacebo-0.4.0-1.fc26.src.rpm
Description: Reusable library for GPU-accelerated video/image rendering
primitives
Fedora Account System Username: kwizart

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1545347] New: Review Request: microdns - Minimal mDNS resolver and announcer library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1545347

Bug ID: 1545347
   Summary: Review Request: microdns - Minimal mDNS resolver and
announcer library
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: leigh123li...@googlemail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://leigh123linux.fedorapeople.org/pub/review/mircodns/1/microdns.spec

SRPM URL:
https://leigh123linux.fedorapeople.org/pub/review/mircodns/1/microdns-0.0.8-1.fc28.src.rpm

Description: Minimal mDNS resolver and announcer library
Fedora Account System Username: leigh123linux

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519081] Review Request: scribus-generator - Open source high-quality PDF template and mail-merge alternative

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519081

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2018-02-14 12:10:06



--- Comment #20 from Fedora Update System  ---
scribus-generator-2.5-5.fc26 has been pushed to the Fedora 26 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534137] Review Request: fluxcapacitor - run programs without blocking on syscalls

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534137



--- Comment #21 from Fedora Update System  ---
fluxcapacitor-0-4.20180114git0b6a11b.el6 has been pushed to the Fedora EPEL 6
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534137] Review Request: fluxcapacitor - run programs without blocking on syscalls

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534137



--- Comment #20 from Fedora Update System  ---
fluxcapacitor-0-4.20180114git0b6a11b.el7 has been pushed to the Fedora EPEL 7
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1544716] Review Request: golang-github-inconshreveable-go-vhost - HTTP/ TLS hostname multiplexing library for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1544716

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #3 from Robert-André Mauchin  ---
Package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538658] Review Request: python-anyconfig - common API to load and dump configuration files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538658



--- Comment #16 from Zbigniew Jędrzejewski-Szmek  ---
OK.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1499443] Review Request: git-pull-request - Command line tool to send GitHub pull-request

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1499443

Sergio Monteiro Basto  changed:

   What|Removed |Added

 CC||ser...@serjux.com



--- Comment #4 from Sergio Monteiro Basto  ---
git-extras have already  git-pull-request [1] 

git-pull-request from git-pull-request  have anything better than the version
of git-extras ? 



[1] 
   git-pull-request - Create pull request for GitHub project

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1310434] Review Request: python-wxpython4 - new implementation of wxPython (Phoenix)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1310434



--- Comment #14 from Miro Hrončok  ---
Please add a comment about the license. "wxWidgets and BSD" doesn't provide
enough information.


I've just noticed the docs subpackage. It's common to name it doc, not docs.
Guidelines says it is recommended, so feel free to keep it as it is.
https://fedoraproject.org/wiki/Packaging:Guidelines#Documentation


Please also change sip and sip-devel to python2-sip and python2-sip-devel.
Sorry for not noticing this earlier.


Still no license file in docs package.


python-wxpython4-docs.noarch: W: file-not-utf8
/usr/share/doc/python-wxpython4-docs/demo/TestTable.txt
python-wxpython4-docs.noarch: W: file-not-utf8
/usr/share/doc/python-wxpython4-docs/docs/sphinx/_downloads/i18nwxapp/i18nwxapp.zip
python-wxpython4-docs.noarch: W: file-not-utf8
/usr/share/doc/python-wxpython4-docs/docs/sphinx/_downloads/i18nwxapp/locale/I18Nwxapp.pot
python-wxpython4-docs.noarch: W: file-not-utf8
/usr/share/doc/python-wxpython4-docs/docs/sphinx/class_summary.pkl
python-wxpython4-docs.noarch: W: file-not-utf8
/usr/share/doc/python-wxpython4-docs/docs/sphinx/wx.1moduleindex.pkl
python-wxpython4-docs.noarch: W: spurious-executable-perm
/usr/share/doc/python-wxpython4-docs/samples/mainloop/mainloop.py

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538658] Review Request: python-anyconfig - common API to load and dump configuration files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538658



--- Comment #15 from Satoru SATOH  ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #10)
> And also (a question for upstream): why is the executable called
> "anyconfig_cli" and not just "anyconfig"?

"anyconfig" feels too generic for me and it's just a demo program of this
library at the time I first made it.
And, to change its name causes other issues (I have to update all its
references in the doc at least),
so I want to keep as it is.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1315809] Review Request: python-pylxd - python library for lxd

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315809

James Paul Turner  changed:

   What|Removed |Added

 CC||karlthe...@gmail.com
  Flags||needinfo?(karlthered@gmail.
   ||com)



--- Comment #3 from James Paul Turner  ---
I will leave the request open for another week. Kindly respond within this
period if you still wish your package to be reviewed, else please disregard
this message.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1541554] Review Request: podman - Manage Pods, Containers and Container Images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1541554

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1541554] Review Request: podman - Manage Pods, Containers and Container Images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1541554



--- Comment #10 from Fedora Update System  ---
podman-0.2-2.git3d0100b.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-23fa359f4c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1492475] Review Request: aftertheflood-sparks-fonts - a font to display charts within text

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1492475



--- Comment #12 from Fedora Update System  ---
aftertheflood-sparks-fonts-2.0-1.fc27 has been submitted as an update to Fedora
27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-bd6471dbac

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1492475] Review Request: aftertheflood-sparks-fonts - a font to display charts within text

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1492475

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1543813] Review Request: pwkickstart - generate kickstart passwords

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1543813



--- Comment #7 from Fedora Update System  ---
pwkickstart-1.0.2-1.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-fcd5fb27e1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1543813] Review Request: pwkickstart - generate kickstart passwords

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1543813

Fedora Update System  changed:

   What|Removed |Added

 Status|NEW |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1543813] Review Request: pwkickstart - generate kickstart passwords

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1543813



--- Comment #6 from Fedora Update System  ---
pwkickstart-1.0.2-1.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-0b09e66084

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1545163] Review Request: python-sphinx-click - Sphinx extension that automatically documents click applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1545163



--- Comment #1 from Michal Cyprian  ---
SRPM was build for f27 not rawhide, updated files:

Spec URL: https://mcyprian.fedorapeople.org/python-sphinx-click.spec
SRPM URL:
https://mcyprian.fedorapeople.org/python-sphinx-click-1.0.4-1.fc28.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1545163] New: Review Request: python-sphinx-click - Sphinx extension that automatically documents click applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1545163

Bug ID: 1545163
   Summary: Review Request: python-sphinx-click - Sphinx extension
that automatically documents click applications
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: mcypr...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://mcyprian.fedorapeople.org/python-sphinx-click.spec
SRPM URL:
https://mcyprian.fedorapeople.org/python-sphinx-click-1.0.4-1.fc27.src.rpm
Description:
sphinx-click is a Sphinx plugin that allows you to automatically extract
documentation from a click-based application and include it in your docs.

This is a build dependency of Pipenv — the officially recommended Python
packaging tool from Python.org.

Fedora Account System Username: mcyprian

Successful build in Copr:
https://copr.fedorainfracloud.org/coprs/mcyprian/pipenv/build/715240/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1544716] Review Request: golang-github-inconshreveable-go-vhost - HTTP/ TLS hostname multiplexing library for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1544716



--- Comment #2 from Jiri Kucera  ---
Hello Robert,

thank You for Your review. I updated spec file and srpms, links are below.

Rawhide:
- SRPM:
https://github.com/i386x/golang-github-inconshreveable-go-vhost/raw/master/golang-github-inconshreveable-go-vhost-0-0.1.20160627git06d8411.fc28.src.rpm
- Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=25038195

F27:
- SRPM:
https://github.com/i386x/golang-github-inconshreveable-go-vhost/raw/master/golang-github-inconshreveable-go-vhost-0-0.1.20160627git06d8411.fc27.src.rpm
- Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=25038685

F26:
- SRPM:
https://github.com/i386x/golang-github-inconshreveable-go-vhost/raw/master/golang-github-inconshreveable-go-vhost-0-0.1.20160627git06d8411.fc26.src.rpm
- Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=25038881


Jirka

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org