date:20180222

[Bug 1539161] Review Request: moby-engine - The open-source application container engine

2018-02-22 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1539161



--- Comment #12 from Frantisek Kluknavsky  ---
MUST: A package must own all directories that it creates. If it does not create
a directory that it uses, then it should require a package which does create
that directory.

file /usr/libexec/moby-engine is not owned by any package

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539161] Review Request: moby-engine - The open-source application container engine

2018-02-22 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1539161



--- Comment #11 from Frantisek Kluknavsky  ---
rpmlint *.rpm
moby-engine.x86_64: W: incoherent-version-in-changelog 17.03.2-3.ce
['17.03.2-3.ce.gitf5ec1e2.fc26', '17.03.2-3.ce.gitf5ec1e2']
moby-engine.x86_64: E: statically-linked-binary
/usr/libexec/moby-engine/moby-init
moby-engine.x86_64: W: udev-rule-in-etc /etc/udev/rules.d/80-moby.rules
moby-engine.x86_64: W: non-conffile-in-etc /etc/udev/rules.d/80-moby.rules
moby-engine.x86_64: E: wrong-script-interpreter
/usr/share/bash-completion/completions/moby /usr/bin/env bash
moby-engine.x86_64: E: non-executable-script
/usr/share/bash-completion/completions/moby 644 /usr/bin/env bash
moby-engine.x86_64: W: manual-page-warning /usr/share/man/man1/moby-run.1.gz
1125: warning: macro `You' not defined
moby-engine.x86_64: W: no-manual-page-for-binary docker
moby-engine.x86_64: W: no-manual-page-for-binary moby-engine
moby-engine-debuginfo.x86_64: E: script-without-shebang
/usr/src/debug/moby-f5ec1e2936dcbe7b5001c2b817188b095c700c27/_build/src/github.com/docker/docker/vendor/github.com/armon/go-metrics/metrics.go
moby-engine-debuginfo.x86_64: E: script-without-shebang
/usr/src/debug/moby-f5ec1e2936dcbe7b5001c2b817188b095c700c27/_build/src/github.com/docker/docker/vendor/github.com/armon/go-metrics/sink.go
moby-engine-debuginfo.x86_64: E: script-without-shebang
/usr/src/debug/moby-f5ec1e2936dcbe7b5001c2b817188b095c700c27/_build/src/github.com/docker/docker/vendor/github.com/armon/go-metrics/start.go
moby-engine-debuginfo.x86_64: E: script-without-shebang
/usr/src/debug/moby-f5ec1e2936dcbe7b5001c2b817188b095c700c27/_build/src/github.com/docker/docker/vendor/github.com/armon/go-metrics/statsite.go
moby-engine-debuginfo.x86_64: E: script-without-shebang
/usr/src/debug/moby-f5ec1e2936dcbe7b5001c2b817188b095c700c27/_build/src/github.com/docker/docker/vendor/github.com/google/certificate-transparency/go/asn1/asn1.go
moby-engine-debuginfo.x86_64: E: script-without-shebang
/usr/src/debug/moby-f5ec1e2936dcbe7b5001c2b817188b095c700c27/_build/src/github.com/docker/docker/vendor/github.com/google/certificate-transparency/go/asn1/common.go
moby-engine-debuginfo.x86_64: E: script-without-shebang
/usr/src/debug/moby-f5ec1e2936dcbe7b5001c2b817188b095c700c27/_build/src/github.com/docker/docker/vendor/github.com/google/certificate-transparency/go/asn1/marshal.go
moby-engine-debuginfo.x86_64: E: script-without-shebang
/usr/src/debug/moby-f5ec1e2936dcbe7b5001c2b817188b095c700c27/_build/src/github.com/docker/docker/vendor/github.com/google/certificate-transparency/go/x509/cert_pool.go
moby-engine-debuginfo.x86_64: E: script-without-shebang
/usr/src/debug/moby-f5ec1e2936dcbe7b5001c2b817188b095c700c27/_build/src/github.com/docker/docker/vendor/github.com/google/certificate-transparency/go/x509/pem_decrypt.go
moby-engine-debuginfo.x86_64: E: script-without-shebang
/usr/src/debug/moby-f5ec1e2936dcbe7b5001c2b817188b095c700c27/_build/src/github.com/docker/docker/vendor/github.com/google/certificate-transparency/go/x509/pkcs1.go
moby-engine-debuginfo.x86_64: E: script-without-shebang
/usr/src/debug/moby-f5ec1e2936dcbe7b5001c2b817188b095c700c27/_build/src/github.com/docker/docker/vendor/github.com/google/certificate-transparency/go/x509/pkix/pkix.go
moby-engine-debuginfo.x86_64: E: script-without-shebang
/usr/src/debug/moby-f5ec1e2936dcbe7b5001c2b817188b095c700c27/_build/src/github.com/docker/docker/vendor/github.com/google/certificate-transparency/go/x509/root.go
moby-engine-debuginfo.x86_64: E: script-without-shebang
/usr/src/debug/moby-f5ec1e2936dcbe7b5001c2b817188b095c700c27/_build/src/github.com/docker/docker/vendor/github.com/google/certificate-transparency/go/x509/root_unix.go
moby-engine-debuginfo.x86_64: E: script-without-shebang
/usr/src/debug/moby-f5ec1e2936dcbe7b5001c2b817188b095c700c27/_build/src/github.com/docker/docker/vendor/github.com/google/certificate-transparency/go/x509/verify.go
moby-engine-debuginfo.x86_64: E: script-without-shebang
/usr/src/debug/moby-f5ec1e2936dcbe7b5001c2b817188b095c700c27/_build/src/github.com/docker/docker/vendor/github.com/google/certificate-transparency/go/x509/x509.go
moby-engine-debuginfo.x86_64: E: script-without-shebang
/usr/src/debug/moby-f5ec1e2936dcbe7b5001c2b817188b095c700c27/_build/src/github.com/docker/docker/vendor/github.com/pborman/uuid/dce.go
moby-engine-debuginfo.x86_64: E: script-without-shebang
/usr/src/debug/moby-f5ec1e2936dcbe7b5001c2b817188b095c700c27/_build/src/github.com/docker/docker/vendor/github.com/pborman/uuid/node.go
moby-engine-debuginfo.x86_64: E: script-without-shebang
/usr/src/debug/moby-f5ec1e2936dcbe7b5001c2b817188b095c700c27/_build/src/github.com/docker/docker/vendor/github.com/pborman/uuid/time.go
moby-engine-fish-completion.x86_64: W: summary-not-capitalized C fish
completion files for Docker
moby-engine-fish-completion.x86_64: W: no-documentation
moby-engine-nano.x86_64: W: summary-not-capitalized C nano syntax highlighting
files for

[Bug 1548142] Review request: firefox-pkcs11-loader - Helper script for Firefox that sets up the browser for authentication with Estonian ID-card

2018-02-22 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1548142



--- Comment #4 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/firefox-pkcs11-loader

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1547577] Review Request: nodejs-charenc - Character encoding utilities

2018-02-22 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1547577



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/nodejs-charenc

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1490057] Review Request: cloudcompare - 3D point cloud and mesh processing software

2018-02-22 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1490057



--- Comment #5 from Miro Hrončok  ---
(In reply to Robert-André Mauchin from comment #4)
>  - These shouldn't have executable bits, it should be 0644:
> 
> cloudcompare-debugsource.x86_64: W: spurious-executable-perm
> /usr/src/debug/cloudcompare-2.9.1-1.fc27.x86_64/plugins/qHoughNormals/
> nanoflann/include/nanoflann.hpp
> cloudcompare-debugsource.x86_64: W: spurious-executable-perm
> /usr/src/debug/cloudcompare-2.9.1-1.fc27.x86_64/plugins/qHoughNormals/
> normals_Hough/Normals.h

https://github.com/hroncok/cloudcompare/commit/d4e6e87c206637ccdecfbd689a47eda04f76f2cf

> cloudcompare.src: W: strange-permission ccviewer.desktop 755
> cloudcompare.src: W: strange-permission cloudcompare.desktop 755

https://github.com/hroncok/cloudcompare/commit/f00fca40c4062ded55f62727d4568654babc342b


Spec URL: https://github.com/hroncok/cloudcompare/raw/master/cloudcompare.spec
SRPM URL:
https://churchyard.fedorapeople.org/SRPMS/cloudcompare-2.9.1-1.fc27.src.rpm

Again, the SRPM gets uploaded slowly, ETA ~15 minutes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1548173] Review Request: yubikey-piv-manager - Tool for configuring your PIV-enabled YubiKey

2018-02-22 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1548173

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review?



--- Comment #1 from Robert-André Mauchin  ---
 - License:BSD

   COPYING is GPLv3+ and licensecheck has both GPLv3+ and BSD:

BSD (2 clause)
--
yubikey-piv-manager-1.4.2/pivman/yubicommon/__init__.py
yubikey-piv-manager-1.4.2/pivman/yubicommon/ctypes/__init__.py
yubikey-piv-manager-1.4.2/pivman/yubicommon/qt/__init__.py
yubikey-piv-manager-1.4.2/pivman/yubicommon/setup/__init__.py
yubikey-piv-manager-1.4.2/pivman/yubicommon/setup/exe.py
yubikey-piv-manager-1.4.2/pivman/yubicommon/setup/qt.py

BSD (3 clause)
--
yubikey-piv-manager-1.4.2/pivman/yubicommon/ctypes/libloader.py

GPL (v3 or later)
-
yubikey-piv-manager-1.4.2/man/pivman.1
yubikey-piv-manager-1.4.2/pivman/__init__.py
yubikey-piv-manager-1.4.2/pivman/__main__.py
yubikey-piv-manager-1.4.2/pivman/controller.py
yubikey-piv-manager-1.4.2/pivman/libykpiv.py
yubikey-piv-manager-1.4.2/pivman/messages.py
yubikey-piv-manager-1.4.2/pivman/piv.py
yubikey-piv-manager-1.4.2/pivman/piv_cmd.py
yubikey-piv-manager-1.4.2/pivman/storage.py
yubikey-piv-manager-1.4.2/pivman/utils.py
yubikey-piv-manager-1.4.2/pivman/view/__init__.py
yubikey-piv-manager-1.4.2/pivman/view/generate_dialog.py
yubikey-piv-manager-1.4.2/pivman/view/init_dialog.py
yubikey-piv-manager-1.4.2/pivman/view/main.py
yubikey-piv-manager-1.4.2/pivman/view/manage.py
yubikey-piv-manager-1.4.2/pivman/view/set_key_dialog.py
yubikey-piv-manager-1.4.2/pivman/view/set_pin_dialog.py
yubikey-piv-manager-1.4.2/pivman/view/settings_dialog.py
yubikey-piv-manager-1.4.2/pivman/view/usage_policy_dialog.py
yubikey-piv-manager-1.4.2/pivman/view/utils.py
yubikey-piv-manager-1.4.2/pivman/watcher.py
yubikey-piv-manager-1.4.2/pivman/yubicommon/qt/classes.py
yubikey-piv-manager-1.4.2/pivman/yubicommon/qt/osx.py
yubikey-piv-manager-1.4.2/pivman/yubicommon/qt/settings.py
yubikey-piv-manager-1.4.2/pivman/yubicommon/qt/utils.py
yubikey-piv-manager-1.4.2/pivman/yubicommon/qt/worker.py
yubikey-piv-manager-1.4.2/setup.py

   Fix the license field and add a comment explaining the license breakdown.


 - Install the provided man file:

mkdir -p %{buildroot}%{_mandir}/man1
install -p -m 0644 man/pivman.1 %{buildroot}%{_mandir}/man1/pivman.1

   And:

%files
%{_bindir}/pivman
%{_mandir}/man1/pivman.1.*

 - Install the documentation:

%files -n python%{python3_pkgversion}-%{name}
%{python3_sitelib}/*
%license COPYING
%doc NEWS doc/



Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD (3 clause)", "BSD (2 clause)", "GPL (v3 or later)",
 "Unknown or generated". 31 files have unknown license. Detailed output
 of licensecheck in /home/bob/packaging/review/yubikey-piv-manager
 /review-yubikey-piv-manager/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run

[Bug 1548173] New: Review Request: yubikey-piv-manager - Tool for configuring your PIV-enabled YubiKey

2018-02-22 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1548173

Bug ID: 1548173
   Summary: Review Request: yubikey-piv-manager - Tool for
configuring your PIV-enabled YubiKey
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: or...@nwra.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://www.cora.nwra.com/~orion/fedora/yubikey-piv-manager.spec
SRPM URL:
https://www.cora.nwra.com/~orion/fedora/yubikey-piv-manager-1.4.2-1.fc29.src.rpm
Description:
Tool for configuring your PIV-enabled YubiKey.

Fedora Account System Username: orion

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1548142] Review request: firefox-pkcs11-loader - Helper script for Firefox that sets up the browser for authentication with Estonian ID-card

2018-02-22 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1548142

Lubomir Rintel  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #3 from Lubomir Rintel  ---
Cool.

APPROVED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1490057] Review Request: cloudcompare - 3D point cloud and mesh processing software

2018-02-22 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1490057

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review?



--- Comment #4 from Robert-André Mauchin  ---
 - These shouldn't have executable bits, it should be 0644:

cloudcompare-debugsource.x86_64: W: spurious-executable-perm
/usr/src/debug/cloudcompare-2.9.1-1.fc27.x86_64/plugins/qHoughNormals/nanoflann/include/nanoflann.hpp
cloudcompare-debugsource.x86_64: W: spurious-executable-perm
/usr/src/debug/cloudcompare-2.9.1-1.fc27.x86_64/plugins/qHoughNormals/normals_Hough/Normals.h

cloudcompare.src: W: strange-permission ccviewer.desktop 755
cloudcompare.src: W: strange-permission cloudcompare.desktop 755

   Fix it in prep for the first two and notify upstream. For the .desktop file
make sure the file perm are 0644 when you build your SRPM.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "LGPL (v2 or later)", "GPL (v2 or later)", "GPL (v3 or later)",
 "Unknown or generated", "MIT/X11 (BSD like)", "Apache (v1.1)",
 "zlib/libpng", "LGPL", "GPL (v2) LGPL (v2 or later)", "BSD
 (unspecified)", "BSD (2 clause)", "LGPL (v2.1 or later)", "GPL (v2)",
 "LGPL (v2.1)". 865 files have unknown license. Detailed output of
 licensecheck in /home/bob/packaging/review/cloudcompare/review-
 cloudcompare/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 163840 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
 desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make

[Bug 1548142] Review request: firefox-pkcs11-loader - Helper script for Firefox that sets up the browser for authentication with Estonian ID-card

2018-02-22 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1548142



--- Comment #2 from Germano Massullo  ---
(In reply to Lubomir Rintel from comment #1)
> 0.) Please remove a useless comment:
> 
> > # procedure for package renaming is 
> > https://fedoraproject.org/wiki/Package_Renaming_Process

Done

> 1.) Please drop the useless macro:
> 
> > %global source_name firefox-pkcs11-loader
> 
> Use %{name} in place of %{source_name}

Done

> 2.) Don't mix tabs and spaces:
>
> > # old name was firefox-esteidpkcs11loader
> > Obsoletes:  firefox-esteidpkcs11loader
> ^^
> Please replace this with spaces.

Done

> 3.) Please use macros consistentlt:
> 
> > %dir %{_prefix}/lib/mozilla/pkcs11-modules/
> > %_prefix/lib/mozilla/pkcs11-modules/onepinopenscpkcs11.json
>   
>   %{_prefix} here

Done

> 4.) Missing dependency on firefox-filesystem
> 
> You install files into %{_prefix}/lib/mozilla and
> %{_datadir}/mozilla/extensions that are owned by it

Done

> 5.) Summary is too long
> 
> > Summary:Helper script for Firefox that sets up the browser for 
> > authentication with Estonian ID-card


There is no requirement for 80 char length on summary, there is only on
description
https://fedoraproject.org/wiki/Packaging:Guidelines#Summary_and_description


> And doesn't seem to make sense -- what package ships is not a script.
> A better choice would be something like:
> "Estonian ID-card authentication support for Firefox"

it is the same description from upstream
https://github.com/open-eid/firefox-pkcs11-loader
and it is a package that installs a JSON and an extension that configures
Firefox to correctly handle PKCS11. This configuration is required to use
correctly the card, but you could also configure manually Firefox instead of
installing this package

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1315809] Review Request: python-pylxd - python library for lxd

2018-02-22 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1315809

James Paul Turner  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Blocks||201449 (FE-DEADREVIEW)
 Resolution|--- |NOTABUG
Last Closed||2018-02-22 16:14:41




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=201449
[Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter
response should be blocking this bug.
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1548142] Review request: firefox-pkcs11-loader - Helper script for Firefox that sets up the browser for authentication with Estonian ID-card

2018-02-22 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1548142

Lubomir Rintel  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|lkund...@v3.sk
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1548142] Review request: firefox-pkcs11-loader - Helper script for Firefox that sets up the browser for authentication with Estonian ID-card

2018-02-22 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1548142

Lubomir Rintel  changed:

   What|Removed |Added

 CC||lkund...@v3.sk



--- Comment #1 from Lubomir Rintel  ---
0.) Please remove a useless comment:

> # procedure for package renaming is 
> https://fedoraproject.org/wiki/Package_Renaming_Process

1.) Please drop the useless macro:

> %global source_name firefox-pkcs11-loader

Use %{name} in place of %{source_name}

2.) Don't mix tabs and spaces:

> # old name was firefox-esteidpkcs11loader
> Obsoletes:  firefox-esteidpkcs11loader
^^
Please replace this with spaces.

3.) Please use macros consistentlt:

> %dir %{_prefix}/lib/mozilla/pkcs11-modules/
> %_prefix/lib/mozilla/pkcs11-modules/onepinopenscpkcs11.json
  
  %{_prefix} here

4.) Missing dependency on firefox-filesystem

You install files into %{_prefix}/lib/mozilla and
%{_datadir}/mozilla/extensions that are owned by it

5.) Summary is too long

> Summary:Helper script for Firefox that sets up the browser for 
> authentication with Estonian ID-card

And doesn't seem to make sense -- what package ships is not a script.
A better choice would be something like:
"Estonian ID-card authentication support for Firefox"

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1548142] New: Review request: firefox-pkcs11-loader - Helper script for Firefox that sets up the browser for authentication with Estonian ID-card

2018-02-22 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1548142

Bug ID: 1548142
   Summary: Review request: firefox-pkcs11-loader - Helper script
for Firefox that sets up the browser for
authentication with Estonian ID-card
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: germano.massu...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Helper script for Firefox that sets up the browser for authentication with
Estonian ID-card

https://germano.fedorapeople.org/package_reviews/firefox-pkcs11-loader/firefox-pkcs11-loader.spec

https://germano.fedorapeople.org/package_reviews/firefox-pkcs11-loader/firefox-pkcs11-loader-3.13.0-1.fc27.src.rpm

package will unretire firefox-esteidpkcs11loader and change its name to
firefox-pkcs11-loader in order to be equal to upstream as much as possible

Procedure for package renaming is
https://fedoraproject.org/wiki/Package_Renaming_Process

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1507103] Review Request: kronosnet - Multipoint-to-Multipoint network abstraction layer for High Availability applications

2018-02-22 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1507103



--- Comment #45 from digimer  ---
Sorry for the delay.

Changes made (tarball from release, license and systed_requires). 

New .spec and srpm:
https://www.alteeve.com/an-repo/files/packages/kronosnet.spec.1.0-9
https://www.alteeve.com/an-repo/files/packages/kronosnet-1.0-9.fc27.src.rpm

f26:
https://koji.fedoraproject.org/koji/taskinfo?taskID=25239823

f27:
https://koji.fedoraproject.org/koji/taskinfo?taskID=25239830

rawhide:
https://koji.fedoraproject.org/koji/taskinfo?taskID=25239815

epel7:
https://koji.fedoraproject.org/koji/taskinfo?taskID=25239839


Diff from 1.0-8:

--- kronosnet.spec.1.0-82018-02-16 00:04:45.452029189 -0500
+++ kronosnet.spec.1.0-92018-02-22 14:34:54.588904329 -0500
@@ -70,15 +70,14 @@
 Name: kronosnet
 Summary: Multipoint-to-Multipoint VPN daemon
 Version: 1.0
-Release: 8%{?dist}
-License: GPLv2+
+Release: 9%{?dist}
+License: GPLv2+ + LGPLv2+
 URL: http://www.kronosnet.org
 Source0: http://www.kronosnet.org/releases/kronosnet-%{version}.tar.gz
 Patch0: gcc8-fixes.patch

 # Build dependencies
 BuildRequires: gcc
-%{?systemd_requires}
 BuildRequires: systemd
 # required to build man pages
 BuildRequires: libxml2-devel doxygen
@@ -204,6 +203,7 @@
 License: GPLv2+
 Requires(post): shadow-utils
 Requires: pam, /etc/pam.d/passwd
+%{?systemd_requires}

 %description -n kronosnetd
 The kronosnet daemon is a bridge between kronosnet switching engine


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1540347] Review Request: hashcat - password recovery utility

2018-02-22 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1540347



--- Comment #25 from Jaroslav Škarvada  ---
Proposed the lzma-sdk unbundle patch upstream:
https://github.com/hashcat/hashcat/issues/1528

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1540347] Review Request: hashcat - password recovery utility

2018-02-22 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1540347



--- Comment #24 from Jaroslav Škarvada  ---
One more thing I noticed during build:
*** WARNING: ./usr/share/doc/hashcat/examples/example500.sh is executable but
has empty or no shebang, removing executable bit
*** WARNING: ./usr/share/doc/hashcat/examples/example400.sh is executable but
has empty or no shebang, removing executable bit
*** WARNING: ./usr/share/doc/hashcat/examples/example0.sh is executable but has
empty or no shebang, removing executable bit

I think it should be enough to just remove the executable mode from the example
files (by chmod).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1548077] Review Request: libyami - Yet Another Media Infrastructure

2018-02-22 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1548077



--- Comment #1 from Nicolas Chauvet (kwizart)  ---
Scratch build failed on f28+
Seems like this will need more work...
Reported here: https://github.com/intel/libyami/issues/830

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1490057] Review Request: cloudcompare - 3D point cloud and mesh processing software

2018-02-22 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1490057



--- Comment #3 from Miro Hrončok  ---
Let's get back to this :D

Spec URL: https://github.com/hroncok/cloudcompare/raw/master/cloudcompare.spec
SRPM URL:
https://churchyard.fedorapeople.org/SRPMS/cloudcompare-2.9.1-1.fc27.src.rpm

(ETA 15 minutes to upload the SRPM, it's somehow slow.)

Changes in https://github.com/hroncok/cloudcompare/commits/master

F27 scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=25238489

I have some (most likely unrelated) deps issues in f28+ now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1506429] Review Request: gnome-shell-extension-windowoverlay-icons - Show app icons on top of the windows thumbnails in Activities Overview

2018-02-22 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1506429



--- Comment #20 from Fedora Update System  ---
gnome-shell-extension-windowoverlay-icons-27-2.el7 has been pushed to the
Fedora EPEL 7 stable repository. If problems still persist, please make note of
it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1548077] New: Review Request: libyami - Yet Another Media Infrastructure

2018-02-22 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1548077

Bug ID: 1548077
   Summary: Review Request: libyami - Yet Another Media
Infrastructure
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: kwiz...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: http://dl.kwizart.net/review/libyami.spec
SRPM URL: http://dl.kwizart.net/review/libyami-1.3.0-1.fc26.src.rpm
Description: Yet Another Media Infrastructure
Fedora Account System Username: kwizart

Koji scratch build for f28:
https://koji.fedoraproject.org/koji/taskinfo?taskID=25238108

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1533719] Review Request: twolame - Optimized MPEG Audio Layer 2 encoding library based on tooLAME

2018-02-22 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1533719

Sergio Monteiro Basto  changed:

   What|Removed |Added

   See Also||https://bugzilla.redhat.com
   ||/show_bug.cgi?id=1186900



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1186900] Review Request: kwave - Sound Editor for KDE

2018-02-22 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1186900

Sergio Monteiro Basto  changed:

   What|Removed |Added

   See Also||https://bugzilla.redhat.com
   ||/show_bug.cgi?id=1533719



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1186900] Review Request: kwave - Sound Editor for KDE

2018-02-22 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1186900

Sergio Monteiro Basto  changed:

   What|Removed |Added

 Status|CLOSED  |NEW
 CC||ser...@serjux.com
 Resolution|NOTABUG |---
   Keywords||Reopened



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1547617] Review Request: python-certbot-dns-cloudflare - Cloudflare DNS Authenticator plugin for Certbot

2018-02-22 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1547617



--- Comment #8 from Fedora Update System  ---
python-certbot-dns-cloudflare-0.21.1-1.fc27 has been pushed to the Fedora 27
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-63ca93179f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1547601] Review Request: python-certbot-dns-luadns - LuaDNS Authenticator plugin for Certbot

2018-02-22 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1547601



--- Comment #8 from Fedora Update System  ---
python-certbot-dns-luadns-0.21.1-1.fc27 has been pushed to the Fedora 27
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-2518466b8e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1546801] Review Request: argparse-manpage - Build manual page from Python ArgumentParser object

2018-02-22 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1546801



--- Comment #8 from Fedora Update System  ---
argparse-manpage-1.0.0-1.fc27 has been pushed to the Fedora 27 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-c990381e5f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1547611] Review Request: python-certbot-dns-cloudxns - CloudXNS DNS Authenticator plugin for Certbot

2018-02-22 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1547611



--- Comment #8 from Fedora Update System  ---
python-certbot-dns-cloudxns-0.21.1-1.fc27 has been pushed to the Fedora 27
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-2fb3d9fbd5

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539161] Review Request: moby-engine - The open-source application container engine

2018-02-22 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1539161



--- Comment #10 from Lokesh Mandvekar  ---
SRPM URL:
https://pagure.io/moby-engine/blob/master/f/SRPMS/moby-engine-17.03.2-3.ce.gitf5ec1e2.fc27.src.rpm

docker-* are symlinks to moby-* in this build.

Spec location is the same.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1547601] Review Request: python-certbot-dns-luadns - LuaDNS Authenticator plugin for Certbot

2018-02-22 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1547601



--- Comment #7 from Fedora Update System  ---
python-certbot-dns-luadns-0.21.1-1.el7 has been pushed to the Fedora EPEL 7
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-7c4aa35266

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1546801] Review Request: argparse-manpage - Build manual page from Python ArgumentParser object

2018-02-22 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1546801



--- Comment #7 from Fedora Update System  ---
argparse-manpage-1.0.0-1.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-d274033e1d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1547611] Review Request: python-certbot-dns-cloudxns - CloudXNS DNS Authenticator plugin for Certbot

2018-02-22 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1547611



--- Comment #7 from Fedora Update System  ---
python-certbot-dns-cloudxns-0.21.1-1.el7 has been pushed to the Fedora EPEL 7
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-8485d945fc

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1547617] Review Request: python-certbot-dns-cloudflare - Cloudflare DNS Authenticator plugin for Certbot

2018-02-22 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1547617



--- Comment #7 from Fedora Update System  ---
python-certbot-dns-cloudflare-0.21.1-1.el7 has been pushed to the Fedora EPEL 7
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-e936db8d39

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1546801] Review Request: argparse-manpage - Build manual page from Python ArgumentParser object

2018-02-22 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1546801

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #6 from Fedora Update System  ---
argparse-manpage-1.0.0-1.fc26 has been pushed to the Fedora 26 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-4e008c25c1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1547611] Review Request: python-certbot-dns-cloudxns - CloudXNS DNS Authenticator plugin for Certbot

2018-02-22 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1547611

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #6 from Fedora Update System  ---
python-certbot-dns-cloudxns-0.21.1-1.fc26 has been pushed to the Fedora 26
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-ba61df5bcd

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1547601] Review Request: python-certbot-dns-luadns - LuaDNS Authenticator plugin for Certbot

2018-02-22 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1547601

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #6 from Fedora Update System  ---
python-certbot-dns-luadns-0.21.1-1.fc26 has been pushed to the Fedora 26
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-07bd741164

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1547617] Review Request: python-certbot-dns-cloudflare - Cloudflare DNS Authenticator plugin for Certbot

2018-02-22 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1547617

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #6 from Fedora Update System  ---
python-certbot-dns-cloudflare-0.21.1-1.fc26 has been pushed to the Fedora 26
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-058661a9bf

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539161] Review Request: moby-engine - The open-source application container engine

2018-02-22 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1539161

Lokesh Mandvekar  changed:

   What|Removed |Added

  Comment #7 is|1   |0
private||



--- Comment #9 from Lokesh Mandvekar  ---
(In reply to Daniel Walsh from comment #7)
> We also want to get some of our patches merged into this package.  We should
> be packaging up projectatomic/moby not moby/moby

Sure, that can be done once we have projectatomic/moby ready with the patches.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1526705] Review Request: python-f5-icontrol-rest - F5 BIG-IP iControl REST API client

2018-02-22 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1526705

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #7 from Robert-André Mauchin  ---
Ok, package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539161] Review Request: moby-engine - The open-source application container engine

2018-02-22 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1539161



--- Comment #8 from Lokesh Mandvekar  ---
RE: binary renames, I'll include docker-* as symlinks to the moby-* binaries.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1543578] Review Request: php-deepdiver-zipstreamer - package maintained fork of PHPZipStreamer

2018-02-22 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1543578



--- Comment #10 from Christian Glombek  ---
Thanks Remi! Updated the build:

Spec URL:
https://copr-be.cloud.fedoraproject.org/results/lorbus/php-deepdiver-zipstreamer/fedora-27-x86_64/00719746-php-deepdiver-zipstreamer/php-deepdiver-zipstreamer.spec

SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/lorbus/php-deepdiver-zipstreamer/fedora-27-x86_64/00719746-php-deepdiver-zipstreamer/php-deepdiver-zipstreamer-1.1.0-1.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1526705] Review Request: python-f5-icontrol-rest - F5 BIG-IP iControl REST API client

2018-02-22 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1526705



--- Comment #6 from Xavier Bachelot  ---
Thanks for the comments.
New version, it fixes doc and also fixes building for EL6 and EL7.

Spec URL: https://www.bachelot.org/fedora/SPECS/python-f5-icontrol-rest.spec
SRPM URL:
https://www.bachelot.org/fedora/SRPMS/python-f5-icontrol-rest-1.3.6-2.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1547757] Review Request: python-molecule - Molecule is designed to aid in the development and testing of Ansible roles

2018-02-22 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1547757

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com



--- Comment #1 from Robert-André Mauchin  ---
 - Not needed:

rm -rf $RPM_BUILD_ROOT

 - You need to build the documentation with sphinx-build

%if %{with python3}
BuildRequires:  python3-sphinx
%else
BuildRequires:  python2-sphinx
%endif # with python3

   And:

# generate html docs 
PYTHONPATH=. sphinx-build doc/source html
# remove the sphinx-build leftovers
rm -rf html/.{doctrees,buildinfo}

   One package is missing for it to be successful, python-tree_format:
https://pypi.python.org/pypi/tree-format

   Package it then add it to the dependencies list:

# doc
BuildRequires:  python2-sh
BuildRequires:  python2-anyconfig
BuildRequires:  python2-colorama
BuildRequires:  python2-tree_format

%if %{with python3}
BuildRequires:  python3-devel
BuildRequires:  python3-pbr
BuildRequires:  python3-setuptools

# doc
BuildRequires:  python3-sh
BuildRequires:  python3-anyconfig
BuildRequires:  python3-colorama
BuildRequires:  python3-tree_format

 - I think I already told you that, but you don't need to separate python 2 and
python 3 in separate directories:

%prep
%autosetup -n %{pkgname}-%{version}
sed -i 's/yamllint==1.8.1/yamllint==1.10.0/' requirements.txt

%build
%{setup_flags} %{py2_build}

%if %{with python3}
%{setup_flags} %{py3_build}
%endif # with python3

# generate html docs 
PYTHONPATH=. sphinx-build doc/source html
# remove the sphinx-build leftovers
rm -rf html/.{doctrees,buildinfo}

%install
# Must do the python3 install first because the scripts in /usr/bin are
# overwritten with every setup.py install (and we want the python2 version
# to be the default for now).
%if %{with python3}
%{setup_flags} %{py3_install}
%endif # with python3

%{setup_flags} %{py2_install}

%files -n python2-%{pkgname}
%license LICENSE
%doc html *.rst
%{python2_sitelib}/%{pkgname}
%{python2_sitelib}/%{pkgname}-%{version}-py?.?.egg-info

%if %{with python3}
%files -n python3-%{pkgname}
%license LICENSE
%doc html *.rst
%{python3_sitelib}/%{pkgname}
%{python3_sitelib}/%{pkgname}-%{version}-py?.?.egg-info
%endif # with python3
%{_bindir}/%{pkgname}


 - Why %{_bindir}/%{pkgname} included in the python3 package? This seems
curious to have a python3 package with only the binary. I would do:

%files -n python2-%{pkgname}
%license LICENSE
%doc html *.rst
%{python2_sitelib}/%{pkgname}
%{python2_sitelib}/%{pkgname}-%{version}-py?.?.egg-info
%if %{without python3}
%{_bindir}/%{pkgname}
%endif # without python3

%if %{with python3}
%files -n python3-molecule
%license LICENSE
%doc html *.rst
%{python3_sitelib}/%{pkgname}
%{python3_sitelib}/%{pkgname}-%{version}-py?.?.egg-info
%{_bindir}/%{pkgname}
%endif # with python3

 - You should also run the tests provided when you have managed to gather all
dependencies.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1543578] Review Request: php-deepdiver-zipstreamer - package maintained fork of PHPZipStreamer

2018-02-22 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1543578



--- Comment #9 from Remi Collet  ---
New package is fully compatible with previous, so obsolete/provide make sense

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1543578] Review Request: php-deepdiver-zipstreamer - package maintained fork of PHPZipStreamer

2018-02-22 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1543578

Remi Collet  changed:

   What|Removed |Added

 CC||fed...@famillecollet.com



--- Comment #8 from Remi Collet  ---
Please enable test suite (ignoring integration part, which rely on Docker)

---configuration test/phpunit.xml
+test/lib

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1547764] Review Request: nodejs-git-tails - Get git tail hashes from your repository in reverse chronological order

2018-02-22 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1547764

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #1 from Robert-André Mauchin  ---
 - License ok
 - Latest version packaged
 - Builds in mock
 - No rpmlint errors

Package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1547733] Review Request: nodejs-conventional-recommended-bump - Get a recommended version bump based on conventional commits

2018-02-22 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1547733

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com



--- Comment #1 from Robert-André Mauchin  ---
 - Some dependencies are missing:

DEBUG util.py:482:  BUILDSTDERR: No matching package to install:
'npm(git-raw-commits)'
DEBUG util.py:482:  BUILDSTDERR: No matching package to install:
'npm(git-semver-tags)'
DEBUG util.py:482:  BUILDSTDERR: Not all dependencies satisfied
DEBUG util.py:482:  BUILDSTDERR: Error: Some packages could not be found.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1547696] Review Request: nodejs-conventional-changelog-preset-loader - Configuration preset loader for conventional-changelog

2018-02-22 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1547696

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #1 from Robert-André Mauchin  ---
 - Tests error:

+ /usr/bin/mocha -R spec
BUILDSTDERR: module.js:540
BUILDSTDERR: throw err;
BUILDSTDERR: ^
BUILDSTDERR: Error: Cannot find module 'chai'

   Add:

BuildRequires:npm(chai)




 - License ok
 - Latest version packaged
 - Builds in mock
 - No rpmlint errors

Package approved. Just don't forget to fix the error above before import.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

48 matches

Mail list logo