[Bug 1284132] Review Request: nrdp - Nagios Remote Data Processor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1284132



--- Comment #11 from Robert-André Mauchin  ---
Also:


6. The Software may only be used in conjunction with products, projects, and
other software distributed by the Company. Any standalone use of the Software,
or use of the Software in conjunction with products, projects, or other
software not authored or distributed by the Company - including third-party
software that competes with the offerings of Company - is strictly prohibited
and is a direct violation of the terms of the license.


Definitively doesn't sound like free software to me.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1284132] Review Request: nrdp - Nagios Remote Data Processor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1284132



--- Comment #10 from Robert-André Mauchin  ---
 - Nagios Open Software License Version 1.3:

Nagios Enterprises, LLC (the "Company") hereby grants, free of charge, to any
person, company, or legal entity (each a "User") obtaining a copy of this
software and associated documentation files (the "Software"), to deal in the
Software without restriction, including without limitation the rights to use,
copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the
Software (each a "Use"), and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:


3. The Software may not be Forked. "Forking" and "to Fork" means to create or
distribute a product or a derivative work of the object or source code of the
Software under a new or different brand. 


Both statements are contradictory and is really free software if it prevents
forking?

Also, NOSL is the shorthand for Netizen Open Source License, not Nagios Open
Software License.


  - You should own /etc/nrdp

[!]: Package must own all directories that it creates.
 Note: Directories without known owners: /etc/nrdp





Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[?]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD (3 clause)", "Unknown or generated". 19 files have unknown
 license. Detailed output of licensecheck in
 /home/bob/packaging/review/nrdp/review-nrdp/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
 must be documented in the spec.
[x]: Package requires other packages for directories it uses.
 Note: No known owner of /etc/nrdp
[!]: Package must own all directories that it creates.
 Note: Directories without known owners: /etc/nrdp
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file 

[Bug 1547696] Review Request: nodejs-conventional-changelog-preset-loader - Configuration preset loader for conventional-changelog

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1547696
Bug 1547696 depends on bug 1547684, which changed state.

Bug 1547684 Summary: Review Request: nodejs-sinon-chai - Extends Chai with 
assertions for the Sinon.JS mocking framework
https://bugzilla.redhat.com/show_bug.cgi?id=1547684

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1547684] Review Request: nodejs-sinon-chai - Extends Chai with assertions for the Sinon.JS mocking framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1547684

Jared Smith  changed:

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-02-23 18:01:59



--- Comment #4 from Jared Smith  ---
Built in rawhide

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1284132] Review Request: nrdp - Nagios Remote Data Processor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1284132

Athmane Madjoudj  changed:

   What|Removed |Added

  Flags|needinfo?(athma...@gmail.co |
   |m)  |



--- Comment #9 from Athmane Madjoudj  ---
Thanks Xavier for the updates, I'm still interested in this pkg, unfortunately
it still stuck in review queue.

Updates:

SPEC: https://athmane.fedorapeople.org/pkgs/nrdp.spec
SRPM: https://athmane.fedorapeople.org/pkgs/nrdp-1.5.1-3.fc27.src.rpm 
Koji scratch build: 
https://koji.fedoraproject.org/koji/taskinfo?taskID=25268468

Rpmlint:

nrdp.src: W: spelling-error Summary(en_US) Nagios -> Adagios
nrdp.src: W: spelling-error %description -l en_US Nagios -> Adagios
nrdp.noarch: W: spelling-error Summary(en_US) Nagios -> Adagios
nrdp.noarch: W: spelling-error %description -l en_US Nagios -> Adagios
nrdp-client-php.noarch: W: no-documentation
nrdp-client-php.noarch: W: no-manual-page-for-binary send_nrdp.php
nrdp-client-python.noarch: W: no-documentation
nrdp-client-python.noarch: W: no-manual-page-for-binary send_nrdp.py
nrdp-client-shell.noarch: W: no-documentation
nrdp-client-shell.noarch: W: no-manual-page-for-binary send_nrdp.sh
5 packages and 1 specfiles checked; 0 errors, 10 warnings.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1546835] Review Request: python-urllib-gssapi - A urllib/ urllib2 backend for GSSAPI/SPNEGO

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1546835



--- Comment #4 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-urllib-gssapi

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 885038] Review Request: pentobi - Program that plays the board game Blokus

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=885038



--- Comment #23 from Andrew Toskin  ---
It's been almost a year since the last comment on this thread, and before that
there was a three year gap. Is it safe to call this an abandoned package
review?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1507103] Review Request: kronosnet - Multipoint-to-Multipoint network abstraction layer for High Availability applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1507103



--- Comment #48 from digimer  ---
Updated to add the missing change log.

New .spec and srpm:
https://www.alteeve.com/an-repo/files/packages/kronosnet.spec.1.0-10
https://www.alteeve.com/an-repo/files/packages/kronosnet-1.0-10.fc27.src.rpm

f26:
https://koji.fedoraproject.org/koji/taskinfo?taskID=25264181

f27:
https://koji.fedoraproject.org/koji/taskinfo?taskID=25264214

rawhide:
https://koji.fedoraproject.org/koji/taskinfo?taskID=25264225

epel7:
https://koji.fedoraproject.org/koji/taskinfo?taskID=25264234


Diff from 1.0-9:

--- kronosnet.spec.1.0-92018-02-22 14:34:54.588904329 -0500
+++ kronosnet.spec.1.0-102018-02-23 14:47:17.586627823 -0500
@@ -70,7 +70,7 @@
 Name: kronosnet
 Summary: Multipoint-to-Multipoint VPN daemon
 Version: 1.0
-Release: 9%{?dist}
+Release: 10%{?dist}
 License: GPLv2+ + LGPLv2+
 URL: http://www.kronosnet.org
 Source0: http://www.kronosnet.org/releases/kronosnet-%{version}.tar.gz
@@ -460,6 +460,14 @@
 %endif

 %changelog
+* Fri Feb 23 2018 Madison Kelly  - 1.0-10
+- Added missing change log for 1.0-9.
+
+* Thu Feb 22 2018 Madison Kelly  - 1.0-9
+- Changed the source tarball to be one from the upstream source.
+- Updated the main license.
+- Moved down %{?systemd_requires}.
+
 * Fri Feb 16 2018 Madison Kelly  - 1.0-8
 - Reverted to 'BuildRequires: bzip2-devel' to fix EPEL7 builds.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1547500] Review Request: python-jupyterlab - The JupyterLab notebook server extension

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1547500

Lumír Balhar  changed:

   What|Removed |Added

 CC||lbal...@redhat.com



--- Comment #1 from Lumír Balhar  ---
Crossed fingers. Let me know if you need any help. I am testing jupyter lab and
it is a great piece of software.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1546835] Review Request: python-urllib-gssapi - A urllib/ urllib2 backend for GSSAPI/SPNEGO

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1546835

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+
   |needinfo?(zebo...@gmail.com |
   |)   |



--- Comment #3 from Robert-André Mauchin  ---
All ok, package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1546835] Review Request: python-urllib-gssapi - A urllib/ urllib2 backend for GSSAPI/SPNEGO

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1546835

Robbie Harwood  changed:

   What|Removed |Added

  Flags||needinfo?(zebo...@gmail.com
   ||)



--- Comment #2 from Robbie Harwood  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/rharwood/python-urllib-gssapi/build/720274/
Spec URL:
https://copr-be.cloud.fedoraproject.org/results/rharwood/python-urllib-gssapi/fedora-rawhide-x86_64/00720274-python-urllib-gssapi/python-urllib-gssapi.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/rharwood/python-urllib-gssapi/fedora-rawhide-x86_64/00720274-python-urllib-gssapi/python-urllib-gssapi-1.0.1-1.fc28.src.rpm

Thanks for the review!  I made some changes upstream for this rather than doing
it all in the spec file, so this is 1.0.1 now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1189171] Review Request: python-antlr - Python runtime support for ANTLR-generated parsers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1189171

Germano Massullo  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+
   |needinfo?(germano.massullo@ |
   |gmail.com)  |



--- Comment #20 from Germano Massullo  ---
PACKAGE APPROVED



This is a review *template*. Besides handling the [ ]-marked tests you are
also supposed to fix the template before pasting into bugzilla:
- Add issues you find to the list of issues on top. If there isn't such
  a list, create one.
- Add your own remarks to the template checks.
- Add new lines marked [!] or [?] when you discover new things not
  listed by fedora-review.
- Change or remove any text in the template which is plain wrong. In this
  case you could also file a bug against fedora-review
- Remove the "[ ] Manual check required", you will not have any such lines
  in what you paste.
- Remove attachments which you deem not really useful (the rpmlint
  ones are mandatory, though)
- Remove this text



Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file LICENSE.txt is not marked as %license
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated", "NTP", "BSD (3 clause)", "BSD
 (unspecified)", "*No copyright* BSD (unspecified)", "GPL (v2 or later)
 (with incorrect FSF address)". 1155 files have unknown license.
 Detailed output of licensecheck in /home/caterpillar/canc/python-
 antlr/licensecheck.txt
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/lib/python2.6,
 /usr/lib/python2.6/site-packages
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, 

[Bug 1507103] Review Request: kronosnet - Multipoint-to-Multipoint network abstraction layer for High Availability applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1507103



--- Comment #47 from digimer  ---
That's the second time I missed that... >_<.

I'll roll a final RPM today/tonight with the change log updated.

Madi

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1547577] Review Request: nodejs-charenc - Character encoding utilities

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1547577

Jared Smith  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-02-23 09:36:43



--- Comment #3 from Jared Smith  ---
Packaged in Rawhide, closing this issue

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1547764] Review Request: nodejs-git-tails - Get git tail hashes from your repository in reverse chronological order

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1547764



--- Comment #3 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/nodejs-git-tails

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1284132] Review Request: nrdp - Nagios Remote Data Processor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1284132

Xavier Bachelot  changed:

   What|Removed |Added

 CC||athma...@gmail.com
  Flags||needinfo?(athma...@gmail.co
   ||m)



--- Comment #8 from Xavier Bachelot  ---
Yet another update, I'll wait for an answer before working more on this.

Spec URL: https://www.bachelot.org/fedora/SPECS/nrdp.spec
SRPM URL: https://www.bachelot.org/fedora/SRPMS/nrdp-1.5.1-2.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1547696] Review Request: nodejs-conventional-changelog-preset-loader - Configuration preset loader for conventional-changelog

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1547696



--- Comment #3 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/nodejs-conventional-changelog-preset-loader

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1547684] Review Request: nodejs-sinon-chai - Extends Chai with assertions for the Sinon.JS mocking framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1547684



--- Comment #3 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/nodejs-sinon-chai

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1547579] Review Request: nodejs-crypt - Utilities for encryption and hashing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1547579



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/nodejs-crypt

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1547764] Review Request: nodejs-git-tails - Get git tail hashes from your repository in reverse chronological order

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1547764

Jared Smith  changed:

   What|Removed |Added

 Status|POST|MODIFIED



--- Comment #2 from Jared Smith  ---
Repo requested at https://pagure.io/releng/fedora-scm-requests/issue/4712.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1547696] Review Request: nodejs-conventional-changelog-preset-loader - Configuration preset loader for conventional-changelog

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1547696

Jared Smith  changed:

   What|Removed |Added

 Status|POST|MODIFIED



--- Comment #2 from Jared Smith  ---
Repo requested at https://pagure.io/releng/fedora-scm-requests/issue/4711.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1547684] Review Request: nodejs-sinon-chai - Extends Chai with assertions for the Sinon.JS mocking framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1547684

Jared Smith  changed:

   What|Removed |Added

 Status|POST|MODIFIED



--- Comment #2 from Jared Smith  ---
Repo requested at https://pagure.io/releng/fedora-scm-requests/issue/4710.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1490057] Review Request: cloudcompare - 3D point cloud and mesh processing software

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1490057



--- Comment #8 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/cloudcompare

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539314] Review Request: ghc-basement - Foundation scrap box of array & string

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539314

Jens Petersen  changed:

   What|Removed |Added

 Status|POST|MODIFIED
   Fixed In Version||ghc-basement-0.0.4-3.fc29



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534116] Review Request: python-rasterio - Fast and direct raster I/ O for use with Numpy and SciPy

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534116



--- Comment #6 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-rasterio

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1119197] Review Request: gnushogi - Shogi (Japanese Chess) AI engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1119197



--- Comment #26 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/gnushogi

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539291] Review Request: ghc-echo - Cross-platform, cross-console echoing of terminal input

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539291

Jens Petersen  changed:

   What|Removed |Added

 Status|POST|MODIFIED
   Fixed In Version||ghc-echo-0.1.3-3.fc29



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1548405] Review Request: python-gsd - Read and write hoomd schema gsd files with an easy to use syntax

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1548405

Dominik 'Rathann' Mierzejewski  changed:

   What|Removed |Added

 Blocks||1538855




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1538855
[Bug 1538855] python-MDAnalysis-0.17.0 is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1284132] Review Request: nrdp - Nagios Remote Data Processor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1284132



--- Comment #7 from Xavier Bachelot  ---
Here's a quick refresh of the spec to latest version. There is still some work
to do and it's not been tested. Just adding it here for reference, feel free to
take it if you wish to pursue the review. If you don't, I'll finish up the
refresh and open a new review.

Spec URL: https://www.bachelot.org/fedora/SPECS/nrdp.spec
SRPM URL: https://www.bachelot.org/fedora/SRPMS/nrdp-1.5.1-1.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1189171] Review Request: python-antlr - Python runtime support for ANTLR-generated parsers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1189171

Dominik 'Rathann' Mierzejewski  changed:

   What|Removed |Added

  Flags||needinfo?(germano.massullo@
   ||gmail.com)



--- Comment #19 from Dominik 'Rathann' Mierzejewski  ---
Anything else missing to get this approved?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1189171] Review Request: python-antlr - Python runtime support for ANTLR-generated parsers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1189171

Dominik 'Rathann' Mierzejewski  changed:

   What|Removed |Added

Summary|Review Request: |Review Request:
   |antlr-python - Python   |python-antlr - Python
   |runtime support for |runtime support for
   |ANTLR-generated parsers |ANTLR-generated parsers



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1548405] New: Review Request: python-gsd - Read and write hoomd schema gsd files with an easy to use syntax

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1548405

Bug ID: 1548405
   Summary: Review Request: python-gsd - Read and write hoomd
schema gsd files with an easy to use syntax
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: domi...@greysector.net
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://rathann.fedorapeople.org/review/python-gsd/python-gsd.spec
SRPM URL:
https://rathann.fedorapeople.org/review/python-gsd/python-gsd-1.5.0-1.fc27.src.rpm
Description:
GSD (General Simulation Data) is a file format specification and a library
to read and write it. The package also contains a python module that reads
and writes hoomd schema gsd files with an easy to use syntax.

* Efficiently store many frames of data from simulation runs.
* High performance file read and write.
* Support arbitrary chunks of data in each frame (position, orientation,
  type, etc...).
* Append frames to an existing file with a monotonically increasing frame
  number.
* Resilient to job kills.
* Variable number of named chunks in each frame.
* Variable size of chunks in each frame.
* Each chunk identifies data type.
* Common use cases: NxM arrays in double, float, int, char types.
* Generic use case: binary blob of N bytes.
* Easy to integrate into other tools with python, or a C API (< 1k lines).
* Fast random access to frames.

Fedora Account System Username: rathann

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1490057] Review Request: cloudcompare - 3D point cloud and mesh processing software

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1490057



--- Comment #7 from Miro Hrončok  ---
Thank you!

BTW Upstream is trying to fix the issues so this might not need the exclude BE
arches after all.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1507103] Review Request: kronosnet - Multipoint-to-Multipoint network abstraction layer for High Availability applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1507103



--- Comment #46 from Jan Friesse  ---
@digimer:
Perfect. Spec file now looks really great with one small nitpick - changelog is
not updated. Please keep that in mind, I believe you also find useful when
package has good changelog.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1490057] Review Request: cloudcompare - 3D point cloud and mesh processing software

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1490057

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #6 from Robert-André Mauchin  ---
Seems good to me, package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1365794] Review Request: python-keyrings-alt - Alternate keyring implementations for python-keyring

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1365794

Igor Gnatenko  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |WONTFIX
  Flags|needinfo?(ignatenko@redhat. |
   |com)|
Last Closed||2018-02-23 06:52:08



--- Comment #5 from Igor Gnatenko  ---
Sorry, don't have time for this.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1284132] Review Request: nrdp - Nagios Remote Data Processor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1284132

Xavier Bachelot  changed:

   What|Removed |Added

 CC||xav...@bachelot.org



--- Comment #6 from Xavier Bachelot  ---
Hi,

Are you still interested in this review ?
Can you please update to latest release ?

Regards,
Xavier

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org