[Bug 1611829] Review Request: swtpm - TPM 1.2 and 2 emulator for QEMU
https://bugzilla.redhat.com/show_bug.cgi?id=1611829 --- Comment #16 from Stefan Berger --- > Done. > > > > > > - Own this directory: > > > > [!]: Package requires other packages for directories it uses. > > Note: No known owner of /usr/share/swtpm > > > I do not know what to do about this. Using %dir solved the problem. Fixed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1478210] Review Request: openas2 - Java implementation of EDIINT AS2
https://bugzilla.redhat.com/show_bug.cgi?id=1478210 --- Comment #13 from Stuart D Gathman --- Spec URL: https://gathman.org/linux/SPECS/openas2.spec SRPM URL: https://gathman.org/linux/f27/src/openas2-2.6.1-3.fc27.src.rpm It builds for me in mock for f27, so I don't know what is up with osgi for you. What Fedora release? It is only used when trying to run tests in mock - which don't work for other reasons. I've been working on suggestions from #fedora-java, so maybe something got out of sync and I published a src.rpm with tests enabled. Verboten or not, the /var/run/openas2 directory is required on el6 for PID. I have removed it since I don't plan to support el6. (No PID file required with systemd.) Perms in /etc/openas2 must NOT be 644 because the config files contain passwords and keys. I removed the Provides, because they are not truly provided - just copies of the jars from Fedora when using the bundled option. I'm leaving the class-path-in-manifest for another pass, because I don't understand maven enough at present to know how to fix it. I think I probably need to edit META-INF/MANIFEST.MF. What is the classpath in jar used for? Logging also happens to journald - and the openas2 server rotates it's own logs, but doesn't remove older ones. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1611829] Review Request: swtpm - TPM 1.2 and 2 emulator for QEMU
https://bugzilla.redhat.com/show_bug.cgi?id=1611829 --- Comment #15 from Stefan Berger --- Actually, I need python as well. It seems to be the one setting the symlink. I suppose it will set a different symlink once python3 takes over? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1611829] Review Request: swtpm - TPM 1.2 and 2 emulator for QEMU
https://bugzilla.redhat.com/show_bug.cgi?id=1611829
--- Comment #14 from Stefan Berger ---
(In reply to Robert-André Mauchin from comment #13)
>and:
>
> %prep
> %autosetup -n %{name}-%{gitcommit}
Cool! Thanks. I am using this now.
>
>
>
>then download the source with "spectool -g swtpm.spec"
>
>And don't forget to fix the changelog (20180918gitbe6b378)
>
>
> - Add gcc as a BR
Done.
>
> - Own this directory:
>
> [!]: Package requires other packages for directories it uses.
> Note: No known owner of /usr/share/swtpm
I do not know what to do about this.
>
>
> - patch this by replacing the obsolete macro with LT_INIT (or do it
> upstream)
This is fixed.
> - subpackages libs and selinux must also contain the license
Done.
>
> - There's an error here, you should require %{name}-libs%{?_isa}, not
> %{name}%{?_isa}
>
> %packagedevel
> Summary:Include files for the TPM emulator's CUSE interface for
> usage by clients
> Requires: %{name}-libs%{?_isa} = %{version}-%{release}
Fixed.
>
> - BuildRequires: python-twisted
>
> You must specify if you want python2-twisted or python3-twisted,
> python-twisted is deprecated. Py3 preferred as we are retiring Py2 packages.
>
Using python2-twisted now.
> - BuildRequires: python
>
> Same, specify python2 or python3. Py 3 preferred if it's compatible.
python3 doesn't seem to create the symlink of python to the python3 executable.
So I have to use python2.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1629446] Review Request: twa - tiny web auditor
https://bugzilla.redhat.com/show_bug.cgi?id=1629446 --- Comment #7 from Fedora Update System --- twa-1.3.1-1.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-326d748f33 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1629446] Review Request: twa - tiny web auditor
https://bugzilla.redhat.com/show_bug.cgi?id=1629446 --- Comment #6 from Fedora Update System --- twa-1.3.1-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-f537442a08 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1528400] Review Request: zabbix30 - Open-source monitoring solution for your IT infrastructure
https://bugzilla.redhat.com/show_bug.cgi?id=1528400 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #9 from Fedora Update System --- zabbix30-3.0.22-2.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-39c65ddf94 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1630022] Review Request: rust-dirs - Platform abstractions for common directories
https://bugzilla.redhat.com/show_bug.cgi?id=1630022 Josh Stone changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2018-09-18 17:26:08 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1528400] Review Request: zabbix30 - Open-source monitoring solution for your IT infrastructure
https://bugzilla.redhat.com/show_bug.cgi?id=1528400 --- Comment #8 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/zabbix30 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1611829] Review Request: swtpm - TPM 1.2 and 2 emulator for QEMU
https://bugzilla.redhat.com/show_bug.cgi?id=1611829
--- Comment #13 from Robert-André Mauchin ---
- Why not use a direct link for the tar.gz?
%global gitdate 20180918
%global gitcommit be6b378487548bc197bbf9fa39a01f628839a22f
%global gitshortcommit %(c=%{gitcommit}; echo ${c:0:7})
# Macros needed by SELinux
%global selinuxtype targeted
%global moduletype contrib
%global modulename swtpm
Summary: TPM Emulator
Name: swtpm
Version:0.1.0
Release:0.%{gitdate}git%{gitshortcommit}%{?dist}
License:BSD
Url:http://github.com/stefanberger/swtpm
Source0:%url/archive/%{gitcommit}/%{name}-%{gitshortcommit}.tar.gz
and:
%prep
%autosetup -n %{name}-%{gitcommit}
then download the source with "spectool -g swtpm.spec"
And don't forget to fix the changelog (20180918gitbe6b378)
- Add gcc as a BR
- Own this directory:
[!]: Package requires other packages for directories it uses.
Note: No known owner of /usr/share/swtpm
- patch this by replacing the obsolete macro with LT_INIT (or do it upstream)
AutoTools: Obsoleted m4s found -- AC_PROG_LIBTOOL
found in: swtpm-0.1.0/configure.ac:43
- subpackages libs and selinux must also contain the license
- There's an error here, you should require %{name}-libs%{?_isa}, not
%{name}%{?_isa}
%packagedevel
Summary:Include files for the TPM emulator's CUSE interface for usage
by clients
Requires: %{name}-libs%{?_isa} = %{version}-%{release}
- BuildRequires: python-twisted
You must specify if you want python2-twisted or python3-twisted, python-twisted
is deprecated. Py3 preferred as we are retiring Py2 packages.
- BuildRequires: python
Same, specify python2 or python3. Py 3 preferred if it's compatible.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
Note: No gcc, gcc-c++ or clang found in BuildRequires
See: https://fedoraproject.org/wiki/Packaging:C_and_C%2B%2B
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "BSD (3 clause)", "Unknown or generated", "*No copyright* BSD
(unspecified)". 211 files have unknown license. Detailed output of
licensecheck in /home/bob/packaging/review/swtpm/review-
swtpm/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[!]: Package requires other packages for directories it uses.
Note: No known owner of /usr/share/swtpm
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 40960 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, c
[Bug 1477567] Review Request: gcolor3 - A simple color chooser written in GTK3 (like gcolor2)
https://bugzilla.redhat.com/show_bug.cgi?id=1477567 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #20 from Robert-André Mauchin --- All good, package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1528400] Review Request: zabbix30 - Open-source monitoring solution for your IT infrastructure
https://bugzilla.redhat.com/show_bug.cgi?id=1528400 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #7 from Robert-André Mauchin --- All right, package is approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1611829] Review Request: swtpm - TPM 1.2 and 2 emulator for QEMU
https://bugzilla.redhat.com/show_bug.cgi?id=1611829
--- Comment #12 from Stefan Berger ---
> Tbh, I think having a shared library for swtpm isn't really worth it. It
> may create problems, not really solve any. I would rather link the common
> objects to the final binaries.
>
> Otherwise, I think the private libraries should rather be placed under
> ${_libdir}/%{name}, to avoid having the library in default link path.
That's where I installed them now.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1580025] Review Request: rubygem-jekyll-email-protect - A simple liquid filter which converts emails into percent-encoded strings
https://bugzilla.redhat.com/show_bug.cgi?id=1580025 Jaroslav Prokop changed: What|Removed |Added Status|MODIFIED|CLOSED Fixed In Version||rubygem-jekyll-email-protec ||t-1.1.0-1.fc30 Resolution|--- |RAWHIDE Last Closed||2018-09-18 16:08:48 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1629487] Review Request: rubygem-jekyll-git-authors - Jekyll plugin that adds git authors into your page
https://bugzilla.redhat.com/show_bug.cgi?id=1629487 Bug 1629487 depends on bug 1580025, which changed state. Bug 1580025 Summary: Review Request: rubygem-jekyll-email-protect - A simple liquid filter which converts emails into percent-encoded strings https://bugzilla.redhat.com/show_bug.cgi?id=1580025 What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1629487] Review Request: rubygem-jekyll-git-authors - Jekyll plugin that adds git authors into your page
https://bugzilla.redhat.com/show_bug.cgi?id=1629487 Jaroslav Prokop changed: What|Removed |Added Status|POST|CLOSED Fixed In Version||rubygem-jekyll-git-authors- ||0.2.1-1.fc30 Resolution|--- |RAWHIDE Last Closed||2018-09-18 16:08:14 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1528400] Review Request: zabbix30 - Open-source monitoring solution for your IT infrastructure
https://bugzilla.redhat.com/show_bug.cgi?id=1528400
--- Comment #6 from Orion Poplawski ---
Thanks!
Spec URL: https://www.cora.nwra.com/~orion/fedora/zabbix30.spec
SRPM URL: https://www.cora.nwra.com/~orion/fedora/zabbix30-3.0.22-2.el7.src.rpm
* Tue Sep 18 2018 Orion Poplawski - 3.0.22-2
- Use %%{?systemd_requires}
- Use %%license
- BR gcc
https://fedoraproject.org/wiki/Packaging:CryptoPolicies is Fedora only, and
does not apply to EPEL7.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1630022] Review Request: rust-dirs - Platform abstractions for common directories
https://bugzilla.redhat.com/show_bug.cgi?id=1630022 --- Comment #4 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-dirs -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1629487] Review Request: rubygem-jekyll-git-authors - Jekyll plugin that adds git authors into your page
https://bugzilla.redhat.com/show_bug.cgi?id=1629487 --- Comment #4 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rubygem-jekyll-git-authors -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1629446] Review Request: twa - tiny web auditor
https://bugzilla.redhat.com/show_bug.cgi?id=1629446 --- Comment #5 from Fedora Update System --- twa-1.3.1-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-52aef16045 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1629446] Review Request: twa - tiny web auditor
https://bugzilla.redhat.com/show_bug.cgi?id=1629446 --- Comment #4 from Fedora Update System --- twa-1.3.1-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-6da6953a64 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1629446] Review Request: twa - tiny web auditor
https://bugzilla.redhat.com/show_bug.cgi?id=1629446 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #3 from Fedora Update System --- twa-1.3.1-1.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2018-865878ba4e -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1580025] Review Request: rubygem-jekyll-email-protect - A simple liquid filter which converts emails into percent-encoded strings
https://bugzilla.redhat.com/show_bug.cgi?id=1580025 --- Comment #6 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rubygem-jekyll-email-protect -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1628752] Review Request: ipmctl - Utility for managing Intel DCPMM
https://bugzilla.redhat.com/show_bug.cgi?id=1628752 --- Comment #4 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/ipmctl -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1528400] Review Request: zabbix30 - Open-source monitoring solution for your IT infrastructure
https://bugzilla.redhat.com/show_bug.cgi?id=1528400
Robert-André Mauchin changed:
What|Removed |Added
CC||zebo...@gmail.com
--- Comment #5 from Robert-André Mauchin ---
Requires(post): systemd
Requires(preun): systemd
Requires(postun):systemd
→ Use %{?systemd_requires}
- License file COPYING must be installed with %license, not %doc
- Add gcc as a BR
- Package must use system-wide ciphers:
zabbix30.x86_64: W: crypto-policy-non-compliance-openssl /usr/bin/zabbix_get
SSL_CTX_set_cipher_list
zabbix30.x86_64: W: crypto-policy-non-compliance-openssl /usr/bin/zabbix_sender
SSL_CTX_set_cipher_list
crypto-policy-non-compliance-openssl:
This application package calls a function to explicitly set crypto ciphers for
SSL/TLS. That may cause the application not to use the system-wide set
cryptographic policy and should be modified in accordance to:
https://fedoraproject.org/wiki/Packaging:CryptoPolicies
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
- If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
Note: No gcc, gcc-c++ or clang found in BuildRequires
See: https://fedoraproject.org/wiki/Packaging:C_and_C%2B%2B
- If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %license.
Note: License file COPYING is not marked as %license
See:
http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "MIT/X11 (BSD like)", "FSF All Permissive", "GPL (v2 or
later)", "Unknown or generated", "zlib/libpng". 629 files have unknown
license. Detailed output of licensecheck in
/home/bob/packaging/review/zabbix30/review-zabbix30/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 911360 bytes in 13 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already
[Bug 1611829] Review Request: swtpm - TPM 1.2 and 2 emulator for QEMU
https://bugzilla.redhat.com/show_bug.cgi?id=1611829 --- Comment #11 from Stefan Berger --- The latest spec is now here again: https://github.com/stefanberger/swtpm/blob/tpm2-preview.v2.selinux/dist/swtpm.spec I removed the remaining 'Group' line, added details about how to get Source0, fixed the changelog entry to have my email and replace the AC_PROG_LIBTOOL with LT_INIT. I also removed the cuse conditional. I would like to keep the gnutls one. The rpmlint is down to this list here. I wasn't sure what to do about the no-documentation warning for the subpackages, so duplicated the %doc to all of them. ]$ rpmlint ~/rpmbuild/RPMS/x86_64/swtpm-*.rpm ~/rpmbuild/SRPMS/swtpm-0.1.0-0.20180918gitbe6b378487.fc28.src.rpm ~/rpmbuild/RPMS/noarch/swtpm-selinux-0.1.0-0.20180918gitbe6b378487.fc28.noarch.rpm swtpm-libs.x86_64: W: spelling-error %description -l en_US libtpms -> libations swtpm.src: W: spelling-error %description -l en_US libtpms -> libations swtpm.src: W: invalid-url Source0: swtpm-0.1.0.tar.gz swtpm-selinux.noarch: E: explicit-lib-dependency libselinux-utils swtpm-selinux.noarch: W: dangerous-command-in-%posttrans rm 10 packages and 0 specfiles checked; 1 errors, 4 warnings. Do I have to have a URL to the tar? In Fedora I will check the tar into the fedpkg repo and it will pick it up from there. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1435921] Review Request: python-j1m.sphinxautozconfig - Sphinx support for ZConfig
https://bugzilla.redhat.com/show_bug.cgi?id=1435921 --- Comment #23 from Miro Hrončok --- Thank You. Yes. In case you find it really useful to have it, you can ask FPC for an exception. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1435921] Review Request: python-j1m.sphinxautozconfig - Sphinx support for ZConfig
https://bugzilla.redhat.com/show_bug.cgi?id=1435921 --- Comment #22 from Robert-André Mauchin --- I wasn't sure of the new policy, I will take care of that in the future. But what if it's a Py2 only package or a cli tool with Py2 lib dependencies? Should I refuse them? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1580025] Review Request: rubygem-jekyll-email-protect - A simple liquid filter which converts emails into percent-encoded strings
https://bugzilla.redhat.com/show_bug.cgi?id=1580025 --- Comment #5 from Jaroslav Prokop --- Thanks for the review! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1629487] Review Request: rubygem-jekyll-git-authors - Jekyll plugin that adds git authors into your page
https://bugzilla.redhat.com/show_bug.cgi?id=1629487 --- Comment #3 from Jaroslav Prokop --- Thanks for the review! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1630022] Review Request: rust-dirs - Platform abstractions for common directories
https://bugzilla.redhat.com/show_bug.cgi?id=1630022 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #3 from Robert-André Mauchin --- All good then, package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1630022] Review Request: rust-dirs - Platform abstractions for common directories
https://bugzilla.redhat.com/show_bug.cgi?id=1630022 --- Comment #2 from Josh Stone --- Oh, of course. I added the %license and %doc files now. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1630022] Review Request: rust-dirs - Platform abstractions for common directories
https://bugzilla.redhat.com/show_bug.cgi?id=1630022 Robert-André Mauchin changed: What|Removed |Added Status|NEW |ASSIGNED CC||zebo...@gmail.com Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review? --- Comment #1 from Robert-André Mauchin --- - You must install LICENSE-APACHE and LICENSE-MIT with %license in %files - You should install README.md with %doc in %files - License ok - Latest version packaged - Builds in mock - No rpmlint errors -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1629487] Review Request: rubygem-jekyll-git-authors - Jekyll plugin that adds git authors into your page
https://bugzilla.redhat.com/show_bug.cgi?id=1629487 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #2 from Robert-André Mauchin --- All good, approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1629446] Review Request: twa - tiny web auditor
https://bugzilla.redhat.com/show_bug.cgi?id=1629446 --- Comment #2 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/twa -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1435921] Review Request: python-j1m.sphinxautozconfig - Sphinx support for ZConfig
https://bugzilla.redhat.com/show_bug.cgi?id=1435921 Miro Hrončok changed: What|Removed |Added CC||mhron...@redhat.com --- Comment #21 from Miro Hrončok --- Note that python2 is deprecated and hence a package with adds new python2-... package should have not been approved. This is quite new thing. Robert-André, I see you so a lot of reviews, could you please check that next time so we don't get new python2 packages at the same time we are trying to mass remove the old ones? Thanks. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1628752] Review Request: ipmctl - Utility for managing Intel DCPMM
https://bugzilla.redhat.com/show_bug.cgi?id=1628752 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #3 from Robert-André Mauchin --- - BuildRequires:python2 It should be python3 as that's what you run in CMakeList - Also now the archive in the SRPM differs from the one linked in Source0, that's not okay. You should make a new release with the fixes you've made in order to have the same checksum. Package is approved but please fix these issues before import. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1628752] Review Request: ipmctl - Utility for managing Intel DCPMM
https://bugzilla.redhat.com/show_bug.cgi?id=1628752
--- Comment #2 from Juston Li ---
Spec URL:
https://copr-be.cloud.fedoraproject.org/results/jhli/ipmctl/fedora-28-x86_64/00799986-ipmctl/ipmctl.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/jhli/ipmctl/fedora-28-x86_64/00799986-ipmctl/ipmctl-01.00.00.3262-1.fc28.src.rpm
Fixed except the two below, Let me know if you still think they should be
changed.
Thank you for doing the review! It is very much appreciated!
(In reply to Robert-André Mauchin from comment #1)
> - If you obsolete stuff, you should add similar Provides in order to have
> an upgrade path for your users:
>
> Obsoletes:ixpdimm-cli < 01.00.00.3000
>
> Obsoletes:ixpdimm_sw < 01.00.00.3000
> Obsoletes:libixpdimm-common < 01.00.00.3000
> Obsoletes:libixpdimm-core < 01.00.00.3000
> Obsoletes:libixpdimm-cli < 01.00.00.3000
> Obsoletes:libixpdimm-cim < 01.00.00.3000
> Obsoletes:libixpdimm < 01.00.00.3000
> Obsoletes:ixpdimm-data < 01.00.00.3000
>
> → obsolete-not-provided:
> If a package is obsoleted by a compatible replacement, the obsoleted package
> should also be provided in order to not cause unnecessary dependency
> breakage.
> If the obsoleting package is not a compatible replacement for the old one,
> leave out the Provides.
>
I considered it an incompatible replacement, it is based on a new codebase and
went through a number of other changes. ixpdimm_sw has not been distributed in
months and all users should have migrated to ipmctl.
> - Are you sure you need to specify the lib dependency in ipmctl and
> ipmctl-monitor? Usually RPM is able to pick up what libs are necessary
> automatically.
>
> Requires: libipmctl%{?_isa} = %{version}-%{release}
>
> I've checked and libipmctl.so.2()(64bit) is indeed picked up, so you don't
> need these Requires.
The binary and lib are always compiled and released together. I do agree these
requires don't seem to be needed but separate versions are not validated so I'd
like to keep them together just in case there are any issues.
Thanks again!
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1583798] Review Request: termy-qt - TermySequence terminal multiplexer client
https://bugzilla.redhat.com/show_bug.cgi?id=1583798 --- Comment #6 from Rex Dieter --- $ rpmlint *.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. naming: ok licensing: ok but consider adding a comment near the License: tag as reference to which licenses apply to which parts of the software sources: ok $ md5sum *.xz ac7581529766edb8f8c89f4515c94a15 termysequence-qt-1.1.0.tar.xz 1. similar to termy-sever review, SHOULD remove # Build type "None" disables Release/Debug CFLAGS and LDFLAGS set by CMake. # Only the CFLAGS and LDFLAGS specified by rpmbuild will be used. and consider using -DCMAKE_BUILD_TYPE=Release instead. scriptlets: n/a macros: ok 2. since this bundles a copy of v8, MUST add something like: Provides: bundled(v8) = per https://fedoraproject.org/wiki/Bundled_Libraries?rd=Packaging:Bundled_Libraries#Requirement_if_you_bundle -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1611829] Review Request: swtpm - TPM 1.2 and 2 emulator for QEMU
https://bugzilla.redhat.com/show_bug.cgi?id=1611829 --- Comment #10 from Robert-André Mauchin --- - Add a URL: field - Source0 must be d/l from a URL, if it's not possible details the instructions to create the archive - Group is not used in Fedora - your changelog entry should contain your email - patch this by replacing the obsolete macro with LT_INIT: AutoTools: Obsoleted m4s found -- AC_PROG_LIBTOOL found in: swtpm-0.1.0/configure.ac:43 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1528400] Review Request: zabbix30 - Open-source monitoring solution for your IT infrastructure
https://bugzilla.redhat.com/show_bug.cgi?id=1528400 --- Comment #4 from Orion Poplawski --- Spec URL: https://www.cora.nwra.com/~orion/fedora/zabbix30.spec SRPM URL: https://www.cora.nwra.com/~orion/fedora/zabbix30-3.0.22-1.el7.src.rpm * Tue Sep 18 2018 Orion Poplawski - 3.0.22-1 - Updaate to 3.0.22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1617953] Review Request: OpenMolcas - A multiconfigurational quantum chemistry software package
https://bugzilla.redhat.com/show_bug.cgi?id=1617953 --- Comment #16 from Fedora Update System --- OpenMolcas-18.0-6.o180813.1752.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-7dce5eec99 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1586117] Review Request: virtio-forwarder - SR-IOV virtual function to virtio packet forwarder
https://bugzilla.redhat.com/show_bug.cgi?id=1586117 --- Comment #9 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/virtio-forwarder -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1580025] Review Request: rubygem-jekyll-email-protect - A simple liquid filter which converts emails into percent-encoded strings
https://bugzilla.redhat.com/show_bug.cgi?id=1580025 Pavel Valena changed: What|Removed |Added Status|POST|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1580025] Review Request: rubygem-jekyll-email-protect - A simple liquid filter which converts emails into percent-encoded strings
https://bugzilla.redhat.com/show_bug.cgi?id=1580025 Pavel Valena changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ |needinfo?(pval...@redhat.co | |m) | --- Comment #4 from Pavel Valena --- Sorry for the holdup. The spec looks fine now, thanks! I APPROVE the package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1586117] Review Request: virtio-forwarder - SR-IOV virtual function to virtio packet forwarder
https://bugzilla.redhat.com/show_bug.cgi?id=1586117 Robert-André Mauchin changed: What|Removed |Added Flags|fedora-review? |fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1586117] Review Request: virtio-forwarder - SR-IOV virtual function to virtio packet forwarder
https://bugzilla.redhat.com/show_bug.cgi?id=1586117 Robert-André Mauchin changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR) | Flags|fedora-review+ |fedora-review? Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1558683] Review Request: python-ucsmsdk - Python SDK for Cisco UCSM
https://bugzilla.redhat.com/show_bug.cgi?id=1558683 Alfredo Moralejo changed: What|Removed |Added Flags|fedora-review+ | -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1613036] Review Request: oshinko-cli - Command line interface for spark cluster management app
https://bugzilla.redhat.com/show_bug.cgi?id=1613036 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2018-09-18 06:23:21 --- Comment #28 from Fedora Update System --- oshinko-cli-0.5.4-1.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1626102] Review Request: xmakemol - Program for visualizing atomic and molecular systems
https://bugzilla.redhat.com/show_bug.cgi?id=1626102 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2018-09-18 06:23:02 --- Comment #11 from Fedora Update System --- xmakemol-5.16-3.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1611829] Review Request: swtpm - TPM 1.2 and 2 emulator for QEMU
https://bugzilla.redhat.com/show_bug.cgi?id=1611829
Marc-Andre Lureau changed:
What|Removed |Added
Whiteboard||NotReady
--- Comment #9 from Marc-Andre Lureau ---
I ran fedora-review for you :) :
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
Issues:
===
- Please follow the common section order:
https://rpm-packaging-guide.github.io/#hello-world
In particular %files is before %changelog
- For initial Fedora introduction, I would recommend to drop all the
conditionals, and the support for building on older fedora or rhel (they can be
added back later on, but they ease the initial review and avoid the cruft).
- test_tpm2_save_load_encrypted_state fails (wasn't this supposed to be fixed
with #1612803 ?)
- These BR are not needed: coreutils sed bash
- /sbin/ldconfig not called in swtpm-libs
Tbh, I think having a shared library for swtpm isn't really worth it. It may
create problems, not really solve any. I would rather link the common objects
to the final binaries.
Otherwise, I think the private libraries should rather be placed under
${_libdir}/%{name}, to avoid having the library in default link path.
- fedora-review doesn't like swtpm-debugsource headers, it may be a
fedora-review bug?
- see other issues listed below, in particular rpmlint
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
[!]: License file installed when any subpackage combination is installed.
The package LICENSE file should be installed with %license with swtpm
[!]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/swtpm
[?]: Package does not own files or directories owned by other packages.
I think I hit a fedora-review bug here...
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[!]: Changelog rpmlint error
[x]: Sources contain only permissible code or content.
[!]: Development files must be in a -devel package
Only /usr/include/swtpm/tpm_ioctl.h is provided, which doesn't provide API
to /usr/lib64/libswtpm_libtpms.so.
If /usr/lib64/libswtpm_libtpms.so is a private shared library, I don't
know what's the packaging rule.
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: Requires correct, justified where necessary.
Sometime you use swtpm, sometime %{name}
[x]: Spec file is legible and written in American English.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must
[Bug 1477567] Review Request: gcolor3 - A simple color chooser written in GTK3 (like gcolor2)
https://bugzilla.redhat.com/show_bug.cgi?id=1477567 --- Comment #19 from Timothée Floure --- Spec URL: https://fedorapeople.org/cgit/fnux/public_git/rpm-gcolor3.git/plain/gcolor3.spec?id=1b21c5404fb054279219d2ca6088eb01c32cfd27 SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/7130/29747130/gcolor3-2.3.1-1.fc28.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1628614] Review Request: python-trustme - #1 quality TLS certs while you wait, for the discerning tester
https://bugzilla.redhat.com/show_bug.cgi?id=1628614 --- Comment #9 from Fedora Update System --- python-trustme-0.4.0-1.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-f5af5d1580 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1628614] Review Request: python-trustme - #1 quality TLS certs while you wait, for the discerning tester
https://bugzilla.redhat.com/show_bug.cgi?id=1628614 --- Comment #8 from Fedora Update System --- python-trustme-0.4.0-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-2b3150c27e -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1583026] Review Request: ektype-mukta-fonts - Free Indian truetype/ open type fonts
https://bugzilla.redhat.com/show_bug.cgi?id=1583026 vishalvvr changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||ektype-mukta-fonts-2.538-2 Resolution|--- |NEXTRELEASE Last Closed||2018-09-18 02:22:07 --- Comment #8 from vishalvvr --- New build created in upstream therefore closing this bug. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1613036] Review Request: oshinko-cli - Command line interface for spark cluster management app
https://bugzilla.redhat.com/show_bug.cgi?id=1613036 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #27 from Fedora Update System --- oshinko-cli-0.5.4-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-51a8158b34 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1628614] Review Request: python-trustme - #1 quality TLS certs while you wait, for the discerning tester
https://bugzilla.redhat.com/show_bug.cgi?id=1628614 --- Comment #7 from Fedora Update System --- python-trustme-0.4.0-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-e21a10114d -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
