[Bug 810049] Review Request: netbeans-ide - Netbeans Integrated Development Environment (IDE)
https://bugzilla.redhat.com/show_bug.cgi?id=810049 Roshni Khanna changed: What|Removed |Added CC||roshanikhann...@gmail.com --- Comment #35 from Roshni Khanna --- I love reading your articles and I shared it with my friends.People also like it and give good feedback. Thank you. http://www.roshnikhanna.in/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1763147] Review Request: golang-github-creack-goselect - Select(2) implementation in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1763147 --- Comment #3 from Elliott Sales de Andrade --- That's only a recommendation of the FSF for GPL. It's not required to annotate all source files, and just take a look at the instructions on the sidebar for choose a license, for example: https://choosealicense.com/licenses/mit/ tldr legal: https://tldrlegal.com/license/mit-license "You must include the license notice in all copies or substantial uses of the work." or this SE answer: https://opensource.stackexchange.com/questions/4534/how-to-apply-mit-license-in-the-github-repo-for-fully-free-project "No, a license header is not necessary, at least for MIT and the Unlicense. Some other licenses encourage you to add such a header but that is not the case of these two." -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1767252] Review Request: transflac - transcode FLAC to lossy formats
https://bugzilla.redhat.com/show_bug.cgi?id=1767252 --- Comment #17 from Fedora Update System --- FEDORA-2019-8e7a59437f has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-8e7a59437f -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1767252] Review Request: transflac - transcode FLAC to lossy formats
https://bugzilla.redhat.com/show_bug.cgi?id=1767252 --- Comment #18 from Fedora Update System --- FEDORA-2019-53639db3c3 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-53639db3c3 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1767252] Review Request: transflac - transcode FLAC to lossy formats
https://bugzilla.redhat.com/show_bug.cgi?id=1767252 --- Comment #16 from Fedora Update System --- FEDORA-2019-9ebbf2f70e has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-9ebbf2f70e -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1768447] Review Request: mcomix3 - User-friendly, customizable image viewer for comic books
https://bugzilla.redhat.com/show_bug.cgi?id=1768447 --- Comment #8 from Mamoru TASAKA --- mcomix3 was successfully built for rawhide, for now I am waiting for next compose to verify it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1767187] Review Request: golang-github-direnv-dotenv - Go dotenv parsing library for direnv
https://bugzilla.redhat.com/show_bug.cgi?id=1767187 Fedora Update System changed: What|Removed |Added Status|ON_QA |MODIFIED --- Comment #6 from Fedora Update System --- FEDORA-2019-afd4e64207 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-afd4e64207 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1731583] Review Request: python-pingouin - Statistical package for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1731583 Bug 1731583 depends on bug 1674101, which changed state. Bug 1674101 Summary: scipy-1.3.1 is available https://bugzilla.redhat.com/show_bug.cgi?id=1674101 What|Removed |Added Status|NEW |CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1767509] Review Request: polkit-qt-1 - Qt bindings for PolicyKit
https://bugzilla.redhat.com/show_bug.cgi?id=1767509 Troy Dawson changed: What|Removed |Added Flags||fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1767509] Review Request: polkit-qt-1 - Qt bindings for PolicyKit
https://bugzilla.redhat.com/show_bug.cgi?id=1767509 --- Comment #2 from Troy Dawson --- Looks good to me. Note: The rpmlint bad URL warning was false positives. I verified all of the URL's by hand. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1767509] Review Request: polkit-qt-1 - Qt bindings for PolicyKit
https://bugzilla.redhat.com/show_bug.cgi?id=1767509
Troy Dawson changed:
What|Removed |Added
Status|NEW |ASSIGNED
--- Comment #1 from Troy Dawson ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[-]: Provides: bundled(gnulib) in place as required.
Note: Sources not installed
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[X]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[X]: License field in the package spec file matches the actual license.
Note: There is no build directory. Running licensecheck on vanilla
upstream sources. No licenses found. Please check the source files for
licenses manually.
[X]: License file installed when any subpackage combination is installed.
[X]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by: /usr/share/doc/polkit-
qt5-1(locale,, defaulting, C, to, Failed, set, polkit-qt5-1),
/usr/share/licenses/polkit-qt5-1(locale,, defaulting, C, to, Failed,
set, polkit-qt5-1), /usr/include/polkit-qt5-1(defaulting, C, to,
polkit-qt5-1-devel, Failed, set, locale,), /usr/include/polkit-
qt5-1/PolkitQt1(defaulting, C, to, polkit-qt5-1-devel, Failed, set,
locale,), /usr/include/polkit-qt5-1/PolkitQt1/Agent(defaulting, C, to,
polkit-qt5-1-devel, Failed, set, locale,), /usr/include/polkit-
qt5-1/PolkitQt1/Gui(defaulting, C, to, polkit-qt5-1-devel, Failed,
set, locale,), /usr/lib64/cmake/PolkitQt5-1(defaulting, C, to, polkit-
qt5-1-devel, Failed, set, locale,)
[X]: %build honors applicable compiler flags or justifies otherwise.
[ ]: Package contains no bundled libraries without FPC exception.
[X]: Changelog in prescribed format.
[X]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[X]: Development files must be in a -devel package
[X]: Package uses nothing in %doc for runtime.
[X]: Package consistently uses macros (instead of hard-coded directory
names).
[X]: Package is named according to the Package Naming Guidelines.
[X]: Package does not generate any conflict.
[X]: Package obeys FHS, except libexecdir and /usr/target.
[X]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[X]: Useful -debuginfo package or justification otherwise.
[X]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 2 files.
[X]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the form
[Bug 1767509] Review Request: polkit-qt-1 - Qt bindings for PolicyKit
https://bugzilla.redhat.com/show_bug.cgi?id=1767509 Troy Dawson changed: What|Removed |Added CC||tdaw...@redhat.com Assignee|nob...@fedoraproject.org|tdaw...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1767235] Review Request: direnv - Per-directory shell configuration tool
https://bugzilla.redhat.com/show_bug.cgi?id=1767235 Ed Marshall changed: What|Removed |Added Status|POST|ASSIGNED --- Comment #4 from Ed Marshall --- Bah, that's what I get for cut-and-pasting in a hurry. :P Fixed problems with manpage permissions and directory package ownership, and pulled in a patch from the debian package for the malformed man page (looks like it's a bug in either ronn or md2man, and this has come up before upstream; I linked to the issue). Thanks for the review! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1770278] Review Request: vimiv-qt - An image viewer with vim-like keybindings
https://bugzilla.redhat.com/show_bug.cgi?id=1770278 --- Comment #5 from J. Scheurich --- Rpmlint --- Checking: vimiv-qt-0.3.0-1.fc32.x86_64.rpm vimiv-qt-doc-0.3.0-1.fc32.x86_64.rpm vimiv-qt-debuginfo-0.3.0-1.fc32.x86_64.rpm vimiv-qt-debugsource-0.3.0-1.fc32.x86_64.rpm vimiv-qt-0.3.0-1.fc32.src.rpm vimiv-qt-doc.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/vimiv-q$ 5 packages and 0 specfiles checked; 0 errors, 1 warnings. ... Rpmlint (installed packages) --. vimiv-qt-doc.x86_64: W: description-shorter-than-summary ... imiv-qt-doc.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/vimiv-qt-doc/html/objects.inv -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1770278] Review Request: vimiv-qt - An image viewer with vim-like keybindings
https://bugzilla.redhat.com/show_bug.cgi?id=1770278 --- Comment #4 from J. Scheurich --- !]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 7075840 bytes in /usr/share -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1763285] Review Request: libnma - NetworkManager GUI library
https://bugzilla.redhat.com/show_bug.cgi?id=1763285
Lubomir Rintel changed:
What|Removed |Added
Flags|needinfo?(lkund...@v3.sk) |
--- Comment #2 from Lubomir Rintel ---
(In reply to Matthew Krupcale from comment #1)
> For the most part, this is close to ready, except for a few {Build,}Requires
> and Obsoletes issues and license packaging details.
>
> Since this is splitting off from network-manager-applet, I looked at that
> spec file, and it seems to indicate that libnma{,-devel} should obsolete
> libnm-gtk{,-devel}.
No, libnma doesn't obsolete libnma-gtk. It is gone without a replacement -- the
Obsoletes should go to fedora-obsolete-packages. I'll do that once the
network-manager-applet package is updated and libnm-gtk is actually dropped.
> Issues:
> ===
> - If your application is a C or C++ application you must list a
> BuildRequires against gcc, gcc-c++ or clang.
> Note: No gcc, gcc-c++ or clang found in BuildRequires
> See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/
Fixed.
> - %bcond_without should be used for defining with by default
> You may have this backwards for libnma_gtk4
> See: https://rpm.org/user_doc/conditional_builds.html
Good catch, thanks. Fixed.
> - -devel and -gtk4-devel should require arch-dependent library packages:
> Requires: %{name}%{?_isa} = %{version}-%{release}
> and
> Requires: %{name}-gtk4%{?_isa} = %{version}-%{release}
> respectively
> See:
> https://docs.fedoraproject.org/en-US/packaging-guidelines/
> #_requiring_base_package
Yes. Fixed.
> - -gtk4 and -gtk4-devel subpackages should only be defined when
> %if %{with libnma_gtk4}
No, it's the presence of %files section or lack thereof that decides whether a
binary package is built. That is so by design.
> - Should Obsoletes: libnm-gtk{,-devel}
See above.
> - %ldconfig_scriptlets is unnecessary on F28+
> See: https://fedoraproject.org/wiki/Changes/Removing_ldconfig_scriptlets
Dropped it.
> - License should be "GPLv2+ and LGPLv2+" due to contents in shared/
> Should install COPYING.LGPLv2.1.
> This should be documented in the spec file as well.
> See:
> https://docs.fedoraproject.org/en-US/packaging-guidelines/
> LicensingGuidelines/#_multiple_licensing_scenarios
Yes. This needs to get fixed upstream first:
https://gitlab.gnome.org/GNOME/libnma/merge_requests/5
> - License not installed with -gtk4
Fixed.
> - Consider moving %{_datadir}/gtk-doc files to noarch -devel-doc subpackage
> See:
> https://docs.fedoraproject.org/en-US/packaging-guidelines/#_documentation
Yeah, it could be done, but it seems rather unnecessary to me at this point.
Updated package:
SPEC: http://v3.sk/~lkundrak/SPECS/libnma.spec
SRPM: http://v3.sk/~lkundrak/SRPMS/libnma-1.8.26-2.fc31.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1770278] Review Request: vimiv-qt - An image viewer with vim-like keybindings
https://bugzilla.redhat.com/show_bug.cgi?id=1770278 --- Comment #3 from J. Scheurich --- License:GPLv3+ vimiv-qt-0.3.0$ find . -type f | xargs grep license ... ./docs/_build/html/_static/doctools.js: * :license: BSD, see LICENSE for details. ./docs/_build/html/_static/underscore.js:// Underscore is freely distributable under the MIT license. ./docs/_build/html/_static/bootswatch-2.3.2/cyborg/bootstrap.min.css: * http://www.apache.org/licenses/LICENSE-2.0 ./docs/_build/html/_static/bootswatch-2.3.2/readable/bootstrap.min.css: * http://www.apache.org/licenses/LICENSE-2.0 ./docs/_build/html/_static/bootswatch-2.3.2/journal/bootstrap.min.css: * http://www.apache.org/licenses/LICENSE-2.0 ... more references to the apache 2 license ... ./docs/_build/html/_static/basic.css: * :license: BSD, see LICENSE for details. ./docs/_build/html/_static/bootstrap-3.3.6/js/bootstrap.js: * Licensed under the MIT license ./docs/_build/html/_static/bootstrap-3.3.6/js/bootstrap.min.js: * Licensed under the MIT license ./docs/_build/html/_static/jquery-3.2.1.js: * Released under the MIT license ./docs/_build/html/_static/jquery-3.2.1.js: * https://jquery.org/license ./docs/_build/html/_static/jquery-3.2.1.js: * Released under the MIT license ./docs/_build/html/_static/jquery-3.2.1.js: * http://jquery.org/license ./docs/_build/html/_static/searchtools.js: * :license: BSD, see LICENSE for details. ./docs/_build/html/_static/searchtools.js: * :license: BSD, see LICENSE for details. ./docs/_build/html/_static/js/jquery-1.11.0.min.js:/*! jQuery v1.12.4 | (c) jQuery Foundation | jquery.org/license */ ./docs/_build/html/_static/jquery.js:/*! jQuery v3.2.1 | (c) JS Foundation and other contributors | jquery.org/license */ ./docs/_build/html/_static/websupport.js: * :license: BSD, see LICENSE for details. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1770278] Review Request: vimiv-qt - An image viewer with vim-like keybindings
https://bugzilla.redhat.com/show_bug.cgi?id=1770278 --- Comment #2 from J. Scheurich --- [!]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. vimiv-qt-0.3.0$ find . -name '*.so*' ./build/lib.linux-x86_64-3.7/vimiv/imutils/_c_manipulate.cpython-37m-x86_64-linux-gnu.so -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1770278] Review Request: vimiv-qt - An image viewer with vim-like keybindings
https://bugzilla.redhat.com/show_bug.cgi?id=1770278 J. Scheurich changed: What|Removed |Added CC||muft...@web.de --- Comment #1 from J. Scheurich --- There are errors during the package build: $ pmbuild -ba vimiv-qt.spec ... ... make: Entering directory '/home/mufti/rpmbuild/BUILD/vimiv-qt-0.3.0/docs' Running Sphinx v1.8.4 making output directory... building [mo]: targets for 0 po files that are out of date building [html]: targets for 19 source files that are out of date updating environment: 19 added, 0 changed, 0 removed reading sources... [100%] screenshots /home/mufti/rpmbuild/BUILD/vimiv-qt-0.3.0/docs/documentation/commands.rst:20: WARNING: Problems with "include" directive path: InputError: [Errno 2] No such file or directory: 'documentation/commands_desc.rstsrc'. /home/mufti/rpmbuild/BUILD/vimiv-qt-0.3.0/docs/documentation/configuration/keybindings.rst:37: WARNING: Problems with "include" directive path: InputError: [Errno 2] No such file or directory: 'documentation/configuration/keybindings_table.rstsrc'. /home/mufti/rpmbuild/BUILD/vimiv-qt-0.3.0/docs/documentation/configuration/plugins.rst:26: WARNING: Problems with "include" directive path: InputError: [Errno 2] No such file or directory: 'documentation/configuration/default_plugins.rstsrc'. /home/mufti/rpmbuild/BUILD/vimiv-qt-0.3.0/docs/documentation/configuration/settings.rst:17: WARNING: Problems with "include" directive path: InputError: [Errno 2] No such file or directory: 'documentation/configuration/settings_table.rstsrc'. /home/mufti/rpmbuild/BUILD/vimiv-qt-0.3.0/docs/documentation/configuration/statusbar.rst:33: WARNING: Problems with "include" directive path: InputError: [Errno 2] No such file or directory: 'documentation/configuration/status_modules.rstsrc'. WARNING: autodoc: failed to import module 'imutils' from module 'vimiv'; the following exception was raised: cannot import name '_c_manipulate' from 'vimiv.imutils' (/home/mufti/rpmbuild/BUILD/vimiv-qt-0.3.0/vimiv/imutils/__init__.py) WARNING: autodoc: failed to import module 'imutils.immanipulate' from module 'vimiv'; the following exception was raised: cannot import name '_c_manipulate' from 'vimiv.imutils' (/home/mufti/rpmbuild/BUILD/vimiv-qt-0.3.0/vimiv/imutils/__init__.py) /home/mufti/rpmbuild/BUILD/vimiv-qt-0.3.0/docs/index.rst:: WARNING: image file not readable: _static/vimiv/vimiv_banner_800.png /home/mufti/rpmbuild/BUILD/vimiv-qt-0.3.0/docs/index.rst:: WARNING: image file not readable: _static/scrots/image_light.png /home/mufti/rpmbuild/BUILD/vimiv-qt-0.3.0/docs/index.rst:: WARNING: image file not readable: _static/scrots/thumbnail_light.png /home/mufti/rpmbuild/BUILD/vimiv-qt-0.3.0/docs/index.rst:: WARNING: image file not readable: _static/scrots/library_dark.png /home/mufti/rpmbuild/BUILD/vimiv-qt-0.3.0/docs/index.rst:: WARNING: image file not readable: _static/scrots/command_dark.png /home/mufti/rpmbuild/BUILD/vimiv-qt-0.3.0/docs/manpage/vimiv.1.rst:10: WARNING: Problems with "include" directive path: InputError: [Errno 2] No such file or directory: 'manpage/synopsis.rstsrc'. /home/mufti/rpmbuild/BUILD/vimiv-qt-0.3.0/docs/manpage/vimiv.1.rst:23: WARNING: Problems with "include" directive path: InputError: [Errno 2] No such file or directory: 'manpage/options.rstsrc'. /home/mufti/rpmbuild/BUILD/vimiv-qt-0.3.0/docs/screenshots.rst:: WARNING: image file not readable: _static/scrots/image_dark.png /home/mufti/rpmbuild/BUILD/vimiv-qt-0.3.0/docs/screenshots.rst:: WARNING: image file not readable: _static/scrots/thumbnail_dark.png /home/mufti/rpmbuild/BUILD/vimiv-qt-0.3.0/docs/screenshots.rst:: WARNING: image file not readable: _static/scrots/library_dark.png /home/mufti/rpmbuild/BUILD/vimiv-qt-0.3.0/docs/screenshots.rst:: WARNING: image file not readable: _static/scrots/command_dark.png /home/mufti/rpmbuild/BUILD/vimiv-qt-0.3.0/docs/screenshots.rst:: WARNING: image file not readable: _static/scrots/image_light.png /home/mufti/rpmbuild/BUILD/vimiv-qt-0.3.0/docs/screenshots.rst:: WARNING: image file not readable: _static/scrots/thumbnail_light.png /home/mufti/rpmbuild/BUILD/vimiv-qt-0.3.0/docs/screenshots.rst:: WARNING: image file not readable: _static/scrots/library_light.png /home/mufti/rpmbuild/BUILD/vimiv-qt-0.3.0/docs/screenshots.rst:: WARNING: image file not readable: _static/scrots/command_light.png looking for now-outdated files... none found pickling environment... done checking consistency... done preparing documents... done /usr/lib/python3.7/site-packages/sphinx/builders/html.py:138: RemovedInSphinx20Warning: builder.css_files is deprecated. Please use app.add_stylesheet() instead. ret += other writing output... [100%] screenshots generating indices... genindex py-modindex writing additional pages... search copying s
[Bug 1763147] Review Request: golang-github-creack-goselect - Select(2) implementation in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1763147 Lubomir Rintel changed: What|Removed |Added Status|NEW |ASSIGNED CC||lkund...@v3.sk Assignee|nob...@fedoraproject.org|lkund...@v3.sk Flags||fedora-review? --- Comment #2 from Lubomir Rintel --- * Package named correctly * Packaging the latest version * License text included * License okay for Fedora * Builds fine in mock * SPEC file clean and concise * rpmlint reasonably happy 1.) The license is not clear There doesn't seem to be any word in documentation or source files about how they are licensed. The MIT license file is just there, with no indication about how is it relevant. Please ask upstream to clarify this, preferrably by including a comment in the source files about how are they licensed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1768186] Package Review: python-anytree - Powerful and Lightweight Python Tree Data Structure
https://bugzilla.redhat.com/show_bug.cgi?id=1768186 Lubomir Rintel changed: What|Removed |Added CC||lrin...@redhat.com --- Comment #2 from Lubomir Rintel --- (In reply to Elliott Sales de Andrade from comment #1) > Why is the license Source1 from a fork and not the original repository? No good reason. My mistake. Fixed. > License should be marked with %license. Done. > Use %py3_build and %py3_install macros. Done. Didn't know about them, thanks. > There seems to be test directory; can you run those in %check? Unfortunately upstream doesn't seem to package it, so I can't really do that yet. Reported upstream: https://github.com/c0fec0de/anytree/issues/106 Updated package: SPEC: http://v3.sk/~lkundrak/SPECS/python-anytree.spec SRPM: http://v3.sk/~lkundrak/SRPMS/python-anytree-2.7.2-2.fc31.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1770294] Review Request: js - JavaScript interpreter and libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1770294 --- Comment #1 from Tom "spot" Callaway --- Description was accidentally omitted. Description: JavaScript is the Netscape-developed object scripting language used in millions of web pages and server applications worldwide. Netscape's JavaScript is a super-set of the ECMA-262 Edition 3 (ECMAScript) standard scripting language, with only mild differences from the published standard. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1770294] New: Review Request: js - JavaScript interpreter and libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1770294 Bug ID: 1770294 Summary: Review Request: js - JavaScript interpreter and libraries Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: tcall...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://spot.fedorapeople.org/js.spec SRPM URL: https://spot.fedorapeople.org/js-1.8.5-35.fc30.src.rpm Description: Fedora Account System Username: spot Koji Rawhide Scratch Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=38842751 Note: This package was previously in Fedora but was orphaned & retired after Fedora 30. I need it alive for freewrl, so I applied the fix to resolve the FTBFS from Sergey Bostandzhyan. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1766688] Review Request: vgrive - Google Drive client for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1766688 --- Comment #1 from Artem --- https://copr-be.cloud.fedoraproject.org/results/atim/vgrive/fedora-31-x86_64/01089112-vgrive/vgrive.spec https://copr-be.cloud.fedoraproject.org/results/atim/vgrive/fedora-31-x86_64/01089112-vgrive/vgrive-1.3.0-1.fc31.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1767918] Review Request: targetd - Revive package
https://bugzilla.redhat.com/show_bug.cgi?id=1767918
--- Comment #5 from Tony Asleson ---
(In reply to Elliott Sales de Andrade from comment #4)
> Please link the spec *and* srpm directly (no .1 suffixes), or fedora-review
> does not work.
Sorry about that, existing spec file updated:
https://tasleson.fedorapeople.org/targetd/targetd.spec
> You should use the %py3_build and %py3_install macros.
> https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_macros
Done
> Man page extensions should be globbed.
> https://docs.fedoraproject.org/en-US/packaging-guidelines/#_manpages
Done
> It doesn't look like you run systemd in scriptlets, so you don't need to
> Require it.
> https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/
> #_dependencies_on_the_systemd_package
Done
Thanks!
diff --git a/targetd.spec b/targetd.spec
index ccd3f62..912a697 100644
--- a/targetd.spec
+++ b/targetd.spec
@@ -11,10 +11,6 @@ BuildRequires: systemd-rpm-macros
BuildRequires: python3-devel
Requires: python3-PyYAML python3-setproctitle python3-rtslib
target-restore
Requires: nfs-utils, btrfs-progs, python3-blockdev, libblockdev-lvm
-Requires(post): systemd
-Requires(preun): systemd
-Requires(postun): systemd
-
%description
targetd turns the machine into a remotely-configurable storage appliance.
@@ -26,7 +22,7 @@ those volumes over iSCSI.
%setup -q
%build
-%{__python3} setup.py build
+%py3_build
%install
mkdir -p %{buildroot}%{_mandir}/man8/
@@ -35,7 +31,7 @@ mkdir -p %{buildroot}%{_sysconfdir}/target/
install -m 644 %{SOURCE1} %{buildroot}%{_unitdir}/targetd.service
install -m 644 targetd.yaml %{buildroot}%{_sysconfdir}/target/targetd.yaml
install -m 644 targetd.8 %{buildroot}%{_mandir}/man8/
-%{__python3} setup.py install --skip-build --root %{buildroot}
+%py3_install
%post
%systemd_post targetd.service
@@ -53,7 +49,7 @@ install -m 644 targetd.8 %{buildroot}%{_mandir}/man8/
%{python3_sitelib}/*.egg-info
%license LICENSE
%doc README.md API.md client
-%{_mandir}/man8/targetd.8.gz
+%{_mandir}/man8/targetd.8*
%config(noreplace) %{_sysconfdir}/target/targetd.yaml
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1770278] New: Review Request: vimiv-qt - An image viewer with vim-like keybindings
https://bugzilla.redhat.com/show_bug.cgi?id=1770278 Bug ID: 1770278 Summary: Review Request: vimiv-qt - An image viewer with vim-like keybindings Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: sanjay.an...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://ankursinha.fedorapeople.org/vimiv-qt/vimiv-qt.spec SRPM URL: https://ankursinha.fedorapeople.org/vimiv-qt/vimiv-qt-0.3.0-1.fc32.src.rpm Description: Vimiv is an image viewer with vim-like keybindings. It is written in python3 using the Qt5 toolkit and is free software, licensed under the GPL. The initial GTK3 version of vimiv will no longer be maintained. - Simple library browser - Thumbnail mode - Basic image editing - Command line with tab completion - Complete customization with style sheets Fedora Account System Username: ankursinha -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1769297] Review Request: python-editdistance - Provides a fast implementation of the Levenshtein distance in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1769297
--- Comment #8 from Aniket Pradhan ---
Thanks a lot, Elliott!
I set the PATH to point to %{buildroot}%{python3_sitearch} where the package is
installed, and the tests now pass successfully [1]. I also shifted from nose to
pytest. I hope there are no problems now. :D
[1]: https://koji.fedoraproject.org/koji/taskinfo?taskID=38841256
P.S. I have updated the spec and the SRPM on the above-mentioned URLs.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1767801] Review Request: python-dasbus - DBus library in Python 3
https://bugzilla.redhat.com/show_bug.cgi?id=1767801 --- Comment #4 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-dasbus -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1769843] Review Request: low-memory-monitor - Monitors low-memory conditions
https://bugzilla.redhat.com/show_bug.cgi?id=1769843
--- Comment #6 from Michael Catanzaro ---
(In reply to Bastien Nocera from comment #5)
> It's not really a configuration file, and shouldn't be modified by users, or
> even
> administrators.
I notice there is also %{_datadir}/dbus-1/system.d/. Not sure about the history
behind these two locations, but how about we put it there instead? Seems like a
better place?
> I would actually want the file to be replaced to automatically use the new
> defaults
> set in the package, rather than keep the old ones. So the current tag is
> correct for
> this file.
That is allowed if you add a comment to the spec file, but it's discouraged:
"""
As a rule of thumb, use %config(noreplace) instead of plain %config unless your
best, educated guess is that doing so will break things. In other words, think
hard before overwriting local changes in configuration files on package
upgrades. An example case when /not/ to use noreplace is when a package’s
configuration file changes so that the new package revision wouldn’t work with
the config file from the previous package revision. Whenever plain %config is
used, add a brief comment to the specfile explaining why.
"""
Basically users won't ever be able to safely edit this file if you replace
their changes on package upgrade. Seems better for low-memory-monitor to assume
default values for anything it doesn't find in its configuration file, which
you probably do already anyway.
But if you really want to replace it despite that guidance, you can add a
comment.
> That expands to:
> %systemd_requires \
> Requires(post): systemd \
> Requires(preun): systemd \
> Requires(postun): systemd \
> %{nil}
>
> Which I think is what we want. Or am I missing something?
Final sentence here:
"""
If package scriptlets call other systemd tools, for example systemd-tmpfiles,
the package SHOULD declare appropriate dependencies. The %systemd_requires
macro is a shortcut to require systemd for the %pre, %post, and %postun
scriptlets. Note that those dependencies are not required for the
%systemd_{post,preun,postun_with_restart,user_post,user_preun} macros listed
above.
"""
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1767883] Review Request: minizip1.2 - Library for manipulation with .zip archives
https://bugzilla.redhat.com/show_bug.cgi?id=1767883 Tom "spot" Callaway changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2019-11-08 13:48:08 --- Comment #11 from Tom "spot" Callaway --- Built and in EPEL-8. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1770162] Review Request: python-molten - A minimal, extensible, fast and productive API framework
https://bugzilla.redhat.com/show_bug.cgi?id=1770162 --- Comment #1 from Anna Khaitovich --- COPR build url: https://copr.fedorainfracloud.org/coprs/akhaitov/python-molten/build/1088893/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1770162] New: Review Request: python-molten - A minimal, extensible, fast and productive API framework
https://bugzilla.redhat.com/show_bug.cgi?id=1770162 Bug ID: 1770162 Summary: Review Request: python-molten - A minimal, extensible, fast and productive API framework Product: Fedora Version: rawhide OS: Linux Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: akhai...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://copr-be.cloud.fedoraproject.org/results/akhaitov/python-molten/fedora-rawhide-x86_64/01088893-python-molten/python-molten.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/akhaitov/python-molten/fedora-rawhide-x86_64/01088893-python-molten/python-molten-0.7.4-1.fc32.src.rpm Description: Minimal, extensible, fast and productive API framework for Python 3 Fedora Account System Username: akhaitov -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1767452] Review Request: rust-normalize-line-ending - Takes an iterator over chars and returns a new iterator with all line endings
https://bugzilla.redhat.com/show_bug.cgi?id=1767452 Igor Gnatenko changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Summary|Review Request: |Review Request: |rust-normalize-line - Takes |rust-normalize-line-ending |an iterator over chars and |- Takes an iterator over |returns a new iterator with |chars and returns a new |all line endings|iterator with all line ||endings Last Closed||2019-11-08 10:43:40 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1764753] Review Request: rust-assert-json-diff - Easily compare two JSON values and get great output
https://bugzilla.redhat.com/show_bug.cgi?id=1764753 Igor Gnatenko changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2019-11-08 10:43:56 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1767240] Review Request: podman-compose - Run docker-compose.yml using podman
https://bugzilla.redhat.com/show_bug.cgi?id=1767240 --- Comment #14 from Yajo --- With podman-compose-0.1.5-2.git20191107.fc31.noarch.rpm that bug indeed disappeared. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1767240] Review Request: podman-compose - Run docker-compose.yml using podman
https://bugzilla.redhat.com/show_bug.cgi?id=1767240 Tomas Dabašinskas changed: What|Removed |Added CC||tomas...@gmail.com --- Comment #13 from Tomas Dabašinskas --- thanks for the package, I've installed it on f31 and aliased docker-compose=podman-compose, tried with gitea https://docs.gitea.io/en-us/install-with-docker/ works great! $ docker-compose version podman-composer version 0.1.6dev podman --version podman version 1.6.2 0 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1770147] New: Review Request: ntsclient - Golang NTS client
https://bugzilla.redhat.com/show_bug.cgi?id=1770147 Bug ID: 1770147 Summary: Review Request: ntsclient - Golang NTS client Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nob...@fedoraproject.org Reporter: sweh...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://gitlab.com/hacklunch/ntsclient/raw/v0.4.1/contrib/ntsclient.spec SRPM URL: https://gitlab.com/hacklunch/ntsclient/-/jobs/343500225/artifacts/raw/artifacts/ntsclient-v0.4.1-1.src.rpm Description: Network Time Security client in Golang, for secure NTP. Fedora Account System Username:stemid -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1769843] Review Request: low-memory-monitor - Monitors low-memory conditions
https://bugzilla.redhat.com/show_bug.cgi?id=1769843
--- Comment #5 from Bastien Nocera ---
(In reply to Michael Catanzaro from comment #4)
> %{_sysconfdir}/dbus-1/system.d/org.freedesktop.LowMemoryMonitor.conf should
> also use %config
It's not really a configuration file, and shouldn't be modified by users, or
even
administrators.
> I see you added %config for %{_sysconfdir}/low-memory-monitor.conf, but I
> would use %config(noreplace) in case the user chooses to modify it.
I would actually want the file to be replaced to automatically use the new
defaults
set in the package, rather than keep the old ones. So the current tag is
correct for
this file.
> Finally, you still have %{?systemd_requires} where systemd-rpm-macros should
> suffice.
That expands to:
%systemd_requires \
Requires(post): systemd \
Requires(preun): systemd \
Requires(postun): systemd \
%{nil}
Which I think is what we want. Or am I missing something?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1769297] Review Request: python-editdistance - Provides a fast implementation of the Levenshtein distance in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1769297
Elliott Sales de Andrade changed:
What|Removed |Added
CC||quantum.anal...@gmail.com
--- Comment #7 from Elliott Sales de Andrade ---
(In reply to Aniket Pradhan from comment #4)
> %{__python3} setup.py test copies some the python module (.so) file to the
> source directory.
You don't usually need to do that; set PYTHONPATH and/or PATH to point to the
%{buildroot} correctly, and it should work with the one you just built.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1768192] Review Request: git-secrets - Prevents committing secrets and credentials into git repos
https://bugzilla.redhat.com/show_bug.cgi?id=1768192 --- Comment #4 from Elliott Sales de Andrade --- The links you've used go to a GitHub webpage; they need to point directly to the raw file. Use the Download button on GitHub to get it. In the Makefile, PREFIX is set using ?=, which means it should only be set if undefined. So setting it on the command-line would override (or rather, skip setting) the value from the file. But you'd need to override PREFIX for both %build and %install to work. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1767918] Review Request: targetd - Revive package
https://bugzilla.redhat.com/show_bug.cgi?id=1767918 --- Comment #4 from Elliott Sales de Andrade --- Please link the spec *and* srpm directly (no .1 suffixes), or fedora-review does not work. You should use the %py3_build and %py3_install macros. https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_macros Man page extensions should be globbed. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_manpages It doesn't look like you run systemd in scriptlets, so you don't need to Require it. https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_dependencies_on_the_systemd_package -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1723052] Review Request: python-geopy - A Python client for several popular geocoding web services
https://bugzilla.redhat.com/show_bug.cgi?id=1723052
Elliott Sales de Andrade changed:
What|Removed |Added
Status|ASSIGNED|POST
Flags|fedora-review? |fedora-review+
--- Comment #6 from Elliott Sales de Andrade ---
LGTM
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: There is no build directory. Running licensecheck on vanilla
upstream sources. No licenses found. Please check the source files for
licenses manually.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[?]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Binary eggs must be removed in %prep
Note: Cannot find any build in BUILD directory (--prebuilt option?)
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[-]: Description and summary sections in the packag
