[Bug 1994678] Review Request: dirgra - Simple Directed Graph
https://bugzilla.redhat.com/show_bug.cgi?id=1994678 --- Comment #8 from Fedora Update System --- FEDORA-2021-71b8779415 has been pushed to the Fedora 33 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-71b8779415 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-71b8779415 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1977799] Review Request: classpathless-compiler - Tool for recompiling java sources with customizable class providers
https://bugzilla.redhat.com/show_bug.cgi?id=1977799 --- Comment #45 from Fedora Update System --- FEDORA-EPEL-2021-8e8965c9c0 has been pushed to the Fedora EPEL 8 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1994678] Review Request: dirgra - Simple Directed Graph
https://bugzilla.redhat.com/show_bug.cgi?id=1994678 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #7 from Fedora Update System --- FEDORA-2021-3f158ce841 has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-3f158ce841 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-3f158ce841 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1983841] Review Request: fatcat - FAT filesystems explore, extract, repair, and forensic tool
https://bugzilla.redhat.com/show_bug.cgi?id=1983841 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #8 from Fedora Update System --- FEDORA-2021-8829cca42c has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-8829cca42c \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-8829cca42c See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1953469] Review Request: R-jquerylib - Obtain jQuery as an HTML Dependency Object
https://bugzilla.redhat.com/show_bug.cgi?id=1953469 Fedora Update System changed: What|Removed |Added Resolution|--- |ERRATA Status|ON_QA |CLOSED Last Closed||2021-08-21 01:05:54 --- Comment #8 from Fedora Update System --- FEDORA-2021-6b782356d5 has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1953496] Review Request: R-bslib - Custom Bootstrap Sass Themes for shiny and rmarkdown
https://bugzilla.redhat.com/show_bug.cgi?id=1953496 Bug 1953496 depends on bug 1953469, which changed state. Bug 1953469 Summary: Review Request: R-jquerylib - Obtain jQuery as an HTML Dependency Object https://bugzilla.redhat.com/show_bug.cgi?id=1953469 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1983841] Review Request: fatcat - FAT filesystems explore, extract, repair, and forensic tool
https://bugzilla.redhat.com/show_bug.cgi?id=1983841 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #7 from Fedora Update System --- FEDORA-2021-8829cca42c has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-8829cca42c -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1991096] Review Request: python-port-for - Utility that helps with local TCP ports management
https://bugzilla.redhat.com/show_bug.cgi?id=1991096 Mikel Olasagasti Uranga changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2021-08-20 22:07:03 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1991138] Review Request: python-pytest-postgresql - pytest plugin that allows to test code that relies on a running PostgreSQL database
https://bugzilla.redhat.com/show_bug.cgi?id=1991138 Bug 1991138 depends on bug 1991096, which changed state. Bug 1991096 Summary: Review Request: python-port-for - Utility that helps with local TCP ports management https://bugzilla.redhat.com/show_bug.cgi?id=1991096 What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1991208] Review Request: pluma-plugins - Modules for the pluma text editor
https://bugzilla.redhat.com/show_bug.cgi?id=1991208 --- Comment #13 from Wolfgang Ulbrich --- Thanks for the review, let's swap to your review to continue. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1991208] Review Request: pluma-plugins - Modules for the pluma text editor
https://bugzilla.redhat.com/show_bug.cgi?id=1991208 --- Comment #12 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/pluma-plugins -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1989300] Review Request: fontawesome5-fonts - Iconic font set
https://bugzilla.redhat.com/show_bug.cgi?id=1989300 --- Comment #6 from Jerry James --- (In reply to Wolfgang Ulbrich from comment #5) > Review tool gives me an installation error. [snip] > ``` > DEBUG util.py:444: No matches found for the following disable plugin > patterns: local, spacewalk > DEBUG util.py:446: fedora 27 kB/s > | 26 kB 00:00 > DEBUG util.py:446: updates 36 kB/s > | 19 kB 00:00 > DEBUG util.py:446: result 3.0 MB/s > | 3.0 kB 00:00 > DEBUG util.py:444: Error: > DEBUG util.py:444: Problem: conflicting requests > DEBUG util.py:444:- nothing provides fontawesome5-brands-fonts = > 5.15.4-1.fc34 needed by fontawesome5-fonts-all-5.15.4-1.fc34.noarch > DEBUG util.py:444:- nothing provides fontawesome5-free-fonts = > 5.15.4-1.fc34 needed by fontawesome5-fonts-all-5.15.4-1.fc34.noarch > DEBUG util.py:446: (try to add '--skip-broken' to skip uninstallable > packages or '--nobest' to use not only best candidate packages) > ``` > > Not sure if this is an problem or a fault positive, because i can reproduce > the error with my box when i install only the 3 mentioned packages. If i > install all packages from result dir everything seems to run well. That is weird. I don't know what fedora-review is trying to do there. The fontawesome5-fonts-all package has "all" in the name for a reason: it depends on the other fonts. Which were built. So why isn't fedora-review trying to install all of them??? As you note, the packages can all be installed manually, so there is nothing wrong with the dependencies. I don't know what happened. It looks like a fedora-review bug to me. > I am also wondering that fontawesome5-brands-fonts, fontawesome5-fonts-all, > fontawesome5-free-fonts are not mentioned in spec file. What magic happened > here? :) You are seeing the magic font macros at work! The %fontpkg macro generates fontawesome5-brands-fonts and fontawesome5-free-fonts from the %global settings above (%fontfamily1, %fontsummary1, etc.), and the %fontmetapkg macro generates fontawesome5-fonts-all from the unnumbered %global settings (%fontlicense, etc.). Down below, the %fontfiles macro generates %files sections for each of those packages. Also, speaking of fedora-review bugs, it issues a couple of bogus complaints; see bug 1996210. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1991208] Review Request: pluma-plugins - Modules for the pluma text editor
https://bugzilla.redhat.com/show_bug.cgi?id=1991208 Jerry James changed: What|Removed |Added Flags|fedora-review? |fedora-review+ Status|ASSIGNED|POST --- Comment #11 from Jerry James --- All of my concerns have been addressed. This package is APPROVED. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1996204] New: Review Request: perl-Data-Properties - Enhanced Java style properties
https://bugzilla.redhat.com/show_bug.cgi?id=1996204 Bug ID: 1996204 Summary: Review Request: perl-Data-Properties - Enhanced Java style properties Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: jvrom...@squirrel.nl QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://www.squirrel.nl/pub/xfer/perl-Data-Properties.spec SRPM URL: https://www.squirrel.nl/pub/xfer/perl-Data-Properties-1.05-1.fc33.src.rpm Description: Data::Properties provides a flexible properties mechanism modeled after the Java implementation of properties. In general, a property is a string value that is associated with a key. A key is a series of names (identifiers) separated with periods. Data::Properties adds the following to the Java model: * hierarchical organization; * grouping; * conditional text substitution. Fedora Account System Username: sciurius Note: Building the RPM currently requires updated versions of two other packages. These are in the updates-testing repo and should become available in a couple of days. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1987298] Review Request: stb - Single-file public domain libraries for C/C++
https://bugzilla.redhat.com/show_bug.cgi?id=1987298 Jerry James changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #7 from Jerry James --- I think the package is fine to proceed now. This package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1981982] Review Request: biglybt - Source for BiglyBT, a feature filled, open source, ad-free, bittorrent client.
https://bugzilla.redhat.com/show_bug.cgi?id=1981982
--- Comment #5 from Didik Supriadi ---
> Issues:
> ===
> - Package uses either %{buildroot} or $RPM_BUILD_ROOT
> Note: Using both %{buildroot} and $RPM_BUILD_ROOT
> See: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_macros
You should not mix %{buildroot} and $RPM_BUILD_ROOT
See
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_using_buildroot_and_optflags_vs_rpm_build_root_and_rpm_opt_flags
> - Javadoc documentation files are generated and included in -javadoc
> subpackage
> Note: No javadoc subpackage present. Note: Javadocs are optional for
> Fedora versions >= 21
> See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation
> - Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)
> Note: No javadoc subpackage present
> See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation
There is no javadoc generation.
> = MUST items =
>
> Generic:
> [ ]: Package successfully compiles and builds into binary rpms on at least
> one supported primary architecture.
> Note: Using prebuilt packages
There is:
* org apache commons lang in core/src/ folder
* org gudy bouncycastle * in core/src/ folder
* org json simple in core/src/folder
* org eclipse swt widgets in uis/src/ folder
is that packages bundled in biglybt? they should be unbundled if possible
See https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling
> [ ]: Package must own all directories that it creates.
> Note: Directories without known owners: /usr/share/application-
> registry
Using unowned directory: /usr/share/application-registry
See
https://docs.fedoraproject.org/en-US/packaging-guidelines/UnownedDirectories/
> Rpmlint
> ---
> Checking: biglybt-2.8.0.0-1.fc36.noarch.rpm
> biglybt-2.8.0.0-1.fc36.src.rpm
> biglybt.noarch: W: spelling-error Summary(en_US) bittorrent -> bit torrent,
> bit-torrent, BitTorrent
> biglybt.src: W: spelling-error Summary(en_US) bittorrent -> bit torrent,
> bit-torrent, BitTorrent
> biglybt.noarch: W: summary-ended-with-dot C Source for BiglyBT, a feature
> filled, open source, ad-free, bittorrent client.
> biglybt.src: W: summary-ended-with-dot C Source for BiglyBT, a feature
> filled, open source, ad-free, bittorrent client.
Simply remove the trailing period from the summary field.
> biglybt.noarch: W: name-repeated-in-summary C BiglyBT
> biglybt.src: W: name-repeated-in-summary C BiglyBT
> biglybt.noarch: E: description-line-too-long C BiglyBT is forked from
> Vuze/Azureus and is being maintained by two of the original developers as
> well as members of the community.
> biglybt.src: E: description-line-too-long C BiglyBT is forked from
> Vuze/Azureus and is being maintained by two of the original developers as
> well as members of the community.
You should split your description, where each line does not exceed 80
characters.
> biglybt.noarch: W: class-path-in-manifest /usr/share/java/biglybt/BiglyBT.jar
JAR files must not include class-path entry inside META-INF/MANIFEST.MF
(See
https://docs.fedoraproject.org/en-US/packaging-guidelines/Java/#_no_class_path_in_manifest_mf)
You could remove it by using `sed -i '/class-path/I d' META-INF/MANIFEST.MF`,
for example.
> biglybt.src: W: strange-permission biglybt.desktop 775
A file that you listed in *.src.rpm has strange permissions.
Use chmod to change it.
> biglybt.src:105: W: macro-in-comment %{buildroot}
> biglybt.src:105: W: macro-in-comment %{_bindir}
Removes these comments
> 2 packages and 0 specfiles checked; 2 errors, 10 warnings.
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
[Bug 1987298] Review Request: stb - Single-file public domain libraries for C/C++
https://bugzilla.redhat.com/show_bug.cgi?id=1987298 Ben Beasley changed: What|Removed |Added Flags|needinfo?(code@musicinmybra | |in.net) | --- Comment #6 from Ben Beasley --- I have added a build conditional to cease packaging the stb_include library: > # We choose not to package the “stb_include” library (stb_include.h) because > it > # is so rife with old-school blithe C behavior—wanton use of strcat/strcpy > into > # a fixed-length buffer that is assumed (but not proven) to be large enough > for > # all possible uses, ignoring possible I/O errors (possibly leading to > # undefined behavior from reading uninitialized memory), and so on. Making it > # safe to use would mean a substantial rewrite. > # > # If a request for this library arises, this decision may be revisited, or the > # necessary rewrite may be done and offered upstream. For now, we omit the > # library and expect it will not be missed. > %bcond_with stb_include I also filed https://github.com/nothings/stb/issues/1193. I have patched some of the most serious and/or most easily fixed issues highlighted by the compiler warnings: https://github.com/nothings/stb/pull/1194 https://github.com/nothings/stb/pull/1195 https://github.com/nothings/stb/pull/1196 There are still some compiler warnings. Most are unused functions or variables—most of those related to preprocessor conditionals. Those warnings that still hint at real issues are difficult to evaluate. I filed one additional issue, https://github.com/nothings/stb/issues/1197. I am leaving this alone: > In file included from /usr/include/string.h:519, > from ../stb_ds.h:395, > from test_cpp_compilation.cpp:13: > In function 'memcpy', > inlined from 'stbi__getn(stbi__context*, unsigned char*, int)' at > ../stb_image.h:1653:16, > inlined from 'stbi__parse_png_file(stbi__png*, int, int) [clone > .constprop.0]' at ../stb_image.h:5123:28: > /usr/include/bits/string_fortified.h:29:33: warning: 'memcpy' specified bound > between 18446744071562067968 and 18446744073709551615 exceeds maximum object > size 9223372036854775807 [-Wstringop-overflow=] >29 | return __builtin___memcpy_chk (__dest, __src, __len, > | ~~~^~ >30 | __glibc_objsize0 (__dest)); > | ~~ which I *think* is pointing out that a sufficiently large 32-bit unsigned chunk length may be cast to a negative int, which is then interpreted as a huge positive number of bytes to memcpy; but whether this can actually happen in practice is much harder to tell. (I ignore here the possibility that int could be shorter than 32 bits on some platform…) In any case, I’m sure that looking closely and turning over a few rocks (i.e., compiling with clang-analyzer/scan-build, or trying to fuzz some of the libraries) could reveal dozens of similar issues in short order. Still, let me know if you think there’s anything else I should deal with before proceeding with the package. Updated spec URL: https://music.fedorapeople.org/20210819/stb.spec Updated SRPM URL: https://music.fedorapeople.org/20210819/stb-0-0.1.20210728git3a11740.fc34.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1994946] Review Request: rust-pyo3-build-config - Build configuration for the PyO3 ecosystem
https://bugzilla.redhat.com/show_bug.cgi?id=1994946 --- Comment #3 from Fabio Valentini --- Please also don't forget the usual "post-review" tasks for rust-sig packages: - request repo and f35 branch (and f34, if you need pyo3 0.14 there too), - add "@rust-sig" to the package with "commit" access, - set default bugzilla assignee to "@rust-sig" (optional), - set up release-monitoring.org for pyo3-build-config, - add package to koschei for all branches where it will be built. You can look at https://release-monitoring.org/project/141649/ for how a similar project is set up in release-monitoring.org (in particular, using "semantic" versioning option works much better for Rust projects than the other two options). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1994946] Review Request: rust-pyo3-build-config - Build configuration for the PyO3 ecosystem
https://bugzilla.redhat.com/show_bug.cgi?id=1994946 Fabio Valentini changed: What|Removed |Added Status|NEW |POST CC||decatho...@gmail.com Assignee|nob...@fedoraproject.org|decatho...@gmail.com Flags||fedora-review+ --- Comment #2 from Fabio Valentini --- Taking this review. The package was generated with rust2rpm, simplifying the review: - latest version is packaged - package builds and installs without errors on Fedora rawhide - test suite is run and all tests pass - license matches upstream specification and is acceptable for Fedora - ASL 2.0 LICENSE license file is included with %license and installed in all cases - package conforms to Rust packaging Guidelines Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1994912] Review Request: rust-aliasable - Basic aliasable (non unique pointer) types
https://bugzilla.redhat.com/show_bug.cgi?id=1994912 Fabio Valentini changed: What|Removed |Added Assignee|nob...@fedoraproject.org|decatho...@gmail.com Status|NEW |ASSIGNED Flags||fedora-review? CC||decatho...@gmail.com --- Comment #2 from Fabio Valentini --- Taking this review. Looks like one of the optional dependencies is not available on Fedora yet: Error: Problem 1: conflicting requests - nothing provides (crate(aliasable_deref_trait/default) >= 0.2.0 with crate(aliasable_deref_trait/default) < 0.3.0~) needed by rust-aliasable+aliasable_deref_trait-devel-0.1.3-1.fc36.noarch Problem 2: conflicting requests - nothing provides (crate(aliasable_deref_trait/default) >= 0.2.0 with crate(aliasable_deref_trait/default) < 0.3.0~) needed by rust-aliasable+traits-devel-0.1.3-1.fc36.noarch (try to add '--skip-broken' to skip uninstallable packages or '--nobest' to use not only best candidate packages) You'll need to either package aliasable_deref_trait 0.2.1, or drop this optional feature from rust-aliasable, if possible. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1982210] Review Request: shutter - GTK+3-based screenshot application written in Perl
https://bugzilla.redhat.com/show_bug.cgi?id=1982210 MartinKG changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2021-08-20 16:04:14 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1996107] Review Request: xmppc - A command-line interface (CLI) XMPP Client
https://bugzilla.redhat.com/show_bug.cgi?id=1996107 --- Comment #2 from Matthieu Saulnier --- copr build: rawhide/f34/f33: https://copr.fedorainfracloud.org/coprs/fantom/xmppc/build/2531144/ -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1996107] Review Request: xmppc - A command-line interface (CLI) XMPP Client
https://bugzilla.redhat.com/show_bug.cgi?id=1996107 Matthieu Saulnier changed: What|Removed |Added Depends On||1994501 Doc Type|--- |If docs needed, set a value --- Comment #1 from Matthieu Saulnier --- xmppc requires libstrophe which is currently in review RHBZ#1994501 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1994501 [Bug 1994501] Review Request: libstrophe - An XMPP library for C -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1994501] Review Request: libstrophe - An XMPP library for C
https://bugzilla.redhat.com/show_bug.cgi?id=1994501 Matthieu Saulnier changed: What|Removed |Added Blocks||1996107 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1996107 [Bug 1996107] Review Request: xmppc - A command-line interface (CLI) XMPP Client -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1996107] New: Review Request: xmppc - A command-line interface (CLI) XMPP Client
https://bugzilla.redhat.com/show_bug.cgi?id=1996107 Bug ID: 1996107 Summary: Review Request: xmppc - A command-line interface (CLI) XMPP Client Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: cas...@casperlefantom.net QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://fantom.fedorapeople.org/xmppc.spec SRPM URL: https://fantom.fedorapeople.org/xmppc-0.1.0-1.fc33.src.rpm Description: xmppc is a XMPP command line interface client. It's written in C and is using the xmpp library libstrophe. Fedora Account System Username: fantom -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1995309] Review Request: cri-tools - CLI and validation tools for Container Runtime Interface
https://bugzilla.redhat.com/show_bug.cgi?id=1995309 --- Comment #4 from Peter Hunt --- Adapted as suggested :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1982430] Review Request: python-azure-mgmt-appplatform - Microsoft Azure App Platform Management Client Library for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1982430 Major Hayden 鸞 changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |DEFERRED Last Closed||2021-08-20 14:45:31 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1983177] Review Request: python-google-resumable-media - Utilities for Google media downloads and resumable uploads
https://bugzilla.redhat.com/show_bug.cgi?id=1983177 --- Comment #1 from Major Hayden 鸞 --- Updated. Spec URL: https://download.copr.fedorainfracloud.org/results/mhayden/python-google-cloud/fedora-rawhide-x86_64/02531131-python-google-resumable-media/python-google-resumable-media.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/mhayden/python-google-cloud/fedora-rawhide-x86_64/02531131-python-google-resumable-media/python-google-resumable-media-1.3.1-1.fc36.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1983181] Review Request: python-google-cloud-storage - Python Client for Google Cloud Storage
https://bugzilla.redhat.com/show_bug.cgi?id=1983181 --- Comment #1 from Major Hayden 鸞 --- Updated. Spec URL: https://download.copr.fedorainfracloud.org/results/mhayden/python-google-cloud/fedora-rawhide-x86_64/02531132-python-google-cloud-storage/python-google-cloud-storage.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/mhayden/python-google-cloud/fedora-rawhide-x86_64/02531132-python-google-cloud-storage/python-google-cloud-storage-1.41.0-1.fc36.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1983176] Review Request: python-google-crc32c - Python wrapper for CRC32C hashing algorithm
https://bugzilla.redhat.com/show_bug.cgi?id=1983176 --- Comment #1 from Major Hayden 鸞 --- Updated. Spec URL: https://download.copr.fedorainfracloud.org/results/mhayden/python-google-cloud/fedora-rawhide-x86_64/02531055-python-google-crc32c/python-google-crc32c.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/mhayden/python-google-cloud/fedora-rawhide-x86_64/02531055-python-google-crc32c/python-google-crc32c-1.1.2-1.fc36.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1994678] Review Request: dirgra - Simple Directed Graph
https://bugzilla.redhat.com/show_bug.cgi?id=1994678 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED --- Comment #5 from Fedora Update System --- FEDORA-2021-71b8779415 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-71b8779415 --- Comment #6 from Fedora Update System --- FEDORA-2021-3f158ce841 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-3f158ce841 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1994678] Review Request: dirgra - Simple Directed Graph
https://bugzilla.redhat.com/show_bug.cgi?id=1994678 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED --- Comment #5 from Fedora Update System --- FEDORA-2021-71b8779415 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-71b8779415 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1983175] Review Request: google-crc32c - CRC32C implementation with support for CPU-specific acceleration instructions
https://bugzilla.redhat.com/show_bug.cgi?id=1983175 --- Comment #4 from Major Hayden 鸞 --- Spec URL: https://download.copr.fedorainfracloud.org/results/mhayden/python-google-cloud/fedora-rawhide-x86_64/02531054-google-crc32c/google-crc32c.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/mhayden/python-google-cloud/fedora-rawhide-x86_64/02531054-google-crc32c/google-crc32c-1.1.1-1.fc36.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1993595] Review Request: deepin-pw-check - Tool used to check password and manager the configuration for password
https://bugzilla.redhat.com/show_bug.cgi?id=1993595 --- Comment #1 from Robin Lee --- Spec URL: https://download.copr.fedorainfracloud.org/results/cheeselee/f35-deepin/fedora-rawhide-x86_64/02531113-deepin-pw-check/deepin-pw-check.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/cheeselee/f35-deepin/fedora-rawhide-x86_64/02531113-deepin-pw-check/deepin-pw-check-5.0.22-1.fc36.src.rpm Changes: - new release 5.0.22 - BR: make -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1991208] Review Request: pluma-plugins - Modules for the pluma text editor
https://bugzilla.redhat.com/show_bug.cgi?id=1991208 --- Comment #10 from Wolfgang Ulbrich --- SPEC and SRPM are updated. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1991208] Review Request: pluma-plugins - Modules for the pluma text editor
https://bugzilla.redhat.com/show_bug.cgi?id=1991208 --- Comment #9 from Wolfgang Ulbrich --- See https://github.com/mate-desktop/pluma-plugins/issues/26#issuecomment-902608903 I will remove the shebang from atril_dbus.py and update SPEC file. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1993592] Review Request: dtkcommon - DTK common files
https://bugzilla.redhat.com/show_bug.cgi?id=1993592 --- Comment #3 from Robin Lee --- The specfile is actually the same in src.rpm. I am still new to rpmautospec. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1993592] Review Request: dtkcommon - DTK common files
https://bugzilla.redhat.com/show_bug.cgi?id=1993592 Robin Lee changed: What|Removed |Added Flags|needinfo?(robinlee.sysu@gma | |il.com) | --- Comment #2 from Robin Lee --- Spec URL: https://cheeselee.fedorapeople.org/dtkcommon.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/cheeselee/f35-deepin/fedora-rawhide-x86_64/02531032-dtkcommon/dtkcommon-5.5.17-1.fc36.src.rpm Changes: - Changed to rpmautospec, so the specfile in src.rpm is different. - BR: gcc-c++, make - the source downloaded tarball directly from upstream - Changed %%define to %%global -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1995266] Review Request: python-mirrors-countme - scripts to create repository access statistics
https://bugzilla.redhat.com/show_bug.cgi?id=1995266 Nils Philippsen changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #5 from Nils Philippsen --- The changes look good, the package is APPROVED. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1989300] Review Request: fontawesome5-fonts - Iconic font set
https://bugzilla.redhat.com/show_bug.cgi?id=1989300 --- Comment #5 from Wolfgang Ulbrich --- Review tool gives me an installation error. ``` Installation errors --- INFO: mock.py version 2.12 starting (python version = 3.9.6, NVR = mock-2.12-1.fc34)... Start: init plugins INFO: selinux disabled Finish: init plugins INFO: Signal handler active Start: run Start: chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled package manager cache Start: cleaning package manager metadata Finish: cleaning package manager metadata INFO: enabled HW Info plugin Mock Version: 2.12 INFO: Mock Version: 2.12 Finish: chroot init INFO: installing package(s): /home/rave/fontawesome5-fonts/results/fontawesome5-fonts-all-5.15.4-1.fc34.noarch.rpm /home/rave/fontawesome5-fonts/results/fontawesome5-fonts-web-5.15.4-1.fc34.noarch.rpm /home/rave/fontawesome5-fonts/results/fontawesome5-fonts-5.15.4-1.fc34.noarch.rpm ERROR: Command failed: # /usr/bin/dnf --installroot /home/rave//fedora-34-x86_64/root/ --releasever 34 --setopt=deltarpm=False --allowerasing --disableplugin=local --disableplugin=spacewalk --disableplugin=versionlock install /home/rave/fontawesome5-fonts/results/fontawesome5-fonts-all-5.15.4-1.fc34.noarch.rpm /home/rave/fontawesome5-fonts/results/fontawesome5-fonts-web-5.15.4-1.fc34.noarch.rpm /home/rave/fontawesome5-fonts/results/fontawesome5-fonts-5.15.4-1.fc34.noarch.rpm ``` see ~/fontawesome5-fonts/results/root.log ``` DEBUG util.py:444: No matches found for the following disable plugin patterns: local, spacewalk DEBUG util.py:446: fedora 27 kB/s | 26 kB 00:00 DEBUG util.py:446: updates 36 kB/s | 19 kB 00:00 DEBUG util.py:446: result 3.0 MB/s | 3.0 kB 00:00 DEBUG util.py:444: Error: DEBUG util.py:444: Problem: conflicting requests DEBUG util.py:444:- nothing provides fontawesome5-brands-fonts = 5.15.4-1.fc34 needed by fontawesome5-fonts-all-5.15.4-1.fc34.noarch DEBUG util.py:444:- nothing provides fontawesome5-free-fonts = 5.15.4-1.fc34 needed by fontawesome5-fonts-all-5.15.4-1.fc34.noarch DEBUG util.py:446: (try to add '--skip-broken' to skip uninstallable packages or '--nobest' to use not only best candidate packages) ``` Not sure if this is an problem or a fault positive, because i can reproduce the error with my box when i install only the 3 mentioned packages. If i install all packages from result dir everything seems to run well. ``` [root@mother results]# ls build.log fontawesome5-brands-fonts-5.15.4-1.fc34.noarch.rpm fontawesome5-fonts-5.15.4-1.fc34.noarch.rpm fontawesome5-fonts-5.15.4-1.fc34.src.rpm fontawesome5-fonts-all-5.15.4-1.fc34.noarch.rpm fontawesome5-fonts-web-5.15.4-1.fc34.noarch.rpm fontawesome5-free-fonts-5.15.4-1.fc34.noarch.rpm hw_info.log installed_pkgs.log repodata root.log state.log [root@mother results]# [root@mother results]# [root@mother results]# [root@mother results]# dnf install fontawesome5-fonts-all-5.15.4-1.fc34.noarch.rpm fontawesome5-fonts-web-5.15.4-1.fc34.noarch.rpm fontawesome5-fonts-5.15.4-1.fc34.noarch.rpm Last metadata expiration check: 2:39:26 ago on Fri Aug 20 12:44:06 2021. Error: Problem: conflicting requests - nothing provides fontawesome5-brands-fonts = 5.15.4-1.fc34 needed by fontawesome5-fonts-all-5.15.4-1.fc34.noarch - nothing provides fontawesome5-free-fonts = 5.15.4-1.fc34 needed by fontawesome5-fonts-all-5.15.4-1.fc34.noarch (try to add '--skip-broken' to skip uninstallable packages) [root@mother results]# [root@mother results]# [root@mother results]# [root@mother results]# dnf install fontawesome5-brands-fonts-5.15.4-1.fc34.noarch.rpm fontawesome5-fonts-5.15.4-1.fc34.noarch.rpm fontawesome5-fonts-all-5.15.4-1.fc34.noarch.rpm fontawesome5-fonts-web-5.15.4-1.fc34.noarch.rpm fontawesome5-free-fonts-5.15.4-1.fc34.noarch.rpm Last metadata expiration check: 2:40:16 ago on Fri Aug 20 12:44:06 2021. Dependencies resolved. Package Arch Version Repository Size Installing: fontawesome5-brands-fontsnoarch5.15.4-1.fc34 @commandline244 k fontawesome5-fonts noarch5.15.4-1.fc34 @commandline566 k fontawesome5-fonts-all noarch5.15.4-1.fc34 @commandline6.2 k fontawesome5-fonts-web noarch5.15.4-1.fc34 @commandline716 k fontawesome5-free-fonts noarch5.15.4-1.fc34 @commandline284 k Transaction Summary Install 5 Packages Total size: 1.8 M Installed size: 13 M Is this ok [y/N]: n Operation aborted. ``` I am also wondering that fontawesome5-brands-fonts, fontawesome5-fonts-all,
[Bug 1995266] Review Request: python-mirrors-countme - scripts to create repository access statistics
https://bugzilla.redhat.com/show_bug.cgi?id=1995266
--- Comment #4 from Nils Philippsen ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin,
[Bug 1994678] Review Request: dirgra - Simple Directed Graph
https://bugzilla.redhat.com/show_bug.cgi?id=1994678 --- Comment #4 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/dirgra -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1983841] Review Request: fatcat - FAT filesystems explore, extract, repair, and forensic tool
https://bugzilla.redhat.com/show_bug.cgi?id=1983841 --- Comment #6 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/fatcat -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1990685] Review Request: cpp-httplib - A C++11 single-file header-only cross platform HTTP/HTTPS library
https://bugzilla.redhat.com/show_bug.cgi?id=1990685 --- Comment #8 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/cpp-httplib -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1995266] Review Request: python-mirrors-countme - scripts to create repository access statistics
https://bugzilla.redhat.com/show_bug.cgi?id=1995266 --- Comment #3 from Adam Saleh --- Spec URL: https://asaleh.fedorapeople.org/python-mirrors-countme.spec SRPM URL: https://asaleh.fedorapeople.org/python-mirrors-countme-0.0.5-1.fc34.src.rpm Description: A python module and scripts for parsing httpd access_log to find requests including `countme=N`, parse the data included with those requests, and compile weekly counts of DNF clients broken out by OS name, OS version, system arch, etc. Fedora Account System Username: asaleh -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1991208] Review Request: pluma-plugins - Modules for the pluma text editor
https://bugzilla.redhat.com/show_bug.cgi?id=1991208 --- Comment #8 from Wolfgang Ulbrich --- Opps, i silently replaced SRPM and SPEC file to avoid version bumping. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1991208] Review Request: pluma-plugins - Modules for the pluma text editor
https://bugzilla.redhat.com/show_bug.cgi?id=1991208
--- Comment #7 from Wolfgang Ulbrich ---
Thank you for taking the review.
(In reply to Jerry James from comment #4)
> (In reply to Wolfgang Ulbrich from comment #2)
>
> Package Review
> ==
>
> Legend:
> [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
>
> Issues:
> ===
> - In a multiple licensing scenario, the license breakdown must be described:
> https://docs.fedoraproject.org/en-US/packaging-guidelines/
> LicensingGuidelines/#_multiple_licensing_scenarios
>
> In this case, what is licensed LGPLv2+? I only see the GPLv2+ in play.
Done.
>
> - Add "%license COPYING" to %files.
Done.
>
> - Note that Provides have been generated for two of the plugins:
>
> libbookmarks.so()(64bit)
> libwordcompletion.so()(64bit)
>
> Since they are in a private subdirectory of %{_libdir}, I don't think this
> is
> right. Something like this in this specfile should prevent it:
>
> %global __provides_exclude_from ^%{_libdir}/pluma/plugins
Done.
>
> - In %build, use "%make_build V=1" instead of the explicit make invocation.
> See
> https://docs.fedoraproject.org/en-US/packaging-guidelines/#_parallel_make
Done.
>
> - Look at the first item under "EXTRA items" below. Is it possible to make
> a noarch subpackage to hold most or all of the files under /usr/share?
I moved all files exept libs, gsettings and metainfo files to
pluma-plugins-data
>
> - Note the unused-direct-shlib-dependency warnings in the rpmlint section
> below.
> That indicates that this project has run afoul of a long-standing libtool
> bug:
> it reorders -Wl,--as-needed *after* the libraries to be linked against,
> rendering it useless. I usually put this between %configure and
> %make_build
> for projects that use libtool:
>
> # Get rid of undesirable hardcoded rpaths; workaround libtool reordering
> # -Wl,--as-needed after all the libraries.
> sed -e 's|^hardcode_libdir_flag_spec=.*|hardcode_libdir_flag_spec=""|g' \
> -e 's|^runpath_var=LD_RUN_PATH|runpath_var=DIE_RPATH_DIE|g' \
> -e 's|CC="\(.*g..\)"|CC="\1 -Wl,--as-needed"|' \
> -i libtool
>
> If you don't have rpath problems, then the 3rd sed expression may be all
> you need.
Done.
Anything left?
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
[Bug 1953340] Review Request: dovecot-fts-xapian - Xapian plugin for Dovecot
https://bugzilla.redhat.com/show_bug.cgi?id=1953340 --- Comment #10 from Joan Moreau --- ANyone can help to push this RPM into the reps ? thank you -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1991208] Review Request: pluma-plugins - Modules for the pluma text editor
https://bugzilla.redhat.com/show_bug.cgi?id=1991208 --- Comment #6 from Wolfgang Ulbrich --- I started a discussion about shebang of atril_dbus.py at upstream. https://github.com/mate-desktop/pluma-plugins/issues/26#issuecomment-902566790 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1995266] Review Request: python-mirrors-countme - scripts to create repository access statistics
https://bugzilla.redhat.com/show_bug.cgi?id=1995266 --- Comment #2 from Adam Saleh --- Uploaded a new srpm, without the excessive test-data. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1988280] Review Request: rust-compress-tools - Utility functions for compressed and archive files handling
https://bugzilla.redhat.com/show_bug.cgi?id=1988280 Petr Pisar changed: What|Removed |Added CC||ppi...@redhat.com Flags|fedora-review? | --- Comment #1 from Petr Pisar --- Daiki, the fedora-review flag is expected to be set to "?" by a reviewer when he starts with the review. Not by the package submitter. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1938451] Review Request: stellarsolver - The Cross Platform Sextractor and Internal Astrometric Solver
https://bugzilla.redhat.com/show_bug.cgi?id=1938451 Petr Pisar changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1991208] Review Request: pluma-plugins - Modules for the pluma text editor
https://bugzilla.redhat.com/show_bug.cgi?id=1991208 --- Comment #5 from Wolfgang Ulbrich --- (In reply to Yaakov Selkowitz from comment #3) > Since I started this just before it was taken, I'll add this as an informal > review. > > > > Package Review > == > > Legend: > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated > [ ] = Manual review needed > > > Issues: > === > - Packages MUST NOT have dependencies (either build-time or runtime) on > packages named with the unversioned python- prefix unless no properly > versioned package exists. Dependencies on Python packages instead MUST > use names beginning with python2- or python3- as appropriate. > Note: Unversionned Python dependency found. > See: https://docs.fedoraproject.org/en-US/packaging- > guidelines/Python/#_dependencies I saw that for myself in fedora review tool. But which dependency does have a unversioned python- prefix ? > - Should atril_dbus.py really have a shebang at all? > IOW instead of fixing the shebang, should it just be removed? As i understand this plugin the file needs to be executable to connect with atril document viewer. > - why is the license "or LGPLv2+"? Nothing LGPL shows up in the license > check. will be fixed > - no %license or %doc in %files will be fixed -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1992931] Review Request: rubygem-image_size - Measure image size using pure Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=1992931 --- Comment #8 from Mamoru TASAKA --- Thank you!! By the way, FYI I debugged out s390x issue: https://github.com/toy/image_size/pull/16 : I will include this patch. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1901665] Review Request: box86 - Linux Userspace x86 Emulator
https://bugzilla.redhat.com/show_bug.cgi?id=1901665 Nicolas Chauvet (kwizart) changed: What|Removed |Added Flags|needinfo?(kwiz...@gmail.com | |) | --- Comment #11 from Nicolas Chauvet (kwizart) --- > Ping. What's the state here? As my initially another review request was > overwhelmed with this one any progress would be nice. Packaging is clean on the packaging wide.IMO. Only usability is to be proven. See next. > The only issue remains that to translate x86 linux binaries for arm, there is > a need to install some x86 dependencies on the host. And if using fedora > packages, then there is a path clash to be expected. (as x86 and arm > libraries are using the same /usr/lib/ path). So this package looks very > complex to use on the fedora side. (unless using x86 binary with only a deps > on libc++). I only expect to build a dedicated chroot with x86 libraries and libstdc++ replaced by box86... This runtime test need to be proven for the package to be usable at all. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1992931] Review Request: rubygem-image_size - Measure image size using pure Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=1992931 Jarek Prokop changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #7 from Jarek Prokop --- LGTM. Package approved. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
