[Bug 1005172] Review Request: python-llvmpy - Python bindings for LLVM
https://bugzilla.redhat.com/show_bug.cgi?id=1005172 Sergio Pascual sergio.pa...@gmail.com changed: What|Removed |Added CC|package-review@lists.fedora | |project.org | Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2013-09-12 06:55:19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=OWPStYK247a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1005172] Review Request: python-llvmpy - Python bindings for LLVM
https://bugzilla.redhat.com/show_bug.cgi?id=1005172
--- Comment #4 from Sergio Pascual sergio.pa...@gmail.com ---
Hi, thanks for the review. I have added the test in check.
The documentation is small, less than 300k, so for the moment I don't think we
need a -doc subpackage.
Regarding the name, there was an exception for python packages having a py in
the name, they could remain with their name. But the exception was removed so
now all python packages need to follow python-%{name} rule.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=mmcK0qmXGfa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1005172] Review Request: python-llvmpy - Python bindings for LLVM
https://bugzilla.redhat.com/show_bug.cgi?id=1005172 Sergio Pascual sergio.pa...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #5 from Sergio Pascual sergio.pa...@gmail.com --- New Package SCM Request === Package Name: python-llvmpy Short Description: Python bindings for LLVM Owners: sergiopr Branches: f18 f19 f20 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5umm2JV0o6a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1005172] Review Request: python-llvmpy - Python bindings for LLVM
https://bugzilla.redhat.com/show_bug.cgi?id=1005172 --- Comment #6 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=iaGEDUheaea=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1005172] Review Request: python-llvmpy - Python bindings for LLVM
https://bugzilla.redhat.com/show_bug.cgi?id=1005172 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=xmFv5SdA6Oa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1005172] Review Request: python-llvmpy - Python bindings for LLVM
https://bugzilla.redhat.com/show_bug.cgi?id=1005172 Christopher Meng cicku...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|cicku...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=iS2DQTzx21a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1005172] Review Request: python-llvmpy - Python bindings for LLVM
https://bugzilla.redhat.com/show_bug.cgi?id=1005172
Christopher Meng cicku...@gmail.com changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #1 from Christopher Meng cicku...@gmail.com ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Large documentation must go in a -doc subpackage. Large could be size (~1MB)
or number of files.
Note: Documentation size is 2416640 bytes in 171 files.
See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation
Rpmlint
---
Checking: python-llvmpy-0.12.0-1.fc20.i686.rpm
python-llvmpy-0.12.0-1.fc20.src.rpm
python-llvmpy.src: W: spelling-error %description -l en_US llvm - llama
2 packages and 0 specfiles checked; 0 errors, 1 warnings.
-- Ignorable
Provides
python-llvmpy:
python-llvmpy
python-llvmpy(x86-32)
Unversioned so-files
python-llvmpy: /usr/lib/python2.7/site-packages/llvmpy/_api.so
python-llvmpy: /usr/lib/python2.7/site-packages/llvmpy/_capsule.so
-- Ignorable
Generated by fedora-review 0.5.0 (920221d) last change: 2013-08-30
Command line :/usr/bin/fedora-review -rvn python-llvmpy-0.12.0-1.fc19.src.rpm
Buildroot used: fedora-rawhide-i386
Active plugins: Generic, Python, Shell-api, C/C++
Disabled plugins: Java, SugarActivity, Perl, R, PHP, Ruby
Disabled flags: EPEL5, EXARCH, DISTTAG
***
APPROVED.
Suggestions:
1. %{buildroot}/%{python_sitearch} can be %{buildroot}%{python_sitearch}
2. Source can be Source0
3. Is it possible to use llvmpy as its %{name}? I think upstream won't release
2 version for py2 and py3 in parallel.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=cwLJ439IDXa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1005172] Review Request: python-llvmpy - Python bindings for LLVM
https://bugzilla.redhat.com/show_bug.cgi?id=1005172 --- Comment #2 from Christopher Meng cicku...@gmail.com --- Also if you think -doc is needed, please add -doc subpackage. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=sAd5V4gVy5a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1005172] Review Request: python-llvmpy - Python bindings for LLVM
https://bugzilla.redhat.com/show_bug.cgi?id=1005172 --- Comment #3 from Christopher Meng cicku...@gmail.com --- Also again(sorry), I just checked documentation of llvmpy and found: python -c import llvm; llvm.test() is used for simple test, is it possible for you to add it into %check? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=i2aR6ojXrOa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
