[Bug 1059708] Review Request: phodav - a WebDAV server using libsoup
https://bugzilla.redhat.com/show_bug.cgi?id=1059708 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||phodav-0.4-1.fc20 Resolution|--- |ERRATA Last Closed||2014-04-24 03:38:55 --- Comment #25 from Fedora Update System upda...@fedoraproject.org --- phodav-0.4-1.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1059708] Review Request: phodav - a WebDAV server using libsoup
https://bugzilla.redhat.com/show_bug.cgi?id=1059708 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #24 from Fedora Update System upda...@fedoraproject.org --- phodav-0.4-1.fc20 has been pushed to the Fedora 20 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1059708] Review Request: phodav - a WebDAV server using libsoup
https://bugzilla.redhat.com/show_bug.cgi?id=1059708 Marc-Andre Lureau marcandre.lur...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #21 from Marc-Andre Lureau marcandre.lur...@redhat.com --- New Package SCM Request === Package Name: phodav Short Description: A WebDAV server using libsoup Owners: elmarco Branches: f20 el6 epel7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1059708] Review Request: phodav - a WebDAV server using libsoup
https://bugzilla.redhat.com/show_bug.cgi?id=1059708 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1059708] Review Request: phodav - a WebDAV server using libsoup
https://bugzilla.redhat.com/show_bug.cgi?id=1059708 --- Comment #22 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1059708] Review Request: phodav - a WebDAV server using libsoup
https://bugzilla.redhat.com/show_bug.cgi?id=1059708 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|NEW |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1059708] Review Request: phodav - a WebDAV server using libsoup
https://bugzilla.redhat.com/show_bug.cgi?id=1059708 --- Comment #23 from Fedora Update System upda...@fedoraproject.org --- phodav-0.4-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/phodav-0.4-1.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1059708] Review Request: phodav - a WebDAV server using libsoup
https://bugzilla.redhat.com/show_bug.cgi?id=1059708 --- Comment #19 from Marc-Andre Lureau marcandre.lur...@redhat.com --- (In reply to Michael Scherer from comment #17) The issue with chezdav not distributing license still stand. ( i, please add the license in %doc ). I am doing a scratch build to test it. but the license is distributed in libphodav dependency, that's not enough? anyway, spec updated: http://elmarco.fedorapeople.org/phodav.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1059708] Review Request: phodav - a WebDAV server using libsoup
https://bugzilla.redhat.com/show_bug.cgi?id=1059708 Michael Scherer m...@zarb.org changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #20 from Michael Scherer m...@zarb.org --- Indeed, didn't see it. So that close the latest issue, so approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1059708] Review Request: phodav - a WebDAV server using libsoup
https://bugzilla.redhat.com/show_bug.cgi?id=1059708 --- Comment #17 from Michael Scherer m...@zarb.org --- The issue with chezdav not distributing license still stand. ( i, please add the license in %doc ). I am doing a scratch build to test it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1059708] Review Request: phodav - a WebDAV server using libsoup
https://bugzilla.redhat.com/show_bug.cgi?id=1059708 --- Comment #18 from Michael Scherer m...@zarb.org --- And chezdav is working ( or at least, not crashing ). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1059708] Review Request: phodav - a WebDAV server using libsoup
https://bugzilla.redhat.com/show_bug.cgi?id=1059708 --- Comment #16 from Michael Scherer m...@zarb.org --- Yup, it can be done later, we can discuss that IRL next time. I will try to check the package before next week, but it should be quite quick and just a formality. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1059708] Review Request: phodav - a WebDAV server using libsoup
https://bugzilla.redhat.com/show_bug.cgi?id=1059708 --- Comment #15 from Marc-Andre Lureau marcandre.lur...@redhat.com --- and it should also be announced over avahi -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1059708] Review Request: phodav - a WebDAV server using libsoup
https://bugzilla.redhat.com/show_bug.cgi?id=1059708 --- Comment #13 from Michael Scherer m...@zarb.org --- The daemon exits whenever a client is disconnected. It must be restarted after. then i guess it would be a perfect candidate for socket-activation. I will take a look and maybe submit a patch. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1059708] Review Request: phodav - a WebDAV server using libsoup
https://bugzilla.redhat.com/show_bug.cgi?id=1059708 --- Comment #14 from Marc-Andre Lureau marcandre.lur...@redhat.com --- (In reply to Michael Scherer from comment #13) The daemon exits whenever a client is disconnected. It must be restarted after. then i guess it would be a perfect candidate for socket-activation. I will take a look and maybe submit a patch. I guess that could work. But don't forget it also has a virtio port dependency. I wonder if systemd supports this complex condition. Could we leave that for a future update? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1059708] Review Request: phodav - a WebDAV server using libsoup
https://bugzilla.redhat.com/show_bug.cgi?id=1059708
Michael Scherer m...@zarb.org changed:
What|Removed |Added
Assignee|nob...@fedoraproject.org|m...@zarb.org
Flags||fedora-review?
--- Comment #11 from Michael Scherer m...@zarb.org ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
- License should be installed if I do yum install chezdav, which is not
the case
- There is unowned directory, see the report ( /usr/include/libphodav-1.0 )
- Spec file in the srpm and on the web differn which confuse Fedora review,
please
upgrade the file ( and the url of the tarball still speak of 0.1 despites being
0.3 ).
- why is spice-webdavd is restarted by default ?
- chezdav is not working :
$ type chezdav
chezdav is /usr/bin/chezdav
$ chezdav
/usr/bin/chezdav: error: `/usr/bin/.libs/chezdav' does not exist
This script is just a wrapper for chezdav.
See the libtool documentation for more information.
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
LGPL (v2.1 or later), LGPL, GPL (v2 or later), Unknown or
generated. 1 files have unknown license. Detailed output of licensecheck
in /home/misc/checkout/git/FedoraReview/1059708-phodav/licensecheck.txt
[!]: License file installed when any subpackage combination is installed.
[!]: Package requires other packages for directories it uses.
Note: No known owner of /usr/include/libphodav-1.0, /usr/share/gtk-
doc/html/phodav
[!]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/include/libphodav-1.0,
/usr/share/gtk-doc, /usr/share/gtk-doc/html, /usr/share/gtk-
doc/html/phodav
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 61440 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not
[Bug 1059708] Review Request: phodav - a WebDAV server using libsoup
https://bugzilla.redhat.com/show_bug.cgi?id=1059708
--- Comment #12 from Marc-Andre Lureau marcandre.lur...@redhat.com ---
(In reply to Michael Scherer from comment #11)
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
- License should be installed if I do yum install chezdav, which is not
the case
- There is unowned directory, see the report ( /usr/include/libphodav-1.0 )
I added
%dir %{_includedir}/libphodav-1.0/
- Spec file in the srpm and on the web differn which confuse Fedora review,
please
upgrade the file ( and the url of the tarball still speak of 0.1 despites
being
0.3 ).
Yeah, I updated only the spec when I saw the URL was outdated.
- why is spice-webdavd is restarted by default ?
The daemon exits whenever a client is disconnected. It must be restarted after.
- chezdav is not working :
$ type chezdav
chezdav is /usr/bin/chezdav
$ chezdav
/usr/bin/chezdav: error: `/usr/bin/.libs/chezdav' does not exist
This script is just a wrapper for chezdav.
See the libtool documentation for more information.
Most of those errors come from the disable-fast-install flag, which screwed up
relinking and dependency generation. Now fixed in 0.3.1
http://elmarco.fedorapeople.org/phodav-0.3.1-1.fc20.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1059708] Review Request: phodav - a WebDAV server using libsoup
https://bugzilla.redhat.com/show_bug.cgi?id=1059708 --- Comment #9 from Marc-Andre Lureau marcandre.lur...@redhat.com --- (In reply to Christopher Meng from comment #8) 1. Where did your source come from? From https://download.gnome.org/sources/phodav/ (I am upstream dev/maintainer) 2. Have you read this carefully? https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd No, what should I know? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1059708] Review Request: phodav - a WebDAV server using libsoup
https://bugzilla.redhat.com/show_bug.cgi?id=1059708 --- Comment #10 from Marc-Andre Lureau marcandre.lur...@redhat.com --- Package updated with 0.3 release, now upstream provides a public library. http://elmarco.fedorapeople.org/phodav-0.3-1.fc20.src.rpm copr fails temporarily with rawhide, but f20 packages are ok: http://copr-be.cloud.fedoraproject.org/results/elmarco/phodav/fedora-20-x86_64/phodav-0.3-1.fc20/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1059708] Review Request: phodav - a WebDAV server using libsoup
https://bugzilla.redhat.com/show_bug.cgi?id=1059708 --- Comment #8 from Christopher Meng cicku...@gmail.com --- 1. Where did your source come from? 2. Have you read this carefully? https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1059708] Review Request: phodav - a WebDAV server using libsoup
https://bugzilla.redhat.com/show_bug.cgi?id=1059708 --- Comment #7 from Marc-Andre Lureau marcandre.lur...@redhat.com --- hey hi hey ho -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1059708] Review Request: phodav - a WebDAV server using libsoup
https://bugzilla.redhat.com/show_bug.cgi?id=1059708 --- Comment #6 from Marc-Andre Lureau marcandre.lur...@redhat.com --- Hi Michael, I updated the spec, a copr build is also available here: https://copr.fedoraproject.org/coprs/elmarco/phodav/ thanks! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1059708] Review Request: phodav - a WebDAV server using libsoup
https://bugzilla.redhat.com/show_bug.cgi?id=1059708
--- Comment #5 from Michael Scherer m...@zarb.org ---
Why does the %post speak ofspice-vdagentd.service while the %files speak of
%{_unitdir}/spice-webdavd.service ?
Also, why do you need a target for systemd ?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1059708] Review Request: phodav - a WebDAV server using libsoup
https://bugzilla.redhat.com/show_bug.cgi?id=1059708
--- Comment #4 from Marc-Andre Lureau marcandre.lur...@redhat.com ---
(In reply to Michael Scherer from comment #3)
Also :
- BuildRoot is no longer needed
- %clean
rm -rf %{buildroot} , the rm at start of install and %defattr are also
uneeded for newer fedora
- chezdav and the spice subpackage do have the same summary
ok
- there is no service file, while this is a daemon
added, but for some reasons, the daemon is not enabled automatically (although
it seems to work for vdagent), I am trying to figure out...
- the spice subpackage should have the lciense in %doc as well, since it can
be install without pulling chezdav
ok
See last update
Spec URL: http://elmarco.fedorapeople.org/phodav.spec
elmarco@anakao:~/pkg/phodav (master #%)$ rpmlint phodav.spec
~/rpmbuild/RPMS/x86_64/phodav-*
phodav-chezdav.x86_64: W: spelling-error %description -l en_US mDNS - mans,
mdse
phodav-spice.x86_64: W: spelling-error %description -l en_US virtio - virtuoso
phodav-spice.x86_64: W: only-non-binary-in-usr-lib
phodav-spice.x86_64: W: no-manual-page-for-binary spice-webdavd
3 packages and 1 specfiles checked; 0 errors, 4 warnings.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1059708] Review Request: phodav - a WebDAV server using libsoup
https://bugzilla.redhat.com/show_bug.cgi?id=1059708 --- Comment #1 from Marc-Andre Lureau marcandre.lur...@redhat.com --- elmarco@anakao:~/pkg/phodav (master #%)$ rpmlint phodav.spec /home/elmarco/rpmbuild/RPMS/x86_64/phodav-* phodav.x86_64: W: spelling-error Summary(en_US) libsoup - lib soup, lib-soup, libelous phodav.x86_64: W: spelling-error %description -l en_US phởdav phodav.x86_64: W: spelling-error %description -l en_US libsoup - lib soup, lib-soup, libelous phodav.x86_64: W: no-manual-page-for-binary chezdav phodav-chezdav.x86_64: W: spelling-error %description -l en_US virtio - virtuoso phodav-chezdav.x86_64: W: no-manual-page-for-binary chezdav phodav-spice.x86_64: W: spelling-error %description -l en_US virtio - virtuoso phodav-spice.x86_64: W: no-documentation phodav-spice.x86_64: W: no-manual-page-for-binary spice-webdavd 4 packages and 1 specfiles checked; 0 errors, 9 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1059708] Review Request: phodav - a WebDAV server using libsoup
https://bugzilla.redhat.com/show_bug.cgi?id=1059708 Michael Scherer m...@zarb.org changed: What|Removed |Added CC||m...@zarb.org --- Comment #2 from Michael Scherer m...@zarb.org --- Mhh, it doesn't build on F20 : checking whether NLS is requested... yes ./configure: line 12254: intltool-update: command not found checking for intltool = 0.40.0... found configure: error: Your intltool is too old. You need intltool 0.40.0 or later. erreur : Mauvais statut de sortie pour /var/tmp/rpm-tmp.MgeUdM (%build) Mauvais statut de sortie pour /var/tmp/rpm-tmp.MgeUdM (%build) Erreur de construction de RPM : Seems to be missing a BR, like intltool -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1059708] Review Request: phodav - a WebDAV server using libsoup
https://bugzilla.redhat.com/show_bug.cgi?id=1059708
--- Comment #3 from Michael Scherer m...@zarb.org ---
Also :
- BuildRoot is no longer needed
- %clean
rm -rf %{buildroot} , the rm at start of install and %defattr are also uneeded
for newer fedora
- chezdav and the spice subpackage do have the same summary
- there is no service file, while this is a daemon
- the spice subpackage should have the lciense in %doc as well, since it can be
install without pulling chezdav
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
