[Bug 1109717] Review Request: python-evtx - Windows Event Log parsing library and tools

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1109717

Richard W.M. Jones  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |WONTFIX
Last Closed||2018-03-23 07:07:30



--- Comment #12 from Richard W.M. Jones  ---
I'm going to close this as I don't have time or interest to
fix the request for Python 3 etc.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1109717] Review Request: python-evtx - Windows Event Log parsing library and tools

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1109717



--- Comment #11 from Itamar Reis Peixoto  ---
some people are talking about retiring python2 in rawhide, do you have a new
version compatible with python3 ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1109717] Review Request: python-evtx - Windows Event Log parsing library and tools

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1109717

Itamar Reis Peixoto  changed:

   What|Removed |Added

 CC||ita...@ispbrasil.com.br



--- Comment #10 from Itamar Reis Peixoto  ---
[itamar@lenovo fedora]$ python -c "from distutils.sysconfig import
get_python_lib; print (get_python_lib())"
/usr/lib/python2.7/site-packages

[itamar@lenovo fedora]$ rpm -E '%{python2_sitelib}'
/usr/lib/python2.7/site-packages

[itamar@lenovo fedora]$ rpm -E '%{python3_sitelib}'
/usr/lib/python3.6/site-packages


I think you probably should use %{python2_sitelib} / %{python3_sitelib} macros,
they are already defined.

I saw a guy defining a macro for description and using it instead of repeating
it, an small example here ->
https://itamarjp.fedorapeople.org/review/python-flask-sphinx-themes.spec, if
you do that your spec file will become smaller.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1109717] Review Request: python-evtx - Windows Event Log parsing library and tools

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1109717

Orion Poplawski  changed:

   What|Removed |Added

 CC||or...@cora.nwra.com



--- Comment #9 from Orion Poplawski  ---
Looks like 0.5.3 is out now.  Update to that and current guidelines and I'll
review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1109717] Review Request: python-evtx - Windows Event Log parsing library and tools

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1109717



--- Comment #8 from Richard W.M. Jones rjo...@redhat.com ---
http://oirase.annexia.org/reviews/python-evtx/
http://oirase.annexia.org/reviews/python-evtx/python-evtx.spec
http://oirase.annexia.org/reviews/python-evtx/python-evtx-0.3.2-0.1.20140326git8838756.src.rpm

Updated with the suggestions from comment 7.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1109717] Review Request: python-evtx - Windows Event Log parsing library and tools

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1109717

Dmitry Tantsur divius.ins...@gmail.com changed:

   What|Removed |Added

 CC||divius.ins...@gmail.com



--- Comment #7 from Dmitry Tantsur divius.ins...@gmail.com ---
Hi!

1. BuildRequires:  python
should be 
BuildRequires:  python2-devel

2. find Evtx -name '*.py' | xargs sed -i '/\/usr\/bin\/python/d'
I think it would be better to check for shebang only, something like:
| xargs sed -i ''/^#!.*\/python/d'

3. Why not use summary and description from package's setup.py?
https://github.com/williballenthin/python-evtx/blob/master/setup.py
Also I think in Programming documentation for %{name} using full summary of
the base package would be more helpful for a user.


Newer build for reference:
http://koji.fedoraproject.org/koji/taskinfo?taskID=7811652

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1109717] Review Request: python-evtx - Windows Event Log parsing library and tools

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1109717

Antonio Trande anto.tra...@gmail.com changed:

   What|Removed |Added

 CC||anto.tra...@gmail.com



--- Comment #6 from Antonio Trande anto.tra...@gmail.com ---
I think there are some changes to do according to the Packaging Guidelines for
Python.
https://fedoraproject.org/wiki/Packaging:Python

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1109717] Review Request: python-evtx - Windows Event Log parsing library and tools

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1109717

Yanko Kaneti yan...@declera.com changed:

   What|Removed |Added

 CC||yan...@declera.com



--- Comment #4 from Yanko Kaneti yan...@declera.com ---
Please follow http://fedoraproject.org/wiki/Packaging:SourceURL#Github
Upstream even does releases so its either
Source0: https://github.com/williballenthin/%{name}/archive/v%{version}.tar.gz
for the last 0.3.1 release
or for master
%global commit 8838756be2736695311440073d9f0b498df1fc24
%global shortcommit %(c=%{commit}; echo ${c:0:7})
Source0:
https://github.com/williballenthin/%{name}/archive/%{commit}/%{name}-%{commit}.tar.gz

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1109717] Review Request: python-evtx - Windows Event Log parsing library and tools

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1109717



--- Comment #5 from Richard W.M. Jones rjo...@redhat.com ---
Ah I didn't see those tarballs.

Try this updated package:

http://oirase.annexia.org/reviews/python-evtx/
http://oirase.annexia.org/reviews/python-evtx/python-evtx.spec
http://oirase.annexia.org/reviews/python-evtx/python-evtx-0.3.2-0.1.20140326git8838756.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1109717] Review Request: python-evtx - Windows Event Log parsing library and tools

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1109717



--- Comment #1 from Richard W.M. Jones rjo...@redhat.com ---
Upstream URLs:
http://www.williballenthin.com/evtx/
https://github.com/williballenthin/python-evtx

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1109717] Review Request: python-evtx - Windows Event Log parsing library and tools

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1109717



--- Comment #2 from Richard W.M. Jones rjo...@redhat.com ---
rpmlint output:

python-evtx.src: W: invalid-url Source0: python-evtx-master.zip
python-evtx.noarch: W: no-manual-page-for-binary evtxdump.py
python-evtx.noarch: W: no-manual-page-for-binary evtxinfo.py
3 packages and 0 specfiles checked; 0 errors, 3 warnings.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1109717] Review Request: python-evtx - Windows Event Log parsing library and tools

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1109717



--- Comment #3 from Richard W.M. Jones rjo...@redhat.com ---
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=7047161

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review