[Bug 1154218] Review Request: graphite-api - Graphite-web, without the interface. Just the rendering HTTP API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1154218

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed|2015-10-23 13:20:56 |2016-08-26 11:49:20



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1154218] Review Request: graphite-api - Graphite-web, without the interface. Just the rendering HTTP API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1154218



--- Comment #37 from Fedora Update System  ---
graphite-api-1.1.3-3.el7 has been pushed to the Fedora EPEL 7 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1154218] Review Request: graphite-api - Graphite-web, without the interface. Just the rendering HTTP API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1154218

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|ERRATA  |---
   Keywords||Reopened



--- Comment #36 from Fedora Update System  ---
graphite-api-1.1.3-3.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-aafa9d322d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1154218] Review Request: graphite-api - Graphite-web, without the interface. Just the rendering HTTP API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1154218



--- Comment #35 from Fedora Update System  ---
graphite-api-1.1.3-3.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-aafa9d322d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1154218] Review Request: graphite-api - Graphite-web, without the interface. Just the rendering HTTP API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1154218



--- Comment #34 from Fedora Update System  ---
graphite-api-1.1-1.fc23 has been pushed to the Fedora 23 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1154218] Review Request: graphite-api - Graphite-web, without the interface. Just the rendering HTTP API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1154218

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2015-10-23 13:20:56



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1154218] Review Request: graphite-api - Graphite-web, without the interface. Just the rendering HTTP API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1154218



--- Comment #33 from Fedora Update System  ---
graphite-api-1.1-1.fc22 has been pushed to the Fedora 22 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1154218] Review Request: graphite-api - Graphite-web, without the interface. Just the rendering HTTP API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1154218



--- Comment #32 from Fedora Update System  ---
graphite-api-1.1-1.fc22 has been pushed to the Fedora 22 testing repository. If
problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update graphite-api'
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2015-4fce70baa8

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1154218] Review Request: graphite-api - Graphite-web, without the interface. Just the rendering HTTP API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1154218

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #31 from Fedora Update System  ---
graphite-api-1.1-1.fc23 has been pushed to the Fedora 23 testing repository. If
problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update graphite-api'
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2015-f7b0fdce2c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1154218] Review Request: graphite-api - Graphite-web, without the interface. Just the rendering HTTP API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1154218



--- Comment #29 from Fedora Update System  ---
graphite-api-1.1-1.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2015-f7b0fdce2c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1154218] Review Request: graphite-api - Graphite-web, without the interface. Just the rendering HTTP API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1154218



--- Comment #30 from Fedora Update System  ---
graphite-api-1.1-1.fc22 has been submitted as an update to Fedora 22.
https://bodhi.fedoraproject.org/updates/FEDORA-2015-4fce70baa8

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1154218] Review Request: graphite-api - Graphite-web, without the interface. Just the rendering HTTP API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1154218

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1154218] Review Request: graphite-api - Graphite-web, without the interface. Just the rendering HTTP API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1154218



--- Comment #28 from Fedora Update System  ---
graphite-api-1.0.1-5.20150926git4cb65cd.fc23 has been pushed to the Fedora 23
testing repository. If problems still persist, please make note of it in this
bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update graphite-api'
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2015-7979db562f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1154218] Review Request: graphite-api - Graphite-web, without the interface. Just the rendering HTTP API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1154218

Piotr Popieluch  changed:

   What|Removed |Added

 Blocks||1270490




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1270490
[Bug 1270490] create epel7 package for graphite-api
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1154218] Review Request: graphite-api - Graphite-web, without the interface. Just the rendering HTTP API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1154218

Parag AN(पराग)  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #22 from Parag AN(पराग)  ---
Oh I am so sorry I missed your updated comments above. 

Package update looks good.

APPROVED.

I was referring to this guideline
https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file

we have now python_provide, py3_build, py3_install macros.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1154218] Review Request: graphite-api - Graphite-web, without the interface. Just the rendering HTTP API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1154218



--- Comment #23 from Piotr Popieluch  ---
Thanks!

New Package SCM Request
===
Package Name: graphite-api
Short Description: Graphite-web, without the interface. Just the rendering HTTP
API
Upstream URL: https://github.com/brutasse/graphite-api
Owners: piotrp
Branches: f22 f23 epel7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1154218] Review Request: graphite-api - Graphite-web, without the interface. Just the rendering HTTP API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1154218

Piotr Popieluch  changed:

   What|Removed |Added

  Flags||fedora-cvs?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1154218] Review Request: graphite-api - Graphite-web, without the interface. Just the rendering HTTP API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1154218



--- Comment #21 from Piotr Popieluch  ---
PS. It seems that there is being worked on updating python-six in RHEL7, see
bug 1185409

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1154218] Review Request: graphite-api - Graphite-web, without the interface. Just the rendering HTTP API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1154218

Jon Ciesla  changed:

   What|Removed |Added

  Flags|fedora-cvs? |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1154218] Review Request: graphite-api - Graphite-web, without the interface. Just the rendering HTTP API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1154218



--- Comment #24 from Jon Ciesla  ---
This SCM request method has been deprecated. Please see
https://fedoraproject.org/wiki/PackageDB_admin_requests.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1154218] Review Request: graphite-api - Graphite-web, without the interface. Just the rendering HTTP API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1154218



--- Comment #25 from Fedora Update System  ---
graphite-api-1.0.1-5.20150926git4cb65cd.fc23 has been submitted as an update to
Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-7979db562f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1154218] Review Request: graphite-api - Graphite-web, without the interface. Just the rendering HTTP API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1154218

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1154218] Review Request: graphite-api - Graphite-web, without the interface. Just the rendering HTTP API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1154218



--- Comment #20 from Piotr Popieluch  ---
Thank you,

Update to new github source guideline,
removed system macros, 
updated to newer version, 
added license to subpackages

I'm not sure to which "newer python macros" you are referring to. Couldn't find
it in the python guidelines, could you please give me more information about
them?

Spec URL: https://piotrp.fedorapeople.org/graphite-api.spec
SRPM URL:
https://piotrp.fedorapeople.org/graphite-api-1.0.1-5.20150926git4cb65cd.fc22.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1154218] Review Request: graphite-api - Graphite-web, without the interface. Just the rendering HTTP API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1154218

Parag AN(पराग)  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|panem...@gmail.com
  Flags||fedora-review?



--- Comment #19 from Parag AN(पराग)  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Apache (v2.0)", "Unknown or generated". 27 files have unknown
 license. Detailed output of licensecheck in /home/parag/1154218
 -graphite-api/licensecheck.txt
[!]: License file installed when any subpackage combination is installed.

==> You need to add license file to -doc subpackage

[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).

==> But there is one thing
"https://fedoraproject.org/wiki/Packaging:Guidelines#Macros says that "Macro
forms of system executables SHOULD NOT be used except when there is a need to
allow the location of those executables to be configurable. For example, rm
should be used in preference to %{__rm}, but %{__python} is acceptable."

so don't use macro __mkdir_p and __install

[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python

==> You may want to use newer python macros as you targeted this package for
Fedora versions.

[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[ ]: Avoid 

[Bug 1154218] Review Request: graphite-api - Graphite-web, without the interface. Just the rendering HTTP API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1154218



--- Comment #18 from Upstream Release Monitoring 
 ---
jgrulich's scratch build of kdevelop?#c8e2b9bc57f11e41f3dc6612cdbcc591078d9062
for f22-candidate and
git://pkgs.fedoraproject.org/kdevelop?#c8e2b9bc57f11e41f3dc6612cdbcc591078d9062
completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11212117

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1154218] Review Request: graphite-api - Graphite-web, without the interface. Just the rendering HTTP API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1154218

Piotr Popieluch piotr1...@gmail.com changed:

   What|Removed |Added

 Depends On|1239336, 1241698|



--- Comment #17 from Piotr Popieluch piotr1...@gmail.com ---
not targeting epel7, removing epel related dependent bugs.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1239336
[Bug 1239336] Please add epel7 package
https://bugzilla.redhat.com/show_bug.cgi?id=1241698
[Bug 1241698] please add lato-fonts epel package
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1154218] Review Request: graphite-api - Graphite-web, without the interface. Just the rendering HTTP API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1154218
Bug 1154218 depends on bug 1239160, which changed state.

Bug 1239160 Summary: Review Request: python-flask-cache - Adds cache support to 
your Flask application
https://bugzilla.redhat.com/show_bug.cgi?id=1239160

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1154218] Review Request: graphite-api - Graphite-web, without the interface. Just the rendering HTTP API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1154218



--- Comment #16 from Piotr Popieluch piotr1...@gmail.com ---
Spec URL: https://piotrp.fedorapeople.org/graphite-api.spec
SRPM URL:
https://piotrp.fedorapeople.org/graphite-api-1.0.1-4.20150702gitbe7907c.fc22.src.rpm


Updated spec and srpm:
- removed epel support, python-six in el7 is too old and not supported
- removed Python2 support, not targeting el7 anymore, fedora has python3
- fixed lint warnings

Tested on F22

scratch-build: http://koji.fedoraproject.org/koji/taskinfo?taskID=10441716

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1154218] Review Request: graphite-api - Graphite-web, without the interface. Just the rendering HTTP API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1154218



--- Comment #15 from Piotr Popieluch piotr1...@gmail.com ---
I've looked into rhel/centos 7. It appears that graphite-api needs at least
python-six 1.4 and rhel7 ships 1.3.

We will not be able to get this working on rhel7.

I will clean up the spec to only support fedora/python3 later this week.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1154218] Review Request: graphite-api - Graphite-web, without the interface. Just the rendering HTTP API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1154218

Piotr Popieluch piotr1...@gmail.com changed:

   What|Removed |Added

 Depends On||1241698




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1241698
[Bug 1241698] please add lato-fonts epel package
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1154218] Review Request: graphite-api - Graphite-web, without the interface. Just the rendering HTTP API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1154218

Piotr Popieluch piotr1...@gmail.com changed:

   What|Removed |Added

 Depends On||1239336



--- Comment #14 from Piotr Popieluch piotr1...@gmail.com ---
Updated package for Python 3. 
Updated to git head.
Fixed Missing Requires.
Added doc package.

Builds and works fine now on Fedora. 
Currently does not build on EPEL7 because of a missing module for
documentation. Will try to get that module in EPEL7 if that fails will have to
omit doc package on el.


Latest version:

Spec URL: https://piotrp.fedorapeople.org/graphite-api.spec
SRPM URL:
https://piotrp.fedorapeople.org/graphite-api-1.0.1-3.20150702gitbe7907c.fc22.src.rpm


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1239336
[Bug 1239336] Please add epel7 package
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1154218] Review Request: graphite-api - Graphite-web, without the interface. Just the rendering HTTP API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1154218

Piotr Popieluch piotr1...@gmail.com changed:

   What|Removed |Added

 Depends On||1239160




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1239160
[Bug 1239160] Review Request: python-flask-cache - Adds cache support to
your Flask application
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1154218] Review Request: graphite-api - Graphite-web, without the interface. Just the rendering HTTP API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1154218



--- Comment #13 from Piotr Popieluch piotr1...@gmail.com ---
Thank you for testing. I actually expected that I missed some deps... Will try
to do some work on this this evening. Weather here is too good to sit at home
today ;)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1154218] Review Request: graphite-api - Graphite-web, without the interface. Just the rendering HTTP API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1154218



--- Comment #9 from Piotr Popieluch piotr1...@gmail.com ---
Spec URL: https://piotrp.fedorapeople.org/graphite-api.spec
SRPM URL: https://piotrp.fedorapeople.org/graphite-api-1.0.1-3.fc22.src.rpm

notes:
- will need some work to get it working on Python 3
- no el6 support
- this is the last available release + a patch. There are many new commits
since the last release, maybe we should package the git head instead of the
release.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1154218] Review Request: graphite-api - Graphite-web, without the interface. Just the rendering HTTP API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1154218



--- Comment #10 from James Turnbull ja...@lovedthanlost.net ---
Agreed on HEAD. I've been discussing upstream doing a new release soon
hopefully. It's unclear to me what's needed for Python 3 support.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1154218] Review Request: graphite-api - Graphite-web, without the interface. Just the rendering HTTP API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1154218



--- Comment #11 from Piotr Popieluch piotr1...@gmail.com ---
HEAD appears to depend on Flask-Cache which is not in Fedora yet, tests fail
now. Will try to package Flask-Cache tomorrow. 

I haven't looked into Python 3 yet, I expect some issues with dependencies
which are still missing.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1154218] Review Request: graphite-api - Graphite-web, without the interface. Just the rendering HTTP API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1154218



--- Comment #12 from James Turnbull ja...@lovedthanlost.net ---
Quickly testing on CentOS Linux release 7.1.1503 (Core) I had to pip upgrade
urllib3, six, pyparsing, and websocket to get it to work. Not being overly
Python savvy or how Python libraries are packaged on RH/Fedora/CentOS - I am
not sure how helpful that is.

$ pip list
backports.ssl-match-hostname (3.4.0.2)
boto (2.38.0)
cairocffi (0.7.1)
carbon (0.9.12)
cffi (1.1.2)
chardet (2.0.1)
Cheetah (2.4.4)
cloud-init (0.7.5)
configobj (4.7.2)
decorator (3.4.0)
Django (1.6.11)
django-tagging (0.3.1)
Flask (0.10.1)
gevent (1.0.2)
graphite-api (1.0.1)
graphite-web (0.9.12)
greenlet (0.4.7)
gunicorn (19.3.0)
iniparse (0.4)
IPy (0.75)
itsdangerous (0.24)
Jinja2 (2.7.3)
jsonpatch (1.2)
jsonpointer (1.0)
Markdown (2.4.1)
MarkupSafe (0.23)
Pillow (2.0.0)
pip (1.5.6)
policycoreutils-default-encoding (0.1)
prettytable (0.7.2)
psycopg2 (2.5.1)
pycparser (2.14)
pycurl (7.19.0)
Pygments (1.4)
pygobject (3.8.2)
pygpgme (0.3)
pyliblzma (0.5.3)
pyOpenSSL (0.13.1)
pyparsing (2.0.3)
pyserial (2.6)
pytz (2012d)
pyudev (0.15)
pyxattr (0.5.1)
PyYAML (3.10)
requests (1.1.0)
rsa (3.1.1)
seobject (0.1)
sepolicy (1.1)
setuptools (0.9.8)
simplejson (3.3.3)
six (1.9.0)
slip (0.4.0)
slip.dbus (0.4.0)
structlog (15.2.0)
Twisted-Core (12.2.0)
urlgrabber (3.10)
urllib3 (1.10.4)
websocket (0.2.1)
Werkzeug (0.10.4)
whisper (0.9.12)
wsgiref (0.1.2)
yum-metadata-parser (1.1.4)
zope.interface (4.0.5)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1154218] Review Request: graphite-api - Graphite-web, without the interface. Just the rendering HTTP API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1154218



--- Comment #8 from James Turnbull ja...@lovedthanlost.net ---
Piotr - happy to help.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1154218] Review Request: graphite-api - Graphite-web, without the interface. Just the rendering HTTP API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1154218



--- Comment #7 from Piotr Popieluch piotr1...@gmail.com ---
Im on Holiday now, will upload spec and srpm as soon as i get back. Also Note
that i dont use this myself anymore, still willing tot maintain anything
graphite related but a comaintainer would be good for quality of package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1154218] Review Request: graphite-api - Graphite-web, without the interface. Just the rendering HTTP API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1154218



--- Comment #6 from James Turnbull ja...@lovedthanlost.net ---
Parag - It appears the spec and the package file are no longer at the URL. I
was hoping to revive the previous submitters interest.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1154218] Review Request: graphite-api - Graphite-web, without the interface. Just the rendering HTTP API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1154218



--- Comment #5 from Parag AN(पराग) panem...@gmail.com ---
James,
  Feel free to review this package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1154218] Review Request: graphite-api - Graphite-web, without the interface. Just the rendering HTTP API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1154218



--- Comment #4 from James Turnbull ja...@lovedthanlost.net ---
Hi - just wondering on the status of this? Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1154218] Review Request: graphite-api - Graphite-web, without the interface. Just the rendering HTTP API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1154218
Bug 1154218 depends on bug 1154213, which changed state.

Bug 1154213 Summary: Review Request: python-structlog - Painless structural 
logging
https://bugzilla.redhat.com/show_bug.cgi?id=1154213

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |NEXTRELEASE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1154218] Review Request: graphite-api - Graphite-web, without the interface. Just the rendering HTTP API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1154218

Parag AN(पराग) panem...@gmail.com changed:

   What|Removed |Added

 CC||panem...@gmail.com
 Blocks|177841 (FE-NEEDSPONSOR) |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1154218] Review Request: graphite-api - Graphite-web, without the interface. Just the rendering HTTP API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1154218



--- Comment #3 from Piotr Popieluch piotr1...@gmail.com ---
New release:

Spec URL: http://vps533.directvps.nl/graphite-api.spec
SRPM URL: http://vps533.directvps.nl/graphite-api-1.0.1-2.fc20.src.rpm

- trailing whitespaces fixed
- made python2 explicit
- added %check section
- added patch from upstream to fix an issue with timezones which made the
%check fail

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1154218] Review Request: graphite-api - Graphite-web, without the interface. Just the rendering HTTP API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1154218



--- Comment #1 from Dominik 'Rathann' Mierzejewski domi...@greysector.net ---
A couple of quick comments:

There's some trailing whitespace at the end of lines 35, 75 and 79.

I think you need Requires: systemd for %{_unitdir} directory ownership.

Please use explicit %{__python2} instead of %{__python} and, if viable, build a
python3 package as well.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1154218] Review Request: graphite-api - Graphite-web, without the interface. Just the rendering HTTP API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1154218



--- Comment #2 from Piotr Popieluch piotr1...@gmail.com ---
Thank you for reviewing.

I will fix the whitespaces.

I'm not sure about the Requires: systemd 
I've took this page as example
https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd
They only require in post, preun, postun. I've checked a couple existing
packages and some only require post/pre others only include on Requires:
systemd. It's not clear to me what 'the right way to do this' is.

I will make python2 explicit for now. It doesn't make sense to me to ship two
packages yet. I think the user will only use the python version which is
default with the OS. I will add python3 when it gets the default python (I
think it is scheduled for f22).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1154218] Review Request: graphite-api - Graphite-web, without the interface. Just the rendering HTTP API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1154218

Piotr Popieluch piotr1...@gmail.com changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1154218] Review Request: graphite-api - Graphite-web, without the interface. Just the rendering HTTP API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1154218

Piotr Popieluch piotr1...@gmail.com changed:

   What|Removed |Added

 Depends On||1154213




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1154213
[Bug 1154213] Review Request: python-structlog - Painless structural
logging
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review