[Bug 1154743] Review Request: python-pretend - A library for stubbing in Python

2014-12-10 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1154743

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

   Fixed In Version|python-pretend-1.0.8-1.fc21 |python-pretend-1.0.8-2.el6



--- Comment #19 from Fedora Update System upda...@fedoraproject.org ---
python-pretend-1.0.8-2.el6 has been pushed to the Fedora EPEL 6 stable
repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1154743] Review Request: python-pretend - A library for stubbing in Python

2014-12-10 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1154743

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

   Fixed In Version|python-pretend-1.0.8-2.el6  |python-pretend-1.0.8-2.el7



--- Comment #20 from Fedora Update System upda...@fedoraproject.org ---
python-pretend-1.0.8-2.el7 has been pushed to the Fedora EPEL 7 stable
repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1154743] Review Request: python-pretend - A library for stubbing in Python

2014-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1154743



--- Comment #16 from Jon Ciesla limburg...@gmail.com ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1154743] Review Request: python-pretend - A library for stubbing in Python

2014-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1154743

Jon Ciesla limburg...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1154743] Review Request: python-pretend - A library for stubbing in Python

2014-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1154743



--- Comment #17 from Fedora Update System upda...@fedoraproject.org ---
python-pretend-1.0.8-2.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/python-pretend-1.0.8-2.el7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1154743] Review Request: python-pretend - A library for stubbing in Python

2014-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1154743



--- Comment #18 from Fedora Update System upda...@fedoraproject.org ---
python-pretend-1.0.8-2.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/python-pretend-1.0.8-2.el6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1154743] Review Request: python-pretend - A library for stubbing in Python

2014-11-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1154743



--- Comment #15 from Piotr Popieluch piotr1...@gmail.com ---
Package Change Request
==
Package Name: python-pretend
New Branches: el6 epel7
Owners: piotrp

https://bugzilla.redhat.com/show_bug.cgi?id=1166900

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1154743] Review Request: python-pretend - A library for stubbing in Python

2014-11-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1154743

Piotr Popieluch piotr1...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-cvs+ |fedora-cvs?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1154743] Review Request: python-pretend - A library for stubbing in Python

2014-11-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1154743

Piotr Popieluch piotr1...@gmail.com changed:

   What|Removed |Added

 Blocks||1166900




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1166900
[Bug 1166900] Please add EPEL7 branch
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1154743] Review Request: python-pretend - A library for stubbing in Python

2014-11-09 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1154743

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

   Fixed In Version|python-pretend-1.0.8-1.fc19 |python-pretend-1.0.8-1.fc21



--- Comment #14 from Fedora Update System upda...@fedoraproject.org ---
python-pretend-1.0.8-1.fc21 has been pushed to the Fedora 21 stable repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1154743] Review Request: python-pretend - A library for stubbing in Python

2014-11-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1154743

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

   Fixed In Version||python-pretend-1.0.8-1.fc20
 Resolution|NEXTRELEASE |ERRATA



--- Comment #12 from Fedora Update System upda...@fedoraproject.org ---
python-pretend-1.0.8-1.fc20 has been pushed to the Fedora 20 stable repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1154743] Review Request: python-pretend - A library for stubbing in Python

2014-11-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1154743

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

   Fixed In Version|python-pretend-1.0.8-1.fc20 |python-pretend-1.0.8-1.fc19



--- Comment #13 from Fedora Update System upda...@fedoraproject.org ---
python-pretend-1.0.8-1.fc19 has been pushed to the Fedora 19 stable repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1154743] Review Request: python-pretend - A library for stubbing in Python

2014-10-27 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1154743

Jon Ciesla limburg...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1154743] Review Request: python-pretend - A library for stubbing in Python

2014-10-27 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1154743

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1154743] Review Request: python-pretend - A library for stubbing in Python

2014-10-27 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1154743



--- Comment #9 from Fedora Update System upda...@fedoraproject.org ---
python-pretend-1.0.8-1.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/python-pretend-1.0.8-1.fc21

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1154743] Review Request: python-pretend - A library for stubbing in Python

2014-10-27 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1154743



--- Comment #10 from Fedora Update System upda...@fedoraproject.org ---
python-pretend-1.0.8-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/python-pretend-1.0.8-1.fc20

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1154743] Review Request: python-pretend - A library for stubbing in Python

2014-10-27 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1154743



--- Comment #11 from Fedora Update System upda...@fedoraproject.org ---
python-pretend-1.0.8-1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/python-pretend-1.0.8-1.fc19

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1154743] Review Request: python-pretend - A library for stubbing in Python

2014-10-27 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1154743

Piotr Popieluch piotr1...@gmail.com changed:

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |NEXTRELEASE
Last Closed||2014-10-27 17:00:16



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1154743] Review Request: python-pretend - A library for stubbing in Python

2014-10-26 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1154743

Piotr Popieluch piotr1...@gmail.com changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #7 from Piotr Popieluch piotr1...@gmail.com ---
New Package SCM Request
===
Package Name: python-pretend
Short Description: A library for stubbing in Python
Upstream URL: https://github.com/alex/pretend
Owners: piotrp
Branches: f19 f20 f21
InitialCC: piotrp

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1154743] Review Request: python-pretend - A library for stubbing in Python

2014-10-25 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1154743

Parag AN(पराग) panem...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||panem...@gmail.com
   Assignee|nob...@fedoraproject.org|panem...@gmail.com
  Flags||fedora-review?



--- Comment #1 from Parag AN(पराग) panem...@gmail.com ---
1) The given spec file and spec file packaged in SRPM is not same, I guess its
some whitespace issue. correct this by having same spec packaged in srpm.

2) Group tag is optional in fedora releases. You may want to remove it but not
mandatory

3) you should add license tag for python3-pretend also.

4) Its a good practice to remove any upstream supplied egg-info files in %prep
and have packaged the newly generated egg-info files.

rm -rf *.egg-info

Otherwise package looks fine.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1154743] Review Request: python-pretend - A library for stubbing in Python

2014-10-25 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1154743



--- Comment #2 from Piotr Popieluch piotr1...@gmail.com ---
Thanks for commenting.

1) Rebuilt package and reuploaded spec/srpm, should be ok now. (rpmlint has no
warnings/errors)

2) Deleted group tag

3) Added license tag to python3-pretend

4) I think the package did only install the new egg-info but I added the rm -rf
*.egg-info to %prep to be sure.


srpm + spec uploaded to the same url (did not increase package version number)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1154743] Review Request: python-pretend - A library for stubbing in Python

2014-10-25 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1154743



--- Comment #3 from Parag AN(पराग) panem...@gmail.com ---
okay. This package looks good for final package review. Can you do more package
reviews (3 to 5) where you actually find issues in packaging and suggest
solutions on how to fix it. I will sponsor you then :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1154743] Review Request: python-pretend - A library for stubbing in Python

2014-10-25 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1154743

Parag AN(पराग) panem...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #4 from Parag AN(पराग) panem...@gmail.com ---
Review:
+ is OK
- is Needs Work

+ Package built successful in mock (f22 x86_64)

+ rpmlint on generated rpms gave output
3 packages and 0 specfiles checked; 0 errors, 0 warnings.

+ Source verified with upstream as sha256sum
srpm tarball: 930f2c1e18503e8f8c403abe2e02166c4a881941745147e712cdd4f49f3fb964
upstream tarball:
930f2c1e18503e8f8c403abe2e02166c4a881941745147e712cdd4f49f3fb964

+ License is BSD and included in LICENSE.rst file

+ follow python packaging guidelines

+ rest also looks as per packaging guidelines.

APPROVED this package.

Note as you know you are not sponsored yet so you may want to wait here before
going to add SCM git request for this package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1154743] Review Request: python-pretend - A library for stubbing in Python

2014-10-25 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1154743



--- Comment #5 from Piotr Popieluch piotr1...@gmail.com ---
Great!!!

I've started a couple more reviews, see:

https://bugzilla.redhat.com/show_bug.cgi?id=1141494
https://bugzilla.redhat.com/show_bug.cgi?id=1146929
https://bugzilla.redhat.com/show_bug.cgi?id=1146928
https://bugzilla.redhat.com/show_bug.cgi?id=1147681
https://bugzilla.redhat.com/show_bug.cgi?id=1156409
https://bugzilla.redhat.com/show_bug.cgi?id=1155403
https://bugzilla.redhat.com/show_bug.cgi?id=1155495

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1154743] Review Request: python-pretend - A library for stubbing in Python

2014-10-25 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1154743



--- Comment #6 from Parag AN(पराग) panem...@gmail.com ---
That's nice!!

I have sponsored you now in packager group :)

you can follow the package review process as given in
http://fedoraproject.org/wiki/New_package_process_for_existing_contributors
from step 7 here.

Keep reviewing packages as we are short of package reviewers in Fedora. See
list for packages to review
http://fedoraproject.org/PackageReviewStatus/NEW.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1154743] Review Request: python-pretend - A library for stubbing in Python

2014-10-25 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1154743

Parag AN(पराग) panem...@gmail.com changed:

   What|Removed |Added

 Blocks|177841 (FE-NEEDSPONSOR) |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1154743] Review Request: python-pretend - A library for stubbing in Python

2014-10-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1154743

Piotr Popieluch piotr1...@gmail.com changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR),
   ||1154213




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
https://bugzilla.redhat.com/show_bug.cgi?id=1154213
[Bug 1154213] Review Request: python-structlog - Painless structural
logging
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review