needinfo canceled: [Bug 1264656] Review Request: rubygem-ace-rails-ap - The Ajax.org Cloud9 Editor.
Product: Fedora Version: rawhide Component: Package Review Package Review has canceled Package Review 's request for Ilya Gradina 's needinfo: Bug 1264656: Review Request: rubygem-ace-rails-ap - The Ajax.org Cloud9 Editor. https://bugzilla.redhat.com/show_bug.cgi?id=1264656 --- Comment #10 from Package Review --- This is an automatic action taken by review-stats script. The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1264656] Review Request: rubygem-ace-rails-ap - The Ajax.org Cloud9 Editor.
https://bugzilla.redhat.com/show_bug.cgi?id=1264656 --- Comment #8 from Vít Ondruch --- (In reply to Vít Ondruch from comment #6) > BTW how are you going address the bundling? You still have not addressed this concern ^^. If you are going to keep the bundled library, then you should at minimum: 1) Explain the reasons why. 2) Add the "bundled" provide. 3) Update the license, since the ACE appears to be of some BSD license. [1] https://fedoraproject.org/wiki/Bundled_Libraries#Requirement_if_you_bundle -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1264656] Review Request: rubygem-ace-rails-ap - The Ajax.org Cloud9 Editor.
https://bugzilla.redhat.com/show_bug.cgi?id=1264656 --- Comment #7 from Ilya Gradina --- Hi Vit, New SPEC: https://raw.githubusercontent.com/ilgrad/fedora-packages/master/rubygems/rubygem-ace-rails-ap.spec New SRPM: https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-ace-rails-ap-4.1.0-1.fc24.src.rpm the question is set: https://github.com/codykrieger/ace-rails-ap/issues/22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1264656] Review Request: rubygem-ace-rails-ap - The Ajax.org Cloud9 Editor.
https://bugzilla.redhat.com/show_bug.cgi?id=1264656 --- Comment #6 from Vít Ondruch --- (In reply to Ilya Gradina from comment #4) > unfortunately the tests I have not found. I see, no tests in upstream. Have you asked them? And even though there are no tests, it is a good habit to leave note in the .spec file. BTW how are you going address the bundling? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1264656] Review Request: rubygem-ace-rails-ap - The Ajax.org Cloud9 Editor.
https://bugzilla.redhat.com/show_bug.cgi?id=1264656 --- Comment #5 from Upstream Release Monitoring --- ilgrad's scratch build of rubygem-ace-rails-ap-4.0.0-2.fc24.src.rpm for f24 completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11266095 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1264656] Review Request: rubygem-ace-rails-ap - The Ajax.org Cloud9 Editor.
https://bugzilla.redhat.com/show_bug.cgi?id=1264656 --- Comment #4 from Ilya Gradina --- Thx Vit, unfortunately the tests I have not found. I made the changes according to your notes. Spec URL: http://repo.clanwars.org/gitlab/rubygem-ace-rails-ap.spec SRPM URL: http://repo.clanwars.org/gitlab/rubygem-ace-rails-ap-4.0.0-2.fc24.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1264656] Review Request: rubygem-ace-rails-ap - The Ajax.org Cloud9 Editor.
https://bugzilla.redhat.com/show_bug.cgi?id=1264656
Vít Ondruch changed:
What|Removed |Added
CC||vondr...@redhat.com
--- Comment #3 from Vít Ondruch ---
Just a few quick points:
* What about test suite?
* How about bundling? This directory looks suspicious: %{gem_instdir}/vendor
* You list several BuildRequires which you definitely don't need ATM, since you
don't execute the test suite.
* We typically try to avoid build time dependency on Bundler as much as
possible. Not sure this will be the case, but its always worth asking.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1264656] Review Request: rubygem-ace-rails-ap - The Ajax.org Cloud9 Editor.
https://bugzilla.redhat.com/show_bug.cgi?id=1264656 --- Comment #2 from Ilya Gradina --- (In reply to Upstream Release Monitoring from comment #1) > jgrulich's scratch build of > kdevelop?#c8e2b9bc57f11e41f3dc6612cdbcc591078d9062 for f22-candidate and > git://pkgs.fedoraproject.org/ > kdevelop?#c8e2b9bc57f11e41f3dc6612cdbcc591078d9062 completed > http://koji.fedoraproject.org/koji/taskinfo?taskID=11212117 It is mistake? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1264656] Review Request: rubygem-ace-rails-ap - The Ajax.org Cloud9 Editor.
https://bugzilla.redhat.com/show_bug.cgi?id=1264656 --- Comment #1 from Upstream Release Monitoring --- jgrulich's scratch build of kdevelop?#c8e2b9bc57f11e41f3dc6612cdbcc591078d9062 for f22-candidate and git://pkgs.fedoraproject.org/kdevelop?#c8e2b9bc57f11e41f3dc6612cdbcc591078d9062 completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11212117 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
