[Bug 1278293] Review Request: python-moss - Assorted utilities for neuroimaging and cognitive science

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1278293

Igor Gnatenko  changed:

   What|Removed |Added

  Alias|python-moss |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1278293] Review Request: python-moss - Assorted utilities for neuroimaging and cognitive science

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1278293



--- Comment #7 from Fedora Update System  ---
python-moss-0.3.4-3.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2015-a13b5923fb

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1278293] Review Request: python-moss - Assorted utilities for neuroimaging and cognitive science

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1278293

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1278293] Review Request: python-moss - Assorted utilities for neuroimaging and cognitive science

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1278293
Bug 1278293 depends on bug 1276871, which changed state.

Bug 1276871 Summary: Review Request: python-nibabel - Python package to access 
a cacophony of neuro-imaging file formats
https://bugzilla.redhat.com/show_bug.cgi?id=1276871

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1278293] Review Request: python-moss - Assorted utilities for neuroimaging and cognitive science

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1278293

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|ASSIGNED|POST



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1278293] Review Request: python-moss - Assorted utilities for neuroimaging and cognitive science

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1278293



--- Comment #6 from Till Maas  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/python-moss

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1278293] Review Request: python-moss - Assorted utilities for neuroimaging and cognitive science

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1278293

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #5 from Zbigniew Jędrzejewski-Szmek  ---
Some style *suggestions*:

pushd %{buildroot}%{_bindir}
  for mod in recon_status recon_movie check_mni_reg recon_process_stats
ts_movie
  do
sed -i '1s|^#!.*$|#!%{__python3}|' $mod
  done

  # Depends on 'freeview' utility
  rm -f {recon,warp}_qc
popd


can be written as

rm %{buildroot}%{_bindir}/{recon,warp}_qc
sed -i '1s|^#!.*$|#!%{__python3}|' %{buildroot}%{_bindir}/*



# Disable one of tests for now due to:
https://github.com/mwaskom/moss/issues/17
sed -i -e '/def test_remove_by_group(self):/a \ \ \ \ \ \ \ \ from
nose.plugins.skip import SkipTest; raise
SkipTest("https://github.com/mwaskom/moss/issues/17;)'
moss/tests/test_statistical.py

can be written as

nosetests-%{python2_version} -v -x test_remove_by_group || :
nosetests-%{python3_version} -v -x test_remove_by_group || :


- license is OK
- license file is present and %license is used
- build follows new python guidelines
- requirements and provides are sane
- rpmlint has nothing interesting to say:
python2-moss.noarch: E: explicit-lib-dependency python-matplotlib
python2-moss.noarch: W: spelling-error Summary(en_US) neuroimaging ->
micromanaging
python2-moss.noarch: W: spelling-error %description -l en_US neuroimaging ->
micromanaging
python3-moss.noarch: E: explicit-lib-dependency python3-matplotlib
python3-moss.noarch: W: spelling-error Summary(en_US) neuroimaging ->
micromanaging
python3-moss.noarch: W: spelling-error %description -l en_US neuroimaging ->
micromanaging
python3-moss.noarch: W: python-bytecode-without-source
/usr/lib/python3.5/site-packages/moss/__pycache__/leastsqbound.cpython-35.opt-1.pyc
...
python3-moss.noarch: W: no-manual-page-for-binary check_mni_reg
python3-moss.noarch: W: no-manual-page-for-binary recon_status
python3-moss.noarch: W: no-manual-page-for-binary ts_movie
python3-moss.noarch: W: no-manual-page-for-binary recon_movie
python3-moss.noarch: W: no-manual-page-for-binary recon_process_stats
python-moss.src: W: spelling-error Summary(en_US) neuroimaging -> micromanaging
python-moss.src: W: spelling-error %description -l en_US neuroimaging ->
micromanaging
3 packages and 0 specfiles checked; 2 errors, 27 warnings.

Package is APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1278293] Review Request: python-moss - Assorted utilities for neuroimaging and cognitive science

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1278293



--- Comment #1 from Zbigniew Jędrzejewski-Szmek  ---
There's no need to package both scripts for both python2 and python3. The same
as in other packages, scripts for python3 should be packaged.

Also, '#!/usr/bin/env /usr/bin/python3' should be replaced with
'#!/usr/bin/python3'.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1278293] Review Request: python-moss - Assorted utilities for neuroimaging and cognitive science

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1278293



--- Comment #3 from Zbigniew Jędrzejewski-Szmek  ---
No other issues, but I wanted to check the updated package. Removing the
scripts changes the automatically generated requires and there are often bugs
lurking there.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1278293] Review Request: python-moss - Assorted utilities for neuroimaging and cognitive science

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1278293

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zbys...@in.waw.pl
   Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1278293] Review Request: python-moss - Assorted utilities for neuroimaging and cognitive science

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1278293



--- Comment #2 from Igor Gnatenko  ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #1)
> There's no need to package both scripts for both python2 and python3. The
> same as in other packages, scripts for python3 should be packaged.
You will find this in all my submitted packages (which was submitted before you
said me this) ;)
> 
> Also, '#!/usr/bin/env /usr/bin/python3' should be replaced with
> '#!/usr/bin/python3'.
yes, the same I will do in other pkgs.

Any other issues? Can we fix in importing stage?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1278293] Review Request: python-moss - Assorted utilities for neuroimaging and cognitive science

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1278293

Igor Gnatenko  changed:

   What|Removed |Added

  Alias||python-moss



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1278293] Review Request: python-moss - Assorted utilities for neuroimaging and cognitive science

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1278293

Igor Gnatenko  changed:

   What|Removed |Added

 Depends On||1276871, 1276938




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1276871
[Bug 1276871] Review Request: python-nibabel - Python package to access a
cacophony of neuro-imaging file formats
https://bugzilla.redhat.com/show_bug.cgi?id=1276938
[Bug 1276938] Review Request: python-nipy - Neuroimaging in Python FMRI
analysis package
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1278293] Review Request: python-moss - Assorted utilities for neuroimaging and cognitive science

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1278293

Igor Gnatenko  changed:

   What|Removed |Added

 Blocks||1276941 (fedora-neuro)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1276941
[Bug 1276941] Fedora NeuroImaging and NeuroScience tracking bug
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review