[Bug 1297524] Review Request: golang-github-asaskevich-govalidator - Validators and sanitizers for strings , numerics, slices and structs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297524



--- Comment #16 from Fedora Update System  ---
golang-github-asaskevich-govalidator-6-1.el7 has been pushed to the Fedora EPEL
7 stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1297524] Review Request: golang-github-asaskevich-govalidator - Validators and sanitizers for strings , numerics, slices and structs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297524



--- Comment #15 from Fedora Update System  ---
golang-github-asaskevich-govalidator-6-1.fc25 has been pushed to the Fedora 25
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1297524] Review Request: golang-github-asaskevich-govalidator - Validators and sanitizers for strings , numerics, slices and structs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297524

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-05-09 17:23:04



--- Comment #14 from Fedora Update System  ---
golang-github-asaskevich-govalidator-6-1.fc26 has been pushed to the Fedora 26
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1297524] Review Request: golang-github-asaskevich-govalidator - Validators and sanitizers for strings , numerics, slices and structs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297524



--- Comment #13 from Fedora Update System  ---
golang-github-asaskevich-govalidator-6-1.fc26 has been pushed to the Fedora 26
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-41ddc6a4a3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1297524] Review Request: golang-github-asaskevich-govalidator - Validators and sanitizers for strings , numerics, slices and structs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297524



--- Comment #12 from Fedora Update System  ---
golang-github-asaskevich-govalidator-6-1.fc25 has been pushed to the Fedora 25
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-a847f52882

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1297524] Review Request: golang-github-asaskevich-govalidator - Validators and sanitizers for strings , numerics, slices and structs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297524

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #11 from Fedora Update System  ---
golang-github-asaskevich-govalidator-6-1.el7 has been pushed to the Fedora EPEL
7 testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-91c6250e8a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1297524] Review Request: golang-github-asaskevich-govalidator - Validators and sanitizers for strings , numerics, slices and structs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297524



--- Comment #10 from Fedora Update System  ---
golang-github-asaskevich-govalidator-6-1.fc26 has been submitted as an update
to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-41ddc6a4a3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1297524] Review Request: golang-github-asaskevich-govalidator - Validators and sanitizers for strings , numerics, slices and structs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297524



--- Comment #9 from Fedora Update System  ---
golang-github-asaskevich-govalidator-6-1.el7 has been submitted as an update to
Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-91c6250e8a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1297524] Review Request: golang-github-asaskevich-govalidator - Validators and sanitizers for strings , numerics, slices and structs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297524

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1297524] Review Request: golang-github-asaskevich-govalidator - Validators and sanitizers for strings , numerics, slices and structs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297524



--- Comment #8 from Fedora Update System  ---
golang-github-asaskevich-govalidator-6-1.fc25 has been submitted as an update
to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-a847f52882

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1297524] Review Request: golang-github-asaskevich-govalidator - Validators and sanitizers for strings , numerics, slices and structs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297524



--- Comment #7 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/golang-github-asaskevich-govalidator

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1297524] Review Request: golang-github-asaskevich-govalidator - Validators and sanitizers for strings , numerics, slices and structs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297524

Athos Ribeiro  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #6 from Athos Ribeiro  ---
> - I'm a little hesitant to remove any of the boilerplate that gofed adds,
> just because I'm trying very hard not to deviate much from the generated
> output (to keep diffs from future runs to a minimum).
> 
> (It might be more worthwhile spending some time making gofed's output less
> verbose when a resulting outputted block is a no-op?)

OK, you are probably right.

There are a few false positives with rpmlint, but they can be safely ignored.

The package looks good now. Approved!

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
[-]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
 files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf 

[Bug 1297524] Review Request: golang-github-asaskevich-govalidator - Validators and sanitizers for strings , numerics, slices and structs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297524



--- Comment #5 from Ed Marshall  ---
Spec URL:
https://fedorapeople.org/~logic/golang-github-asaskevich-govalidator/golang-github-asaskevich-govalidator.spec
SRPM URL:
https://kojipkgs.fedoraproject.org//work/tasks/9064/19359064/golang-github-asaskevich-govalidator-6-1.fc27.src.rpm

Scratch rawhide koji build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=19359063

Thanks for taking the time to take a look at this!

- Fixed License field. Whoops. :(

- Updated to v6, and cleaned up Release. Since upstream is making releases, I'd
like to stick to that if possible, rather than chasing SHAs.

- I'm a little hesitant to remove any of the boilerplate that gofed adds, just
because I'm trying very hard not to deviate much from the generated output (to
keep diffs from future runs to a minimum).

(It might be more worthwhile spending some time making gofed's output less
verbose when a resulting outputted block is a no-op?)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1297524] Review Request: golang-github-asaskevich-govalidator - Validators and sanitizers for strings , numerics, slices and structs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297524

Athos Ribeiro  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||athoscribe...@gmail.com
   Assignee|nob...@fedoraproject.org|athoscribe...@gmail.com
  Flags||fedora-review?



--- Comment #4 from Athos Ribeiro  ---
Hello,

I will take this review.

- License field is wrong (!!FILL!!) in the new spec.

- Version 6 is out, do you want to package it before we proceed (and use the
new gofed version to generate the spec file)?

- Note that if you are packaging a post release, you should not use the 0.N
notation. Also, there are new guidelines on pre/post releases. In special, the
date when the snapshot was taken must be in the release tag. See [1] and [2].

- You could also remove the empty conditional blocks to improve readability

[1] https://fedoraproject.org/wiki/Packaging:Versioning
[2] https://fedoraproject.org/wiki/Package_Versioning_Examples

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1297524] Review Request: golang-github-asaskevich-govalidator - Validators and sanitizers for strings , numerics, slices and structs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297524

marcindulak  changed:

   What|Removed |Added

 CC||marcin.du...@gmail.com



--- Comment #3 from marcindulak  ---
Hi, are you planning to make your vault dependencies available also in EPEL7?

Several of them are needed for
https://copr.fedorainfracloud.org/coprs/marcindulak/minishift/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1297524] Review Request: golang-github-asaskevich-govalidator - Validators and sanitizers for strings , numerics, slices and structs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297524



--- Comment #2 from Ed Marshall  ---
Spec URL:
https://fedorapeople.org/cgit/logic/public_git/golang-github-asaskevich-govalidator.git/plain/golang-github-asaskevich-govalidator.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/logic/vault/fedora-rawhide-x86_64/00522706-golang-github-asaskevich-govalidator/golang-github-asaskevich-govalidator-5-0.1.git7b3beb6.fc27.src.rpm

Updated, regenerated using latest gofed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1297524] Review Request: golang-github-asaskevich-govalidator - Validators and sanitizers for strings, numerics, slices and structs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297524

Michael Scherer  changed:

   What|Removed |Added

 CC||m...@zarb.org



--- Comment #1 from Michael Scherer  ---
Seems to not build on Fedora Review:
Executing(%check): /bin/sh -e /var/tmp/rpm-tmp.VXfc9R
+ umask 022
+ cd /builddir/build/BUILD
+ cd govalidator-5fe52de9fffecc6df9539fcfd6ac6ae6aa6fc626
+ export
GOPATH=/builddir/build/BUILDROOT/golang-github-asaskevich-govalidator-2-1.fc23.x86_64//usr/share/gocode:/usr/share/gocode
+
GOPATH=/builddir/build/BUILDROOT/golang-github-asaskevich-govalidator-2-1.fc23.x86_64//usr/share/gocode:/usr/share/gocode
+ go test -compiler gc -ldflags '' github.com/asaskevich/govalidator
/var/tmp/rpm-tmp.VXfc9R: line 33: go: command not found
RPM build errors:
error: Bad exit status from /var/tmp/rpm-tmp.VXfc9R (%check)
Bad exit status from /var/tmp/rpm-tmp.VXfc9R (%check)
Child return code was: 1
EXCEPTION: Command failed. See logs for output.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review