[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315870



--- Comment #36 from Neil Horman  ---
Nothing, you can proceed with the documentation at the link you have above

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315870



--- Comment #35 from dennis.dalessan...@intel.com ---
Thank Neil. So looks like the next steps for me are to follow:

https://fedoraproject.org/wiki/Join_the_package_collection_maintainers?rd=PackageMaintainers/Join#Add_Package_to_Source_Code_Management_.28SCM.29_system_and_Set_Owner

What other info do you need from me at this point?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315870

Neil Horman  changed:

   What|Removed |Added

  Flags||needinfo?(dennis.dalessandr
   ||o...@intel.com)



--- Comment #34 from Neil Horman  ---
done.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315870

dennis.dalessan...@intel.com changed:

   What|Removed |Added

  Flags|needinfo?(dennis.dalessandr |needinfo-
   |o...@intel.com)|



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315870



--- Comment #33 from dennis.dalessan...@intel.com ---
Just now seen this. I have been out for a couple weeks. My fedora user name is
ddalessa.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315870

Neil Horman  changed:

   What|Removed |Added

  Flags||needinfo?(dennis.dalessandr
   ||o...@intel.com)



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315870

Neil Horman  changed:

   What|Removed |Added

  Flags|needinfo?(dennis.dalessandr |
   |o...@intel.com)|
   |needinfo?(nhor...@redhat.co |
   |m)  |



--- Comment #32 from Neil Horman  ---
whats your fedora user name, I can sponsor you in.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315870

Janet Morgan  changed:

   What|Removed |Added

  Flags||needinfo?(nhor...@redhat.co
   ||m)



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315870



--- Comment #31 from dennis.dalessan...@intel.com ---
Hi Neil,

What info is being requested from me at this point? So you marked it approved,
now am I waiting to get a sponsor? Does the FE_NEEDSPONSOR in the blocks
section accomplish that or is there something else I should do to move that
along.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315870

Neil Horman  changed:

   What|Removed |Added

  Flags||needinfo?(dennis.dalessandr
   ||o...@intel.com)



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315870

Neil Horman  changed:

   What|Removed |Added

  Flags|needinfo?(dennis.dalessandr |fedora-review+
   |o...@intel.com)|
   |needinfo?(nhor...@redhat.co |
   |m)  |



--- Comment #30 from Neil Horman  ---
ok, then you have what you want, thanks.

APROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315870

Janet Morgan  changed:

   What|Removed |Added

  Flags||needinfo?(nhor...@redhat.co
   ||m)



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315870

Neil Horman  changed:

   What|Removed |Added

  Flags||needinfo?(dennis.dalessandr
   ||o...@intel.com)



--- Comment #28 from Neil Horman  ---
It looks like at some point in your update you removed the _smp_mflags macro:

[!]: Uses parallel make %{?_smp_mflags} macro.

Its not a huge deal, I can let that slide, but please fix it when you check it
in.

Also, something just occured to me.  Is this verb library named libhfi1 because
its meant to supersede libhfi?  If so, you might consider renaming it upstream,
and just using the epoch tag in the spec to make sure the upgrade path is
right.  Doing so would let you avoid the obsoletes tag requirements, as you we
could update the libhfiverbs package that exists.

The question to really answer is "is libhfiverbs still under active
development"?  If it is, then you proably want what you have.  If not, and if
libfhi1 is compatible with libhfi in terms of hardware, then you may want to
consider renaming the package upstream.

Let me know what you want to do.  If you are happy with the way it currently
is, then I can approve this as it is.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315870

Neil Horman  changed:

   What|Removed |Added

  Flags|needinfo?(nhor...@redhat.co |
   |m)  |



--- Comment #27 from Neil Horman  ---
sorry, I completely missed this, I'll review it right away

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315870

dennis.dalessan...@intel.com changed:

   What|Removed |Added

  Flags||needinfo?(nhor...@redhat.co
   ||m)



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315870

dennis.dalessan...@intel.com changed:

   What|Removed |Added

  Flags|needinfo?(dennis.dalessandr |
   |o...@intel.com)|



--- Comment #26 from dennis.dalessan...@intel.com ---
I think I got the requested changes covered, please take a look and let me know
any further review comments. Here are the Koji test build, spec, and srpm
links.

http://koji.fedoraproject.org/koji/taskinfo?taskID=14025958

https://github.com/01org/opa-libhfi1verbs/releases/download/10_1_2/libhfi1-0.5-23.el7.src.rpm

https://github.com/01org/opa-libhfi1verbs/releases/download/10_1_2/libhfi1.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315870

Neil Horman  changed:

   What|Removed |Added

  Flags||needinfo?(dennis.dalessandr
   ||o...@intel.com)



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315870



--- Comment #25 from dennis.dalessan...@intel.com ---
Ok sounds like we are on the same page then. I've made the other changes and
have it out for review/testing on our end. Should be posted as a new version
here soon.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315870

Neil Horman  changed:

   What|Removed |Added

  Flags|needinfo?(dennis.dalessandr |
   |o...@intel.com)|
   |needinfo?(nhor...@redhat.co |
   |m)  |



--- Comment #24 from Neil Horman  ---
You're right, my bad, the license is ok, the other BuildRequires issues and
such need to get fixed though

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315870

Honggang LI  changed:

   What|Removed |Added

  Flags||needinfo?(nhor...@redhat.co
   ||m)



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315870



--- Comment #23 from dennis.dalessan...@intel.com ---
(In reply to Neil Horman from comment #22)
> Just because the source has multiple license options, doesn't mean you just
> pass that through to the binary.  The dual license option is for use when
> you have multiple binaries in a given binary rpm, some of which have license
> X, some of which have license Y. If they all are being distributed under the
> same license, then you either need to:

That's not the way I read it. I think you are describing the "Multiple license"
option, not "Dual license". All binaries have the same license (GPL/BSD).
"Multiple" license is when there are different licenses for different binaries.
That is not the case here.

I think Honggang is correct in comment 21. Please confirm?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315870



--- Comment #22 from Neil Horman  ---
Concur with comment 20, we need the latest package from upstream

However, the license does need to get fixed.  As per the licensing guidelines:
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines

The license field in the spec applies to the binaries in the resultant packages

Just because the source has multiple license options, doesn't mean you just
pass that through to the binary.  The dual license option is for use when you
have multiple binaries in a given binary rpm, some of which have license X,
some of which have license Y. If they all are being distributed under the same
license, then you either need to:

1) Pick a single license and update the spec file as such
or
2) Change the or in the License field to an And

See:
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#Multiple_Licensing_Scenarios

for details

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315870



--- Comment #21 from Honggang LI  ---
(In reply to dennis.dalessandro from comment #19)
> (In reply to Honggang LI from comment #12)
> > 6) As this package is licensed by multiple licenses, so add comment in spec
> > file as required.
> 
> Not sure what you mean here? The spec file has the GPL and BSD license text
> in the comments at the beginning.

As the software is dual licensed, it is OK to ignore my comment.

https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Dual_Licensing_Scenarios

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315870



--- Comment #20 from Honggang LI  ---
(In reply to dennis.dalessandro from comment #18)
> So I'm asking is it a hard requirement to use the newer package? If so, why?
> is there a specific problem with the older version (which would be good to
> know for other reasons), or is a general policy that the latest/greatest is
> required for Fedora packages?

It works with older libibverbs. However, we update 'BuildRequires: 
libibverbs-devel >= 1.2.0' for *all* RDMA user space drivers to prevent build
the drivers against old libibverbs in Fedora koji system. As Fedora always asks
for latest upstream release to be packaged up, the latest libibverbs will be
installed. Building packages with latest required will ensure packages built
and run with the same version required packages.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315870



--- Comment #19 from dennis.dalessan...@intel.com ---
(In reply to Honggang LI from comment #12)
> 6) As this package is licensed by multiple licenses, so add comment in spec
> file as required.

Not sure what you mean here? The spec file has the GPL and BSD license text in
the comments at the beginning.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315870

Neil Horman  changed:

   What|Removed |Added

  Flags||needinfo?(dennis.dalessandr
   ||o...@intel.com)



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315870



--- Comment #18 from dennis.dalessan...@intel.com ---
So I'm asking is it a hard requirement to use the newer package? If so, why? is
there a specific problem with the older version (which would be good to know
for other reasons), or is a general policy that the latest/greatest is required
for Fedora packages?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315870



--- Comment #17 from Neil Horman  ---
Its a BuildRequires.  If someone is building the rpm they can adhere to the
levels Fedora requires. If they aren't using fedora, then they can modify the
spec file.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315870

dennis.dalessan...@intel.com changed:

   What|Removed |Added

  Flags|needinfo?(dennis.dalessandr |
   |o...@intel.com)|



--- Comment #16 from dennis.dalessan...@intel.com ---
(In reply to Honggang LI from comment #12)
> 3) BuildRequires:  libibverbs-devel >= 1.2.0
> We had update libibverbs to latest upstream v1.2.0 for Fedora.

Do we really need to update this? There still may be systems that want to build
this RPM but have not upgraded to 1.2.0, not sure how we would handle that.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315870

Neil Horman  changed:

   What|Removed |Added

  Flags||needinfo?(dennis.dalessandr
   ||o...@intel.com)



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315870

Honggang LI  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315870

dennis.dalessan...@intel.com changed:

   What|Removed |Added

  Flags|needinfo?(dennis.dalessandr |
   |o...@intel.com)|
   |needinfo?(dennis.dalessandr |
   |o...@intel.com)|



--- Comment #15 from dennis.dalessan...@intel.com ---
(In reply to Honggang LI from comment #14)
> Hello, Dennis
>  Ping? Any update?
> 
> Thanks

I was out of the office last week on travel. Will get to this as soon as I dig
out.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315870

Honggang LI  changed:

   What|Removed |Added

  Flags||needinfo?(dennis.dalessandr
   ||o...@intel.com)



--- Comment #14 from Honggang LI  ---
Hello, Dennis
 Ping? Any update?

Thanks

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315870

Neil Horman  changed:

   What|Removed |Added

  Flags||needinfo?(dennis.dalessandr
   ||o...@intel.com)



--- Comment #13 from Neil Horman  ---
My review re-inforces Honggangs, pelase make those corrections, submit a new
spec/srpm when complete, and inform us here of the update with the new location

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315870



--- Comment #12 from Honggang LI  ---
Hello, Dennis

http://people.redhat.com/honli/.b187328c893321f3baa62cc5ef46f5d1/

I uploaded my review result into this http dir. Please fix the obsoleted m4s
macros in upstream git repo and recreate the spec and src.

http://people.redhat.com/honli/.b187328c893321f3baa62cc5ef46f5d1/review.txt
=
Generic:
[!]: Package should not use obsolete m4 macros
 Note: Some obsoleted macros found, see the attachment.
 See: https://fedorahosted.org/FedoraReview/wiki/AutoTools
..
AutoTools: Obsoleted m4s found
--
  AM_PROG_LIBTOOL found in: libhfi1-0.5/configure.in:63
  AM_CONFIG_HEADER found in: libhfi1-0.5/configure.in:61

=
What I modified based on your spec.
1) rename libhfi1verbs as libhfi1, as we had import it into rhel-7.2 with the
name libhfi1. If Fedora and RHEL-7 have different names for this package. It
will be an trouble.
https://bugzilla.redhat.com/show_bug.cgi?id=1251634

2) replace '%define' with '%global'

3) BuildRequires:  libibverbs-devel >= 1.2.0
We had update libibverbs to latest upstream v1.2.0 for Fedora.

4) replace '-devel' package with '-static'
a) There is a *.a file, it should be packaged with -static package, not -devel
package.
b) All other verbs user space drivers have a static package instead a -devel
package.

5) make %{?_smp_mflags}
It seems there is a typo in your spec file.

6) As this package is licensed by multiple licenses, so add comment in spec
file as required.

7) Add changelog as I said in comment #1. Please check your name.


thanks

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315870

Neil Horman  changed:

   What|Removed |Added

 CC||nhor...@redhat.com
   Assignee|nob...@fedoraproject.org|nhor...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315870

dennis.dalessan...@intel.com changed:

   What|Removed |Added

  Flags|needinfo?(dennis.dalessandr |
   |o...@intel.com)|



--- Comment #11 from dennis.dalessan...@intel.com ---
(In reply to Honggang LI from comment #10)
> Hello, Dennis
>  Ping? Any update?

SRPM:
https://github.com/01org/opa-libhfi1verbs/releases/download/10_1_1/libhfi1verbs-0.5-17.fc23.src.rpm

SPEC:
https://github.com/01org/opa-libhfi1verbs/releases/download/10_1_1/libhfi1verbs.spec

Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=13484725

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315870

Honggang LI  changed:

   What|Removed |Added

 CC||dennis.dalessan...@intel.co
   ||m
  Flags||needinfo?(dennis.dalessandr
   ||o...@intel.com)



--- Comment #10 from Honggang LI  ---
Hello, Dennis
 Ping? Any update?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315870

Don Bayly  changed:

   What|Removed |Added

 Blocks||1171868



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315870



--- Comment #9 from dennis.dalessan...@intel.com ---
(In reply to Honggang LI from comment #8)
> Please re-post the old version then someone else can review those files. And
> I also need those files to run fedora-review as suggested by someone in IRC
> channel #fedora-devel.

Ok, done.

Spec URL:
https://github.com/01org/opa-libhfi1verbs/releases/download/10_1/libhfi1verbs.spec

SRPM URL:
https://github.com/01org/opa-libhfi1verbs/releases/download/10_1/libhfi1verbs-0.5-16.fc23.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315870



--- Comment #8 from Honggang LI  ---
Please re-post the old version then someone else can review those files. And I
also need those files to run fedora-review as suggested by someone in IRC
channel #fedora-devel.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315870



--- Comment #7 from dennis.dalessan...@intel.com ---
(In reply to Honggang LI from comment #6)
> (In reply to dennis.dalessandro from comment #0)
> > Spec URL:
> > https://github.com/01org/opa-libhfi1verbs/releases/download/10_1/
> > libhfi1verbs.spec
> > SRPM URL:
> > https://github.com/01org/opa-libhfi1verbs/releases/download/10_1/
> > libhfi1verbs-0.5-16.fc23.src.rpm
> 
> Hi, Dennis
>  It seems those URLs are no longer valid. Could you please check them?

Hi Honggang, yep, I am going to post new revisions there. I got side tracked
looking into the valgrind thing. Should I re-post the old version until I'm
ready to replace it?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315870



--- Comment #6 from Honggang LI  ---
(In reply to dennis.dalessandro from comment #0)
> Spec URL:
> https://github.com/01org/opa-libhfi1verbs/releases/download/10_1/
> libhfi1verbs.spec
> SRPM URL:
> https://github.com/01org/opa-libhfi1verbs/releases/download/10_1/
> libhfi1verbs-0.5-16.fc23.src.rpm

Hi, Dennis
 It seems those URLs are no longer valid. Could you please check them?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315870



--- Comment #5 from Honggang LI  ---
(In reply to dennis.dalessandro from comment #4)
> Is this a hard requirement? I'm checking into its impact regardless.

Yes, it is a hard requirement for RHEL. So, it is better to build with valgrind
for fedora too. We test other InfiniBand user-space drivers, for example,
libmlx4. The performance is good over our RDMA cluster. However, we don't have
huge/large cluster for testing.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315870

Honggang LI  changed:

   What|Removed |Added

 Attachment|0   |1
#1134688 is||
   obsolete||



--- Comment #3 from Honggang LI  ---
Created attachment 1134700
  --> https://bugzilla.redhat.com/attachment.cgi?id=1134700=edit
spec review patch

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315870



--- Comment #2 from Honggang LI  ---
Created attachment 1134688
  --> https://bugzilla.redhat.com/attachment.cgi?id=1134688=edit
spec review patch

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315870



--- Comment #1 from Honggang LI  ---
(In reply to dennis.dalessandro from comment #0)
> Spec URL:
> https://github.com/01org/opa-libhfi1verbs/releases/download/10_1/
> libhfi1verbs.spec

Please see the attachment and update the spec file and the package. You also
need update '%changelog' section.

http://people.redhat.com/honli/.bcc4d86c9ce430ffc0c40ba4b877b7c6/libmlx5.spec

Please take this one as example. Thanks

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315870

Honggang LI  changed:

   What|Removed |Added

 CC||ho...@redhat.com
 Blocks||1315609



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315870

dennis.dalessan...@intel.com changed:

   What|Removed |Added

 Blocks||1273171



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315870

dennis.dalessan...@intel.com changed:

   What|Removed |Added

 CC||john.fl...@intel.com
 Blocks||177841 (FE-NEEDSPONSOR)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review