[Bug 1359914] Review Request: lollypop - Music player for GNOME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1359914

MartinKG  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |NEXTRELEASE
Last Closed||2016-12-15 08:53:17



--- Comment #34 from MartinKG  ---
package has been built successfully on fc24 and rawhide.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1359914] Review Request: lollypop - Music player for GNOME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1359914



--- Comment #33 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/lollypop

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1359914] Review Request: lollypop - Music player for GNOME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1359914



--- Comment #32 from MartinKG  ---
(In reply to Jeremy Newton from comment #31)
> (In reply to MartinKG from comment #30)
> > (In reply to Jeremy Newton from comment #29)
> > > Just some documentation fixes to silence some rpmlint warnings:
> > > 
> > > - Use the following for portal's description:
> > > Summary:Lollypop flatpak portal (advanced features)
> > > 
> > > - youtube should be spelt YouTube
> > > 
> > > - playlists I believe should be "play-lists"
> > > 
> > > But other than that, looks good! Approved!
> > > 
> > > Remember to fix these before submitting.
> > 
> > changes done.
> > Thanks for the review.
> > 
> > Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/lollypop.spec
> > SRPM URL:
> > https://martinkg.fedorapeople.org/Review/SRPMS/lollypop-0.9.223-3.fc25.src.
> > rpm
> 
> No problem, but I meant playlists should be changed to play-lists without
> the quotes ;)

ok, done.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1359914] Review Request: lollypop - Music player for GNOME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1359914



--- Comment #31 from Jeremy Newton  ---
(In reply to MartinKG from comment #30)
> (In reply to Jeremy Newton from comment #29)
> > Just some documentation fixes to silence some rpmlint warnings:
> > 
> > - Use the following for portal's description:
> > Summary:Lollypop flatpak portal (advanced features)
> > 
> > - youtube should be spelt YouTube
> > 
> > - playlists I believe should be "play-lists"
> > 
> > But other than that, looks good! Approved!
> > 
> > Remember to fix these before submitting.
> 
> changes done.
> Thanks for the review.
> 
> Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/lollypop.spec
> SRPM URL:
> https://martinkg.fedorapeople.org/Review/SRPMS/lollypop-0.9.223-3.fc25.src.
> rpm

No problem, but I meant playlists should be changed to play-lists without the
quotes ;)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1359914] Review Request: lollypop - Music player for GNOME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1359914



--- Comment #30 from MartinKG  ---
(In reply to Jeremy Newton from comment #29)
> Just some documentation fixes to silence some rpmlint warnings:
> 
> - Use the following for portal's description:
> Summary:Lollypop flatpak portal (advanced features)
> 
> - youtube should be spelt YouTube
> 
> - playlists I believe should be "play-lists"
> 
> But other than that, looks good! Approved!
> 
> Remember to fix these before submitting.

changes done.
Thanks for the review.

Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/lollypop.spec
SRPM URL:
https://martinkg.fedorapeople.org/Review/SRPMS/lollypop-0.9.223-3.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1359914] Review Request: lollypop - Music player for GNOME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1359914

Jeremy Newton  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #29 from Jeremy Newton  ---
Just some documentation fixes to silence some rpmlint warnings:

- Use the following for portal's description:
Summary:Lollypop flatpak portal (advanced features)

- youtube should be spelt YouTube

- playlists I believe should be "play-lists"

But other than that, looks good! Approved!

Remember to fix these before submitting.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1359914] Review Request: lollypop - Music player for GNOME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1359914



--- Comment #28 from MartinKG  ---
(In reply to Jeremy Newton from comment #27)
> (In reply to MartinKG from comment #26)
> 
> The issue of the portal dependency still exists. lollypop should require
> lollypop-portal, not the other way around.
> 
> Right now portal has the following requirement:
> > Requires:   %{name} = %{version}-%{release}
> 
> This should be removed and the following should be added on the base package:
> > Requires:   %{name}-portal = %{version}-%{release}
> 
> This also allows a user to only install lollypop-portal, if they wish to use
> the flatpak instead.

done
> 
> As well, is --prefix=/usr should not be used for autogen.sh. I would
> personally suggestion running autogen with NOCONFIGURE set, thus to prevent
> configure from running, then configure using the %configure macro.
> 
> I'm assuming something like this would work:
> > pushd %{subpkg}-%{commit0}
> > NOCONFIGURE=1 ./autogen.sh
> > %configure
> > popd

done 


Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/lollypop.spec
SRPM URL:
https://martinkg.fedorapeople.org/Review/SRPMS/lollypop-0.9.223-2.fc25.src.rpm

%changelog
* Sat Dec 10 2016 Martin Gansser  - 0.9.223-2
- Add Requires to base package
- Remove Requires on the subpkg lollypop-portal
- Add NOCONFIGURE=1 ./autogen.sh to subpkg lollypop-portal

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1359914] Review Request: lollypop - Music player for GNOME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1359914



--- Comment #27 from Jeremy Newton  ---
(In reply to MartinKG from comment #26)
> Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/lollypop.spec
> SRPM URL:
> https://martinkg.fedorapeople.org/Review/SRPMS/lollypop-0.9.223-1.fc25.src.
> rpm
> 
> %changelog
> * Fri Dec 09 2016 Martin Gansser  - 0.9.223-1
> - Update to 0.9.223
> - Add subpkg lollypop-cli

The issue of the portal dependency still exists. lollypop should require
lollypop-portal, not the other way around.

Right now portal has the following requirement:
> Requires:   %{name} = %{version}-%{release}

This should be removed and the following should be added on the base package:
> Requires:   %{name}-portal = %{version}-%{release}

This also allows a user to only install lollypop-portal, if they wish to use
the flatpak instead.

As well, is --prefix=/usr should not be used for autogen.sh. I would personally
suggestion running autogen with NOCONFIGURE set, thus to prevent configure from
running, then configure using the %configure macro.

I'm assuming something like this would work:
> pushd %{subpkg}-%{commit0}
> NOCONFIGURE=1 ./autogen.sh
> %configure
> popd

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1359914] Review Request: lollypop - Music player for GNOME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1359914



--- Comment #26 from MartinKG  ---
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/lollypop.spec
SRPM URL:
https://martinkg.fedorapeople.org/Review/SRPMS/lollypop-0.9.223-1.fc25.src.rpm

%changelog
* Fri Dec 09 2016 Martin Gansser  - 0.9.223-1
- Update to 0.9.223
- Add subpkg lollypop-cli

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1359914] Review Request: lollypop - Music player for GNOME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1359914



--- Comment #25 from Jeremy Newton  ---
If I understand correctly, lollypop should require lollypop-portal, not the
other way around.

As well, is it possible to subpackage the CLI?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1359914] Review Request: lollypop - Music player for GNOME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1359914



--- Comment #24 from MartinKG  ---
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/lollypop.spec
SRPM URL:
https://martinkg.fedorapeople.org/Review/SRPMS/lollypop-0.9.222-1.fc25.src.rpm

%changelog
* Thu Dec 08 2016 Martin Gansser  - 0.9.222-1
- Update to 0.9.222
- Set correct file permission
- Add subpkg lollypop-portal

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1359914] Review Request: lollypop - Music player for GNOME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1359914



--- Comment #23 from Jeremy Newton  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Package does not contain duplicates in %files.
  Note: warning: File listed twice: /usr/share/lollypop/lollypop-sp
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "GPL (v3 or later)", "*No copyright* CC by-sa (v3.0)", "MIT/X11
 (BSD like)", "Unknown or generated", "CC by-sa (v3.0)", "FSF All
 Permissive". 149 files have unknown license.
> The MIT and FSF All Permissive are install scripts, not source code.
> This is a non-issue in my opinion
[x]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/share/help/he, /usr/share/help/sk
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/help/fi,
 /usr/share/help/he, /usr/share/help/uk, /usr/share/help/de,
 /usr/share/help/sk, /usr/share/dbus-1/services, /usr/share/gnome-shell
 /search-providers, /usr/share/help/sv, /usr/share/help/sr,
 /usr/share/help/fr, /usr/share/help/C, /usr/share/help/nl,
 /usr/share/help/es, /usr/share/help/cs, /usr/share/help, /usr/share
 /gnome-shell, /usr/share/help/ca, /usr/share/help/pl,
 /usr/share/dbus-1, /usr/share/help/pt_BR, /usr/share/help/ru,
 /usr/share/help/it
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: glib-compile-schemas is run in %postun and %posttrans if package has
 *.gschema.xml files.
 Note: gschema file(s) in lollypop
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: update-desktop-database is invoked in %post and %postun if package
 contains desktop file(s) with a MimeType: entry.
 Note: desktop file(s) with MimeType entry in lollypop
[x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
 contains icons.
 Note: icons in lollypop
[-]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
 desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or 

[Bug 1359914] Review Request: lollypop - Music player for GNOME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1359914



--- Comment #22 from Jeremy Newton  ---
(In reply to Cédric Bellegarde from comment #21)
> lollypop-portal is a separate source, you will be forced to package it as a
> separate package.
> 
> DBus portal is not part of lollypop because it can't be part of flatpak
> package.

That shouldn't be necessary; RPM allows for multiple sources. As long Martin
makes sure the lollypop-portal files only make it into the "portal" subpackage,
this should work as intended.

Even if the user prefers to install the flatpak, they should be able to just
install the lollypop-portal package without requiring the lollypop package.
This is because the lollypop package should require lollypop-portal but not the
other way around.

With that said, it's ultimately Martin's choice how he wishes to package it.
Ultimately either decision is fine by me.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1359914] Review Request: lollypop - Music player for GNOME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1359914



--- Comment #21 from Cédric Bellegarde  ---
lollypop-portal is a separate source, you will be forced to package it as a
separate package.

DBus portal is not part of lollypop because it can't be part of flatpak
package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1359914] Review Request: lollypop - Music player for GNOME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1359914



--- Comment #20 from Jeremy Newton  ---
(In reply to MartinKG from comment #19)
> (In reply to Jeremy Newton from comment #18)
> > I'll take a look into this night or tomorrow.
> 
> You are welcome.
> 
> This information reached me on 2 December from the developer Cédric
> Bellegarde
> 
> Hello dear Lollypop packagers ;)
> 
> Next lollypop release will depends on this dbus service:
> https://github.com/gnumdk/lollypop-portal
> 
> So you will need to package it as well (and rpm packagers, make sure
> /usr/share/lollypop/lollypop-portal is +x).

You should be able to just make this a sub-package later on. I feel like it
would be a waste to make this a separate package.

As well, I'm not sure if you got my email, if you have time, can you swap with
me? I'm trying to move a bunch of packages from rpmfusion into Fedora due to
changes in Fedora's policies and I have two left. In return, I can help push
along your unassigned reviews.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1359914] Review Request: lollypop - Music player for GNOME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1359914



--- Comment #19 from MartinKG  ---
(In reply to Jeremy Newton from comment #18)
> I'll take a look into this night or tomorrow.

You are welcome.

This information reached me on 2 December from the developer Cédric Bellegarde

Hello dear Lollypop packagers ;)

Next lollypop release will depends on this dbus service:
https://github.com/gnumdk/lollypop-portal

So you will need to package it as well (and rpm packagers, make sure
/usr/share/lollypop/lollypop-portal is +x).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1359914] Review Request: lollypop - Music player for GNOME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1359914

Jeremy Newton  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||alexjn...@gmail.com
   Assignee|nob...@fedoraproject.org|alexjn...@gmail.com



--- Comment #18 from Jeremy Newton  ---
I'll take a look into this night or tomorrow.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1359914] Review Request: lollypop - Music player for GNOME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1359914



--- Comment #17 from MartinKG  ---
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/lollypop.spec
SRPM URL:
https://martinkg.fedorapeople.org/Review/SRPMS/lollypop-0.9.220-1.fc25.src.rpm

%changelog
* Fri Nov 25 2016 Martin Gansser  - 0.9.220-1
- Update to 0.9.220

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1359914] Review Request: lollypop - Music player for GNOME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1359914



--- Comment #16 from MartinKG  ---

(In reply to Cédric Bellegarde from comment #15)
> Hello,
> 
> since 0.9.217, you need to add this to SPEC file:
> %attr(755, root, root) %{_datadir}/%{name}/lollypop-sp
> 
> regards,
> --
> Cédric Bellegarde

thanks for the hint. Have you time to do a review ?

new packages:

Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/lollypop.spec
SRPM URL:
https://martinkg.fedorapeople.org/Review/SRPMS/lollypop-0.9.219-1.fc25.src.rpm

%changelog
* Wed Nov 23 2016 Martin Gansser  - 0.9.219-1
- Update to 0.9.219
- Add %%attr to correct file permisson

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1359914] Review Request: lollypop - Music player for GNOME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1359914

Cédric Bellegarde  changed:

   What|Removed |Added

 CC||cedric.bellegarde@adishatz.
   ||org



--- Comment #15 from Cédric Bellegarde  ---
Hello,

since 0.9.217, you need to add this to SPEC file:
%attr(755, root, root) %{_datadir}/%{name}/lollypop-sp

regards,
--
Cédric Bellegarde

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1359914] Review Request: lollypop - Music player for GNOME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1359914



--- Comment #14 from MartinKG  ---
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/lollypop.spec
SRPM URL:
https://martinkg.fedorapeople.org/Review/SRPMS/lollypop-0.9.216-1.fc25.src.rpm

%changelog
* Mon Nov 14 2016 Martin Gansser  - 0.9.216-1
* Update to 0.9.216

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1359914] Review Request: lollypop - Music player for GNOME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1359914



--- Comment #13 from MartinKG  ---
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/lollypop.spec
SRPM URL:
https://martinkg.fedorapeople.org/Review/SRPMS/lollypop-0.9.213-1.fc25.src.rpm

%changelog
* Mon Oct 24 2016 Martin Gansser  - 0.9.213-1
* Update to 0.9.213

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1359914] Review Request: lollypop - Music player for GNOME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1359914
Bug 1359914 depends on bug 1381132, which changed state.

Bug 1381132 Summary: Review Request: python-wikipedia - Wikipedia API for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1381132

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |NEXTRELEASE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1359914] Review Request: lollypop - Music player for GNOME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1359914



--- Comment #12 from MartinKG  ---
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/lollypop.spec
SRPM URL:
https://martinkg.fedorapeople.org/Review/SRPMS/lollypop-0.9.210-1.fc24.src.rpm

changelog
* Sat Oct 08 2016 Martin Gansser  - 0.9.210-1
* Update to 0.9.210

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1359914] Review Request: lollypop - Music player for GNOME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1359914



--- Comment #11 from MartinKG  ---
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/lollypop.spec
SRPM URL:
https://martinkg.fedorapeople.org/Review/SRPMS/lollypop-0.9.209-1.fc24.src.rpm

%changelog
* Thu Oct 06 2016 Martin Gansser  - 0.9.209-1
* Update to 0.9.209

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1359914] Review Request: lollypop - Music player for GNOME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1359914

MartinKG  changed:

   What|Removed |Added

 Depends On||1381132




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1381132
[Bug 1381132] Review Request: python-wikipedia - Wikipedia API for Python
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1359914] Review Request: lollypop - Music player for GNOME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1359914



--- Comment #10 from MartinKG  ---
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/lollypop.spec
SRPM URL:
https://martinkg.fedorapeople.org/Review/SRPMS/lollypop-0.9.206-1.fc24.src.rpm

%changelog
* Sun Oct 02 2016 Martin Gansser  - 0.9.206-1
* Update to 0.9.206

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1359914] Review Request: lollypop - Music player for GNOME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1359914



--- Comment #9 from MartinKG  ---
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/lollypop.spec
SRPM URL:
https://martinkg.fedorapeople.org/Review/SRPMS/lollypop-0.9.205-1.fc24.src.rpm


%changelog
* Mon Sep 26 2016 Martin Gansser  - 0.9.205-1
* Update to 0.9.205

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1359914] Review Request: lollypop - Music player for GNOME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1359914



--- Comment #8 from MartinKG  ---
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/lollypop.spec
SRPM URL:
https://martinkg.fedorapeople.org/Review/SRPMS/lollypop-0.9.204-1.fc24.src.rpm

%changelog
* Wed Sep 21 2016 Martin Gansser  - 0.9.204-1
* Update to 0.9.204-1
- Use full path for scriptlets
- Corrected ownership of %%{_datadir/%%{name}/ in file section
- Dropped Requires: gstreamer1


rpmlint -i lollypop.spec
/home/martin/rpmbuild/SRPMS/lollypop-0.9.204-1.fc24.src.rpm
/home/martin/rpmbuild/RPMS/noarch/lollypop-0.9.204-1.fc24.noarch.rpm
lollypop.noarch: W: no-manual-page-for-binary lollypop
Each executable in standard binary directories should have a man page.

2 packages and 1 specfiles checked; 0 errors, 1 warnings.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1359914] Review Request: lollypop - Music player for GNOME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1359914

leigh scott  changed:

   What|Removed |Added

 CC||leigh123li...@googlemail.co
   ||m



--- Comment #7 from leigh scott  ---
The scriptlets are wrong, use the full path.

see

https://fedoraproject.org/wiki/Packaging:Scriptlets?rd=Packaging:ScriptletSnippets#desktop-database


also there is no need for the %dir

change from

%dir %{_datadir}/%{name}
%{_datadir}/%{name}/%{name}.gresource


to

%{_datadir}/%{name}/

this way it owns the directory and everything in it


There is no need to require gstreamer1 as gstreamer1-plugins-base requires it

change from

Requires:   gstreamer1-plugins-base, gstreamer1

to

Requires:   gstreamer1-plugins-base

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1359914] Review Request: lollypop - Music player for GNOME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1359914

MartinKG  changed:

   What|Removed |Added

 CC||anto.tra...@gmail.com



--- Comment #6 from MartinKG  ---
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/lollypop.spec
SRPM URL:
https://martinkg.fedorapeople.org/Review/SRPMS/lollypop-0.9.202-1.fc24.src.rpm

%changelog
* Sun Sep 18 2016 Martin Gansser  - 0.9.202-1
* Update to 0.9.202-1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1359914] Review Request: lollypop - Music player for GNOME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1359914



--- Comment #5 from MartinKG  ---
@Itamar could you please finish the review ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1359914] Review Request: lollypop - Music player for GNOME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1359914



--- Comment #4 from MartinKG  ---
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/lollypop.spec
SRPM URL:
https://martinkg.fedorapeople.org/Review/SRPMS/lollypop-0.9.112-2.fc24.src.rpm

%changelog
* Mon Aug 01 2016 Martin Gansser  - 0.9.112-2
- Added pylast Requirement

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1359914] Review Request: lollypop - Music player for GNOME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1359914

Itamar Reis Peixoto  changed:

   What|Removed |Added

 QA Contact|extras...@fedoraproject.org |ita...@ispbrasil.com.br
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1359914] Review Request: lollypop - Music player for GNOME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1359914



--- Comment #3 from Itamar Reis Peixoto  ---
pylast appears to be in the repo, you probably missed to add it in Build /
requires


pylast.noarch : A Python interface to Last.fm API compatible social networks
python3-pylast.noarch : A Python interface to Last.fm API compatible social
networks

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1359914] Review Request: lollypop - Music player for GNOME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1359914

Itamar Reis Peixoto  changed:

   What|Removed |Added

 CC||ita...@ispbrasil.com.br



--- Comment #2 from Itamar Reis Peixoto  ---
No module named 'pylast'
- Scrobbler disabled
- Auto cover download disabled
- Artist informations disabled
$ sudo pip3 install pylast
No module named 'wikipedia'
Advanced artist informations disabled
$ sudo pip3 install wikipedia

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1359914] Review Request: lollypop - Music player for GNOME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1359914

MartinKG  changed:

   What|Removed |Added

URL||http://gnumdk.github.io/lol
   ||lypop/
Summary|Review Request: |Review Request: lollypop -
   |xt7-player-mpv - Qt/Gambas  |Music player for GNOME
   |gui to mpv media player |



--- Comment #1 from MartinKG  ---
correct Description: Lollypop is a new GNOME music playing application.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org