[Bug 1362130] Review Request: olpcau-abc123-fonts - A nice font for kids/readability

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1362130

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |INSUFFICIENT_DATA
Last Closed||2019-09-17 15:37:10



--- Comment #10 from Zbigniew Jędrzejewski-Szmek  ---
Let's close this. Feel free to restart the process at any time.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1362130] Review Request: olpcau-abc123-fonts - A nice font for kids/ readability

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1362130



--- Comment #9 from Zbigniew Jędrzejewski-Szmek  ---
Hi, sorry for the long silence. I went away on vacation and then completely
forgot about this. For the future, in such cases, it often helps to send a ping
after a week or two, just to get things going again. Let's get this ball
rolling again!

I looked at your comments on those reviews, but they are a bit scant. Before I
asked you for a fedora-review run on #1388945. I'd like to know that you have
set up mock and can do test builds there. Can you please do a review of one
more package, this time using fedora-review as the starting point?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1362130] Review Request: olpcau-abc123-fonts - A nice font for kids/ readability

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1362130



--- Comment #8 from Sam P.  ---
Thanks, I have updated the package to fix the typo:

Spec URL: 
http://copr-dist-git.fedorainfracloud.org/cgit/samtoday/olpcau-abc123-fonts/olpcau-abc123-fonts.git/plain/olpcau-abc123-fonts.spec?id=307918b5e8beba9bf988a93badfcc34ea0fedeec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/samtoday/olpcau-abc123-fonts/fedora-25-x86_64/00476808-olpcau-abc123-fonts/olpcau-abc123-fonts-20130716-3.fc25.src.rpm

I also found 2 packages that I have reviewed:

* https://bugzilla.redhat.com/show_bug.cgi?id=1388945
* https://bugzilla.redhat.com/show_bug.cgi?id=1377631

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1362130] Review Request: olpcau-abc123-fonts - A nice font for kids/ readability

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1362130

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

  Flags||fedora-review?



--- Comment #7 from Zbigniew Jędrzejewski-Szmek  ---
developed for literacy John Greatorex → missing "by"

The package looks good. I'll approve the package once you are sponsored into
the packagers group. Any chance you could review some other packages?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1362130] Review Request: olpcau-abc123-fonts - A nice font for kids/ readability

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1362130

Sam P.  changed:

   What|Removed |Added

  Flags|needinfo?(sam@sam.today)|



--- Comment #6 from Sam P.  ---
Thanks for the review Zbigniew!

> I don't think you have to copy sources in %prep. This breaks 'fedpkg local' 
> builds too.

I tried removing the copy, and it continued to work via mock and rpmbuild
locally on my computer.  However, it caused it to fail when building on COPR
[1].  So I kept it in the end.

I've updated the package:

Spec URL: 
http://copr-dist-git.fedorainfracloud.org/cgit/samtoday/olpcau-abc123-fonts/olpcau-abc123-fonts.git/plain/olpcau-abc123-fonts.spec?id=68ad2759b09e46cd16f1ac7e3935c6bcce1766a7
 
SRPM URL: 
https://copr-be.cloud.fedoraproject.org/results/samtoday/olpcau-abc123-fonts/fedora-25-x86_64/00476460-olpcau-abc123-fonts/olpcau-abc123-fonts-20130716-2.fc25.src.rpm

[1]
https://copr.fedorainfracloud.org/coprs/samtoday/olpcau-abc123-fonts/build/476456/
and
https://copr-be.cloud.fedoraproject.org/results/samtoday/olpcau-abc123-fonts/fedora-25-x86_64/00476456-olpcau-abc123-fonts/build.log.gz

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1362130] Review Request: olpcau-abc123-fonts - A nice font for kids/ readability

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1362130

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 CC||sam@sam.today
  Flags||needinfo?(sam@sam.today)



--- Comment #5 from Zbigniew Jędrzejewski-Szmek  ---
Any progress?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1362130] Review Request: olpcau-abc123-fonts - A nice font for kids/ readability

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1362130

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1362130] Review Request: olpcau-abc123-fonts - A nice font for kids/ readability

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1362130



--- Comment #4 from Parag AN(पराग)  ---
I am using this as general practice that let the review be on completion along
with sponsorship process requirements and then remove 177841 and sponsor. 

If you are ready to sponsor then first step is to assign the review to yourself
and change the flag to fedora-review? This will make sure other sponsors that
you already picked this for review and then will be knowing you will complete
the sponsorship.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1362130] Review Request: olpcau-abc123-fonts - A nice font for kids/ readability

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1362130



--- Comment #3 from Zbigniew Jędrzejewski-Szmek  ---
I'm not sure ;) I unset the flag when I make the offer to sponsor someone
because I assume that other sponsors are looking at bugs with that flag for
people to sponsor. Please correct me if that's not the case.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1362130] Review Request: olpcau-abc123-fonts - A nice font for kids/ readability

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1362130

Parag AN(पराग)  changed:

   What|Removed |Added

 CC||panem...@gmail.com



--- Comment #2 from Parag AN(पराग)  ---
Zbigniew,

Just my thought here that removal of 177841 at this stage looks a proactive
action here. Generally we (Sponsor) make sure that package submitter is having
a understanding of rpm packaging by asking him/her to review others packages
waiting for their reviews and complete this package review and then remove the
177841 blocker.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1362130] Review Request: olpcau-abc123-fonts - A nice font for kids/ readability

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1362130

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 CC||zbys...@in.waw.pl
 Blocks|177841 (FE-NEEDSPONSOR) |



--- Comment #1 from Zbigniew Jędrzejewski-Szmek  ---
The Spec URL doesn't seem to work for me, I'm using
http://copr-dist-git.fedorainfracloud.org/cgit/samtoday/olpcau-abc123-fonts/olpcau-abc123-fonts.git/commit/?h=f24

Summary should not repeat the package name. It also doesn't need the leading
article (it looks better in listing if there's no article, since otherwise
almost everything would start with "A").

Group: User Interface/X
→ not used
[https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections]

I don't think you have to copy sources in %prep. This breaks 'fedpkg local'
builds too.

appstream-util validate-relax --nonet should be added in %check:
https://fedoraproject.org/wiki/Packaging:AppData#app-data-validate_usage.

You should also run full validation locally with "validate" and fix issues:
olpcau-abc123.metainfo.xml: FAILED:
• style-invalid :  requires sentence case [abc123, a typeface
developed for literacy]
Validation of files failed

Package looks good.

--

I can sponsor you into the packager group. Apart from fixing the few issues
pointed out above, I would like you to do two or three reviews of other
packages (https://fedoraproject.org/PackageReviewStatus/NEW.html is a good
start) and to be familiar with mock, fedora-review, etc. There's a bunch of
fonts packages waiting for review, so you might want to take those (or not,
whatever you prefer). Until you're a packager, you cannot formally approve a
package, so please don't assign the review to yourself, just paste whatever
comments you have. If nobody beats you to it, you will be able to formally
approve those packages after you become packager. If you have any questions,
feel free to mail me, or ping on IRC (I'm "zbyszek" everywhere).


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1362130] Review Request: olpcau-abc123-fonts - A nice font for kids/ readability

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1362130

Sam P.  changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org