[Bug 1376635] Review Request: ostrichriders - Knights flying on ostriches compete against other riders

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376635

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-07-17 00:53:02



--- Comment #11 from Fedora Update System  ---
ostrichriders-0.6.4-2.fc26 has been pushed to the Fedora 26 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376635] Review Request: ostrichriders - Knights flying on ostriches compete against other riders

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376635

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #10 from Fedora Update System  ---
ostrichriders-0.6.4-2.fc26 has been pushed to the Fedora 26 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-0de7a42c6d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376635] Review Request: ostrichriders - Knights flying on ostriches compete against other riders

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376635



--- Comment #9 from Fedora Update System  ---
ostrichriders-0.6.4-2.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-0de7a42c6d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376635] Review Request: ostrichriders - Knights flying on ostriches compete against other riders

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376635

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376635] Review Request: ostrichriders - Knights flying on ostriches compete against other riders

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376635



--- Comment #8 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/ostrichriders

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376635] Review Request: ostrichriders - Knights flying on ostriches compete against other riders

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376635



--- Comment #7 from Andrea Musuruane  ---
Dennis, can you go on with the process and make an SCM admin request?
https://fedoraproject.org/wiki/Package_Review_Process

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376635] Review Request: ostrichriders - Knights flying on ostriches compete against other riders

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376635

Jon Ciesla  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #6 from Jon Ciesla  ---
Wow, I'm so sorry, I missed the above. . .for 6 months.  

Looks great, APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376635] Review Request: ostrichriders - Knights flying on ostriches compete against other riders

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376635



--- Comment #5 from Dennis Payne  ---
To my knowledge, all review issues have been fixed and I'm just waiting for it
to be approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376635] Review Request: ostrichriders - Knights flying on ostriches compete against other riders

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376635

terrycloth  changed:

   What|Removed |Added

 CC||and...@tosk.in



--- Comment #4 from terrycloth  ---
What's the status on ostrichriders?

I'm looking to do package reviews as part of joining the official packagers
group. I'm also just interested in adding more games to Fedora. So I can help
get this moving again, if you're still interested in maintaining this package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376635] Review Request: ostrichriders - Knights flying on ostriches compete against other riders

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376635



--- Comment #3 from Dennis Payne  ---
Spec URL: https://github.com/dulsi/ostrichriders/raw/master/ostrichriders.spec
SRPM URL:
http://identicalsoftware.com/ostrichriders/ostrichriders-0.6.4-2.fc24.src.rpm

I've left in the group for now but did the other changes. I'm not sure I agree
with the hicolor-icon-theme requirement. I found this discussion of it:

https://fedorahosted.org/fpc/ticket/632

In the end I decided to just add it as I don't feel it matters enough.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376635] Review Request: ostrichriders - Knights flying on ostriches compete against other riders

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376635

Jon Ciesla  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||limburg...@gmail.com
   Assignee|nob...@fedoraproject.org|limburg...@gmail.com
  Flags||fedora-review?



--- Comment #2 from Jon Ciesla  ---
- rpmlint checks return:

ostrichriders.x86_64: W: no-manual-page-for-binary ostrichriders
Each executable in standard binary directories should have a man page.

Nice to have but not critical.

- package meets naming guidelines
- package meets packaging guidelines
- license ( GPLv3+ ) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file 

So, it's just the things Andrea called out.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376635] Review Request: ostrichriders - Knights flying on ostriches compete against other riders

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376635

Andrea Musuruane  changed:

   What|Removed |Added

 CC||musur...@gmail.com



--- Comment #1 from Andrea Musuruane  ---
I had a quick glance at the spec file and I noticed the following issues:

- you can drop the Group tag
https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections

- you must Requires: hicolor-icon-theme because you install files in
%{_datadir}/icons/hicolor/

- you may change "make %{?_smp_mflags}" in %make_build

- you may change "make DESTDIR=%{buildroot} PREFIX=%{_prefix} install" in
"%make_install PREFIX=%{_prefix}"

- you must remove LICENCE from %doc and add it to %license
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text

- you must run appstream-util validate-relax (in %check or %install) and have
BuildRequires: libappstream-glib
https://fedoraproject.org/wiki/Packaging:AppData#app-data-validate_usage

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1376635] Review Request: ostrichriders - Knights flying on ostriches compete against other riders

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376635

Ben Rosser  changed:

   What|Removed |Added

 CC||rosser@gmail.com
 Blocks||1364745 (FE-GAMESIG)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1364745
[Bug 1364745] Games SIG tracker bug
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org