[Bug 1391334] Review Request: freeorion - Turn-based space empire and galactic conquest (4X) computer game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391334



--- Comment #21 from Fedora Update System  ---
freeorion-0.4.6-5.fc24 has been pushed to the Fedora 24 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1391334] Review Request: freeorion - Turn-based space empire and galactic conquest (4X) computer game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391334

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-01-12 00:22:36



--- Comment #20 from Fedora Update System  ---
freeorion-0.4.6-5.fc25 has been pushed to the Fedora 25 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1391334] Review Request: freeorion - Turn-based space empire and galactic conquest (4X) computer game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391334



--- Comment #19 from Fedora Update System  ---
freeorion-0.4.6-5.fc25 has been pushed to the Fedora 25 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-0d7eb3c1fa

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1391334] Review Request: freeorion - Turn-based space empire and galactic conquest (4X) computer game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391334

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #18 from Fedora Update System  ---
freeorion-0.4.6-5.fc24 has been pushed to the Fedora 24 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-2f6eb8f93b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1391334] Review Request: freeorion - Turn-based space empire and galactic conquest (4X) computer game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391334



--- Comment #17 from Fedora Update System  ---
freeorion-0.4.6-5.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-2f6eb8f93b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1391334] Review Request: freeorion - Turn-based space empire and galactic conquest (4X) computer game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391334

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1391334] Review Request: freeorion - Turn-based space empire and galactic conquest (4X) computer game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391334



--- Comment #16 from Fedora Update System  ---
freeorion-0.4.6-5.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-0d7eb3c1fa

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1391334] Review Request: freeorion - Turn-based space empire and galactic conquest (4X) computer game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391334



--- Comment #15 from Fedora Update System  ---
freeorion-0.4.6-4.fc24 has been pushed to the Fedora 24 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-2f6eb8f93b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1391334] Review Request: freeorion - Turn-based space empire and galactic conquest (4X) computer game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391334

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #14 from Fedora Update System  ---
freeorion-0.4.6-4.fc25 has been pushed to the Fedora 25 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-0d7eb3c1fa

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1391334] Review Request: freeorion - Turn-based space empire and galactic conquest (4X) computer game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391334



--- Comment #13 from Link Dupont  ---
Quick followup on the rpmlint incorrect-fsf-address warning. The address listed
in the COPYING file appears correct. I'm not sure if it's a false positive
somehow coming out of rpmlint. When I grep -E the COPYING file directly using
the regex from rpmlint's FilesCheck.py, it does _not_ match. I filed an issue
with rpmlint[1] about this, but I'm comfortable ignoring the rpmlint error
here. The address in the COPYING file is correct.

1: https://github.com/rpm-software-management/rpmlint/issues/85

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1391334] Review Request: freeorion - Turn-based space empire and galactic conquest (4X) computer game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391334



--- Comment #12 from Fedora Update System  ---
freeorion-0.4.6-4.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-0d7eb3c1fa

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1391334] Review Request: freeorion - Turn-based space empire and galactic conquest (4X) computer game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391334



--- Comment #11 from Fedora Update System  ---
freeorion-0.4.6-4.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-2f6eb8f93b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1391334] Review Request: freeorion - Turn-based space empire and galactic conquest (4X) computer game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391334

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1391334] Review Request: freeorion - Turn-based space empire and galactic conquest (4X) computer game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391334



--- Comment #10 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/freeorion

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1391334] Review Request: freeorion - Turn-based space empire and galactic conquest (4X) computer game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391334

Antonio Trande  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #9 from Antonio Trande  ---
LGPLv2+, not LGPLv2.

Package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1391334] Review Request: freeorion - Turn-based space empire and galactic conquest (4X) computer game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391334



--- Comment #8 from Link Dupont  ---
Good catch. It falls back to DejaVu-Sans if it can't find Roboto, but I
symlinked those two fonts into default/data/fonts anyway.

Spec URL:
https://fedorapeople.org/cgit/linkdupont/public_git/freeorion.git/plain/freeorion.spec
SRPM URL:
https://fedorapeople.org/~linkdupont/srpms/freeorion-0.4.6-4.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1391334] Review Request: freeorion - Turn-based space empire and galactic conquest (4X) computer game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391334



--- Comment #7 from Antonio Trande  ---
(In reply to Link Dupont from comment #6)
> It does run without those fonts in that path. I assumed it would fall back
> to the system-provided fonts, and it appears I was lucky it did. So no need
> to symlink to system-level fonts. Pulling them in via Requires: was
> sufficient.
> 
> The only contents in %{_datadir}/%{name}/default/data/fonts were the *.ttf
> files and some README/licenses.

mmh..
dejavu-sans-fonts and google-roboto-fonts use different paths. Please, create
the symlinks to be sure.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1391334] Review Request: freeorion - Turn-based space empire and galactic conquest (4X) computer game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391334



--- Comment #6 from Link Dupont  ---
It does run without those fonts in that path. I assumed it would fall back to
the system-provided fonts, and it appears I was lucky it did. So no need to
symlink to system-level fonts. Pulling them in via Requires: was sufficient.

The only contents in %{_datadir}/%{name}/default/data/fonts were the *.ttf
files and some README/licenses.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1391334] Review Request: freeorion - Turn-based space empire and galactic conquest (4X) computer game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391334



--- Comment #5 from Antonio Trande  ---
>rm -rf %{buildroot}%{_datadir}/%{name}/default/data/fonts

Have you tested freeorion?
Does it use the icons?

Usually, bundled icons are replaced with symbolic links to system icons.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1391334] Review Request: freeorion - Turn-based space empire and galactic conquest (4X) computer game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391334



--- Comment #4 from Link Dupont  ---
Updated Spec and SRPM:

Spec URL:
https://fedorapeople.org/cgit/linkdupont/public_git/freeorion.git/plain/freeorion.spec
SRPM URL:
https://fedorapeople.org/~linkdupont/srpms/freeorion-0.4.6-3.fc26.src.rpm

I have a koji scratch build pending:
http://koji.fedoraproject.org/koji/taskinfo?taskID=16546329

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1391334] Review Request: freeorion - Turn-based space empire and galactic conquest (4X) computer game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391334



--- Comment #3 from Antonio Trande  ---
(In reply to Link Dupont from comment #2)
> Thank you for the review! This raised a couple questions when I was
> examining the issues.
> 
> 1) FreeOrion appears to bundle libGiGi
> FreeOrion bundles libGiGi. There is an external libGiGi project, but during
> my research, I found that Debian supports bundling libGiGi with their
> freeorion package. This excerpt from their README.source file:
> 
> Bundled GG (libgigi) library:
>  At the moment GG is not feasible to maintain separately:
>   * It is used exclusively by freeorion.
>   * FreeOrion maintains a fork of GG in FreeOrion's source tree.
>   * FreeOrion's GG fork is better maintained and needs less patches.
> * For example the original libgigi library doesn't build with gcc-4.7
>   (requires gcc-4.6) while from FreeOrion's source tree
>   it builds fine with gcc-4.7 and doesn't need the "vector.patch".
>   * GG is not a proper library (more like a plugin) and therefore
> not suitable for packaging as a standalone libgigi(-dev) package.
> 
> Would I need to submit a bundle library exception to the FPC for this?

No; libGiGi is not officially packed on Fedora, it's simply a library provided
by freeorion.

> 
> 2) FSF address incorrect
> 
> I noticed a rpmlint warning about an incorrect FSF address. When I looked at
> the COPYING file shipped by upstream, it does have the correct address. The
> only difference was a comma (,) inserted between the ZIP code and the
> country. I feel like ignoring this lint error is okay, since the address is
> correct, just formatted funny.

Don't modify the FSF address youself, but point out these lacks to upstream.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1391334] Review Request: freeorion - Turn-based space empire and galactic conquest (4X) computer game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391334



--- Comment #2 from Link Dupont  ---
Thank you for the review! This raised a couple questions when I was examining
the issues.

1) FreeOrion appears to bundle libGiGi
FreeOrion bundles libGiGi. There is an external libGiGi project, but during my
research, I found that Debian supports bundling libGiGi with their freeorion
package. This excerpt from their README.source file:

Bundled GG (libgigi) library:
 At the moment GG is not feasible to maintain separately:
  * It is used exclusively by freeorion.
  * FreeOrion maintains a fork of GG in FreeOrion's source tree.
  * FreeOrion's GG fork is better maintained and needs less patches.
* For example the original libgigi library doesn't build with gcc-4.7
  (requires gcc-4.6) while from FreeOrion's source tree
  it builds fine with gcc-4.7 and doesn't need the "vector.patch".
  * GG is not a proper library (more like a plugin) and therefore
not suitable for packaging as a standalone libgigi(-dev) package.

Would I need to submit a bundle library exception to the FPC for this?

2) FSF address incorrect

I noticed a rpmlint warning about an incorrect FSF address. When I looked at
the COPYING file shipped by upstream, it does have the correct address. The
only difference was a comma (,) inserted between the ZIP code and the country.
I feel like ignoring this lint error is okay, since the address is correct,
just formatted funny.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1391334] Review Request: freeorion - Turn-based space empire and galactic conquest (4X) computer game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391334



--- Comment #1 from Antonio Trande  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Package contains BR: python2-devel or python3-devel
  Use python2-devel

- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file LICENSE.DejaVu is not marked as %license
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text

- freeorion is built with GiGi support (GG/src directory) and linked against
  libGiGi.so private library.
  GG (like util/XMLDoc.cpp) is provided under LGPLv2+ license 

- Unbundle font files please.

- /usr/lib64/freeorion is not owned

- CC-BY-SA-3.0 is not correct; use CC-BY-SA

- Main package and sub-package are inter-dependent.
  You can remove

Requires: %{name}%{?_isa} = %{version}-%{release}

  from freeorion-data

- Fix following errors

freeorion-data.noarch: E: wrong-script-interpreter
/usr/share/freeorion/default/python/tests/run_tests.py /usr/bin/env python2.7
freeorion-data.noarch: E: non-executable-script
/usr/share/freeorion/default/python/tests/run_tests.py 644 /usr/bin/env
python2.7

- Diff spec file in url and in SRPM (see rpmlint output)


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "LGPL (v2.1 or later) (with incorrect FSF address)", "GPL (v2
 or later)", "Unknown or generated", "LGPL (v2.1 or later) LGPL (v2.1
 or later) (with incorrect FSF address)", "BSL (v1.0)", "BSL",
 "zlib/libpng LGPL (v2.1 or later) LGPL (v2.1 or later) (with incorrect
 FSF address)". 547 files have unknown license. Detailed output of
 licensecheck in /home/sagitter/1391334-freeorion/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[!]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/lib64/freeorion
[!]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/lib64/freeorion
[x]: %build honors applicable compiler flags or justifies otherwise.
[!]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
 contains icons.
 Note: icons in freeorion
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 122880 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package 

[Bug 1391334] Review Request: freeorion - Turn-based space empire and galactic conquest (4X) computer game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391334

Antonio Trande  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|anto.tra...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1391334] Review Request: freeorion - Turn-based space empire and galactic conquest (4X) computer game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391334

Link Dupont  changed:

   What|Removed |Added

 Blocks||1364745 (FE-GAMESIG)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1364745
[Bug 1364745] Games SIG tracker bug
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org