[Bug 1431444] Review Request: molequeue - Desktop integration of high performance computing resources

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431444



--- Comment #14 from Fedora Update System  ---
molequeue-0.8.0-2.20161222giteb397e.fc25 has been pushed to the Fedora 25
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431444] Review Request: molequeue - Desktop integration of high performance computing resources

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431444

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-04-09 12:42:51



--- Comment #13 from Fedora Update System  ---
molequeue-0.8.0-2.20161222giteb397e.fc26 has been pushed to the Fedora 26
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431444] Review Request: molequeue - Desktop integration of high performance computing resources

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431444



--- Comment #12 from Fedora Update System  ---
molequeue-0.8.0-2.20161222giteb397e.fc26 has been pushed to the Fedora 26
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-c1b32a53bd

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431444] Review Request: molequeue - Desktop integration of high performance computing resources

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431444

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #11 from Fedora Update System  ---
molequeue-0.8.0-2.20161222giteb397e.fc25 has been pushed to the Fedora 25
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-833b73f0b0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431444] Review Request: molequeue - Desktop integration of high performance computing resources

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431444



--- Comment #9 from Fedora Update System  ---
molequeue-0.8.0-2.20161222giteb397e.fc25 has been submitted as an update to
Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-833b73f0b0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431444] Review Request: molequeue - Desktop integration of high performance computing resources

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431444



--- Comment #10 from Fedora Update System  ---
molequeue-0.8.0-2.20161222giteb397e.fc26 has been submitted as an update to
Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-c1b32a53bd

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431444] Review Request: molequeue - Desktop integration of high performance computing resources

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431444

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431444] Review Request: molequeue - Desktop integration of high performance computing resources

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431444



--- Comment #8 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/molequeue

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431444] Review Request: molequeue - Desktop integration of high performance computing resources

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431444



--- Comment #7 from Antonio Trande  ---
Thank you.

Spec URL: https://sagitter.fedorapeople.org/molequeue/molequeue.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/sagitter/avogadro2/fedora-25-x86_64/00528765-molequeue/molequeue-0.8.0-2.20161222giteb397e.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431444] Review Request: molequeue - Desktop integration of high performance computing resources

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431444



--- Comment #6 from Zbigniew Jędrzejewski-Szmek  ---
(I didn't check actual functionality, because I don't have the necessary setup,
but the app seems to be functional.)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431444] Review Request: molequeue - Desktop integration of high performance computing resources

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431444

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags||fedora-review+



--- Comment #5 from Zbigniew Jędrzejewski-Szmek  ---
Duh, I thought we got rid of those terrible icon cache scriptlets, but
apparently they are still required.

+ package name is OK
+ license is OK (BSD 3-clause)
+ license is specified correctly
+ builds and installs OK
+ scriptlets are OK
+ buildrequires, provides, requires look correct

One issue, my fault:
in the .desktop file:
-Name=HPC queuing system 
+Name=MoleQueue
+Comment=Manage HPC jobs from the system tray

(Name is displayed in search, and the text was too generic.)

Package is APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431444] Review Request: molequeue - Desktop integration of high performance computing resources

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431444



--- Comment #4 from Antonio Trande  ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #1)
> - Development (unversioned) .so files in -devel subpackage, if present.
>   Note: Unversioned so-files directly in %_libdir.
>   See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages
> Hm, upstream has unversioned libraries. So all users will have to be rebuilt
> in sync. It would be nice talk with upstream why this is a bad idea. Nothing
> you can do downstream though
> [https://www.redhat.com/archives/fedora-devel-list/2009-March/msg01155.html].
> 

Asked to upstream: https://github.com/OpenChemistry/molequeue/issues/17

Spec URL: https://sagitter.fedorapeople.org/molequeue/molequeue.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/sagitter/avogadro2/fedora-rawhide-x86_64/00528416-molequeue/molequeue-0.8.0-2.20161222giteb397e.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431444] Review Request: molequeue - Desktop integration of high performance computing resources

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431444



--- Comment #3 from Antonio Trande  ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #1)
> 
> You should run ldconfig scriptlets anyway, I think
> [https://fedoraproject.org/wiki/Packaging:Scriptlets#Shared_libraries].

I have fully ignored the 'ldscripts' in these rpms.
Scatterbrained.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431444] Review Request: molequeue - Desktop integration of high performance computing resources

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431444

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Blocks||1431445




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1431445
[Bug 1431445] Review Request: avogadro2-libs - Avogadro2 libraries
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431444] Review Request: molequeue - Desktop integration of high performance computing resources

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431444



--- Comment #2 from Zbigniew Jędrzejewski-Szmek  ---
%build
cat >molequeue.desktop <

[Bug 1431444] Review Request: molequeue - Desktop integration of high performance computing resources

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431444



--- Comment #1 from Zbigniew Jędrzejewski-Szmek  ---
- Development (unversioned) .so files in -devel subpackage, if present.
  Note: Unversioned so-files directly in %_libdir.
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages
Hm, upstream has unversioned libraries. So all users will have to be rebuilt in
sync. It would be nice talk with upstream why this is a bad idea. Nothing you
can do downstream though
[https://www.redhat.com/archives/fedora-devel-list/2009-March/msg01155.html].

You should run ldconfig scriptlets anyway, I think
[https://fedoraproject.org/wiki/Packaging:Scriptlets#Shared_libraries].

Why not python3? Ah, OK, the code does not seem to be python3 compatible. Too
bad.

.tar.gz would be preferable to .zip, they're 30% smaller usually.

This is a graphical application, it would be nice to add an appdata file
https://fedoraproject.org/wiki/Packaging:AppData, and a desktop file.
Especially the desktop file is important so that people can launch this without
going to the console. This is a specialized application, so the appdata can be
missing.

+ package name is OK
+ license is OK (BSD 3-clause)
+ license is specified correctly
+ builds and installs OK
- scriptlets are missing (see above)
+ buildrequires, provides, requires look correct

Looks good otherwise.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431444] Review Request: molequeue - Desktop integration of high performance computing resources

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431444

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zbys...@in.waw.pl
   Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431444] Review Request: molequeue - Desktop integration of high performance computing resources

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431444

Antonio Trande  changed:

   What|Removed |Added

 Blocks||1431448




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1431448
[Bug 1431448] Review Request: avogadro2 - Advanced molecular editor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431444] Review Request: molequeue - Desktop integration of high performance computing resources

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431444

Antonio Trande  changed:

   What|Removed |Added

 Blocks||1431172




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1431172
[Bug 1431172] RFE: update to avogadro2 (from github)
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org