[Bug 1471156] Review Request: berry - Modern and light image viewer
https://bugzilla.redhat.com/show_bug.cgi?id=1471156 mgans...@alice.de changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2017-08-24 06:47:04 --- Comment #12 from mgans...@alice.de --- package has been built successfully on f25, f26, f27 and rawhide. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1471156] Review Request: berry - Modern and light image viewer
https://bugzilla.redhat.com/show_bug.cgi?id=1471156 --- Comment #11 from mgans...@alice.de --- (In reply to Robert-André Mauchin from comment #10) > Add the license breakdown in comment. It doesn't show on the above spec. > > Otherwise it's good, package accepted. done. Thanks for the review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1471156] Review Request: berry - Modern and light image viewer
https://bugzilla.redhat.com/show_bug.cgi?id=1471156 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #10 from Robert-André Mauchin --- Add the license breakdown in comment. It doesn't show on the above spec. Otherwise it's good, package accepted. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1471156] Review Request: berry - Modern and light image viewer
https://bugzilla.redhat.com/show_bug.cgi?id=1471156 --- Comment #9 from mgans...@alice.de --- (In reply to Robert-André Mauchin from comment #8) > Hello, > > There's one last thing, some part of the code are licensed under BSD: > > BSD (3 clause) > -- > berry/asemantools/qml/AsemanTools/Controls/Styles/Desktop/CalendarStyle.qml > berry/asemantools/qml/AsemanTools/Controls/Styles/Desktop/FocusFrameStyle.qml > berry/asemantools/qml/AsemanTools/Controls/Styles/Desktop/MenuBarStyle.qml > berry/asemantools/qml/AsemanTools/Controls/Styles/Desktop/SliderStyle.qml > berry/asemantools/qml/AsemanTools/Controls/Styles/Desktop/StatusBarStyle.qml > berry/asemantools/qml/AsemanTools/Controls/Styles/Desktop/TableViewStyle.qml > berry/asemantools/qml/AsemanTools/Controls/Styles/Desktop/TextAreaStyle.qml > berry/asemantools/qml/AsemanTools/Controls/Styles/Desktop/ToolBarStyle.qml > > Even if the resulting package is GPL, it should be reflected in the License: > tag of the spec file, with a comment specifying which part is BSD. > sorry forgot to change the license part. Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/berry.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/berry-1.0.0-3.fc26.src.rpm %changelog * Wed Aug 23 2017 Martin Gansser - 1.0.0-3 - add license breakdown -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1471156] Review Request: berry - Modern and light image viewer
https://bugzilla.redhat.com/show_bug.cgi?id=1471156
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |ASSIGNED
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Flags||fedora-review?
--- Comment #8 from Robert-André Mauchin ---
Hello,
There's one last thing, some part of the code are licensed under BSD:
BSD (3 clause)
--
berry/asemantools/qml/AsemanTools/Controls/Styles/Desktop/CalendarStyle.qml
berry/asemantools/qml/AsemanTools/Controls/Styles/Desktop/FocusFrameStyle.qml
berry/asemantools/qml/AsemanTools/Controls/Styles/Desktop/MenuBarStyle.qml
berry/asemantools/qml/AsemanTools/Controls/Styles/Desktop/SliderStyle.qml
berry/asemantools/qml/AsemanTools/Controls/Styles/Desktop/StatusBarStyle.qml
berry/asemantools/qml/AsemanTools/Controls/Styles/Desktop/TableViewStyle.qml
berry/asemantools/qml/AsemanTools/Controls/Styles/Desktop/TextAreaStyle.qml
berry/asemantools/qml/AsemanTools/Controls/Styles/Desktop/ToolBarStyle.qml
Even if the resulting package is GPL, it should be reflected in the License:
tag of the spec file, with a comment specifying which part is BSD.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "BSD (3 clause)", "GPL (v2.1) LGPL (v2.1)", "LGPL (v2.1 or
v3)", "GPL (v3 or later)", "Unknown or generated". 179 files have
unknown license. Detailed output of licensecheck in
/home/bob/packaging/review/berry/review-berry/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
Note: No known owner of /usr/share/mime/application
[x]: Package must own all directories that it creates.
Note: Directories without known owners:
/usr/share/icons/hicolor/scalable/apps, /usr/share/mime,
/usr/share/icons/hicolor, /usr/share/mime/application,
/usr/share/icons/hicolor/scalable
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
contains icons.
Note: icons in berry
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %
[Bug 1471156] Review Request: berry - Modern and light image viewer
https://bugzilla.redhat.com/show_bug.cgi?id=1471156
--- Comment #7 from mgans...@alice.de ---
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/berry.spec
SRPM URL:
https://martinkg.fedorapeople.org/Review/SRPMS/berry-1.0.0-2.fc26.src.rpm
%changelog
* Tue Aug 22 2017 Martin Gansser - 1.0.0-2
- add %%{name}.appdata.xml
- dropped /sbin/ldconfig not needed
- dropped update-desktop-database should not be used on Fedora 24+
- dropped update-mime-info it's obsolete
- add %%find-lang to handle translation
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1471156] Review Request: berry - Modern and light image viewer
https://bugzilla.redhat.com/show_bug.cgi?id=1471156 --- Comment #6 from Robert-André Mauchin --- Disregard the translation comment above, it seems berry install its translations in a non-standard location. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1471156] Review Request: berry - Modern and light image viewer
https://bugzilla.redhat.com/show_bug.cgi?id=1471156
--- Comment #5 from Robert-André Mauchin ---
Use find-lang to handle translation. The -with-qt option finds *.qm files for
you.
%install
%find_lang %{name} --with-qt
%files -f %{name}.lang
See https://fedoraproject.org/wiki/PackagingDrafts/find_lang
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1471156] Review Request: berry - Modern and light image viewer
https://bugzilla.redhat.com/show_bug.cgi?id=1471156 --- Comment #4 from Robert-André Mauchin --- Similarly update-mime-info is obsolete. See: https://fedoraproject.org/w/index.php?title=Packaging:Scriptlets&oldid=481889#mimeinfo -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1471156] Review Request: berry - Modern and light image viewer
https://bugzilla.redhat.com/show_bug.cgi?id=1471156 --- Comment #3 from Robert-André Mauchin --- update-desktop-database should not be used on Fedora 24+. See https://fedoraproject.org/wiki/Packaging:Scriptlets#desktop-database -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1471156] Review Request: berry - Modern and light image viewer
https://bugzilla.redhat.com/show_bug.cgi?id=1471156 --- Comment #2 from Robert-André Mauchin --- My bad, gtk-update-icon-cache does need to be run in %posttrans -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1471156] Review Request: berry - Modern and light image viewer
https://bugzilla.redhat.com/show_bug.cgi?id=1471156 Robert-André Mauchin changed: What|Removed |Added CC||zebo...@gmail.com --- Comment #1 from Robert-André Mauchin --- Hello, - Why do you have: %postun /sbin/ldconfig There is no .so in this app, no need for ldconfig - gtk-update-icon-cache must be run in %post and %postun, not in %trans See the scriplet https://fedoraproject.org/wiki/PackagingDrafts/ScriptletSnippets#GTK.2B_icon_cache - update-mime-database is not needed in %trans either. - it would be great to include an Appdata file. See https://fedoraproject.org/wiki/Packaging:AppData - There are several files under BSD: BSD (3 clause) -- berry/asemantools/qml/AsemanTools/Controls/Styles/Desktop/CalendarStyle.qml berry/asemantools/qml/AsemanTools/Controls/Styles/Desktop/FocusFrameStyle.qml berry/asemantools/qml/AsemanTools/Controls/Styles/Desktop/MenuBarStyle.qml berry/asemantools/qml/AsemanTools/Controls/Styles/Desktop/SliderStyle.qml berry/asemantools/qml/AsemanTools/Controls/Styles/Desktop/StatusBarStyle.qml berry/asemantools/qml/AsemanTools/Controls/Styles/Desktop/TableViewStyle.qml berry/asemantools/qml/AsemanTools/Controls/Styles/Desktop/TextAreaStyle.qml berry/asemantools/qml/AsemanTools/Controls/Styles/Desktop/ToolBarStyle.qml Please include it in License: and detail what each license covers. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
