[Bug 1471806] Review Request: danmaq - A small client side Qt program to play danmaku on any screen

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1471806

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-08-23 15:53:48



--- Comment #26 from Fedora Update System  ---
danmaq-0.2-1.fc26 has been pushed to the Fedora 26 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1471806] Review Request: danmaq - A small client side Qt program to play danmaku on any screen

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1471806

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #25 from Fedora Update System  ---
danmaq-0.2-1.fc26 has been pushed to the Fedora 26 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-29f2713379

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1471806] Review Request: danmaq - A small client side Qt program to play danmaku on any screen

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1471806

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1471806] Review Request: danmaq - A small client side Qt program to play danmaku on any screen

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1471806



--- Comment #24 from Fedora Update System  ---
danmaq-0.2-1.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-29f2713379

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1471806] Review Request: danmaq - A small client side Qt program to play danmaku on any screen

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1471806



--- Comment #23 from Ralph Bean  ---
(fedrepo-req-admin):  Apologies for the delay!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1471806] Review Request: danmaq - A small client side Qt program to play danmaku on any screen

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1471806



--- Comment #22 from Ralph Bean  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/danmaq

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1471806] Review Request: danmaq - A small client side Qt program to play danmaku on any screen

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1471806



--- Comment #21 from Zamir SUN  ---
SPEC URL: https://zsun.fedorapeople.org/pub/pkgs/danmaq/danmaq.spec
SRPM URL:
https://zsun.fedorapeople.org/pub/pkgs/danmaq/danmaq-0.2-1.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1471806] Review Request: danmaq - A small client side Qt program to play danmaku on any screen

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1471806



--- Comment #20 from Zamir SUN  ---
(In reply to Zamir SUN from comment #19)
> (In reply to Zamir SUN from comment #16)
> > (In reply to Zbigniew Jędrzejewski-Szmek from comment #15)
> > > ... that said, if you strongly prefer "danmaQ", then just go ahead — the
> > > guidelines (the old and the new) allow camelCased names when there's good
> > > justification.
> In order to make it sync with other distributions - Now I will change it to
> lower case danmaq but leave the . Will edit corresponding tickets soon.
...leave the binary file unchanged.. Sorry I happened to click the submit
before finishing.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1471806] Review Request: danmaq - A small client side Qt program to play danmaku on any screen

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1471806

Zamir SUN  changed:

   What|Removed |Added

  Alias|danmaQ  |danmaq



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1471806] Review Request: danmaq - A small client side Qt program to play danmaku on any screen

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1471806

Zamir SUN  changed:

   What|Removed |Added

Summary|Review Request: danmaQ - A  |Review Request: danmaq - A
   |small client side Qt|small client side Qt
   |program to play danmaku on  |program to play danmaku on
   |any screen  |any screen



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1471806] Review Request: danmaQ - A small client side Qt program to play danmaku on any screen

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1471806



--- Comment #19 from Zamir SUN  ---
(In reply to Zamir SUN from comment #16)
> (In reply to Zbigniew Jędrzejewski-Szmek from comment #15)
> > ... that said, if you strongly prefer "danmaQ", then just go ahead — the
> > guidelines (the old and the new) allow camelCased names when there's good
> > justification.
In order to make it sync with other distributions - Now I will change it to
lower case danmaq but leave the . Will edit corresponding tickets soon.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1471806] Review Request: danmaQ - A small client side Qt program to play danmaku on any screen

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1471806



--- Comment #18 from Zamir SUN  ---

(In reply to sensor.wen from comment #17)
> - "_" prefix in macro names is not necessary.
> 
> %{_commit} -> %{commit}

Oh, thanks. Will change it when packaging into repo

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1471806] Review Request: danmaQ - A small client side Qt program to play danmaku on any screen

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1471806

sensor@gmail.com changed:

   What|Removed |Added

 CC||sensor@gmail.com



--- Comment #17 from sensor@gmail.com ---
- "_" prefix in macro names is not necessary.

%{_commit} -> %{commit}

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1471806] Review Request: danmaQ - A small client side Qt program to play danmaku on any screen

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1471806



--- Comment #16 from Zamir SUN  ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #15)
> ... that said, if you strongly prefer "danmaQ", then just go ahead — the
> guidelines (the old and the new) allow camelCased names when there's good
> justification.

Thanks. I will take this into consideration for future packaging.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1471806] Review Request: danmaQ - A small client side Qt program to play danmaku on any screen

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1471806



--- Comment #15 from Zbigniew Jędrzejewski-Szmek  ---
... that said, if you strongly prefer "danmaQ", then just go ahead — the
guidelines (the old and the new) allow camelCased names when there's good
justification.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1471806] Review Request: danmaQ - A small client side Qt program to play danmaku on any screen

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1471806



--- Comment #14 from Zbigniew Jędrzejewski-Szmek  ---
https://pagure.io/packaging-committee/issue/703

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1471806] Review Request: danmaQ - A small client side Qt program to play danmaku on any screen

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1471806



--- Comment #13 from Zbigniew Jędrzejewski-Szmek  ---
That's a typical case of Packaging Guidelines being internally inconsistent.
The rules were changed to prefer lowercase names recently (1-2 years ago), and
that bit of advice you linked to is from before 2008
[https://fedoraproject.org/w/index.php?title=Packaging:Naming=3672#Case_Sensitivity,
that's the first entry in history of this page], and nobody remembered to
update it.

I'd rather change both the executable name and package name to lowercase.
Camel-cased executable names are an abomination.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1471806] Review Request: danmaQ - A small client side Qt program to play danmaku on any screen

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1471806



--- Comment #12 from Zamir SUN  ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #11)
> One issue: the package should be called "danmaq". See
> https://fedoraproject.org/wiki/Packaging:Naming:
> > Package names should be in lower case [...]

Thanks for pointing this out.
In the upstream page, the developer stated it as danmaQ, to be clear, it
pronounces as danma Q (Q as the letter pronunciation). 
https://github.com/TUNA/danmaQ

I think this fits into the chapter "Case Sensitive" 
https://fedoraproject.org/wiki/Packaging:Naming#Case_Sensitivity
"Keep in mind to respect the wishes of the upstream maintainers". 
So I decide to keep it as danmaQ as lower case is a 'should' rule.

Can I take this as the justification? 

If this is not sufficient, I will change it before file request for repo.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1471806] Review Request: danmaQ - A small client side Qt program to play danmaku on any screen

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1471806

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 CC||zbys...@in.waw.pl



--- Comment #11 from Zbigniew Jędrzejewski-Szmek  ---
One issue: the package should be called "danmaq". See
https://fedoraproject.org/wiki/Packaging:Naming:
> Package names should be in lower case [...]

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1471806] Review Request: danmaQ - A small client side Qt program to play danmaku on any screen

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1471806

Felix Yan  changed:

   What|Removed |Added

 Status|ASSIGNED|POST



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1471806] Review Request: danmaQ - A small client side Qt program to play danmaku on any screen

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1471806

Felix Yan  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1471806] Review Request: danmaQ - A small client side Qt program to play danmaku on any screen

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1471806



--- Comment #10 from Felix Yan  ---
Looks good to me.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated



= MUST items =

C/C++:
[ ]: Package does not contain kernel modules.
[ ]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[ ]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[ ]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated". 25 files have unknown license. Detailed
 output of licensecheck in /root/1471806-danmaQ/licensecheck.txt
[ ]: License file installed when any subpackage combination is installed.
[ ]: Package must own all directories that it creates.
 Note: Directories without known owners:
 /usr/share/icons/hicolor/scalable/apps, /usr/share/icons/hicolor,
 /usr/share/icons/hicolor/scalable
[ ]: %build honors applicable compiler flags or justifies otherwise.
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory
 names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
 contains icons.
 Note: icons in danmaQ
[ ]: Useful -debuginfo package or justification otherwise.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
 desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[ ]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in danmaQ-
 debuginfo
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[ ]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[ ]: Package 

[Bug 1471806] Review Request: danmaQ - A small client side Qt program to play danmaku on any screen

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1471806

Felix Yan  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1471806] Review Request: danmaQ - A small client side Qt program to play danmaku on any screen

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1471806

Felix Yan  changed:

   What|Removed |Added

 CC||felixonm...@archlinux.org
   Assignee|nob...@fedoraproject.org|felixonm...@archlinux.org
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1471806] Review Request: danmaQ - A small client side Qt program to play danmaku on any screen

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1471806

Robert-André Mauchin  changed:

   What|Removed |Added

  Flags|needinfo?(zebo...@gmail.com |
   |)   |



--- Comment #9 from Robert-André Mauchin  ---
Sorry, I am having computer issues on the Windows side of things. 

The package is all good to me, you just need official approval now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1471806] Review Request: danmaQ - A small client side Qt program to play danmaku on any screen

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1471806

Zamir SUN  changed:

   What|Removed |Added

  Flags||needinfo?(zebo...@gmail.com
   ||)



--- Comment #8 from Zamir SUN  ---
Anything else that I need to fix before getting approved?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1471806] Review Request: danmaQ - A small client side Qt program to play danmaku on any screen

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1471806



--- Comment #7 from Zamir SUN  ---
(In reply to Robert-André Mauchin from comment #6)
> Ah indeed, I compiled locally insted of fedora-review and it passed fine.
> 
> Just one thing: you should use desktop-file-validate in %check.

Done. 

Spec URL: https://zsun.fedorapeople.org/pub/pkgs/danmaQ/danmaQ.spec
SRPM URL:
https://zsun.fedorapeople.org/pub/pkgs/danmaQ/danmaQ-0.2-1.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1471806] Review Request: danmaQ - A small client side Qt program to play danmaku on any screen

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1471806



--- Comment #6 from Robert-André Mauchin  ---
Ah indeed, I compiled locally insted of fedora-review and it passed fine.

Just one thing: you should use desktop-file-validate in %check.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1471806] Review Request: danmaQ - A small client side Qt program to play danmaku on any screen

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1471806



--- Comment #5 from Zamir SUN  ---
Updated.

Spec URL: https://zsun.fedorapeople.org/pub/pkgs/danmaQ/danmaQ.spec
SRPM URL:
https://zsun.fedorapeople.org/pub/pkgs/danmaQ/danmaQ-0.2-1.fc26.src.rpm

> danmaQ-debuginfo.x86_64: E: debuginfo-without-sources
After several hours test, I assume this is a bug with fedora-review. I assume
you configured your mock to use rawhide. If so, you can see it will generate a
danmaQ-debugsource-0.2-1.fc27.x86_64.rpm in results dir, while rpmlint
currently don't detect this one. RPMlint passed on Fedora 26.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1471806] Review Request: danmaQ - A small client side Qt program to play danmaku on any screen

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1471806

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com



--- Comment #4 from Robert-André Mauchin  ---
Hello,

A few comments

 - You should use %make_build instead of make %{?_smp_mflags}
 - You should add a Categories to your desktop file
 - /usr/bin/update-desktop-database &>/dev/null ||: is not needed as your
desktop file does not contain a MimeType key. See
https://fedoraproject.org/wiki/PackagingDrafts/ScriptletSnippets#desktop-database_.28Needs_description.29
 - In %files, line "%{_datadir}/icons/hicolor/*/apps/": aren't you missing a *
at the end or just statusicon.svg, since it's the only file.
 - The Group: tag mutn't be included in Fedora spec file. See:
https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections
 - %defattr(-,root,root,-) is not needed

You have a rpmlint error like on your other package:

 - debuginfo-without-sources:
This debuginfo package appears to contain debug symbols but no source files.
This is often a sign of binaries being unexpectedly stripped too early during
the build, or being compiled without compiler debug flags (which again often
is a sign of distro's default compiler flags ignored which might have security
consequences), or other compiler flags which result in rpmbuild's debuginfo
extraction not working as expected.  Verify that the binaries are not
unexpectedly stripped and that the intended compiler flags are used.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated". 25 files have unknown license. Detailed
 output of licensecheck in /home/bob/packaging/review/danmaQ/review-
 danmaQ/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[-]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/icons/hicolor,
 /usr/share/icons/hicolor/scalable
[!]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by:
 /usr/share/icons/hicolor/scalable/apps(hicolor-icon-theme, fedora-
 logos)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[!]: Each %files section contains %defattr if rpm < 4.4
 Note: %defattr present but not needed
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
 contains icons.
 Note: icons in danmaQ
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of 

[Bug 1471806] Review Request: danmaQ - A small client side Qt program to play danmaku on any screen

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1471806



--- Comment #3 from Zamir SUN  ---
Upstream tagged.

Spec URL: https://zsun.fedorapeople.org/pub/pkgs/danmaQ/
SRPM URL:
https://zsun.fedorapeople.org/pub/pkgs/danmaQ/danmaQ-0.2-1.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1471806] Review Request: danmaQ - A small client side Qt program to play danmaku on any screen

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1471806



--- Comment #2 from Zamir SUN  ---
I just realized the release is too long. Updated

Spec URL: https://zsun.fedorapeople.org/pub/pkgs/danmaQ/danmaQ.spec
SRPM URL:
https://zsun.fedorapeople.org/pub/pkgs/danmaQ/danmaQ-0-0.1.20170715git.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1471806] Review Request: danmaQ - A small client side Qt program to play danmaku on any screen

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1471806



--- Comment #1 from Zamir SUN  ---
The server side is https://dm.tuna.moe/?lang=en
It is open source as well but I am not packaging it at the moment. 
https://github.com/tuna/gdanmaku-server

> danmaQ.x86_64: W: hidden-file-or-dir /usr/lib/.build-id
This is not an issue of this package, see bug 1431408

> [ ]: License field in the package spec file matches the actual license.
>  Note: Checking patched sources after %prep for licenses. Licenses
>  found: "Unknown or generated". 25 files have unknown license. Detailed
>  output of licensecheck in ~/tmp/danmaq-review/review-
>  danmaQ/licensecheck.txt
It is GPLv3. I've filed an issue to ask them add licence announcement into each
file https://github.com/tuna/danmaQ/issues/18

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1471806] Review Request: danmaQ - A small client side Qt program to play danmaku on any screen

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1471806

Zamir SUN  changed:

   What|Removed |Added

  Alias||danmaQ



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org