[Bug 1475961] Review Request: cmrt - C for Media Runtime

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475961



--- Comment #12 from Fedora Update System  ---
cmrt-1.0.6-4.fc26 has been pushed to the Fedora 26 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475961] Review Request: cmrt - C for Media Runtime

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475961

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-08-27 02:22:41



--- Comment #11 from Fedora Update System  ---
cmrt-1.0.6-4.fc25 has been pushed to the Fedora 25 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475961] Review Request: cmrt - C for Media Runtime

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475961



--- Comment #10 from Fedora Update System  ---
cmrt-1.0.6-4.fc26 has been pushed to the Fedora 26 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-e727a51e23

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475961] Review Request: cmrt - C for Media Runtime

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475961

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #9 from Fedora Update System  ---
cmrt-1.0.6-4.fc25 has been pushed to the Fedora 25 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-c8bda49173

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475961] Review Request: cmrt - C for Media Runtime

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475961



--- Comment #8 from Fedora Update System  ---
cmrt-1.0.6-4.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-e727a51e23

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475961] Review Request: cmrt - C for Media Runtime

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475961

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475961] Review Request: cmrt - C for Media Runtime

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475961



--- Comment #7 from Robert-André Mauchin  ---
Thank you for your review and helpful comments.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475961] Review Request: cmrt - C for Media Runtime

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475961



--- Comment #6 from Zbigniew Jędrzejewski-Szmek  ---
You have been added to the packagers group. User your powers for good!
If you have any questions about packaging or issues with the process, feel free
to ping me (at my bugzilla e-mail, or 'zbyszek' on #fedora-devel).

You should now head over to
https://fedoraproject.org/wiki/Infrastructure/WhatHappenedToPkgdb#How_do_I_request_a_new_package_or_a_new_branch.
From what I heard yesterday, fedrepo-req is still in updates-testing, e,
actually only in rawhide. It seems you have to install it from koji!
https://apps.fedoraproject.org/packages/fedrepo-req/builds/, just great ;( If
you run into issues, #fedora-devel or #fedora-admin are probably the places to
ask.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475961] Review Request: cmrt - C for Media Runtime

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475961

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #5 from Zbigniew Jędrzejewski-Szmek  ---
+ package name is OK
+ license is acceptable for Fedora (MIT)
+ license is specified correctly
+ %license macro is used
+ builds and installs OK
+ P/R/BR look correct
+ scriptlets follow the guidelines

The source tarball contains a pre-compiled library: igfxcmjit32.so,
igfxcmjit64.so. That library is not present in the resulting binary rpm. Those
libs are BSD licensed. So it is not a problem that they are in the src rpm, as
long as they are not used.

I'm not sure what the effect of the lack of those precompiled objects is. I
hope cmrt is still usable without them. Debian packages is like that, so I
assume that it is.

Package is APPROVED.

A note for the future: please link directly to the raw spec file. Otherwise,
fedora-review and other tools have trouble. Also, koji scratch builds are not
good for the srpm. They are garbage-collected after a few weeks, and the srpm
should stay around "forever". Sometimes reviews get stalled, and the original
submitter goes away, and as a general policy it's good for another submitter or
reviewer to just pick the review up again at any time.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475961] Review Request: cmrt - C for Media Runtime

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475961



--- Comment #4 from Robert-André Mauchin  ---
I forgot the SOURCE0 URL fix.

SPEC: https://github.com/eclipseo/packaging/blob/223219f/cmrt.spec
SRPM:
https://kojipkgs.fedoraproject.org//work/tasks/6873/21066873/cmrt-1.0.6-4.fc27.src.rpm
Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=21066872

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475961] Review Request: cmrt - C for Media Runtime

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475961



--- Comment #3 from Robert-André Mauchin  ---
Thank you very much for taking the time to review.


I added a more detailed description, separated the BR for -devel, fixed
autosetup, used your command for removing *.la and removed %license from the
-devel package.

SPEC: https://github.com/eclipseo/packaging/blob/72ff61c/cmrt.spec
SRPM:
https://kojipkgs.fedoraproject.org//work/tasks/6721/21066721/cmrt-1.0.6-4.fc27.src.rpm
Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=21066720


I added my IRC nick to my FAS account, they're both the same, eclipseo.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475961] Review Request: cmrt - C for Media Runtime

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475961



--- Comment #2 from Zbigniew Jędrzejewski-Szmek  ---
Please consider adding your irc nick in FAS.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475961] Review Request: cmrt - C for Media Runtime

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475961

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475961] Review Request: cmrt - C for Media Runtime

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475961

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 CC||zbys...@in.waw.pl



--- Comment #1 from Zbigniew Jędrzejewski-Szmek  ---
A small cleanup:
https://github.com/01org/cmrt/archive/%{version}.tar.gz#/%{name}-%{version}.tar.gz
→
https://github.com/01org/cmrt/archive/%{version}/%{name}-%{version}.tar.gz

%description should end in a dot (those are full sentences). It would be great
if you could add a sentence or two what this package does (something like "It
allows ... to ... with ...".)

Please don't put multiple Requires/BuildRequires/etc on the same line,
especially when there are versions. It's more legible and looks much better in
diffs when it's one-per-line.

Hmm, "%autosetup -p1 n %{name}-%{version}" that "n" looks strange. And
%{name}-%{version} is the default, so '%autosetup -p1' should suffice.

> find %{buildroot} -regex ".*\.la$" | xargs rm -f --
Just do find '%{buildroot} -name "*.la" -delete'

The -devel package requires you main package, so you don't need to put %license
in %files devel again.

--

I liked the reviews you did on other packages. I'll sponsor you once this
package is approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475961] Review Request: cmrt - C for Media Runtime

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475961

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Blocks|177841 (FE-NEEDSPONSOR) |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475961] Review Request: cmrt - C for Media Runtime

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475961

Robert-André Mauchin  changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org