[Bug 1476589] Review Request: deepin-api - Go-lang bingding for dde-daemon

2018-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1476589
Bug 1476589 depends on bug 1480960, which changed state.

Bug 1480960 Summary: Review Request: golang-github-BurntSushi-xgb - XGB is the 
X protocol Go language Binding
https://bugzilla.redhat.com/show_bug.cgi?id=1480960

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/VK6FALLQI4KV2KOPUGSR4YD3MYGUJQOU/


[Bug 1476589] Review Request: deepin-api - Go-lang bingding for dde-daemon

2018-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1476589
Bug 1476589 depends on bug 1480973, which changed state.

Bug 1480973 Summary: Review Request: golang-github-alecthomas-kingpin - A Go 
command line and flag parser
https://bugzilla.redhat.com/show_bug.cgi?id=1480973

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/6WTFPF2XVPTK2CLSLVS5HD7OMVV5A4IQ/


[Bug 1476589] Review Request: deepin-api - Go-lang bingding for dde-daemon

2018-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1476589
Bug 1476589 depends on bug 1480962, which changed state.

Bug 1480962 Summary: Review Request: golang-github-disintegration-imaging - 
Simple Go image processing package
https://bugzilla.redhat.com/show_bug.cgi?id=1480962

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/NSX2TPMFMNO3DIQDS2L3DSJL7PIBA7YQ/


[Bug 1476589] Review Request: deepin-api - Go-lang bingding for dde-daemon

2018-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1476589

Zamir SUN  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-07-22 09:30:00



--- Comment #16 from Zamir SUN  ---
This is already in Rawhide. Closing on behalf of the Deepin Desktop packaging
effort.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/AYPETGC64TR6W6WEHXJGF67XEHIB32YZ/


[Bug 1476589] Review Request: deepin-api - Go-lang bingding for dde-daemon

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1476589

Zamir SUN  changed:

   What|Removed |Added

 CC||szts...@gmail.com
  Alias||deepin-api



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1476589] Review Request: deepin-api - Go-lang bingding for dde-daemon

2017-08-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1476589



--- Comment #15 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/deepin-api

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1476589] Review Request: deepin-api - Go-lang bingding for dde-daemon

2017-08-27 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1476589



--- Comment #14 from sensor@gmail.com ---
Don't worry, i added the follows content to build requires.

> golang(pkg.deepin.io/dde/api/dxinput)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1476589] Review Request: deepin-api - Go-lang bingding for dde-daemon

2017-08-27 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1476589



--- Comment #13 from Robert-André Mauchin  ---
@mosquito: There an issue, could you add:


Provides:   golang(%{import_path}) = %{version}-%{release}

to this package, otherwise package depending on golang(pkg.deepin.io/dde/api)
can't find it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1476589] Review Request: deepin-api - Go-lang bingding for dde-daemon

2017-08-26 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1476589

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #12 from Robert-André Mauchin  ---
It looks good, package accepted.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1476589] Review Request: deepin-api - Go-lang bingding for dde-daemon

2017-08-26 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1476589



--- Comment #11 from sensor@gmail.com ---
https://github.com/FZUG/repo/commit/ca9f53b2d49bb9c5dca6a17c652ec2b84805d8b9

Fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1476589] Review Request: deepin-api - Go-lang bingding for dde-daemon

2017-08-25 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1476589

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review?



--- Comment #10 from Robert-André Mauchin  ---
 - I think you need to change:

BuildRequires:  deepin-go-dbus-factory

   to:

BuildRequires:  golang-deepin-dbus-factory-devel


 - The license should be :

License:GPLv3+

 - Replace make with %make_build

 - You forgot the systemd BR:

%{?systemd_requires}
BuildRequires:  systemd

 - I don't understand why you are using:

BuildArch:  noarch
ExclusiveArch:  %{go_arches} noarch

for %package -n golang-%{name}-devel. It shouldn't be a noarch package.

  Shouldn't you be using the typical Golang ExclusivArch:

ExclusiveArch:  %{?go_arches:%{go_arches}}%{!?go_arches:%{ix86} x86_64 %{arm}}



Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "GPL (v3 or later)", "Unknown or generated". 76 files have
 unknown license. Detailed output of licensecheck in
 /home/bob/packaging/review/deepin-api/review-deepin-
 api/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/share/gocode/src/pkg.deepin.io,
 /usr/share/gocode/src/pkg.deepin.io/dde
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/gocode/src,
 /usr/share/gocode/src/pkg.deepin.io/dde, /usr/share/gocode,
 /usr/share/gocode/src/pkg.deepin.io
[x]: Package does not own files or directories owned by other packages.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
 contains icons.
 Note: icons in deepin-api
[x]: Useful -debuginfo package or justification otherwise.
[-]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: 

[Bug 1476589] Review Request: deepin-api - Go-lang bingding for dde-daemon

2017-08-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1476589



--- Comment #9 from sensor@gmail.com ---
SPEC: 
https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-26-x86_64/00593068-deepin-api/deepin-api.spec
SRPM: 
https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-26-x86_64/00593068-deepin-api/deepin-api-3.1.11-2.fc26.src.rpm

I review and added some golang packages with gofed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1476589] Review Request: deepin-api - Go-lang bingding for dde-daemon

2017-08-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1476589

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com



--- Comment #8 from Robert-André Mauchin  ---
Could you please redo this package with gofed as a starting point?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1476589] Review Request: deepin-api - Go-lang bingding for dde-daemon

2017-08-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1476589

Robert-André Mauchin  changed:

   What|Removed |Added

 Blocks||1476590




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1476590
[Bug 1476590] Review Request: deepin-daemon - Daemon handling the DDE
session settings
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1476589] Review Request: deepin-api - Go-lang bingding for dde-daemon

2017-08-13 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1476589

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 CC||zbys...@in.waw.pl
 Depends On||1480960, 1480962, 1480973




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1480960
[Bug 1480960] Review Request: golang-github-BurntSushi-xgb - XGB is the X
protocol Go language Binding
https://bugzilla.redhat.com/show_bug.cgi?id=1480962
[Bug 1480962] Review Request: golang-github-disintegration-imaging - Simple
Go image processing package
https://bugzilla.redhat.com/show_bug.cgi?id=1480973
[Bug 1480973] Review Request: golang-github-alecthomas-kingpin - A Go
command line and flag parser
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1476589] Review Request: deepin-api - Go-lang bingding for dde-daemon

2017-08-13 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1476589

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Blocks||1476583




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1476583
[Bug 1476583] Review Request: startdde - Starter of deepin desktop
environment
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1476589] Review Request: deepin-api - Go-lang bingding for dde-daemon

2017-08-10 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1476589



--- Comment #7 from sensor@gmail.com ---
SPEC: 
https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-25-x86_64/00588927-deepin-api/deepin-api.spec
SRPM: 
https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-25-x86_64/00588927-deepin-api/deepin-api-3.1.11-2.fc25.src.rpm

Fixed, but some packages does not submit for review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1476589] Review Request: deepin-api - Go-lang bingding for dde-daemon

2017-08-09 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1476589



--- Comment #6 from Ye Cheng <18969068...@163.com> ---
Please submit the review requests of the following packages(and add them on
   depends on field), so the package won't have broken dependencies when
merged.
  golang-github-disintegration-imaging-devel
  golang-github-alecthomas-kingpin-devel
  golang-github-BurntSushi-xgbutil-devel
  golang-github-BurntSushi-xgb-devel
  golang-deepin-go-lib-devel
  deepin-go-dbus-factory

Please use BuildRequires: pkgconfig(gtk+-3.0) instead of BuildRequires: 
gtk3-devel for all the libraries located using pkg-config, because the
dependency won't break when the name of the package providing the library was
changed when coded this way.
> Makefile:12
> LDFLAGS = $(shell pkg-config --libs gio-2.0 gtk+-3.0 gdk-pixbuf-xlib-2.0 x11 
> xi >xfixes xcursor libcanberra cairo-ft poppler-glib librsvg-2.0)
>BuildRequires:  gtk3-devel 
...
Please refer to https://fedoraproject.org/wiki/Packaging:PkgConfigBuildRequires
for detail.

Please avoid hard-coded path if possile
>%make_install SYSTEMD_LIB_DIR="/usr/lib" LIBDIR="/libexec"
A better way is to use SYSTEMD_SERVICE_DIR ="%{_unitdir}" instead of
SYSTEMD_LIB_DIR="/usr/lib" as it is supported in Makefile. 
I don't know whether it is acceptable to code LIBDIR="/libexec" as
LIBDIR="%{_libexecdir}"

The pakage dose not honor the applicable compiler flags 
>Makefile:13
>GOBUILD = go build -compiler gccgo -gccgoflags "${LDFLAGS}"
export GOBUILD=$(%gobuild | sed 's|${LDFLAGS:-}|${LDFLAGS}|') could be a quick
fix if it can be built with gc, compile using gccgo may require some tweaks on
flags.
%gobuild evaluates to rpm --eval %gobuild :
%ifnarch ppc64 
go build -buildmode pie -compiler gc -tags=rpm_crashtraceback -ldflags
"${LDFLAGS:-} -B 0x$(head -c20 /dev/urandom|od -An -tx1|tr -d ' \n')
-extldflags '-Wl,-z,relro -specs=/usr/lib/rpm/redhat/redhat-hardened-ld'" -a -v
-x ;
%else 
go build -compiler gc -tags=rpm_crashtraceback -ldflags "${LDFLAGS:-} -B
0x$(head -c20 /dev/urandom|od -An -tx1|tr -d ' \n') -extldflags '-Wl,-z,relro
-specs=/usr/lib/rpm/redhat/redhat-hardened-ld'" -a -v -x ;
%endif


This package should conform Go packaging
guideline:https://fedoraproject.org/wiki/PackagingDrafts/Go.Thus,
ExclusiveArch:  %{go_arches} should be added; a better way to write build
requires: gcc-go and golang-deepin-go-lib-devel  is  compiler(gcc-go) and
golang(github.com/linuxdeepin/go-lib), etc ...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1476589] Review Request: deepin-api - Go-lang bingding for dde-daemon

2017-08-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1476589



--- Comment #5 from sensor@gmail.com ---
SPEC: 
https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-25-x86_64/00587960-deepin-api/deepin-api.spec
SRPM: 
https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-25-x86_64/00587960-deepin-api/deepin-api-3.1.11-2.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1476589] Review Request: deepin-api - Go-lang bingding for dde-daemon

2017-08-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1476589



--- Comment #4 from sensor@gmail.com ---
Diff: 
https://github.com/FZUG/repo/commit/beffb7e08c0dd0cb99167dd24a544a33932cb070

> This will fail the mock build because network access is not available at 
> build time and these downloaded library become undesirably bundled into the 
> application.
Reference:http://fedoraproject.org/wiki/Packaging:Guidelines#Build_time_network_access
Fixed

> It seems that github.com/howeyc/fsnotify is no longer actively maintained. 
> Please switch to golang-github-go-fsnotify-fsnotify package if possible.
The golang-github-go-fsnotify-fsnotify is not work with deepin-api.

> If it is necessary for these icon to display properly immediately after 
> installation, please write a %post script let to refresh icon cache. Please 
> reference 
> https://fedoraproject.org/wiki/Packaging:Scriptlets?rd=Packaging:ScriptletSnippets#Icon_Cache
>  for detail
Fixed

> Perhaps some  %post,%preun and %postun script lets are necessary for handling 
> systemd units. Please reference
http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd
Fixed

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1476589] Review Request: deepin-api - Go-lang bingding for dde-daemon

2017-08-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1476589

Ye Cheng <18969068...@163.com> changed:

   What|Removed |Added

 CC||18969068...@163.com



--- Comment #3 from Ye Cheng <18969068...@163.com> ---
(In reply to sensor.wen from comment #2)
> SPEC: 
> https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-26-
> x86_64/00586135-deepin-api/deepin-api.spec

>go get github.com/disintegration/imaging \
>github.com/howeyc/fsnotify \
>gopkg.in/check.v1 \
>gopkg.in/alecthomas/kingpin.v2
This will fail the mock build because network access is not available at build
time and these downloaded library become undesirably bundled into the
application.
Reference:http://fedoraproject.org/wiki/Packaging:Guidelines#Build_time_network_access

It seems that github.com/howeyc/fsnotify is no longer actively maintained.
Please switch to golang-github-go-fsnotify-fsnotify package if possible.

>%{_datadir}/icons/hicolor/*/actions/*
If it is necessary for these icon to display properly immediately after
installation, please write a %post script let to refresh icon cache. Please
reference
https://fedoraproject.org/wiki/Packaging:Scriptlets?rd=Packaging:ScriptletSnippets#Icon_Cache
for detail

>%{_unitdir}/*.service
Perhaps some  %post,%preun and %postun script lets are necessary for handling
systemd units. Please reference
http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1476589] Review Request: deepin-api - Go-lang bingding for dde-daemon

2017-08-03 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1476589



--- Comment #2 from sensor@gmail.com ---
SPEC: 
https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-26-x86_64/00586135-deepin-api/deepin-api.spec
SRPM: 
https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-26-x86_64/00586135-deepin-api/deepin-api-3.1.11-1.fc26.src.rpm

Rebuild.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1476589] Review Request: deepin-api - Go-lang bingding for dde-daemon

2017-08-03 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1476589



--- Comment #1 from sensor@gmail.com ---
SPEC:
https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-25-x86_64/00585731-deepin-api/deepin-api.spec
SRPM:
https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-25-x86_64/00585731-deepin-api/deepin-api-3.1.11-1.fc25.src.rpm

Release 3.1.11

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1476589] Review Request: deepin-api - Go-lang bingding for dde-daemon

2017-08-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1476589

Zamir SUN  changed:

   What|Removed |Added

 Blocks||1465889
   ||(DeepinDEPackageReview)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1465889
[Bug 1465889] Tracking: Deepin Desktop related package review tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org