[Bug 1483298] Review Request: deepin-launcher - Deepin desktop-environment Launcher module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483298
Bug 1483298 depends on bug 1419330, which changed state.

Bug 1419330 Summary: Review Request: deepin-menu - deepin menu service
https://bugzilla.redhat.com/show_bug.cgi?id=1419330

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/CDVHTIOFQJWKPSFJUYMPZXUKMS2OQREB/

[Bug 1483298] Review Request: deepin-launcher - Deepin desktop-environment Launcher module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483298
Bug 1483298 depends on bug 1476596, which changed state.

Bug 1476596 Summary: Review Request: dtkwidget - Deepin tool kit widget modules
https://bugzilla.redhat.com/show_bug.cgi?id=1476596

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/FTCQKHWZALN3YYITM3TLCRSQJSH4LFLE/

[Bug 1483298] Review Request: deepin-launcher - Deepin desktop-environment Launcher module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483298

Zamir SUN  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-07-22 09:30:26



--- Comment #10 from Zamir SUN  ---
This is already in Rawhide. Closing on behalf of the Deepin Desktop packaging
effort.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/LPTN3TBD5FTMJCVRQSFUBMJFTLTVWJ5J/

[Bug 1483298] Review Request: deepin-launcher - Deepin desktop-environment Launcher module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483298
Bug 1483298 depends on bug 1476590, which changed state.

Bug 1476590 Summary: Review Request: deepin-daemon - Daemon handling the DDE 
session settings
https://bugzilla.redhat.com/show_bug.cgi?id=1476590

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/3EH5EKTBGHOYTUR3YLS7BZI4XHC6EIA6/

[Bug 1483298] Review Request: deepin-launcher - Deepin desktop-environment Launcher module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483298

Zamir SUN  changed:

   What|Removed |Added

 CC||szts...@gmail.com
  Alias||deepin-launcher



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483298] Review Request: deepin-launcher - Deepin desktop-environment Launcher module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483298



--- Comment #9 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/deepin-launcher

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483298] Review Request: deepin-launcher - Deepin desktop-environment Launcher module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483298

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #8 from Robert-André Mauchin  ---
Package accepted.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "GPL (v3 or later)", "Unknown or generated". 362 files have
 unknown license. Detailed output of licensecheck in
 /home/bob/packaging/review/deepin-launcher/review-deepin-
 launcher/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/dbus-1,
 /usr/share/dbus-1/services
[x]: Package does not own files or directories owned by other packages.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
 contains icons.
 Note: icons in deepin-launcher
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in deepin-
 launcher-debuginfo , deepin-launcher-debugsource
[?]: Package functions as described.
[x]: Latest version is 

[Bug 1483298] Review Request: deepin-launcher - Deepin desktop-environment Launcher module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483298



--- Comment #7 from sensor@gmail.com ---
SPEC: 
https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-26-x86_64/00594499-deepin-launcher/deepin-launcher.spec
SRPM: 
https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-26-x86_64/00594499-deepin-launcher/deepin-launcher-4.1.8-1.fc26.src.rpm

Release 4.1.8

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483298] Review Request: deepin-launcher - Deepin desktop-environment Launcher module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483298

Robert-André Mauchin  changed:

   What|Removed |Added

 Depends On||1419330




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1419330
[Bug 1419330] Review Request: deepin-menu - deepin menu service
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483298] Review Request: deepin-launcher - Deepin desktop-environment Launcher module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483298

Robert-André Mauchin  changed:

   What|Removed |Added

 Depends On||1476590



--- Comment #6 from Robert-André Mauchin  ---
I'll continue the Review once deepin-daemon is handled: bug #1476590.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1476590
[Bug 1476590] Review Request: deepin-daemon - Daemon handling the DDE
session settings
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483298] Review Request: deepin-launcher - Deepin desktop-environment Launcher module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483298



--- Comment #5 from sensor@gmail.com ---
Diff: 
https://github.com/FZUG/repo/commit/5f5c3c4660a88b31698f4052a36a500a83d2526b

Small changes, no rebuild.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483298] Review Request: deepin-launcher - Deepin desktop-environment Launcher module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483298



--- Comment #4 from sensor@gmail.com ---
- dtkwidget:  removed the require entry for Qt.
https://copr.fedorainfracloud.org/coprs/mosquito/deepin/build/593706/

- use '>=' instead '=' for dtkwidget
I do not know if it is compatible with the new version, I only know it is not
compatible with 1.0. So I used the "=" in Req entry.

- add pkgconfig(dtkcore) BReq

Fixd, Thanks a lot.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483298] Review Request: deepin-launcher - Deepin desktop-environment Launcher module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483298

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 Depends On||1476596
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review?



--- Comment #3 from Robert-André Mauchin  ---
Why do you make a strict requirement to pkgconfig(dtkwidget) = 2.0 ? Shouldn't
you used instead: pkgconfig(dtkwidget) >= 2.0 ?

You still haven't put the BR for dtkcore.

I can't build this because your copr package for dtkwidget require qtbase 5.7.1
and Fedora Rawhide provides qtbase 5.9. I don't think your package dtkwidget
should depend on a specific version of Qt either. Please fix it.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1476596
[Bug 1476596] Review Request: dtkwidget - Deepin tool kit widget modules
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483298] Review Request: deepin-launcher - Deepin desktop-environment Launcher module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483298



--- Comment #2 from sensor@gmail.com ---
SPEC: 
https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-26-i386/00593013-deepin-launcher/deepin-launcher.spec
SRPM: 
https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-26-i386/00593013-deepin-launcher/deepin-launcher-4.1.7-1.fc26.src.rpm

>  - I wasn't able to build the project because it seems a BR is missing:
> Project ERROR: dtkcore development package not found
> Have you packaged this yet? https://github.com/linuxdeepin/dtkcore

http://dl.fedoraproject.org/pub/fedora/linux/development/rawhide/Everything/x86_64/os/Packages/d/dtkcore-devel-2.0.0-1.fc28.x86_64.rpm

the dtkcore is approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483298] Review Request: deepin-launcher - Deepin desktop-environment Launcher module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483298

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com



--- Comment #1 from Robert-André Mauchin  ---
Hello,

Some similar issues as before:

 - You must post both SPEC URL and SRPM URL. It's used by fedora review to
fetch the files from a bug number.
 - The latest version is 4.1.7, not 4.1.6
 - Just use: %global repo dde-launcher
 - Use pkgconfig where you can:

BuildRequires:  pkgconfig(dtkbase)
BuildRequires:  pkgconfig(dframeworkdbus)
BuildRequires:  pkgconfig(gsettings-qt)
BuildRequires:  pkgconfig(gtk+-2.0)
BuildRequires:  qt5-linguist
BuildRequires:  pkgconfig(Qt5)
BuildRequires:  pkgconfig(Qt5Svg)
BuildRequires:  pkgconfig(Qt5X11Extras)
BuildRequires:  pkgconfig(xcb-ewmh)

 - If you install icons your must run the scriptlets described in this section:
https://fedoraproject.org/wiki/Packaging:Scriptlets#Icon_Cache
 You also need to add a: Requires:   hicolor-icon-theme

 - I wasn't able to build the project because it seems a BR is missing:

Project ERROR: dtkcore development package not found

Have you packaged this yet? https://github.com/linuxdeepin/dtkcore

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483298] Review Request: deepin-launcher - Deepin desktop-environment Launcher module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483298

sensor@gmail.com changed:

   What|Removed |Added

 Blocks||1465889
   ||(DeepinDEPackageReview)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1465889
[Bug 1465889] Tracking: Deepin Desktop related package review tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org