[Bug 1501500] Review Request: containerd - An industry-standard container runtime

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1501500

Carl George  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2017-10-23 09:43:06



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1501500] Review Request: containerd - An industry-standard container runtime

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1501500



--- Comment #8 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/containerd

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1501500] Review Request: containerd - An industry-standard container runtime

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1501500

Lokesh Mandvekar  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #7 from Lokesh Mandvekar  ---
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Requires correct, justified where necessary.

package spec conforms to current golang packaging draft. Mandatory review items
taken care of as mentioned above.

package approved.

Enjoy!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1501500] Review Request: containerd - An industry-standard container runtime

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1501500



--- Comment #6 from Carl George  ---
Spec URL: https://carlwgeorge.fedorapeople.org/containerd.spec
SRPM URL:
https://carlwgeorge.fedorapeople.org/containerd-1.0.0-0.4.beta.2.fc28.src.rpm

* Thu Oct 19 2017 Carl George  - 1.0.0-0.4.beta.2 
- Own /etc/containerd

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1501500] Review Request: containerd - An industry-standard container runtime

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1501500



--- Comment #5 from Lokesh Mandvekar  ---
whoops my bad RE: runc and systemd.

RE: epel, you'll have a much less frustrating time doing this on Virt SIG than
EPEL as I mentioned on the github issue, but anyway, that's not really a
blocker to package review.

So, let me know once the /etc/containerd ownership is updated.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1501500] Review Request: containerd - An industry-standard container runtime

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1501500



--- Comment #4 from Carl George  ---
I'll add /etc/containerd added to %files, thanks for catching that.

systemd and runc are both already requirements in the spec file.

Regarding the minimum golang version to build, I'm hoping for more feedback
from upstream first.  I like to keep it at 1.8 if possible so that this can be
added to EPEL.

https://github.com/containerd/containerd/issues/1508#issuecomment-336200953

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1501500] Review Request: containerd - An industry-standard container runtime

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1501500



--- Comment #3 from Lokesh Mandvekar  ---
Also, looking at the spec, might wanna change golang to be >= 1.9, doesn't
matter if that means it won't build for f26.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1501500] Review Request: containerd - An industry-standard container runtime

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1501500



--- Comment #2 from Lokesh Mandvekar  ---
= MUST items =

C/C++:
[-]: Package does not contain kernel modules.
[-]: Package contains no static executables.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Apache (v2.0)", "CC by-sa (v4.0)", "*No copyright* BSD (2
 clause)", "Unknown or generated", "MIT/X11 (BSD like)", "ISC", "BSD (3
 clause)", "BSD (2 clause)", "do What The Fuck you want to Public
 License (v2)", "*No copyright* Apache (v2.0)". 1241 files have unknown
 license. Detailed output of licensecheck in
 /home/lsm5/reviews/1501500-containerd/licensecheck.txt


[!]: Package requires other packages for directories it uses.
 Note: No known owner of /etc/containerd
[!]: Package must own all directories that it creates.
 Note: Directories without known owners: /etc/containerd

Owning /etc/containerd should make these two go away.

[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[!]: Requires correct, justified where necessary.

See the Requires section below.

[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines



Requires

containerd (rpmlib, GLIBC filtered):
/bin/sh
config(containerd)
libc.so.6()(64bit)
libdl.so.2()(64bit)
libpthread.so.0()(64bit)
rtld(GNU_HASH)
runc
systemd

You'll need to include systemd as a Requires since you're shipping a unitfile.
Also, probably need to include runc in there as well. Rest of them should be
automatically handled IIUC.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1501500] Review Request: containerd - An industry-standard container runtime

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1501500



--- Comment #1 from Lokesh Mandvekar  ---
This is a review *template*. Besides handling the [ ]-marked tests you are
also supposed to fix the template before pasting into bugzilla:
- Add issues you find to the list of issues on top. If there isn't such
  a list, create one.
- Add your own remarks to the template checks.
- Add new lines marked [!] or [?] when you discover new things not
  listed by fedora-review.
- Change or remove any text in the template which is plain wrong. In this
  case you could also file a bug against fedora-review
- Remove the "[ ] Manual check required", you will not have any such lines
  in what you paste.
- Remove attachments which you deem not really useful (the rpmlint
  ones are mandatory, though)
- Remove this text



Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

C/C++:
[ ]: Package does not contain kernel modules.
[ ]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[ ]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[ ]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Apache (v2.0)", "CC by-sa (v4.0)", "*No copyright* BSD (2
 clause)", "Unknown or generated", "MIT/X11 (BSD like)", "ISC", "BSD (3
 clause)", "BSD (2 clause)", "do What The Fuck you want to Public
 License (v2)", "*No copyright* Apache (v2.0)". 1241 files have unknown
 license. Detailed output of licensecheck in
 /home/lsm5/reviews/1501500-containerd/licensecheck.txt
[ ]: Package requires other packages for directories it uses.
 Note: No known owner of /etc/containerd
[ ]: Package must own all directories that it creates.
 Note: Directories without known owners: /etc/containerd
[ ]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by: /usr/lib/.build-id(iputils,
 gc, libtomcrypt, gdbm, gpgme, rpm-plugin-selinux, libnfsidmap, gdb-
 headless, trousers, bzip2-libs, unzip, libdb-utils, libcom_err,
 pycryptopp, libseccomp, gnutls, npth, p11-kit, libyaml, iptables-libs,
 rpm-build, device-mapper-persistent-data, cryptsetup-libs,
 python2-krbv, libselinux-utils, perl-Scalar-List-Utils, parted, zstd,
 mozjs17, libxslt, libpkgconf, libunistring, keyutils-libs, perl-
 Encode, elfutils, python2-cryptography, libgpg-error, lvm2-libs, perl-
 Digest-SHA, perl-Data-Dumper, gawk, python2-rpm, libbasicobjects,
 c-ares, python2-sqlalchemy, jansson, e2fsprogs-libs, apr,
 libsss_nss_idmap, deltarpm, file-libs, trousers-lib, libyubikey,
 python3-pycurl, zip, libnetfilter_conntrack, libtommath, libusbx,
 compat-openssl10, qrencode-libs, drpm, createrepo_c-libs, libtasn1,
 openssh, python3-dbus, sqlite, http-parser, tar, sudo, dhcp-client,
 libgomp, gcc, systemd-bootchart, dwz, python2-psutil, ebtables,
 libsmartcols, NetworkManager, pyliblzma, ncurses-libs, polkit, pigz,
 libpsl, python3-rpm, libini_config, openssh-clients, libuser, perl-
 libs, kbd, python3-cryptography, systemd, libacl, libnl3, libcap-ng,
 policycoreutils, libidn, grubby, lzo, libss, libbabeltrace, nspr,
 dbus, polkit-libs, perl-threads, perl-Params-Validate, libsss_certmap,
 python2-libcomps, rpm-plugin-systemd-inhibit, python2-pyyaml, audit-
 libs, nss-sysinit, python2-saslwrapper, libgcc, gettext-libs, p11-kit-
 trust, golang-github-cpuguy83-go-md2man, ykpers, python3-cffi, dbus-
 libs, libcrypt-nss, usermode, bash, glibc-common, linux-atm-libs,
 libedit, libidn2, python3-librepo, libuuid, subversion-libs, openssl,
 libarchive, isl, lvm2, libatomic_ops, xz, vim-minimal, NetworkManager-
 libnm, python2-libs, zeromq, groff-base, authconfig, libusb, dhcp-
 libs, python2-cccolutils, libtalloc, libldb, grep, guile, pcre-utf16,
 gnupg, cronie-anacron, libserf, xfsprogs, man-db, libcroco,
 python2-zmq, xz-libs, dbus-glib, timedatex, perl-Package-Stash-XS,
 skopeo, which, libcap, sssd-nfs-idmap, libdb, saslwrapper, passwd,
 kmod-libs, desktop-file-utils, cronie, rpm-libs, nettle, createrepo_c,
 fakeroot, python2-markupsafe, nss-tools, libpipeline, iproute,
 python2-gpg, findutils, popt, fakeroot-libs, libsss_idmap, gobject-
 introspection, libpwquality, krb5-workstation, python3-hawkey,
 iptables, iproute-tc, systemd-libs, cpio, lz4-libs, util-linux, patch,
 krb5-libs, sqlite-libs, enchant, pkgconf, pcre-cpp,
 python3-libselinux, rhash, sed, libipt, libsss_autofs, perl-threads-
 shared, libaio, kmod, nss-util, 

[Bug 1501500] Review Request: containerd - An industry-standard container runtime

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1501500

Lokesh Mandvekar  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||l...@redhat.com
   Assignee|nob...@fedoraproject.org|l...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org