[Bug 1505306] Review Request: i-nex - System information tool like hardinfo, sysinfo

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505306

mgans...@alice.de  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |NEXTRELEASE
Last Closed||2017-10-24 10:07:28



--- Comment #10 from mgans...@alice.de  ---
package has been built successfully on f25, f26, f27 and rawhide.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1505306] Review Request: i-nex - System information tool like hardinfo, sysinfo

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505306



--- Comment #9 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/i-nex

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1505306] Review Request: i-nex - System information tool like hardinfo, sysinfo

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505306



--- Comment #8 from mgans...@alice.de  ---
build fails on arch: s390x ppc64le ppc64 aarch64 armv7hl aarch64
will add ExcludeArch to spec file

ExcludeArch:aarch64 %arm ppc64le ppc64 s390x

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1505306] Review Request: i-nex - System information tool like hardinfo, sysinfo

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505306
Bug 1505306 depends on bug 1505304, which changed state.

Bug 1505304 Summary: Review Request: libcpuid - Provides CPU identification for 
x86
https://bugzilla.redhat.com/show_bug.cgi?id=1505304

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |NEXTRELEASE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1505306] Review Request: i-nex - System information tool like hardinfo, sysinfo

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505306



--- Comment #7 from mgans...@alice.de  ---
thanks for the professional ticket review !

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1505306] Review Request: i-nex - System information tool like hardinfo, sysinfo

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505306



--- Comment #6 from mgans...@alice.de  ---
(In reply to Robert-André Mauchin from comment #5)
> There's a typo in the Release field, it should be:
> 
> Release:3%{gver}%{?dist}
> 
> The ? is before dist, not gver.
> 
> Otherwise the package is good and is accepted.

typo fixed, no extra upload.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1505306] Review Request: i-nex - System information tool like hardinfo, sysinfo

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505306

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #5 from Robert-André Mauchin  ---
There's a typo in the Release field, it should be:

Release:3%{gver}%{?dist}

The ? is before dist, not gver.

Otherwise the package is good and is accepted.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1505306] Review Request: i-nex - System information tool like hardinfo, sysinfo

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505306



--- Comment #4 from mgans...@alice.de  ---
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/i-nex.spec
SRPM URL:
https://martinkg.fedorapeople.org/Review/SRPMS/i-nex-7.6.0-3.20170703git0c10102.fc26.src.rpm

%changelog
* Mon Oct 23 2017 Martin Gansser  -
7.6.0-3.20170703git0c10102
- Delete BR hicolor-icon-theme not needed
- Use udev macro %%{_udevrulesdir}
- Add BR libappstream-glib
- Add %%{name}-Makefile.patch to fix install pixmap

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1505306] Review Request: i-nex - System information tool like hardinfo, sysinfo

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505306



--- Comment #3 from Robert-André Mauchin  ---
 - The R and BR for hicolor-icon-theme are still there…

 - You didn't use %{_udevrulesdir} everywhere:

chmod 0644 %{buildroot}/%{_prefix}/lib/udev/rules.d/i2c_smbus.rules
mv %{buildroot}/%{_prefix}/lib/udev/rules.d/i2c_smbus.rules
%{buildroot}/%{_prefix}/lib/udev/rules.d/50-i2c_smbus.rules

 - You need to add the following BR:

BuildRequires: libappstream-glib

   otherwise appstream-util won't work

 - It seems there is an error in the build script:

>Install pixmaps...
>/usr/bin/make -C pixmaps install
>make[1]: Entering directory 
>'/builddir/build/BUILD/I-Nex-0c10102578e7c762674eaf9460b0903d76f151db/pixmaps'
>mkdir -p 
>/builddir/build/BUILDROOT/i-nex-7.6.0-2.20170703git0c10102.fc28.x86_64/usr/share/pixmaps
>/usr/bin/install -p 644 i-nex.png 
>/builddir/build/BUILDROOT/i-nex-7.6.0-2.20170703git0c10102.fc28.x86_64/usr/share/pixmaps/
>/usr/bin/install: cannot stat '644': No such file or directory
>make[1]: *** [Makefile:5: install] Error 1

   The correct syntax for install is:

install -p -m 644 i-nex.png
/builddir/build/BUILDROOT/i-nex-7.6.0-2.20170703git0c10102.fc28.x86_64/usr/share/pixmaps/

   The -m is missing so the command fails.

   You should probably patch it and notify upstream. Here's a patch for it:


diff -up I-Nex-0c10102578e7c762674eaf9460b0903d76f151db/JSON/Makefile.fix_build
I-Nex-0c10102578e7c762674eaf9460b0903d76f151db/JSON/Makefile
--- I-Nex-0c10102578e7c762674eaf9460b0903d76f151db/JSON/Makefile.fix_build   
2017-05-24 21:16:01.0 +0200
+++ I-Nex-0c10102578e7c762674eaf9460b0903d76f151db/JSON/Makefile2017-10-23
17:10:34.223531318 +0200
@@ -18,7 +18,7 @@ install-bin: install-bin-i-nex-edid

 install-bin-i-nex-edid:
 test -d $(DESTDIR)$(bindir) || mkdir $(DESTDIR)$(bindir)
-$(INSTALL) 0755 i-nex-edid $(DESTDIR)$(bindir)
+$(INSTALL_DM) 0755 i-nex-edid $(DESTDIR)$(bindir)
 clean:
 @echo -e '$(ACTION_COLOR)Clean JSON$(NO_COLOR)'
 $(RM_COM) $(RMFILE_OPT) i-nex-edid
diff -up I-Nex-0c10102578e7c762674eaf9460b0903d76f151db/Makefile.fix_build
I-Nex-0c10102578e7c762674eaf9460b0903d76f151db/Makefile
--- I-Nex-0c10102578e7c762674eaf9460b0903d76f151db/Makefile.fix_build   
2017-05-24 21:16:01.0 +0200
+++ I-Nex-0c10102578e7c762674eaf9460b0903d76f151db/Makefile2017-10-23
17:08:12.910892293 +0200
@@ -20,8 +20,8 @@ build-json:
 install-desktop-files:
 @echo -e '\033[1;32mCreate nedded dirs...\033[0m'
 mkdir -p $(DESTDIR)$(PREFIX)/share/applications
-$(INSTALL) 0755 debian/i-nex.desktop
$(DESTDIR)$(PREFIX)/share/applications/
-$(INSTALL) 0755 debian/i-nex-library.desktop
$(DESTDIR)$(PREFIX)/share/applications/
+$(INSTALL_DM) 0755 debian/i-nex.desktop
$(DESTDIR)$(PREFIX)/share/applications/
+$(INSTALL_DM) 0755 debian/i-nex-library.desktop
$(DESTDIR)$(PREFIX)/share/applications/

 install-pixmaps:

diff -up
I-Nex-0c10102578e7c762674eaf9460b0903d76f151db/pixmaps/Makefile.fix_build
I-Nex-0c10102578e7c762674eaf9460b0903d76f151db/pixmaps/Makefile
--- I-Nex-0c10102578e7c762674eaf9460b0903d76f151db/pixmaps/Makefile.fix_build  
 2017-05-24 21:16:01.0 +0200
+++ I-Nex-0c10102578e7c762674eaf9460b0903d76f151db/pixmaps/Makefile   
2017-10-23 17:07:26.049011999 +0200
@@ -2,10 +2,10 @@
 include ../i-nex.mk
 install:
 mkdir -p ${DESTDIR}$(PREFIX)/share/pixmaps
-${INSTALL} 644 i-nex.png $(DESTDIR)$(PREFIX)/share/pixmaps/
-${INSTALL} 644 i-nex-16.png $(DESTDIR)$(PREFIX)/share/pixmaps/
-${INSTALL} 644 i-nex-32.png $(DESTDIR)$(PREFIX)/share/pixmaps/
-${INSTALL} 644 i-nex-128.png $(DESTDIR)$(PREFIX)/share/pixmaps/
+$(INSTALL_DM) 644 i-nex.png $(DESTDIR)$(PREFIX)/share/pixmaps/
+$(INSTALL_DM) 644 i-nex-16.png $(DESTDIR)$(PREFIX)/share/pixmaps/
+$(INSTALL_DM) 644 i-nex-32.png $(DESTDIR)$(PREFIX)/share/pixmaps/
+$(INSTALL_DM) 644 i-nex-128.png $(DESTDIR)$(PREFIX)/share/pixmaps/

 uninstall:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1505306] Review Request: i-nex - System information tool like hardinfo, sysinfo

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505306



--- Comment #2 from mgans...@alice.de  ---
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/i-nex.spec
SRPM URL:
https://martinkg.fedorapeople.org/Review/SRPMS/i-nex-7.6.0-2.20170703git0c10102.fc26.src.rpm

%changelog
* Mon Oct 23 2017 Martin Gansser  -
7.6.0-2.20170703git0c10102
- use udev macro %%{_udevrulesdir}
- delete BR  hicolor-icon-theme not needed
- RR hicolor-icon-theme not needed
- Add an AppData file. See https://fedoraproject.org/wiki/Packaging:AppData
- Add gitdate for snapshot release

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1505306] Review Request: i-nex - System information tool like hardinfo, sysinfo

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505306

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com



--- Comment #1 from Robert-André Mauchin  ---
Hello,


 - %{_prefix}/lib/udev/rules.d/ → %{_udevrulesdir}

 - BuildRequires:  hicolor-icon-theme 
   Requires:   hicolor-icon-theme 

   → Not needed, as you don't install any icons in the hicolor directory.

 - You forgot to validate i-nex.desktop:

desktop-file-validate %{buildroot}/%{_datadir}/applications/%{name}.desktop

 - You should add an AppData file. See
https://fedoraproject.org/wiki/Packaging:AppData

 - The release tag should contain the commit date too for a snapshot release:

%global gver .%{gitdate}git%{shortcommit0}

   And:

* Wed Sep 27 2017 Martin Gansser  -
7.6.0-1.20170703git0c10102

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1505306] Review Request: i-nex - System information tool like hardinfo, sysinfo

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505306

mgans...@alice.de  changed:

   What|Removed |Added

 Depends On||1505304




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1505304
[Bug 1505304] Review Request: libcpuid - Provides CPU identification for
x86
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org