[Bug 1506722] Review Request: python-octaviaclient - Client for OpenStack Octavia ( Load Balancer as a Service)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1506722

Carlos Goncalves  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |NEXTRELEASE
Last Closed||2017-11-27 05:40:07



--- Comment #12 from Carlos Goncalves  ---
python-octaviaclient file sources successfully push to
http://pkgs.fedoraproject.org/cgit/rpms/python-octaviaclient.git/

It was also successfully built for f28 (rawhide):
http://koji.fedoraproject.org/koji/buildinfo?buildID=1004381

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1506722] Review Request: python-octaviaclient - Client for OpenStack Octavia ( Load Balancer as a Service)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1506722

hgue...@redhat.com changed:

   What|Removed |Added

 Blocks|177841 (FE-NEEDSPONSOR) |



--- Comment #11 from hgue...@redhat.com ---
Removing FE-NEEDSPONSOR as I sponsored Carlos in the packager group


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1506722] Review Request: python-octaviaclient - Client for OpenStack Octavia ( Load Balancer as a Service)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1506722

hgue...@redhat.com changed:

   What|Removed |Added

 CC||hgue...@redhat.com
  Flags|needinfo?(puiterwijk@redhat |
   |.com)   |



--- Comment #10 from hgue...@redhat.com ---
I'm sponsoring Carlos, he will be working with RDO project to maintain this
package and he will get our support when he needs to.
FAS: hguemar (yeah, too lazy to switch to my fp.o account on RHBZ :o) )

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1506722] Review Request: python-octaviaclient - Client for OpenStack Octavia ( Load Balancer as a Service)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1506722

Carlos Goncalves  changed:

   What|Removed |Added

 CC||puiterw...@redhat.com
 Blocks||177841 (FE-NEEDSPONSOR)
  Flags||needinfo?(puiterwijk@redhat
   ||.com)



--- Comment #9 from Carlos Goncalves  ---
This is my first package and thus I need sponsoring. Could you please sponsor?


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1506722] Review Request: python-octaviaclient - Client for OpenStack Octavia ( Load Balancer as a Service)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1506722



--- Comment #8 from Patrick Uiterwijk  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-octaviaclient

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1506722] Review Request: python-octaviaclient - Client for OpenStack Octavia ( Load Balancer as a Service)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1506722



--- Comment #7 from Carlos Goncalves  ---
Repo request: https://pagure.io/releng/fedora-scm-requests/issue/3223

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1506722] Review Request: python-octaviaclient - Client for OpenStack Octavia ( Load Balancer as a Service)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1506722

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #6 from Robert-André Mauchin  ---
Everything seems good, package accepted.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1506722] Review Request: python-octaviaclient - Client for OpenStack Octavia ( Load Balancer as a Service)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1506722

Carlos Goncalves  changed:

   What|Removed |Added

 Depends On|1417461, 1507995|



--- Comment #5 from Carlos Goncalves  ---
Updated to version 1.2.0


Spec URL: http://cgoncalves.pt/trash/openstack/python-octaviaclient.spec
SRPM URL:
http://cgoncalves.pt/trash/openstack/python-octaviaclient-1.2.0-1.fc27.src.rpm
Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=23282172


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1417461
[Bug 1417461] python-openstackclient: Provide a Python 3 subpackage
https://bugzilla.redhat.com/show_bug.cgi?id=1507995
[Bug 1507995] Nothing provides python2-PyYAML
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1506722] Review Request: python-octaviaclient - Client for OpenStack Octavia ( Load Balancer as a Service)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1506722



--- Comment #4 from Robert-André Mauchin  ---
Care to point us toward the updated SPEC and SRPM?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1506722] Review Request: python-octaviaclient - Client for OpenStack Octavia ( Load Balancer as a Service)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1506722

Carlos Goncalves  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 Depends On||1507995, 1417461



--- Comment #3 from Carlos Goncalves  ---
(In reply to Robert-André Mauchin from comment #1)

>  - Did you forget to put the Version and Release infos?

Done.

>  - There is no %changelog entry either!

Done.

>  - No need to complicate things, use version instead of upstream_version and
> remove upstream_version definition

Template client spec suggests using upstream_version [1]. Couple of existing
OpenStack clients specs also defining macro upstream_version [2][3][4][5].


>  - You could use the %{py2_dist/%{py3_dist macros to handle your BR and R.
> See
> https://fedoraproject.org/wiki/Packaging:
> Python#Requires_and_BuildRequires_with_standardized_names

Yes, although:

a) Easier to maintain dependencies with BR and R explicitly thanks to '$ rdopkg
reqcheck'.
b) Consistency with other OpenStack client specs.
c) Straightforward to support RDO and RHOSP, because EL7 does not support such
macros AFAIK.


> There is no package openstack-macros in Fedora repositories. You'll have to
> package it beforehand.

Replaced macro %py_req_cleanup by "rm -f {,test-}requirements.txt" as it's also
not used in existing OpenStack client specs for Fedora.



(In reply to Nir Magnezi from comment #2)

> 1. In other packages we have, URL points to a launchpad URL. since Octavia
> migrated to storyboard, perhaps the URL should be:
> https://storyboard.openstack.org/#!/project/911

Good point! Indeed [1] suggests linking to launchpad. I think that is because
launchpad project pages have been considered good landing pages. Would
project-specific storyboard pages be a good replacement? I'd rather point to
somewhere providing users with more info such as [6], [7] or [8] (because of
the HTML-rendered README).


> 2. You should end up with a separate RPM for tests, see the
> python-neutronclient spec for reference:
> https://github.com/rdo-packages/neutronclient-distgit/blob/
> 26310d84ea59c383c928be5d01d350f0e21291cd/python-neutronclient.spec#L65-L130

Yes, although python-stestr is a dependency and happens that the python-stestr
RPM has a dependency issue (rhbz #1507995). Either we wait for a fix or disable
-tests subpackage.


[1]
https://github.com/openstack-packages/openstack-example-spec/blob/master/python-exampleclient.spec
[2]
http://pkgs.fedoraproject.org/cgit/rpms/python-neutronclient.git/tree/python-neutronclient.spec
[3]
http://pkgs.fedoraproject.org/cgit/rpms/python-novaclient.git/tree/python-novaclient.spec
[4]
http://pkgs.fedoraproject.org/cgit/rpms/python-congressclient.git/tree/python-congressclient.spec
[5]
http://pkgs.fedoraproject.org/cgit/rpms/python-aodhclient.git/tree/python-aodhclient.spec
[6] https://docs.openstack.org/python-octaviaclient/latest/
[7] https://docs.openstack.org/octavia/latest/
[7] https://github.com/openstack/python-octaviaclient


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1417461
[Bug 1417461] python-openstackclient: Provide a Python 3 subpackage
https://bugzilla.redhat.com/show_bug.cgi?id=1507995
[Bug 1507995] Nothing provides python2-PyYAML
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1506722] Review Request: python-octaviaclient - Client for OpenStack Octavia ( Load Balancer as a Service)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1506722

Nir Magnezi  changed:

   What|Removed |Added

 Blocks||1513469




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1513469
[Bug 1513469] Package python-octaviaclient
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1506722] Review Request: python-octaviaclient - Client for OpenStack Octavia ( Load Balancer as a Service)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1506722

Nir Magnezi  changed:

   What|Removed |Added

 CC||nmagn...@redhat.com



--- Comment #2 from Nir Magnezi  ---
Carlos,

Initial review:

1. In other packages we have, URL points to a launchpad URL. since Octavia
migrated to storyboard, perhaps the URL should be:
https://storyboard.openstack.org/#!/project/911

2. You should end up with a separate RPM for tests, see the
python-neutronclient spec for reference:
https://github.com/rdo-packages/neutronclient-distgit/blob/26310d84ea59c383c928be5d01d350f0e21291cd/python-neutronclient.spec#L65-L130

3. Another reference can use to learn how to handle the tests deletion from the
main rpm:
https://github.com/rdo-packages/neutronclient-distgit/commit/296abb5e9aee5019ea22b4f2235f12fae2916a43

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1506722] Review Request: python-octaviaclient - Client for OpenStack Octavia ( Load Balancer as a Service)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1506722

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com
Summary|Review Request: |Review Request:
   |python-octaviaclient-   |python-octaviaclient -
   |Client for OpenStack|Client for OpenStack
   |Octavia (Load Balancer as a |Octavia (Load Balancer as a
   |Service)|Service)



--- Comment #1 from Robert-André Mauchin  ---
Hello,

 - Did you forget to put the Version and Release infos?

Version:XXX
Release:XXX

⇒

Version:1.1.0
Release:1%{?dist}

 - There is no %changelog entry either!

* Thu Oct 26 2017 Carlos Goncalves  - 1.1.0-1
- Initial RPM release

 - No need to complicate things, use version instead of upstream_version and
remove upstream_version definition

%autosetup -n %{name}-%{version}

 - You could use the %{py2_dist/%{py3_dist macros to handle your BR and R. See
https://fedoraproject.org/wiki/Packaging:Python#Requires_and_BuildRequires_with_standardized_names

 - BuildRequires:  openstack-macros

There is no package openstack-macros in Fedora repositories. You'll have to
package it beforehand.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1506722] Review Request: python-octaviaclient- Client for OpenStack Octavia ( Load Balancer as a Service)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1506722

Jon Schlueter  changed:

   What|Removed |Added

 Blocks||1505482




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1505482
[Bug 1505482] [RFE] [Octavia] NewCmp: python-octaviaclient
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org