[Bug 1536852] Review Request: molsketch - Molecular Structures Editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536852



--- Comment #43 from Fedora Update System  ---
molsketch-0.5.1-7.fc27 has been pushed to the Fedora 27 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536852] Review Request: molsketch - Molecular Structures Editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536852

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2018-02-27 11:53:08



--- Comment #42 from Fedora Update System  ---
molsketch-0.5.1-7.fc26 has been pushed to the Fedora 26 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536852] Review Request: molsketch - Molecular Structures Editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536852



--- Comment #41 from Alexander Ploumistos  ---
(In reply to Alexander Ploumistos from comment #40)
> 32-bit OpenBabel has been available since last August, so this can't be
> right.

I meant the last build of OpenBabel.

Btw, I have just installed molsketch on actual i686 hardware and there were no
issues.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536852] Review Request: molsketch - Molecular Structures Editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536852



--- Comment #40 from Alexander Ploumistos  ---
Hi Antonio,

There are these warning messages in Bodhi:

The update can not be pushed: 1 of 1 required tests failed


The failing test is dist.rpmdeplint and this is the explanation:

results:
- arch: x86_64
  item: molsketch-0.5.1-7.fc27
  outcome: FAILED
  scenario: x86_64
  type: koji_build


nothing provides openbabel(x86-32) needed by molsketch-0.5.1-7.fc27.i686
nothing provides openbabel(x86-32) needed by molsketch-0.5.1-7.fc27.i686

It's the same for fc26.

32-bit OpenBabel has been available since last August, so this can't be right.
Also, while the arch is x86_64, the failures concern the i686 packages.

Have I done something wrong, or should I ask about these failures on devel@?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536852] Review Request: molsketch - Molecular Structures Editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536852



--- Comment #39 from Fedora Update System  ---
molsketch-0.5.1-7.fc27 has been pushed to the Fedora 27 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-6ccf2bb289

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536852] Review Request: molsketch - Molecular Structures Editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536852

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #38 from Fedora Update System  ---
molsketch-0.5.1-7.fc26 has been pushed to the Fedora 26 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-c755bcbeff

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536852] Review Request: molsketch - Molecular Structures Editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536852



--- Comment #37 from Alexander Ploumistos  ---
I just did.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536852] Review Request: molsketch - Molecular Structures Editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536852



--- Comment #36 from Antonio Trande  ---
Why not.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536852] Review Request: molsketch - Molecular Structures Editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536852



--- Comment #35 from Alexander Ploumistos  ---
Antonio, do you think that I should add Molsketch (and/or SciDAVis) to the
comps XML file under "Engineering and Scientific"?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536852] Review Request: molsketch - Molecular Structures Editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536852

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536852] Review Request: molsketch - Molecular Structures Editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536852



--- Comment #34 from Fedora Update System  ---
molsketch-0.5.1-7.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-c755bcbeff

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536852] Review Request: molsketch - Molecular Structures Editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536852



--- Comment #33 from Fedora Update System  ---
molsketch-0.5.1-7.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-6ccf2bb289

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536852] Review Request: molsketch - Molecular Structures Editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536852



--- Comment #32 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/molsketch

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536852] Review Request: molsketch - Molecular Structures Editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536852



--- Comment #31 from Alexander Ploumistos  ---
Thank you very much Antonio!
Once again, it's been very educational.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536852] Review Request: molsketch - Molecular Structures Editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536852

Antonio Trande  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #30 from Antonio Trande  ---
Package approved.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Header files in -devel subpackage, if present.
  Note: molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/TextInputItem.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/abstractxmlobject.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/actions/abstractitemaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/actions/abstractrecursiveitemaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/actions/alignmentaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/actions/arrowtypeaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/actions/arrowtypewidget.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/actions/bondtypeaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/actions/bondtypewidget.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/actions/coloraction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/actions/connectaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/actions/deleteaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/actions/drawaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/actions/flipbondaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/actions/flipstereobondsaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/actions/frameaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/actions/frametypeaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/actions/frametypewidget.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/actions/genericaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/actions/incdecaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/actions/itemgrouptypeaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/actions/itemtypeaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/actions/itemtypeselectionaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/actions/itemtypewidget.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/actions/linewidthaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/actions/mechanismarrowaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/actions/multiaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/actions/periodictablewidget.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/actions/reactionarrowaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/actions/ringaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/actions/rotateaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/actions/textaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/actions/transformcommand.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/arrow.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/arrowpopup.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/atom.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/atompopup.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/bond.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/boundingboxlinker.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-7.fc28.x86_64/libmolsketch/commands.h
  molsketch-debugsource :
  

[Bug 1536852] Review Request: molsketch - Molecular Structures Editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536852



--- Comment #29 from Alexander Ploumistos  ---
Built from the newest snapshot, source for OpenBabel interface removed from
devel subpackage.

Spec URL: https://alexpl.fedorapeople.org/packages/Molsketch/molsketch.spec
SRPM URL:
https://alexpl.fedorapeople.org/packages/Molsketch/molsketch-0.5.1-7.fc28.src.rpm

rawhide scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=24943591
f27 scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=24943607

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536852] Review Request: molsketch - Molecular Structures Editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536852



--- Comment #28 from Alexander Ploumistos  ---
Spec URL: https://alexpl.fedorapeople.org/packages/Molsketch/molsketch.spec
SRPM URL:
https://alexpl.fedorapeople.org/packages/Molsketch/molsketch-0.5.1-6.fc28.src.rpm

rawhide scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=24893031
f27 scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=24893587

I used Hendrik's latest snapshot and it seems there aren't any unversioned
shared object files any more, so I had to adjust. I've only added the .so files
to the regular package.

OpenBabel-dependent stuff work.

I still get the "useless-provides debuginfo(build-id)" error for
molsketch-debuginfo.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536852] Review Request: molsketch - Molecular Structures Editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536852



--- Comment #27 from Antonio Trande  ---
Created attachment 1393272
  --> https://bugzilla.redhat.com/attachment.cgi?id=1393272=edit
Patch for installation of header files

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536852] Review Request: molsketch - Molecular Structures Editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536852



--- Comment #26 from Antonio Trande  ---
(In reply to Alexander Ploumistos from comment #25)
> (In reply to Antonio Trande from comment #24)
> > - Openbabel features do not work yet.
> 
> Sorry about the mess, I had been using 2 different machines plus koji and I
> mixed up my files. That's why the spec files don't match.
> 
> The f27 scratch build does work for me and the rawhide build was made from
> the same rpm, so maybe you could try removing 
> ~/.config/SourceForge/Molsketch.conf
> if it's there and try again?

Bingo! It's working now.

> 
>  
> > - ldconfig scriplets are not needed if you install libraries in a private
> > directory.
> 
> And for the devel subpackages they are not needed at all?

Yes.

> 
> 
> > - You're installing duplicate libraries with devel sub-package
> > 
> > Remove
> > 
> > %{_libdir}/%{name}/lib%{name}*so
> > %{_libdir}/%{name}/libobabeliface*so
> 
> And leave only
> %{_includedir}/lib%{name}
> ?

We finally understand what was the problem, then we can separate correctly the
libraries; that is '*.so' in devel and '*.so.*' in main package.

> 
> 
> > - Not all headers are installed; see the list below.
> >   Respect the directories too; for example:
> > 
> >  
> > /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/
> > abstractitemaction.h
> > 
> > is installed as
> > 
> >   /usr/include/libmolsketch/actions/abstractitemaction.h
> > 
> > and so on.
> 
> I am sorry, but I do not understand what I am supposed to do here, could you
> please explain a bit?
> 
> 
> I'll sort through my files tonight, I will add your corrections and submit
> new builds probably tomorrow.

For 'rpmlint' not all the *.h files are installed.
For example,
'/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/obabeliface/obabeliface.h' is not
in the '-devel' subpackage.

You can quickly fix with the attached patch.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536852] Review Request: molsketch - Molecular Structures Editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536852



--- Comment #25 from Alexander Ploumistos  ---
(In reply to Antonio Trande from comment #24)
> - Openbabel features do not work yet.

Sorry about the mess, I had been using 2 different machines plus koji and I
mixed up my files. That's why the spec files don't match.

The f27 scratch build does work for me and the rawhide build was made from the
same rpm, so maybe you could try removing  ~/.config/SourceForge/Molsketch.conf
if it's there and try again?


> - ldconfig scriplets are not needed if you install libraries in a private
> directory.

And for the devel subpackages they are not needed at all?


> - You're installing duplicate libraries with devel sub-package
> 
> Remove
> 
> %{_libdir}/%{name}/lib%{name}*so
> %{_libdir}/%{name}/libobabeliface*so

And leave only
%{_includedir}/lib%{name}
?


> - Not all headers are installed; see the list below.
>   Respect the directories too; for example:
> 
>  
> /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/
> abstractitemaction.h
> 
> is installed as
> 
>   /usr/include/libmolsketch/actions/abstractitemaction.h
> 
> and so on.

I am sorry, but I do not understand what I am supposed to do here, could you
please explain a bit?


I'll sort through my files tonight, I will add your corrections and submit new
builds probably tomorrow.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536852] Review Request: molsketch - Molecular Structures Editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536852



--- Comment #24 from Antonio Trande  ---
- Openbabel features do not work yet.

- ldconfig scriplets are not needed if you install libraries in a private
directory.

- /usr/lib64/molsketch directory is not owned.
  Use the line

%{_libdir}/%{name}/

- You're installing duplicate libraries with devel sub-package

Remove

%{_libdir}/%{name}/lib%{name}*so
%{_libdir}/%{name}/libobabeliface*so

- Diff spec file in url and in SRPM.
  See rpmlint's output.

- Not all headers are installed; see the list below.
  Respect the directories too; for example:

 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/abstractitemaction.h

is installed as

  /usr/include/libmolsketch/actions/abstractitemaction.h

and so on.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

Issues:
===
- Header files in -devel subpackage, if present.
  Note: molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/TextInputItem.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/abstractxmlobject.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/abstractitemaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/abstractrecursiveitemaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/alignmentaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/arrowtypeaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/arrowtypewidget.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/bondtypeaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/bondtypewidget.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/coloraction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/connectaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/deleteaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/drawaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/flipbondaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/flipstereobondsaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/frameaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/frametypeaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/frametypewidget.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/genericaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/incdecaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/itemgrouptypeaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/itemtypeaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/itemtypeselectionaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/itemtypewidget.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/linewidthaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/mechanismarrowaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/multiaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/periodictablewidget.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/reactionarrowaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/ringaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/rotateaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/textaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/transformcommand.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/arrow.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/arrowpopup.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/atom.h
  

[Bug 1536852] Review Request: molsketch - Molecular Structures Editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536852



--- Comment #23 from Alexander Ploumistos  ---
New builds, after Hendrik's update.
I've also remembered to use %ldconfig_scriptlets.

Spec URL: https://alexpl.fedorapeople.org/packages/Molsketch/molsketch.spec
SRPM URL:
https://alexpl.fedorapeople.org/packages/Molsketch/molsketch-0.5.1-5.fc28.src.rpm

koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=24808294

and one for f27: https://koji.fedoraproject.org/koji/taskinfo?taskID=24808437

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536852] Review Request: molsketch - Molecular Structures Editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536852



--- Comment #22 from Alexander Ploumistos  ---
Also, I installed molsketch and all its subpackages in mock (built using the
same spec file as in koji build 24441314) and there were no errors:

$ mock -r fedora-rawhide-x86_64 --install
/var/lib/mock/fedora-rawhide-x86_64/result/molsketch-0.5.1-4.fc28.x86_64.rpm
/var/lib/mock/fedora-rawhide-x86_64/result/molsketch-doc-0.5.1-4.fc28.noarch.rpm
/var/lib/mock/fedora-rawhide-x86_64/result/molsketch-devel-0.5.1-4.fc28.x86_64.rpm
/var/lib/mock/fedora-rawhide-x86_64/result/molsketch-debugsource-0.5.1-4.fc28.x86_64.rpm
/var/lib/mock/fedora-rawhide-x86_64/result/molsketch-debuginfo-0.5.1-4.fc28.x86_64.rpm

INFO: mock.py version 1.4.8 starting (python version = 3.6.4)...
Start: init plugins
INFO: selinux disabled
Finish: init plugins
Start: run
Start: chroot init
INFO: calling preinit hooks
INFO: enabled root cache
INFO: enabled dnf cache
Start: cleaning dnf metadata
Finish: cleaning dnf metadata
INFO: enabled HW Info plugin
Mock Version: 1.4.8
INFO: Mock Version: 1.4.8
Finish: chroot init
INFO: installing package(s):
/var/lib/mock/fedora-rawhide-x86_64/result/molsketch-0.5.1-4.fc28.x86_64.rpm
/var/lib/mock/fedora-rawhide-x86_64/result/molsketch-doc-0.5.1-4.fc28.noarch.rpm
/var/lib/mock/fedora-rawhide-x86_64/result/molsketch-devel-0.5.1-4.fc28.x86_64.rpm
/var/lib/mock/fedora-rawhide-x86_64/result/molsketch-debugsource-0.5.1-4.fc28.x86_64.rpm
/var/lib/mock/fedora-rawhide-x86_64/result/molsketch-debuginfo-0.5.1-4.fc28.x86_64.rpm

[…]

Installed:
  molsketch.x86_64 0.5.1-4.fc28  
molsketch-debuginfo.x86_64 0.5.1-4.fc28   molsketch-debugsource.x86_64
0.5.1-4.fc28
  molsketch-devel.x86_64 0.5.1-4.fc28
molsketch-doc.noarch 0.5.1-4.fc28 SDL.x86_64 1.2.15-29.fc28 
  atk.x86_64 2.27.1-1.fc28   
gdk-pixbuf2-modules.x86_64 2.36.11-1.fc28 gtk-update-icon-cache.x86_64
3.22.26-2.fc28  
  gtk2.x86_64 2.24.32-1.fc28 
openbabel.x86_64 2.4.1-10.fc28qt5-designer.x86_64
5.10.0-2.fc28
  qt5-doctools.x86_64 5.10.0-2.fc28  
qt5-linguist.x86_64 5.10.0-2.fc28 qt5-qttools.x86_64
5.10.0-2.fc28 
  qt5-qttools-common.noarch 5.10.0-2.fc28
qt5-qttools-devel.x86_64 5.10.0-2.fc28   
qt5-qttools-libs-designer.x86_64 5.10.0-2.fc28   
  qt5-qttools-libs-designercomponents.x86_64 5.10.0-2.fc28   
qt5-qttools-libs-help.x86_64 5.10.0-2.fc28wxBase.x86_64 2.8.12-29.fc27  
  wxGTK.x86_64 2.8.12-29.fc27

Complete!
INFO: 
Finish: run

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536852] Review Request: molsketch - Molecular Structures Editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536852



--- Comment #21 from Alexander Ploumistos  ---
(In reply to Antonio Trande from comment #7)
> >- Header files in -devel subpackage, if present.
> >  Note: molsketch-debugsource :
> >  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/TextInputItem.h
> >  molsketch-debugsource :
> > ...
> 
> 'qmake' does not install all header files, i don't know why. Can you ask to
> upstream which headers must be provided?

Hendrik looked into that one:

> after having had a look at the RPM's content I'm confused... It appears to 
> contain everything from the source, headers, cpp files, even the generated 
> headers and sources (i.e. Qt's moc files). Did they give you any hints as to 
> what is missing? Or how we can test it? Were they not able to properly debug 
> it (i.e. did the debugger not find the files?)?

And it's true, the devel subpackage contains even the generated headers, not
just the original ones, so what is the problem there?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536852] Review Request: molsketch - Molecular Structures Editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536852



--- Comment #20 from Alexander Ploumistos  ---
Created attachment 1386508
  --> https://bugzilla.redhat.com/attachment.cgi?id=1386508=edit
Fresh installation on default Live Workstation

(In reply to Antonio Trande from comment #18)
> (In reply to Alexander Ploumistos from comment #15)
> > I am attaching a screenshot of the program from this scratch build for f27:
> > https://koji.fedoraproject.org/koji/taskinfo?taskID=24441314
> > 
> > As you can see, all of the "extra" features are enabled.
> > 
> > I tried ~15 builds yesterday, the only change that made a difference was
> > that dot.
> 
> It does not work to me.
> Have you done additional settings? (From Edit --> Preference menu)
> Upstream bug: https://sourceforge.net/p/molsketch/bugs/24/

Are you sure you used this build?
https://koji.fedoraproject.org/koji/taskinfo?taskID=24441314

This screenshot is from a system running F27 Live Workstation and as you can
see everything is working.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536852] Review Request: molsketch - Molecular Structures Editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536852



--- Comment #19 from Alexander Ploumistos  ---
Created attachment 1386274
  --> https://bugzilla.redhat.com/attachment.cgi?id=1386274=edit
New user with defaults

(In reply to Antonio Trande from comment #18)
> It does not work to me.
> Have you done additional settings? (From Edit --> Preference menu)
> Upstream bug: https://sourceforge.net/p/molsketch/bugs/24/

Just tested with a new user, these are the default settings.
It seems to work here…

Tomorrow I'll try completely uninstalling the program and I will check if there
are any remnants of previous installations before reinstalling.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536852] Review Request: molsketch - Molecular Structures Editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536852



--- Comment #18 from Antonio Trande  ---
(In reply to Alexander Ploumistos from comment #15)
> Created attachment 1386243 [details]
> Features with unversioned libraries packaged
> 
> (In reply to Antonio Trande from comment #14)
> > If this binary uses Openbabel, you see it does not link libobabeliface-qt5.
> 
> I noticed it too, I don't know what to tell you.
> 
>  
> > Related links look like that:
> > 
> > molsketch-qt5 --> libmolsketch-qt5.so.0
> > libobabeliface-qt5.so.0 --> libmolsketch-qt5.so.0
> > libobabeliface-qt5.so.0 --> libopenbabel.so.5
> > 
> > Do you confirm that your "working" binary files have these links?
> 
> Nope, ldd does not mention libobabeliface anywhere.
> 
> I am attaching a screenshot of the program from this scratch build for f27:
> https://koji.fedoraproject.org/koji/taskinfo?taskID=24441314
> 
> As you can see, all of the "extra" features are enabled.
> 
> I tried ~15 builds yesterday, the only change that made a difference was
> that dot.

It does not work to me.
Have you done additional settings? (From Edit --> Preference menu)
Upstream bug: https://sourceforge.net/p/molsketch/bugs/24/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536852] Review Request: molsketch - Molecular Structures Editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536852



--- Comment #17 from Alexander Ploumistos  ---
(In reply to Antonio Trande from comment #16)
> What's the output from command-line of your "working" molsketch?

$ molsketch-qt5
Info: ((null):0, (null)) Clearing list of molecules. Count: 0
Warning: ((null):0, (null)) :icons/document-new.svg:602:58: Could not resolve
property: linearGradient5167
Warning: ((null):0, (null)) :icons/document-new.svg:602:58: Could not resolve
property: linearGradient5167
Warning: ((null):0, (null)) :icons/document-open.svg:4290: Could not resolve
property: pattern5614
Warning: ((null):0, (null)) :icons/document-open.svg:4290: Could not resolve
property: pattern5626
Warning: ((null):0, (null)) :icons/document-open.svg:4290: Could not resolve
property: pattern5614
Warning: ((null):0, (null)) :icons/document-open.svg:4290: Could not resolve
property: pattern5626
Warning: ((null):0, (null)) QObject::connect: No such slot
Molsketch::MolScene::convertImage()
Warning: ((null):0, (null)) :icons/preferences-system.svg:1713: Could not
resolve property: linearGradient4636
Warning: ((null):0, (null)) :icons/preferences-system.svg:1713: Could not
resolve property: linearGradient4592
Warning: ((null):0, (null)) :icons/preferences-system.svg:1713: Could not
resolve property: linearGradient4247
Warning: ((null):0, (null)) :icons/preferences-system.svg:1713: Could not
resolve property: linearGradient4636
Warning: ((null):0, (null)) :icons/preferences-system.svg:1713: Could not
resolve property: linearGradient4592
Warning: ((null):0, (null)) :icons/preferences-system.svg:1713: Could not
resolve property: linearGradient4247
Warning: ((null):0, (null)) :icons/help-contents.svg:7092: Could not resolve
property: linearGradient3592
Warning: ((null):0, (null)) :icons/help-contents.svg:7092: Could not resolve
property: linearGradient7999
Warning: ((null):0, (null)) :icons/help-contents.svg:7092: Could not resolve
property: radialGradient2943
Warning: ((null):0, (null)) :icons/help-contents.svg:7092: Could not resolve
property: linearGradient3592
Warning: ((null):0, (null)) :icons/help-contents.svg:7092: Could not resolve
property: linearGradient7999
Warning: ((null):0, (null)) :icons/help-contents.svg:7092: Could not resolve
property: radialGradient2943
Warning: ((null):0, (null)) QGraphicsScene::removeItem: item 0x56101d819540's
scene (0x0) is different from this scene (0x56101d2abc50)
Warning: ((null):0, (null)) QIODevice::write (QProcess): device not open
Warning: ((null):0, (null)) QGraphicsScene::removeItem: item 0x56101d819540's
scene (0x0) is different from this scene (0x56101d2abc50)
Info: ((null):0, (null)) Clearing list of molecules. Count: 0

and after I click on the "Close" button:

Warning: ((null):0, (null)) QMainWindow::saveState(): 'objectName' not set for
QDockWidget 0x56101d426bc0 'Properties;
Info: ((null):0, (null)) Clearing list of molecules. Count: 4
Info: ((null):0, (null)) Clearing list of molecules. Count: 4
Info: ((null):0, (null)) Clearing list of molecules. Count: 0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536852] Review Request: molsketch - Molecular Structures Editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536852



--- Comment #16 from Antonio Trande  ---
What's the output from command-line of your "working" molsketch?

$ molsketch-qt5

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536852] Review Request: molsketch - Molecular Structures Editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536852



--- Comment #15 from Alexander Ploumistos  ---
Created attachment 1386243
  --> https://bugzilla.redhat.com/attachment.cgi?id=1386243=edit
Features with unversioned libraries packaged

(In reply to Antonio Trande from comment #14)
> If this binary uses Openbabel, you see it does not link libobabeliface-qt5.

I noticed it too, I don't know what to tell you.


> Related links look like that:
> 
> molsketch-qt5 --> libmolsketch-qt5.so.0
> libobabeliface-qt5.so.0 --> libmolsketch-qt5.so.0
> libobabeliface-qt5.so.0 --> libopenbabel.so.5
> 
> Do you confirm that your "working" binary files have these links?

Nope, ldd does not mention libobabeliface anywhere.

I am attaching a screenshot of the program from this scratch build for f27:
https://koji.fedoraproject.org/koji/taskinfo?taskID=24441314

As you can see, all of the "extra" features are enabled.

I tried ~15 builds yesterday, the only change that made a difference was that
dot.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536852] Review Request: molsketch - Molecular Structures Editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536852



--- Comment #14 from Antonio Trande  ---
(In reply to Alexander Ploumistos from comment #12)
> (In reply to Antonio Trande from comment #11)
> > Can you post the output of
> > 
> > $ ldd -r /usr/bin/molsketch-qt5
> > 
> > ?
> 
>   linux-vdso.so.1 (0x7ffc76bb)
>   libmolsketch-qt5.so.0 => /lib64/libmolsketch-qt5.so.0 
> (0x7fd8e155c000)
>   libQt5PrintSupport.so.5 => /lib64/libQt5PrintSupport.so.5
> (0x7fd8e12ee000)
>   libQt5Svg.so.5 => /lib64/libQt5Svg.so.5 (0x7fd8e1098000)
>   libQt5Widgets.so.5 => /lib64/libQt5Widgets.so.5 (0x7fd8e084c000)
>   libQt5Gui.so.5 => /lib64/libQt5Gui.so.5 (0x7fd8e018e000)
>   libQt5Network.so.5 => /lib64/libQt5Network.so.5 (0x7fd8dfe06000)
>   libQt5Core.so.5 => /lib64/libQt5Core.so.5 (0x7fd8df764000)
>   libGL.so.1 => /lib64/libGL.so.1 (0x7fd8df4d8000)
>   libpthread.so.0 => /lib64/libpthread.so.0 (0x7fd8df2b9000)
>   libstdc++.so.6 => /lib64/libstdc++.so.6 (0x7fd8def33000)
>   libm.so.6 => /lib64/libm.so.6 (0x7fd8debde000)
>   libgcc_s.so.1 => /lib64/libgcc_s.so.1 (0x7fd8de9c7000)
>   libc.so.6 => /lib64/libc.so.6 (0x7fd8de5e4000)
>   libz.so.1 => /lib64/libz.so.1 (0x7fd8de3cd000)
>   libpng16.so.16 => /lib64/libpng16.so.16 (0x7fd8de19a000)
>   libharfbuzz.so.0 => /lib64/libharfbuzz.so.0 (0x7fd8ddf02000)
>   libssl.so.1.1 => /lib64/libssl.so.1.1 (0x7fd8ddc96000)
>   libcrypto.so.1.1 => /lib64/libcrypto.so.1.1 (0x7fd8dd80e000)
>   libsystemd.so.0 => /lib64/libsystemd.so.0 (0x7fd8dd584000)
>   libicui18n.so.57 => /lib64/libicui18n.so.57 (0x7fd8dd111000)
>   libicuuc.so.57 => /lib64/libicuuc.so.57 (0x7fd8dcd6c000)
>   libicudata.so.57 => /lib64/libicudata.so.57 (0x7fd8db2ef000)
>   libpcre2-16.so.0 => /lib64/libpcre2-16.so.0 (0x7fd8db077000)
>   libdl.so.2 => /lib64/libdl.so.2 (0x7fd8dae73000)
>   libgthread-2.0.so.0 => /lib64/libgthread-2.0.so.0 (0x7fd8dac71000)
>   libglib-2.0.so.0 => /lib64/libglib-2.0.so.0 (0x7fd8da95d000)
>   /lib64/ld-linux-x86-64.so.2 (0x7fd8e1cf9000)
>   libGLX.so.0 => /lib64/libGLX.so.0 (0x7fd8da72b000)
>   libX11.so.6 => /lib64/libX11.so.6 (0x7fd8da3ed000)
>   libXext.so.6 => /lib64/libXext.so.6 (0x7fd8da1db000)
>   libGLdispatch.so.0 => /lib64/libGLdispatch.so.0 (0x7fd8d9f25000)
>   libfreetype.so.6 => /lib64/libfreetype.so.6 (0x7fd8d9c7)
>   libgraphite2.so.3 => /lib64/libgraphite2.so.3 (0x7fd8d9a44000)
>   libgcrypt.so.20 => /lib64/libgcrypt.so.20 (0x7fd8d972a000)
>   librt.so.1 => /lib64/librt.so.1 (0x7fd8d9522000)
>   liblzma.so.5 => /lib64/liblzma.so.5 (0x7fd8d92fc000)
>   liblz4.so.1 => /lib64/liblz4.so.1 (0x7fd8d90e7000)
>   libselinux.so.1 => /lib64/libselinux.so.1 (0x7fd8d8ebe000)
>   libpcre.so.1 => /lib64/libpcre.so.1 (0x7fd8d8c4b000)
>   libxcb.so.1 => /lib64/libxcb.so.1 (0x7fd8d8a23000)
>   libbz2.so.1 => /lib64/libbz2.so.1 (0x7fd8d8812000)
>   libgpg-error.so.0 => /lib64/libgpg-error.so.0 (0x7fd8d85fd000)
>   libpcre2-8.so.0 => /lib64/libpcre2-8.so.0 (0x7fd8d8379000)
>   libXau.so.6 => /lib64/libXau.so.6 (0x7fd8d8175000)

If this binary uses Openbabel, you see it does not link libobabeliface-qt5.

Related links look like that:

molsketch-qt5 --> libmolsketch-qt5.so.0
libobabeliface-qt5.so.0 --> libmolsketch-qt5.so.0
libobabeliface-qt5.so.0 --> libopenbabel.so.5

Do you confirm that your "working" binary files have these links?

>Btw, that's from the last build with all the libraries -versioned & 
>unversioned- packaged.

molsketch does not need all versioned+unversioned libraries to work; real
libraries are that full-versioned, the other ones are links:

$ ll /usr/lib64/libmolsketch-qt5.so*
lrwxrwxrwx. 1 root root  25 23 gen 11.32 /usr/lib64/libmolsketch-qt5.so.0
-> libmolsketch-qt5.so.0.5.1
lrwxrwxrwx. 1 root root  25 23 gen 11.32 /usr/lib64/libmolsketch-qt5.so.0.5
-> libmolsketch-qt5.so.0.5.1
-rwxr-xr-x. 1 root root 1390312 23 gen 11.32
/usr/lib64/libmolsketch-qt5.so.0.5.1

$ ll /usr/lib64/libobabeliface-qt5.so*
lrwxrwxrwx. 1 root root27 23 gen 11.32 /usr/lib64/libobabeliface-qt5.so.0
-> libobabeliface-qt5.so.0.5.1
lrwxrwxrwx. 1 root root27 23 gen 11.32 /usr/lib64/libobabeliface-qt5.so.0.5
-> libobabeliface-qt5.so.0.5.1
-rwxr-xr-x. 1 root root 56880 23 gen 11.32
/usr/lib64/libobabeliface-qt5.so.0.5.1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536852] Review Request: molsketch - Molecular Structures Editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536852



--- Comment #13 from Alexander Ploumistos  ---
Btw, that's from the last build with all the libraries -versioned &
unversioned- packaged.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536852] Review Request: molsketch - Molecular Structures Editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536852



--- Comment #12 from Alexander Ploumistos  ---
(In reply to Antonio Trande from comment #11)
> Can you post the output of
> 
> $ ldd -r /usr/bin/molsketch-qt5
> 
> ?

linux-vdso.so.1 (0x7ffc76bb)
libmolsketch-qt5.so.0 => /lib64/libmolsketch-qt5.so.0 (0x7fd8e155c000)
libQt5PrintSupport.so.5 => /lib64/libQt5PrintSupport.so.5
(0x7fd8e12ee000)
libQt5Svg.so.5 => /lib64/libQt5Svg.so.5 (0x7fd8e1098000)
libQt5Widgets.so.5 => /lib64/libQt5Widgets.so.5 (0x7fd8e084c000)
libQt5Gui.so.5 => /lib64/libQt5Gui.so.5 (0x7fd8e018e000)
libQt5Network.so.5 => /lib64/libQt5Network.so.5 (0x7fd8dfe06000)
libQt5Core.so.5 => /lib64/libQt5Core.so.5 (0x7fd8df764000)
libGL.so.1 => /lib64/libGL.so.1 (0x7fd8df4d8000)
libpthread.so.0 => /lib64/libpthread.so.0 (0x7fd8df2b9000)
libstdc++.so.6 => /lib64/libstdc++.so.6 (0x7fd8def33000)
libm.so.6 => /lib64/libm.so.6 (0x7fd8debde000)
libgcc_s.so.1 => /lib64/libgcc_s.so.1 (0x7fd8de9c7000)
libc.so.6 => /lib64/libc.so.6 (0x7fd8de5e4000)
libz.so.1 => /lib64/libz.so.1 (0x7fd8de3cd000)
libpng16.so.16 => /lib64/libpng16.so.16 (0x7fd8de19a000)
libharfbuzz.so.0 => /lib64/libharfbuzz.so.0 (0x7fd8ddf02000)
libssl.so.1.1 => /lib64/libssl.so.1.1 (0x7fd8ddc96000)
libcrypto.so.1.1 => /lib64/libcrypto.so.1.1 (0x7fd8dd80e000)
libsystemd.so.0 => /lib64/libsystemd.so.0 (0x7fd8dd584000)
libicui18n.so.57 => /lib64/libicui18n.so.57 (0x7fd8dd111000)
libicuuc.so.57 => /lib64/libicuuc.so.57 (0x7fd8dcd6c000)
libicudata.so.57 => /lib64/libicudata.so.57 (0x7fd8db2ef000)
libpcre2-16.so.0 => /lib64/libpcre2-16.so.0 (0x7fd8db077000)
libdl.so.2 => /lib64/libdl.so.2 (0x7fd8dae73000)
libgthread-2.0.so.0 => /lib64/libgthread-2.0.so.0 (0x7fd8dac71000)
libglib-2.0.so.0 => /lib64/libglib-2.0.so.0 (0x7fd8da95d000)
/lib64/ld-linux-x86-64.so.2 (0x7fd8e1cf9000)
libGLX.so.0 => /lib64/libGLX.so.0 (0x7fd8da72b000)
libX11.so.6 => /lib64/libX11.so.6 (0x7fd8da3ed000)
libXext.so.6 => /lib64/libXext.so.6 (0x7fd8da1db000)
libGLdispatch.so.0 => /lib64/libGLdispatch.so.0 (0x7fd8d9f25000)
libfreetype.so.6 => /lib64/libfreetype.so.6 (0x7fd8d9c7)
libgraphite2.so.3 => /lib64/libgraphite2.so.3 (0x7fd8d9a44000)
libgcrypt.so.20 => /lib64/libgcrypt.so.20 (0x7fd8d972a000)
librt.so.1 => /lib64/librt.so.1 (0x7fd8d9522000)
liblzma.so.5 => /lib64/liblzma.so.5 (0x7fd8d92fc000)
liblz4.so.1 => /lib64/liblz4.so.1 (0x7fd8d90e7000)
libselinux.so.1 => /lib64/libselinux.so.1 (0x7fd8d8ebe000)
libpcre.so.1 => /lib64/libpcre.so.1 (0x7fd8d8c4b000)
libxcb.so.1 => /lib64/libxcb.so.1 (0x7fd8d8a23000)
libbz2.so.1 => /lib64/libbz2.so.1 (0x7fd8d8812000)
libgpg-error.so.0 => /lib64/libgpg-error.so.0 (0x7fd8d85fd000)
libpcre2-8.so.0 => /lib64/libpcre2-8.so.0 (0x7fd8d8379000)
libXau.so.6 => /lib64/libXau.so.6 (0x7fd8d8175000)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536852] Review Request: molsketch - Molecular Structures Editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536852



--- Comment #11 from Antonio Trande  ---
(In reply to Alexander Ploumistos from comment #10)
> Caught it:
> 
> diff 0.5.1-4/molsketch.spec 0.5.1-4b/molsketch.spec 
> 90c90
> < %{_libdir}/lib*.so.*
> ---
> > %{_libdir}/lib*.so*
> 
> If I revert that line to how it was before, it works. How should I proceed?

Can you post the output of

$ ldd -r /usr/bin/molsketch-qt5

?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536852] Review Request: molsketch - Molecular Structures Editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536852



--- Comment #10 from Alexander Ploumistos  ---
Caught it:

diff 0.5.1-4/molsketch.spec 0.5.1-4b/molsketch.spec 
90c90
< %{_libdir}/lib*.so.*
---
> %{_libdir}/lib*.so*

If I revert that line to how it was before, it works. How should I proceed?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536852] Review Request: molsketch - Molecular Structures Editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536852



--- Comment #9 from Alexander Ploumistos  ---
(In reply to Antonio Trande from comment #7)
> (In reply to Alexander Ploumistos from comment #6)
> > The 0.5.1-4 build is missing the requirement on
> > libobabeliface-qt5.so.0()(64bit). But how did this happen?
> 
> Because in the release 2 there was the line "'Requires: lib%{name}-qt5'".
> 'molsketch-qt5' doesn't need 'libobabeliface-qt5', it seems.

As far as I understand it, libobeliface is used to connect Molsketch with
OpenBabel, so it is very much needed.

It has been a busy week, when I get some spare time I'll try to revert some of
the changes incrementally and see what happens.


> >- Header files in -devel subpackage, if present.
> >  Note: molsketch-debugsource :
> >  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/TextInputItem.h
> >  molsketch-debugsource :
> > ...
> 
> 'qmake' does not install all header files, i don't know why. Can you ask to
> upstream which headers must be provided?

I will send a message in a few minutes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536852] Review Request: molsketch - Molecular Structures Editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536852



--- Comment #8 from Alexander Ploumistos  ---
Created attachment 1385256
  --> https://bugzilla.redhat.com/attachment.cgi?id=1385256=edit
OpenBabel-dependent features

(In reply to Antonio Trande from comment #7)
> (In reply to Alexander Ploumistos from comment #6)
> > The 0.5.1-4 build is missing the requirement on
> > libobabeliface-qt5.so.0()(64bit). But how did this happen?
> 
> Because in the release 2 there was the line "'Requires: lib%{name}-qt5'".
> 'molsketch-qt5' doesn't need 'libobabeliface-qt5', it seems.
> 
> >There is one serious regression now. When the program starts, I can see that 
> >it >is not using OpenBabel, in the bottom right corner it shows everything 
> >with a >minus (OpenBabel, InChI, gen2d). Can you tell where I've messed up?
> 
> Does your latest release not provide all functions yet?
> Can you show me a screenshot?

The screenshot is from the 0.5.1-2 build. In the bottom left corner you can see
the plus signs in front of OpenBabel, InChI and gen2d, which means that
OpenBabel is found and enabled. The last button on the toolbar top right is for
cleaning up structures, with the help of OpenBabel. In 0.5.1-4 all these are
disabled.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536852] Review Request: molsketch - Molecular Structures Editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536852



--- Comment #7 from Antonio Trande  ---
(In reply to Alexander Ploumistos from comment #6)
> I ran a side by side comparison of the 0.5.1-2 and 0.5.1-4 x86_64 builds and
> I found the difference:
> 
> Processing files: molsketch-0.5.1-2.fc28.x86_64
> […]
> Requires: libGL.so.1()(64bit) libQt5Core.so.5()(64bit)
> libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.10)(64bit)
> libQt5Gui.so.5()(64bit) libQt5Gui.so.5(Qt_5)(64bit)
> libQt5Network.so.5()(64bit) libQt5Network.so.5(Qt_5)(64bit)
> libQt5PrintSupport.so.5()(64bit) libQt5PrintSupport.so.5(Qt_5)(64bit)
> libQt5Svg.so.5()(64bit) libQt5Svg.so.5(Qt_5)(64bit)
> libQt5Widgets.so.5()(64bit) libQt5Widgets.so.5(Qt_5)(64bit)
> libc.so.6()(64bit) libc.so.6(GLIBC_2.14)(64bit)
> libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.3.4)(64bit)
> libc.so.6(GLIBC_2.4)(64bit) libgcc_s.so.1()(64bit)
> libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit)
> libm.so.6(GLIBC_2.2.5)(64bit) libmolsketch-qt5.so.0()(64bit)
> libobabeliface-qt5.so.0()(64bit) libopenbabel.so.5()(64bit)
> libpthread.so.0()(64bit) libstdc++.so.6()(64bit)
> libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit)
> libstdc++.so.6(GLIBCXX_3.4)(64bit) libstdc++.so.6(GLIBCXX_3.4.14)(64bit)
> rtld(GNU_HASH)
> 
> 
> Processing files: molsketch-0.5.1-4.fc28.x86_64
> […]
> Requires: libGL.so.1()(64bit) libQt5Core.so.5()(64bit)
> libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.10)(64bit)
> libQt5Gui.so.5()(64bit) libQt5Gui.so.5(Qt_5)(64bit)
> libQt5Network.so.5()(64bit) libQt5Network.so.5(Qt_5)(64bit)
> libQt5PrintSupport.so.5()(64bit) libQt5PrintSupport.so.5(Qt_5)(64bit)
> libQt5Svg.so.5()(64bit) libQt5Svg.so.5(Qt_5)(64bit)
> libQt5Widgets.so.5()(64bit) libQt5Widgets.so.5(Qt_5)(64bit)
> libc.so.6()(64bit) libc.so.6(GLIBC_2.14)(64bit)
> libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.3.4)(64bit)
> libc.so.6(GLIBC_2.4)(64bit) libgcc_s.so.1()(64bit)
> libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit)
> libm.so.6(GLIBC_2.2.5)(64bit) libmolsketch-qt5.so.0()(64bit)
> libopenbabel.so.5()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit)
> libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit)
> libstdc++.so.6(GLIBCXX_3.4)(64bit) libstdc++.so.6(GLIBCXX_3.4.14)(64bit)
> rtld(GNU_HASH)
> 
> The 0.5.1-4 build is missing the requirement on
> libobabeliface-qt5.so.0()(64bit). But how did this happen?

Because in the release 2 there was the line "'Requires: lib%{name}-qt5'".
'molsketch-qt5' doesn't need 'libobabeliface-qt5', it seems.

>There is one serious regression now. When the program starts, I can see that 
>it >is not using OpenBabel, in the bottom right corner it shows everything 
>with a >minus (OpenBabel, InChI, gen2d). Can you tell where I've messed up?

Does your latest release not provide all functions yet?
Can you show me a screenshot?

>- Header files in -devel subpackage, if present.
>  Note: molsketch-debugsource :
>  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/TextInputItem.h
>  molsketch-debugsource :
> ...

'qmake' does not install all header files, i don't know why. Can you ask to
upstream which headers must be provided?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536852] Review Request: molsketch - Molecular Structures Editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536852



--- Comment #6 from Alexander Ploumistos  ---
I ran a side by side comparison of the 0.5.1-2 and 0.5.1-4 x86_64 builds and I
found the difference:

Processing files: molsketch-0.5.1-2.fc28.x86_64
[…]
Requires: libGL.so.1()(64bit) libQt5Core.so.5()(64bit)
libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.10)(64bit)
libQt5Gui.so.5()(64bit) libQt5Gui.so.5(Qt_5)(64bit) libQt5Network.so.5()(64bit)
libQt5Network.so.5(Qt_5)(64bit) libQt5PrintSupport.so.5()(64bit)
libQt5PrintSupport.so.5(Qt_5)(64bit) libQt5Svg.so.5()(64bit)
libQt5Svg.so.5(Qt_5)(64bit) libQt5Widgets.so.5()(64bit)
libQt5Widgets.so.5(Qt_5)(64bit) libc.so.6()(64bit) libc.so.6(GLIBC_2.14)(64bit)
libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.3.4)(64bit)
libc.so.6(GLIBC_2.4)(64bit) libgcc_s.so.1()(64bit)
libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libm.so.6(GLIBC_2.2.5)(64bit)
libmolsketch-qt5.so.0()(64bit) libobabeliface-qt5.so.0()(64bit)
libopenbabel.so.5()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit)
libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit)
libstdc++.so.6(GLIBCXX_3.4)(64bit) libstdc++.so.6(GLIBCXX_3.4.14)(64bit)
rtld(GNU_HASH)


Processing files: molsketch-0.5.1-4.fc28.x86_64
[…]
Requires: libGL.so.1()(64bit) libQt5Core.so.5()(64bit)
libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.10)(64bit)
libQt5Gui.so.5()(64bit) libQt5Gui.so.5(Qt_5)(64bit) libQt5Network.so.5()(64bit)
libQt5Network.so.5(Qt_5)(64bit) libQt5PrintSupport.so.5()(64bit)
libQt5PrintSupport.so.5(Qt_5)(64bit) libQt5Svg.so.5()(64bit)
libQt5Svg.so.5(Qt_5)(64bit) libQt5Widgets.so.5()(64bit)
libQt5Widgets.so.5(Qt_5)(64bit) libc.so.6()(64bit) libc.so.6(GLIBC_2.14)(64bit)
libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.3.4)(64bit)
libc.so.6(GLIBC_2.4)(64bit) libgcc_s.so.1()(64bit)
libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libm.so.6(GLIBC_2.2.5)(64bit)
libmolsketch-qt5.so.0()(64bit) libopenbabel.so.5()(64bit)
libpthread.so.0()(64bit) libstdc++.so.6()(64bit)
libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit)
libstdc++.so.6(GLIBCXX_3.4)(64bit) libstdc++.so.6(GLIBCXX_3.4.14)(64bit)
rtld(GNU_HASH)

The 0.5.1-4 build is missing the requirement on
libobabeliface-qt5.so.0()(64bit). But how did this happen?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536852] Review Request: molsketch - Molecular Structures Editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536852



--- Comment #5 from Alexander Ploumistos  ---
$ diff 0.5.1-2/molsketch.spec 0.5.1-4/molsketch.spec 
3c3
< Release:2%{?dist}
---
> Release:4%{?dist}
5c5
< License:GPLv2
---
> License:GPLv2+
16d15
< BuildRequires:  qca
23c22
< Requires:   openbabel
---
> Requires:   openbabel%{?_isa}
36c35
< License:GPLv2
---
> License:GPLv2+
47,48c46,47
< Requires:   lib%{name}-qt5
< #Requires:   libqt5-qttools
---
> Requires:   %{name}%{?_isa} = %{version}-%{release}
> Requires:   qt5-qttools-devel
59c58
< #%setup -q -n Molsketch-%{version}
---
> #%%setup -q -n Molsketch-%%{version}
61c60
< #%setup -q -n Molsketch-latest
---
> #%%setup -q -n Molsketch-latest
68c67
< %{qmake_qt5} "MSK_PREFIX=%{_prefix}" "MSK_INSTALL_PREFIX=%{_prefix}"
"MSK_INSTALL_DOCS=%{_docdir}/%{name}" ./Molsketch.pro
---
> %{qmake_qt5} "MSK_PREFIX=%{_prefix}" "MSK_INSTALL_PREFIX=%{_prefix}" 
> "MSK_INSTALL_DOCS=%{_docdir}/%{name}" "MSK_INSTALL_LIBS=%{_libdir}" 
> "MSK_INSTALL_INCLUDES=%{_includedir}/lib%{name}" ./Molsketch.pro
73c72
< make INSTALL_ROOT="%{buildroot}" install
---
> %make_install INSTALL_ROOT="%{buildroot}"
81,82c80
< %post
< /sbin/ldconfig
---
> %post -p /sbin/ldconfig
85,86c83
< %postun
< /sbin/ldconfig
---
> %postun -p /sbin/ldconfig
91c88
< %doc CHANGELOG INSTALL
---
> %doc CHANGELOG
93c90
< %{_libdir}/lib*.so*
---
> %{_libdir}/lib*.so.*
97c94,95
< %{_datadir}/icons/hicolor/scalable/*
---
> %{_datadir}/icons/hicolor/scalable/mimetypes/application-x-%{name}.svg
> %{_datadir}/icons/hicolor/scalable/apps/%{name}.svg
101a100
> %license COPYING
106c105
< %{_includedir}/%{name}
---
> %{_includedir}/lib%{name}
111a111,116
> * Mon Jan 22 2018 Alexander Ploumistos  - 0.5.1-4
> - More cleaning up 
> 
> * Mon Jan 22 2018 Alexander Ploumistos  - 0.5.1-3
> - Clean up spec file according to remarks by Antonio Trande (rhbz#1536852)
> 
128c133
< - Fix %post & %postun scriptlets
---
> - Fix post & postun scriptlets


Could it be the %{_includedir}/lib%{name} change? Maybe change it to
%{_includedir}/%{name}?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536852] Review Request: molsketch - Molecular Structures Editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536852



--- Comment #4 from Alexander Ploumistos  ---
(In reply to Antonio Trande from comment #3)
> - Error: 
>  Problem: conflicting requests
>   - nothing provides libmolsketch-qt5 needed by
> molsketch-devel-0.5.1-3.fc28.x86_64
> 
> Remove 
> 
> 'Requires: lib%{name}-qt5'

Done.

> >The OpenSUSE spec file also listed libqt5-qttools as a requirement for the 
> >devel >package, but we don't have that in Fedora. Do you know what that is 
> >about?
> 
> Use 'qt5-qttools-devel'.

Done.


> - Diff spec file in url and in SRPM

These should be the same now:

Spec URL: https://alexpl.fedorapeople.org/packages/Molsketch/molsketch.spec
SRPM URL:
https://alexpl.fedorapeople.org/packages/Molsketch/molsketch-0.5.1-4.fc28.src.rpm

koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=24376144

Something that changed since 0.5.1-2 build is disabling the extra features,
probably during the build phase, but I can't figure out what that might have
been.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536852] Review Request: molsketch - Molecular Structures Editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536852



--- Comment #3 from Antonio Trande  ---
- Error: 
 Problem: conflicting requests
  - nothing provides libmolsketch-qt5 needed by
molsketch-devel-0.5.1-3.fc28.x86_64

Remove 

'Requires: lib%{name}-qt5'

- 
>The OpenSUSE spec file also listed libqt5-qttools as a requirement for the 
>devel >package, but we don't have that in Fedora. Do you know what that is 
>about?

Use 'qt5-qttools-devel'.

- Diff spec file in url and in SRPM
-
--- /home/sagitter/1536852-molsketch/srpm/molsketch.spec2018-01-22
18:33:42.450467184 +0100
+++ /home/sagitter/1536852-molsketch/srpm-unpacked/molsketch.spec2018-01-22
13:12:35.0 +0100
@@ -130,5 +130,5 @@

 * Wed Nov 01 2017 Alexander Ploumistos  - 0.5.0-6
-- Fix post & postun scriptlets
+- Fix %post & %postun scriptlets

 * Wed Nov 01 2017 Alexander Ploumistos  - 0.5.0-5

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536852] Review Request: molsketch - Molecular Structures Editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536852



--- Comment #2 from Alexander Ploumistos  ---
Hello Antonio and thanks for taking this review request.


(In reply to Antonio Trande from comment #1)
> - Are you sure that 'qca' (or qca-qt5?) is required for building?

Not really and neither was upstream. I commented it out, didn't notice any
problems. The OpenSUSE spec file also listed libqt5-qttools as a requirement
for the devel package, but we don't have that in Fedora. Do you know what that
is about?


> - Make arch-specific the 'openbabel' explicit request:
> Requires:  openbabel%{?_isa}

Changed it, but why is that needed?


> - devel subpackage requires the main package (that contains libmolsketch.so):
> Requires: %{name}%{?_isa} = %{version}-%{release}

Fixed.


> - Remove that macros in comments or use %% for disabling them.

Did not know about the % escaping, did that.


> - Use %make_install in the %install section

Fixed.


> - Remove INSTALL as documentation

Removed.


> - %{_libdir}/lib*.so* installs unversioned libraries too. Change it with
>   %{_libdir}/lib*.so.*

Fixed. Can you point me to any good resource regarding versioned-unversioned
libraries?


> - Regarding your question on devel mailing list, there could be a problem
> with some architectures (like s390x) about how to set correctly the
> libraries directory.
> In particular, 
> 
> obabeliface/obabeliface.pro
> libmolsketch/libmolsketch.pro
> 
> contain a "DESTDIR = ../lib" line. To fix try to add the option
> ""MSK_INSTALL_LIBS=%{_libdir}" to qmake's line.

Thanks, it builds now.


> - Set MSK_INSTALL_INCLUDES to %{_includedir}/lib%{name}

I also changed

%files devel
%{_includedir}/%{name}

to

%files devel
%{_includedir}/lib%{name}

because the build failed complaining about a missing file.


> - /usr/share/icons/hicolor/scalable/mimetypes must not be owned by this
> package.

I declared both images in the %files section, perhaps I should just have gone a
level below %{_datadir}/icons/hicolor/scalable/ and used the wildcard there.


> - doc is a stand-alone package, it must provide an own license file.

Added.


> - Most files are licensed under GPLv2+ license; you can use it as License
> file i guess.

Changed to GPLv2+.


Spec URL: https://alexpl.fedorapeople.org/packages/Molsketch/molsketch.spec
SRPM URL:
https://alexpl.fedorapeople.org/packages/Molsketch/molsketch-0.5.1-3.fc28.src.rpm
koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=24370202


There is one serious regression now. When the program starts, I can see that it
is not using OpenBabel, in the bottom right corner it shows everything with a
minus (OpenBabel, InChI, gen2d). Can you tell where I've messed up?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536852] Review Request: molsketch - Molecular Structures Editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536852



--- Comment #1 from Antonio Trande  ---
- Are you sure that 'qca' (or qca-qt5?) is required for building?

- Make arch-specific the 'openbabel' explicit request:
Requires:  openbabel%{?_isa}

- devel subpackage requires the main package (that contains libmolsketch.so):
Requires: %{name}%{?_isa} = %{version}-%{release}

- Remove that macros in comments or use %% for disabling them.

- Use %make_install in the %install section

- Remove INSTALL as documentation

- %{_libdir}/lib*.so* installs unversioned libraries too. Change it with
  %{_libdir}/lib*.so.*

- Regarding your question on devel mailing list, there could be a problem with
some architectures (like s390x) about how to set correctly the libraries
directory.
In particular, 

obabeliface/obabeliface.pro
libmolsketch/libmolsketch.pro

contain a "DESTDIR = ../lib" line. To fix try to add the option
""MSK_INSTALL_LIBS=%{_libdir}" to qmake's line.

- Set MSK_INSTALL_INCLUDES to %{_includedir}/lib%{name}

- /usr/share/icons/hicolor/scalable/mimetypes must not be owned by this
package.

- doc is a stand-alone package, it must provide an own license file.

- Most files are licensed under GPLv2+ license; you can use it as License file
i guess.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://fedoraproject.org/wiki/Packaging:Guidelines
- Header files in -devel subpackage, if present.
  Note: molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/TextInputItem.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/abstractxmlobject.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/abstractitemaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/abstractrecursiveitemaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/alignmentaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/arrowtypeaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/arrowtypewidget.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/bondtypeaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/bondtypewidget.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/coloraction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/connectaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/deleteaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/drawaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/flipbondaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/flipstereobondsaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/frameaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/frametypeaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/frametypewidget.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/genericaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/incdecaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/itemgrouptypeaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/itemtypeaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/itemtypeselectionaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/itemtypewidget.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/linewidthaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/mechanismarrowaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/multiaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/periodictablewidget.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/reactionarrowaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/actions/ringaction.h
  

[Bug 1536852] Review Request: molsketch - Molecular Structures Editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536852

Antonio Trande  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||anto.tra...@gmail.com
   Assignee|nob...@fedoraproject.org|anto.tra...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org