[Bug 1544716] Review Request: golang-github-inconshreveable-go-vhost - HTTP/ TLS hostname multiplexing library for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1544716



--- Comment #11 from Jiri Kucera  ---
https://github.com/i386x/golang-github-inconshreveable-go-vhost/ no longer
exists, its content has been moved here:
https://github.com/i386x/files/tree/8ab83153b141069669966a0a2d6dc47b4a3d39f7/golang-github-inconshreveable-go-vhost/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/ZUG2OUG3XOFV56OVN7IR6VNPVNO27NFN/

[Bug 1544716] Review Request: golang-github-inconshreveable-go-vhost - HTTP/ TLS hostname multiplexing library for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1544716



--- Comment #10 from Fedora Update System  ---
golang-github-inconshreveable-go-vhost-0-0.1.20160627git06d8411.fc27 has been
pushed to the Fedora 27 stable repository. If problems still persist, please
make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1544716] Review Request: golang-github-inconshreveable-go-vhost - HTTP/ TLS hostname multiplexing library for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1544716

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2018-02-27 11:55:27



--- Comment #9 from Fedora Update System  ---
golang-github-inconshreveable-go-vhost-0-0.1.20160627git06d8411.fc26 has been
pushed to the Fedora 26 stable repository. If problems still persist, please
make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1544716] Review Request: golang-github-inconshreveable-go-vhost - HTTP/ TLS hostname multiplexing library for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1544716



--- Comment #8 from Fedora Update System  ---
golang-github-inconshreveable-go-vhost-0-0.1.20160627git06d8411.fc27 has been
pushed to the Fedora 27 testing repository. If problems still persist, please
make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-35d796c441

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1544716] Review Request: golang-github-inconshreveable-go-vhost - HTTP/ TLS hostname multiplexing library for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1544716

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #7 from Fedora Update System  ---
golang-github-inconshreveable-go-vhost-0-0.1.20160627git06d8411.fc26 has been
pushed to the Fedora 26 testing repository. If problems still persist, please
make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-569ccc30be

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1544716] Review Request: golang-github-inconshreveable-go-vhost - HTTP/ TLS hostname multiplexing library for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1544716



--- Comment #6 from Fedora Update System  ---
golang-github-inconshreveable-go-vhost-0-0.1.20160627git06d8411.fc26 has been
submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-569ccc30be

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1544716] Review Request: golang-github-inconshreveable-go-vhost - HTTP/ TLS hostname multiplexing library for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1544716



--- Comment #5 from Fedora Update System  ---
golang-github-inconshreveable-go-vhost-0-0.1.20160627git06d8411.fc27 has been
submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-35d796c441

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1544716] Review Request: golang-github-inconshreveable-go-vhost - HTTP/ TLS hostname multiplexing library for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1544716

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1544716] Review Request: golang-github-inconshreveable-go-vhost - HTTP/ TLS hostname multiplexing library for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1544716



--- Comment #4 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/golang-github-inconshreveable-go-vhost

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1544716] Review Request: golang-github-inconshreveable-go-vhost - HTTP/ TLS hostname multiplexing library for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1544716

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #3 from Robert-André Mauchin  ---
Package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1544716] Review Request: golang-github-inconshreveable-go-vhost - HTTP/ TLS hostname multiplexing library for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1544716



--- Comment #2 from Jiri Kucera  ---
Hello Robert,

thank You for Your review. I updated spec file and srpms, links are below.

Rawhide:
- SRPM:
https://github.com/i386x/golang-github-inconshreveable-go-vhost/raw/master/golang-github-inconshreveable-go-vhost-0-0.1.20160627git06d8411.fc28.src.rpm
- Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=25038195

F27:
- SRPM:
https://github.com/i386x/golang-github-inconshreveable-go-vhost/raw/master/golang-github-inconshreveable-go-vhost-0-0.1.20160627git06d8411.fc27.src.rpm
- Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=25038685

F26:
- SRPM:
https://github.com/i386x/golang-github-inconshreveable-go-vhost/raw/master/golang-github-inconshreveable-go-vhost-0-0.1.20160627git06d8411.fc26.src.rpm
- Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=25038881


Jirka

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1544716] Review Request: golang-github-inconshreveable-go-vhost - HTTP/ TLS hostname multiplexing library for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1544716

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review?



--- Comment #1 from Robert-André Mauchin  ---
> This is my first package, but I already have sponsor (I guess)

According to fas info, you are already a member of the packager group, so you
need no sponsor, you already can request repos and branches:

User: jkucera, Name: Jiri Kucera, email: jkuc...@redhat.com, Creation:
2017-10-16, IRC Nick: None, Timezone: UTC, Locale: en, GPG key ID: None,
Status: active
Approved Groups: fedorabugs packager cla_done cla_fpca


Now this package:

 - When packaging a development snapshot, you need to add the date of the
commit in the Release field. See
https://fedoraproject.org/wiki/Packaging:Versioning#Snapshots

%global commit  06d84117953b22058c096b49a429ebd4f3d3d97b
%global shortcommit %(c=%{commit}; echo ${c:0:7})
%global commitdate  20160627

Name:   golang-%{provider}-%{project}-%{repo}
Version:0
Release:0.1.%{commitdate}git%{shortcommit}%{?dist}

   And then in the %changelog:

* Mon Feb 12 2018 Jiri Kucera  - 0-0.1.20160627git06d8411

 - Please add a comment explaining why the patch is needed, optionally link to
an upstream bug report or PR. (I guess this is yours
https://github.com/inconshreveable/go-vhost/pull/7 Just add it as a comment so
you'll know when to remove the patch once it has been accepted upstream).


Everything else is okay


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Apache (v2.0)", "Unknown or generated". 10 files have unknown
 license. Detailed output of licensecheck in /home/bob/packaging/review
 /golang-github-inconshreveable-go-vhost/review-golang-github-
 inconshreveable-go-vhost/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/gocode/src,
 /usr/share/gocode, /usr/share/gocode/src/github.com
[x]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by:
 /usr/share/gocode/src/github.com/inconshreveable(golang-github-
 inconshreveable-mousetrap-devel, golang-github-inconshreveable-muxado-
 devel)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[!]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[-]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf