[Bug 1719008] Review Request: python-soupsieve - CSS selector library
https://bugzilla.redhat.com/show_bug.cgi?id=1719008 --- Comment #34 from Zbigniew Jędrzejewski-Szmek --- I see you also built soupsieve. Nice. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1719008] Review Request: python-soupsieve - CSS selector library
https://bugzilla.redhat.com/show_bug.cgi?id=1719008 --- Comment #33 from Miro Hrončok --- But not beyond all recognition: https://src.fedoraproject.org/rpms/python-soupsieve/c/8548ee4e3735cbd73c0b6aa63dc9626e7abbcd89?branch=master beautifulsoup4 built. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1719008] Review Request: python-soupsieve - CSS selector library
https://bugzilla.redhat.com/show_bug.cgi?id=1719008 --- Comment #32 from Zbigniew Jędrzejewski-Szmek --- We fucked this up. bs4 and soupsieve BR each other, so boostrap in f32-python doesn't work. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1719008] Review Request: python-soupsieve - CSS selector library
https://bugzilla.redhat.com/show_bug.cgi?id=1719008 --- Comment #31 from Terje Røsten --- bs4 4.8.0 in rawhide + f31 now. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1719008] Review Request: python-soupsieve - CSS selector library
https://bugzilla.redhat.com/show_bug.cgi?id=1719008 --- Comment #30 from Zbigniew Jędrzejewski-Szmek --- Terje, please update bs4. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1719008] Review Request: python-soupsieve - CSS selector library
https://bugzilla.redhat.com/show_bug.cgi?id=1719008 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added Status|POST|CLOSED Fixed In Version||python-soupsieve-1.9.2-1.fc ||31 Resolution|--- |RAWHIDE Last Closed||2019-08-19 20:36:14 --- Comment #29 from Zbigniew Jędrzejewski-Szmek --- Built in rawhide and branched. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1719008] Review Request: python-soupsieve - CSS selector library
https://bugzilla.redhat.com/show_bug.cgi?id=1719008 --- Comment #28 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-soupsieve -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1719008] Review Request: python-soupsieve - CSS selector library
https://bugzilla.redhat.com/show_bug.cgi?id=1719008 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added Status|ASSIGNED|POST --- Comment #27 from Zbigniew Jędrzejewski-Szmek --- Thanks! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1719008] Review Request: python-soupsieve - CSS selector library
https://bugzilla.redhat.com/show_bug.cgi?id=1719008
Miro Hrončok changed:
What|Removed |Added
Status|NEW |ASSIGNED
Assignee|nob...@fedoraproject.org|mhron...@redhat.com
Flags|fedora-review? |fedora-review+
--- Comment #26 from Miro Hrončok ---
Package Review
==
Package APPROVED.
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
Issues:
===
- Package must not depend on deprecated() packages.
Note: python2-devel is deprecated, you must not depend on it.
Exception granted via https://pagure.io/fesco/issue/2145
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "Expat License".
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[!]: Package meets the Packaging Guidelines::Python - Python 2 exception
granted
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
[?]: Package functions as described.
[?]: Latest version is packaged.
[-]: Package does not include license text files separate
[Bug 1719008] Review Request: python-soupsieve - CSS selector library
https://bugzilla.redhat.com/show_bug.cgi?id=1719008 --- Comment #25 from Zbigniew Jędrzejewski-Szmek --- Try 'sed -i s/30/32/g /etc/mock/fedora-rawhide-x86_64.cfg'. This worked here. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1719008] Review Request: python-soupsieve - CSS selector library
https://bugzilla.redhat.com/show_bug.cgi?id=1719008 --- Comment #24 from Miro Hrončok --- I won't be able to review this today. Among other things, my mock is broken after f31 branching. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1719008] Review Request: python-soupsieve - CSS selector library
https://bugzilla.redhat.com/show_bug.cgi?id=1719008 --- Comment #23 from Miro Hrončok --- Spec URL: https://in.waw.pl/~zbyszek/fedora/python-soupsieve.spec SRPM URL: https://in.waw.pl/~zbyszek/fedora/python-soupsieve-1.9.2-1.fc32.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1719008] Review Request: python-soupsieve - CSS selector library
https://bugzilla.redhat.com/show_bug.cgi?id=1719008 --- Comment #22 from Zbigniew Jędrzejewski-Szmek --- Updated in place with %bcond_with tests. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1719008] Review Request: python-soupsieve - CSS selector library
https://bugzilla.redhat.com/show_bug.cgi?id=1719008 --- Comment #21 from Miro Hrončok --- I don't like the || : in %check. Could you bcond tests out instead? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1719008] Review Request: python-soupsieve - CSS selector library
https://bugzilla.redhat.com/show_bug.cgi?id=1719008 --- Comment #20 from Zbigniew Jędrzejewski-Szmek --- Updated to latest version and with test results ignored: Spec URL: https://in.waw.pl/~zbyszek/fedora/python-soupsieve.spec SRPM URL: https://in.waw.pl/~zbyszek/fedora/python-soupsieve-1.9.2-1.fc31.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1719008] Review Request: python-soupsieve - CSS selector library
https://bugzilla.redhat.com/show_bug.cgi?id=1719008
--- Comment #19 from Zbigniew Jędrzejewski-Szmek ---
Terje, could you submit the change for bs4 as PR in pagure? Then we know we are
talking about the same thing ;)
When I try to build python-beautifulsoup4-4.8.0-1.fc31.src.rpm with
python2-soupsieve-1.9.2-1.fc32.noarch, python3-soupsieve-1.9.2-1.fc32.noarch
installed in rawhide mock, tests fail with:
==
FAIL: test_nested_namespaces (tests.test_lxml.LXMLXMLTreeBuilderSmokeTest)
--
Traceback (most recent call last):
File "bs4/testing.py", line 841, in test_nested_namespaces
self.assertEqual(doc, soup.encode())
AssertionError: '\nhttp://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd;>\nhttp://ns1/;>\nhttp://ns2/;
xmlns:ns3="http://ns3/;>\nhttp://ns4/"/>\n\n' != '\nhttp://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd;>\nhttp://ns1/;>\nhttp://ns2/;
xmlns:ns3="http://ns3/;>\nhttp://ns4/"/>\n\n'
==
FAIL: test_real_xhtml_document (tests.test_lxml.LXMLXMLTreeBuilderSmokeTest)
A real XHTML document should come out *exactly* the same as it went in.
--
Traceback (most recent call last):
File "bs4/testing.py", line 830, in test_real_xhtml_document
soup.encode("utf-8"), markup)
AssertionError: '\n\nhttp://www.w3.org/1999/xhtml;>\nHello.\nGoodbye.\n'
!= '\n\nhttp://www.w3.org/1999/xhtml;>\nHello.\nGoodbye.\n'
--
And the failure seems valid:
>>> print(s1)
http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd;>
http://ns1/;>
http://ns2/; xmlns:ns3="http://ns3/;>
http://ns4/"/>
>>> print(s2)
http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd;>
http://ns1/;>
http://ns2/; xmlns:ns3="http://ns3/;>
http://ns4/"/>
Note the xmlns:="..." assignments.
That said, I think we should build python-soupsieve in rawhide, i.e. do the
step 1. from the list in previous comment.
@Miro, could you approve the package? We'll figure out the test failures later.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1719008] Review Request: python-soupsieve - CSS selector library
https://bugzilla.redhat.com/show_bug.cgi?id=1719008 Terje Røsten changed: What|Removed |Added Blocks||1742146 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1742146 [Bug 1742146] python-beautifulsoup4-4.8.0 is available -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1719008] Review Request: python-soupsieve - CSS selector library
https://bugzilla.redhat.com/show_bug.cgi?id=1719008 Terje Røsten changed: What|Removed |Added CC||terje...@phys.ntnu.no --- Comment #18 from Terje Røsten --- hi guys! I have tested the beautifulsoup4 4.8.0 and python-soupsieve to 1.9.3 combo, it works fine with all tests enabled. The problem is that beautifulsoup4 > 4.7.0 needs python-soupsieve. I suggest these actions: 1 - approve package and then import soupsieve with tests disabled (or error ignored), please push to fedora 31 too. 2 - ping me, I then upgrade beautifulsoup4 to 4.8.0 in rawhide and f31. 3 - rebuild soupsieve with tests enabled. ok? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1719008] Review Request: python-soupsieve - CSS selector library
https://bugzilla.redhat.com/show_bug.cgi?id=1719008
--- Comment #17 from Miro Hrončok ---
BTW python-beautifulsoup4 is failing with:
BUILDSTDERR:
==
BUILDSTDERR: FAIL: test_nested_namespaces
(tests.test_lxml.LXMLXMLTreeBuilderSmokeTest)
BUILDSTDERR:
--
BUILDSTDERR: Traceback (most recent call last):
BUILDSTDERR: File "bs4/testing.py", line 665, in test_nested_namespaces
BUILDSTDERR: self.assertEqual(doc, soup.encode())
BUILDSTDERR: AssertionError: '\nhttp://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd;>\nhttp://ns1/;>\nhttp://ns2/;
xmlns:ns3="http://ns3/;>\nhttp://ns4/"/>\n\n' != '\nhttp://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd;>\nhttp://ns1/;>\nhttp://ns2/;
xmlns:ns3="http://ns3/;>\nhttp://ns4/"/>\n\n'
BUILDSTDERR:
==
BUILDSTDERR: FAIL: test_real_xhtml_document
(tests.test_lxml.LXMLXMLTreeBuilderSmokeTest)
BUILDSTDERR: A real XHTML document should come out *exactly* the same as it
went in.
BUILDSTDERR:
--
BUILDSTDERR: Traceback (most recent call last):
BUILDSTDERR: File "bs4/testing.py", line 654, in test_real_xhtml_document
BUILDSTDERR: soup.encode("utf-8"), markup)
BUILDSTDERR: AssertionError: '\n\nhttp://www.w3.org/1999/xhtml;>\nHello.\nGoodbye.\n'
!= '\n\nhttp://www.w3.org/1999/xhtml;>\nHello.\nGoodbye.\n'
BUILDSTDERR:
--
BUILDSTDERR: Ran 476 tests in 2.288s
BUILDSTDERR: FAILED (failures=2)
BUILDSTDERR: error: Bad exit status from /var/tmp/rpm-tmp.fHaY2V (%check)
BUILDSTDERR: Bad exit status from /var/tmp/rpm-tmp.fHaY2V (%check)
Since lxml 4.4 https://apps.fedoraproject.org/koschei/build/6778909
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1719008] Review Request: python-soupsieve - CSS selector library
https://bugzilla.redhat.com/show_bug.cgi?id=1719008 --- Comment #16 from Zbigniew Jędrzejewski-Szmek --- I'm don't know who is "you" here. I started looking into those errors, but I didn't find any obvious solution. I'll return to it once I'm back from vacation. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1719008] Review Request: python-soupsieve - CSS selector library
https://bugzilla.redhat.com/show_bug.cgi?id=1719008 --- Comment #15 from Kevin Fenzi --- To be clear, those test failures happen to this package now on rawhide... can you fix them up? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1719008] Review Request: python-soupsieve - CSS selector library
https://bugzilla.redhat.com/show_bug.cgi?id=1719008
--- Comment #14 from Miro Hrončok ---
=== FAILURES
===
TestDefined.test_defined_xhtml
self =
def test_defined_xhtml(self):
"""Test defined XHTML."""
markup = """
http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd;>
http://www.w3.org/1999/xhtml;>
"""
self.assert_selector(
markup,
'body :defined',
['0', '2'], # We should get 3, but we don't for reasons stated
above.
> flags=util.XHTML
)
tests/test_level4/test_defined.py:63:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
tests/util.py:142: in assert_selector
self.assertEqual(sorted(ids), sorted(expected_ids))
E AssertionError: Lists differ: [u'0', u'1', u'2'] != [u'0', u'2']
E
E First differing element 1:
E u'1'
E u'2'
E
E First list contains 1 additional elements.
E First extra element 2:
E u'2'
E
E - [u'0', u'1', u'2']
E ?--
E
E + [u'0', u'2']
- Captured stdout call
-
Running Selector Test
(u'PATTERN: ', u'body :defined')
## PARSING: u'body :defined'
TOKEN: 'tag' --> u'body' at position 0
TOKEN: 'combine' --> u' ' at position 4
TOKEN: 'pseudo_class' --> u':defined' at position 5
## END PARSING
(u'\nPARSER: ', u'xml')
(u'TAG: ', 'div')
(u'TAG: ', 'div-custom')
(u'TAG: ', 'div')
_ TestDefinedQuirks.test_defined_xhtml
_
self =
def test_defined_xhtml(self):
"""Test defined XHTML."""
markup = """
http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd;>
http://www.w3.org/1999/xhtml;>
"""
self.assert_selector(
markup,
'body :defined',
['0', '2'], # We should get 3, but we don't for reasons stated
above.
> flags=util.XHTML
)
tests/test_level4/test_defined.py:63:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
tests/util.py:142: in assert_selector
self.assertEqual(sorted(ids), sorted(expected_ids))
E AssertionError: Lists differ: [u'0', u'1', u'2'] != [u'0', u'2']
E
E First differing element 1:
E u'1'
E u'2'
E
E First list contains 1 additional elements.
E First extra element 2:
E u'2'
E
E - [u'0', u'1', u'2']
E ?--
E
E + [u'0', u'2']
- Captured stdout call
-
Running Selector Test
(u'PATTERN: ', u'body :defined')
## QUIRKS MODE: Throwing out the spec!
## PARSING: u'body :defined'
TOKEN: 'tag' --> u'body' at position 0
TOKEN: 'combine' --> u' ' at position 4
TOKEN: 'pseudo_class' --> u':defined' at position 5
## END PARSING
(u'\nPARSER: ', u'xml')
(u'TAG: ', 'div')
(u'TAG: ', 'div-custom')
(u'TAG: ', 'div')
=== warnings summary
===
tests/test_api.py::TestSoupSieve::test_comments
/builddir/build/BUILD/soupsieve-1.9.1/tests/test_api.py:37:
DeprecationWarning: 'comments' is deprecated. 'comments' is not related to CSS
selectors and will be removed in the future.
comments = [sv_util.ustr(c).strip() for c in sv.comments(soup)]
tests/test_api.py::TestSoupSieve::test_compiled_comments
/builddir/build/BUILD/soupsieve-1.9.1/tests/test_api.py:88:
DeprecationWarning: 'comments' is deprecated. 'comments' is not related to CSS
selectors and will be removed in the future.
comments = [sv_util.ustr(c).strip() for c in pattern.comments(soup)]
tests/test_api.py::TestSoupSieve::test_compiled_icomments
/builddir/build/BUILD/soupsieve-1.9.1/tests/test_api.py:113:
DeprecationWarning: 'icomments' is deprecated. 'icomments' is not related to
CSS selectors and will be removed in the future.
comments = [sv_util.ustr(c).strip() for c in pattern.icomments(soup,
limit=2)]
tests/test_api.py::TestSoupSieve::test_icomments
/builddir/build/BUILD/soupsieve-1.9.1/tests/test_api.py:61:
DeprecationWarning: 'icomments' is deprecated. 'icomments' is not related to
CSS selectors and will be removed in the future.
comments = [sv_util.ustr(c).strip() for c in sv.icomments(soup, limit=2)]
tests/test_api.py::TestInvalid::test_invalid_type_input_comments
tests/test_api.py::TestInvalidQuirks::test_invalid_type_input_comments
/builddir/build/BUILD/soupsieve-1.9.1/tests/test_api.py:704:
DeprecationWarning: 'comments' is deprecated. 'comments' is not related to CSS
selectors and will be removed in the future.
sv.comments('div', "not a tag", flags=flags)
-- Docs: https://docs.pytest.org/en/latest/warnings.html
== 2 failed, 645 passed,
[Bug 1719008] Review Request: python-soupsieve - CSS selector library
https://bugzilla.redhat.com/show_bug.cgi?id=1719008 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added Status|ASSIGNED|NEW Assignee|m...@fabian-affolter.ch |nob...@fedoraproject.org Flags|needinfo?(mail@fabian-affol | |ter.ch) | --- Comment #13 from Zbigniew Jędrzejewski-Szmek --- I'm resetting the assignee because of lack of response. If somebody else could pick up the review that'd be great. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1719008] Review Request: python-soupsieve - CSS selector library
https://bugzilla.redhat.com/show_bug.cgi?id=1719008 --- Comment #12 from Zbigniew Jędrzejewski-Szmek --- Ping. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1719008] Review Request: python-soupsieve - CSS selector library
https://bugzilla.redhat.com/show_bug.cgi?id=1719008 --- Comment #11 from Zbigniew Jędrzejewski-Szmek --- Ping. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1719008] Review Request: python-soupsieve - CSS selector library
https://bugzilla.redhat.com/show_bug.cgi?id=1719008 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added Flags||needinfo?(mail@fabian-affol ||ter.ch) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1719008] Review Request: python-soupsieve - CSS selector library
https://bugzilla.redhat.com/show_bug.cgi?id=1719008 --- Comment #10 from Zbigniew Jędrzejewski-Szmek --- Fesco exception was granted, please approve. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1719008] Review Request: python-soupsieve - CSS selector library
https://bugzilla.redhat.com/show_bug.cgi?id=1719008 Kevin Fenzi changed: What|Removed |Added CC||ke...@scrye.com --- Comment #9 from Kevin Fenzi --- Any news here? it's holding up new calibre... :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1719008] Review Request: python-soupsieve - CSS selector library
https://bugzilla.redhat.com/show_bug.cgi?id=1719008 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added Status|POST|ASSIGNED --- Comment #8 from Zbigniew Jędrzejewski-Szmek --- Nvm, I see the review is not approved yet. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1719008] Review Request: python-soupsieve - CSS selector library
https://bugzilla.redhat.com/show_bug.cgi?id=1719008 --- Comment #7 from Zbigniew Jędrzejewski-Szmek --- Still waiting for the FESCo ticket to be resolved. I'll ask for the repo to be created, but I won't import. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1719008] Review Request: python-soupsieve - CSS selector library
https://bugzilla.redhat.com/show_bug.cgi?id=1719008 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added Status|NEW |POST -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1719008] Review Request: python-soupsieve - CSS selector library
https://bugzilla.redhat.com/show_bug.cgi?id=1719008 --- Comment #6 from Miro Hrončok --- As another note, please make the tests bcondable, to allow bootstrapping (such as when Python is updated). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1719008] Review Request: python-soupsieve - CSS selector library
https://bugzilla.redhat.com/show_bug.cgi?id=1719008 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added Blocks||1667497 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1667497 [Bug 1667497] calibre-3.44.0 is available -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1719008] Review Request: python-soupsieve - CSS selector library
https://bugzilla.redhat.com/show_bug.cgi?id=1719008 --- Comment #5 from Zbigniew Jędrzejewski-Szmek --- https://pagure.io/fesco/issue/2145 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1719008] Review Request: python-soupsieve - CSS selector library
https://bugzilla.redhat.com/show_bug.cgi?id=1719008
Zbigniew Jędrzejewski-Szmek changed:
What|Removed |Added
Status|ASSIGNED|NEW
--- Comment #4 from Zbigniew Jędrzejewski-Szmek ---
Thanks for the quick review!
> Move the BuildRequires for Python 3 to the %package for Python3 section
I kept them at the top on purpose. I assume that the python2 part will go away
soon, and
then all BRs will be at the top.
> Source0
Updated to
https://github.com/facelessuser/soupsieve/archive/%{version}/%{name}-%{version}.tar.gz.
I pushed an updated srpm/spec with just this change:
Spec URL: https://in.waw.pl/~zbyszek/fedora/python-soupsieve.spec
SRPM URL:
https://in.waw.pl/~zbyszek/fedora/python-soupsieve-1.9.1-1.fc31.src.rpm
So... I need the python2 subpackage for bs4. A bunch of other packages depened
on python2-bs4:
$ dnf repoquery --release=31 --whatrequires python2-beautifulsoup4
mote-0:0.6.2-10.fc30.noarch
packagedb-cli-0:2.14.1-9.fc30.noarch
python2-fedora-0:0.10.0-8.fc30.noarch
python2-fmn-lib-0:0.8.2-8.fc29.noarch
python2-webtest-0:2.0.30-3.fc30.noarch
$ dnf repoquery --disablerepo=\* --enablerepo=rawhide-source --arch=src
--whatrequires python2-beautifulsoup4
chromium-0:73.0.3683.103-1.fc31.src
mote-0:0.6.2-10.fc30.src
python-fmn-lib-0:0.8.2-8.fc29.src
python-html5-parser-0:0.4.6-1.fc31.src
python-webtest-0:2.0.30-3.fc30.src
It seems like not including the python2 subpackage will make the bs4 upgrade
very hard.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1719008] Review Request: python-soupsieve - CSS selector library
https://bugzilla.redhat.com/show_bug.cgi?id=1719008 Miro Hrončok changed: What|Removed |Added CC||mhron...@redhat.com --- Comment #3 from Miro Hrončok --- You need a FESCo exception if you really need python2-soupsieve. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1719008] Review Request: python-soupsieve - CSS selector library
https://bugzilla.redhat.com/show_bug.cgi?id=1719008
Fabian Affolter changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||m...@fabian-affolter.ch
Assignee|nob...@fedoraproject.org|m...@fabian-affolter.ch
Flags||fedora-review?
--- Comment #2 from Fabian Affolter ---
It looks like that you don't want to build the package for EPEL. If that's the
case then remove the support for Python 2.
- Package must not depend on deprecated() packages.
Note: python2-devel is deprecated, you must not depend on it.
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/deprecating-packages/
- Move the BuildRequires for Python 3 to the %package for Python3 section
- Replace the Source0 with
Source0:
https://github.com/facelessuser/soupsieve/archive/%{version}.tar.gz#/%{name}-%{version}.tar.gz
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "Expat License". 123 files have unknown
license. Detailed output of licensecheck in
/home/fab/Documents/repos/reviews/1719008-python-
soupsieve/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with
[Bug 1719008] Review Request: python-soupsieve - CSS selector library
https://bugzilla.redhat.com/show_bug.cgi?id=1719008 --- Comment #1 from Zbigniew Jędrzejewski-Szmek --- See also https://src.fedoraproject.org/rpms/python-beautifulsoup4/pull-request/3. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
