[Bug 1798811] Review Request: waybar - Highly customizable Wayland bar for Sway and Wlroots based compositors
https://bugzilla.redhat.com/show_bug.cgi?id=1798811 --- Comment #9 from Fedora Update System --- date-2.4.1-1.20200207git9a0ee25.fc31, waybar-0.9.1-1.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1798811] Review Request: waybar - Highly customizable Wayland bar for Sway and Wlroots based compositors
https://bugzilla.redhat.com/show_bug.cgi?id=1798811 --- Comment #8 from Fedora Update System --- date-2.4.1-1.20200207git9a0ee25.fc31, waybar-0.9.1-1.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-7371874e98 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1798811] Review Request: waybar - Highly customizable Wayland bar for Sway and Wlroots based compositors
https://bugzilla.redhat.com/show_bug.cgi?id=1798811 --- Comment #7 from Fedora Update System --- FEDORA-2020-7371874e98 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-7371874e98 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1798811] Review Request: waybar - Highly customizable Wayland bar for Sway and Wlroots based compositors
https://bugzilla.redhat.com/show_bug.cgi?id=1798811 Aleksei Bavshin changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-02-09 22:46:13 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1798811] Review Request: waybar - Highly customizable Wayland bar for Sway and Wlroots based compositors
https://bugzilla.redhat.com/show_bug.cgi?id=1798811 --- Comment #6 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/waybar -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1798811] Review Request: waybar - Highly customizable Wayland bar for Sway and Wlroots based compositors
https://bugzilla.redhat.com/show_bug.cgi?id=1798811
Till Hofmann changed:
What|Removed |Added
Blocks|177841 (FE-NEEDSPONSOR) |
Flags|fedora-review? |fedora-review+
--- Comment #5 from Till Hofmann ---
Looks good, approved!
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[?]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
justified.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[Bug 1798811] Review Request: waybar - Highly customizable Wayland bar for Sway and Wlroots based compositors
https://bugzilla.redhat.com/show_bug.cgi?id=1798811 --- Comment #4 from Aleksei Bavshin --- waybar could be started from sway-bar(5) swaybar_command or with `exec`. Systemd user service is not really necessary for that case, so I'm removing it for now. It might become a problem in a future, once I fix everything required for StatusNotifierItem tray dbus activation and add dbus service. Hopefully we'll figure out how to mix sway and systemd user services by that moment. Updated package: Spec URL: https://copr-be.cloud.fedoraproject.org/results/alebastr/waybar/srpm-builds/01224084/waybar.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/alebastr/waybar/srpm-builds/01224084/waybar-0.9.0-4.fc31.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1798811] Review Request: waybar - Highly customizable Wayland bar for Sway and Wlroots based compositors
https://bugzilla.redhat.com/show_bug.cgi?id=1798811 --- Comment #3 from Till Hofmann --- Thanks Jan for having a look at the package already. For the user service preset, can you please add a comment and a link to the F32 change to the spec. This makes it obvious what's going on and is also a reminder to remove the preset once the change is accepted. Is it possible to start waybar simply with something like `exec waybar`? If so, you could also remove the service all together until a proper solution was found. You should probably not include a service that does not work as expected. Other than that, the SPEC looks nice and clean! Running fedora-review also didn't show any obvious problems. I'll follow up with a formal review once the above issues are addressed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1798811] Review Request: waybar - Highly customizable Wayland bar for Sway and Wlroots based compositors
https://bugzilla.redhat.com/show_bug.cgi?id=1798811
--- Comment #2 from Aleksei Bavshin ---
(In reply to Jan Staněk from comment #1)
> With github, there is no need to use the #-renaming trick for tarballs.
> Prefer `SourceN: %{url}/archive/%{version}/%{name}-%{version}.tar.gz`.
> https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_git_hosting_services
Noted, will be changed in next update.
> Maybe I'm missing something, but any service in Fedora is not enabled by
> default;
Unfortunately user sevices are enabled by default. There's no global preset,
however there's a plan to add it in f32:
https://fedoraproject.org/wiki/Changes/Systemd_presets_for_user_units
I'm tracking that effort and will add proper conditionals once the change lands
into fedora-release for f32.
You are right though, I need to update a comment with a reference to that
change.
> Also, the unit file presumes the existence of a wayland-session.target,
> which we do not have in Fedora at the moment – so enabling the service would
> not have the desired effect of starting the service at login (as far as I
> can tell). I'm not sure what should be done with that.
I'll check that.
One thing I found with mako and redshift is that WantedBy=default.target starts
services too early and does not get environment from sway. Right now I'm using
custom sway-session.target and starting it from sway config as `exec 'systemctl
--user import-environment; systemctl --user start sway-session.target'`, but
that doesn't seem to be upstreamable.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1798811] Review Request: waybar - Highly customizable Wayland bar for Sway and Wlroots based compositors
https://bugzilla.redhat.com/show_bug.cgi?id=1798811
Jan Staněk changed:
What|Removed |Added
CC||jsta...@redhat.com
--- Comment #1 from Jan Staněk ---
Not a proper review, just my 2 cents:
> Source0:%{url}/archive/%{version}.tar.gz#/%{name}-%{version}.tar.gz
With github, there is no need to use the #-renaming trick for tarballs.
Prefer `SourceN: %{url}/archive/%{version}/%{name}-%{version}.tar.gz`.
https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_git_hosting_services
> # disable systemd user service by default
Maybe I'm missing something, but any service in Fedora is not enabled by
default; AFAIK you need a preset file only if you want to enable it without
user interaction. Unless you have a compelling reason (in which case I would
appreciate a comment in the spec file) to ship the preset, just get rid of it
entirely.
Also, the unit file presumes the existence of a wayland-session.target, which
we do not have in Fedora at the moment – so enabling the service would not have
the desired effect of starting the service at login (as far as I can tell). I'm
not sure what should be done with that.
---
Other than that, it looks good at a glance; thank you for the effort in
preparing the package.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1798811] Review Request: waybar - Highly customizable Wayland bar for Sway and Wlroots based compositors
https://bugzilla.redhat.com/show_bug.cgi?id=1798811 Till Hofmann changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1798811] Review Request: waybar - Highly customizable Wayland bar for Sway and Wlroots based compositors
https://bugzilla.redhat.com/show_bug.cgi?id=1798811 Till Hofmann changed: What|Removed |Added Status|NEW |ASSIGNED CC||sway-sig@lists.fedoraprojec ||t.org -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1798811] Review Request: waybar - Highly customizable Wayland bar for Sway and Wlroots based compositors
https://bugzilla.redhat.com/show_bug.cgi?id=1798811 Till Hofmann changed: What|Removed |Added CC||thofm...@fedoraproject.org Assignee|nob...@fedoraproject.org|thofm...@fedoraproject.org Doc Type|--- |If docs needed, set a value -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1798811] Review Request: waybar - Highly customizable Wayland bar for Sway and Wlroots based compositors
https://bugzilla.redhat.com/show_bug.cgi?id=1798811 Aleksei Bavshin changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
