[Bug 1808571] Review Request: python-cclib - Parsers for output files of computational chemistry packages
https://bugzilla.redhat.com/show_bug.cgi?id=1808571 Mattia Verga changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2021-07-18 14:27:16 --- Comment #13 from Mattia Verga --- Package is in repos -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1808571] Review Request: python-cclib - Parsers for output files of computational chemistry packages
https://bugzilla.redhat.com/show_bug.cgi?id=1808571 Bug 1808571 depends on bug 1808573, which changed state. Bug 1808573 Summary: Review Request: python-periodictable - Extensible periodic table of the elements https://bugzilla.redhat.com/show_bug.cgi?id=1808573 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1808571] Review Request: python-cclib - Parsers for output files of computational chemistry packages
https://bugzilla.redhat.com/show_bug.cgi?id=1808571 Mukundan Ragavan changed: What|Removed |Added Status|ASSIGNED|POST -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1808571] Review Request: python-cclib - Parsers for output files of computational chemistry packages
https://bugzilla.redhat.com/show_bug.cgi?id=1808571 Mukundan Ragavan changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #12 from Mukundan Ragavan --- I have no complaints. Package approved. Please proceed with unretirement process. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1808571] Review Request: python-cclib - Parsers for output files of computational chemistry packages
https://bugzilla.redhat.com/show_bug.cgi?id=1808571
--- Comment #11 from Mukundan Ragavan ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package does not use a name that already exists.
Note: A package with this name already exists. Please check
https://src.fedoraproject.org/rpms/python-cclib
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/Naming/#_conflicting_package_names
---> Well, this review is for unretiring. All good here.
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "BSD 3-clause "New" or "Revised"
License", "BSD (unspecified)", "GNU Lesser General Public License",
"GNU Lesser General Public License (v2.1)". 985 files have unknown
license. Detailed output of licensecheck in
/home/mukundan/nextcloud/open_source_contrib/pkg_reviews/1808571-python-
cclib/licensecheck.txt
[x]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
---> BSD and LGPLv2
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package
[Bug 1808571] Review Request: python-cclib - Parsers for output files of computational chemistry packages
https://bugzilla.redhat.com/show_bug.cgi?id=1808571 --- Comment #10 from Antonio T. (sagitter) --- (In reply to Antonio T. (sagitter) from comment #9) > Spec URL: https://sagitter.fedorapeople.org/python-cclib/python-cclib.spec > SRPM URL: > https://sagitter.fedorapeople.org/python-cclib/python-cclib-1.6.2-1.fc31.src. > rpm > > - Remove shabangs from scripts > - Add PyQt4 and vtk runtime dependencies Spec URL: https://sagitter.fedorapeople.org/python-cclib/python-cclib.spec SRPM URL: https://sagitter.fedorapeople.org/python-cclib/python-cclib-1.6.2-2.fc31.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1808571] Review Request: python-cclib - Parsers for output files of computational chemistry packages
https://bugzilla.redhat.com/show_bug.cgi?id=1808571 --- Comment #9 from Antonio T. (sagitter) --- Spec URL: https://sagitter.fedorapeople.org/python-cclib/python-cclib.spec SRPM URL: https://sagitter.fedorapeople.org/python-cclib/python-cclib-1.6.2-1.fc31.src.rpm - Remove shabangs from scripts - Add PyQt4 and vtk runtime dependencies -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1808571] Review Request: python-cclib - Parsers for output files of computational chemistry packages
https://bugzilla.redhat.com/show_bug.cgi?id=1808571 --- Comment #8 from Mukundan Ragavan --- See here for the old package - https://src.fedoraproject.org/rpms/python-cclib -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1808571] Review Request: python-cclib - Parsers for output files of computational chemistry packages
https://bugzilla.redhat.com/show_bug.cgi?id=1808571
Susi Lehtola changed:
What|Removed |Added
CC||susi.leht...@iki.fi
--- Comment #7 from Susi Lehtola ---
(In reply to Antonio T. (sagitter) from comment #6)
> (In reply to Miro Hrončok from comment #5)
> > Regarding:
> >
> > pathfix.py -pn -i "%{__python3}"
> > %{buildroot}%{python3_sitelib}/cclib/scripts/ccframe.py
> > pathfix.py -pn -i "%{__python3}"
> > %{buildroot}%{python3_sitelib}/cclib/scripts/ccget.py
> > pathfix.py -pn -i "%{__python3}"
> > %{buildroot}%{python3_sitelib}/cclib/scripts/ccwrite.py
> > pathfix.py -pn -i "%{__python3}"
> > %{buildroot}%{python3_sitelib}/cclib/scripts/cda.py
> >
> > chmod a+x %{buildroot}%{python3_sitelib}/cclib/scripts/ccframe.py
> > chmod a+x %{buildroot}%{python3_sitelib}/cclib/scripts/ccget.py
> > chmod a+x %{buildroot}%{python3_sitelib}/cclib/scripts/ccwrite.py
> > chmod a+x %{buildroot}%{python3_sitelib}/cclib/scripts/cda.py
> >
> > Wouldn't it be better to drop the shebangs entirely? Or are the users of
> > this package expected to execute those files directly?
>
> Shebangs were already there in the form `#!/usr/bin/env python`
But they can be removed altogether since these files are in the Python library
directory. The shebangs only matter in the case where the user would run these
directly i.e. run
$ /usr/lib64/python3.7/site-packages/cclib/scripts/ccget.py
The files are not in the PATH so the shebangs can be dropped.
Also, since this is an unretirement procedure, please rebase your spec using
the old one and see that you inherit all of its fixes to various issues.
Usually one also keeps the old changelog.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1808571] Review Request: python-cclib - Parsers for output files of computational chemistry packages
https://bugzilla.redhat.com/show_bug.cgi?id=1808571
--- Comment #6 from Antonio T. (sagitter) ---
(In reply to Miro Hrončok from comment #5)
> > Successfully tested with Python-3.9
>
> Thanks for testing this.
>
>
> Regarding:
>
> pathfix.py -pn -i "%{__python3}"
> %{buildroot}%{python3_sitelib}/cclib/scripts/ccframe.py
> pathfix.py -pn -i "%{__python3}"
> %{buildroot}%{python3_sitelib}/cclib/scripts/ccget.py
> pathfix.py -pn -i "%{__python3}"
> %{buildroot}%{python3_sitelib}/cclib/scripts/ccwrite.py
> pathfix.py -pn -i "%{__python3}"
> %{buildroot}%{python3_sitelib}/cclib/scripts/cda.py
>
> chmod a+x %{buildroot}%{python3_sitelib}/cclib/scripts/ccframe.py
> chmod a+x %{buildroot}%{python3_sitelib}/cclib/scripts/ccget.py
> chmod a+x %{buildroot}%{python3_sitelib}/cclib/scripts/ccwrite.py
> chmod a+x %{buildroot}%{python3_sitelib}/cclib/scripts/cda.py
>
>
> Wouldn't it be better to drop the shebangs entirely? Or are the users of
> this package expected to execute those files directly?
Shebangs were already there in the form `#!/usr/bin/env python`
>
>
>
> > %global with_check 1
>
> Consider using a %bcond?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1808571] Review Request: python-cclib - Parsers for output files of computational chemistry packages
https://bugzilla.redhat.com/show_bug.cgi?id=1808571
Miro Hrončok changed:
What|Removed |Added
CC||mhron...@redhat.com
--- Comment #5 from Miro Hrončok ---
> Successfully tested with Python-3.9
Thanks for testing this.
Regarding:
pathfix.py -pn -i "%{__python3}"
%{buildroot}%{python3_sitelib}/cclib/scripts/ccframe.py
pathfix.py -pn -i "%{__python3}"
%{buildroot}%{python3_sitelib}/cclib/scripts/ccget.py
pathfix.py -pn -i "%{__python3}"
%{buildroot}%{python3_sitelib}/cclib/scripts/ccwrite.py
pathfix.py -pn -i "%{__python3}"
%{buildroot}%{python3_sitelib}/cclib/scripts/cda.py
chmod a+x %{buildroot}%{python3_sitelib}/cclib/scripts/ccframe.py
chmod a+x %{buildroot}%{python3_sitelib}/cclib/scripts/ccget.py
chmod a+x %{buildroot}%{python3_sitelib}/cclib/scripts/ccwrite.py
chmod a+x %{buildroot}%{python3_sitelib}/cclib/scripts/cda.py
Wouldn't it be better to drop the shebangs entirely? Or are the users of this
package expected to execute those files directly?
> %global with_check 1
Consider using a %bcond?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1808571] Review Request: python-cclib - Parsers for output files of computational chemistry packages
https://bugzilla.redhat.com/show_bug.cgi?id=1808571 --- Comment #4 from Antonio T. (sagitter) --- (In reply to Mukundan Ragavan from comment #3) > We had python-cclib in fedora. You are essentially unretiring this package, > correct? I did not know that it already was in Fedora, so yes i wish to claim this package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1808571] Review Request: python-cclib - Parsers for output files of computational chemistry packages
https://bugzilla.redhat.com/show_bug.cgi?id=1808571 --- Comment #3 from Mukundan Ragavan --- We had python-cclib in fedora. You are essentially unretiring this package, correct? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1808571] Review Request: python-cclib - Parsers for output files of computational chemistry packages
https://bugzilla.redhat.com/show_bug.cgi?id=1808571 Mukundan Ragavan changed: What|Removed |Added Status|NEW |ASSIGNED CC||nonamed...@gmail.com Assignee|nob...@fedoraproject.org|nonamed...@gmail.com Flags||fedora-review? --- Comment #2 from Mukundan Ragavan --- I will take this. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1808571] Review Request: python-cclib - Parsers for output files of computational chemistry packages
https://bugzilla.redhat.com/show_bug.cgi?id=1808571 Antonio T. (sagitter) changed: What|Removed |Added Doc Type|--- |If docs needed, set a value Whiteboard||Python-3.9 OK --- Comment #1 from Antonio T. (sagitter) --- Successfully tested with Python-3.9 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1808571] Review Request: python-cclib - Parsers for output files of computational chemistry packages
https://bugzilla.redhat.com/show_bug.cgi?id=1808571 Antonio T. (sagitter) changed: What|Removed |Added Depends On||1808573 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1808573 [Bug 1808573] Review Request: python-periodictable - Extensible periodic table of the elements -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
