[Bug 1827880] Review Request: fswatch - A cross-platform file change monitor
https://bugzilla.redhat.com/show_bug.cgi?id=1827880 Darryl T. Agostinelli changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2020-06-05 03:31:33 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1827880] Review Request: fswatch - A cross-platform file change monitor
https://bugzilla.redhat.com/show_bug.cgi?id=1827880 --- Comment #12 from Igor Raits --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/fswatch -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1827880] Review Request: fswatch - A cross-platform file change monitor
https://bugzilla.redhat.com/show_bug.cgi?id=1827880 --- Comment #11 from Darryl T. Agostinelli --- repo requested: https://pagure.io/releng/fedora-scm-requests/issue/25250 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1827880] Review Request: fswatch - A cross-platform file change monitor
https://bugzilla.redhat.com/show_bug.cgi?id=1827880 --- Comment #10 from Darryl T. Agostinelli --- Whoop! Whoop! Thx. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1827880] Review Request: fswatch - A cross-platform file change monitor
https://bugzilla.redhat.com/show_bug.cgi?id=1827880 Fabian Affolter changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #9 from Fabian Affolter --- Issues were addressed, packaged APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1827880] Review Request: fswatch - A cross-platform file change monitor
https://bugzilla.redhat.com/show_bug.cgi?id=1827880 --- Comment #8 from Darryl T. Agostinelli --- Spec URL: https://raw.githubusercontent.com/dagostinelli/fswatch-packaging/master/fswatch.spec SRPM URL: https://github.com/dagostinelli/fswatch-packaging/raw/master/fswatch-1.14.0-3.fc32.src.rpm - License tag - fixed "GPLv3+" - defattr - removed - The man page -- Upstream and I had a conversation about that. It should be in man1, not man 7. Upstream wants to move it, but hasn't gotten around to it yet. In a future release he will publish an official version with it in man1. Until then, I'm moving it like this. The convo was in private email. Ready for your review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1827880] Review Request: fswatch - A cross-platform file change monitor
https://bugzilla.redhat.com/show_bug.cgi?id=1827880 --- Comment #7 from Fabian Affolter --- (In reply to Darryl T. Agostinelli from comment #4) > During package review? I know we do this once it's checked into > https://src.fedoraproject.org/ > > I made the change as requested. How should the reviewer be able to keep track of the changes otherwise? - License tag is still wrong - %defattr(-,root,root,-) is obsolete - The man page location should be keep. Changing this should be done by upstream and not during the package installation. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1827880] Review Request: fswatch - A cross-platform file change monitor
https://bugzilla.redhat.com/show_bug.cgi?id=1827880 --- Comment #6 from Darryl T. Agostinelli --- bump -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1827880] Review Request: fswatch - A cross-platform file change monitor
https://bugzilla.redhat.com/show_bug.cgi?id=1827880 --- Comment #5 from Darryl T. Agostinelli --- Spec URL: https://raw.githubusercontent.com/dagostinelli/fswatch-packaging/master/fswatch.spec SRPM URL: https://github.com/dagostinelli/fswatch-packaging/raw/master/fswatch-1.14.0-2.fc32.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1827880] Review Request: fswatch - A cross-platform file change monitor
https://bugzilla.redhat.com/show_bug.cgi?id=1827880 --- Comment #4 from Darryl T. Agostinelli --- During package review? I know we do this once it's checked into https://src.fedoraproject.org/ I made the change as requested. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1827880] Review Request: fswatch - A cross-platform file change monitor
https://bugzilla.redhat.com/show_bug.cgi?id=1827880 --- Comment #3 from Fabian Affolter --- This would be 1.14.0-2 aka with "Release: 2%{?dist}". There was a change and it requires a new release with a changelog entry. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1827880] Review Request: fswatch - A cross-platform file change monitor
https://bugzilla.redhat.com/show_bug.cgi?id=1827880 --- Comment #2 from Darryl T. Agostinelli --- Spec URL: https://raw.githubusercontent.com/dagostinelli/fswatch-packaging/master/fswatch.spec SRPM URL: https://github.com/dagostinelli/fswatch-packaging/raw/master/fswatch-1.14.0-1.fc32.src.rpm Updated. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1827880] Review Request: fswatch - A cross-platform file change monitor
https://bugzilla.redhat.com/show_bug.cgi?id=1827880 --- Comment #1 from Fabian Affolter --- Package Review == - The license is GPLv3+ (either version 3, or (at your option) any later version.) - Descriptions (%description static) should end with a period and %description is too long (see rpmlint ouput) - COPYING is in %doc and %license, should only be in %license - "Source0:" could be replaced with %{url}/archive/%{version}/%{name}-%{version}.tar.gz - NEWS could be part of the package, AUTHORS.libfswatch, NEWS.libfswatch andvREADME.libfswatch.md of the -devel package - The package should own %{_includedir}/lib%{name}/* Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed = MUST items = C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GPL (v3 or later)", "FSF All Permissive License", "GNU Free Documentation License", "GNU Free Documentation License (v1.3 or later)". 31 files have unknown license. Detailed output of licensecheck in /home/fab/Documents/repos/reviews/1827880-fswatch/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/include/libfswatch [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/include/libfswatch [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 61440 bytes in 4 files. [!]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: Static libraries in -static or -devel subpackage, providing -devel if present. Note: Package has .a files: fs
[Bug 1827880] Review Request: fswatch - A cross-platform file change monitor
https://bugzilla.redhat.com/show_bug.cgi?id=1827880 Fabian Affolter changed: What|Removed |Added Status|NEW |ASSIGNED CC||m...@fabian-affolter.ch Assignee|nob...@fedoraproject.org|m...@fabian-affolter.ch Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1827880] Review Request: fswatch - A cross-platform file change monitor
https://bugzilla.redhat.com/show_bug.cgi?id=1827880 Darryl T. Agostinelli changed: What|Removed |Added Priority|unspecified |low CC||dagostine...@gmail.com Doc Type|--- |If docs needed, set a value -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org