[Bug 1989357] Review Request: fedora-third-party - Tool for handling third-party RPM and Flatpak repositories in Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=1989357 --- Comment #10 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/fedora-third-party -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1989357] Review Request: fedora-third-party - Tool for handling third-party RPM and Flatpak repositories in Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=1989357 Neal Gompa changed: What|Removed |Added Flags|fedora-review? |fedora-review+ Status|ASSIGNED|POST --- Comment #9 from Neal Gompa --- Review notes: * Package is named correctly * Package builds and installs correctly * Package licensing is correct and license file is installed properly * No serious rpmlint issues Of note, though, the summary and description are too long for 24 columns wide, and should be reflowed on import. In any case... PACKAGE APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1989357] Review Request: fedora-third-party - Tool for handling third-party RPM and Flatpak repositories in Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=1989357 --- Comment #8 from Owen Taylor --- New version: * Adds polkit configuration for 'pkexec fedora-third-party' * Adds some more missing BuildRequires * Includes various command line tweaks (fedora-third-party enable --config-only, etc.) Spec URL: https://pagure.io/fedora-third-party/raw/main/f/fedora-third-party.spec SRPM URL: https://otaylor.fedorapeople.org/fedora-third-party/SRPMS/fedora-third-party-0.3-1.fc35.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1989357] Review Request: fedora-third-party - Tool for handling third-party RPM and Flatpak repositories in Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=1989357 --- Comment #7 from Neal Gompa --- The SRPM is not updated, fedora-review continues to fail. :( -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1989357] Review Request: fedora-third-party - Tool for handling third-party RPM and Flatpak repositories in Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=1989357 --- Comment #6 from Owen Taylor --- Added the python3-devel BuildRequires (same URLs). -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1989357] Review Request: fedora-third-party - Tool for handling third-party RPM and Flatpak repositories in Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=1989357 --- Comment #5 from Neal Gompa --- You're missing "BuildRequires: python3-devel", so the macros don't exist to build the package. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1989357] Review Request: fedora-third-party - Tool for handling third-party RPM and Flatpak repositories in Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=1989357 --- Comment #4 from Owen Taylor --- Spec file and SRPM have been updated to fix the identified problems. Thanks for the review! Spec URL: https://pagure.io/fedora-third-party/raw/main/f/fedora-third-party.spec SRPM URL: https://otaylor.fedorapeople.org/fedora-third-party-0.1-1.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1989357] Review Request: fedora-third-party - Tool for handling third-party RPM and Flatpak repositories in Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=1989357 Neal Gompa changed: What|Removed |Added Comment|0 |updated --- Comment #0 has been edited --- Spec URL: https://pagure.io/fedora-third-party/raw/main/f/fedora-third-party.spec SRPM URL: https://otaylor.fedorapeople.org/fedora-third-party-0.1-1.src.rpm Description: fedora-third-party is a tool for handling third-party RPM and Flatpak repositories in Fedora. It is used to handle the user changing their opt-in status for these repositories, and enables/disables RPM repositories and adds/removes Flatpak repositories as necessary. See: https://fedoraproject.org/wiki/Changes/Third_Party_Software_Mechanism Examples of usage: https://src.fedoraproject.org/rpms/fedora-workstation-repositories/diff/main..private-otaylor-fedora-third-party https://pagure.io/fedora-flathub-filter/c/8277908dc9e60b39ca197517a40c85806a704e1b?branch=main Fedora Account System Username: otaylor -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1989357] Review Request: fedora-third-party - Tool for handling third-party RPM and Flatpak repositories in Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=1989357
--- Comment #3 from Neal Gompa ---
> Release: 1
This should be "Release: 1%{?dist}" as we require the DistTag to be present.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
[Bug 1989357] Review Request: fedora-third-party - Tool for handling third-party RPM and Flatpak repositories in Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=1989357
--- Comment #2 from Neal Gompa ---
Initial review notes:
> %autosetup -p1 -n fedora-third-party-0.1
This should be "%autosetup -p1" or "%autosetup -p1 -n %{name}-%{version}" (the
-n stuff is optional since name-version matches the package name)
> %{python3_sitelib}/*
This is not allowed, you should use "%{python3_sitelib}/fedora_third_party*"
instead
Also, it seems to install a "tests" thing, which you shouldn't do. That
requires fixing setup.py accordingly:
https://pagure.io/fedora-third-party/blob/main/f/setup.py#_15
> %dnl This enables/adds any newly added repositories/remotes
> %transfiletriggerin -- %{_prefix}/lib/%{name}/conf.d
> fedora-third-party refresh
>
> %dnl This could potentially be used to remove Flatpak repositories (not
> currently implemented)
> %transfiletriggerpostun -- %{_prefix}/lib/%{name}/conf.d
> fedora-third-party refresh
"fedora-third-party refresh" should be "fedora-third-party refresh || :" so
that it won't fail if the package is uninstalled.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
[Bug 1989357] Review Request: fedora-third-party - Tool for handling third-party RPM and Flatpak repositories in Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=1989357 Neal Gompa changed: What|Removed |Added Blocks||1989360 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1989360 [Bug 1989360] Review Request: fedora-flathub-remote - Third party remote pointing to a filtered version of flathub.org -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1989357] Review Request: fedora-third-party - Tool for handling third-party RPM and Flatpak repositories in Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=1989357 Neal Gompa changed: What|Removed |Added Status|NEW |ASSIGNED CC||ngomp...@gmail.com Flags||fedora-review? Assignee|nob...@fedoraproject.org|ngomp...@gmail.com --- Comment #1 from Neal Gompa --- Taking this review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1989357] Review Request: fedora-third-party - Tool for handling third-party RPM and Flatpak repositories in Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=1989357 Owen Taylor changed: What|Removed |Added Summary|Review Request: -|for handling third-party ||RPM and Flatpak ||repositories in Fedora -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
