[Bug 737972] Review Request: spacewalk-admin - Various utility scripts and data files for RHN Satellite installations

2012-04-12 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=737972

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

   Fixed In Version|spacewalk-admin-1.8.3-1.fc1 |spacewalk-admin-1.8.3-1.el5
   |7   |

--- Comment #19 from Fedora Update System upda...@fedoraproject.org 
2012-04-12 01:58:55 EDT ---
spacewalk-admin-1.8.3-1.el5 has been pushed to the Fedora EPEL 5 stable
repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 737972] Review Request: spacewalk-admin - Various utility scripts and data files for RHN Satellite installations

2012-04-12 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=737972

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

   Fixed In Version|spacewalk-admin-1.8.3-1.el5 |spacewalk-admin-1.8.3-1.el6

--- Comment #20 from Fedora Update System upda...@fedoraproject.org 
2012-04-12 01:59:48 EDT ---
spacewalk-admin-1.8.3-1.el6 has been pushed to the Fedora EPEL 6 stable
repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 737972] Review Request: spacewalk-admin - Various utility scripts and data files for RHN Satellite installations

2012-04-11 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=737972

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||spacewalk-admin-1.8.3-1.fc1
   ||7
 Resolution||ERRATA
Last Closed||2012-04-11 22:43:55

--- Comment #18 from Fedora Update System upda...@fedoraproject.org 
2012-04-11 22:43:55 EDT ---
spacewalk-admin-1.8.3-1.fc17 has been pushed to the Fedora 17 stable
repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 737972] Review Request: spacewalk-admin - Various utility scripts and data files for RHN Satellite installations

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=737972

--- Comment #10 from Miroslav Suchý msu...@redhat.com 2012-03-27 07:23:09 EDT 
---
Changelog entries fixed.
Man pages added.

Updated:
http://miroslav.suchy.cz/fedora/spacewalk-admin/spacewalk-admin-1.8.3-1.fc16.src.rpm
http://miroslav.suchy.cz/fedora/spacewalk-admin/spacewalk-admin.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 737972] Review Request: spacewalk-admin - Various utility scripts and data files for RHN Satellite installations

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=737972

Michael Scherer m...@zarb.org changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Flag|fedora-review?  |fedora-review+

--- Comment #11 from Michael Scherer m...@zarb.org 2012-03-27 09:15:05 EDT ---
[x]: MUST Changelog in prescribed format.

So the package is good to go.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 737972] Review Request: spacewalk-admin - Various utility scripts and data files for RHN Satellite installations

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=737972

--- Comment #13 from Jon Ciesla limburg...@gmail.com 2012-03-27 09:40:01 EDT 
---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 737972] Review Request: spacewalk-admin - Various utility scripts and data files for RHN Satellite installations

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=737972

Miroslav Suchý msu...@redhat.com changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #12 from Miroslav Suchý msu...@redhat.com 2012-03-27 09:36:57 EDT 
---
New Package SCM Request
===
Package Name: spacewalk-admin
Short Description: Various utility scripts and data files for RHN Satellite
installations
Owners: msuchy
Branches: F-17, F-16, EL-5, EL-6
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 737972] Review Request: spacewalk-admin - Various utility scripts and data files for RHN Satellite installations

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=737972

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 737972] Review Request: spacewalk-admin - Various utility scripts and data files for RHN Satellite installations

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=737972

--- Comment #14 from Fedora Update System upda...@fedoraproject.org 
2012-03-27 14:06:42 EDT ---
spacewalk-admin-1.8.3-1.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/spacewalk-admin-1.8.3-1.fc17

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 737972] Review Request: spacewalk-admin - Various utility scripts and data files for RHN Satellite installations

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=737972

--- Comment #15 from Fedora Update System upda...@fedoraproject.org 
2012-03-27 14:31:02 EDT ---
spacewalk-admin-1.8.3-1.el5 has been submitted as an update for Fedora EPEL 5.
https://admin.fedoraproject.org/updates/spacewalk-admin-1.8.3-1.el5

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 737972] Review Request: spacewalk-admin - Various utility scripts and data files for RHN Satellite installations

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=737972

--- Comment #16 from Fedora Update System upda...@fedoraproject.org 
2012-03-27 14:31:33 EDT ---
spacewalk-admin-1.8.3-1.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/spacewalk-admin-1.8.3-1.el6

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 737972] Review Request: spacewalk-admin - Various utility scripts and data files for RHN Satellite installations

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=737972

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA

--- Comment #17 from Fedora Update System upda...@fedoraproject.org 
2012-03-28 00:54:51 EDT ---
spacewalk-admin-1.8.3-1.el5 has been pushed to the Fedora EPEL 5 testing
repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 737972] Review Request: spacewalk-admin - Various utility scripts and data files for RHN Satellite installations

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=737972

--- Comment #3 from Miroslav Suchý msu...@redhat.com 2012-03-26 04:06:39 EDT 
---
Updated:
http://miroslav.suchy.cz/fedora/spacewalk-admin/spacewalk-admin-1.8.1-1.fc16.src.rpm
http://miroslav.suchy.cz/fedora/spacewalk-admin/spacewalk-admin.spec

Please note that I'm member of upstream. Therefore I created new release (as I
put those changes directly to upstream) and not put it in spec as patch.

 - for a fedora rpm, BuildRoot is no longer needed, same goes for %defattr, and
%clean, and cleaning of %install

We build the package for EPEL and mainly EPEL5 as well. And there there it is
needed. It is easier to maintain the spec file when we can leave it there (and
it makes no harm of Fedora). But if you insinst on that I can make separate
spec for Fedora and for EPEL.

 you should consider using packages rather than filedesps
fixed

 you should use %global, not %define for %rhnroot
fixed

 you should also ( IMHO ) place requires on 1 line each, as it permit to have
easier to read diff when sending patch
That is only two perl packages. Somebody in past decided that it would be nice
to have perl packages together. I do not think it is necessary, but if you see
it as blocker, I can change it.

 the file spacewalk-service look like a init script, and recent fedora use
 systemd, so the file should be converted
 http://fedoraproject.org/wiki/Packaging:Systemd
It looks like init script, but it is not.
Spacewalk server is layered application and is build on top of several services
(jabberd, httpd, tomcat6, osad-dispatcher, postgresql...). And since usually
Spacewalk server is run on dedicated machine and these services are run just
because Spacewalk server - if sysadmin want to restart Spacewalk, he would have
to write:
service tomcat6 stop
service httpd stop 
...
service  httpd start
service  tomcat6 start
which means: he has to enumerate all services which Spacewalk requires, not
forget single one and do it in correct order.
To make it easy for sysadmin, we provide spacewalk-service script, which can do
that.
But it does *not* start those service during boot. And neither stop those
services during shutdown. Each of those services still has its own
initd/systemd script.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 737972] Review Request: spacewalk-admin - Various utility scripts and data files for RHN Satellite installations

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=737972

--- Comment #4 from Miroslav Suchý msu...@redhat.com 2012-03-26 04:10:25 EDT 
---
I forgot that in previous comment:
 Also, there is no file to give the license of the tarball
Fixed as well.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 737972] Review Request: spacewalk-admin - Various utility scripts and data files for RHN Satellite installations

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=737972

--- Comment #5 from Michael Scherer m...@zarb.org 2012-03-26 04:40:05 EDT ---
No, neither buildroot or package on the same line are blocking.

I will start the formal review soon.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 737972] Review Request: spacewalk-admin - Various utility scripts and data files for RHN Satellite installations

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=737972

--- Comment #6 from Michael Scherer m...@zarb.org 2012-03-26 05:14:47 EDT ---
The directory /var/lib/rhn is already owned by spacewalk-config, but according
to the policy, the current way is ok ( unless spacewalk-config end somehow in
the dependency chain of spacewalk-admin, but it doesn't seems to be the case, i
am just mentioning to be complete ).

So that's ok, according to
https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership

However, it seems that the package requires sudo, and nothing use it in the
script, is this correct ?

The same goes for restorecon, I didn't found where it is needed in the current
tarball.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 737972] Review Request: spacewalk-admin - Various utility scripts and data files for RHN Satellite installations

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=737972

--- Comment #7 from Miroslav Suchý msu...@redhat.com 2012-03-26 05:48:26 EDT 
---
You are correct. Usage of restorecon in this package has been removed year ago.
And sudo even earlier. I will remove those requires completely.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 737972] Review Request: spacewalk-admin - Various utility scripts and data files for RHN Satellite installations

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=737972

--- Comment #8 from Miroslav Suchý msu...@redhat.com 2012-03-26 05:56:11 EDT 
---
Updated:
http://miroslav.suchy.cz/fedora/spacewalk-admin/spacewalk-admin-1.8.2-1.fc16.src.rpm
http://miroslav.suchy.cz/fedora/spacewalk-admin/spacewalk-admin.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 737972] Review Request: spacewalk-admin - Various utility scripts and data files for RHN Satellite installations

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=737972

--- Comment #9 from Michael Scherer m...@zarb.org 2012-03-26 11:40:12 EDT ---

Package Review
==

Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated



 Generic 
[x]: MUST Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
 least one supported primary architecture.
[-]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
 Note: Buildroot is not needed unless packager plans to package for EPEL5
[x]: MUST Package contains no bundled libraries.
[!]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
 Note: Clean is needed only if supporting EPEL
[x]: MUST Sources contain only permissible code or content.
[x]: MUST %config files are marked noreplace or the reason is justified.
[x]: MUST Each %files section contains %defattr if rpm  4.4
 Note: defattr() present in %files section. This is OK if packaging
 for EPEL5. Otherwise not needed
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
 Note: rm -rf is only needed if supporting EPEL5
[x]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
 Note: Licenses found: UNKNOWN For detailed output of licensecheck see
 file: /home/misc/checkout/git/FedoraReview/src/737972/licensecheck.txt
[x]: MUST Package consistently uses macros (instead of hard-coded directory
 names).
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST No %config files under /usr.
[x]: MUST Package does not generate any conflict.
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[x]: MUST If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Requires correct, justified where necessary.
[!]: MUST Rpmlint output is silent.

rpmlint spacewalk-admin-1.8.2-1.fc18.src.rpm

1 packages and 0 specfiles checked; 0 errors, 0 warnings.


rpmlint spacewalk-admin-1.8.2-1.fc18.noarch.rpm

spacewalk-admin.noarch: W: no-manual-page-for-binary rhn-generate-pem.pl
spacewalk-admin.noarch: W: no-manual-page-for-binary rhn-deploy-ca-cert.pl
spacewalk-admin.noarch: W: no-manual-page-for-binary rhn-install-ssl-cert.pl
1 packages and 0 specfiles checked; 0 errors, 3 warnings.


[x]: MUST Sources used to build the package match the upstream source, as
 provided in the spec URL.

[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[-]: MUST Package contains a SysV-style init script if in need of one.
[x]: MUST File names are valid UTF-8.
[x]: SHOULD Reviewer should test that the package builds in mock.
[x]: SHOULD If the source package does not include license text(s) as a
 separate file from upstream, the packager SHOULD query upstream to
 include it.
[x]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
 /usr/sbin.
[x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
 --requires).
[x]: SHOULD Package functions as described.
[x]: SHOULD Latest version is packaged.
[x]: SHOULD Package does not include license text files separate from
 upstream.
[x]: SHOULD SourceX is a working URL.
[x]: SHOULD Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: SHOULD Package should compile and build into binary rpms on all supported
 architectures.
[x]: SHOULD 

[Bug 737972] Review Request: spacewalk-admin - Various utility scripts and data files for RHN Satellite installations

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=737972

Michael Scherer m...@zarb.org changed:

   What|Removed |Added

 AssignedTo|nob...@fedoraproject.org|m...@zarb.org
   Flag||fedora-review?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 737972] Review Request: spacewalk-admin - Various utility scripts and data files for RHN Satellite installations

2012-03-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=737972

Michael Scherer m...@zarb.org changed:

   What|Removed |Added

 CC||m...@zarb.org

--- Comment #1 from Michael Scherer m...@zarb.org 2012-03-24 03:28:04 EDT ---
Hi,

can you update the spec file for the latest release  ( and the tarball for the
version 1.6.X are missing ) ?

also, a few note :
- for a fedora rpm, BuildRoot is no longer needed, same goes for %defattr, and
%clean, and cleaning of %install

- you should use %global, not %define for %rhnroot
http://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define

- you should consider using packages rather than filedesps, for reasons listed
in the guideline :
http://fedoraproject.org/wiki/Packaging:Guidelines#File_Dependencies

- you should also ( IMHO ) place requires on 1 line each, as it permit to have
easier to read diff when sending patch

- the file spacewalk-service look like a init script, and recent fedora use
systemd, so the file should be converted
http://fedoraproject.org/wiki/Packaging:Systemd

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 737972] Review Request: spacewalk-admin - Various utility scripts and data files for RHN Satellite installations

2012-03-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=737972

--- Comment #2 from Michael Scherer m...@zarb.org 2012-03-24 03:37:54 EDT ---
Also, there is no file to give the license of the tarball, and you should ask
upstream to add one :
http://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 737972] Review Request: spacewalk-admin - Various utility scripts and data files for RHN Satellite installations

2011-12-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=737972

Milan Zazrivec mzazri...@redhat.com changed:

   What|Removed |Added

 Blocks||765736(space17)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 737972] Review Request: spacewalk-admin - Various utility scripts and data files for RHN Satellite installations

2011-12-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=737972

Milan Zazrivec mzazri...@redhat.com changed:

   What|Removed |Added

 Blocks|765736(space17) |

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 737972] Review Request: spacewalk-admin - Various utility scripts and data files for RHN Satellite installations

2011-09-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=737972

Miroslav Suchý msu...@redhat.com changed:

   What|Removed |Added

 Blocks||452450(F-Spacewalk)
  Alias||spacewalk-admin

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review