[Bug 973868] Re-Review Request: lifeograph - A diary program
https://bugzilla.redhat.com/show_bug.cgi?id=973868 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|lifeograph-0.11.1-2.fc19|lifeograph-0.11.1-2.fc18 --- Comment #17 from Fedora Update System upda...@fedoraproject.org --- lifeograph-0.11.1-2.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=diIFh3QAG9a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 973868] Re-Review Request: lifeograph - A diary program
https://bugzilla.redhat.com/show_bug.cgi?id=973868 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||lifeograph-0.11.1-2.fc19 Resolution|--- |ERRATA Last Closed||2013-06-29 14:24:04 --- Comment #16 from Fedora Update System upda...@fedoraproject.org --- lifeograph-0.11.1-2.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lFgdArYNvja=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 973868] Re-Review Request: lifeograph - A diary program
https://bugzilla.redhat.com/show_bug.cgi?id=973868 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZBxvGiNKrYa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 973868] Re-Review Request: lifeograph - A diary program
https://bugzilla.redhat.com/show_bug.cgi?id=973868 --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- lifeograph-0.11.1-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/lifeograph-0.11.1-2.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0rMpAHHZ3sa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 973868] Re-Review Request: lifeograph - A diary program
https://bugzilla.redhat.com/show_bug.cgi?id=973868 --- Comment #14 from Fedora Update System upda...@fedoraproject.org --- lifeograph-0.11.1-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/lifeograph-0.11.1-2.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=14thMtV8bJa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 973868] Re-Review Request: lifeograph - A diary program
https://bugzilla.redhat.com/show_bug.cgi?id=973868 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #15 from Fedora Update System upda...@fedoraproject.org --- lifeograph-0.11.1-2.fc19 has been pushed to the Fedora 19 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UMihxDmAHNa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 973868] Re-Review Request: lifeograph - A diary program
https://bugzilla.redhat.com/show_bug.cgi?id=973868 --- Comment #10 from Jon Ciesla limburg...@gmail.com --- Unretired, please take ownership in pkgdb and submit a Package Change request for additional branches. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=FqF4ggCiHfa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 973868] Re-Review Request: lifeograph - A diary program
https://bugzilla.redhat.com/show_bug.cgi?id=973868 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3jABF2ZhWra=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 973868] Re-Review Request: lifeograph - A diary program
https://bugzilla.redhat.com/show_bug.cgi?id=973868 Ankur Sinha (FranciscoD) sanjay.an...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #11 from Ankur Sinha (FranciscoD) sanjay.an...@gmail.com --- Package Change Request == Package Name: lifeograph New Branches: f18 f19 Owners: ankursinha InitialCC: Taken ownership. Thanks. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7YSjpxdQXDa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 973868] Re-Review Request: lifeograph - A diary program
https://bugzilla.redhat.com/show_bug.cgi?id=973868 --- Comment #12 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6czJAl7lzpa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 973868] Re-Review Request: lifeograph - A diary program
https://bugzilla.redhat.com/show_bug.cgi?id=973868 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=jujZ5ufFhqa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 973868] Re-Review Request: lifeograph - A diary program
https://bugzilla.redhat.com/show_bug.cgi?id=973868 --- Comment #5 from Ankur Sinha (FranciscoD) sanjay.an...@gmail.com --- Thanks for the review! Updated: http://ankursinha.fedorapeople.org/Lifeograph/lifeograph.spec http://ankursinha.fedorapeople.org/Lifeograph/lifeograph-0.11.1-2.fc20.src.rpm * Sat Jun 15 2013 Ankur Sinha ankursinha AT fedoraproject DOT org 0.11.1-2 - Replace sed with patch - Update desktop database - Bug# 973868 Warm regards, Ankur -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2Ct2dHMd77a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 973868] Re-Review Request: lifeograph - A diary program
https://bugzilla.redhat.com/show_bug.cgi?id=973868 Ankur Sinha (FranciscoD) sanjay.an...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3naIYBia8ba=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 973868] Re-Review Request: lifeograph - A diary program
https://bugzilla.redhat.com/show_bug.cgi?id=973868 Alec Leamas leamas.a...@gmail.com changed: What|Removed |Added Assignee|nob...@fedoraproject.org|leamas.a...@gmail.com --- Comment #6 from Alec Leamas leamas.a...@gmail.com --- Ouch... seems that I wasn't clear about the sed issues... :( The original sed patching of the desktop file was basically fine IMHO, besides that the was expressions needlessly complicated and the backup useless. My idea was to replace these with something like sed -i -e '/^Ĉategories/s/$/;/' -e /^MimeType/s/$/;/ lifeograph.desktop or so (nop patch here required, but doessn't, hjurt either, I guess) Mhy real concerns is the last expresseion sed -ibackup 81,86 d wscript. This is just too vulnerable to even whitespace changes, and should be replaced with a patch IMHO. Sorry for the mess. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ymFQBIXm87a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 973868] Re-Review Request: lifeograph - A diary program
https://bugzilla.redhat.com/show_bug.cgi?id=973868 --- Comment #7 from Ankur Sinha (FranciscoD) sanjay.an...@gmail.com --- Hi Alec! My bad! I knew what you meant but completely forgot the second sed command! I've replaced both sed commands with patches, and commented the patches too. I'll try sending the wscript patch upstream. Their wscript overrides all flags so I'm not sure how other distributions are building this app. Updated spec/srpm: http://ankursinha.fedorapeople.org/Lifeograph/lifeograph.spec http://ankursinha.fedorapeople.org/Lifeograph/lifeograph-0.11.1-2.fc20.src.rpm I haven't bumped the release for this change. (The same changelog applies) Thanks, Warm regards, Ankur -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Utc1K9DwLfa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 973868] Re-Review Request: lifeograph - A diary program
https://bugzilla.redhat.com/show_bug.cgi?id=973868 Alec Leamas leamas.a...@gmail.com changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #8 from Alec Leamas leamas.a...@gmail.com --- Hi Ankur! You're welcome! Looks good. *** Approved -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gdi6jPZVZTa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 973868] Re-Review Request: lifeograph - A diary program
https://bugzilla.redhat.com/show_bug.cgi?id=973868 Ankur Sinha (FranciscoD) sanjay.an...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #9 from Ankur Sinha (FranciscoD) sanjay.an...@gmail.com --- New Package SCM Request === Package Name: lifeograph Short Description: A diary program Owners: ankursinha Branches: f18 f19 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lK0Tr9iVcXa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 973868] Re-Review Request: lifeograph - A diary program
https://bugzilla.redhat.com/show_bug.cgi?id=973868 Alec Leamas leamas.a...@gmail.com changed: What|Removed |Added CC||leamas.a...@gmail.com Docs Contact||leamas.a...@gmail.com Flags||fedora-review? --- Comment #2 from Alec Leamas leamas.a...@gmail.com --- and I'll review this one -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=CF7engKgVma=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 973868] Re-Review Request: lifeograph - A diary program
https://bugzilla.redhat.com/show_bug.cgi?id=973868
--- Comment #3 from Alec Leamas leamas.a...@gmail.com ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
Issues:
===
- Code sems to be GPLv3+ rather than GPLv3 at a quick glance. Or is there
indeed something in the sources which requires plain GPLv3?
- update-desktop-database is invoked when required
Note: desktop file in lifeograph contains MimeType entry, needs
to update desktop-database
See:
http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-database
- The sed scripts could (and should) be simplified and sanitized.
s|\(Categories=Utility\)|\1;| - /^Ĉategories/s/$/;/
s|\(MimeType=application/x-lifeographdiary\)|\1;| - /^MimeType/s/$/;/
These two are applied to the same file making the backup useless. Either
merge the two commands to one using -e, or just drop the backup.
sed -ibackup 81,86 d wscript - something else. This will fail silently
for just an added blank line somewhere. Matching two regex'es or so seems
much safer.
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
*No copyright* GPL (v3 or later), GPL (v3 or later). Detailed output
of licensecheck in
/home/leamas/tmp/FedoraReview/973868-lifeograph/licensecheck.txt
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: gtk-update-icon-cache is invoked when required
Note: icons in lifeograph
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 51200 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install if there is
such a file.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[Bug 973868] Re-Review Request: lifeograph - A diary program
https://bugzilla.redhat.com/show_bug.cgi?id=973868 --- Comment #4 from Alec Leamas leamas.a...@gmail.com --- Actually, instead of the last sed-script I would suggest using a patch; it seems like a better alternative for this kind of fix. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NEkGVI279Ma=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 973868] Re-Review Request: lifeograph - A diary program
https://bugzilla.redhat.com/show_bug.cgi?id=973868 --- Comment #1 from Ankur Sinha (FranciscoD) sanjay.an...@gmail.com --- SRPMs updated. The macro in comment warnings are now gone. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=PnL1SnEUSUa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
