[Bug 1543527] Review Request: kyua - Testing framework for infrastructure software

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1543527



--- Comment #3 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/kyua

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1119197] Review Request: gnushogi - Shogi (Japanese Chess) AI engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1119197



--- Comment #23 from Ben Rosser  ---
> copr does not use koji at all. ;) Scratch builds in koji are similar to copr 
> builds with the 'network access' turned off, but they aren't the exact same 
> systems doing the building. 

Whoops, yes, I misspoke. What I meant to say was, both use *mock* behind the
scenes and therefore are equally suitable for scratch builds.

> No sure why it wants to write .bbk into lib64. Might need to invent a patch 
> to move it into share or generate into user's home.

That might be a good idea, since it seems like gnushogi expects to be able to
write out the book files while it's running. Ideally, I guess it should be able
to read them from both /usr/share and somewhere under /home?

I'd encourage you to try to improve this, but this isn't a blocker for review
purposes. 

However... one final thing that is a blocker:

> %{_libdir}/%{name}/gnushogi.tbk
> %{_libdir}/%{name}/gnushogi.bbk

Should just be:

> %{_libdir}/%{name}

The former causes %{_libdir}/gnushogi to be a directory not owned by any
package.

https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "GPL (v1 or later) (with incorrect FSF address)", "Unknown or
 generated", "GPL (v3 or later)". 21 files have unknown license.

 (Note: this is weird but some of the Makefiles have GPL+ headers instead
 of GPLv3+ headers... but they don't actually get built into the package,
 so I think the GPLv3+ license tag is fine).

[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/lib64/gnushogi
[!]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/lib64/gnushogi
[x]: Package does not own files or directories owned by other packages.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Texinfo files are installed using install-info in %post and %preun if
 package has .info files.
 Note: Texinfo .info file(s) in gnushogi
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 81920 bytes in 10 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make 

[Bug 1543578] Review Request: php-deepdiver-zipstreamer - package maintained fork of PHPZipStreamer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1543578

Christian Glombek  changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1543578] New: Review Request: php-deepdiver-zipstreamer - package maintained fork of PHPZipStreamer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1543578

Bug ID: 1543578
   Summary: Review Request: php-deepdiver-zipstreamer - package
maintained fork of PHPZipStreamer
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Assignee: nob...@fedoraproject.org
  Reporter: c...@petersen-glombek.de
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://copr-be.cloud.fedoraproject.org/results/lorbus/php-deepdiver-zipstreamer/fedora-27-x86_64/00712432-php-deepdiver-zipstreamer/php-deepdiver-zipstreamer.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/lorbus/php-deepdiver-zipstreamer/fedora-27-x86_64/00712432-php-deepdiver-zipstreamer/php-deepdiver-zipstreamer-1.1.0-1.fc27.src.rpm

Description:
Bundle deepdiver/zipstreamer fork which is maintained and required in
NextCloud/OwnCloud. 
Obsoletes php-mcnetic-zipstreamer as it uses the same namespace.
Should I add Conflicts: here as well?
For more info on this see: https://github.com/McNetic/PHPZipStreamer/pull/39

Fedora Account System Username: lorbus

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1023690] Review Request: rspamd - Fast, free and open-source spam filtering system

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1023690



--- Comment #6 from Christian Glombek  ---
I believe this issue has been obsoleted and can now be closed. 

Current tracking bug for Rspamd:
https://bugzilla.redhat.com/show_bug.cgi?id=1494914

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1543578] Review Request: php-deepdiver-zipstreamer - package maintained fork of PHPZipStreamer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1543578



--- Comment #1 from Christian Glombek  ---
For a display of changes made from php-mcnetic-tarstreamer, see:

https://github.com/LorbusChris/php-deepdiver-zipstreamer-rpm/commit/4a66d46a0650161e51838c92ba4fe9c8cb3b9b74

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1543527] New: Review Request: kyua - Testing framework for infrastructure software

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1543527

Bug ID: 1543527
   Summary: Review Request: kyua - Testing framework for
infrastructure software
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: ignate...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/kyua.spec
SRPM URL:
https://ignatenkobrain.fedorapeople.org/for-review/kyua-0.13-1.fc28.src.rpm
Description:
Kyua is a testing framework for infrastructure software, originally designed
to equip BSD-based operating systems with a test suite. This means that
Kyua is lightweight and simple, and that Kyua integrates well with various
build systems and continuous integration frameworks.

Kyua features an expressive test suite definition language, a safe runtime
engine for test suites and a powerful report generation engine.

Kyua is for both developers and users, from the developer applying a simple
fix to a library to the system administrator deploying a new release
on a production machine.

Kyua is able to execute test programs written with a plethora of
testing libraries and languages. The library of choice is ATF, for which
Kyua was originally designed, but simple, framework-less test programs and
TAP-compliant test programs can also be executed through Kyua.
Fedora Account System Username: ignatenkobrain

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1543527] Review Request: kyua - Testing framework for infrastructure software

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1543527

Neal Gompa  changed:

   What|Removed |Added

 CC||ngomp...@gmail.com
   Assignee|nob...@fedoraproject.org|ngomp...@gmail.com
  Flags||fedora-review?



--- Comment #1 from Neal Gompa  ---
Taking this review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1542650] Review Request: QEverCloud - Unofficial Evernote Cloud API for Qt5

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1542650

Ben Rosser  changed:

   What|Removed |Added

  Flags|fedora-review+  |fedora-review?



--- Comment #2 from Ben Rosser  ---
Sorry... I missed two additional things with the qevercloud-doc package. I
guess I should be more careful doing package reviews when I'm sick. :)

> %package doc
> Summary: Documentation for %{altname}

You're missing a 'BuildArch: noarch' for the doc package.

> Note: Directories without known owners: /usr/share/doc/qt5

I didn't notice this last night, but this is being reported by fedora-review
because the -doc subpackage doesn't actually depend on the main one. So, it's
technically possible to install qevercloud-doc without qt5-qtbase installed.

So, either qevercloud-doc needs to co-own /usr/share/doc/qt5 or it should just
depend on qt5-qtbase.

Since there are now several things to cleanup, and the directory ownership
thing is technically a blocker, I'll temporarily un-approve this. Please fix
these issues and I'll re-approve.

Here is the full output of fedora-review.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues
==
- ldconfig called in %post and %postun if required.
  Note: /sbin/ldconfig not called in qevercloud
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#Shared_Libraries


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated". 62 files have
 unknown license. Detailed output of licensecheck in
 /home/bjr/Programming/fedora/reviews/1542650-qevercloud/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[!]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/doc/qt5
[x]: Package does not own files or directories owned by other packages.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: 

[Bug 1543527] Review Request: kyua - Testing framework for infrastructure software

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1543527

Neal Gompa  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #2 from Neal Gompa  ---
Review notes:

* Package follows general packaging guidelines
* Package is named correctly
* Obsoletes/Provides for replacing the package are sane
* Licensing is properly marked and license files are correctly included
* Package installs correctly, and upgrade path isn't broken

PACKAGE APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536852] Review Request: molsketch - Molecular Structures Editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536852



--- Comment #26 from Antonio Trande  ---
(In reply to Alexander Ploumistos from comment #25)
> (In reply to Antonio Trande from comment #24)
> > - Openbabel features do not work yet.
> 
> Sorry about the mess, I had been using 2 different machines plus koji and I
> mixed up my files. That's why the spec files don't match.
> 
> The f27 scratch build does work for me and the rawhide build was made from
> the same rpm, so maybe you could try removing 
> ~/.config/SourceForge/Molsketch.conf
> if it's there and try again?

Bingo! It's working now.

> 
>  
> > - ldconfig scriplets are not needed if you install libraries in a private
> > directory.
> 
> And for the devel subpackages they are not needed at all?

Yes.

> 
> 
> > - You're installing duplicate libraries with devel sub-package
> > 
> > Remove
> > 
> > %{_libdir}/%{name}/lib%{name}*so
> > %{_libdir}/%{name}/libobabeliface*so
> 
> And leave only
> %{_includedir}/lib%{name}
> ?

We finally understand what was the problem, then we can separate correctly the
libraries; that is '*.so' in devel and '*.so.*' in main package.

> 
> 
> > - Not all headers are installed; see the list below.
> >   Respect the directories too; for example:
> > 
> >  
> > /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/
> > abstractitemaction.h
> > 
> > is installed as
> > 
> >   /usr/include/libmolsketch/actions/abstractitemaction.h
> > 
> > and so on.
> 
> I am sorry, but I do not understand what I am supposed to do here, could you
> please explain a bit?
> 
> 
> I'll sort through my files tonight, I will add your corrections and submit
> new builds probably tomorrow.

For 'rpmlint' not all the *.h files are installed.
For example,
'/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/obabeliface/obabeliface.h' is not
in the '-devel' subpackage.

You can quickly fix with the attached patch.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536852] Review Request: molsketch - Molecular Structures Editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536852



--- Comment #25 from Alexander Ploumistos  ---
(In reply to Antonio Trande from comment #24)
> - Openbabel features do not work yet.

Sorry about the mess, I had been using 2 different machines plus koji and I
mixed up my files. That's why the spec files don't match.

The f27 scratch build does work for me and the rawhide build was made from the
same rpm, so maybe you could try removing  ~/.config/SourceForge/Molsketch.conf
if it's there and try again?


> - ldconfig scriplets are not needed if you install libraries in a private
> directory.

And for the devel subpackages they are not needed at all?


> - You're installing duplicate libraries with devel sub-package
> 
> Remove
> 
> %{_libdir}/%{name}/lib%{name}*so
> %{_libdir}/%{name}/libobabeliface*so

And leave only
%{_includedir}/lib%{name}
?


> - Not all headers are installed; see the list below.
>   Respect the directories too; for example:
> 
>  
> /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/
> abstractitemaction.h
> 
> is installed as
> 
>   /usr/include/libmolsketch/actions/abstractitemaction.h
> 
> and so on.

I am sorry, but I do not understand what I am supposed to do here, could you
please explain a bit?


I'll sort through my files tonight, I will add your corrections and submit new
builds probably tomorrow.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536852] Review Request: molsketch - Molecular Structures Editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536852



--- Comment #27 from Antonio Trande  ---
Created attachment 1393272
  --> https://bugzilla.redhat.com/attachment.cgi?id=1393272=edit
Patch for installation of header files

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519749] Review request: qdigidoc - Estonian digital signature application

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519749



--- Comment #9 from Fedora Update System  ---
qdigidoc-3.13.5-3.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-8d148ceb02

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519749] Review request: qdigidoc - Estonian digital signature application

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519749

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1543578] Review Request: php-deepdiver-zipstreamer - package maintained fork of PHPZipStreamer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1543578



--- Comment #2 from Christian Glombek  ---
Updated:

https://github.com/LorbusChris/php-deepdiver-zipstreamer-rpm/commit/8682a4b252c96ddf62096b82217472099677ee46

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1543527] Review Request: kyua - Testing framework for infrastructure software

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1543527

Igor Gnatenko  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-02-08 14:11:25



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532042] Review Request: compton - Compositor for X11

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532042

Igor Gnatenko  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|ignate...@redhat.com



--- Comment #10 from Igor Gnatenko  ---
I will sponsor you and take this review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1542663] Review Request: bitlbee-discord - Bitlbee plugin for Discord

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1542663



--- Comment #6 from Fedora Update System  ---
bitlbee-discord-0.4.1-2.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-829e7a235a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532042] Review Request: compton - Compositor for X11

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532042



--- Comment #11 from Abhiram K <4kuch...@gmail.com> ---
Thank you so much for the sponser!

I removed the scriptlets and made the changes to those two lines as you
suggested.

SPEC URL:
https://copr-be.cloud.fedoraproject.org/results/axeld/compton/fedora-27-x86_64/00712491-compton/compton.spec

SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/axeld/compton/fedora-27-x86_64/00712491-compton/compton-0.1_beta3-0.1_beta3.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1542522] Review Request: jsonnet - a data templating language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1542522

Naadir Jeewa  changed:

   What|Removed |Added

  Alias||jsonnet



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1542522] Review Request: jsonnet - a data templating language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1542522

Naadir Jeewa  changed:

   What|Removed |Added

URL||https://github.com/google/j
   ||sonnet



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1543578] Review Request: php-deepdiver-zipstreamer - package maintained fork of PHPZipStreamer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1543578



--- Comment #3 from Christian Glombek  ---
and again:

https://github.com/LorbusChris/php-deepdiver-zipstreamer-rpm/commit/1718abe6d4ae1fb6e6e121c8ebca967064a83b0d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1542663] Review Request: bitlbee-discord - Bitlbee plugin for Discord

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1542663

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1542663] Review Request: bitlbee-discord - Bitlbee plugin for Discord

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1542663



--- Comment #5 from Fedora Update System  ---
bitlbee-discord-0.4.1-2.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-e3cf77ed71

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1540347] Review Request: hashcat - password recovery utility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540347



--- Comment #18 from Jaroslav Škarvada  ---
I jsut tried for curiosity hashcat with POCL on ppc64. The POCL itself has some
issues there (the internal testsuite is failing), but this will get resolved
sooner or later. The bigger problem is that hashcat OCL kernels hardcode
little-endian, so it will not work on ppc64 until hashcat upstream adds support
for it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532042] Review Request: compton - Compositor for X11

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532042



--- Comment #9 from Igor Gnatenko  ---
%post
update-desktop-database &> /dev/null || :
touch --no-create %{_datadir}/icons/hicolor &>/dev/null
gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || :

%postun
update-desktop-database &> /dev/null || :
if [ $1 -eq 0 ] ; then
touch --no-create %{_datadir}/icons/hicolor &>/dev/null
gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || :
fi


Please remove those scriptlets.

> %__make
> %__make docs
%make_build
%make_build docs

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539134] Review Request: bouncycastle1.58 - Bouncy Castle Cryptography APIs for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539134

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539134] Review Request: bouncycastle1.58 - Bouncy Castle Cryptography APIs for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539134



--- Comment #7 from Fedora Update System  ---
bouncycastle1.58-1.58-1.el6 canl-java-2.5.0-2.el6 jglobus-2.1.0-5.el6
voms-api-java-3.3.0-1.el6 voms-clients-java-3.3.0-1.el6 has been submitted as
an update to Fedora EPEL 6.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-71db8f6f28

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539134] Review Request: bouncycastle1.58 - Bouncy Castle Cryptography APIs for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539134

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #6 from Fedora Update System  ---
bouncycastle1.58-1.58-1.el6, canl-java-2.5.0-2.el6, jglobus-2.1.0-5.el6,
voms-api-java-3.2.0-7.el6, voms-clients-java-3.0.7-6.el6 has been pushed to the
Fedora EPEL 6 testing repository. If problems still persist, please make note
of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-71db8f6f28

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1315809] Review Request: python-pylxd - python library for lxd

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315809

James Paul Turner  changed:

   What|Removed |Added

 CC||jamesturner...@gmail.com



--- Comment #2 from James Paul Turner  ---
Hi Haïkel.

I appreciate that it's been almost two years since you submitted this, but are
you able to re-upload both review files? The above srpm link is down. 

Thanks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1520585] Review Request: perl-Test-SQL-Data - Helps running SQL tests : database preparing and result matching

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520585

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|ERRATA  |---
   Keywords||Reopened



--- Comment #15 from Fedora Update System  ---
perl-Test-SQL-Data-0.0.6-2.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-483d50018f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1520581] Review Request: perl-Authen-Passphrase - Hashed passwords/ passphrases as objects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520581
Bug 1520581 depends on bug 1520572, which changed state.

Bug 1520572 Summary: Review Request: perl-Authen-DecHpwd - DEC VMS password 
hashing
https://bugzilla.redhat.com/show_bug.cgi?id=1520572

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|ERRATA  |---



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519323] Review request: qesteidutil - Estonian ID card utility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519323



--- Comment #12 from Germano Massullo  ---
(In reply to Fedora Update System from comment #11)
> qdigidoc-3.13.5-1.fc27 has been submitted as an update to Fedora 27.
> https://bodhi.fedoraproject.org/updates/FEDORA-2018-c6419c676b

My fault!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1119197] Review Request: gnushogi - Shogi (Japanese Chess) AI engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1119197



--- Comment #22 from Chen Chen  ---
Spec URL: https://github.com/aflyhorse/gnushogi-spec/raw/master/gnushogi.spec
SRPM URL:
https://www.lunes.faith/SRPMS/gnushogi-1.5-0.3.git5bb0b5b.fc26.src.rpm

No sure why it wants to write .bbk into lib64. Might need to invent a patch to
move it into share or generate into user's home.
BTW. Moved to Github in order to get a permanent direct link.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1543334] New: Review Request: python-xmlsec - Python bindings for the XML Security Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1543334

Bug ID: 1543334
   Summary: Review Request:  python-xmlsec - Python bindings for
the XML Security Library
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: jer...@jcline.org
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://jcline.fedorapeople.org/python-xmlsec.spec
SRPM URL: https://jcline.fedorapeople.org/python-xmlsec-1.3.3-1.fc28.src.rpm
Description: Python bindings for the XML Security Library.

Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=24832835
FAS name: jcline

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1481630] Review Request: virtualbox-guest-additions - VirtualBox Guest Additions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481630



--- Comment #64 from Hans de Goede  ---
(In reply to Sergio Monteiro Basto from comment #63)
> But , shared folder will work ? 

See comment 58.

> but this will be ready for 4.16-rc1 ? i.e. or we will still need vboxsf.ko
> from akmod-VirtualBox ? 

4.16-rc1 will not contain a vboxsf, I hope to get another review to my upstream
submission of vboxsf soon and then hopefully get it into -next, after which I
can add it as a downstream patch to the Fedora kernels.

> you can use /usr/lib/modules-load.d/VirtualBox-guest.conf only with vboxsf
> and still Requires:   %{name}-kmod = %{version}

1) I cannot add a Requires to a Fedora package on something which is in
rpmfusion
2) The vbox guest-additions bundled version will not work with the mainline
vboxguest driver

I suggest we simply wait a bit to see how the upstreaming process of vboxsf
goes, I don't expect many users to be running rawhide inside vbox. Plan A. is
still for vboxsf.ko to be part of the Fedora kernels for rawhide/F28.

If that falls through the floor plan B is that I will do a standalone /
out-of-tree version of my version of vboxsf (which works with the mainline
vboxguest driver) and you can put that in the akmod for F28+ and users who want
the shared-folder functionality can install the akmod (you can even use
enhances to make this automatic).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1520568] Review Request: perl-Crypt-MySQL - Emulate MySQL PASSWORD() function

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520568

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|ERRATA  |---
   Keywords||Reopened



--- Comment #12 from Fedora Update System  ---
perl-Crypt-MySQL-0.04-1.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-4abaf72a99

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1520569] Review Request: perl-Crypt-UnixCrypt_XS - Perl xs interface for a portable traditional crypt function

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520569
Bug 1520569 depends on bug 1522917, which changed state.

Bug 1522917 Summary: Review Request: perl-Algorithm-Loops - Perl module for 
looping constructs
https://bugzilla.redhat.com/show_bug.cgi?id=1522917

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|ERRATA  |---



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1520572] Review Request: perl-Authen-DecHpwd - DEC VMS password hashing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520572

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|ERRATA  |---
   Keywords||Reopened



--- Comment #16 from Fedora Update System  ---
perl-Authen-DecHpwd-2.007-1.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-5480df179b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1520571] Review Request: perl-Data-Integer - Details of the native integer data type

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520571

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|ERRATA  |---
   Keywords||Reopened



--- Comment #16 from Fedora Update System  ---
perl-Data-Integer-0.006-1.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-ea8e5d2eb5

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1520572] Review Request: perl-Authen-DecHpwd - DEC VMS password hashing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520572
Bug 1520572 depends on bug 1520570, which changed state.

Bug 1520570 Summary: Review Request: perl-Scalar-String - String aspects of 
scalars
https://bugzilla.redhat.com/show_bug.cgi?id=1520570

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|ERRATA  |---



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1520581] Review Request: perl-Authen-Passphrase - Hashed passwords/ passphrases as objects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520581
Bug 1520581 depends on bug 1520568, which changed state.

Bug 1520568 Summary: Review Request: perl-Crypt-MySQL - Emulate MySQL 
PASSWORD() function
https://bugzilla.redhat.com/show_bug.cgi?id=1520568

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|ERRATA  |---



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1520572] Review Request: perl-Authen-DecHpwd - DEC VMS password hashing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520572
Bug 1520572 depends on bug 1520571, which changed state.

Bug 1520571 Summary: Review Request: perl-Data-Integer - Details of the native 
integer data type
https://bugzilla.redhat.com/show_bug.cgi?id=1520571

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|ERRATA  |---



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1520581] Review Request: perl-Authen-Passphrase - Hashed passwords/ passphrases as objects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520581
Bug 1520581 depends on bug 1520569, which changed state.

Bug 1520569 Summary: Review Request: perl-Crypt-UnixCrypt_XS - Perl xs 
interface for a portable traditional crypt function
https://bugzilla.redhat.com/show_bug.cgi?id=1520569

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|ERRATA  |---



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1520570] Review Request: perl-Scalar-String - String aspects of scalars

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520570

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|ERRATA  |---
   Keywords||Reopened



--- Comment #13 from Fedora Update System  ---
perl-Scalar-String-0.003-1.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-6c82f2d57f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1522917] Review Request: perl-Algorithm-Loops - Perl module for looping constructs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1522917

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|ERRATA  |---
   Keywords||Reopened



--- Comment #14 from Fedora Update System  ---
perl-Algorithm-Loops-1.032-1.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-d314769f44

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1520569] Review Request: perl-Crypt-UnixCrypt_XS - Perl xs interface for a portable traditional crypt function

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520569

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|ERRATA  |---
   Keywords||Reopened



--- Comment #15 from Fedora Update System  ---
perl-Crypt-UnixCrypt_XS-0.11-2.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-095c3b7f59

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1542807] Review Request: gap-pkg-toric - Computations with toric varieties in GAP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1542807

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #5 from Fedora Update System  ---
gap-pkg-toric-1.9.4-1.fc27 has been pushed to the Fedora 27 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-9f95eb3e80

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519323] Review request: qesteidutil - Estonian ID card utility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519323



--- Comment #11 from Fedora Update System  ---
qdigidoc-3.13.5-1.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-c6419c676b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519323] Review request: qesteidutil - Estonian ID card utility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519323

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1119197] Review Request: gnushogi - Shogi (Japanese Chess) AI engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1119197



--- Comment #24 from Chen Chen  ---
Spec URL: https://github.com/aflyhorse/gnushogi-spec/raw/master/gnushogi.spec
SRPM URL:
https://www.lunes.faith/SRPMS/gnushogi-1.5-0.4.git5bb0b5b.fc26.src.rpm
Koji URL: https://koji.fedoraproject.org/koji/taskinfo?taskID=24862124

I need some time to prepare for lib patch. spec is modified as requested.
As this is probably the final commitment, package is also submitted on koji.

Online diff:
https://github.com/aflyhorse/gnushogi-spec/commit/ce0bcae2da6118ea036ca5756911c1984b2e96ee

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1130199] Review Request: kyua - Testing framework for infrastructure software

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1130199

Igor Gnatenko  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-02-08 12:52:49



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1543060] Review Request: php-phpunit-dbunit4 - Extension for database interaction testing for PHPUnit 7

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1543060



--- Comment #5 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/php-phpunit-dbunit4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1542931] Review Request: cri-tools - CLI and validation tools for Container Runtime Interface

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1542931



--- Comment #4 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/cri-tools. You may commit to the branch
"f27" in about 10 minutes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1542663] Review Request: bitlbee-discord - Bitlbee plugin for Discord

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1542663



--- Comment #4 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/bitlbee-discord

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1543060] Review Request: php-phpunit-dbunit4 - Extension for database interaction testing for PHPUnit 7

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1543060

Remi Collet  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-02-08 09:12:24



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1543377] New: Review Request: python3-saml - Add SAML support to your Python software using this library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1543377

Bug ID: 1543377
   Summary: Review Request: python3-saml - Add SAML support to
your Python software using this library
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: jer...@jcline.org
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



SRPM URL: https://jcline.fedorapeople.org/python3-saml-1.3.0-1.fc28.src.rpm
Spec URL: https://jcline.fedorapeople.org/python3-saml.spec
Description:
This toolkit lets you turn your Python application into a SP
(Service Provider) that can be connected to an IdP (Identity Provider).

FAS name: jcline

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1543334] Review Request: python-xmlsec - Python bindings for the XML Security Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1543334

Jeremy Cline  changed:

   What|Removed |Added

 Blocks||1543377




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1543377
[Bug 1543377] Review Request: python3-saml - Add SAML support to your
Python software using this library
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1543377] Review Request: python3-saml - Add SAML support to your Python software using this library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1543377

Jeremy Cline  changed:

   What|Removed |Added

 Depends On||1543334




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1543334
[Bug 1543334] Review Request:  python-xmlsec - Python bindings for the XML
Security Library
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536852] Review Request: molsketch - Molecular Structures Editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536852



--- Comment #24 from Antonio Trande  ---
- Openbabel features do not work yet.

- ldconfig scriplets are not needed if you install libraries in a private
directory.

- /usr/lib64/molsketch directory is not owned.
  Use the line

%{_libdir}/%{name}/

- You're installing duplicate libraries with devel sub-package

Remove

%{_libdir}/%{name}/lib%{name}*so
%{_libdir}/%{name}/libobabeliface*so

- Diff spec file in url and in SRPM.
  See rpmlint's output.

- Not all headers are installed; see the list below.
  Respect the directories too; for example:

 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/abstractitemaction.h

is installed as

  /usr/include/libmolsketch/actions/abstractitemaction.h

and so on.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

Issues:
===
- Header files in -devel subpackage, if present.
  Note: molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/TextInputItem.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/abstractxmlobject.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/abstractitemaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/abstractrecursiveitemaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/alignmentaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/arrowtypeaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/arrowtypewidget.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/bondtypeaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/bondtypewidget.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/coloraction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/connectaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/deleteaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/drawaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/flipbondaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/flipstereobondsaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/frameaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/frametypeaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/frametypewidget.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/genericaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/incdecaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/itemgrouptypeaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/itemtypeaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/itemtypeselectionaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/itemtypewidget.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/linewidthaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/mechanismarrowaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/multiaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/periodictablewidget.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/reactionarrowaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/ringaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/rotateaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/textaction.h
  molsketch-debugsource :
 
/usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/actions/transformcommand.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/arrow.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/arrowpopup.h
  molsketch-debugsource :
  /usr/src/debug/molsketch-0.5.1-5.fc28.x86_64/libmolsketch/atom.h
  

[Bug 1532042] Review Request: compton - Compositor for X11

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532042



--- Comment #8 from Abhiram K <4kuch...@gmail.com> ---
Made the suggested changes, please find the new links down below:

SPEC URL:
https://copr-be.cloud.fedoraproject.org/results/axeld/compton/fedora-27-x86_64/00712261-compton/compton.spec

SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/axeld/compton/fedora-27-x86_64/00712261-compton/compton-0.1_beta3-0.1_beta3.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1542931] Review Request: cri-tools - CLI and validation tools for Container Runtime Interface

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1542931



--- Comment #5 from Fedora Update System  ---
cri-tools-1.0.0-2.alpha.0.git653cc8c.fc27 has been submitted as an update to
Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-218e0f9890

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1542931] Review Request: cri-tools - CLI and validation tools for Container Runtime Interface

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1542931

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org