[Bug 1554322] New: Review Request: perl-PerlX-Maybe-XS - XS backend for PerlX::Maybe

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1554322

Bug ID: 1554322
   Summary: Review Request: perl-PerlX-Maybe-XS - XS backend for
PerlX::Maybe
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: ppi...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://ppisar.fedorapeople.org/perl-PerlX-Maybe-XS/perl-PerlX-Maybe-XS.spec
SRPM URL:
https://ppisar.fedorapeople.org/perl-PerlX-Maybe-XS/perl-PerlX-Maybe-XS-1.001-1.fc29.src.rpm
Description:
This is a faster implementation of PerlX::Maybe Perl module.

Fedora Account System Username: ppisar

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1554322] Review Request: perl-PerlX-Maybe-XS - XS backend for PerlX:: Maybe

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1554322

Jitka Plesnikova  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jples...@redhat.com
   Assignee|nob...@fedoraproject.org|jples...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1548761] Review Request: nnn - The missing terminal file browser for X

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1548761

Dridi Boukelmoune  changed:

   What|Removed |Added

 CC||dridi.boukelmo...@gmail.com



--- Comment #8 from Dridi Boukelmoune  ---
Hello Robert-André, would you like to review kcov (bug 1480752) that has been
overtaken by events? In exchange I'd be happy to do a formal review of nnn.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553802] Review Request: gnome-usage - a system resources visualizer for GNOME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553802

Yanko Kaneti  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|yan...@declera.com
  Flags||fedora-review+



--- Comment #4 from Yanko Kaneti  ---
With the license change to GPLv3+ it looks acceptable.

Name sensible
Doesn't conflict.
Builds in mock.
Works in brief testing

APPROVED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553635] Review Request: rust-language-tags - Language tags for Rust

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553635



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-language-tags

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553867] Review Request: python-flask-sphinx-themes - Sphinx themes for Flask and related projects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553867



--- Comment #3 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-flask-sphinx-themes

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553615] Review Request: rust-tokio - Platform for writing asynchronous I/O backed applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553615



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-tokio

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1554322] Review Request: perl-PerlX-Maybe-XS - XS backend for PerlX:: Maybe

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1554322

Jitka Plesnikova  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Jitka Plesnikova  ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-PerlX-Maybe-XS-1.001-1.fc29.x86_64.rpm | sort | uniq
-c
  1 libc.so.6()(64bit)
  1 libc.so.6(GLIBC_2.2.5)(64bit)
  1 libc.so.6(GLIBC_2.4)(64bit)
  1 libperl.so.5.26()(64bit)
  1 libpthread.so.0()(64bit)
  1 libpthread.so.0(GLIBC_2.2.5)(64bit)
  1 perl(Exporter)
  1 perl(:MODULE_COMPAT_5.26.1)
  1 perl(strict)
  1 perl(:VERSION) >= 5.8.0
  1 perl(warnings)
  1 perl(XSLoader)
  1 rpmlib(CompressedFileNames) <= 3.0.4-1
  1 rpmlib(FileDigests) <= 4.6.0-1
  1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
  1 rpmlib(PayloadIsXz) <= 5.2-1
  1 rtld(GNU_HASH)
Binary requires are Ok.

$ rpm -qp --provides perl-PerlX-Maybe-XS-1.001-1.fc29.x86_64.rpm | sort | uniq
-c
  1 perl(PerlX::Maybe::XS) = 1.001
  1 perl-PerlX-Maybe-XS = 1.001-1.fc29
  1 perl-PerlX-Maybe-XS(x86-64) = 1.001-1.fc29
Binary provides are Ok.

$ rpmlint ./perl-PerlX-Maybe-XS*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

The package looks good.
Approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553944] Review Request: R-webp - A New Format for Lossless and Lossy Image Compression

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553944



--- Comment #3 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/R-webp

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553802] Review Request: gnome-usage - a system resources visualizer for GNOME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553802



--- Comment #3 from Felipe Borges  ---
Thanks!

I have fixed the license
https://copr-be.cloud.fedoraproject.org/results/feborges/gnome-usage/fedora-28-x86_64/00727071-gnome-usage/gnome-usage.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553967] Review Request: rust-indexmap - Hash table with consistent order and fast iteration

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553967



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-indexmap

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553639] Review Request: rust-hyper - Modern HTTP library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553639



--- Comment #4 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-hyper

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1480752] Review Request: kcov - Code coverage tool without special compilation options

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1480752

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review?



--- Comment #8 from Robert-André Mauchin  ---
 - You forgot that part mentioned by Raphael:

  Create a separate bug for each entry of ExcludeArch and let it block the
  individual tracker.
 
https://fedoraproject.org/wiki/Packaging:Guidelines#Architecture_Build_Failures

 - Remove cmake(dyninst) as upstream recommended

 - Use a more meaningful name for your archive:

Source:
https://github.com/SimonKagstrom/%{name}/archive/v%{version}/%{name}-%{version}.tar.gz

 - kcov.x86_64: E: incorrect-fsf-address /usr/share/licenses/kcov/COPYING

Notify upstream about this



Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated". 209 files have
 unknown license. Detailed output of licensecheck in
 /home/bob/packaging/review/kcov/review-kcov/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
 must be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[-]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the 

[Bug 1549686] Review Request: f28-backgrounds - Fedora 28 default desktop background

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1549686



--- Comment #14 from Adam Williamson  ---
Luya: the question isn't whether the *new* backgrounds are different, of course
they are. The question is whether the backgrounds *currently* in F28 - before
this update - are the same as F27 or F26. And it looks to me like they're the
same as F27:

https://openqa.fedoraproject.org/tests/200929#step/_do_install_and_reboot/31

which would make this a blocker.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553622] Review Request: perl-Gtk3-SimpleList - Simple interface to Gtk3's complex MVC list widget

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553622



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/perl-Gtk3-SimpleList

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1554323] Review Request: perl-PerlX-Maybe - Return a pair only if they are both defined

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1554323

Jitka Plesnikova  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jples...@redhat.com
   Assignee|nob...@fedoraproject.org|jples...@redhat.com
  Flags||fedora-review+



--- Comment #1 from Jitka Plesnikova  ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-PerlX-Maybe-1.001-1.fc29.noarch.rpm | sort | uniq -c
  1 perl(Exporter)
  1 perl(:MODULE_COMPAT_5.26.1)
  1 perl(PerlX::Maybe)
  1 perl(strict)
  1 perl(:VERSION) >= 5.6.0
  1 perl(warnings)
  1 rpmlib(CompressedFileNames) <= 3.0.4-1
  1 rpmlib(FileDigests) <= 4.6.0-1
  1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
  1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-PerlX-Maybe-1.001-1.fc29.noarch.rpm | sort | uniq -c
  1 perl(PerlX::Maybe) = 1.001
  1 perl-PerlX-Maybe = 1.001-1.fc29
  1 perl(Syntax::Feature::Maybe) = 1.001
Binary provides are Ok.

$ rpmlint ./perl-PerlX-Maybe*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

The package looks good.
Approved

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553632] Review Request: perl-GooCanvas2 - Perl binding for GooCanvas2 widget using Glib::Object:: Introspection

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553632



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/perl-GooCanvas2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1554322] Review Request: perl-PerlX-Maybe-XS - XS backend for PerlX:: Maybe

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1554322



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/perl-PerlX-Maybe-XS

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1554322] Review Request: perl-PerlX-Maybe-XS - XS backend for PerlX:: Maybe

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1554322

Petr Pisar  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
   Fixed In Version||perl-PerlX-Maybe-XS-1.001-1
   ||.fc29
 Resolution|--- |RAWHIDE
Last Closed||2018-03-12 10:08:47



--- Comment #3 from Petr Pisar  ---
Thank you for the review and the repository.

I also added a missing dependency on perl-devel.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1554323] Review Request: perl-PerlX-Maybe - Return a pair only if they are both defined

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1554323
Bug 1554323 depends on bug 1554322, which changed state.

Bug 1554322 Summary: Review Request: perl-PerlX-Maybe-XS - XS backend for 
PerlX::Maybe
https://bugzilla.redhat.com/show_bug.cgi?id=1554322

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1551402] Review Request: falkon - Modern web browser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1551402



--- Comment #12 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/falkon

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553967] Review Request: rust-indexmap - Hash table with consistent order and fast iteration

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553967

Igor Gnatenko  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-03-12 09:37:23



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1554323] Review Request: perl-PerlX-Maybe - Return a pair only if they are both defined

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1554323



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/perl-PerlX-Maybe

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1154750] Review Request: mozilla-privacy-badger - Protects your privacy by blocking spying ads and invisible trackers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1154750



--- Comment #20 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/mozilla-privacy-badger

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553615] Review Request: rust-tokio - Platform for writing asynchronous I/O backed applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553615

Igor Gnatenko  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-03-12 09:37:34



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553639] Review Request: rust-hyper - Modern HTTP library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553639
Bug 1553639 depends on bug 1553635, which changed state.

Bug 1553635 Summary: Review Request: rust-language-tags - Language tags for Rust
https://bugzilla.redhat.com/show_bug.cgi?id=1553635

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553635] Review Request: rust-language-tags - Language tags for Rust

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553635

Igor Gnatenko  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-03-12 09:37:28



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553802] Review Request: gnome-usage - a system resources visualizer for GNOME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553802



--- Comment #5 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/gnome-usage

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553622] Review Request: perl-Gtk3-SimpleList - Simple interface to Gtk3's complex MVC list widget

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553622

Petr Pisar  changed:

   What|Removed |Added

 Status|POST|CLOSED
   Fixed In Version||perl-Gtk3-SimpleList-0.17-1
   ||.fc29
 Resolution|--- |RAWHIDE
Last Closed||2018-03-12 09:52:17



--- Comment #3 from Petr Pisar  ---
Thank you for the review and the repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553632] Review Request: perl-GooCanvas2 - Perl binding for GooCanvas2 widget using Glib::Object:: Introspection

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553632

Petr Pisar  changed:

   What|Removed |Added

 Status|POST|CLOSED
   Fixed In Version||perl-GooCanvas2-0.06-1.fc29
 Resolution|--- |RAWHIDE
Last Closed||2018-03-12 09:54:13



--- Comment #3 from Petr Pisar  ---
Thank you for the review and the repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1554376] New: Review Request: gcompris-qt - Educational software suite for children aged 2 to 10

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1554376

Bug ID: 1554376
   Summary: Review Request: gcompris-qt - Educational software
suite for children aged 2 to 10
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: musur...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
http://copr-dist-git.fedorainfracloud.org/cgit/musuruan/gcompris-qt/gcompris-qt.git/plain/gcompris-qt.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/musuruan/gcompris-qt/fedora-rawhide-x86_64/00713329-gcompris-qt/gcompris-qt-0.81-2.fc28.src.rpm

Description:
GCompris-Qt is an educational software suite comprising
of numerous activities for children aged 2 to 10. Some of the
activities are game orientated, but nonetheless still educational.

Currently, GCompris offers in excess of 100 activities. New
activities can be added, and an activity can implement its own game
scheme.

This version is a rewrite of GCompris using the QtQuick
technology.

Fedora Account System Username: musuruan

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553447] Review Request: python-backoff - Python library providing function decorators for configurable backoff and retry

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553447

Randy Barlow  changed:

   What|Removed |Added

   Fixed In Version||python-backoff-1.4.3-1.fc29



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553999] Review Request: cava - console-based audio visualizer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553999



--- Comment #5 from Lars Kellogg-Stedman  ---
Spec URL:
https://copr-be.cloud.fedoraproject.org/results/larsks/cava/fedora-27-x86_64/00727165-cava/cava.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/larsks/cava/fedora-27-x86_64/00727165-cava/cava-0.6.0-6.fc27.src.rpm

I've updated the package based on Robert-André's comments.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553447] Review Request: python-backoff - Python library providing function decorators for configurable backoff and retry

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553447



--- Comment #8 from Fedora Update System  ---
python-backoff-1.4.3-1.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-596076c56a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553447] Review Request: python-backoff - Python library providing function decorators for configurable backoff and retry

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553447



--- Comment #7 from Fedora Update System  ---
python-backoff-1.4.3-1.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-f6f04bf6a6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553447] Review Request: python-backoff - Python library providing function decorators for configurable backoff and retry

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553447



--- Comment #9 from Fedora Update System  ---
python-backoff-1.4.3-1.fc28 has been submitted as an update to Fedora 28.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-67cc87c718

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553447] Review Request: python-backoff - Python library providing function decorators for configurable backoff and retry

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553447

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1507103] Review Request: kronosnet - Multipoint-to-Multipoint network abstraction layer for High Availability applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1507103

Jan Friesse  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #86 from Jan Friesse  ---
Package is ok to go into Fedora.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Scriptlets must be sane, if used.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
 files.
[x]: Reviewer should test that 

[Bug 1553999] Review Request: cava - console-based audio visualizer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553999



--- Comment #6 from Lars Kellogg-Stedman  ---
Spec URL:
https://copr-be.cloud.fedoraproject.org/results/larsks/cava/fedora-27-x86_64/00727168-cava/cava.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/larsks/cava/fedora-27-x86_64/00727168-cava/cava-0.6.0-7.fc27.src.rpm

While testing the previous fixes I realized that a typo had crept into the URL
field.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1554323] Review Request: perl-PerlX-Maybe - Return a pair only if they are both defined

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1554323

Petr Pisar  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
   Fixed In Version||perl-PerlX-Maybe-1.001-1.fc
   ||29
 Resolution|--- |RAWHIDE
Last Closed||2018-03-12 11:10:18



--- Comment #3 from Petr Pisar  ---
Thank you for the review and the repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553802] Review Request: gnome-usage - a system resources visualizer for GNOME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553802



--- Comment #6 from Fedora Update System  ---
gnome-usage-3.27.92-1.fc28 has been submitted as an update to Fedora 28.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-4a37f53893

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553802] Review Request: gnome-usage - a system resources visualizer for GNOME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553802

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1554033] Review Request: rubygem-em-websocket-client - EventMachine WebSocket Client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1554033



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rubygem-em-websocket-client

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553447] Review Request: python-backoff - Python library providing function decorators for configurable backoff and retry

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553447



--- Comment #3 from Randy Barlow  ---
(In reply to Robert-André Mauchin from comment #2)
> It seens to also be compatible with python 2, you don't want to provide the
> Py2 package?

I don't for two reasons:

0. According to the FPC, Python 2 packaging is now optional. My opinion is that
   we additionally don't want to encourage additional potential dependencies on
   Python 2 packages.
1. The upstream package says it supports Python 2, but that's only if you use
   setup.py install. Fedora additionally runs bytecompiling on all .py files,
and
   this project includes some .py files that have invalid syntax for Python 2:

   https://github.com/litl/backoff/blob/v1.4.3/backoff/_async.py#L3

   In order to get this package built for Python 2, I would have to do some
   patching to remove all non-Python 2 compatible code so that Fedora's byte
   compiling will succeed. Due to 0., I would rather not expend this effort.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553447] Review Request: python-backoff - Python library providing function decorators for configurable backoff and retry

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553447



--- Comment #5 from Randy Barlow  ---
Thanks!

https://pagure.io/releng/fedora-scm-requests/issue/4978

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553447] Review Request: python-backoff - Python library providing function decorators for configurable backoff and retry

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553447



--- Comment #6 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-backoff

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1554323] Review Request: perl-PerlX-Maybe - Return a pair only if they are both defined

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1554323

Petr Pisar  changed:

   What|Removed |Added

 Blocks||1554155
 Depends On||1554322




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1554155
[Bug 1554155] perl-Dancer-Session-Cookie-0.30 is available
https://bugzilla.redhat.com/show_bug.cgi?id=1554322
[Bug 1554322] Review Request: perl-PerlX-Maybe-XS - XS backend for
PerlX::Maybe
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1554323] New: Review Request: perl-PerlX-Maybe - Return a pair only if they are both defined

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1554323

Bug ID: 1554323
   Summary: Review Request: perl-PerlX-Maybe - Return a pair only
if they are both defined
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: ppi...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://ppisar.fedorapeople.org/perl-PerlX-Maybe/perl-PerlX-Maybe.spec
SRPM URL:
https://ppisar.fedorapeople.org/perl-PerlX-Maybe/perl-PerlX-Maybe-1.001-1.fc29.src.rpm
Description:
This Perl module provides a syntax sugar for passing a pair of variables only
if both of them match some criteria (to be defined usually).

Fedora Account System Username: ppisar

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1554322] Review Request: perl-PerlX-Maybe-XS - XS backend for PerlX:: Maybe

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1554322

Petr Pisar  changed:

   What|Removed |Added

 Blocks||1554323




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1554323
[Bug 1554323] Review Request: perl-PerlX-Maybe - Return a pair only if they
are both defined
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1550685] Review Request: python-cookiecutter - CLI utility to create projects from templates

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1550685



--- Comment #7 from Brett Lentz  ---
All dependencies are now packaged. The RPM builds, complete with docs and
tests.

SPEC & SRPM URLs from Comment #1 are updated.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553447] Review Request: python-backoff - Python library providing function decorators for configurable backoff and retry

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553447

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #4 from Robert-André Mauchin  ---
Package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1554029] Review Request: rubygem-em-http-request - EventMachine based , async HTTP Request client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1554029



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rubygem-em-http-request

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1549686] Review Request: f28-backgrounds - Fedora 28 default desktop background

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1549686

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2018-03-12 18:36:38



--- Comment #16 from Fedora Update System  ---
desktop-backgrounds-28.0.0-1.fc28, f28-backgrounds-28.1.0-1.fc28 has been
pushed to the Fedora 28 stable repository. If problems still persist, please
make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553944] Review Request: R-webp - A New Format for Lossless and Lossy Image Compression

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553944



--- Comment #6 from Fedora Update System  ---
R-webp-0.4-1.fc28 has been submitted as an update to Fedora 28.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-14b9b05004

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1500958] Review Request: python-kiwi-gtk - Framework for Python GUI applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1500958

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483339] Review Request: kiwi - A flexible operating system image builder

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483339



--- Comment #14 from Neal Gompa  ---
There's nothing else blocking this package. `python-kiwi` has been retired, and
`python-kiwi-gtk` is submitted as an update:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-83f7373a17

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553999] Review Request: cava - console-based audio visualizer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553999



--- Comment #8 from Lars Kellogg-Stedman  ---
Spec URL:
https://copr-be.cloud.fedoraproject.org/results/larsks/cava/fedora-27-x86_64/00727290-cava/cava.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/larsks/cava/fedora-27-x86_64/00727290-cava/cava-0.6.0-8.fc27.src.rpm

I have corrected the tabs/spaces issue. Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1500958] Review Request: python-kiwi-gtk - Framework for Python GUI applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1500958



--- Comment #13 from Fedora Update System  ---
python-kiwi-gtk-1.11.1-1.fc28 flumotion-0.11.0.1-9.20140103git886031a.fc28 has
been submitted as an update to Fedora 28.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-83f7373a17

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1550685] Review Request: python-cookiecutter - CLI utility to create projects from templates

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1550685

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #8 from Robert-André Mauchin  ---
Package approved.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD (3 clause)", "*No copyright* Apache (v2.0) BSD
 (unspecified)", "Unknown or generated". 204 files have unknown
 license. Detailed output of licensecheck in /home/bob/packaging/review
 /python-cookiecutter/review-python-cookiecutter/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: Uses parallel make %{?_smp_mflags} macro.
[-]: Avoid bundling fonts in non-fonts packages.
 Note: Package contains font files
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
 python2-cookiecutter , python3-cookiecutter
[-]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: 

[Bug 1553999] Review Request: cava - console-based audio visualizer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553999

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #7 from Robert-André Mauchin  ---

 - Don't mix tabs and spaces:

cava.src:15: W: mixed-use-of-spaces-and-tabs (spaces: line 15, tab: line 1)

   i.e.:

BuildRequires:iniparser-devel


Package otherwise approved.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated". 35 files have
 unknown license. Detailed output of licensecheck in
 /home/bob/packaging/review/cava/review-cava/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by: /usr/share/consolefonts
 (console-setup, cmatrix)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 30720 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.

[Bug 1551107] Review Request: nulib2 - Disk and file archive program for NuFX (.SDK, .BXY) archives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1551107

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1551107] Review Request: nulib2 - Disk and file archive program for NuFX (.SDK, .BXY) archives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1551107



--- Comment #7 from Fedora Update System  ---
nulib2-3.1.0-1.fc28 has been submitted as an update to Fedora 28.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-6183a6af8a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1328248] Review Request: python-pysword - Python bindings to read Sword bible files directly

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1328248



--- Comment #15 from Robert-André Mauchin  ---
(In reply to TR Bentley from comment #13)
> I only want a python3 version.
> Do you have an example of a spec file as I am very confused as this is based
> on other packages I have found.

As Itamar said or look at
https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file Just
don't add the python2 subpackage.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553944] Review Request: R-webp - A New Format for Lossless and Lossy Image Compression

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553944



--- Comment #5 from Fedora Update System  ---
R-webp-0.4-1.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-14ddb81795

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553944] Review Request: R-webp - A New Format for Lossless and Lossy Image Compression

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553944

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1553944] Review Request: R-webp - A New Format for Lossless and Lossy Image Compression

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1553944



--- Comment #4 from Fedora Update System  ---
R-webp-0.4-1.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-fb0761b64c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1550740] Review request: webextension-token-signing - Firefox extension for signing with your eID on the web

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1550740



--- Comment #17 from Germano Massullo  ---
Some new infos

https://lists.fedoraproject.org/archives/list/de...@lists.fedoraproject.org/message/APKC62MK7GDMDSGIQ6LITVHH2IULK7KZ/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1554033] Review Request: rubygem-em-websocket-client - EventMachine WebSocket Client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1554033

Jaroslav Prokop  changed:

   What|Removed |Added

 Status|POST|CLOSED
   Fixed In Version||rubygem-em-websocket-client
   ||-0.1.2-1.fc29
 Resolution|--- |RAWHIDE
Last Closed||2018-03-12 16:43:27



--- Comment #3 from Jaroslav Prokop  ---
Thanks for the review!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1554376] Review Request: gcompris-qt - Educational software suite for children aged 2 to 10

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1554376

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review?



--- Comment #1 from Robert-André Mauchin  ---
 - Use cmake goodies for your dependencies:

BuildRequires:  cmake
BuildRequires:  extra-cmake-modules
BuildRequires:  cmake(Qt5Qml)
BuildRequires:  cmake(Qt5Quick)
BuildRequires:  cmake(Qt5Gui)
BuildRequires:  cmake(Qt5Multimedia)
BuildRequires:  cmake(Qt5Core)
BuildRequires:  cmake(Qt5Svg)
BuildRequires:  cmake(Qt5Xml)
BuildRequires:  cmake(Qt5XmlPatterns)
BuildRequires:  cmake(Qt5LinguistTools)
BuildRequires:  cmake(Qt5Sensors)
BuildRequires:  gettext
BuildRequires:  desktop-file-utils
BuildRequires:  libappstream-glib

 - Got various CC-BY and CC-BY-SA, also one MPL 2.0 and SIL for the fonts

*No copyright* CC by (v2.0)
---
gcompris-qt-0.81/src/activities/categorization/resource/images/others/README
gcompris-qt-0.81/src/activities/categorization/resource/images/renewable/README
gcompris-qt-0.81/src/activities/categorization/resource/images/tools/README

*No copyright* CC by (v3.0)
---
gcompris-qt-0.81/src/activities/explore_world_animals/resource/animals/README

*No copyright* CC0
--
gcompris-qt-0.81/src/activities/target/resource/README

*No copyright* GPL
--
gcompris-qt-0.81/src/activities/erase/resource/README
gcompris-qt-0.81/src/activities/paintings/resource/image/README

*No copyright* MPL (v2.0)
-
gcompris-qt-0.81/src/activities/checkers/LICENSE

*No copyright* Public domain

gcompris-qt-0.81/src/activities/chess/engine.js

CC by (v2.0)

gcompris-qt-0.81/src/activities/categorization/resource/images/fishes/README
gcompris-qt-0.81/src/activities/categorization/resource/images/monuments/README

CC by (v2.5)

gcompris-qt-0.81/src/activities/paintings/resource/image/Michelangelo_Pieta_a1.png
gcompris-qt-0.81/src/activities/paintings/resource/image/Michelangelo_Pieta_a2.png
gcompris-qt-0.81/src/activities/paintings/resource/image/Michelangelo_Pieta_a3.png
gcompris-qt-0.81/src/activities/paintings/resource/image/Michelangelo_Pieta_a4.png
gcompris-qt-0.81/src/activities/paintings/resource/image/Michelangelo_Pieta_b1.png
gcompris-qt-0.81/src/activities/paintings/resource/image/Michelangelo_Pieta_b2.png
gcompris-qt-0.81/src/activities/paintings/resource/image/Michelangelo_Pieta_b3.png
gcompris-qt-0.81/src/activities/paintings/resource/image/Michelangelo_Pieta_b4.png
gcompris-qt-0.81/src/activities/paintings/resource/image/Michelangelo_Pieta_c1.png
gcompris-qt-0.81/src/activities/paintings/resource/image/Michelangelo_Pieta_c2.png
gcompris-qt-0.81/src/activities/paintings/resource/image/Michelangelo_Pieta_c3.png
gcompris-qt-0.81/src/activities/paintings/resource/image/Michelangelo_Pieta_c4.png

CC by (v3.0)

gcompris-qt-0.81/src/core/resource/fonts/OpenDyslexic-Regular.otf
gcompris-qt-0.81/src/core/resource/fonts/README-OpenDyslexic.txt

CC by-sa

gcompris-qt-0.81/src/core/resource/README

CC by-sa (v3.0)
---
gcompris-qt-0.81/src/activities/drawletters/resource/README
gcompris-qt-0.81/src/activities/drawnumbers/resource/README

CC by-sa (v4.0)
---
gcompris-qt-0.81/src/activities/README
gcompris-qt-0.81/src/activities/algebra_by/resource/README
gcompris-qt-0.81/src/activities/algorithm/resource/README
gcompris-qt-0.81/src/activities/align4-2players/resource/README
gcompris-qt-0.81/src/activities/babymatch/resource/README
gcompris-qt-0.81/src/activities/balancebox/resource/README
gcompris-qt-0.81/src/activities/ballcatch/resource/README
gcompris-qt-0.81/src/activities/bargame/resource/README
gcompris-qt-0.81/src/activities/braille_alphabets/resource/README
gcompris-qt-0.81/src/activities/braille_fun/resource/README
gcompris-qt-0.81/src/activities/canal_lock/resource/README
gcompris-qt-0.81/src/activities/categorization/resource/README
gcompris-qt-0.81/src/activities/categorization/resource/images/alphabets/README
gcompris-qt-0.81/src/activities/categorization/resource/images/numbers/README
gcompris-qt-0.81/src/activities/checkers/resource/README
gcompris-qt-0.81/src/activities/chess/resource/README
gcompris-qt-0.81/src/activities/click_on_letter/resource/README
gcompris-qt-0.81/src/activities/clockgame/resource/README
gcompris-qt-0.81/src/activities/color_mix/resource/README
gcompris-qt-0.81/src/activities/crane/resource/README
gcompris-qt-0.81/src/activities/crane/resource/letters/README
gcompris-qt-0.81/src/activities/fifteen/resource/README

[Bug 1554029] Review Request: rubygem-em-http-request - EventMachine based , async HTTP Request client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1554029

Jaroslav Prokop  changed:

   What|Removed |Added

 Status|POST|CLOSED
   Fixed In Version||rubygem-em-http-request-1.1
   ||.5-1.fc29
 Resolution|--- |RAWHIDE
Last Closed||2018-03-12 16:49:03



--- Comment #3 from Jaroslav Prokop  ---
Thanks for the review!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1549686] Review Request: f28-backgrounds - Fedora 28 default desktop background

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1549686

Geoffrey Marr  changed:

   What|Removed |Added

 CC||gm...@redhat.com
 Blocks|1469205 |1469204
   |(BetaFreezeException,F28Bet |(BetaBlocker,F28BetaBlocker
   |aFreezeException)   |)
 Whiteboard||AcceptedBlocker



--- Comment #15 from Geoffrey Marr  ---
Discussed during the 2018-03-12 blocker review meeting: [1]

The decision to classify this bug as an AcceptedBlocker was made as it violates
the following blocker criteria:

"The default desktop background must be different from that of the last two
stable releases"

[1]
https://meetbot-raw.fedoraproject.org/fedora-blocker-review/2018-03-12/f28-blocker-review.2018-03-12-16.01.txt


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1469204
[Bug 1469204] Fedora 28 Beta blocker bug tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1469205
[Bug 1469205] Fedora 28 Beta freeze exception bug tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org