Re: [nick@unfortu.net: [PATCH] MANIFEST.SKIP]
On Wed, 30 Jan 2002, Steve Fink wrote: On Wed, Jan 30, 2002 at 09:32:45PM +, Nicholas Clark wrote: Should I add classes/array.c classes/array.h docs/embed.pod docs/io_ops.pod to MANIFEST? *.pod, yes. classes/*.[ch], no. Autogenerated. Erm, io_ops.pod is also autogenerated, the same way that core_ops.pod is. embed.pod should go in, though. Simon
[COMMIT] Re: [nick@unfortu.net: [PATCH] MANIFEST.SKIP]
On Fri, Feb 01, 2002 at 11:06:30AM +, Simon Glover wrote: On Wed, 30 Jan 2002, Steve Fink wrote: On Wed, Jan 30, 2002 at 09:32:45PM +, Nicholas Clark wrote: Should I add classes/array.c classes/array.h docs/embed.pod docs/io_ops.pod to MANIFEST? *.pod, yes. classes/*.[ch], no. Autogenerated. Erm, io_ops.pod is also autogenerated, the same way that core_ops.pod is. embed.pod should go in, though. Thanks. I spotted io_ops.pod, and that was in the MANIFEST.SKIP that I committed before I went to bed. (Hmm. Arguably a bad time to commit) $ make manitest /usr/local/bin/perl -MExtUtils::Manifest=fullcheck -e fullcheck Not in MANIFEST: docs/embed.pod Not in MANIFEST: t/op/ifunless.t So I've just commited this: --- MANIFEST~ Fri Feb 1 01:36:48 2002 +++ MANIFESTFri Feb 1 13:18:39 2002 @@ -33,6 +33,7 @@ core.ops disassemble.pl docs/Makefile.in +docs/embed.pod docs/intro.pod docs/jit.pod docs/overview.pod @@ -228,6 +229,7 @@ t/op/hacks.t t/op/integer.t t/op/interp.t +t/op/ifunless.t t/op/macro.t t/op/number.t t/op/rx.t Nicholas Clark -- EMCFT http://www.ccl4.org/~nick/CV.html
Re: [nick@unfortu.net: [PATCH] MANIFEST.SKIP]
On Mon, Jan 28, 2002 at 08:13:11PM +, Nicholas Clark wrote: Is a MANIFEST.SKIP a good idea, even if Configure.pl doesn't check it by default? Revised patch. Any objections? [Either express objections or remove my commit privs else it goes in in 24 hours :-)] You can now do: nick@thinking-cap maniskip$ make manitest perl14405-32 -MExtUtils::Manifest=fullcheck -e fullcheck Not in MANIFEST: Configure.pl.rej Not in MANIFEST: MANIFEST.SKIP.orig Not in MANIFEST: MANIFEST.SKIP~ Not in MANIFEST: MANIFEST.orig Not in MANIFEST: Makefile.in.orig Not in MANIFEST: Makefile.in~ Not in MANIFEST: classes/array.c Not in MANIFEST: classes/array.h Not in MANIFEST: docs/embed.pod Not in MANIFEST: docs/io_ops.pod Not in MANIFEST: newpatch Not in MANIFEST: patch Should I add classes/array.c classes/array.h docs/embed.pod docs/io_ops.pod to MANIFEST? Nicholas Clark --- MANIFEST.orig Wed Jan 30 17:33:48 2002 +++ MANIFESTWed Jan 30 21:01:47 2002 @@ -4,6 +4,7 @@ KNOWN_ISSUES LICENSES/Artistic MANIFEST +MANIFEST.SKIP Makefile.in NEWS README --- Makefile.in.origWed Jan 30 10:31:28 2002 +++ Makefile.in Wed Jan 30 21:10:17 2002 @@ -408,6 +408,8 @@ reconfig: $(MAKE) clean; $(PERL) Configure.pl --reconfig +manitest: + $(PERL) -MExtUtils::Manifest=fullcheck -e fullcheck ### # --- /dev/null Wed Jan 30 19:14:25 2002 +++ MANIFEST.SKIP Wed Jan 30 21:05:44 2002 @@ -0,0 +1,53 @@ +\.o$ +^\.cvsignore$ +/\.cvsignore$ +CVS/[^/]+$ +^include/parrot/config\.h$ +^include/parrot/platform\.h$ +^Makefile$ +/Makefile$ +^lib/Parrot/Types\.pm$ +^lib/Parrot/Config\.pm$ +^platform\.c$ +^config.opt$ + +^vtable\.ops$ +^include/parrot/vtable\.h$ +^include/parrot/jit_struct\.h$ +^include/parrot/oplib/core_ops\.h$ +^include/parrot/oplib/core_ops_prederef\.h$ + +^core_ops\.c$ +^core_ops_prederef\.c$ +^vtable_ops\.c$ + +^lib/Parrot/Jit\.pm$ +^lib/Parrot/PMC\.pm$ +^lib/Parrot/OpLib/core\.pm$ + +^classes/default\.h$ +^classes/default\.c$ +^classes/intqueue\.h$ +^classes/intqueue\.c$ +^classes/parrotpointer\.h$ +^classes/parrotpointer\.c$ +^classes/perlarray\.h$ +^classes/perlarray\.c$ +^classes/perlhash\.h$ +^classes/perlhash\.c$ +^classes/perlint\.h$ +^classes/perlint\.c$ +^classes/perlnum\.h$ +^classes/perlnum\.c$ +^classes/perlstring\.h$ +^classes/perlstring\.c$ +^classes/perlundef\.h$ +^classes/perlundef\.c$ + +^docs/packfile-c\.pod$ +^docs/packfile-perl\.pod$ +^docs/core_ops\.pod$ + +^test_parrot$ +^pdump$ +^blib/
Re: [nick@unfortu.net: [PATCH] MANIFEST.SKIP]
On Wed, Jan 30, 2002 at 09:32:45PM +, Nicholas Clark wrote: You can now do: nick@thinking-cap maniskip$ make manitest perl14405-32 -MExtUtils::Manifest=fullcheck -e fullcheck Not in MANIFEST: Configure.pl.rej Not in MANIFEST: MANIFEST.SKIP.orig Not in MANIFEST: MANIFEST.SKIP~ Not in MANIFEST: MANIFEST.orig Not in MANIFEST: Makefile.in.orig Not in MANIFEST: Makefile.in~ Not in MANIFEST: classes/array.c Not in MANIFEST: classes/array.h Not in MANIFEST: docs/embed.pod Not in MANIFEST: docs/io_ops.pod Not in MANIFEST: newpatch Not in MANIFEST: patch Should I add classes/array.c classes/array.h docs/embed.pod docs/io_ops.pod to MANIFEST? *.pod, yes. classes/*.[ch], no. Autogenerated.
Re: [nick@unfortu.net: [PATCH] MANIFEST.SKIP]
On Wed, Jan 30, 2002 at 02:55:54PM -0800, Steve Fink wrote: On Wed, Jan 30, 2002 at 09:32:45PM +, Nicholas Clark wrote: You can now do: nick@thinking-cap maniskip$ make manitest perl14405-32 -MExtUtils::Manifest=fullcheck -e fullcheck Not in MANIFEST: Configure.pl.rej Not in MANIFEST: MANIFEST.SKIP.orig Not in MANIFEST: MANIFEST.SKIP~ Not in MANIFEST: MANIFEST.orig Not in MANIFEST: Makefile.in.orig Not in MANIFEST: Makefile.in~ Not in MANIFEST: classes/array.c Not in MANIFEST: classes/array.h Not in MANIFEST: docs/embed.pod Not in MANIFEST: docs/io_ops.pod Not in MANIFEST: newpatch Not in MANIFEST: patch Should I add classes/array.c classes/array.h docs/embed.pod docs/io_ops.pod to MANIFEST? *.pod, yes. classes/*.[ch], no. Autogenerated. Ah. This suggests that this bit of the proposed MANIFEST.SKIP: ^classes/default\.h$ ^classes/default\.c$ ^classes/intqueue\.h$ ^classes/intqueue\.c$ ^classes/parrotpointer\.h$ ^classes/parrotpointer\.c$ ^classes/perlarray\.h$ ^classes/perlarray\.c$ ^classes/perlhash\.h$ ^classes/perlhash\.c$ ^classes/perlint\.h$ ^classes/perlint\.c$ ^classes/perlnum\.h$ ^classes/perlnum\.c$ ^classes/perlstring\.h$ ^classes/perlstring\.c$ ^classes/perlundef\.h$ ^classes/perlundef\.c$ becomes ^classes/.*\.[ch]$ Is it valid to assume that the only .h and .c files in classes/ are autogenerated? Nicholas Clark -- EMCFT http://www.ccl4.org/~nick/CV.html
Re: [nick@unfortu.net: [PATCH] MANIFEST.SKIP]
On Wed, Jan 30, 2002 at 11:20:28PM +, Nicholas Clark wrote: On Wed, Jan 30, 2002 at 02:55:54PM -0800, Steve Fink wrote: Ah. This suggests that this bit of the proposed MANIFEST.SKIP: ... becomes ^classes/.*\.[ch]$ Is it valid to assume that the only .h and .c files in classes/ are autogenerated? Well, if it isn't, then classes/.cvsignore should be told.
[nick@unfortu.net: [PATCH] MANIFEST.SKIP]
Is a MANIFEST.SKIP a good idea, even if Configure.pl doesn't check it by
default?
Nicholas Clark
- Forwarded message from Nicholas Clark [EMAIL PROTECTED] -
Mailing-List: contact [EMAIL PROTECTED]; run by ezmlm
List-Post: mailto:[EMAIL PROTECTED]
List-Help: mailto:[EMAIL PROTECTED]
List-Unsubscribe: mailto:[EMAIL PROTECTED]
List-Subscribe: mailto:[EMAIL PROTECTED]
To: [EMAIL PROTECTED]
Subject: [PATCH] MANIFEST.SKIP
From: Nicholas Clark [EMAIL PROTECTED]
This patch (context diffs mean that it's atop the Term::ReadLine patch)
adds a check for unexpected files not in the MANIFEST to Configure.pl
I'm not certain that putting the test in Configure.pl is the right place
for it, but I do believe that having an accurate MANIFEST.SKIP and the
ability to run
perl -MExtUtils::Manifest -e ExtUtils::Manifest::fullcheck
(possibly as a Makefile target) is useful.
Currently:
Not in MANIFEST: include/parrot/rxstacks.h
Not in MANIFEST: rxstacks.c
Nicholas Clark
--
ENOCHOCOLATE http://www.ccl4.org/~nick/CV.html
--- /mnt/six/parrot/parrot_readline++/Configure.pl~ Mon Jan 21 17:44:03 2002
+++ Configure.plMon Jan 21 19:48:37 2002
@@ -11,7 +11,7 @@
use Config;
use Getopt::Long;
-use ExtUtils::Manifest qw(manicheck);
+use ExtUtils::Manifest qw(fullcheck);
use File::Copy;
use Term::ReadLine; # The stub is present from earlier than 5.004
use Parrot::BuildUtil;
@@ -810,11 +810,10 @@
#
sub check_manifest {
-print \n;
-my(@missing)=manicheck();
+my($missing,$extra)=fullcheck();
-if(@missing) {
+if(@$missing) {
print END;
Ack, some files were missing! I can't continue running
@@ -838,6 +837,7 @@
if ($term) {
my $type = $term-ReadLine;
print END;
+
Okay, we found everything. Next you'll need to answer
a few questions about your system. You have
${ type} installed, so I'll use that to let
--- /dev/null Mon Jul 16 22:57:44 2001
+++ MANIFEST.SKIP Mon Jan 21 20:13:26 2002
@@ -0,0 +1,52 @@
+\.o$
+^\.cvsignore$
+/\.cvsignore$
+^include/parrot/config\.h$
+^include/parrot/platform\.h$
+^Makefile$
+/Makefile$
+^Parrot/Types\.pm$
+^Parrot/Config\.pm$
+^platform\.c$
+^config.opt$
+
+^vtable\.ops$
+^include/parrot/vtable\.h$
+^include/parrot/jit_struct\.h$
+^include/parrot/oplib/core_ops\.h$
+^include/parrot/oplib/core_ops_prederef\.h$
+
+^core_ops\.c$
+^core_ops_prederef\.c$
+^vtable_ops\.c$
+
+^Parrot/Jit\.pm$
+^Parrot/PMC\.pm$
+^Parrot/OpLib/core\.pm$
+
+^classes/default\.h$
+^classes/default\.c$
+^classes/intqueue\.h$
+^classes/intqueue\.c$
+^classes/parrotpointer\.h$
+^classes/parrotpointer\.c$
+^classes/perlarray\.h$
+^classes/perlarray\.c$
+^classes/perlhash\.h$
+^classes/perlhash\.c$
+^classes/perlint\.h$
+^classes/perlint\.c$
+^classes/perlnum\.h$
+^classes/perlnum\.c$
+^classes/perlstring\.h$
+^classes/perlstring\.c$
+^classes/perlundef\.h$
+^classes/perlundef\.c$
+
+^docs/packfile-c\.pod$
+^docs/packfile-perl\.pod$
+^docs/core_ops\.pod$
+
+^test_parrot$
+^pdump$
+^blib/
--- ../parrot/MANIFEST Mon Jan 21 16:42:17 2002
+++ MANIFESTMon Jan 21 19:34:16 2002
@@ -3,6 +3,7 @@
Configure.pl
KNOWN_ISSUES
MANIFEST
+MANIFEST.SKIP
Makefile.in
NEWS
Parrot/Assembler.pm
- End forwarded message -
