[perl #47560] [BUG]: 'make realclean' not exiting cleanly

2007-11-27 Thread James Keenan via RT
The immediate storm has passed, though I long for a better long-term
solution.  Resolving this ticket.


Re: [perl #47560] [BUG]: 'make realclean' not exiting cleanly

2007-11-18 Thread Bernhard Schmalhofer

James Keenan (via RT) schrieb:
# New Ticket Created by  James Keenan 
# Please include the string:  [perl #47560]
# in the subject line of all future correspondence about this issue. 
# URL: http://rt.perl.org/rt3/Ticket/Display.html?id=47560 



Coke reported this evening that 'make realclean' was not exiting  
cleanly:


08:18 Coke make -C languages realcleanmake[1]: *** No rule to make  
target `realclean'.  Stop.

08:19 Coke (from `make realclean`)

I confirmed this on Darwin which recently had been svn-updated:

make -C languages realclean
make[1]: Entering directory `/Users/jimk/work/parrot/languages'
make[1]: *** No rule to make target `realclean'.  Stop.
make[1]: Leaving directory `/Users/jimk/work/parrot/languages'
make: *** [languages-realclean] Error 2

I called svn update in a sandbox that had not been updated since  
r22850 and got:


Uconfig/gen/makefiles/root.in
Uconfig/gen/makefiles/languages.in
Ulanguages/jako/config/makefiles/root.in
Ulanguages/PIR/config/makefiles/root.in
Ulanguages/APL/config/makefiles/root.in
  

The effect should go away with the next 'perl Configure.pl  svn up'.

The 'realclean' target of Makefile now depends on the new 'realclean' target
of 'languages/Makefile'. The two changes were done atomically in a 
single commit.

That's why I didn't expect this effect.

I assume that the root Makefile was updated by the automatically by
  usr/bin/perl tools/dev/reconfigure.pl --step=gen::makefiles 
--target=Makefile

which didn't look for changes in 'config/gen/makefiles/languages.in'.

I'll take a brief look at reconfigure.pl .


Regards,
 Bernhard


[perl #47560] [BUG]: 'make realclean' not exiting cleanly

2007-11-18 Thread James Keenan via RT
Problem persists, albeit with a different directory as last visited,
with an svn up to r22876.

make -C languages realclean
make[1]: Entering directory `/Users/jimk/work/parrot/languages'
make[1]: *** No rule to make target `realclean'.  Stop.
make[1]: Leaving directory `/Users/jimk/work/parrot/languages'
make: *** [languages-realclean] Error 2



[perl #47560] [BUG]: 'make realclean' not exiting cleanly

2007-11-18 Thread James Keenan via RT
The patch attached reverts changes to config/gen/makefiles/root.in,
config/gen/makefiles/languages.in and
languages/jako/config/makefiles/root.in that appear to be associated
with the recent problems in 'make realclean'.  I applied this patch in
two different sandboxes on two different OSes and it DWIMmed.  It may
not, however, have addressed the original 'jako' problem Bernhard was
looking at.

kid51
Index: config/gen/makefiles/root.in
===
--- config/gen/makefiles/root.in(revision 22876)
+++ config/gen/makefiles/root.in(working copy)
@@ -1282,9 +1282,6 @@
 languages-clean :
$(MAKE) languages clean
 
-languages-realclean :
-   $(MAKE) languages realclean
-
 ###
 #
 # compiler implementation targets:
@@ -1661,7 +1658,7 @@
 $(IMCC_DIR)/*$(O) \
 $(IMCC_DIR)/imcparser.output
 
-realclean : clean languages-realclean
+realclean : clean 
$(RM_RF) \
 $(STICKY_FILES) \
 blib \
Index: config/gen/makefiles/languages.in
===
--- config/gen/makefiles/languages.in   (revision 22876)
+++ config/gen/makefiles/languages.in   (working copy)
@@ -120,8 +120,6 @@
 urm.clean \
 smoke-clean
 
-realclean: \
-jako.realclean
 
 #
 # Language specific targets
@@ -257,8 +255,6 @@
- $(MAKE) jako test
 jako.clean:
- $(MAKE) jako clean
-jako.realclean:
-   - $(MAKE) jako realclean
 
 lisp: lisp.dummy
 lisp.dummy:
Index: languages/jako/config/makefiles/root.in
===
--- languages/jako/config/makefiles/root.in (revision 22876)
+++ languages/jako/config/makefiles/root.in (working copy)
@@ -66,10 +66,6 @@
 clean:
$(RM_F) examples/*.pir examples/*.list t/*.pir
 
-realclean: clean
-   $(RM_F) Makefile
-
-
 over:
@$(MAKE) clean
@$(MAKE) all


[perl #47560] [BUG]: 'make realclean' not exiting cleanly

2007-11-17 Thread via RT
# New Ticket Created by  James Keenan 
# Please include the string:  [perl #47560]
# in the subject line of all future correspondence about this issue. 
# URL: http://rt.perl.org/rt3/Ticket/Display.html?id=47560 


Coke reported this evening that 'make realclean' was not exiting  
cleanly:

08:18 Coke make -C languages realcleanmake[1]: *** No rule to make  
target `realclean'.  Stop.
08:19 Coke (from `make realclean`)

I confirmed this on Darwin which recently had been svn-updated:

make -C languages realclean
make[1]: Entering directory `/Users/jimk/work/parrot/languages'
make[1]: *** No rule to make target `realclean'.  Stop.
make[1]: Leaving directory `/Users/jimk/work/parrot/languages'
make: *** [languages-realclean] Error 2

I called svn update in a sandbox that had not been updated since  
r22850 and got:

Uconfig/gen/makefiles/root.in
Uconfig/gen/makefiles/languages.in
Ulanguages/jako/config/makefiles/root.in
Ulanguages/PIR/config/makefiles/root.in
Ulanguages/APL/config/makefiles/root.in

Here are the 'svn log' outputs for the first 2 of these files:

svn log config/gen/makefiles/root.in | less


r22858 | bernhard | 2007-11-17 14:24:42 -0500 (Sat, 17 Nov 2007) | 3  
lines

#43759: [BUG] realclean leaves files behind
Clean up languages/perl5/Makefile and languages/PIR/Makefile


r22854 | bernhard | 2007-11-17 13:39:14 -0500 (Sat, 17 Nov 2007) | 5  
lines

#43759: [BUG] realclean leaves files behind
Add 'make languages-realclean' and use it for jako.

Get rid of unneeded tabs in jako/Makefile


r22853 | bernhard | 2007-11-17 13:05:04 -0500 (Sat, 17 Nov 2007) | 2  
lines

Make indenting of generated Makefile more consistent.


svn log config/gen/makefiles/languages.in | less


r22854 | bernhard | 2007-11-17 13:39:14 -0500 (Sat, 17 Nov 2007) | 5  
lines

#43759: [BUG] realclean leaves files behind
Add 'make languages-realclean' and use it for jako.

Get rid of unneeded tabs in jako/Makefile


I tried to fix, but I'm not familiar enough with Makefiles to do it  
quickly.

Barney, looks like this is your baby.  Can you take a look?

Thank you very much.
kid51