Re: [pgAdmin4][Patch]: RM-2859: Can't create new user

[Dave Page]

Thanks, patch applied!

On Tue, Nov 28, 2017 at 11:22 AM, Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:

> Hi Dave,
>
> Please find the attached updated patch, which includes:
>
> - The fix for this RM
> - Close button for the error message, which is applicable globally
>
> Thanks,
> Khushboo
>
> On Tue, Nov 28, 2017 at 4:18 PM, Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>>
>>
>> On Tue, Nov 28, 2017 at 3:40 PM, Dave Page  wrote:
>>
>>>
>>>
>>> On Tue, Nov 28, 2017 at 7:10 AM, Khushboo Vashi <
>>> khushboo.va...@enterprisedb.com> wrote:
>>>


 On Mon, Nov 27, 2017 at 5:01 PM, Khushboo Vashi <
 khushboo.va...@enterprisedb.com> wrote:

>
>
> On Mon, Nov 27, 2017 at 4:58 PM, Dave Page  wrote:
>
>>
>>
>> On Mon, Nov 27, 2017 at 11:26 AM, Khushboo Vashi <
>> khushboo.va...@enterprisedb.com> wrote:
>>
>>>
>>>
>>> On Mon, Nov 27, 2017 at 4:47 PM, Dave Page 
>>> wrote:
>>>


 On Mon, Nov 27, 2017 at 11:03 AM, Khushboo Vashi <
 khushboo.va...@enterprisedb.com> wrote:

>
>
> On Mon, Nov 27, 2017 at 4:13 PM, Dave Page 
> wrote:
>
>>
>>
>> On Mon, Nov 27, 2017 at 10:39 AM, Khushboo Vashi <
>> khushboo.va...@enterprisedb.com> wrote:
>>
>>>
>>>
>>> On Mon, Nov 27, 2017 at 2:59 PM, Dave Page 
>>> wrote:
>>>


 On Mon, Nov 27, 2017 at 9:19 AM, Khushboo Vashi <
 khushboo.va...@enterprisedb.com> wrote:

>
>
> On Mon, Nov 27, 2017 at 2:20 PM, Dave Page 
> wrote:
>
>>
>>
>> On Mon, Nov 27, 2017 at 5:25 AM, Khushboo Vashi <
>> khushboo.va...@enterprisedb.com> wrote:
>>
>>> Hi Dave,
>>>
>>> On Fri, Nov 24, 2017 at 3:21 PM, Dave Page <
>>> dp...@pgadmin.org> wrote:
>>>


 On Thu, Nov 23, 2017 at 10:43 AM, Khushboo Vashi <
 khushboo.va...@enterprisedb.com> wrote:

>
>
> On Thu, Nov 23, 2017 at 2:58 PM, Dave Page <
> dp...@pgadmin.org> wrote:
>
>> Hi
>>
>> On Thu, Nov 23, 2017 at 5:03 AM, Khushboo Vashi <
>> khushboo.va...@enterprisedb.com> wrote:
>>
>>> Hi,
>>>
>>> Please find the attached patch to fix RM #2859:  Can't
>>> create new user.
>>>
>>> The "User Management" dialogue footer was overlapping
>>> the back-grid table which has been fixed.
>>>
>>
>> If my screen is too small, it now looks like the attached
>> screenshot, which is really quite ugly.
>>
>> If we don't leave the bottom blank space then in case of
> error the error-message will shown on the grid itself and 
> user can't
> perform any task.
> Please refer the attached screen-shot for the same.
>

 Right, but we also can't have that space left blank like
 that. Can't we extend the scroll range of the grid? In other 
 words, always
 include space for an extra row or so, so it can scroll above 
 the error
 message, when, and only when a message is shown?


>>> Please find the attached screen-shot, If we always include
>>> an extra row.
>>> Suggestion please.
>>>
>>
>> I think that's much better, though still not ideal. What if
>> we made the error messages closable like other notifications?
>>
>> The error-messages in pgAdmin 4 are not closable, so it will
> not go with the flow.
>

 I meant to do it globally.

 Should I create the separate case for this?
>>>
>>
>> No, I don't think there's any need for that.
>>
>> Does it seem like it would solve the problem appropriately?
>>
>>
> It would lead us to more complexity
> 1. How can we keep track of the closed error messages for multiple
> fields?
>

 Do we need to?


> 2. We have validated backbone model on focus out/change, so we
> need to 

Re: [pgAdmin4][Patch]: RM-2859: Can't create new user

[Khushboo Vashi]

Hi Dave,

Please find the attached updated patch, which includes:

- The fix for this RM
- Close button for the error message, which is applicable globally

Thanks,
Khushboo

On Tue, Nov 28, 2017 at 4:18 PM, Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:

>
>
> On Tue, Nov 28, 2017 at 3:40 PM, Dave Page  wrote:
>
>>
>>
>> On Tue, Nov 28, 2017 at 7:10 AM, Khushboo Vashi <
>> khushboo.va...@enterprisedb.com> wrote:
>>
>>>
>>>
>>> On Mon, Nov 27, 2017 at 5:01 PM, Khushboo Vashi <
>>> khushboo.va...@enterprisedb.com> wrote:
>>>


 On Mon, Nov 27, 2017 at 4:58 PM, Dave Page  wrote:

>
>
> On Mon, Nov 27, 2017 at 11:26 AM, Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>>
>>
>> On Mon, Nov 27, 2017 at 4:47 PM, Dave Page  wrote:
>>
>>>
>>>
>>> On Mon, Nov 27, 2017 at 11:03 AM, Khushboo Vashi <
>>> khushboo.va...@enterprisedb.com> wrote:
>>>


 On Mon, Nov 27, 2017 at 4:13 PM, Dave Page 
 wrote:

>
>
> On Mon, Nov 27, 2017 at 10:39 AM, Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>>
>>
>> On Mon, Nov 27, 2017 at 2:59 PM, Dave Page 
>> wrote:
>>
>>>
>>>
>>> On Mon, Nov 27, 2017 at 9:19 AM, Khushboo Vashi <
>>> khushboo.va...@enterprisedb.com> wrote:
>>>


 On Mon, Nov 27, 2017 at 2:20 PM, Dave Page 
 wrote:

>
>
> On Mon, Nov 27, 2017 at 5:25 AM, Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>> Hi Dave,
>>
>> On Fri, Nov 24, 2017 at 3:21 PM, Dave Page > > wrote:
>>
>>>
>>>
>>> On Thu, Nov 23, 2017 at 10:43 AM, Khushboo Vashi <
>>> khushboo.va...@enterprisedb.com> wrote:
>>>


 On Thu, Nov 23, 2017 at 2:58 PM, Dave Page <
 dp...@pgadmin.org> wrote:

> Hi
>
> On Thu, Nov 23, 2017 at 5:03 AM, Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> Please find the attached patch to fix RM #2859:  Can't
>> create new user.
>>
>> The "User Management" dialogue footer was overlapping the
>> back-grid table which has been fixed.
>>
>
> If my screen is too small, it now looks like the attached
> screenshot, which is really quite ugly.
>
> If we don't leave the bottom blank space then in case of
 error the error-message will shown on the grid itself and user 
 can't
 perform any task.
 Please refer the attached screen-shot for the same.

>>>
>>> Right, but we also can't have that space left blank like
>>> that. Can't we extend the scroll range of the grid? In other 
>>> words, always
>>> include space for an extra row or so, so it can scroll above 
>>> the error
>>> message, when, and only when a message is shown?
>>>
>>>
>> Please find the attached screen-shot, If we always include an
>> extra row.
>> Suggestion please.
>>
>
> I think that's much better, though still not ideal. What if we
> made the error messages closable like other notifications?
>
> The error-messages in pgAdmin 4 are not closable, so it will
 not go with the flow.

>>>
>>> I meant to do it globally.
>>>
>>> Should I create the separate case for this?
>>
>
> No, I don't think there's any need for that.
>
> Does it seem like it would solve the problem appropriately?
>
>
 It would lead us to more complexity
 1. How can we keep track of the closed error messages for multiple
 fields?

>>>
>>> Do we need to?
>>>
>>>
 2. We have validated backbone model on focus out/change, so we need
 to change the basic error model.

>>>
>>> I'm not sure why. Can't we just have an X button on the error panel
>>> that will hide it? If another error occurs (e.g. because the user 
>>> changes
>>> focus), just re-display it.
>>>
>>>
>> This means, 

Re: [pgAdmin4][Patch]: RM-2859: Can't create new user

[Khushboo Vashi]

On Tue, Nov 28, 2017 at 3:40 PM, Dave Page  wrote:

>
>
> On Tue, Nov 28, 2017 at 7:10 AM, Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>>
>>
>> On Mon, Nov 27, 2017 at 5:01 PM, Khushboo Vashi <
>> khushboo.va...@enterprisedb.com> wrote:
>>
>>>
>>>
>>> On Mon, Nov 27, 2017 at 4:58 PM, Dave Page  wrote:
>>>


 On Mon, Nov 27, 2017 at 11:26 AM, Khushboo Vashi <
 khushboo.va...@enterprisedb.com> wrote:

>
>
> On Mon, Nov 27, 2017 at 4:47 PM, Dave Page  wrote:
>
>>
>>
>> On Mon, Nov 27, 2017 at 11:03 AM, Khushboo Vashi <
>> khushboo.va...@enterprisedb.com> wrote:
>>
>>>
>>>
>>> On Mon, Nov 27, 2017 at 4:13 PM, Dave Page 
>>> wrote:
>>>


 On Mon, Nov 27, 2017 at 10:39 AM, Khushboo Vashi <
 khushboo.va...@enterprisedb.com> wrote:

>
>
> On Mon, Nov 27, 2017 at 2:59 PM, Dave Page 
> wrote:
>
>>
>>
>> On Mon, Nov 27, 2017 at 9:19 AM, Khushboo Vashi <
>> khushboo.va...@enterprisedb.com> wrote:
>>
>>>
>>>
>>> On Mon, Nov 27, 2017 at 2:20 PM, Dave Page 
>>> wrote:
>>>


 On Mon, Nov 27, 2017 at 5:25 AM, Khushboo Vashi <
 khushboo.va...@enterprisedb.com> wrote:

> Hi Dave,
>
> On Fri, Nov 24, 2017 at 3:21 PM, Dave Page 
> wrote:
>
>>
>>
>> On Thu, Nov 23, 2017 at 10:43 AM, Khushboo Vashi <
>> khushboo.va...@enterprisedb.com> wrote:
>>
>>>
>>>
>>> On Thu, Nov 23, 2017 at 2:58 PM, Dave Page <
>>> dp...@pgadmin.org> wrote:
>>>
 Hi

 On Thu, Nov 23, 2017 at 5:03 AM, Khushboo Vashi <
 khushboo.va...@enterprisedb.com> wrote:

> Hi,
>
> Please find the attached patch to fix RM #2859:  Can't
> create new user.
>
> The "User Management" dialogue footer was overlapping the
> back-grid table which has been fixed.
>

 If my screen is too small, it now looks like the attached
 screenshot, which is really quite ugly.

 If we don't leave the bottom blank space then in case of
>>> error the error-message will shown on the grid itself and user 
>>> can't
>>> perform any task.
>>> Please refer the attached screen-shot for the same.
>>>
>>
>> Right, but we also can't have that space left blank like
>> that. Can't we extend the scroll range of the grid? In other 
>> words, always
>> include space for an extra row or so, so it can scroll above the 
>> error
>> message, when, and only when a message is shown?
>>
>>
> Please find the attached screen-shot, If we always include an
> extra row.
> Suggestion please.
>

 I think that's much better, though still not ideal. What if we
 made the error messages closable like other notifications?

 The error-messages in pgAdmin 4 are not closable, so it will
>>> not go with the flow.
>>>
>>
>> I meant to do it globally.
>>
>> Should I create the separate case for this?
>

 No, I don't think there's any need for that.

 Does it seem like it would solve the problem appropriately?


>>> It would lead us to more complexity
>>> 1. How can we keep track of the closed error messages for multiple
>>> fields?
>>>
>>
>> Do we need to?
>>
>>
>>> 2. We have validated backbone model on focus out/change, so we need
>>> to change the basic error model.
>>>
>>
>> I'm not sure why. Can't we just have an X button on the error panel
>> that will hide it? If another error occurs (e.g. because the user changes
>> focus), just re-display it.
>>
>>
> This means, if the error message is displayed for the field 1 and
> after closing if we go ahead without filling up the valid data, on the
> focus out; the same error message will be shown.
>

 Yes.


>
> I was thinking; if we have closed the error message for the field 1,
> then it will not display any kind of message for that particular field. 
> So,
> I have mentioned about the 

Re: [pgAdmin4][Patch]: RM-2859: Can't create new user

[Khushboo Vashi]

On Mon, Nov 27, 2017 at 5:01 PM, Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:

>
>
> On Mon, Nov 27, 2017 at 4:58 PM, Dave Page  wrote:
>
>>
>>
>> On Mon, Nov 27, 2017 at 11:26 AM, Khushboo Vashi <
>> khushboo.va...@enterprisedb.com> wrote:
>>
>>>
>>>
>>> On Mon, Nov 27, 2017 at 4:47 PM, Dave Page  wrote:
>>>


 On Mon, Nov 27, 2017 at 11:03 AM, Khushboo Vashi <
 khushboo.va...@enterprisedb.com> wrote:

>
>
> On Mon, Nov 27, 2017 at 4:13 PM, Dave Page  wrote:
>
>>
>>
>> On Mon, Nov 27, 2017 at 10:39 AM, Khushboo Vashi <
>> khushboo.va...@enterprisedb.com> wrote:
>>
>>>
>>>
>>> On Mon, Nov 27, 2017 at 2:59 PM, Dave Page 
>>> wrote:
>>>


 On Mon, Nov 27, 2017 at 9:19 AM, Khushboo Vashi <
 khushboo.va...@enterprisedb.com> wrote:

>
>
> On Mon, Nov 27, 2017 at 2:20 PM, Dave Page 
> wrote:
>
>>
>>
>> On Mon, Nov 27, 2017 at 5:25 AM, Khushboo Vashi <
>> khushboo.va...@enterprisedb.com> wrote:
>>
>>> Hi Dave,
>>>
>>> On Fri, Nov 24, 2017 at 3:21 PM, Dave Page 
>>> wrote:
>>>


 On Thu, Nov 23, 2017 at 10:43 AM, Khushboo Vashi <
 khushboo.va...@enterprisedb.com> wrote:

>
>
> On Thu, Nov 23, 2017 at 2:58 PM, Dave Page 
> wrote:
>
>> Hi
>>
>> On Thu, Nov 23, 2017 at 5:03 AM, Khushboo Vashi <
>> khushboo.va...@enterprisedb.com> wrote:
>>
>>> Hi,
>>>
>>> Please find the attached patch to fix RM #2859:  Can't
>>> create new user.
>>>
>>> The "User Management" dialogue footer was overlapping the
>>> back-grid table which has been fixed.
>>>
>>
>> If my screen is too small, it now looks like the attached
>> screenshot, which is really quite ugly.
>>
>> If we don't leave the bottom blank space then in case of
> error the error-message will shown on the grid itself and user 
> can't
> perform any task.
> Please refer the attached screen-shot for the same.
>

 Right, but we also can't have that space left blank like that.
 Can't we extend the scroll range of the grid? In other words, 
 always
 include space for an extra row or so, so it can scroll above the 
 error
 message, when, and only when a message is shown?


>>> Please find the attached screen-shot, If we always include an
>>> extra row.
>>> Suggestion please.
>>>
>>
>> I think that's much better, though still not ideal. What if we
>> made the error messages closable like other notifications?
>>
>> The error-messages in pgAdmin 4 are not closable, so it will not
> go with the flow.
>

 I meant to do it globally.

 Should I create the separate case for this?
>>>
>>
>> No, I don't think there's any need for that.
>>
>> Does it seem like it would solve the problem appropriately?
>>
>>
> It would lead us to more complexity
> 1. How can we keep track of the closed error messages for multiple
> fields?
>

 Do we need to?


> 2. We have validated backbone model on focus out/change, so we need to
> change the basic error model.
>

 I'm not sure why. Can't we just have an X button on the error panel
 that will hide it? If another error occurs (e.g. because the user changes
 focus), just re-display it.


>>> This means, if the error message is displayed for the field 1 and after
>>> closing if we go ahead without filling up the valid data, on the focus out;
>>> the same error message will be shown.
>>>
>>
>> Yes.
>>
>>
>>>
>>> I was thinking; if we have closed the error message for the field 1,
>>> then it will not display any kind of message for that particular field. So,
>>> I have mentioned about the complexity.
>>>
>>
>> I'm not convinced we need that level of complexity.
>>
>> Can you whip up a PoC so we can see how it behaves?
>>
>> Please find the attached patch.

This patch includes:
- The fix for this RM
- Close button for the error message for the User management module
- Close button for other node modules like server , schema etc

Thanks,
Khushboo

> Sure.
>
>>
>>
>
> I have attached the patch for the RM #2859.
>
> Thanks,
> Khushboo
>
> --
>> Dave 

Re: [pgAdmin4][Patch]: RM-2859: Can't create new user

[Khushboo Vashi]

On Mon, Nov 27, 2017 at 4:58 PM, Dave Page  wrote:

>
>
> On Mon, Nov 27, 2017 at 11:26 AM, Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>>
>>
>> On Mon, Nov 27, 2017 at 4:47 PM, Dave Page  wrote:
>>
>>>
>>>
>>> On Mon, Nov 27, 2017 at 11:03 AM, Khushboo Vashi <
>>> khushboo.va...@enterprisedb.com> wrote:
>>>


 On Mon, Nov 27, 2017 at 4:13 PM, Dave Page  wrote:

>
>
> On Mon, Nov 27, 2017 at 10:39 AM, Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>>
>>
>> On Mon, Nov 27, 2017 at 2:59 PM, Dave Page  wrote:
>>
>>>
>>>
>>> On Mon, Nov 27, 2017 at 9:19 AM, Khushboo Vashi <
>>> khushboo.va...@enterprisedb.com> wrote:
>>>


 On Mon, Nov 27, 2017 at 2:20 PM, Dave Page 
 wrote:

>
>
> On Mon, Nov 27, 2017 at 5:25 AM, Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>> Hi Dave,
>>
>> On Fri, Nov 24, 2017 at 3:21 PM, Dave Page 
>> wrote:
>>
>>>
>>>
>>> On Thu, Nov 23, 2017 at 10:43 AM, Khushboo Vashi <
>>> khushboo.va...@enterprisedb.com> wrote:
>>>


 On Thu, Nov 23, 2017 at 2:58 PM, Dave Page 
 wrote:

> Hi
>
> On Thu, Nov 23, 2017 at 5:03 AM, Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> Please find the attached patch to fix RM #2859:  Can't create
>> new user.
>>
>> The "User Management" dialogue footer was overlapping the
>> back-grid table which has been fixed.
>>
>
> If my screen is too small, it now looks like the attached
> screenshot, which is really quite ugly.
>
> If we don't leave the bottom blank space then in case of error
 the error-message will shown on the grid itself and user can't 
 perform any
 task.
 Please refer the attached screen-shot for the same.

>>>
>>> Right, but we also can't have that space left blank like that.
>>> Can't we extend the scroll range of the grid? In other words, always
>>> include space for an extra row or so, so it can scroll above the 
>>> error
>>> message, when, and only when a message is shown?
>>>
>>>
>> Please find the attached screen-shot, If we always include an
>> extra row.
>> Suggestion please.
>>
>
> I think that's much better, though still not ideal. What if we
> made the error messages closable like other notifications?
>
> The error-messages in pgAdmin 4 are not closable, so it will not
 go with the flow.

>>>
>>> I meant to do it globally.
>>>
>>> Should I create the separate case for this?
>>
>
> No, I don't think there's any need for that.
>
> Does it seem like it would solve the problem appropriately?
>
>
 It would lead us to more complexity
 1. How can we keep track of the closed error messages for multiple
 fields?

>>>
>>> Do we need to?
>>>
>>>
 2. We have validated backbone model on focus out/change, so we need to
 change the basic error model.

>>>
>>> I'm not sure why. Can't we just have an X button on the error panel that
>>> will hide it? If another error occurs (e.g. because the user changes
>>> focus), just re-display it.
>>>
>>>
>> This means, if the error message is displayed for the field 1 and after
>> closing if we go ahead without filling up the valid data, on the focus out;
>> the same error message will be shown.
>>
>
> Yes.
>
>
>>
>> I was thinking; if we have closed the error message for the field 1, then
>> it will not display any kind of message for that particular field. So, I
>> have mentioned about the complexity.
>>
>
> I'm not convinced we need that level of complexity.
>
> Can you whip up a PoC so we can see how it behaves?
>
> Sure.

>
>

 I have attached the patch for the RM #2859.

 Thanks,
 Khushboo

 --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>


>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The 

Re: [pgAdmin4][Patch]: RM-2859: Can't create new user

[Dave Page]

On Mon, Nov 27, 2017 at 11:26 AM, Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:

>
>
> On Mon, Nov 27, 2017 at 4:47 PM, Dave Page  wrote:
>
>>
>>
>> On Mon, Nov 27, 2017 at 11:03 AM, Khushboo Vashi <
>> khushboo.va...@enterprisedb.com> wrote:
>>
>>>
>>>
>>> On Mon, Nov 27, 2017 at 4:13 PM, Dave Page  wrote:
>>>


 On Mon, Nov 27, 2017 at 10:39 AM, Khushboo Vashi <
 khushboo.va...@enterprisedb.com> wrote:

>
>
> On Mon, Nov 27, 2017 at 2:59 PM, Dave Page  wrote:
>
>>
>>
>> On Mon, Nov 27, 2017 at 9:19 AM, Khushboo Vashi <
>> khushboo.va...@enterprisedb.com> wrote:
>>
>>>
>>>
>>> On Mon, Nov 27, 2017 at 2:20 PM, Dave Page 
>>> wrote:
>>>


 On Mon, Nov 27, 2017 at 5:25 AM, Khushboo Vashi <
 khushboo.va...@enterprisedb.com> wrote:

> Hi Dave,
>
> On Fri, Nov 24, 2017 at 3:21 PM, Dave Page 
> wrote:
>
>>
>>
>> On Thu, Nov 23, 2017 at 10:43 AM, Khushboo Vashi <
>> khushboo.va...@enterprisedb.com> wrote:
>>
>>>
>>>
>>> On Thu, Nov 23, 2017 at 2:58 PM, Dave Page 
>>> wrote:
>>>
 Hi

 On Thu, Nov 23, 2017 at 5:03 AM, Khushboo Vashi <
 khushboo.va...@enterprisedb.com> wrote:

> Hi,
>
> Please find the attached patch to fix RM #2859:  Can't create
> new user.
>
> The "User Management" dialogue footer was overlapping the
> back-grid table which has been fixed.
>

 If my screen is too small, it now looks like the attached
 screenshot, which is really quite ugly.

 If we don't leave the bottom blank space then in case of error
>>> the error-message will shown on the grid itself and user can't 
>>> perform any
>>> task.
>>> Please refer the attached screen-shot for the same.
>>>
>>
>> Right, but we also can't have that space left blank like that.
>> Can't we extend the scroll range of the grid? In other words, always
>> include space for an extra row or so, so it can scroll above the 
>> error
>> message, when, and only when a message is shown?
>>
>>
> Please find the attached screen-shot, If we always include an
> extra row.
> Suggestion please.
>

 I think that's much better, though still not ideal. What if we made
 the error messages closable like other notifications?

 The error-messages in pgAdmin 4 are not closable, so it will not go
>>> with the flow.
>>>
>>
>> I meant to do it globally.
>>
>> Should I create the separate case for this?
>

 No, I don't think there's any need for that.

 Does it seem like it would solve the problem appropriately?


>>> It would lead us to more complexity
>>> 1. How can we keep track of the closed error messages for multiple
>>> fields?
>>>
>>
>> Do we need to?
>>
>>
>>> 2. We have validated backbone model on focus out/change, so we need to
>>> change the basic error model.
>>>
>>
>> I'm not sure why. Can't we just have an X button on the error panel that
>> will hide it? If another error occurs (e.g. because the user changes
>> focus), just re-display it.
>>
>>
> This means, if the error message is displayed for the field 1 and after
> closing if we go ahead without filling up the valid data, on the focus out;
> the same error message will be shown.
>

Yes.


>
> I was thinking; if we have closed the error message for the field 1, then
> it will not display any kind of message for that particular field. So, I
> have mentioned about the complexity.
>

I'm not convinced we need that level of complexity.

Can you whip up a PoC so we can see how it behaves?



>
>>> I have attached the patch for the RM #2859.
>>>
>>> Thanks,
>>> Khushboo
>>>
>>> --
 Dave Page
 Blog: http://pgsnake.blogspot.com
 Twitter: @pgsnake

 EnterpriseDB UK: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company

>>>
>>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgAdmin4][Patch]: RM-2859: Can't create new user

[Khushboo Vashi]

On Mon, Nov 27, 2017 at 4:47 PM, Dave Page  wrote:

>
>
> On Mon, Nov 27, 2017 at 11:03 AM, Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>>
>>
>> On Mon, Nov 27, 2017 at 4:13 PM, Dave Page  wrote:
>>
>>>
>>>
>>> On Mon, Nov 27, 2017 at 10:39 AM, Khushboo Vashi <
>>> khushboo.va...@enterprisedb.com> wrote:
>>>


 On Mon, Nov 27, 2017 at 2:59 PM, Dave Page  wrote:

>
>
> On Mon, Nov 27, 2017 at 9:19 AM, Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>>
>>
>> On Mon, Nov 27, 2017 at 2:20 PM, Dave Page  wrote:
>>
>>>
>>>
>>> On Mon, Nov 27, 2017 at 5:25 AM, Khushboo Vashi <
>>> khushboo.va...@enterprisedb.com> wrote:
>>>
 Hi Dave,

 On Fri, Nov 24, 2017 at 3:21 PM, Dave Page 
 wrote:

>
>
> On Thu, Nov 23, 2017 at 10:43 AM, Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>>
>>
>> On Thu, Nov 23, 2017 at 2:58 PM, Dave Page 
>> wrote:
>>
>>> Hi
>>>
>>> On Thu, Nov 23, 2017 at 5:03 AM, Khushboo Vashi <
>>> khushboo.va...@enterprisedb.com> wrote:
>>>
 Hi,

 Please find the attached patch to fix RM #2859:  Can't create
 new user.

 The "User Management" dialogue footer was overlapping the
 back-grid table which has been fixed.

>>>
>>> If my screen is too small, it now looks like the attached
>>> screenshot, which is really quite ugly.
>>>
>>> If we don't leave the bottom blank space then in case of error
>> the error-message will shown on the grid itself and user can't 
>> perform any
>> task.
>> Please refer the attached screen-shot for the same.
>>
>
> Right, but we also can't have that space left blank like that.
> Can't we extend the scroll range of the grid? In other words, always
> include space for an extra row or so, so it can scroll above the error
> message, when, and only when a message is shown?
>
>
 Please find the attached screen-shot, If we always include an extra
 row.
 Suggestion please.

>>>
>>> I think that's much better, though still not ideal. What if we made
>>> the error messages closable like other notifications?
>>>
>>> The error-messages in pgAdmin 4 are not closable, so it will not go
>> with the flow.
>>
>
> I meant to do it globally.
>
> Should I create the separate case for this?

>>>
>>> No, I don't think there's any need for that.
>>>
>>> Does it seem like it would solve the problem appropriately?
>>>
>>>
>> It would lead us to more complexity
>> 1. How can we keep track of the closed error messages for multiple fields?
>>
>
> Do we need to?
>
>
>> 2. We have validated backbone model on focus out/change, so we need to
>> change the basic error model.
>>
>
> I'm not sure why. Can't we just have an X button on the error panel that
> will hide it? If another error occurs (e.g. because the user changes
> focus), just re-display it.
>
>
This means, if the error message is displayed for the field 1 and after
closing if we go ahead without filling up the valid data, on the focus out;
the same error message will be shown.

I was thinking; if we have closed the error message for the field 1, then
it will not display any kind of message for that particular field. So, I
have mentioned about the complexity.

>
>> I have attached the patch for the RM #2859.
>>
>> Thanks,
>> Khushboo
>>
>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Re: [pgAdmin4][Patch]: RM-2859: Can't create new user

[Dave Page]

On Mon, Nov 27, 2017 at 11:03 AM, Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:

>
>
> On Mon, Nov 27, 2017 at 4:13 PM, Dave Page  wrote:
>
>>
>>
>> On Mon, Nov 27, 2017 at 10:39 AM, Khushboo Vashi <
>> khushboo.va...@enterprisedb.com> wrote:
>>
>>>
>>>
>>> On Mon, Nov 27, 2017 at 2:59 PM, Dave Page  wrote:
>>>


 On Mon, Nov 27, 2017 at 9:19 AM, Khushboo Vashi <
 khushboo.va...@enterprisedb.com> wrote:

>
>
> On Mon, Nov 27, 2017 at 2:20 PM, Dave Page  wrote:
>
>>
>>
>> On Mon, Nov 27, 2017 at 5:25 AM, Khushboo Vashi <
>> khushboo.va...@enterprisedb.com> wrote:
>>
>>> Hi Dave,
>>>
>>> On Fri, Nov 24, 2017 at 3:21 PM, Dave Page 
>>> wrote:
>>>


 On Thu, Nov 23, 2017 at 10:43 AM, Khushboo Vashi <
 khushboo.va...@enterprisedb.com> wrote:

>
>
> On Thu, Nov 23, 2017 at 2:58 PM, Dave Page 
> wrote:
>
>> Hi
>>
>> On Thu, Nov 23, 2017 at 5:03 AM, Khushboo Vashi <
>> khushboo.va...@enterprisedb.com> wrote:
>>
>>> Hi,
>>>
>>> Please find the attached patch to fix RM #2859:  Can't create
>>> new user.
>>>
>>> The "User Management" dialogue footer was overlapping the
>>> back-grid table which has been fixed.
>>>
>>
>> If my screen is too small, it now looks like the attached
>> screenshot, which is really quite ugly.
>>
>> If we don't leave the bottom blank space then in case of error
> the error-message will shown on the grid itself and user can't 
> perform any
> task.
> Please refer the attached screen-shot for the same.
>

 Right, but we also can't have that space left blank like that.
 Can't we extend the scroll range of the grid? In other words, always
 include space for an extra row or so, so it can scroll above the error
 message, when, and only when a message is shown?


>>> Please find the attached screen-shot, If we always include an extra
>>> row.
>>> Suggestion please.
>>>
>>
>> I think that's much better, though still not ideal. What if we made
>> the error messages closable like other notifications?
>>
>> The error-messages in pgAdmin 4 are not closable, so it will not go
> with the flow.
>

 I meant to do it globally.

 Should I create the separate case for this?
>>>
>>
>> No, I don't think there's any need for that.
>>
>> Does it seem like it would solve the problem appropriately?
>>
>>
> It would lead us to more complexity
> 1. How can we keep track of the closed error messages for multiple fields?
>

Do we need to?


> 2. We have validated backbone model on focus out/change, so we need to
> change the basic error model.
>

I'm not sure why. Can't we just have an X button on the error panel that
will hide it? If another error occurs (e.g. because the user changes
focus), just re-display it.


>
>
> I have attached the patch for the RM #2859.
>
> Thanks,
> Khushboo
>
> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgAdmin4][Patch]: RM-2859: Can't create new user

[Khushboo Vashi]

On Mon, Nov 27, 2017 at 4:13 PM, Dave Page  wrote:

>
>
> On Mon, Nov 27, 2017 at 10:39 AM, Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>>
>>
>> On Mon, Nov 27, 2017 at 2:59 PM, Dave Page  wrote:
>>
>>>
>>>
>>> On Mon, Nov 27, 2017 at 9:19 AM, Khushboo Vashi <
>>> khushboo.va...@enterprisedb.com> wrote:
>>>


 On Mon, Nov 27, 2017 at 2:20 PM, Dave Page  wrote:

>
>
> On Mon, Nov 27, 2017 at 5:25 AM, Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>> Hi Dave,
>>
>> On Fri, Nov 24, 2017 at 3:21 PM, Dave Page  wrote:
>>
>>>
>>>
>>> On Thu, Nov 23, 2017 at 10:43 AM, Khushboo Vashi <
>>> khushboo.va...@enterprisedb.com> wrote:
>>>


 On Thu, Nov 23, 2017 at 2:58 PM, Dave Page 
 wrote:

> Hi
>
> On Thu, Nov 23, 2017 at 5:03 AM, Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> Please find the attached patch to fix RM #2859:  Can't create new
>> user.
>>
>> The "User Management" dialogue footer was overlapping the
>> back-grid table which has been fixed.
>>
>
> If my screen is too small, it now looks like the attached
> screenshot, which is really quite ugly.
>
> If we don't leave the bottom blank space then in case of error the
 error-message will shown on the grid itself and user can't perform any 
 task.
 Please refer the attached screen-shot for the same.

>>>
>>> Right, but we also can't have that space left blank like that. Can't
>>> we extend the scroll range of the grid? In other words, always include
>>> space for an extra row or so, so it can scroll above the error message,
>>> when, and only when a message is shown?
>>>
>>>
>> Please find the attached screen-shot, If we always include an extra
>> row.
>> Suggestion please.
>>
>
> I think that's much better, though still not ideal. What if we made
> the error messages closable like other notifications?
>
> The error-messages in pgAdmin 4 are not closable, so it will not go
 with the flow.

>>>
>>> I meant to do it globally.
>>>
>>> Should I create the separate case for this?
>>
>
> No, I don't think there's any need for that.
>
> Does it seem like it would solve the problem appropriately?
>
>
It would lead us to more complexity
1. How can we keep track of the closed error messages for multiple fields?
2. We have validated backbone model on focus out/change, so we need to
change the basic error model.


I have attached the patch for the RM #2859.

Thanks,
Khushboo

-- 
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
diff --git a/web/pgadmin/static/css/bootstrap.overrides.css b/web/pgadmin/static/css/bootstrap.overrides.css
index b894021..6e3e580 100755
--- a/web/pgadmin/static/css/bootstrap.overrides.css
+++ b/web/pgadmin/static/css/bootstrap.overrides.css
@@ -1218,6 +1218,11 @@ height: calc(100% - 35px);
   line-height: 16px;
 }
 
+.user_management table tbody tr.blank_row {
+  visibility: hidden;
+  height: 35px;
+}
+
 .pg-panel-statistics-container >table.backgrid.table-bordered {
   border: 0px;
 }
diff --git a/web/pgadmin/tools/user_management/static/js/user_management.js b/web/pgadmin/tools/user_management/static/js/user_management.js
index ffdf8b2..4ae738c 100644
--- a/web/pgadmin/tools/user_management/static/js/user_management.js
+++ b/web/pgadmin/tools/user_management/static/js/user_management.js
@@ -392,8 +392,8 @@ define([
   prepare: function() {
 var self = this,
   footerTpl = _.template([
-'',
-  '',
+'',
+  '',
 '',
   '',
 '',
@@ -405,8 +405,7 @@ define([
 '',
   '',
 ''].join("\n")),
-  $footer = $(footerTpl()),
-  $statusBar = $footer.find('.pg-prop-status-bar'),
+  $statusBar = $(footerTpl()),
   UserRow = Backgrid.Row.extend({
 userInvalidColor: "lightYellow",
 
@@ -558,7 +557,7 @@ define([
 
 this.$content = $("").append(
 headerTpl(data)).append($gridBody
-).append($footer);
+).append($statusBar);
 
 $(this.elements.body.childNodes[0]).addClass(
   'alertify_tools_dialog_backgrid_properties');
@@ -569,7 +568,12 @@ define([
 $('.search_users').append(
  

Re: [pgAdmin4][Patch]: RM-2859: Can't create new user

[Dave Page]

On Mon, Nov 27, 2017 at 10:39 AM, Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:

>
>
> On Mon, Nov 27, 2017 at 2:59 PM, Dave Page  wrote:
>
>>
>>
>> On Mon, Nov 27, 2017 at 9:19 AM, Khushboo Vashi <
>> khushboo.va...@enterprisedb.com> wrote:
>>
>>>
>>>
>>> On Mon, Nov 27, 2017 at 2:20 PM, Dave Page  wrote:
>>>


 On Mon, Nov 27, 2017 at 5:25 AM, Khushboo Vashi <
 khushboo.va...@enterprisedb.com> wrote:

> Hi Dave,
>
> On Fri, Nov 24, 2017 at 3:21 PM, Dave Page  wrote:
>
>>
>>
>> On Thu, Nov 23, 2017 at 10:43 AM, Khushboo Vashi <
>> khushboo.va...@enterprisedb.com> wrote:
>>
>>>
>>>
>>> On Thu, Nov 23, 2017 at 2:58 PM, Dave Page 
>>> wrote:
>>>
 Hi

 On Thu, Nov 23, 2017 at 5:03 AM, Khushboo Vashi <
 khushboo.va...@enterprisedb.com> wrote:

> Hi,
>
> Please find the attached patch to fix RM #2859:  Can't create new
> user.
>
> The "User Management" dialogue footer was overlapping the
> back-grid table which has been fixed.
>

 If my screen is too small, it now looks like the attached
 screenshot, which is really quite ugly.

 If we don't leave the bottom blank space then in case of error the
>>> error-message will shown on the grid itself and user can't perform any 
>>> task.
>>> Please refer the attached screen-shot for the same.
>>>
>>
>> Right, but we also can't have that space left blank like that. Can't
>> we extend the scroll range of the grid? In other words, always include
>> space for an extra row or so, so it can scroll above the error message,
>> when, and only when a message is shown?
>>
>>
> Please find the attached screen-shot, If we always include an extra
> row.
> Suggestion please.
>

 I think that's much better, though still not ideal. What if we made the
 error messages closable like other notifications?

 The error-messages in pgAdmin 4 are not closable, so it will not go
>>> with the flow.
>>>
>>
>> I meant to do it globally.
>>
>> Should I create the separate case for this?
>

No, I don't think there's any need for that.

Does it seem like it would solve the problem appropriately?

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgAdmin4][Patch]: RM-2859: Can't create new user

[Khushboo Vashi]

On Mon, Nov 27, 2017 at 2:59 PM, Dave Page  wrote:

>
>
> On Mon, Nov 27, 2017 at 9:19 AM, Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>>
>>
>> On Mon, Nov 27, 2017 at 2:20 PM, Dave Page  wrote:
>>
>>>
>>>
>>> On Mon, Nov 27, 2017 at 5:25 AM, Khushboo Vashi <
>>> khushboo.va...@enterprisedb.com> wrote:
>>>
 Hi Dave,

 On Fri, Nov 24, 2017 at 3:21 PM, Dave Page  wrote:

>
>
> On Thu, Nov 23, 2017 at 10:43 AM, Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>>
>>
>> On Thu, Nov 23, 2017 at 2:58 PM, Dave Page  wrote:
>>
>>> Hi
>>>
>>> On Thu, Nov 23, 2017 at 5:03 AM, Khushboo Vashi <
>>> khushboo.va...@enterprisedb.com> wrote:
>>>
 Hi,

 Please find the attached patch to fix RM #2859:  Can't create new
 user.

 The "User Management" dialogue footer was overlapping the back-grid
 table which has been fixed.

>>>
>>> If my screen is too small, it now looks like the attached
>>> screenshot, which is really quite ugly.
>>>
>>> If we don't leave the bottom blank space then in case of error the
>> error-message will shown on the grid itself and user can't perform any 
>> task.
>> Please refer the attached screen-shot for the same.
>>
>
> Right, but we also can't have that space left blank like that. Can't
> we extend the scroll range of the grid? In other words, always include
> space for an extra row or so, so it can scroll above the error message,
> when, and only when a message is shown?
>
>
 Please find the attached screen-shot, If we always include an extra
 row.
 Suggestion please.

>>>
>>> I think that's much better, though still not ideal. What if we made the
>>> error messages closable like other notifications?
>>>
>>> The error-messages in pgAdmin 4 are not closable, so it will not go with
>> the flow.
>>
>
> I meant to do it globally.
>
> Should I create the separate case for this?

>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Re: [pgAdmin4][Patch]: RM-2859: Can't create new user

[Dave Page]

On Mon, Nov 27, 2017 at 9:19 AM, Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:

>
>
> On Mon, Nov 27, 2017 at 2:20 PM, Dave Page  wrote:
>
>>
>>
>> On Mon, Nov 27, 2017 at 5:25 AM, Khushboo Vashi <
>> khushboo.va...@enterprisedb.com> wrote:
>>
>>> Hi Dave,
>>>
>>> On Fri, Nov 24, 2017 at 3:21 PM, Dave Page  wrote:
>>>


 On Thu, Nov 23, 2017 at 10:43 AM, Khushboo Vashi <
 khushboo.va...@enterprisedb.com> wrote:

>
>
> On Thu, Nov 23, 2017 at 2:58 PM, Dave Page  wrote:
>
>> Hi
>>
>> On Thu, Nov 23, 2017 at 5:03 AM, Khushboo Vashi <
>> khushboo.va...@enterprisedb.com> wrote:
>>
>>> Hi,
>>>
>>> Please find the attached patch to fix RM #2859:  Can't create new
>>> user.
>>>
>>> The "User Management" dialogue footer was overlapping the back-grid
>>> table which has been fixed.
>>>
>>
>> If my screen is too small, it now looks like the attached screenshot,
>> which is really quite ugly.
>>
>> If we don't leave the bottom blank space then in case of error the
> error-message will shown on the grid itself and user can't perform any 
> task.
> Please refer the attached screen-shot for the same.
>

 Right, but we also can't have that space left blank like that. Can't we
 extend the scroll range of the grid? In other words, always include space
 for an extra row or so, so it can scroll above the error message, when, and
 only when a message is shown?


>>> Please find the attached screen-shot, If we always include an extra row.
>>> Suggestion please.
>>>
>>
>> I think that's much better, though still not ideal. What if we made the
>> error messages closable like other notifications?
>>
>> The error-messages in pgAdmin 4 are not closable, so it will not go with
> the flow.
>

I meant to do it globally.


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgAdmin4][Patch]: RM-2859: Can't create new user

[Khushboo Vashi]

On Mon, Nov 27, 2017 at 2:20 PM, Dave Page  wrote:

>
>
> On Mon, Nov 27, 2017 at 5:25 AM, Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>> Hi Dave,
>>
>> On Fri, Nov 24, 2017 at 3:21 PM, Dave Page  wrote:
>>
>>>
>>>
>>> On Thu, Nov 23, 2017 at 10:43 AM, Khushboo Vashi <
>>> khushboo.va...@enterprisedb.com> wrote:
>>>


 On Thu, Nov 23, 2017 at 2:58 PM, Dave Page  wrote:

> Hi
>
> On Thu, Nov 23, 2017 at 5:03 AM, Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> Please find the attached patch to fix RM #2859:  Can't create new
>> user.
>>
>> The "User Management" dialogue footer was overlapping the back-grid
>> table which has been fixed.
>>
>
> If my screen is too small, it now looks like the attached screenshot,
> which is really quite ugly.
>
> If we don't leave the bottom blank space then in case of error the
 error-message will shown on the grid itself and user can't perform any 
 task.
 Please refer the attached screen-shot for the same.

>>>
>>> Right, but we also can't have that space left blank like that. Can't we
>>> extend the scroll range of the grid? In other words, always include space
>>> for an extra row or so, so it can scroll above the error message, when, and
>>> only when a message is shown?
>>>
>>>
>> Please find the attached screen-shot, If we always include an extra row.
>> Suggestion please.
>>
>
> I think that's much better, though still not ideal. What if we made the
> error messages closable like other notifications?
>
> The error-messages in pgAdmin 4 are not closable, so it will not go with
the flow.

>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Re: [pgAdmin4][Patch]: RM-2859: Can't create new user

[Khushboo Vashi]

Hi Dave,

On Fri, Nov 24, 2017 at 3:21 PM, Dave Page  wrote:

>
>
> On Thu, Nov 23, 2017 at 10:43 AM, Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>>
>>
>> On Thu, Nov 23, 2017 at 2:58 PM, Dave Page  wrote:
>>
>>> Hi
>>>
>>> On Thu, Nov 23, 2017 at 5:03 AM, Khushboo Vashi <
>>> khushboo.va...@enterprisedb.com> wrote:
>>>
 Hi,

 Please find the attached patch to fix RM #2859:  Can't create new user.

 The "User Management" dialogue footer was overlapping the back-grid
 table which has been fixed.

>>>
>>> If my screen is too small, it now looks like the attached screenshot,
>>> which is really quite ugly.
>>>
>>> If we don't leave the bottom blank space then in case of error the
>> error-message will shown on the grid itself and user can't perform any task.
>> Please refer the attached screen-shot for the same.
>>
>
> Right, but we also can't have that space left blank like that. Can't we
> extend the scroll range of the grid? In other words, always include space
> for an extra row or so, so it can scroll above the error message, when, and
> only when a message is shown?
>
>
Please find the attached screen-shot, If we always include an extra row.
Suggestion please.

-- 
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Re: [pgAdmin4][Patch]: RM-2859: Can't create new user

[Khushboo Vashi]

On Thu, Nov 23, 2017 at 2:58 PM, Dave Page  wrote:

> Hi
>
> On Thu, Nov 23, 2017 at 5:03 AM, Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> Please find the attached patch to fix RM #2859:  Can't create new user.
>>
>> The "User Management" dialogue footer was overlapping the back-grid table
>> which has been fixed.
>>
>
> If my screen is too small, it now looks like the attached screenshot,
> which is really quite ugly.
>
> If we don't leave the bottom blank space then in case of error the
error-message will shown on the grid itself and user can't perform any task.
Please refer the attached screen-shot for the same.

-- 
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Re: [pgAdmin4][Patch]: RM-2859: Can't create new user

[Dave Page]

Hi

On Thu, Nov 23, 2017 at 5:03 AM, Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:

> Hi,
>
> Please find the attached patch to fix RM #2859:  Can't create new user.
>
> The "User Management" dialogue footer was overlapping the back-grid table
> which has been fixed.
>

If my screen is too small, it now looks like the attached screenshot, which
is really quite ugly.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

[pgAdmin4][Patch]: RM-2859: Can't create new user

[Khushboo Vashi]

Hi,

Please find the attached patch to fix RM #2859:  Can't create new user.

The "User Management" dialogue footer was overlapping the back-grid table
which has been fixed.

Thanks,
Khushboo
diff --git a/web/pgadmin/static/css/bootstrap.overrides.css b/web/pgadmin/static/css/bootstrap.overrides.css
index 73b4fc7..a64e85b 100755
--- a/web/pgadmin/static/css/bootstrap.overrides.css
+++ b/web/pgadmin/static/css/bootstrap.overrides.css
@@ -1177,7 +1177,7 @@ form[name="change_password_form"] .help-block {
 .user_management {
   margin: 0 10px !important;
   width: calc(100% - 20px);
-  height: 100%;
+  height: calc(100% - 40px);
   overflow: hidden;
 }
 
@@ -1187,7 +1187,7 @@ form[name="change_password_form"] .help-block {
 
 .user_management table {
   display: block;
-  height: 100%;
+  height: calc(100% - 10px);
   overflow: auto;
   border: 0 none;
 }
diff --git a/web/pgadmin/tools/user_management/static/js/user_management.js b/web/pgadmin/tools/user_management/static/js/user_management.js
index ffdf8b2..ee8701a 100644
--- a/web/pgadmin/tools/user_management/static/js/user_management.js
+++ b/web/pgadmin/tools/user_management/static/js/user_management.js
@@ -386,6 +386,7 @@ define([
 // clear our backform model/view
 this.view.remove({data: true, internal: true, silent: true});
 this.$content.remove();
+this.$footer.remove();
   }
 }
   },
@@ -404,9 +405,9 @@ define([
   '',
 '',
   '',
-''].join("\n")),
-  $footer = $(footerTpl()),
-  $statusBar = $footer.find('.pg-prop-status-bar'),
+''].join("\n"));
+  self.$footer = $(footerTpl());
+  var $statusBar = self.$footer.find('.pg-prop-status-bar'),
   UserRow = Backgrid.Row.extend({
 userInvalidColor: "lightYellow",
 
@@ -558,12 +559,14 @@ define([
 
 this.$content = $("").append(
 headerTpl(data)).append($gridBody
-).append($footer);
+);
 
 $(this.elements.body.childNodes[0]).addClass(
   'alertify_tools_dialog_backgrid_properties');
 
 this.elements.content.appendChild(this.$content[0]);
+this.elements.content.appendChild(this.$footer[0]);
+
 
 // Render Search Filter
 $('.search_users').append(