Release this week?
Anyone have any reasons why we shouldn't push a release this week using the new automated build system (assuming they work as planned and no issues are found in QA)? -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Re: [pgadmin4][Patch]: Feature #3273 Add ability to sort in the Select File window when opening a saved query
Hi
On Fri, Jun 22, 2018 at 6:39 AM, Akshay Joshi wrote:
>
>
> On Thu, Jun 21, 2018 at 11:57 PM, Dave Page wrote:
>
>> Hi
>>
>> On Thu, Jun 21, 2018 at 6:27 AM, Akshay Joshi <
>> akshay.jo...@enterprisedb.com> wrote:
>>
>>>
>>>
>>> On Thu, Jun 21, 2018 at 6:20 AM, Dave Page wrote:
>>>
Hi
On Wed, Jun 20, 2018 at 3:13 PM, Akshay Joshi <
akshay.jo...@enterprisedb.com> wrote:
> Hi Hackers,
>
> Attached is the patch for Feature #3273 Add ability to sort in the
> Select File window when opening a saved query.
>
> I haven't seen any refactoring possibility, patch contains feature
> test with *time.sleep(0.05). *I have spend lot of time to not
> introduce "time.sleep()" and tried couple of different ways of
> WebDriveWait, but didn't get success.
>
> Please review it.
>
I get the following running the feature tests:
invalid syntax (xss_checks_file_manager_test.py, line 60)
make: *** [check-feature] Error 1
Fixed.
>>>
>>>
Also; should that file be renamed now, to reflect that it tests more
than just XSS?
>>>
>>> Done. Attached is the modified patch.
>>>
>>
>> This seems to work for the most part, however, when sorting on the
>> Modified column, it is sorting alphabetically, not by date. This doesn't
>> seem like it's what users would expect.
>>
>
> Attached is the modified patch with the above fix.
>
>>
I'm seeing the following failure pretty consistently:
==
ERROR: runTest
(pgadmin.feature_tests.file_manager_test.CheckFileManagerFeatureTest)
File manager feature test
--
Traceback (most recent call last):
File
"/Users/dpage/git/pgadmin4/web/regression/feature_utils/base_feature_test.py",
line 66, in tearDown
self.after()
File
"/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/file_manager_test.py",
line 48, in after
self.page.close_query_tool('sql', False)
File
"/Users/dpage/git/pgadmin4/web/regression/feature_utils/pgadmin_page.py",
line 104, in close_query_tool
"//li[contains(@class, 'context-menu-item')]/span[contains(text(),"
File
"/Users/dpage/git/pgadmin4/web/regression/feature_utils/pgadmin_page.py",
line 171, in find_by_xpath
lambda driver: driver.find_element_by_xpath(xpath)
File
"/Users/dpage/git/pgadmin4/web/regression/feature_utils/pgadmin_page.py",
line 263, in wait_for_element
return self._wait_for("element to exist", element_if_it_exists)
File
"/Users/dpage/git/pgadmin4/web/regression/feature_utils/pgadmin_page.py",
line 337, in _wait_for
"Timed out waiting for " + waiting_for_message
File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packages/selenium/webdriver/support/wait.py",
line 80, in until
raise TimeoutException(message, screen, stacktrace)
selenium.common.exceptions.TimeoutException: Message: Timed out waiting for
element to exist
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Re: [pgadmin4][Patch]: Feature #3273 Add ability to sort in the Select File window when opening a saved query
On Mon, Jun 25, 2018 at 4:43 PM, Dave Page wrote:
> Hi
>
> On Fri, Jun 22, 2018 at 6:39 AM, Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>>
>>
>> On Thu, Jun 21, 2018 at 11:57 PM, Dave Page wrote:
>>
>>> Hi
>>>
>>> On Thu, Jun 21, 2018 at 6:27 AM, Akshay Joshi <
>>> akshay.jo...@enterprisedb.com> wrote:
>>>
On Thu, Jun 21, 2018 at 6:20 AM, Dave Page wrote:
> Hi
>
> On Wed, Jun 20, 2018 at 3:13 PM, Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Hi Hackers,
>>
>> Attached is the patch for Feature #3273 Add ability to sort in the
>> Select File window when opening a saved query.
>>
>> I haven't seen any refactoring possibility, patch contains feature
>> test with *time.sleep(0.05). *I have spend lot of time to not
>> introduce "time.sleep()" and tried couple of different ways of
>> WebDriveWait, but didn't get success.
>>
>> Please review it.
>>
>
> I get the following running the feature tests:
>
> invalid syntax (xss_checks_file_manager_test.py, line 60)
>
> make: *** [check-feature] Error 1
>
>Fixed.
> Also; should that file be renamed now, to reflect that it tests more
> than just XSS?
>
Done. Attached is the modified patch.
>>>
>>> This seems to work for the most part, however, when sorting on the
>>> Modified column, it is sorting alphabetically, not by date. This doesn't
>>> seem like it's what users would expect.
>>>
>>
>> Attached is the modified patch with the above fix.
>>
>>>
> I'm seeing the following failure pretty consistently:
>
> ==
>
> ERROR: runTest (pgadmin.feature_tests.file_manager_test.
> CheckFileManagerFeatureTest)
>
> File manager feature test
>
> --
>
> Traceback (most recent call last):
>
> File
> "/Users/dpage/git/pgadmin4/web/regression/feature_utils/base_feature_test.py",
> line 66, in tearDown
>
> self.after()
>
> File
> "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/file_manager_test.py",
> line 48, in after
>
> self.page.close_query_tool('sql', False)
>
> File
> "/Users/dpage/git/pgadmin4/web/regression/feature_utils/pgadmin_page.py",
> line 104, in close_query_tool
>
> "//li[contains(@class, 'context-menu-item')]/span[contains(text(),"
>
> File
> "/Users/dpage/git/pgadmin4/web/regression/feature_utils/pgadmin_page.py",
> line 171, in find_by_xpath
>
> lambda driver: driver.find_element_by_xpath(xpath)
>
> File
> "/Users/dpage/git/pgadmin4/web/regression/feature_utils/pgadmin_page.py",
> line 263, in wait_for_element
>
> return self._wait_for("element to exist", element_if_it_exists)
>
> File
> "/Users/dpage/git/pgadmin4/web/regression/feature_utils/pgadmin_page.py",
> line 337, in _wait_for
>
> "Timed out waiting for " + waiting_for_message
>
> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-
> packages/selenium/webdriver/support/wait.py", line 80, in until
>
> raise TimeoutException(message, screen, stacktrace)
>
> selenium.common.exceptions.TimeoutException: Message: Timed out waiting
> for element to exist
>
>
It's a Timed out issue and I haven't faced this on my machine. As per
above traceback it is failing on "self.page.close_query_tool()" which is
not the part of this patch and not reproducible either on my machine.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
--
*Akshay Joshi*
*Sr. Software Architect *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
Re: Release this week?
Shipit On Mon, Jun 25, 2018, 10:37 AM Dave Page wrote: > Anyone have any reasons why we shouldn't push a release this week using > the new automated build system (assuming they work as planned and no issues > are found in QA)? > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company >
[pgAdmin4][Patch] - RM #3309 - Backup does not work with --format=d
Hi,
Please find the attached patch for RM #3309 - Backup does not work with
--format=d.
Fixes in the patch :
1. Format = directory fix for Backup and Restore utilities
2. Test cases for format = directory
2. File manager fix - The selected directory was not properly populated in
the text box
3. Refactoring of File manager JS file
Thanks,
Khushboo
diff --git a/web/pgadmin/misc/file_manager/static/js/create_dialogue.js b/web/pgadmin/misc/file_manager/static/js/create_dialogue.js
new file mode 100644
index 000..8deb720
--- /dev/null
+++ b/web/pgadmin/misc/file_manager/static/js/create_dialogue.js
@@ -0,0 +1,162 @@
+import gettext from 'sources/gettext';
+import url_for from 'sources/url_for';
+import $ from 'jquery';
+import Alertify from 'pgadmin.alertifyjs';
+import pgAdmin from 'sources/pgadmin';
+import {removeTransId, set_last_traversed_dir} from './helpers';
+
+// Declare the Create mode dialog
+module.exports = Alertify.dialog('createModeDlg', function() {
+ // Dialog property
+ return {
+setup: function() {
+ return {
+buttons: [{
+ text: gettext('Create'),
+ key: 13,
+ className: 'btn btn-primary fa fa-file file_manager_create file_manager_ok pg-alertify-button disabled',
+},
+{
+ text: gettext('Cancel'),
+ key: 27,
+ className: 'btn btn-danger fa fa-times file_manager_create_cancel pg-alertify-button',
+},
+],
+focus: {
+ element: 0,
+},
+options: {
+ closableByDimmer: false,
+ maximizable: false,
+ closable: false,
+ movable: true,
+},
+ };
+},
+replace_file: function() {
+ var $yesBtn = $('.replace_file .btn_yes'),
+$noBtn = $('.replace_file .btn_no');
+
+ $('.storage_dialog #uploader .input-path').attr('disabled', true);
+ $('.file_manager_ok').addClass('disabled');
+ $('.replace_file, .fm_dimmer').show();
+
+ $yesBtn.on('click',() => {
+$('.replace_file, .fm_dimmer').hide();
+$yesBtn.off();
+$noBtn.off();
+var newFile = $('.storage_dialog #uploader .input-path').val();
+
+pgAdmin.Browser.Events.trigger('pgadmin-storage:finish_btn:create_file', newFile);
+$('.file_manager_create_cancel').trigger('click');
+$('.storage_dialog #uploader .input-path').attr('disabled', false);
+$('.file_manager_ok').removeClass('disabled');
+ });
+
+ $noBtn.on('click',() => {
+$('.replace_file, .fm_dimmer').hide();
+$yesBtn.off();
+$noBtn.off();
+$('.storage_dialog #uploader .input-path').attr('disabled', false);
+$('.file_manager_ok').removeClass('disabled');
+ });
+},
+is_file_exist: function() {
+ var full_path = $('.storage_dialog #uploader .input-path').val(),
+path = full_path.substr(0, full_path.lastIndexOf('/') + 1),
+selected_item = full_path.substr(full_path.lastIndexOf('/') + 1),
+is_exist = false;
+
+ var file_data = {
+'path': path,
+'name': selected_item,
+'mode': 'is_file_exist',
+ };
+
+ $.ajax({
+type: 'POST',
+data: JSON.stringify(file_data),
+url: url_for('file_manager.filemanager', {
+ 'trans_id': this.trans_id,
+}),
+dataType: 'json',
+contentType: 'application/x-download; charset=utf-8',
+async: false,
+success: function(resp) {
+ var data = resp.data.result;
+ if (data['Code'] === 1) {
+is_exist = true;
+ } else {
+is_exist = false;
+ }
+},
+ });
+ return is_exist;
+},
+check_permission: function(path) {
+ var permission = false,
+post_data = {
+ 'path': path,
+ 'mode': 'permission',
+};
+
+ $.ajax({
+type: 'POST',
+data: JSON.stringify(post_data),
+url: url_for('file_manager.filemanager', {
+ 'trans_id': this.trans_id,
+}),
+dataType: 'json',
+contentType: 'application/json; charset=utf-8',
+async: false,
+success: function(resp) {
+ var data = resp.data.result;
+ if (data.Code === 1) {
+permission = true;
+ } else {
+$('.file_manager_ok').addClass('disabled');
+Alertify.error(data.Error);
+ }
+},
+error: function() {
+ $('.file_manager_ok').addClass('disabled');
+ Alertify.error(gettext('Error occurred while checking access permission.'));
+},
+ });
+ return permission;
+},
+callback: function(closeEvent) {
+ if (closeEvent.button.text == gettext('Create')) {
+var newFile = $('.storage_dialog #uploader .input-path').val(),
+ file_data = {
+'path': $('.currentpath').val(),
+ },
+ innerbody;
+
+if (!this.check_p
pgAdmin 4 commit: Allow sorting in the file dialogue. Fixes #3273
Allow sorting in the file dialogue. Fixes #3273 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1f5ca1b540e96374e26a09051433e3e6a71b5c21 Author: Akshay Joshi Modified Files -- docs/en_US/release_notes_3_1.rst | 1 + web/package.json | 1 + ...s_file_manager_test.py => file_manager_test.py} | 40 - .../misc/file_manager/static/css/file_manager.css | 51 +- web/pgadmin/misc/file_manager/static/js/utility.js | 16 +-- web/yarn.lock | 8 +++- 6 files changed, 100 insertions(+), 17 deletions(-)
Re: [pgadmin4][Patch]: Feature #3273 Add ability to sort in the Select File window when opening a saved query
On Mon, Jun 25, 2018 at 12:23 PM, Akshay Joshi <
akshay.jo...@enterprisedb.com> wrote:
>
>
> On Mon, Jun 25, 2018 at 4:43 PM, Dave Page wrote:
>
>> Hi
>>
>> On Fri, Jun 22, 2018 at 6:39 AM, Akshay Joshi <
>> akshay.jo...@enterprisedb.com> wrote:
>>
>>>
>>>
>>> On Thu, Jun 21, 2018 at 11:57 PM, Dave Page wrote:
>>>
Hi
On Thu, Jun 21, 2018 at 6:27 AM, Akshay Joshi <
akshay.jo...@enterprisedb.com> wrote:
>
>
> On Thu, Jun 21, 2018 at 6:20 AM, Dave Page wrote:
>
>> Hi
>>
>> On Wed, Jun 20, 2018 at 3:13 PM, Akshay Joshi <
>> akshay.jo...@enterprisedb.com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Attached is the patch for Feature #3273 Add ability to sort in the
>>> Select File window when opening a saved query.
>>>
>>> I haven't seen any refactoring possibility, patch contains feature
>>> test with *time.sleep(0.05). *I have spend lot of time to not
>>> introduce "time.sleep()" and tried couple of different ways of
>>> WebDriveWait, but didn't get success.
>>>
>>> Please review it.
>>>
>>
>> I get the following running the feature tests:
>>
>> invalid syntax (xss_checks_file_manager_test.py, line 60)
>>
>> make: *** [check-feature] Error 1
>>
>>Fixed.
>
>
>> Also; should that file be renamed now, to reflect that it tests more
>> than just XSS?
>>
>
> Done. Attached is the modified patch.
>
This seems to work for the most part, however, when sorting on the
Modified column, it is sorting alphabetically, not by date. This doesn't
seem like it's what users would expect.
>>>
>>> Attached is the modified patch with the above fix.
>>>
>> I'm seeing the following failure pretty consistently:
>>
>> ==
>>
>> ERROR: runTest (pgadmin.feature_tests.file_ma
>> nager_test.CheckFileManagerFeatureTest)
>>
>> File manager feature test
>>
>> --
>>
>> Traceback (most recent call last):
>>
>> File
>> "/Users/dpage/git/pgadmin4/web/regression/feature_utils/base_feature_test.py",
>> line 66, in tearDown
>>
>> self.after()
>>
>> File
>> "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/file_manager_test.py",
>> line 48, in after
>>
>> self.page.close_query_tool('sql', False)
>>
>> File
>> "/Users/dpage/git/pgadmin4/web/regression/feature_utils/pgadmin_page.py",
>> line 104, in close_query_tool
>>
>> "//li[contains(@class, 'context-menu-item')]/span[contains(text(),"
>>
>> File
>> "/Users/dpage/git/pgadmin4/web/regression/feature_utils/pgadmin_page.py",
>> line 171, in find_by_xpath
>>
>> lambda driver: driver.find_element_by_xpath(xpath)
>>
>> File
>> "/Users/dpage/git/pgadmin4/web/regression/feature_utils/pgadmin_page.py",
>> line 263, in wait_for_element
>>
>> return self._wait_for("element to exist", element_if_it_exists)
>>
>> File
>> "/Users/dpage/git/pgadmin4/web/regression/feature_utils/pgadmin_page.py",
>> line 337, in _wait_for
>>
>> "Timed out waiting for " + waiting_for_message
>>
>> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packa
>> ges/selenium/webdriver/support/wait.py", line 80, in until
>>
>> raise TimeoutException(message, screen, stacktrace)
>>
>> selenium.common.exceptions.TimeoutException: Message: Timed out waiting
>> for element to exist
>>
>>
>It's a Timed out issue and I haven't faced this on my machine. As per
> above traceback it is failing on "self.page.close_query_tool()" which is
> not the part of this patch and not reproducible either on my machine.
>
True. I've pushed the patch, and will setup a call to figure out how to
resolve these issues as they are becoming a real pain.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
pgAdmin 4 commit: Various EPAS/PG11 function & procedure fixes. Fixes #
Various EPAS/PG11 function & procedure fixes. Fixes #3421. Fixes #3422 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4a71c6d7af9eb3386c651b890af2dee5c1406988 Author: Akshay Joshi Modified Files -- .../function/ppas/sql/11_plus/coll_stats.sql | 20 +++ .../templates/function/ppas/sql/11_plus/delete.sql | 22 .../function/ppas/sql/11_plus/get_definition.sql | 15 + .../function/ppas/sql/11_plus/get_oid.sql | 17 ++ .../templates/function/ppas/sql/11_plus/node.sql | 23 + .../function/ppas/sql/11_plus/properties.sql | 32 ++ .../procedure/ppas/sql/11_plus/coll_stats.sql | 20 +++ .../procedure/ppas/sql/11_plus/delete.sql | 21 .../procedure/ppas/sql/11_plus/get_definition.sql | 15 + .../procedure/ppas/sql/11_plus/get_oid.sql | 17 ++ .../templates/procedure/ppas/sql/11_plus/node.sql | 29 .../procedure/ppas/sql/11_plus/properties.sql | 39 ++ .../ppas/sql/11_plus/coll_stats.sql| 20 +++ .../trigger_function/ppas/sql/11_plus/delete.sql | 21 .../ppas/sql/11_plus/get_definition.sql| 15 + .../trigger_function/ppas/sql/11_plus/get_oid.sql | 18 ++ .../trigger_function/ppas/sql/11_plus/node.sql | 22 .../ppas/sql/11_plus/properties.sql| 32 ++ .../schemas/tables/partitions/__init__.py | 2 ++ .../sqlautocomplete/sql/11_plus/functions.sql | 30 + web/pgadmin/tools/grant_wizard/__init__.py | 6 ++-- .../grant_wizard/pg/11_plus/sql/function.sql | 26 +++ .../grant_wizard/ppas/11_plus/sql/function.sql | 26 +++ 23 files changed, 486 insertions(+), 2 deletions(-)
Re: [pgadmin4][Patch]: PG/EPAS 11 fixes for functions, procedures and trigger functions
Thanks, applied. On Fri, Jun 22, 2018 at 2:16 PM, Akshay Joshi wrote: > Hi Hackers > > Attached is the patch to fix following: > >- RM #3421 Function is not displayed in grant wizard screen and >message displayed. >- RM #3422 procedure is not displayed in grant wizard screen >- PG/EPAS 11 function query for auto complete. >- Added support for functions, procedures and trigger function for EPAS >11. >- Fixed issue to expand table for EPAS 9.6 and below due to change in >backend support logic. > > I have run the regression test on PG/EPAS: 9.6, 10, 11. > -- > *Akshay Joshi* > > *Sr. Software Architect * > > > > *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
[pgadmin4][Patch]: Fixed RM 3442, 3443, 3444 Drop options not available.
Hi Hackers, Attached is the patch to RM 3442, 3443 and 3444 related to Drop options not available for Collations, Packages, Synonyms, Rules, Check Constraint and Domain Constraints. This are regressions. Please review it. -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* RM_3442_3443_3444.patch Description: Binary data
Re: [pgAdmin4][Patch] - RM #3309 - Backup does not work with --format=d
Hi On Mon, Jun 25, 2018 at 1:23 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch for RM #3309 - Backup does not work with > --format=d. > > Fixes in the patch : > > 1. Format = directory fix for Backup and Restore utilities > 2. Test cases for format = directory > 2. File manager fix - The selected directory was not properly populated in > the text box > The patch disables the file picker button if you select Directory format. This seems like poor behaviour; I think we need to modify the dialogue to allow a directory to be selected. > 3. Refactoring of File manager JS file > That's somewhat more readable. Can we add tests? -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Re: [pgAdmin4][Patch] - RM #3309 - Backup does not work with --format=d
On Mon, 25 Jun 2018, 19:47 Dave Page, wrote: > Hi > > On Mon, Jun 25, 2018 at 1:23 PM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> Please find the attached patch for RM #3309 - Backup does not work with >> --format=d. >> >> Fixes in the patch : >> >> 1. Format = directory fix for Backup and Restore utilities >> 2. Test cases for format = directory >> 2. File manager fix - The selected directory was not properly populated >> in the text box >> > > The patch disables the file picker button if you select Directory format. > This seems like poor behaviour; I think we need to modify the dialogue to > allow a directory to be selected. > > In the directory format, which ever the folder name given, that will be created by pg_dump, so I have disabled it. > 3. Refactoring of File manager JS file >> > > That's somewhat more readable. Can we add tests? > Will look into it. > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company >
Re: [pgAdmin4][Patch] - RM #3309 - Backup does not work with --format=d
On Mon, Jun 25, 2018 at 3:33 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Mon, 25 Jun 2018, 19:47 Dave Page, wrote: > >> Hi >> >> On Mon, Jun 25, 2018 at 1:23 PM, Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> Hi, >>> >>> Please find the attached patch for RM #3309 - Backup does not work with >>> --format=d. >>> >>> Fixes in the patch : >>> >>> 1. Format = directory fix for Backup and Restore utilities >>> 2. Test cases for format = directory >>> 2. File manager fix - The selected directory was not properly populated >>> in the text box >>> >> >> The patch disables the file picker button if you select Directory format. >> This seems like poor behaviour; I think we need to modify the dialogue to >> allow a directory to be selected. >> >> > In the directory format, which ever the folder name given, that will be > created by pg_dump, so I have disabled it. > Sure, but I can't even browse to the location I want to put it now - I have to manually type in the path. We just need to allow selection of the directory that will contain the directory. > 3. Refactoring of File manager JS file >>> >> >> That's somewhat more readable. Can we add tests? >> > Will look into it. > Thanks. > >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
pgAdmin 4 commit: Fix various Drop menu options that were broken during
Fix various Drop menu options that were broken during the treeview refactoring. Fixes #3442. Fixes #3443. Fixes #3444 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=57c054fb0ef52c79294fde55dcb8efedf5b4b409 Author: Akshay Joshi Modified Files -- .../databases/schemas/collations/static/js/collation.js | 3 --- .../domain_constraints/static/js/domain_constraints.js| 6 +++--- .../databases/schemas/functions/static/js/procedure.js| 11 --- .../servers/databases/schemas/packages/static/js/package.js | 9 +++-- .../servers/databases/schemas/static/js/child.js | 10 -- .../servers/databases/schemas/synonyms/static/js/synonym.js | 7 +++ .../check_constraint/static/js/check_constraint.js| 6 +++--- .../servers/databases/schemas/tables/rules/static/js/rule.js | 11 ++- 8 files changed, 26 insertions(+), 37 deletions(-)
Re: [pgadmin4][Patch]: Fixed RM 3442, 3443, 3444 Drop options not available.
Thanks, applied. On Mon, Jun 25, 2018 at 3:08 PM, Akshay Joshi wrote: > Hi Hackers, > > Attached is the patch to RM 3442, 3443 and 3444 related to Drop options > not available for Collations, Packages, Synonyms, Rules, Check Constraint > and Domain Constraints. > > This are regressions. Please review it. > > -- > *Akshay Joshi* > > *Sr. Software Architect * > > > > *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
pgAdmin 4 commit: Require v1.1 of the pldbgapi extension to debug on EP
Require v1.1 of the pldbgapi extension to debug on EPAS 11. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=cf29e8df90ebfb8221e457863a281d7ed5f22faa Author: Akshay Joshi Modified Files -- web/pgadmin/tools/debugger/__init__.py | 16 1 file changed, 16 insertions(+)
pgAdmin 4 commit: Correct version comparison, per Khushboo.
Correct version comparison, per Khushboo. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5bdd80e3da36b9d37c4e0420799e5664db343d29 Modified Files -- web/pgadmin/tools/debugger/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
pgAdmin 4 commit: Don't use imple variable notation in bash scripts.
Don't use imple variable notation in bash scripts. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=27bb7ff5db2be892c9a7aa8880a01a907572a7e1 Modified Files -- ci/build_docs.sh| 8 ci/build_pip_wheel.sh | 8 ci/build_runtime_qt4.sh | 8 ci/build_runtime_qt5.sh | 8 ci/build_tarballs.sh| 10 +- ci/ci_runner.sh | 18 +- ci/create_config.sh | 16 ci/run_feature_tests.sh | 24 ci/run_jasmine_tests.sh | 2 +- ci/run_python_tests.sh | 22 +++--- ci/update_messages.sh | 4 ++-- 11 files changed, 64 insertions(+), 64 deletions(-)
pgAdmin 4 commit: Updated extension upgrade message. Fixes #3445
Updated extension upgrade message. Fixes #3445 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=08e4cdf2ac5c843e383e7cf1603c144d181517ce Modified Files -- web/pgadmin/tools/debugger/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
